Re: [Cython] Migration of tickets from trac to github

2016-07-29 Thread Robert Bradshaw
On Thu, Jul 28, 2016 at 10:15 PM, Yury V. Zaytsev  wrote:
> On Thu, 28 Jul 2016, Robert Bradshaw wrote:
>
>>> When I click on one of the "migrated from" links to "trac.cython.org", I
>>> get redirected back to github, but with the trac ticket number, which means
>>> I get either a 404 or a totally different ticket on github. I guess that can
>>> be fixed once we have a mapping from trac ticket numbers to github tickets.
>>
>>
>> Yep. Had we not had any issues, we could have maybe kept the numbers, but
>> it's too late for that now.
>
>
> Just an idea: one could, of course, disable issues for the main cython
> repository and create a separate repository like `cython-issues`. Not sure
> if it's worth it though...

That's an idea, though then we'd loose things like pull request
linkage and have to migrate the issues that are already there. I think
it's worth having a bounded amount of "odd" history with a "standard"
setup going forward.
___
cython-devel mailing list
cython-devel@python.org
https://mail.python.org/mailman/listinfo/cython-devel


Re: [Cython] Migration of tickets from trac to github

2016-07-29 Thread Jeroen Demeyer

On 2016-07-29 06:50, Robert Bradshaw wrote:

I'm not quite sure how to serve the mappings


I think it's really important to keep redirects from the old Trac 
tickets to GitHub. There are a lot of links from SageMath to some Cython 
Trac ticket and it would be a shame to lose that.



Related to that: converted ticket #73 has a reference to another trac
ticket (#51) in a comment, which now links to the (wrong) github ticket #51.
https://github.com/robertwb/issues-import-test/issues/73


Hmm... I should spell that out.


Just make the link explicit to trac.cython.org...
___
cython-devel mailing list
cython-devel@python.org
https://mail.python.org/mailman/listinfo/cython-devel


Re: [Cython] Migration of tickets from trac to github

2016-07-29 Thread Jeroen Demeyer

There are some duplicates, like
https://github.com/robertwb/issues-import-test/issues/130
and
https://github.com/robertwb/issues-import-test/issues/137
___
cython-devel mailing list
cython-devel@python.org
https://mail.python.org/mailman/listinfo/cython-devel


Re: [Cython] Migration of tickets from trac to github

2016-07-29 Thread Yury V. Zaytsev

On Fri, 29 Jul 2016, Robert Bradshaw wrote:

That's an idea, though then we'd loose things like pull request linkage 
and have to migrate the issues that are already there.


Not that I'm advocating for this option, but pull request linkage will 
stay in place: disabling issues doesn't disable pull requests. Also, 
references to the old issues might remain valid, although I'm not so sure 
about that.


Anyways, on GitHub, you can reference issues across the repositories, so 
for migrated issues one could just use that, which brings me neatly to the 
next point:


One could also consider migrating Trac to a separate issues-only 
repository under Cython account for historical / archiving / cross-linking 
purposes, and agreeing to freeze it going forward. From that point on one 
might just start making full use of issues under the main repository...


P.S. If you don't want to hear more stupid proposals, please let me know.

--
Sincerely yours,
Yury V. Zaytsev
___
cython-devel mailing list
cython-devel@python.org
https://mail.python.org/mailman/listinfo/cython-devel


Re: [Cython] Migration of tickets from trac to github

2016-07-29 Thread Robert Bradshaw
On Fri, Jul 29, 2016 at 12:46 AM, Jeroen Demeyer  wrote:
> On 2016-07-29 06:50, Robert Bradshaw wrote:
>>
>> I'm not quite sure how to serve the mappings
>
> I think it's really important to keep redirects from the old Trac tickets to
> GitHub. There are a lot of links from SageMath to some Cython Trac ticket
> and it would be a shame to lose that.

Yes. I figured out how to do redirects (e.g.
http://trac.cython.org/ticket/32 ). Now to generate the tickets and
get the mappings...

>>> Related to that: converted ticket #73 has a reference to another trac
>>> ticket (#51) in a comment, which now links to the (wrong) github ticket
>>> #51.
>>> https://github.com/robertwb/issues-import-test/issues/73
>>
>>
>> Hmm... I should spell that out.
>
> Just make the link explicit to trac.cython.org...

Yep.
___
cython-devel mailing list
cython-devel@python.org
https://mail.python.org/mailman/listinfo/cython-devel


Re: [Cython] Migration of tickets from trac to github

2016-07-29 Thread Robert Bradshaw
Yes, several. I was intentionally re-importing the same ranges to see
how things looked.

On Fri, Jul 29, 2016 at 12:49 AM, Jeroen Demeyer  wrote:
> There are some duplicates, like
> https://github.com/robertwb/issues-import-test/issues/130
> and
> https://github.com/robertwb/issues-import-test/issues/137
>
> ___
> cython-devel mailing list
> cython-devel@python.org
> https://mail.python.org/mailman/listinfo/cython-devel
___
cython-devel mailing list
cython-devel@python.org
https://mail.python.org/mailman/listinfo/cython-devel


Re: [Cython] Migration of tickets from trac to github

2016-07-29 Thread Jeroen Demeyer
What about attachments to Trac tickets? This ones mentions a patch, but 
the patch does not appear on GitHub as far as I can tell:


https://github.com/robertwb/issues-import-test/issues/122
___
cython-devel mailing list
cython-devel@python.org
https://mail.python.org/mailman/listinfo/cython-devel


Re: [Cython] Migration of tickets from trac to github

2016-07-29 Thread Robert Bradshaw
No, this didn't do attachments. It'd be good to get a handle on how
large a loss that would be for Cython (for Sage attachments are key).

I also just discovered
https://gist.github.com/jonmagic/5282384165e0f86ef105 which looks like
it might be a better solution.

On Fri, Jul 29, 2016 at 1:23 AM, Jeroen Demeyer  wrote:
> What about attachments to Trac tickets? This ones mentions a patch, but the
> patch does not appear on GitHub as far as I can tell:
>
> https://github.com/robertwb/issues-import-test/issues/122
>
> ___
> cython-devel mailing list
> cython-devel@python.org
> https://mail.python.org/mailman/listinfo/cython-devel
___
cython-devel mailing list
cython-devel@python.org
https://mail.python.org/mailman/listinfo/cython-devel


Re: [Cython] Migration of tickets from trac to github

2016-07-29 Thread Jeroen Demeyer

We should also about a convention about naming testsuite files.

For example, there is
tests/compile/distutils_libraries_T845.srctree

Should this be changed to
tests/compile/distutils_libraries_GH1234.srctree

if this becomes GitHub issue #1234?
___
cython-devel mailing list
cython-devel@python.org
https://mail.python.org/mailman/listinfo/cython-devel


Re: [Cython] BUG: cannot override cdef by cpdef method in .pxd

2016-07-29 Thread Jeroen Demeyer

Fixed with a 1-line change:
https://github.com/cython/cython/pull/545
___
cython-devel mailing list
cython-devel@python.org
https://mail.python.org/mailman/listinfo/cython-devel