(tapestry-5) branch master updated: TAP5-2769: fixing hardcoded references to ASM packages
This is an automated email from the ASF dual-hosted git repository.
thiagohp pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tapestry-5.git
The following commit(s) were added to refs/heads/master by this push:
new fa1b44e79 TAP5-2769: fixing hardcoded references to ASM packages
fa1b44e79 is described below
commit fa1b44e79b23c5774eb800976996ffa36ac3c06a
Author: Thiago H. de Paula Figueiredo
AuthorDate: Wed Jan 31 23:15:55 2024 -0300
TAP5-2769: fixing hardcoded references to ASM packages
---
.../java/org/apache/tapestry5/internal/plastic/asm/Constants.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
a/plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Constants.java
b/plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Constants.java
index 80a025c44..2c51aefc4 100644
---
a/plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Constants.java
+++
b/plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Constants.java
@@ -191,15 +191,15 @@ final class Constants {
}
static boolean isWhitelisted(final String internalName) {
-if (!internalName.startsWith("org/objectweb/asm/")) {
+if
(!internalName.startsWith("org/apache/tapestry5/internal/plastic/asm/")) {
return false;
}
String member =
"(Annotation|Class|Field|Method|Module|RecordComponent|Signature)";
return internalName.contains("Test$")
|| Pattern.matches(
-"org/objectweb/asm/util/Trace" + member + "Visitor(\\$.*)?",
internalName)
+"org/apache/tapestry5/internal/plastic/asm/util/Trace" + member +
"Visitor(\\$.*)?", internalName)
|| Pattern.matches(
-"org/objectweb/asm/util/Check" + member + "Adapter(\\$.*)?",
internalName);
+"org/apache/tapestry5/internal/plastic/asm/util/Check" + member +
"Adapter(\\$.*)?", internalName);
}
static void checkIsPreview(final InputStream classInputStream) {
[jira] [Commented] (TAP5-2769) Upgrade ASM to 9.6 to allow running on Java 21
[
https://issues.apache.org/jira/browse/TAP5-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813007#comment-17813007
]
ASF subversion and git services commented on TAP5-2769:
---
Commit fa1b44e79b23c5774eb800976996ffa36ac3c06a in tapestry-5's branch
refs/heads/master from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=fa1b44e79 ]
TAP5-2769: fixing hardcoded references to ASM packages
> Upgrade ASM to 9.6 to allow running on Java 21
> --
>
> Key: TAP5-2769
> URL: https://issues.apache.org/jira/browse/TAP5-2769
> Project: Tapestry 5
> Issue Type: Task
> Components: plastic
>Affects Versions: 5.8.3
>Reporter: Chris Poulsen
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.4
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> I have a local version where the shadowing of ASM is done by Gradle to easier
> maintain the ASM copy in the future.
> I'll create a PR with the changes on Github.
> The copied version had a single change to the ASM sources (in order to access
> the static package protected method
> {code:java}
> AnnotationNode.accept
> {code}
> .
> I did a quick hack with reflection to access it instead, there is definitely
> room for improvement there, if anyone wants to take a stab at it.
> Edit: PR https://github.com/apache/tapestry-5/pull/46
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2769) Upgrade ASM to 9.6 to allow running on Java 21
[
https://issues.apache.org/jira/browse/TAP5-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813008#comment-17813008
]
Hudson commented on TAP5-2769:
--
FAILURE: Integrated in Jenkins build Tapestry »
tapestry-java-11-temurin-freestyle #19 (See
[https://ci-builds.apache.org/job/Tapestry/job/tapestry-java-11-temurin-freestyle/19/])
TAP5-2769: fixing hardcoded references to ASM packages (thiago: rev
fa1b44e79b23c5774eb800976996ffa36ac3c06a)
* (edit)
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Constants.java
> Upgrade ASM to 9.6 to allow running on Java 21
> --
>
> Key: TAP5-2769
> URL: https://issues.apache.org/jira/browse/TAP5-2769
> Project: Tapestry 5
> Issue Type: Task
> Components: plastic
>Affects Versions: 5.8.3
>Reporter: Chris Poulsen
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.4
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> I have a local version where the shadowing of ASM is done by Gradle to easier
> maintain the ASM copy in the future.
> I'll create a PR with the changes on Github.
> The copied version had a single change to the ASM sources (in order to access
> the static package protected method
> {code:java}
> AnnotationNode.accept
> {code}
> .
> I did a quick hack with reflection to access it instead, there is definitely
> room for improvement there, if anyone wants to take a stab at it.
> Edit: PR https://github.com/apache/tapestry-5/pull/46
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2769) Upgrade ASM to 9.6 to allow running on Java 21
[
https://issues.apache.org/jira/browse/TAP5-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813012#comment-17813012
]
Hudson commented on TAP5-2769:
--
FAILURE: Integrated in Jenkins build Tapestry » tapestry-java-8-freestyle #47
(See
[https://ci-builds.apache.org/job/Tapestry/job/tapestry-java-8-freestyle/47/])
TAP5-2769: fixing hardcoded references to ASM packages (thiago: rev
fa1b44e79b23c5774eb800976996ffa36ac3c06a)
* (edit)
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Constants.java
> Upgrade ASM to 9.6 to allow running on Java 21
> --
>
> Key: TAP5-2769
> URL: https://issues.apache.org/jira/browse/TAP5-2769
> Project: Tapestry 5
> Issue Type: Task
> Components: plastic
>Affects Versions: 5.8.3
>Reporter: Chris Poulsen
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.4
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> I have a local version where the shadowing of ASM is done by Gradle to easier
> maintain the ASM copy in the future.
> I'll create a PR with the changes on Github.
> The copied version had a single change to the ASM sources (in order to access
> the static package protected method
> {code:java}
> AnnotationNode.accept
> {code}
> .
> I did a quick hack with reflection to access it instead, there is definitely
> room for improvement there, if anyone wants to take a stab at it.
> Edit: PR https://github.com/apache/tapestry-5/pull/46
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
(tapestry-5) branch master updated: Fixing test so it runs correctly on Java 17+.
This is an automated email from the ASF dual-hosted git repository.
thiagohp pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tapestry-5.git
The following commit(s) were added to refs/heads/master by this push:
new ccf1459fc Fixing test so it runs correctly on Java 17+.
ccf1459fc is described below
commit ccf1459fc411b2c10897d3d9f1b6ebe35b3229cf
Author: Thiago H. de Paula Figueiredo
AuthorDate: Wed Jan 31 23:33:49 2024 -0300
Fixing test so it runs correctly on Java 17+.
ioc.specs.StrategyRegistrySpec.access to types registered
---
tapestry-ioc/src/test/groovy/ioc/specs/StrategyRegistrySpec.groovy | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tapestry-ioc/src/test/groovy/ioc/specs/StrategyRegistrySpec.groovy
b/tapestry-ioc/src/test/groovy/ioc/specs/StrategyRegistrySpec.groovy
index 0b0cde4b1..9bf66cd52 100644
--- a/tapestry-ioc/src/test/groovy/ioc/specs/StrategyRegistrySpec.groovy
+++ b/tapestry-ioc/src/test/groovy/ioc/specs/StrategyRegistrySpec.groovy
@@ -42,7 +42,7 @@ class StrategyRegistrySpec extends Specification {
then:
-sr.types.size == 2
+sr.types.size() == 2
sr.types.containsAll(List, Map)
}
[jira] [Commented] (TAP5-2769) Upgrade ASM to 9.6 to allow running on Java 21
[
https://issues.apache.org/jira/browse/TAP5-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813015#comment-17813015
]
Hudson commented on TAP5-2769:
--
FAILURE: Integrated in Jenkins build Tapestry »
tapestry-java-17-temurin-freestyle #18 (See
[https://ci-builds.apache.org/job/Tapestry/job/tapestry-java-17-temurin-freestyle/18/])
TAP5-2769: fixing hardcoded references to ASM packages (thiago: rev
fa1b44e79b23c5774eb800976996ffa36ac3c06a)
* (edit)
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Constants.java
> Upgrade ASM to 9.6 to allow running on Java 21
> --
>
> Key: TAP5-2769
> URL: https://issues.apache.org/jira/browse/TAP5-2769
> Project: Tapestry 5
> Issue Type: Task
> Components: plastic
>Affects Versions: 5.8.3
>Reporter: Chris Poulsen
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.4
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> I have a local version where the shadowing of ASM is done by Gradle to easier
> maintain the ASM copy in the future.
> I'll create a PR with the changes on Github.
> The copied version had a single change to the ASM sources (in order to access
> the static package protected method
> {code:java}
> AnnotationNode.accept
> {code}
> .
> I did a quick hack with reflection to access it instead, there is definitely
> room for improvement there, if anyone wants to take a stab at it.
> Edit: PR https://github.com/apache/tapestry-5/pull/46
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2769) Upgrade ASM to 9.6 to allow running on Java 21
[
https://issues.apache.org/jira/browse/TAP5-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813018#comment-17813018
]
Hudson commented on TAP5-2769:
--
FAILURE: Integrated in Jenkins build Tapestry » tapestry-java-19-freestyle #43
(See
[https://ci-builds.apache.org/job/Tapestry/job/tapestry-java-19-freestyle/43/])
TAP5-2769: fixing hardcoded references to ASM packages (thiago: rev
fa1b44e79b23c5774eb800976996ffa36ac3c06a)
* (edit)
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Constants.java
> Upgrade ASM to 9.6 to allow running on Java 21
> --
>
> Key: TAP5-2769
> URL: https://issues.apache.org/jira/browse/TAP5-2769
> Project: Tapestry 5
> Issue Type: Task
> Components: plastic
>Affects Versions: 5.8.3
>Reporter: Chris Poulsen
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.4
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> I have a local version where the shadowing of ASM is done by Gradle to easier
> maintain the ASM copy in the future.
> I'll create a PR with the changes on Github.
> The copied version had a single change to the ASM sources (in order to access
> the static package protected method
> {code:java}
> AnnotationNode.accept
> {code}
> .
> I did a quick hack with reflection to access it instead, there is definitely
> room for improvement there, if anyone wants to take a stab at it.
> Edit: PR https://github.com/apache/tapestry-5/pull/46
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2769) Upgrade ASM to 9.6 to allow running on Java 21
[
https://issues.apache.org/jira/browse/TAP5-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813022#comment-17813022
]
Hudson commented on TAP5-2769:
--
FAILURE: Integrated in Jenkins build Tapestry » tapestry-java-9-freestyle #46
(See
[https://ci-builds.apache.org/job/Tapestry/job/tapestry-java-9-freestyle/46/])
TAP5-2769: fixing hardcoded references to ASM packages (thiago: rev
fa1b44e79b23c5774eb800976996ffa36ac3c06a)
* (edit)
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Constants.java
> Upgrade ASM to 9.6 to allow running on Java 21
> --
>
> Key: TAP5-2769
> URL: https://issues.apache.org/jira/browse/TAP5-2769
> Project: Tapestry 5
> Issue Type: Task
> Components: plastic
>Affects Versions: 5.8.3
>Reporter: Chris Poulsen
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.4
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> I have a local version where the shadowing of ASM is done by Gradle to easier
> maintain the ASM copy in the future.
> I'll create a PR with the changes on Github.
> The copied version had a single change to the ASM sources (in order to access
> the static package protected method
> {code:java}
> AnnotationNode.accept
> {code}
> .
> I did a quick hack with reflection to access it instead, there is definitely
> room for improvement there, if anyone wants to take a stab at it.
> Edit: PR https://github.com/apache/tapestry-5/pull/46
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2769) Upgrade ASM to 9.6 to allow running on Java 21
[
https://issues.apache.org/jira/browse/TAP5-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813030#comment-17813030
]
Hudson commented on TAP5-2769:
--
ABORTED: Integrated in Jenkins build Tapestry » tapestry-java-17-freestyle #86
(See
[https://ci-builds.apache.org/job/Tapestry/job/tapestry-java-17-freestyle/86/])
TAP5-2769: fixing hardcoded references to ASM packages (thiago: rev
fa1b44e79b23c5774eb800976996ffa36ac3c06a)
* (edit)
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Constants.java
> Upgrade ASM to 9.6 to allow running on Java 21
> --
>
> Key: TAP5-2769
> URL: https://issues.apache.org/jira/browse/TAP5-2769
> Project: Tapestry 5
> Issue Type: Task
> Components: plastic
>Affects Versions: 5.8.3
>Reporter: Chris Poulsen
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.4
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> I have a local version where the shadowing of ASM is done by Gradle to easier
> maintain the ASM copy in the future.
> I'll create a PR with the changes on Github.
> The copied version had a single change to the ASM sources (in order to access
> the static package protected method
> {code:java}
> AnnotationNode.accept
> {code}
> .
> I did a quick hack with reflection to access it instead, there is definitely
> room for improvement there, if anyone wants to take a stab at it.
> Edit: PR https://github.com/apache/tapestry-5/pull/46
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
svn commit: r1085331 [2/2] - in /websites/production/tapestry/content: ./ cache/
Modified: websites/production/tapestry/content/release-notes-53.html == --- websites/production/tapestry/content/release-notes-53.html (original) +++ websites/production/tapestry/content/release-notes-53.html Thu Feb 1 05:12:20 2024 @@ -143,11 +143,11 @@ This is the consolidated list of changes between Tapestry versions 5.2 and 5.3. To upgrade from 5.2 to 5.3, most users who are not using deprecated features will be able to just update the Maven dependency in their POM file (or download the new JAR file) and the new version will just work. However, please read carefully below before upgrading, and also review the How to Upgrade instructions.Contents/**/ +/*]]>*/ Breaking ChangesNew FeaturesSub-tasks CompletedBugs FixedImprovements MadeNew Features ImplementedTasks Completed Breaking ChangesTapestry now depends on Servlet API version 2.5 (prior releases worked with 2.4).Tapestry no longer supports the ability to inject the component id into a String field. This was rarely (if ever) used functionality that caused unwanted conflicts elsewhere. When a component needs to know its component id, it may inject the http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/ComponentResources.html";>ComponentResources object, and invoke getCompleteId().Tapestry templates without a are treated a bit differently in Tapestry 5.3; they are treated as if they have the HTML5 doctype (). See further notes about component templates.Many classes and interfaces that were deprecated in prior releases of Tapestry have been removed in Tapestry 5.3. See https://issues.apache.org/jira/browse/TAP5-1432";>the full list. As always, you should use your IDE to find and replace all deprecated items before you upgrade. The following are the most significant of these:@IncludeJavaScriptLibrary and @IncludeStylesheet annotations (replaced by @http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/annotations/Import.html";>Import)@ApplicationState annotation (replaced with @http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/annotations/SessionState.html";>SessionState)"validateForm" event triggered by Form component (replaced with "validate" event)Code and constants related to page poolingIn addition, some of the abstract base classes used with the tapestry-func library have changed into interfaces; you will want to recompile, but may also need to adjust your code, depending on your compiler settings and use of the standard Java @Override annotation.Because of the upgrade to Prototype 1.7, existing JavaScript that uses value.toJSON() may break; replace with Object.toJSON(value).Some number of interfaces and APIs in Tapestry 5.3 will be removed in Tapestry 5.4 or later. These include:The http://tapestry.apache.org/5.2/apidocs/org/apache/tapestry5/RenderSupport.html";>RenderSupport environmental (replaced with the http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/services/javascript/JavaScriptSupport.html";>JavaScriptSupport environmental)The http://tapestry.apache.org/5.2/apidocs/org/apache/tapestry5/ajax/MultiZoneUpdate.html";>MultiZoneUpdate object, replaced with http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/services/ajax/AjaxR esponseRenderer.html">AjaxResponseRendererClassFactory service and ClassFab interface (replaced with the http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/ioc/services/PlasticProxyFactory.html";>PlasticProxyFactory service and http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/plastic/PlasticClass.html";>PlasticClass interface)The "suppress redirects" functionality, which allows component event requests to respond directly with HTML, as in Tapestry 4.New FeaturesUnderscore.jsTapestry now bundles http://underscorejs.org/"; rel="nofollow">Underscore.js, a useful library for expressive functional programming in the browser. It is used in no conflict mode, made available as the T5._ object.User AlertsTapestry now has a central mechanism for handling user alerts; this includes the AlertManager service and the Alerts component. Just add an Alerts component to your application's standard layout component and Tapestry takes care of the rest. Alerts can be added during both traditional and Ajax requests, and may be transient (displayed for a few seconds), normal, or sticky (persist until the user expressly dismisses them). Alerts support three severities: info, warn(ing) and error; the look and feel can be customized by overriding Tape
svn commit: r1085331 [1/2] - in /websites/production/tapestry/content: ./ cache/
Author: buildbot
Date: Thu Feb 1 05:12:20 2024
New Revision: 1085331
Log:
Production update by buildbot for tapestry
Modified:
websites/production/tapestry/content/beaneditform-faq.html
websites/production/tapestry/content/cache/main.pageCache
websites/production/tapestry/content/component-events-faq.html
websites/production/tapestry/content/component-parameters.html
websites/production/tapestry/content/forms-and-validation.html
websites/production/tapestry/content/javascript-faq.html
websites/production/tapestry/content/page-navigation.html
websites/production/tapestry/content/release-notes-50.html
websites/production/tapestry/content/release-notes-51.html
websites/production/tapestry/content/release-notes-52.html
websites/production/tapestry/content/release-notes-53.html
websites/production/tapestry/content/release-upgrade-faq.html
websites/production/tapestry/content/request-processing-faq.html
websites/production/tapestry/content/security-faq.html
websites/production/tapestry/content/session-storage.html
websites/production/tapestry/content/templating-and-markup-faq.html
Modified: websites/production/tapestry/content/beaneditform-faq.html
==
--- websites/production/tapestry/content/beaneditform-faq.html (original)
+++ websites/production/tapestry/content/beaneditform-faq.html Thu Feb 1
05:12:20 2024
@@ -143,11 +143,11 @@
BeanEditFormMain Article: BeanEditForm GuideContents/**/
+/*]]>*/
Why
do I get exceptions about instantiating a bean when using
BeanEditForm?What's
the difference between BeanEditor and BeanEditForm?How do I
customize the layout of the BeanEditForm?
Why
do I get exceptions about instantiating a bean when using
BeanEditForm?When you render a BeanEditForm, or when the rendered form
is submitted, Tapestry must instantiate an instance of the object to be edited.
This occurs when the BeanEditForm's object parameter is bound to
null: Tapestry instantiates an instance of the property type so that the
BeanEditForm has an object to read default values from, or to push submitted
values into.By default, this uses the standard injection mechanism, which means that
Tapestry will identify the public constructor with the most parameters, and
attempt to find objects and other objects for each constructor
parameter.There's two ways to fine tune this so you don't get
errors:Place an @http://tapestry.apache.org/current/apidocs/org/apache
/tapestry5/ioc/annotations/Inject.html">Inject annotation on the correct
constructor to use (often, the constructor with no parameters).
public class MyBean {
Modified: websites/production/tapestry/content/cache/main.pageCache
==
Binary files - no diff available.
Modified: websites/production/tapestry/content/component-events-faq.html
==
--- websites/production/tapestry/content/component-events-faq.html (original)
+++ websites/production/tapestry/content/component-events-faq.html Thu Feb 1
05:12:20 2024
@@ -143,11 +143,11 @@
Component EventsMain Article:
Component EventsContents/**/
+/*]]>*/
Why
does Tapestry send a redirect after a form is submitted?I
specified a zone in my ActionLink/EventLink, so why doesn't my event fire via
ajax (request.isXHR() is false)?
Why
does Tapestry send a redirect after a form is submitted?This is an
extension of the http://en.wikipedia.org/wiki/Post/Redirect/Get";
rel="nofollow">Post/Redirect/Get approach. It ensures that after an
operation that updates server-side state, such as a form submission, if the
user resubmits the resulting page, the operation is not
performed a second time; instead just the results of the operation, reflecting
the changed server-side state, is re-rendered.This has the unwanted
requirement that any data needed to render the response must persist between
the event request (the form submission) and the render request; this often
means that fields must be annotated with @http://tapestry.apache.org/current/apidocs/org/apache/tapestry5/ann
