svn commit: r40276 - /dev/struts/2.5.23/
Author: lukaszlenart Date: Fri Jul 3 06:13:21 2020 New Revision: 40276 Log: Updates test release 2.5.23 Added: dev/struts/2.5.23/ dev/struts/2.5.23/struts-2.5.23-all.zip (with props) dev/struts/2.5.23/struts-2.5.23-all.zip.asc (with props) dev/struts/2.5.23/struts-2.5.23-all.zip.sha256 dev/struts/2.5.23/struts-2.5.23-all.zip.sha512 dev/struts/2.5.23/struts-2.5.23-apps.zip (with props) dev/struts/2.5.23/struts-2.5.23-apps.zip.asc (with props) dev/struts/2.5.23/struts-2.5.23-apps.zip.sha256 dev/struts/2.5.23/struts-2.5.23-apps.zip.sha512 dev/struts/2.5.23/struts-2.5.23-docs.zip (with props) dev/struts/2.5.23/struts-2.5.23-docs.zip.asc (with props) dev/struts/2.5.23/struts-2.5.23-docs.zip.sha256 dev/struts/2.5.23/struts-2.5.23-docs.zip.sha512 dev/struts/2.5.23/struts-2.5.23-lib.zip (with props) dev/struts/2.5.23/struts-2.5.23-lib.zip.asc (with props) dev/struts/2.5.23/struts-2.5.23-lib.zip.sha256 dev/struts/2.5.23/struts-2.5.23-lib.zip.sha512 dev/struts/2.5.23/struts-2.5.23-min-lib.zip (with props) dev/struts/2.5.23/struts-2.5.23-min-lib.zip.asc (with props) dev/struts/2.5.23/struts-2.5.23-min-lib.zip.sha256 dev/struts/2.5.23/struts-2.5.23-min-lib.zip.sha512 dev/struts/2.5.23/struts-2.5.23-src.zip (with props) dev/struts/2.5.23/struts-2.5.23-src.zip.asc (with props) dev/struts/2.5.23/struts-2.5.23-src.zip.sha256 dev/struts/2.5.23/struts-2.5.23-src.zip.sha512 Added: dev/struts/2.5.23/struts-2.5.23-all.zip == Binary file - no diff available. Propchange: dev/struts/2.5.23/struts-2.5.23-all.zip -- svn:mime-type = application/zip Added: dev/struts/2.5.23/struts-2.5.23-all.zip.asc == Binary file - no diff available. Propchange: dev/struts/2.5.23/struts-2.5.23-all.zip.asc -- svn:mime-type = application/pgp-signature Added: dev/struts/2.5.23/struts-2.5.23-all.zip.sha256 == --- dev/struts/2.5.23/struts-2.5.23-all.zip.sha256 (added) +++ dev/struts/2.5.23/struts-2.5.23-all.zip.sha256 Fri Jul 3 06:13:21 2020 @@ -0,0 +1 @@ +3f33fe643debd1d57bed4a82ea9d62a6b8a7bbdd120e25d6dc27152b9f8b0e9d struts-2.5.23-all.zip Added: dev/struts/2.5.23/struts-2.5.23-all.zip.sha512 == --- dev/struts/2.5.23/struts-2.5.23-all.zip.sha512 (added) +++ dev/struts/2.5.23/struts-2.5.23-all.zip.sha512 Fri Jul 3 06:13:21 2020 @@ -0,0 +1 @@ +85a3fe6746ea3f8995b23d10d92f0a018a894ccad91dde72a1beae7c4f356968a2539f09182007e3106b577f6206210192e13c3f000c1de2a0b26538285495c7 struts-2.5.23-all.zip Added: dev/struts/2.5.23/struts-2.5.23-apps.zip == Binary file - no diff available. Propchange: dev/struts/2.5.23/struts-2.5.23-apps.zip -- svn:mime-type = application/zip Added: dev/struts/2.5.23/struts-2.5.23-apps.zip.asc == Binary file - no diff available. Propchange: dev/struts/2.5.23/struts-2.5.23-apps.zip.asc -- svn:mime-type = application/pgp-signature Added: dev/struts/2.5.23/struts-2.5.23-apps.zip.sha256 == --- dev/struts/2.5.23/struts-2.5.23-apps.zip.sha256 (added) +++ dev/struts/2.5.23/struts-2.5.23-apps.zip.sha256 Fri Jul 3 06:13:21 2020 @@ -0,0 +1 @@ +54bd3bf4f5c6417fa5f33acc139cf3eebdfbc9d2980054a3488330c7829b6b33 struts-2.5.23-apps.zip Added: dev/struts/2.5.23/struts-2.5.23-apps.zip.sha512 == --- dev/struts/2.5.23/struts-2.5.23-apps.zip.sha512 (added) +++ dev/struts/2.5.23/struts-2.5.23-apps.zip.sha512 Fri Jul 3 06:13:21 2020 @@ -0,0 +1 @@ +3d663f3ffcd0f633e1ec141734ab05c8163cfaf1428bd788600121ed8318204192e67cd032187b1002fe5d29c0fbe2b1bc16d1083f1500659e1f29ec2178e718 struts-2.5.23-apps.zip Added: dev/struts/2.5.23/struts-2.5.23-docs.zip == Binary file - no diff available. Propchange: dev/struts/2.5.23/struts-2.5.23-docs.zip -- svn:mime-type = application/zip Added: dev/struts/2.5.23/struts-2.5.23-docs.zip.asc == Binary file - no diff available. Propchange: dev/st
[struts] branch WW-5081-cols-rows created (now 0d622cf)
This is an automated email from the ASF dual-hosted git repository. lukaszlenart pushed a change to branch WW-5081-cols-rows in repository https://gitbox.apache.org/repos/asf/struts.git. at 0d622cf WW-5081 Makes textarea compatible with W3C This branch includes the following new commits: new 0d622cf WW-5081 Makes textarea compatible with W3C The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[struts] 01/01: WW-5081 Makes textarea compatible with W3C
This is an automated email from the ASF dual-hosted git repository.
lukaszlenart pushed a commit to branch WW-5081-cols-rows
in repository https://gitbox.apache.org/repos/asf/struts.git
commit 0d622cfa96dbbc1e286347f30a7527505aeb0ed0
Author: Lukasz Lenart
AuthorDate: Fri Jul 3 08:50:04 2020 +0200
WW-5081 Makes textarea compatible with W3C
---
.../main/resources/template/simple/textarea.ftl| 4
.../apache/struts2/views/jsp/ui/TextareaTest.java | 24 ++
.../org/apache/struts2/views/jsp/ui/Textarea-2.txt | 4
3 files changed, 32 insertions(+)
diff --git a/core/src/main/resources/template/simple/textarea.ftl
b/core/src/main/resources/template/simple/textarea.ftl
index 54e935c..22f2d9b 100644
--- a/core/src/main/resources/template/simple/textarea.ftl
+++ b/core/src/main/resources/template/simple/textarea.ftl
@@ -20,8 +20,12 @@
-->
name="${(parameters.name!"")}"<#rt/>
+<#if parameters.cols?has_content>
cols="${(parameters.cols!"")}"<#rt/>
+
+<#if parameters.rows?has_content>
rows="${(parameters.rows!"")}"<#rt/>
+
<#if parameters.wrap?has_content>
wrap="${parameters.wrap}"<#rt/>
diff --git
a/core/src/test/java/org/apache/struts2/views/jsp/ui/TextareaTest.java
b/core/src/test/java/org/apache/struts2/views/jsp/ui/TextareaTest.java
index 3dc7630..ddd0506 100644
--- a/core/src/test/java/org/apache/struts2/views/jsp/ui/TextareaTest.java
+++ b/core/src/test/java/org/apache/struts2/views/jsp/ui/TextareaTest.java
@@ -54,6 +54,30 @@ public class TextareaTest extends AbstractUITagTest {
verify(TextareaTag.class.getResource("Textarea-1.txt"));
}
+public void testNoColsAndRows() throws Exception {
+TestAction testAction = (TestAction) action;
+testAction.setFoo("bar");
+
+TextareaTag tag = new TextareaTag();
+tag.setPageContext(pageContext);
+tag.setLabel("mylabel");
+tag.setName("myname");
+tag.setValue("%{foo}");
+tag.setTitle("mytitle");
+tag.setDisabled("true");
+tag.setTabindex("5");
+tag.setOnchange("alert('goodbye');");
+tag.setOnclick("alert('onclick');");
+tag.setId("the_id");
+tag.setOnkeyup("alert('hello');");
+tag.setReadonly("true");
+
+tag.doStartTag();
+tag.doEndTag();
+
+verify(TextareaTag.class.getResource("Textarea-2.txt"));
+}
+
/**
* Initialize a map of {@link
org.apache.struts2.views.jsp.AbstractUITagTest.PropertyHolder} for generic tag
* property testing. Will be used when calling {@link
#verifyGenericProperties(org.apache.struts2.views.jsp.ui.AbstractUITag,
diff --git
a/core/src/test/resources/org/apache/struts2/views/jsp/ui/Textarea-2.txt
b/core/src/test/resources/org/apache/struts2/views/jsp/ui/Textarea-2.txt
new file mode 100644
index 000..69c05c0
--- /dev/null
+++ b/core/src/test/resources/org/apache/struts2/views/jsp/ui/Textarea-2.txt
@@ -0,0 +1,4 @@
+
+mylabel:
+bar
+
