Re: [PR] [bugfix](becore) local exchange should check receiver's local state to avoid core [doris]
Thearas commented on PR #45470: URL: https://github.com/apache/doris/pull/45470#issuecomment-2544894985 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [bugfix](becore) local exchange should check receiver's local state to avoid core [doris]
yiguolei opened a new pull request, #45470: URL: https://github.com/apache/doris/pull/45470 ### What problem does this PR solve? _local_recvr depdend on pipeline::ExchangeLocalState* _parent to do some memory counter settings but it only owns a raw pointer, so that the ExchangeLocalState object may be deconstructed. So that I lock the local state to avoid it is deconstruted ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bugfix](becore) local exchange should check receiver's local state to avoid core [doris]
yiguolei commented on PR #45470: URL: https://github.com/apache/doris/pull/45470#issuecomment-2544895204 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](shuffle)(part III) Use local exchanger for both exchange sink and lo… [doris]
Gabriel39 commented on PR #45375: URL: https://github.com/apache/doris/pull/45375#issuecomment-2544851347 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] test 2.1 [doris]
github-actions[bot] commented on PR #45469: URL: https://github.com/apache/doris/pull/45469#issuecomment-2544899880 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](pipeline) make sink operator process eos signals after wake_up_early [doris]
github-actions[bot] commented on code in PR #45207:
URL: https://github.com/apache/doris/pull/45207#discussion_r1886365565
##
be/src/pipeline/pipeline_task.cpp:
##
@@ -279,25 +271,22 @@ bool PipelineTask::_is_blocked() {
_blocked_dep = op_dep->is_blocked_by(this);
if (_blocked_dep != nullptr) {
_blocked_dep->start_watcher();
-if (_wake_up_by_downstream) {
-_eos = true;
-}
return true;
}
}
return false;
}
Status PipelineTask::execute(bool* eos) {
Review Comment:
warning: function 'execute' has cognitive complexity of 70 (threshold 50)
[readability-function-cognitive-complexity]
```cpp
Status PipelineTask::execute(bool* eos) {
^
```
Additional context
**be/src/pipeline/pipeline_task.cpp:280:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (_eos) {
^
```
**be/src/pipeline/pipeline_task.cpp:290:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
DBUG_EXECUTE_IF("fault_inject::PipelineXTask::execute", {
^
```
**be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (UNLIKELY(config::enable_debug_points)) {
\
^
```
**be/src/pipeline/pipeline_task.cpp:290:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
DBUG_EXECUTE_IF("fault_inject::PipelineXTask::execute", {
^
```
**be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (dp) {
\
^
```
**be/src/pipeline/pipeline_task.cpp:308:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (_wait_to_start()) {
^
```
**be/src/pipeline/pipeline_task.cpp:313:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (!_opened && !_fragment_context->is_canceled()) {
^
```
**be/src/pipeline/pipeline_task.cpp:313:** +1
```cpp
if (!_opened && !_fragment_context->is_canceled()) {
^
```
**be/src/pipeline/pipeline_task.cpp:314:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (_wake_up_early) {
^
```
**be/src/pipeline/pipeline_task.cpp:319:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_open());
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do {\
^
```
**be/src/pipeline/pipeline_task.cpp:319:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_open());
^
```
**be/src/common/status.h:634:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/pipeline_task.cpp:322:** nesting level increased to 1
```cpp
auto set_wake_up_and_dep_ready = [&]() {
^
```
**be/src/pipeline/pipeline_task.cpp:323:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (wake_up_early()) {
^
```
**be/src/pipeline/pipeline_task.cpp:332:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
while (!_fragment_context->is_canceled()) {
^
```
**be/src/pipeline/pipeline_task.cpp:333:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (_is_blocked()) {
^
```
**be/src/pipeline/pipeline_task.cpp:340:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (_fragment_context->is_canceled()) {
^
```
**be/src/pipeline/pipeline_task.cpp:344:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (time_spent > THREAD_TIME_SLICE) {
^
```
**be/src/pipeline/pipeline_task.cpp:352:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (should_revoke_memory(_state, sink_revocable_mem_size)) {
^
```
**be/src/pipeline/pipeline_task.cpp:353:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_sink->revoke_memory(_state));
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do {\
^
```
**be/src/pipeline/pipeline_task.cpp:353:** +4, including nesting penalty of
3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_sink->revoke_memory(_state));
^
```
**be
Re: [PR] [opt](join) Check the property of nullable from intermediate row [doris]
github-actions[bot] commented on PR #45017: URL: https://github.com/apache/doris/pull/45017#issuecomment-2544905522 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](join) Check the property of nullable from intermediate row [doris]
github-actions[bot] commented on PR #45017: URL: https://github.com/apache/doris/pull/45017#issuecomment-2544905438 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bugfix](becore) local exchange should check receiver's local state to avoid core [doris]
github-actions[bot] commented on PR #45470: URL: https://github.com/apache/doris/pull/45470#issuecomment-2544906693 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45267-branch-3.0 updated (ca212e91308 -> 43d54fe3021)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-45267-branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git from ca212e91308 branch-3.0: [fix](statistics)Fix skip analyze empty table case. #45441 (#45450) add 43d54fe3021 [feat](docker)Add a BE ENV item 'SKIP_CHECK_ULIMIT' for Docker to start quickly (#45267) No new revisions were added by this update. Summary of changes: be/src/olap/storage_engine.cpp | 10 ++ 1 file changed, 10 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [feat](docker)Add a BE ENV item 'SKIP_CHECK_ULIMIT' for Docker to start quickly #45267 [doris]
dataroaring closed pull request #45467: branch-3.0: [feat](docker)Add a BE ENV item 'SKIP_CHECK_ULIMIT' for Docker to start quickly #45267 URL: https://github.com/apache/doris/pull/45467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [feat](docker)Add a BE ENV item 'SKIP_CHECK_ULIMIT' for Docker to start quickly #45267 [doris]
hello-stephen commented on PR #45467: URL: https://github.com/apache/doris/pull/45467#issuecomment-2544854546 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] branch-3.0: [feat](docker)Add a BE ENV item 'SKIP_CHECK_ULIMIT' for Docker to start quickly #45267 [doris]
github-actions[bot] opened a new pull request, #45467: URL: https://github.com/apache/doris/pull/45467 Cherry-picked from #45267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45267-branch-2.1 created (now 9e5c53d5762)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-45267-branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git at 9e5c53d5762 branch-2.1: [Fix](job-case)Fix status typo #45326 (#45341) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45267-branch-3.0 created (now ca212e91308)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-45267-branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git at ca212e91308 branch-3.0: [fix](statistics)Fix skip analyze empty table case. #45441 (#45450) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [feat](docker)Add a BE ENV item 'SKIP_CHECK_ULIMIT' for Docker to start quickly #45267 [doris]
hello-stephen commented on PR #45467: URL: https://github.com/apache/doris/pull/45467#issuecomment-2544854640 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] branch-2.1: [feat](docker)Add a BE ENV item 'SKIP_CHECK_ULIMIT' for Docker to start quickly #45267 [doris]
github-actions[bot] opened a new pull request, #45468: URL: https://github.com/apache/doris/pull/45468 Cherry-picked from #45267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45267-branch-2.1 updated (9e5c53d5762 -> 54d1b1c74f1)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-45267-branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git from 9e5c53d5762 branch-2.1: [Fix](job-case)Fix status typo #45326 (#45341) add 54d1b1c74f1 [feat](docker)Add a BE ENV item 'SKIP_CHECK_ULIMIT' for Docker to start quickly (#45267) No new revisions were added by this update. Summary of changes: be/src/olap/storage_engine.cpp | 10 ++ 1 file changed, 10 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [I] [Enhancement] (nereids)implement showColumnsCommand in nereids [doris]
msridhar78 commented on issue #42747: URL: https://github.com/apache/doris/issues/42747#issuecomment-2544855215 @LiBinfeng-01 will pick this up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](ccr) Incorrectly generated sql with NONE aggregate type [doris]
wyxxxcat commented on PR #45452: URL: https://github.com/apache/doris/pull/45452#issuecomment-2544866932 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [feat](docker)Add a BE ENV item 'SKIP_CHECK_ULIMIT' for Docker to start quickly (#45267)
This is an automated email from the ASF dual-hosted git repository.
zykkk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 8cba7a2672e [feat](docker)Add a BE ENV item 'SKIP_CHECK_ULIMIT' for
Docker to start quickly (#45267)
8cba7a2672e is described below
commit 8cba7a2672ee99febfa5787d7b2d1340fd00d855
Author: FreeOnePlus <54164178+freeonep...@users.noreply.github.com>
AuthorDate: Mon Dec 16 15:59:55 2024 +0800
[feat](docker)Add a BE ENV item 'SKIP_CHECK_ULIMIT' for Docker to start
quickly (#45267)
In the storage_engine.cpp of the BE process, it is mandatory to check
that the `ulimit` value must be greater than 60,000. When starting with
Docker or Docker-Compose, it is necessary to preemptively change the
corresponding value on the host machine. This change is very unfriendly
to Docker, as it loses its unique advantage of being able to "build
quickly and anywhere," and cannot become a fundamental capability for
rapid startup. Therefore, a new environment variable has been added to
control whether to skip this check value. The default value is false,
which enforces the check of this value. When set to true, it skips the
check and starts directly.
---
be/src/olap/storage_engine.cpp | 10 ++
1 file changed, 10 insertions(+)
diff --git a/be/src/olap/storage_engine.cpp b/be/src/olap/storage_engine.cpp
index e00b5b595e2..24cda8232f1 100644
--- a/be/src/olap/storage_engine.cpp
+++ b/be/src/olap/storage_engine.cpp
@@ -463,6 +463,16 @@ Status StorageEngine::_check_file_descriptor_number() {
<< ", use default configuration instead.";
return Status::OK();
}
+if (getenv("SKIP_CHECK_ULIMIT") == nullptr) {
+LOG(INFO) << "will check 'ulimit' value.";
+} else if (std::string(getenv("SKIP_CHECK_ULIMIT")) == "true") {
+LOG(INFO) << "the 'ulimit' value check is skipped"
+ << ", the SKIP_CHECK_ULIMIT env value is " <<
getenv("SKIP_CHECK_ULIMIT");
+return Status::OK();
+} else {
+LOG(INFO) << "the SKIP_CHECK_ULIMIT env value is " <<
getenv("SKIP_CHECK_ULIMIT")
+ << ", will check ulimit value.";
+}
if (l.rlim_cur < config::min_file_descriptor_number) {
LOG(ERROR) << "File descriptor number is less than " <<
config::min_file_descriptor_number
<< ". Please use (ulimit -n) to set a value equal or
greater than "
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](docker)Add a BE ENV item 'SKIP_CHECK_ULIMIT' for Docker to start quickly [doris]
zy-kkk merged PR #45267: URL: https://github.com/apache/doris/pull/45267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](exchange) remove duplicate code [doris]
github-actions[bot] commented on PR #45466: URL: https://github.com/apache/doris/pull/45466#issuecomment-2544857805 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test][doc] add example how to recover data when insert overwrite and truncate cases [doris]
Vallishp commented on code in PR #45424:
URL: https://github.com/apache/doris/pull/45424#discussion_r1886340358
##
regression-test/suites/doc/admin-manual/data-admin/recover_more_cases.md.groovy:
##
@@ -0,0 +1,65 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import org.junit.jupiter.api.Assertions;
+
+suite("docs/admin-manual/data-admin/recover_more_cases.md",
"p0,nonConcurrent") {
Review Comment:
its not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](shuffle)(part III) Use local exchanger for both exchange sink and lo… [doris]
github-actions[bot] commented on PR #45375: URL: https://github.com/apache/doris/pull/45375#issuecomment-2544861782 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [I] [Enhancement] (nereids)implement showRowPolicyCommand in nereids [doris]
msridhar78 commented on issue #42720: URL: https://github.com/apache/doris/issues/42720#issuecomment-2544864040 @LiBinfeng-01 will pick this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [I] [Enhancement] (nereids)implement showCreateLoadCommand in nereids [doris]
msridhar78 commented on issue #42813: URL: https://github.com/apache/doris/issues/42813#issuecomment-2544871014 @LiBinfeng-01 will pick this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](inverted index) Fix Null Pointer Exception in function match [doris]
doris-robot commented on PR #45456: URL: https://github.com/apache/doris/pull/45456#issuecomment-2544872330 TeamCity be ut coverage result: Function Coverage: 38.82% (10125/26084) Line Coverage: 29.76% (85077/285899) Region Coverage: 28.81% (43638/151481) Branch Coverage: 25.35% (22165/87434) Coverage Report: http://coverage.selectdb-in.cc/coverage/439ccab01c69b8d9cff76a86db5239806f46c2f5_439ccab01c69b8d9cff76a86db5239806f46c2f5/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](schema-change) fix array/map/struct in schema-change not-null to null will make core [doris]
doris-robot commented on PR #45305: URL: https://github.com/apache/doris/pull/45305#issuecomment-2544872007 TeamCity be ut coverage result: Function Coverage: 38.82% (10125/26084) Line Coverage: 29.76% (85083/285915) Region Coverage: 28.81% (43639/151487) Branch Coverage: 25.35% (22165/87438) Coverage Report: http://coverage.selectdb-in.cc/coverage/e5bc09ea89ba9ef587f9398d06ed78e2827c7752_e5bc09ea89ba9ef587f9398d06ed78e2827c7752/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] test 2.1 [doris]
Thearas commented on PR #45469: URL: https://github.com/apache/doris/pull/45469#issuecomment-2544870162 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] test 2.1 [doris]
Gabriel39 opened a new pull request, #45469: URL: https://github.com/apache/doris/pull/45469 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tvf) Tvf supports to parse the enclose character in csv files [doris]
doris-robot commented on PR #45407: URL: https://github.com/apache/doris/pull/45407#issuecomment-2544872177 TeamCity be ut coverage result: Function Coverage: 38.82% (10125/26084) Line Coverage: 29.76% (85078/285896) Region Coverage: 28.81% (43646/151478) Branch Coverage: 25.35% (22162/87432) Coverage Report: http://coverage.selectdb-in.cc/coverage/4819d16773098e4c41713977e0e541664150ce37_4819d16773098e4c41713977e0e541664150ce37/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](pipeline) make sink operator process eos signals after wake_up_early [doris]
BiteThet commented on code in PR #45207:
URL: https://github.com/apache/doris/pull/45207#discussion_r1886348832
##
be/src/pipeline/exec/hashjoin_build_sink.cpp:
##
@@ -135,26 +135,17 @@ Status HashJoinBuildSinkLocalState::close(RuntimeState*
state, Status exec_statu
}
}};
-if (!_runtime_filter_slots || _runtime_filters.empty() ||
state->is_cancelled()) {
+if (!_runtime_filter_slots || _runtime_filters.empty() ||
state->is_cancelled() ||
+!p.get_local_state(state)._eos) {
return Base::close(state, exec_status);
}
try {
-if (state->get_task()->wake_up_by_downstream()) {
-if (_should_build_hash_table) {
-// partitial ignore rf to make global rf work
-RETURN_IF_ERROR(
-_runtime_filter_slots->send_filter_size(state, 0,
_finish_dependency));
-RETURN_IF_ERROR(_runtime_filter_slots->ignore_all_filters());
-} else {
-// do not publish filter coz local rf not inited and useless
-return Base::close(state, exec_status);
-}
+if (state->get_task()->wake_up_early()) {
Review Comment:
broadcast join不走sync filter size
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](test) Fix cumu compaction with delete case fail [doris]
gavinchou merged PR #45442: URL: https://github.com/apache/doris/pull/45442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](hive)Support read hive4 transaction tables. [doris]
doris-robot commented on PR #44001: URL: https://github.com/apache/doris/pull/44001#issuecomment-2544879594 TeamCity be ut coverage result: Function Coverage: 38.84% (10123/26065) Line Coverage: 29.75% (85054/285897) Region Coverage: 28.80% (43621/151462) Branch Coverage: 25.34% (22154/87436) Coverage Report: http://coverage.selectdb-in.cc/coverage/3b4388790a35b415fe4c9feebc91b09018e35d06_3b4388790a35b415fe4c9feebc91b09018e35d06/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [Fix](test) Fix cumu compaction with delete case fail (#45442)
This is an automated email from the ASF dual-hosted git repository.
gavinchou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 5c2bfe7ec06 [Fix](test) Fix cumu compaction with delete case fail
(#45442)
5c2bfe7ec06 is described below
commit 5c2bfe7ec06c683cbd705382beea2c0c53acf42a
Author: abmdocrt
AuthorDate: Mon Dec 16 16:14:32 2024 +0800
[Fix](test) Fix cumu compaction with delete case fail (#45442)
After https://github.com/apache/doris/pull/44576, defining global
variables in test groovy files is disabled.
---
.../suites/compaction/test_cumu_compaction_with_delete.groovy | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
a/regression-test/suites/compaction/test_cumu_compaction_with_delete.groovy
b/regression-test/suites/compaction/test_cumu_compaction_with_delete.groovy
index 7c6be0b177c..05ab96a628a 100644
--- a/regression-test/suites/compaction/test_cumu_compaction_with_delete.groovy
+++ b/regression-test/suites/compaction/test_cumu_compaction_with_delete.groovy
@@ -50,7 +50,7 @@ suite("test_cumu_compaction_with_delete") {
sql """ delete from ${tableName} where user_id = 1"""
}
-now = System.currentTimeMillis()
+def now = System.currentTimeMillis()
while(true){
if(check_cumu_point(100)){
@@ -58,7 +58,7 @@ suite("test_cumu_compaction_with_delete") {
}
Thread.sleep(1000)
}
-time_diff = System.currentTimeMillis() - now
+def time_diff = System.currentTimeMillis() - now
logger.info("time_diff:" + time_diff)
assertTrue(time_diff<200*1000)
@@ -99,7 +99,7 @@ suite("test_cumu_compaction_with_delete") {
sql """ delete from ${tableName} where user_id = 1"""
}
-now = System.currentTimeMillis()
+def now = System.currentTimeMillis()
while(true){
if(check_cumu_point(100)){
@@ -107,7 +107,7 @@ suite("test_cumu_compaction_with_delete") {
}
Thread.sleep(1000)
}
-time_diff = System.currentTimeMillis() - now
+def time_diff = System.currentTimeMillis() - now
logger.info("time_diff:" + time_diff)
assertTrue(time_diff>=200*1000)
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] test 2.1 [doris]
github-actions[bot] commented on PR #45469: URL: https://github.com/apache/doris/pull/45469#issuecomment-2544883319 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45442-branch-3.0 created (now ca212e91308)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-45442-branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git at ca212e91308 branch-3.0: [fix](statistics)Fix skip analyze empty table case. #45441 (#45450) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](pipeline) make sink operator process eos signals after wake_up_early [doris]
BiteThet commented on PR #45207: URL: https://github.com/apache/doris/pull/45207#issuecomment-2544891096 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] update workload document [doris-website]
wangtianyi2004 commented on code in PR #1407: URL: https://github.com/apache/doris-website/pull/1407#discussion_r1886136159 ## i18n/zh-CN/docusaurus-plugin-content-docs/current/admin-manual/workload-mangement/compute-group.md: ## Review Comment: 1. 大写 ADD BE  2. 缺少分号  3. 在文档最后添加一句详细操作参考存算分离相关操作（给一个链接）。 ## i18n/zh-CN/docusaurus-plugin-content-docs/current/admin-manual/workload-mangement/workload-group.md: ## Review Comment: 需要添加版本说明  #版本升级说明 自 Doris 2.0 版本开始提供 Workload 资源管控功能。在 Doris 2.0 版本中，Workload 资源管控不依赖于 CGroup，而 Doris 2.1 版本中需要依赖 CGroup。 - 从 Doris 1.2 升级到 2.0：建议集群升级完成后，再开启 Workload 资源管控功能。只升级部分 follower FE 节点，可能会因为未升级的 FE 节点没有 Workload Group 的元数据信息，导致已升级的 follower FE 节点查询失败。 - 从 Doris 2.0 升级到 2.1：由于 2.1 版本的 Workload 资源管控功能依赖于 CGroup，需要先配置 CGroup 环境，在升级到 Doris 2.1 版本。 ## i18n/zh-CN/docusaurus-plugin-content-docs/current/admin-manual/workload-mangement/kill-query.md: ## Review Comment: LGTM ## i18n/zh-CN/docusaurus-plugin-content-docs/current/admin-manual/workload-mangement/sql-blocking.md: ## Review Comment: Typo    ## i18n/zh-CN/docusaurus-plugin-content-docs/current/admin-manual/workload-mangement/sql-blocking.md: ## Review Comment: 使用方法标题下，应该有四个标题 - 阻止扫描超过指定行数的数据 - 阻止扫描超过指定分数数量的数据 - 阻止扫描超过指定分桶数量的数据 - 阻止特定模式的查询 存在以下问题： 1. 当前文档标题级别没有对齐 2. 在使用场景前，增加一句描述，可以在这四个场景使用 ## i18n/zh-CN/docusaurus-plugin-content-docs/current/admin-manual/workload-mangement/sql-blocking.md: ## Review Comment: 使用方法标题下，应该有四个标题 - 阻止扫描超过指定行数的数据 - 阻止扫描超过指定分数数量的数据 - 阻止扫描超过指定分桶数量的数据 - 阻止特定模式的查询 存在以下问题： 1. 当前文档标题级别没有对齐 2. 在使用场景前，增加一句描述，可以在这四个场景使用 ## i18n/zh-CN/docusaurus-plugin-content-docs/current/admin-manual/workload-mangement/workload-management-summary.md: ## Review Comment: LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) merge SimplifyDecimalV3Comparison into SimplifyComparisonPredicate [doris]
yujun777 commented on PR #45459: URL: https://github.com/apache/doris/pull/45459#issuecomment-2545047270 run cloud_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](statistics)Fix skip analyze empty table case. (#45441) [doris]
Jibing-Li merged PR #45455: URL: https://github.com/apache/doris/pull/45455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: [fix](statistics)Fix skip analyze empty table case. (#45441) (#45455)
This is an automated email from the ASF dual-hosted git repository.
lijibing pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new 7e9f6951c04 [fix](statistics)Fix skip analyze empty table case.
(#45441) (#45455)
7e9f6951c04 is described below
commit 7e9f6951c040666757bcbaef2004fb4c5c0f749c
Author: James
AuthorDate: Mon Dec 16 17:28:05 2024 +0800
[fix](statistics)Fix skip analyze empty table case. (#45441) (#45455)
backport: https://github.com/apache/doris/pull/45441
---
.../doris/statistics/StatisticsAutoCollector.java | 18 +-
.../doris/statistics/StatisticsAutoCollectorTest.java | 5 +
.../suites/statistics/test_analyze_mv.groovy | 8
3 files changed, 14 insertions(+), 17 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsAutoCollector.java
b/fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsAutoCollector.java
index 1d7818a8e8d..574b25da422 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsAutoCollector.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsAutoCollector.java
@@ -123,15 +123,6 @@ public class StatisticsAutoCollector extends MasterDaemon {
protected void processOneJob(TableIf table, JobPriority priority)
throws DdlException, ExecutionException, InterruptedException {
-List> needRunColumns = table.getColumnIndexPairs(
-table.getSchemaAllIndexes(false)
-.stream()
-.filter(c ->
!StatisticsUtil.isUnsupportedType(c.getType()))
-.map(Column::getName)
-.collect(Collectors.toSet()));
-if (needRunColumns == null || needRunColumns.isEmpty()) {
-return;
-}
AnalysisMethod analysisMethod =
table.getDataSize(true) >=
StatisticsUtil.getHugeTableLowerBoundSizeInBytes()
? AnalysisMethod.SAMPLE : AnalysisMethod.FULL;
@@ -151,6 +142,15 @@ public class StatisticsAutoCollector extends MasterDaemon {
}
return;
}
+List> needRunColumns = table.getColumnIndexPairs(
+table.getSchemaAllIndexes(false)
+.stream()
+.filter(c ->
!StatisticsUtil.isUnsupportedType(c.getType()))
+.map(Column::getName)
+.collect(Collectors.toSet()));
+if (needRunColumns == null || needRunColumns.isEmpty()) {
+return;
+}
StringJoiner stringJoiner = new StringJoiner(",", "[", "]");
for (Pair pair : needRunColumns) {
stringJoiner.add(pair.toString());
diff --git
a/fe/fe-core/src/test/java/org/apache/doris/statistics/StatisticsAutoCollectorTest.java
b/fe/fe-core/src/test/java/org/apache/doris/statistics/StatisticsAutoCollectorTest.java
index d687d111d2c..6c13bbc0f79 100644
---
a/fe/fe-core/src/test/java/org/apache/doris/statistics/StatisticsAutoCollectorTest.java
+++
b/fe/fe-core/src/test/java/org/apache/doris/statistics/StatisticsAutoCollectorTest.java
@@ -67,6 +67,11 @@ public class StatisticsAutoCollectorTest {
count[0]++;
return Pair.of(null, JobPriority.LOW);
}
+
+@Mock
+protected void processOneJob(TableIf table, JobPriority priority) {
+return;
+}
};
count[0] = 0;
count[1] = 0;
diff --git a/regression-test/suites/statistics/test_analyze_mv.groovy
b/regression-test/suites/statistics/test_analyze_mv.groovy
index a4263975c26..f52295469db 100644
--- a/regression-test/suites/statistics/test_analyze_mv.groovy
+++ b/regression-test/suites/statistics/test_analyze_mv.groovy
@@ -717,14 +717,6 @@ suite("test_analyze_mv") {
empty_test = sql """show auto analyze mvTestDup"""
assertEquals(0, empty_test.size())
empty_test = sql """show column stats mvTestDup"""
-for (int i = 0; i < 100; i++) {
-empty_test = sql """show column stats mvTestDup"""
-if (empty_test.size() != 0) {
-logger.info("async delete is not finished yet.")
-Thread.sleep(1000)
-}
-break
-}
assertEquals(0, empty_test.size())
// ** End of embedded test
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [case](auth)Auth case for auth [doris]
hello-stephen commented on PR #45478: URL: https://github.com/apache/doris/pull/45478#issuecomment-2545063048 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [case](auth)Auth case for auth [doris]
zddr commented on PR #45478: URL: https://github.com/apache/doris/pull/45478#issuecomment-2545063913 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [case](auth)Auth case for auth [doris]
zddr opened a new pull request, #45478: URL: https://github.com/apache/doris/pull/45478 ### What problem does this PR solve? add case - Restrictions on special users, roles, and resources - Permission control for select count Issue Number: close #xxx Related PR: #xxx Problem Summary: Auth case for auth ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Test](binlog) Remove unnecessary binlog property [doris]
wyxxxcat commented on PR #45477: URL: https://github.com/apache/doris/pull/45477#issuecomment-2545066144 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Test](binlog) Remove unnecessary binlog property [doris]
github-actions[bot] commented on PR #45477: URL: https://github.com/apache/doris/pull/45477#issuecomment-2545066252 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](ccr) Incorrectly generated sql with NONE aggregate type [doris]
github-actions[bot] commented on PR #45452: URL: https://github.com/apache/doris/pull/45452#issuecomment-2545065325 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Test](binlog) Check correctly for show create database [doris]
github-actions[bot] commented on PR #45472: URL: https://github.com/apache/doris/pull/45472#issuecomment-2545067054 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Test](binlog) Check correctly for show create database [doris]
wyxxxcat commented on PR #45472: URL: https://github.com/apache/doris/pull/45472#issuecomment-2545067133 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Test](binlog) Check correctly for show create database [doris]
github-actions[bot] commented on PR #45472: URL: https://github.com/apache/doris/pull/45472#issuecomment-2545067154 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](mtmv)Change the way to verify the existence of partition names when refreshing MTMV [doris]
github-actions[bot] commented on PR #45290: URL: https://github.com/apache/doris/pull/45290#issuecomment-2545065514 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Test](binlog) Remove unnecessary binlog property [doris]
github-actions[bot] commented on PR #45477: URL: https://github.com/apache/doris/pull/45477#issuecomment-2545066088 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-2.1: [bug](function) fix first/last value return error with ignore null #44996 [doris]
doris-robot commented on PR #45345: URL: https://github.com/apache/doris/pull/45345#issuecomment-2545067717 TeamCity be ut coverage result: Function Coverage: 36.48% (9569/26232) Line Coverage: 27.93% (78666/281654) Region Coverage: 26.60% (40386/151836) Branch Coverage: 23.35% (20454/87594) Coverage Report: http://coverage.selectdb-in.cc/coverage/6b0a45da1f5dbb1040c93ce1d603c61b8b2f3135_6b0a45da1f5dbb1040c93ce1d603c61b8b2f3135/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](exchange) remove duplicate code [doris]
Gabriel39 commented on PR #45466: URL: https://github.com/apache/doris/pull/45466#issuecomment-2545031155 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement CreateCatalogCommand in nereids [doris]
starocean999 merged PR #45150: URL: https://github.com/apache/doris/pull/45150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [Enhancement] (nereids)implement CreateCatalogCommand in nereids (#45150)
This is an automated email from the ASF dual-hosted git repository.
starocean999 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new cf6dba79c48 [Enhancement] (nereids)implement CreateCatalogCommand in
nereids (#45150)
cf6dba79c48 is described below
commit cf6dba79c48c40775a40749d730c69916c5c900a
Author: Sridhar R Manikarnike
AuthorDate: Mon Dec 16 14:50:33 2024 +0530
[Enhancement] (nereids)implement CreateCatalogCommand in nereids (#45150)
Issue Number: close #42594
---
.../antlr4/org/apache/doris/nereids/DorisParser.g4 | 8 +-
.../apache/doris/datasource/CatalogFactory.java| 10 ++
.../org/apache/doris/datasource/CatalogMgr.java| 33 +++--
.../doris/nereids/parser/LogicalPlanBuilder.java | 14 ++
.../apache/doris/nereids/trees/plans/PlanType.java | 1 +
.../trees/plans/commands/CreateCatalogCommand.java | 144 +
.../trees/plans/visitor/CommandVisitor.java| 5 +
.../nereids_p0/test_create_catalog_command.out | 4 +
.../nereids_p0/test_create_catalog_command.groovy | 43 ++
9 files changed, 249 insertions(+), 13 deletions(-)
diff --git a/fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4
b/fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4
index 044ed7771a4..bc91a667eda 100644
--- a/fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4
+++ b/fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4
@@ -185,7 +185,10 @@ supportedCreateStatement
(WITH ROLLUP (rollupNames=identifierList)?)?
#createTableLike
| CREATE ROLE (IF NOT EXISTS)? name=identifier (COMMENT STRING_LITERAL)?
#createRole
| CREATE WORKLOAD GROUP (IF NOT EXISTS)?
-name=identifierOrText properties=propertyClause?
#createWorkloadGroup
+name=identifierOrText properties=propertyClause?
#createWorkloadGroup
+| CREATE CATALOG (IF NOT EXISTS)? catalogName=identifier
+(WITH RESOURCE resourceName=identifier)?
+(COMMENT STRING_LITERAL)? properties=propertyClause?
#createCatalog
| CREATE ROW POLICY (IF NOT EXISTS)? name=identifier
ON table=multipartIdentifier
AS type=(RESTRICTIVE | PERMISSIVE)
@@ -744,9 +747,6 @@ analyzeProperties
unsupportedCreateStatement
: CREATE (DATABASE | SCHEMA) (IF NOT EXISTS)? name=multipartIdentifier
properties=propertyClause?
#createDatabase
-| CREATE CATALOG (IF NOT EXISTS)? catalogName=identifier
-(WITH RESOURCE resourceName=identifier)?
-(COMMENT STRING_LITERAL)? properties=propertyClause?
#createCatalog
| CREATE (GLOBAL | SESSION | LOCAL)?
(TABLES | AGGREGATE)? FUNCTION (IF NOT EXISTS)?
functionIdentifier LEFT_PAREN functionArguments? RIGHT_PAREN
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/datasource/CatalogFactory.java
b/fe/fe-core/src/main/java/org/apache/doris/datasource/CatalogFactory.java
index 43ac17839c9..984d29cae49 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/datasource/CatalogFactory.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/datasource/CatalogFactory.java
@@ -37,6 +37,7 @@ import
org.apache.doris.datasource.maxcompute.MaxComputeExternalCatalog;
import org.apache.doris.datasource.paimon.PaimonExternalCatalogFactory;
import org.apache.doris.datasource.test.TestExternalCatalog;
import
org.apache.doris.datasource.trinoconnector.TrinoConnectorExternalCatalogFactory;
+import org.apache.doris.nereids.trees.plans.commands.CreateCatalogCommand;
import com.google.common.base.Strings;
import org.apache.logging.log4j.LogManager;
@@ -83,6 +84,15 @@ public class CatalogFactory {
log.getComment(), log.getProps(), true);
}
+/**
+ * create the catalog instance from CreateCatalogCommand.
+ */
+public static CatalogIf createFromCommand(long catalogId,
CreateCatalogCommand cmd)
+throws DdlException {
+return createCatalog(catalogId, cmd.getCatalogName(),
cmd.getResource(),
+cmd.getComment(), cmd.getProperties(), false);
+}
+
/**
* create the catalog instance from creating statement.
*/
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/datasource/CatalogMgr.java
b/fe/fe-core/src/main/java/org/apache/doris/datasource/CatalogMgr.java
index 070d31c071e..0203aa7020b 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/datasource/CatalogMgr.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/datasource/CatalogMgr.java
@@ -50,6 +50,7 @@ import org.apache.doris.common.util.Util;
import org.apache.doris.datasource.hive.HMSExternalCatalog;
import org.apache.doris.datasource.hive.HMSExternalTable;
import org.apache.doris.mysql.
Re: [PR] [fix](cluster key) add some case [doris]
mymeiyi commented on PR #45383: URL: https://github.com/apache/doris/pull/45383#issuecomment-2545036598 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cluster key) test mow cases in cluster key [doris]
mymeiyi commented on PR #42565: URL: https://github.com/apache/doris/pull/42565#issuecomment-2545038645 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) fix error in get detached tablet stat [doris]
github-actions[bot] commented on PR #45449: URL: https://github.com/apache/doris/pull/45449#issuecomment-2544993624 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](exchange) remove duplicate code [doris]
github-actions[bot] commented on PR #45466: URL: https://github.com/apache/doris/pull/45466#issuecomment-2545041347 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pick](branch-2.1) pick #45210 [doris]
doris-robot commented on PR #45444: URL: https://github.com/apache/doris/pull/45444#issuecomment-2545041649 TeamCity be ut coverage result: Function Coverage: 36.48% (9569/26231) Line Coverage: 27.92% (78631/281651) Region Coverage: 26.59% (40375/151828) Branch Coverage: 23.34% (20448/87594) Coverage Report: http://coverage.selectdb-in.cc/coverage/7046871701080ae726b757a921496e373807be6f_7046871701080ae726b757a921496e373807be6f/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [I] [Enhancement] (nereids)implement CreateCatalogCommand in nereids [doris]
starocean999 closed issue #42594: [Enhancement] (nereids)implement CreateCatalogCommand in nereids URL: https://github.com/apache/doris/issues/42594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-2.1: [bug](function) fix first/last value return error with ignore null #44996 [doris]
github-actions[bot] commented on PR #45345: URL: https://github.com/apache/doris/pull/45345#issuecomment-2545028424 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](pipeline) make sink operator process eos signals after wake_up_early [doris]
github-actions[bot] commented on PR #45207: URL: https://github.com/apache/doris/pull/45207#issuecomment-2545028574 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](pipeline) make sink operator process eos signals after wake_up_early [doris]
github-actions[bot] commented on PR #45207: URL: https://github.com/apache/doris/pull/45207#issuecomment-2545028668 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cluster key) add some case [doris]
github-actions[bot] commented on PR #45383: URL: https://github.com/apache/doris/pull/45383#issuecomment-2545040211 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45017-branch-2.1 updated (17f4c1a17ac -> f6958fa5d27)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-45017-branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git from 17f4c1a17ac branch-2.1: [enhance](nereids) remove first_value and second_value second parameter if the second parameter is false #45264 (#45454) add f6958fa5d27 [opt](join) Check the property of nullable from intermediate row (#45017) No new revisions were added by this update. Summary of changes: be/src/pipeline/exec/hashjoin_probe_operator.cpp | 29 ++-- 1 file changed, 22 insertions(+), 7 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) merge SimplifyDecimalV3Comparison into SimplifyComparisonPredicate [doris]
yujun777 commented on PR #45459: URL: https://github.com/apache/doris/pull/45459#issuecomment-2545047678 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) merge SimplifyDecimalV3Comparison into SimplifyComparisonPredicate [doris]
yujun777 commented on PR #45459: URL: https://github.com/apache/doris/pull/45459#issuecomment-2545048107 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Test](binlog) Remove unnecessary binlog property [doris]
hello-stephen commented on PR #45477: URL: https://github.com/apache/doris/pull/45477#issuecomment-2545051281 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Test](binlog) Remove unnecessary binlog property [doris]
wyxxxcat opened a new pull request, #45477: URL: https://github.com/apache/doris/pull/45477 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-2.1 [Fix](Insert-Job)Resolving Task Status Discrepancies in Query Execution Records (#45342) [doris]
CalvinKirs commented on PR #45451: URL: https://github.com/apache/doris/pull/45451#issuecomment-2545084967 run P0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] [ccr] add support for restore to ccr [doris]
w41ter commented on code in PR #45162:
URL: https://github.com/apache/doris/pull/45162#discussion_r1886500959
##
fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java:
##
@@ -1693,8 +1694,13 @@ public void logAlterRepository(Repository repo) {
logEdit(OperationType.OP_ALTER_REPOSITORY, repo);
}
-public void logRestoreJob(RestoreJob job) {
Review Comment:
Doris' editlog has a replay process, and the specific steps are in
EditLog.loadJournal. Both the log phase and the replay phase need to add the
binlog to the binlog manager. If a RestoreBinLogInfo is temporarily created in
the log phase, then it will not be possible to construct RestoreBinLogInfo in
the replay phase.
##
fe/fe-core/src/main/java/org/apache/doris/backup/RestoreBinLogInfo.java:
##
@@ -0,0 +1,68 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.backup;
+
+import org.apache.doris.persist.gson.GsonUtils;
+
+import com.google.common.collect.Maps;
+import com.google.gson.annotations.SerializedName;
+
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+public class RestoreBinLogInfo {
Review Comment:
Consider keeping consistent with the existing word `Binlog`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[PR] Update workload-group.md [doris-website]
young138120 opened a new pull request, #1524: URL: https://github.com/apache/doris-website/pull/1524 Correct text ## Versions - [ ] dev - [ ] 3.0 - [ ] 2.1 - [ ] 2.0 ## Languages - [ ] Chinese - [ ] English ## Docs Checklist - [ ] Checked by AI - [ ] Test Cases Built -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](exchange) remove duplicate code [doris]
doris-robot commented on PR #45466: URL: https://github.com/apache/doris/pull/45466#issuecomment-2545095431 TeamCity be ut coverage result: Function Coverage: 38.84% (10122/26064) Line Coverage: 29.77% (85097/285889) Region Coverage: 28.80% (43631/151475) Branch Coverage: 25.34% (22162/87446) Coverage Report: http://coverage.selectdb-in.cc/coverage/90b496890dea9d6baadfdd6a4194697dc78be37b_90b496890dea9d6baadfdd6a4194697dc78be37b/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [opt](join) Check the property of nullable from intermediate row #45017 [doris]
doris-robot commented on PR #45475: URL: https://github.com/apache/doris/pull/45475#issuecomment-2545110749 TPC-H: Total hot run time: 40389 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 349cf5a3b49899adf5c4478c18b995d11cc73786, data reload: false -- Round 1 -- q1 17606 738472637263 q2 2052184 192 184 q3 10662 107111481071 q4 10547 740 723 723 q5 7749277027532753 q6 234 144 145 144 q7 949 618 604 604 q8 9564192720081927 q9 7650636263986362 q10 6929227923162279 q11 465 260 260 260 q12 398 210 207 207 q13 17794 296029682960 q14 235 222 207 207 q15 571 533 509 509 q16 666 611 594 594 q17 947 609 586 586 q18 7167648165356481 q19 1378102310081008 q20 480 195 197 195 q21 3915320531163116 q22 1048960 956 956 Total cold run time: 109006 ms Total hot run time: 40389 ms - Round 2, with runtime_filter_mode=off - q1 7612725071857185 q2 328 242 231 231 q3 2840287128442844 q4 1953177718091777 q5 5631565956815659 q6 225 142 140 140 q7 2179175518221755 q8 3300350334943494 q9 8719883387828782 q10 3519349434953494 q11 605 508 494 494 q12 811 608 586 586 q13 15932 316831403140 q14 296 275 270 270 q15 562 544 516 516 q16 702 668 680 668 q17 1847162415881588 q18 8143769074197419 q19 6160163414331433 q20 2065189218301830 q21 5415529751495149 q22 1138102210101010 Total cold run time: 79982 ms Total hot run time: 59464 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cluster key) test mow cases in cluster key [doris]
github-actions[bot] commented on PR #42565: URL: https://github.com/apache/doris/pull/42565#issuecomment-2545048170 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](pipeline) catch exception on task::prepare [doris]
hello-stephen commented on PR #45479: URL: https://github.com/apache/doris/pull/45479#issuecomment-2545119914 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cluster key) add some case [doris]
doris-robot commented on PR #45383: URL: https://github.com/apache/doris/pull/45383#issuecomment-2545101323 TeamCity be ut coverage result: Function Coverage: 38.85% (10125/26064) Line Coverage: 29.77% (85102/285909) Region Coverage: 28.81% (43645/151490) Branch Coverage: 25.35% (22171/87462) Coverage Report: http://coverage.selectdb-in.cc/coverage/8e7030c4cada379ef84b41f46525bf4b8851deeb_8e7030c4cada379ef84b41f46525bf4b8851deeb/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Chore](pipeline) catch exception on task::prepare [doris]
BiteThet opened a new pull request, #45479: URL: https://github.com/apache/doris/pull/45479 ### What problem does this PR solve? catch exception on task::prepare Problem Summary: ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](pipeline) catch exception on task::prepare to avoid exception make backend coredump [doris]
github-actions[bot] commented on PR #45479: URL: https://github.com/apache/doris/pull/45479#issuecomment-2545131364 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cluster key) test mow cases in cluster key [doris]
doris-robot commented on PR #42565: URL: https://github.com/apache/doris/pull/42565#issuecomment-2545131242 TeamCity be ut coverage result: Function Coverage: 38.84% (10123/26064) Line Coverage: 29.77% (85109/285909) Region Coverage: 28.80% (43634/151490) Branch Coverage: 25.34% (22167/87462) Coverage Report: http://coverage.selectdb-in.cc/coverage/fdef604520e2a410f6607b2ac9ac5ebb08877374_fdef604520e2a410f6607b2ac9ac5ebb08877374/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](k8s)K8s coupled refactor arch [doris-website]
KassieZ merged PR #1500: URL: https://github.com/apache/doris-website/pull/1500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [doc](udf) update some error about java-udf type [doris-website]
KassieZ commented on PR #1523: URL: https://github.com/apache/doris-website/pull/1523#issuecomment-2546058738 Please also update v2.1/3.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[I] [Bug] Failed to deserialize column....Caused by: java.lang.ArrayIndexOutOfBoundsException [doris]
junit opened a new issue, #45494: URL: https://github.com/apache/doris/issues/45494 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version 2.1.7 ### What's Wrong? ``` RuntimeLogger 2024-12-16 14:25:56,541 WARN (STATS_FETCH-6|283) [ColumnStatistic.fromResultRow():181] Failed to deserialize column `extra_words` text NULL COMMENT 'é¢å¤ä¿¡æ¯' max value ð§§è¥¿è¥¿å°å§. org.apache.doris.common.AnalysisException: errCode = 2, detailMessage = 5 at org.apache.doris.statistics.util.StatisticsUtil.convertToDouble(StatisticsUtil.java:317) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.statistics.ColumnStatistic.fromResultRow(ColumnStatistic.java:178) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.statistics.ColumnStatistic.fromResultRow(ColumnStatistic.java:118) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.statistics.util.StatisticsUtil.deserializeToColumnStatistics(StatisticsUtil.java:169) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.statistics.ColumnStatisticsCacheLoader.loadFromStatsTable(ColumnStatisticsCacheLoader.java:66) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.statistics.ColumnStatisticsCacheLoader.doLoad(ColumnStatisticsCacheLoader.java:38) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.statistics.ColumnStatisticsCacheLoader.doLoad(ColumnStatisticsCacheLoader.java:29) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.statistics.BasicAsyncCacheLoader.lambda$asyncLoad$0(BasicAsyncCacheLoader.java:39) ~[doris-fe.jar:1.2-SNAPSHOT] at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1604) ~[?:1.8.0_352-352] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_352-352] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_352-352] at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_352-352] Caused by: java.lang.ArrayIndexOutOfBoundsException: 5 at org.apache.doris.nereids.trees.expressions.literal.StringLikeLiteral.getDouble(StringLikeLiteral.java:53) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.nereids.trees.expressions.literal.StringLikeLiteral.getDouble(StringLikeLiteral.java:42) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.statistics.util.StatisticsUtil.convertToDouble(StatisticsUtil.java:307) ~[doris-fe.jar:1.2-SNAPSHOT] ... 11 more ``` ### What You Expected? No exception ### How to Reproduce? _No response_ ### Anything Else? _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-44996-branch-2.1 updated (ba844bb4e2e -> 6b0a45da1f5)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch auto-pick-44996-branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git omit ba844bb4e2e [bug](function) fix first/last value return error with ignore null (#44996) add 667f5e6e6a8 [feat](iceberg)Supports using rest type catalog to read tables in unity catalog for 2.1 (#43525) (#45217) add 95ffc7a65fc branch-2.1: [fix](job)Fix millisecond offset issue in time window scheduling trigger time calculation #45176 (#45353) add 4d6d9a6c8c2 branch-2.1: [fix](persist) Fix TableAddOrDropInvertedIndicesInfo.equals #45335 (#45364) add 384a1a4bd70 [branch-2.1]log more detail when query hits policy (#44685) (#45366) add 6dabdd6a8ce branch-2.1: [fix](txn insert) txn insert show error url #45254 (#45381) add 249ffa44c05 branch-2.1 [Chore](dependencies)Upgrade Fe dependencies #44872 (#45362) add 1db78d44966 branch-2.1: [fix](hive) fix block decompressor bug #45289 (#45379) add b881157d528 branch-2.1: [regression](paimon) test Paimon's connectivity of cloud filesystems #45268 (#45378) add d13241115db [branch-2.1]downgrade resource tag when there is not queryable repli… (#45387) add 4df7069e59e branch-2.1: [fix](ip)fix default value for ip #45194 (#45392) add 00e69022127 branch-2.1: [chore](arrow-flight-sql) Add Arrow Flight Sql demo for Java #45306 (#45389) add 4d1f4fb5d2b branch-2.1: [fix](nereids)EliminateGroupBy rule should keep output's datatype unchanged #45359 (#45399) add 23c5d52b04a branch-2.1: [fix](s3) improve error msg #45360 (#45432) add 9e5c53d5762 branch-2.1: [Fix](job-case)Fix status typo #45326 (#45341) add 17f4c1a17ac branch-2.1: [enhance](nereids) remove first_value and second_value second parameter if the second parameter is false #45264 (#45454) add 6b0a45da1f5 [bug](function) fix first/last value return error with ignore null (#44996) This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (ba844bb4e2e) \ N -- N -- N refs/heads/auto-pick-44996-branch-2.1 (6b0a45da1f5) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: be/src/exec/decompressor.cpp | 24 +-- be/src/io/fs/err_utils.cpp | 10 +- be/src/io/fs/file_system.cpp | 34 ++-- be/src/io/fs/file_system.h | 8 +- be/src/io/fs/local_file_system.cpp | 82 +++-- be/src/io/fs/local_file_system.h | 6 + be/src/io/fs/remote_file_system.cpp| 10 +- be/src/io/fs/s3_file_system.h | 7 +- .../runtime/stream_load/stream_load_executor.cpp | 9 +- .../workload_management/workload_action.cpp| 2 +- .../workload_management/workload_condition.h | 20 +++ .../workload_management/workload_query_info.h | 3 +- .../workload_management/workload_sched_policy.cpp | 5 + be/src/vec/exec/format/parquet/schema_desc.cpp | 18 ++ be/src/vec/exec/format/parquet/schema_desc.h | 7 + be/src/vec/exec/format/parquet/vparquet_reader.cpp | 6 +- be/src/vec/exec/format/parquet/vparquet_reader.h | 2 +- be/src/vec/exec/format/table/iceberg_reader.cpp| 48 ++ be/src/vec/exec/format/table/iceberg_reader.h | 2 +- be/test/io/fs/local_file_system_test.cpp | 51 ++ .../java/org/apache/doris/analysis/ColumnDef.java | 6 + .../org/apache/doris/analysis/IPv4Literal.java | 2 +- .../org/apache/doris/analysis/IPv6Literal.java | 2 +- .../org/apache/doris/common/util/TimeUtils.java| 11 ++ .../apache/doris/datasource/ExternalCatalog.java | 6 + .../doris/datasource/FederationBackendPolicy.java | 3 + .../doris/datasource/hive/HMSExternalCatalog.java | 20 ++- .../datasource/iceberg/IcebergExternalCatalog.java | 3 +- .../datasource/iceberg/IcebergMetadataCache.java | 14 +- .../datasource/iceberg/IcebergMetadataOps.java | 69 ++-- .../iceberg/IcebergRestExternalCatalog.java| 2 - .../datasource/iceberg/IcebergTransaction.java | 3 +- .../operations/ExternalMetadataOperations.java | 4 +- .../datasource/operations/ExternalMetadataOps.java | 4 + .../org/apache/doris/httpv2/rest/LoadAction.java | 2 + .../doris/job/base/JobExecutionConfiguration.java | 2 +- .../org/ap
Re: [PR] branch-2.1: [bug](function) fix first/last value return error with ignore null #44996 [doris]
yiguolei commented on PR #45345: URL: https://github.com/apache/doris/pull/45345#issuecomment-2545012611 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](statistics)Set enableQueryCache to false for statistics queries. [doris]
Jibing-Li commented on PR #45474: URL: https://github.com/apache/doris/pull/45474#issuecomment-2545016791 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [improvement](statistics)Set enableQueryCache to false for statistics queries. [doris]
Jibing-Li opened a new pull request, #45474: URL: https://github.com/apache/doris/pull/45474 ### What problem does this PR solve? Set enableQueryCache to false for statistics queries. Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [x] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [x] No. - [ ] Yes. - Does this need documentation? - [x] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](statistics)Set enableQueryCache to false for statistics queries. [doris]
hello-stephen commented on PR #45474: URL: https://github.com/apache/doris/pull/45474#issuecomment-2545016309 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (5c2bfe7ec06 -> 79eddb78c08)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 5c2bfe7ec06 [Fix](test) Fix cumu compaction with delete case fail (#45442) add 79eddb78c08 [opt](join) Check the property of nullable from intermediate row (#45017) No new revisions were added by this update. Summary of changes: be/src/pipeline/exec/hashjoin_probe_operator.cpp | 29 ++-- 1 file changed, 22 insertions(+), 7 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](join) Check the property of nullable from intermediate row [doris]
yiguolei merged PR #45017: URL: https://github.com/apache/doris/pull/45017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45017-branch-3.0 updated (ca212e91308 -> 349cf5a3b49)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-45017-branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git from ca212e91308 branch-3.0: [fix](statistics)Fix skip analyze empty table case. #45441 (#45450) add 349cf5a3b49 [opt](join) Check the property of nullable from intermediate row (#45017) No new revisions were added by this update. Summary of changes: be/src/pipeline/exec/hashjoin_probe_operator.cpp | 29 ++-- 1 file changed, 22 insertions(+), 7 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [opt](join) Check the property of nullable from intermediate row #45017 [doris]
Thearas commented on PR #45475: URL: https://github.com/apache/doris/pull/45475#issuecomment-2545023352 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [opt](join) Check the property of nullable from intermediate row #45017 [doris]
dataroaring closed pull request #45475: branch-3.0: [opt](join) Check the property of nullable from intermediate row #45017 URL: https://github.com/apache/doris/pull/45475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](pipeline) make sink operator process eos signals after wake_up_early [doris]
Gabriel39 commented on code in PR #45207:
URL: https://github.com/apache/doris/pull/45207#discussion_r1886451822
##
be/src/pipeline/exec/exchange_sink_operator.cpp:
##
@@ -186,9 +186,6 @@ void
ExchangeSinkLocalState::on_channel_finished(InstanceLoId channel_id) {
_finished_channels.emplace(channel_id);
if (_working_channels_count.fetch_sub(1) == 1) {
set_reach_limit();
-if (_finish_dependency) {
Review Comment:
不是，是当前task已经处在阻塞状态了。能走到这里的前提是这个task被唤醒起来执行了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [opt](join) Check the property of nullable from intermediate row #45017 [doris]
Thearas commented on PR #45475: URL: https://github.com/apache/doris/pull/45475#issuecomment-2545023504 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] branch-3.0: [opt](join) Check the property of nullable from intermediate row #45017 [doris]
github-actions[bot] opened a new pull request, #45475: URL: https://github.com/apache/doris/pull/45475 Cherry-picked from #45017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
