Re: [PR] Remove common docs [doris-website]
jeffreys-cat merged PR #1501: URL: https://github.com/apache/doris-website/pull/1501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improment]add be avail cpu num metric [doris]
wangbo commented on PR #45284: URL: https://github.com/apache/doris/pull/45284#issuecomment-2535824433 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) lock table in ascending order of table IDs [doris]
doris-robot commented on PR #45045: URL: https://github.com/apache/doris/pull/45045#issuecomment-2535824969 TPC-DS: Total hot run time: 197215 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 924a1af55f985176a6a2c42434ec349886a6affa, data reload: false query1 13541002928 928 query2 6243209621042096 query3 10925 4511 query4 66866 28547 23442 23442 query5 5023471 470 470 query6 411 189 179 179 query7 5549315 304 304 query8 337 260 257 257 query9 8588273927412739 query10 442 275 256 256 query11 17215 15141 15910 15141 query12 154 105 101 101 query13 1533483 444 444 query14 11069 749174457445 query15 209 186 188 186 query16 7066451 472 451 query17 1239574 576 574 query18 1874321 310 310 query19 198 165 159 159 query20 123 107 118 107 query21 213 105 103 103 query22 4748462343624362 query23 34406 33977 33927 33927 query24 5457249725042497 query25 488 396 397 396 query26 650 159 154 154 query27 1898287 294 287 query28 4400250124762476 query29 672 421 439 421 query30 212 156 151 151 query31 1077825 862 825 query32 67 55 55 55 query33 464 283 317 283 query34 993 555 528 528 query35 903 773 776 773 query36 1088958 977 958 query37 126 113 73 73 query38 4507437443614361 query39 1522145414861454 query40 208 101 99 99 query41 46 41 45 41 query42 116 102 105 102 query43 562 532 507 507 query44 1249862 867 862 query45 190 171 174 171 query46 1176785 799 785 query47 2004192219191919 query48 444 335 335 335 query49 722 428 396 396 query50 832 401 400 400 query51 7437724372127212 query52 101 91 95 91 query53 261 184 200 184 query54 531 422 428 422 query55 81 77 79 77 query56 273 285 260 260 query57 1244110311421103 query58 234 229 222 222 query59 3323305028752875 query60 258 238 235 235 query61 109 110 111 110 query62 759 675 656 656 query63 220 194 188 188 query64 1393659 662 659 query65 3250323832153215 query66 707 305 304 304 query67 15808 15589 15618 15589 query68 4295579 569 569 query69 427 264 257 257 query70 1228118410991099 query71 342 258 252 252 query72 6420419040384038 query73 786 363 365 363 query74 10101 892289098909 query75 3383266627052666 query76 1876118011071107 query77 503 274 278 274 query78 10409 947494229422 query79 1334607 614 607 query80 857 444 439 439 query81 498 247 233 233 query82 1403120 121 120 query83 269 147 141 141 query84 277 69 74 69 query85 876 311 314 311 query86 338 301 282 282 query87 4681450844994499 query88 3548223122122212 query89 419 300 291 291 query90 1994189 188 188 query91 140 103 105 103 query92 64 50 48 48 query93 1462565 561 561 query94 784 287 290 287 query95 344 252 253 252 query96 635 281 292 281 query97 2817266226742662 query98 220 203 193 193 query99 1809136713441344 Total cold run time: 318386 ms Total hot run time: 197215 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [test](index compaction)Add index compaction exception fault injection cases [doris]
qidaye commented on PR #45127: URL: https://github.com/apache/doris/pull/45127#issuecomment-2535830264 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](backup) Backup and restore cooldown data [doris]
justfortaste commented on PR #44993: URL: https://github.com/apache/doris/pull/44993#issuecomment-2535832785 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) lock table in ascending order of table IDs [doris]
doris-robot commented on PR #45045: URL: https://github.com/apache/doris/pull/45045#issuecomment-2535836503 ClickBench: Total hot run time: 32.98 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 924a1af55f985176a6a2c42434ec349886a6affa, data reload: false query1 0.030.030.03 query2 0.080.030.03 query3 0.240.070.06 query4 1.630.100.11 query5 0.410.400.42 query6 1.160.650.65 query7 0.020.010.02 query8 0.030.030.03 query9 0.580.500.49 query10 0.540.570.56 query11 0.140.100.10 query12 0.130.110.11 query13 0.600.600.60 query14 2.852.782.85 query15 0.900.820.83 query16 0.390.390.38 query17 1.031.011.02 query18 0.220.210.21 query19 1.971.922.03 query20 0.010.020.01 query21 15.37 0.590.59 query22 3.031.611.90 query23 16.98 0.930.87 query24 2.931.522.21 query25 0.370.150.05 query26 0.490.130.13 query27 0.040.050.03 query28 9.201.111.08 query29 12.54 3.363.33 query30 0.240.060.05 query31 2.870.380.39 query32 3.280.460.45 query33 2.992.983.12 query34 16.77 4.434.44 query35 4.504.414.54 query36 0.670.490.48 query37 0.090.070.06 query38 0.040.030.03 query39 0.030.020.02 query40 0.180.120.12 query41 0.080.030.02 query42 0.040.020.02 query43 0.030.020.03 Total cold run time: 105.72 s Total hot run time: 32.98 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](index compaction)Add index compaction exception fault injection cases [doris]
qidaye commented on code in PR #45127:
URL: https://github.com/apache/doris/pull/45127#discussion_r1880085133
##
be/src/olap/compaction.cpp:
##
@@ -714,6 +788,16 @@ Status Compaction::do_inverted_index_compaction() {
return Status::OK();
}
+void Compaction::mark_skip_index_compaction(
+const RowsetWriterContext& context,
+const std::function& error_handler) {
+for (auto&& column_uniq_id : context.columns_to_do_index_compaction) {
+auto col = _cur_tablet_schema->column_by_uid(column_uniq_id);
+const auto* index_meta = _cur_tablet_schema->inverted_index(col);
Review Comment:
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](rowset meta) truncate segments key bounds if too large to avoid `RowsetMetaCloudPB` exceeds fdb's 100KB limits [doris]
github-actions[bot] commented on code in PR #45287: URL: https://github.com/apache/doris/pull/45287#discussion_r1880091185 ## be/test/olap/segments_key_bounds_truncation_test.cpp: ## @@ -0,0 +1,73 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include Review Comment: warning: 'gen_cpp/olap_file.pb.h' file not found [clang-diagnostic-error] ```cpp #include ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](index compaction)Add index compaction exception fault injection cases [doris]
github-actions[bot] commented on code in PR #45127:
URL: https://github.com/apache/doris/pull/45127#discussion_r1880098983
##
be/src/olap/compaction.cpp:
##
@@ -495,10 +495,35 @@ Status CompactionMixin::execute_compact_impl(int64_t
permits) {
Status Compaction::do_inverted_index_compaction() {
Review Comment:
warning: function 'do_inverted_index_compaction' has cognitive complexity of
59 (threshold 50) [readability-function-cognitive-complexity]
```cpp
Status Compaction::do_inverted_index_compaction() {
^
```
Additional context
**be/src/olap/compaction.cpp:496:** +1, including nesting penalty of 0,
nesting level increased to 1
```cpp
if (!config::inverted_index_compaction_enable || _input_row_num <= 0 ||
^
```
**be/src/olap/compaction.cpp:496:** +1
```cpp
if (!config::inverted_index_compaction_enable || _input_row_num <= 0 ||
^
```
**be/src/olap/compaction.cpp:501:** nesting level increased to 1
```cpp
auto error_handler = [this](int64_t index_id, int64_t column_uniq_id) {
^
```
**be/src/olap/compaction.cpp:513:** +1, including nesting penalty of 0,
nesting level increased to 1
```cpp
DBUG_EXECUTE_IF("Compaction::do_inverted_index_compaction_rowid_conversion_null",
^
```
**be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (UNLIKELY(config::enable_debug_points)) {
\
^
```
**be/src/olap/compaction.cpp:513:** +2, including nesting penalty of 1,
nesting level increased to 2
```cpp
DBUG_EXECUTE_IF("Compaction::do_inverted_index_compaction_rowid_conversion_null",
^
```
**be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (dp) {
\
^
```
**be/src/olap/compaction.cpp:515:** +1, including nesting penalty of 0,
nesting level increased to 1
```cpp
if (!_stats.rowid_conversion) {
^
```
**be/src/olap/compaction.cpp:543:** +1, including nesting penalty of 0,
nesting level increased to 1
```cpp
RETURN_IF_ERROR(_output_rs_writer->get_segment_num_rows(&dest_segment_num_rows));
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do {\
^
```
**be/src/olap/compaction.cpp:543:** +2, including nesting penalty of 1,
nesting level increased to 2
```cpp
RETURN_IF_ERROR(_output_rs_writer->get_segment_num_rows(&dest_segment_num_rows));
^
```
**be/src/common/status.h:634:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/compaction.cpp:549:** +1, including nesting penalty of 0,
nesting level increased to 1
```cpp
if (dest_segment_num <= 0) {
^
```
**be/src/olap/compaction.cpp:558:** +1, including nesting penalty of 0,
nesting level increased to 1
```cpp
if (config::debug_inverted_index_compaction) {
^
```
**be/src/olap/compaction.cpp:570:** +2, including nesting penalty of 1,
nesting level increased to 2
```cpp
for (int i = 0; i < dest_segment_num; ++i) {
^
```
**be/src/olap/compaction.cpp:575:** nesting level increased to 2
```cpp
auto write_json_to_file = [&](const nlohmann::json& json_obj,
^
```
**be/src/olap/compaction.cpp:580:** +3, including nesting penalty of 2,
nesting level increased to 3
```cpp
RETURN_IF_ERROR(io::global_local_filesystem()->create_file(file_path,
&file_writer));
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do {\
^
```
**be/src/olap/compaction.cpp:580:** +4, including nesting penalty of 3,
nesting level increased to 4
```cpp
RETURN_IF_ERROR(io::global_local_filesystem()->create_file(file_path,
&file_writer));
^
```
**be/src/common/status.h:634:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/compaction.cpp:581:** +3, including nesting penalty of 2,
nesting level increased to 3
```cpp
RETURN_IF_ERROR(file_writer->append(json_obj.dump()));
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do {\
^
```
**be/src/olap/compaction.cpp:581:** +4, including nesting penalty of 3,
nesting level increased to 4
```cpp
RETURN_IF_ERROR(file_writer->append(json_obj.dump()));
Re: [PR] [feat](docker)Modify the init_be and start_be scripts to meet the requirements for rapid Docker startup. [doris]
doris-robot commented on PR #45269: URL: https://github.com/apache/doris/pull/45269#issuecomment-2535851619 TeamCity be ut coverage result: Function Coverage: 38.75% (10103/26073) Line Coverage: 29.69% (84765/285515) Region Coverage: 28.75% (43501/151329) Branch Coverage: 25.31% (22099/87330) Coverage Report: http://coverage.selectdb-in.cc/coverage/c37ec4dabb4abc2c90d660b8e83a71192fbedef0_c37ec4dabb4abc2c90d660b8e83a71192fbedef0/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](backup) Backup and restore cooldown data [doris]
github-actions[bot] commented on code in PR #44993:
URL: https://github.com/apache/doris/pull/44993#discussion_r1880105218
##
be/src/runtime/snapshot_loader.cpp:
##
@@ -124,6 +132,161 @@ Status SnapshotLoader::init(TStorageBackendType::type
type, const std::string& l
SnapshotLoader::~SnapshotLoader() = default;
+static Status list_segment_inverted_index_file(io::RemoteFileSystem* cold_fs,
+ const std::string& dir, const
std::string& rowset,
+ std::vector*
remote_files) {
+bool exists = true;
+std::vector files;
+RETURN_IF_ERROR(cold_fs->list(dir, true, &files, &exists));
+for (auto& tmp_file : files) {
+io::Path path(tmp_file.file_name);
+std::string file_name = path.filename();
+
+if (file_name.substr(0, rowset.length()).compare(rowset) != 0 ||
+!_end_with(file_name, ".idx")) {
+continue;
+}
+remote_files->push_back(file_name);
+}
+
+return Status::OK();
+}
+
+static Status check_need_upload(const std::string& src_path, const
std::string& local_file,
+std::map& remote_files,
std::string* md5sum,
+bool* need_upload) {
+// calc md5sum of localfile
+RETURN_IF_ERROR(io::global_local_filesystem()->md5sum(src_path + "/" +
local_file, md5sum));
+VLOG_CRITICAL << "get file checksum: " << local_file << ": " << *md5sum;
+
+// check if this local file need upload
+auto find = remote_files.find(local_file);
+if (find != remote_files.end()) {
+if (*md5sum != find->second.md5) {
+// remote storage file exist, but with different checksum
+LOG(WARNING) << "remote file checksum is invalid. remote: " <<
find->first
+ << ", local: " << *md5sum;
+// TODO(cmy): save these files and delete them later
+*need_upload = true;
+}
+} else {
+*need_upload = true;
+}
+
+return Status::OK();
+}
+
+static Status download_and_upload_one_cold_file(
+io::RemoteFileSystem& dest_fs, io::RemoteFileSystem* cold_fs,
+const std::string& remote_seg_path, const std::string& local_seg_path,
+const std::string& dest_seg_path, const std::string& local_path,
+const std::string& local_file, std::map&
remote_files) {
+RETURN_IF_ERROR(cold_fs->download(remote_seg_path, local_seg_path));
+
+bool need_upload = false;
+std::string md5sum;
+RETURN_IF_ERROR(check_need_upload(local_path, local_file, remote_files,
&md5sum, &need_upload));
+
+if (!need_upload) {
+VLOG_CRITICAL << "cold file exist in remote path, no need to upload: "
<< local_file;
+return Status::OK();
+}
+
+RETURN_IF_ERROR(upload_with_checksum(dest_fs, local_seg_path,
dest_seg_path, md5sum));
+
+//delete local file
+
RETURN_IF_ERROR(io::global_local_filesystem()->delete_file(local_seg_path));
+
+return Status::OK();
+}
+
+static Status upload_remote_cold_rowset(io::RemoteFileSystem& dest_fs, int64_t
tablet_id,
+const std::string& local_path, const
std::string& dest_path,
+io::RemoteFileSystem* cold_fs, const
std::string& rowset_id,
+int segments, int have_inverted_index,
+std::map&
remote_files) {
+Status res = Status::OK();
+
+for (int i = 0; i < segments; i++) {
+std::string local_file = fmt::format("{}_{}.dat", rowset_id, i);
+std::string remote_seg_path =
+fmt::format("{}/{}_{}.dat", remote_tablet_path(tablet_id),
rowset_id, i);
+std::string local_seg_path = fmt::format("{}/{}_{}.dat", local_path,
rowset_id, i);
+std::string dest_seg_path = fmt::format("{}/{}_{}.dat", dest_path,
rowset_id, i);
+
+RETURN_IF_ERROR(download_and_upload_one_cold_file(dest_fs, cold_fs,
remote_seg_path,
+ local_seg_path,
dest_seg_path, local_path,
+ local_file,
remote_files));
+}
+
+if (!have_inverted_index) {
+return res;
+}
+
+std::vector remote_index_files;
+RETURN_IF_ERROR(list_segment_inverted_index_file(cold_fs,
remote_tablet_path(tablet_id),
+ rowset_id,
&remote_index_files));
+
+for (auto& index_file : remote_index_files) {
+std::string remote_index_path =
+fmt::format("{}/{}", remote_tablet_path(tablet_id),
index_file);
+std::string local_seg_path = fmt::format("{}/{}", local_path,
index_file);
+std::string dest_seg_path = fmt::format("{}/{}", dest_path,
index_file);
+
+RETURN_IF_ERROR(download_and_upload_one_cold_file(dest_fs, cold_fs,
r
Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]
csun5285 commented on PR #44994: URL: https://github.com/apache/doris/pull/44994#issuecomment-2535856164 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]
csun5285 commented on code in PR #44994:
URL: https://github.com/apache/doris/pull/44994#discussion_r1880109837
##
be/test/olap/rowset/segment_v2/inverted_index/common/inverted_index_gc_binlogs_test.cpp:
##
@@ -0,0 +1,170 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include
+
+#include "olap/rowset/beta_rowset_writer.h"
+#include "olap/rowset/rowset_factory.h"
+#include "olap/rowset/rowset_meta_manager.h"
+#include "olap/storage_engine.h"
+
+namespace doris {
+
+using namespace doris::vectorized;
+
+constexpr static uint32_t MAX_PATH_LEN = 1024;
+constexpr static std::string_view dest_dir = "./ut_dir/inverted_index_test";
+constexpr static std::string_view tmp_dir = "./ut_dir/tmp";
+static int64_t inc_id = 0;
+
+class IndexGcBinglogsTest : public ::testing::Test {
+protected:
+void SetUp() override {
+// absolute dir
+char buffer[MAX_PATH_LEN];
+EXPECT_NE(getcwd(buffer, MAX_PATH_LEN), nullptr);
+_curreent_dir = std::string(buffer);
+_absolute_dir = _curreent_dir + std::string(dest_dir);
+
EXPECT_TRUE(io::global_local_filesystem()->delete_directory(_absolute_dir).ok());
+
EXPECT_TRUE(io::global_local_filesystem()->create_directory(_absolute_dir).ok());
+
+// tmp dir
+
EXPECT_TRUE(io::global_local_filesystem()->delete_directory(tmp_dir).ok());
+
EXPECT_TRUE(io::global_local_filesystem()->create_directory(tmp_dir).ok());
+std::vector paths;
+paths.emplace_back(std::string(tmp_dir), 102400);
+auto tmp_file_dirs = std::make_unique(paths);
+EXPECT_TRUE(tmp_file_dirs->init().ok());
+ExecEnv::GetInstance()->set_tmp_file_dir(std::move(tmp_file_dirs));
+
+// storage engine
+doris::EngineOptions options;
+auto engine = std::make_unique(options);
+_engine_ref = engine.get();
+_data_dir = std::make_unique(*_engine_ref, _absolute_dir);
+static_cast(_data_dir->update_capacity());
+EXPECT_TRUE(_data_dir->init(true).ok());
+ExecEnv::GetInstance()->set_storage_engine(std::move(engine));
+
+// tablet_schema
+TabletSchemaPB schema_pb;
+schema_pb.set_keys_type(KeysType::DUP_KEYS);
+
schema_pb.set_inverted_index_storage_format(InvertedIndexStorageFormatPB::V2);
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) range inference convert isnull(k) and null to EmptyValue [doris]
yujun777 commented on PR #45310: URL: https://github.com/apache/doris/pull/45310#issuecomment-2535761977 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](hive)Clear processed tasks [doris]
doris-robot commented on PR #45309: URL: https://github.com/apache/doris/pull/45309#issuecomment-2535864563 TPC-H: Total hot run time: 39781 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 9609373d1dca3993414d85c8c8666b4a9febe246, data reload: false -- Round 1 -- q1 17565 746472697269 q2 2044183 173 173 q3 10638 107811751078 q4 10556 726 697 697 q5 7604271526802680 q6 239 148 146 146 q7 965 636 624 624 q8 9245186919341869 q9 6679644564546445 q10 7013228922962289 q11 466 250 246 246 q12 424 218 217 217 q13 17783 300230013001 q14 242 215 206 206 q15 573 506 522 506 q16 663 585 570 570 q17 987 522 505 505 q18 7219667367266673 q19 1343102010901020 q20 459 175 177 175 q21 4025308631033086 q22 372 312 306 306 Total cold run time: 107104 ms Total hot run time: 39781 ms - Round 2, with runtime_filter_mode=off - q1 7214723174377231 q2 322 226 230 226 q3 2942283229172832 q4 2095186918661866 q5 5690567456565656 q6 220 139 141 139 q7 2239181717821782 q8 3381353935103510 q9 9085900190289001 q10 3580355435473547 q11 605 506 530 506 q12 822 612 599 599 q13 11326 323932073207 q14 299 268 268 268 q15 566 522 514 514 q16 690 663 644 644 q17 1849163415971597 q18 8327765777137657 q19 1791160014861486 q20 2129187818801878 q21 5574543952265226 q22 636 558 591 558 Total cold run time: 71382 ms Total hot run time: 59930 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](index compaction)Add index compaction exception fault injection cases [doris]
doris-robot commented on PR #45127: URL: https://github.com/apache/doris/pull/45127#issuecomment-2535873519 TPC-H: Total hot run time: 39757 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit a2809702274224954d998a641642e5cc456d0df9, data reload: false -- Round 1 -- q1 17626 742972087208 q2 2045177 175 175 q3 10541 113511821135 q4 10229 713 731 713 q5 7605271126892689 q6 236 144 151 144 q7 986 618 627 618 q8 9245187419211874 q9 6606643264316431 q10 6931229423452294 q11 460 251 255 251 q12 409 220 224 220 q13 1 300829902990 q14 228 217 212 212 q15 571 509 512 509 q16 651 594 581 581 q17 957 486 543 486 q18 7428663867716638 q19 1346991 949 949 q20 482 184 188 184 q21 4013314632383146 q22 384 310 320 310 Total cold run time: 106756 ms Total hot run time: 39757 ms - Round 2, with runtime_filter_mode=off - q1 7170718672177186 q2 340 229 231 229 q3 2952280329672803 q4 2125185518451845 q5 5624569056305630 q6 221 146 141 141 q7 2271181217771777 q8 3356355235183518 q9 8915890389218903 q10 3564352035263520 q11 593 495 495 495 q12 793 642 608 608 q13 12406 322031353135 q14 307 261 270 261 q15 581 531 514 514 q16 677 625 632 625 q17 1785158115331533 q18 7880751973687368 q19 1660155314801480 q20 2037180718771807 q21 5371514452195144 q22 608 568 574 568 Total cold run time: 71236 ms Total hot run time: 59090 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](multi-catalog) Add legavy hive compactible catalog property to resolve reading issue of Hive 2.0.0 to 2.2.0 before the ORC-125 fix. [doris]
kaka11chen commented on PR #45311: URL: https://github.com/apache/doris/pull/45311#issuecomment-2535882246 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](multi-catalog) Add legavy hive compactible catalog property to resolve reading issue of Hive 2.0.0 to 2.2.0 before the ORC-125 fix. [doris]
doris-robot commented on PR #45311: URL: https://github.com/apache/doris/pull/45311#issuecomment-2535882066 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Enhancement](multi-catalog) Add legavy hive compactible catalog property to resolve reading issue of Hive 2.0.0 to 2.2.0 before the ORC-125 fix. [doris]
kaka11chen opened a new pull request, #45311: URL: https://github.com/apache/doris/pull/45311 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](docker)Modify the init_be and start_be scripts to meet the requirements for rapid Docker startup. [doris]
github-actions[bot] commented on PR #45269: URL: https://github.com/apache/doris/pull/45269#issuecomment-2535886024 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](hive)Clear processed tasks [doris]
doris-robot commented on PR #45309: URL: https://github.com/apache/doris/pull/45309#issuecomment-2535891058 TPC-DS: Total hot run time: 196811 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 9609373d1dca3993414d85c8c8666b4a9febe246, data reload: false query1 1319985 922 922 query2 6235216421382138 query3 10922 426944364269 query4 66800 28535 23398 23398 query5 4954472 453 453 query6 408 188 174 174 query7 5519310 298 298 query8 321 227 228 227 query9 8799273927292729 query10 444 238 254 238 query11 17150 15160 15933 15160 query12 162 113 105 105 query13 1492447 446 446 query14 9911774076097609 query15 222 180 193 180 query16 7141479 474 474 query17 1099623 581 581 query18 1863321 322 321 query19 209 163 163 163 query20 123 110 113 110 query21 212 103 107 103 query22 4628444345104443 query23 34589 34141 34551 34141 query24 5405252924802480 query25 522 404 405 404 query26 709 162 166 162 query27 1959287 293 287 query28 4512250825002500 query29 703 416 420 416 query30 209 156 155 155 query31 1036842 834 834 query32 70 56 56 56 query33 454 293 306 293 query34 934 528 518 518 query35 928 749 777 749 query36 1107971 965 965 query37 124 74 81 74 query38 4503442543334333 query39 1495143314691433 query40 202 100 100 100 query41 48 42 46 42 query42 121 98 100 98 query43 559 499 503 499 query44 1222863 859 859 query45 200 172 170 170 query46 1194763 773 763 query47 1999190019351900 query48 417 331 325 325 query49 733 391 409 391 query50 831 398 401 398 query51 7398717672727176 query52 99 92 88 88 query53 248 179 182 179 query54 512 397 399 397 query55 76 90 77 77 query56 267 234 237 234 query57 1258112111141114 query58 205 201 216 201 query59 3183304228332833 query60 267 270 251 251 query61 104 103 104 103 query62 801 655 672 655 query63 209 188 184 184 query64 1779685 685 685 query65 3296327132013201 query66 666 290 289 289 query67 15948 15406 15574 15406 query68 4054572 578 572 query69 415 255 254 254 query70 1182113211121112 query71 347 258 251 251 query72 6406412540194019 query73 786 360 363 360 query74 10007 891290268912 query75 3356265326272627 query76 1830104710201020 query77 467 269 268 268 query78 10482 939294519392 query79 1224613 605 605 query80 838 457 447 447 query81 481 340 235 235 query82 1358122 120 120 query83 267 144 144 144 query84 286 74 69 69 query85 915 317 299 299 query86 333 296 290 290 query87 4773456944834483 query88 3444223222062206 query89 420 295 287 287 query90 1940229 185 185 query91 153 103 106 103 query92 64 49 48 48 query93 1320552 548 548 query94 737 300 299 299 query95 344 248 251 248 query96 626 278 279 278 query97 2812265126512651 query98 234 208 202 202 query99 1591131813431318 Total cold run time: 316526 ms Total hot run time: 196811 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [Enhancement](multi-catalog) Add legavy hive compactible catalog property to resolve reading issue of Hive 2.0.0 to 2.2.0 before the ORC-125 fix. [doris]
github-actions[bot] commented on code in PR #45311:
URL: https://github.com/apache/doris/pull/45311#discussion_r1880132671
##
be/src/vec/sink/writer/vhive_config.h:
##
@@ -0,0 +1,37 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+namespace doris {
+namespace vectorized {
+
+class HiveCatalogConfig {
+public:
+// ORC Writer configurations
+static constexpr char ORC_WRITER_LEGACY_HIVE_COMPATIBLE[] =
+"hive.orc.writer.legacy_hive_compatible";
+
+private:
+HiveCatalogConfig() = delete;
+~HiveCatalogConfig() = delete;
+HiveCatalogConfig(const HiveCatalogConfig&) = delete;
Review Comment:
warning: deleted member function should be public
[modernize-use-equals-delete]
```cpp
HiveCatalogConfig(const HiveCatalogConfig&) = delete;
^
```
##
be/src/vec/sink/writer/vhive_config.h:
##
@@ -0,0 +1,37 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+namespace doris {
+namespace vectorized {
+
+class HiveCatalogConfig {
+public:
+// ORC Writer configurations
+static constexpr char ORC_WRITER_LEGACY_HIVE_COMPATIBLE[] =
+"hive.orc.writer.legacy_hive_compatible";
+
+private:
+HiveCatalogConfig() = delete;
+~HiveCatalogConfig() = delete;
+HiveCatalogConfig(const HiveCatalogConfig&) = delete;
+HiveCatalogConfig& operator=(const HiveCatalogConfig&) = delete;
Review Comment:
warning: deleted member function should be public
[modernize-use-equals-delete]
```cpp
HiveCatalogConfig& operator=(const HiveCatalogConfig&) = delete;
^
```
##
be/src/vec/sink/writer/vhive_config.h:
##
@@ -0,0 +1,37 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+namespace doris {
+namespace vectorized {
Review Comment:
warning: nested namespaces can be concatenated
[modernize-concat-nested-namespaces]
```suggestion
namespace doris::vectorized {
```
be/src/vec/sink/writer/vhive_config.h:35:
```diff
- } // namespace vectorized
- } // namespace doris
+ } // namespace doris
```
##
be/src/vec/sink/writer/vhive_config.h:
##
@@ -0,0 +1,37 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http:/
Re: [PR] [Enhancement] (nereids)implement showQueryProfileCommand in nereids [doris]
shuke987 commented on PR #45271: URL: https://github.com/apache/doris/pull/45271#issuecomment-2535892020 http://43.132.222.7:8111/buildConfiguration/Doris_DorisRegression_P0Regression/585592?buildTab=tests&name=insert_group_commit_into&expandedTest=build%3A%28id%3A585592%29%2Cid%3A202147 a case runs timeout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](index compaction)Add index compaction exception fault injection cases [doris]
doris-robot commented on PR #45127: URL: https://github.com/apache/doris/pull/45127#issuecomment-2535898535 TPC-DS: Total hot run time: 190488 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit a2809702274224954d998a641642e5cc456d0df9, data reload: false query1 982 364 379 364 query2 6510221820362036 query3 6703219 210 210 query4 33916 23349 23359 23349 query5 4337449 448 448 query6 282 198 183 183 query7 4622309 302 302 query8 307 234 225 225 query9 9670274427262726 query10 479 245 253 245 query11 18020 15172 15071 15071 query12 163 100 103 100 query13 1687425 430 425 query14 9387766069756975 query15 298 184 187 184 query16 8209475 405 405 query17 1773580 570 570 query18 2147306 315 306 query19 369 157 140 140 query20 117 108 109 108 query21 204 101 98 98 query22 4564446543884388 query23 34464 33704 33659 33659 query24 11488 239025222390 query25 674 377 381 377 query26 1862156 150 150 query27 2858281 275 275 query28 8163247324462446 query29 1046402 409 402 query30 301 150 149 149 query31 1029804 814 804 query32 96 57 64 57 query33 765 306 282 282 query34 1036516 518 516 query35 904 753 720 720 query36 1081923 941 923 query37 285 83 71 71 query38 4335412942164129 query39 1440139213971392 query40 279 99 97 97 query41 51 43 45 43 query42 108 94 97 94 query43 546 496 508 496 query44 1256826 822 822 query45 186 170 165 165 query46 1163705 696 696 query47 1987186418761864 query48 407 317 313 313 query49 1282395 389 389 query50 785 378 378 378 query51 7280711071377110 query52 102 94 88 88 query53 254 180 179 179 query54 1316401 405 401 query55 86 88 75 75 query56 259 254 228 228 query57 1235109211001092 query58 224 209 210 209 query59 3398330432013201 query60 279 251 252 251 query61 114 110 140 110 query62 897 666 638 638 query63 215 192 187 187 query64 5061667 633 633 query65 3262317432263174 query66 1445344 329 329 query67 16038 15757 15535 15535 query68 5326584 574 574 query69 413 250 251 250 query70 1195113611481136 query71 338 248 266 248 query72 6389406640614061 query73 764 368 366 366 query74 10314 882489418824 query75 3428263226662632 query76 3202116710731073 query77 506 279 277 277 query78 10352 954994939493 query79 1510595 633 595 query80 1096427 443 427 query81 521 232 228 228 query82 917 114 123 114 query83 238 146 139 139 query84 231 68 73 68 query85 1339317 315 315 query86 389 308 304 304 query87 4631458246104582 query88 3230225522232223 query89 421 301 305 301 query90 2024188 187 187 query91 139 111 107 107 query92 59 51 52 51 query93 1097541 559 541 query94 1124286 281 281 query95 359 247 249 247 query96 617 288 279 279 query97 2862267026822670 query98 216 195 196 195 query99 1515133213031303 Total cold run time: 302850 ms Total hot run time: 190488 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] [fix](hive)Clear processed tasks [doris]
doris-robot commented on PR #45309: URL: https://github.com/apache/doris/pull/45309#issuecomment-2535903118 ClickBench: Total hot run time: 32.81 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 9609373d1dca3993414d85c8c8666b4a9febe246, data reload: false query1 0.040.030.03 query2 0.070.030.03 query3 0.240.070.07 query4 1.620.100.11 query5 0.420.390.40 query6 1.170.650.64 query7 0.020.020.01 query8 0.040.030.03 query9 0.590.510.51 query10 0.550.570.56 query11 0.140.100.11 query12 0.130.110.11 query13 0.600.610.61 query14 2.712.722.86 query15 0.890.820.83 query16 0.380.370.36 query17 1.071.071.05 query18 0.220.190.21 query19 1.971.871.98 query20 0.010.010.02 query21 15.37 0.590.59 query22 2.701.581.82 query23 16.98 0.940.77 query24 3.281.281.28 query25 0.270.170.12 query26 0.530.130.14 query27 0.040.040.05 query28 10.15 1.111.08 query29 12.57 3.363.36 query30 0.240.060.07 query31 2.880.390.38 query32 3.280.470.46 query33 2.903.043.08 query34 17.25 4.444.51 query35 4.454.494.49 query36 0.700.480.48 query37 0.090.060.06 query38 0.040.030.04 query39 0.030.020.02 query40 0.170.130.12 query41 0.080.030.02 query42 0.030.020.02 query43 0.030.030.03 Total cold run time: 106.94 s Total hot run time: 32.81 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](docker)Modify the init_be and start_be scripts to meet the requirements for rapid Docker startup. [doris]
github-actions[bot] commented on PR #45269: URL: https://github.com/apache/doris/pull/45269#issuecomment-2535885941 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](index compaction)Add index compaction exception fault injection cases [doris]
doris-robot commented on PR #45127: URL: https://github.com/apache/doris/pull/45127#issuecomment-2535908757 TeamCity be ut coverage result: Function Coverage: 38.75% (10103/26074) Line Coverage: 29.68% (84778/285612) Region Coverage: 28.74% (43505/151361) Branch Coverage: 25.30% (22099/87350) Coverage Report: http://coverage.selectdb-in.cc/coverage/a2809702274224954d998a641642e5cc456d0df9_a2809702274224954d998a641642e5cc456d0df9/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](index compaction)Add index compaction exception fault injection cases [doris]
doris-robot commented on PR #45127: URL: https://github.com/apache/doris/pull/45127#issuecomment-2535910388 ClickBench: Total hot run time: 33.72 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit a2809702274224954d998a641642e5cc456d0df9, data reload: false query1 0.040.050.03 query2 0.060.030.03 query3 0.230.080.06 query4 1.610.100.11 query5 0.430.400.42 query6 1.170.660.64 query7 0.030.020.02 query8 0.050.030.04 query9 0.580.510.50 query10 0.550.590.55 query11 0.150.110.11 query12 0.140.100.11 query13 0.600.600.60 query14 2.712.802.84 query15 0.910.820.82 query16 0.370.400.40 query17 1.071.111.00 query18 0.230.210.21 query19 2.001.882.04 query20 0.020.010.01 query21 15.36 0.580.57 query22 2.361.942.01 query23 17.02 0.980.71 query24 2.921.972.19 query25 0.290.130.20 query26 0.510.150.14 query27 0.070.040.04 query28 9.321.091.07 query29 12.53 3.323.28 query30 0.250.060.06 query31 2.860.390.38 query32 3.280.450.45 query33 2.952.963.06 query34 17.14 4.454.46 query35 4.484.484.48 query36 0.680.490.51 query37 0.090.060.06 query38 0.040.030.04 query39 0.040.020.02 query40 0.170.130.12 query41 0.080.030.03 query42 0.040.020.02 query43 0.030.040.03 Total cold run time: 105.46 s Total hot run time: 33.72 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [regression-test](fix) two tests using same table [doris]
shuke987 opened a new pull request, #45312: URL: https://github.com/apache/doris/pull/45312 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: case bug. ### Release note None ### Check List (For Author) - Test - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [x] No. - [ ] Yes. - Does this need documentation? - [x] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](fix) two tests using same table [doris]
doris-robot commented on PR #45312: URL: https://github.com/apache/doris/pull/45312#issuecomment-2535911388 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tabletScheduler) Fix addTablet dead lock in tabletScheduler [doris]
github-actions[bot] commented on PR #45298: URL: https://github.com/apache/doris/pull/45298#issuecomment-2535911247 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](fix) two tests using same table [doris]
shuke987 commented on PR #45312: URL: https://github.com/apache/doris/pull/45312#issuecomment-2535924151 run skipall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](fix) two tests using same table [doris]
github-actions[bot] commented on PR #45312: URL: https://github.com/apache/doris/pull/45312#issuecomment-2535934818 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](fix) two tests using same table [doris]
github-actions[bot] commented on PR #45312: URL: https://github.com/apache/doris/pull/45312#issuecomment-2535934935 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](fix) two tests using same table [doris]
shuke987 commented on PR #45312: URL: https://github.com/apache/doris/pull/45312#issuecomment-2535924352 skip buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [cloud] update compute group doc [doris-website]
deardeng opened a new pull request, #1508: URL: https://github.com/apache/doris-website/pull/1508 ## Versions - [ ] dev - [ ] 3.0 - [ ] 2.1 - [ ] 2.0 ## Languages - [ ] Chinese - [ ] English ## Docs Checklist - [ ] Checked by AI - [ ] Test Cases Built -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [regression-test](fix) two tests using same table (#45312)
This is an automated email from the ASF dual-hosted git repository.
hellostephen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 88b36177e81 [regression-test](fix) two tests using same table (#45312)
88b36177e81 is described below
commit 88b36177e81e7ab83a42ffb18322d990dd0d4c16
Author: shuke
AuthorDate: Wed Dec 11 21:09:01 2024 +0800
[regression-test](fix) two tests using same table (#45312)
---
regression-test/suites/correctness_p0/test_bitmap_intersect.groovy | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/regression-test/suites/correctness_p0/test_bitmap_intersect.groovy
b/regression-test/suites/correctness_p0/test_bitmap_intersect.groovy
index 4023e5dac8c..6d3866fea86 100644
--- a/regression-test/suites/correctness_p0/test_bitmap_intersect.groovy
+++ b/regression-test/suites/correctness_p0/test_bitmap_intersect.groovy
@@ -16,7 +16,7 @@
// under the License.
suite("test_bitmap_intersect") {
- def tableName = "test_bitmap"
+ def tableName = "test_bitmap_intersect"
sql """ DROP TABLE IF EXISTS ${tableName} """
@@ -35,4 +35,4 @@
select bitmap_to_string(bitmap_intersect(user_ids)) from ( select tag,
bitmap_union(user_ids) user_ids
from ${tableName} group by tag ) t; """
- }
\ No newline at end of file
+ }
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](function) fix first/last value return error with ignore null [doris]
zhangstar333 commented on PR #44996: URL: https://github.com/apache/doris/pull/44996#issuecomment-2535948571 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](fix) two tests using same table [doris]
hello-stephen merged PR #45312: URL: https://github.com/apache/doris/pull/45312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [cloud] update compute group doc [doris-website]
gavinchou commented on code in PR #1508: URL: https://github.com/apache/doris-website/pull/1508#discussion_r1880172594 ## i18n/zh-CN/docusaurus-plugin-content-docs/current/compute-storage-decoupled/managing-compute-cluster.md: ## @@ -33,17 +33,43 @@ under the License. *注意* 3.0.2 之前的版本中叫做计算集群（Compute Cluster）。 +## 计算组使用场景 + +在多计算组的架构下，可以通过将一个或多个无状态的 BE 节点组成计算集群，利用计算集群指定语句 (use @) 将特定负载分配到特定的计算集群中，从而实现多导入和查询负载的物理隔离。 + +假设当前有两个计算集群：C1 和 C2。 + +- **读读隔离**：在发起两个大型查询之前，分别使用 `use @c1` 和 `use @c2`，确保两个查询在不同的计算节点上运行，从而避免在访问相同数据集时因 CPU 和内存等资源竞争而相互干扰。 + +- **读写隔离**：Doris 的数据导入会消耗大量资源，尤其是在大数据量和高频导入的场景中。为了避免查询和导入之间的资源竞争，可以通过 `use @c1` 和 `use @c2` 指定查询在 C1 上执行，导入在 C2 上执行。同时，C1 计算集群可以访问 C2 计算集群中新导入的数据。 + +- **写写隔离**：与读写隔离类似，导入之间也可以进行隔离。例如，当系统中存在高频小量导入和大批量导入时，批量导入通常耗时较长且重试成本高，而高频小量导入耗时短且重试成本低。为了避免小量导入对批量导入的干扰，可以通过 `use @c1` 和 `use @c2`，将小量导入指定到 C1 上执行，批量导入指定到 C2 上执行。 + + +## 默认计算组的选择机制 + +当用户未明确设置默认计算组时，系统将自动为用户选择一个具有 Active BE 且用户具有使用权限的计算组。在特定会话中确定默认计算组后，默认计算组将在该会话期间保持不变，除非用户显式更改了默认设置。 + +在不同次的会话中，若发生以下情况，系统可能会自动更改用户的默认计算组： + +- 用户失去了在上次会话中所选择默认计算组的使用权限 +- 有计算组被添加或移除 +- 上次所选择的默认计算组不再具有 Active BE Review Comment: 什么是 active 的BE? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Bug](function) fix wrong result on group_concat with distinct+order_by+nullable [doris]
BiteThet opened a new pull request, #45313: URL: https://github.com/apache/doris/pull/45313 ### What problem does this PR solve? fix wrong result on group_concat with distinct+order_by+nullable Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](function) fix wrong result on group_concat with distinct+order_by+nullable [doris]
BiteThet commented on PR #45313: URL: https://github.com/apache/doris/pull/45313#issuecomment-2535953623 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](function) fix first/last value return error with ignore null [doris]
github-actions[bot] commented on PR #44996: URL: https://github.com/apache/doris/pull/44996#issuecomment-2535956365 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Bug](case) fix conflict table name between test_bitmap_intersect and test_bitmap… [doris]
BiteThet opened a new pull request, #45314: URL: https://github.com/apache/doris/pull/45314 …_serialize ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](case) fix conflict table name between test_bitmap_intersect and test_bitmap… [doris]
BiteThet commented on PR #45314: URL: https://github.com/apache/doris/pull/45314#issuecomment-2535957936 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [cloud] update compute group doc [doris-website]
gavinchou commented on code in PR #1508: URL: https://github.com/apache/doris-website/pull/1508#discussion_r1880173875 ## i18n/zh-CN/docusaurus-plugin-content-docs/current/compute-storage-decoupled/managing-compute-cluster.md: ## @@ -33,17 +33,43 @@ under the License. *注意* 3.0.2 之前的版本中叫做计算集群（Compute Cluster）。 +## 计算组使用场景 + +在多计算组的架构下，可以通过将一个或多个无状态的 BE 节点组成计算集群，利用计算集群指定语句 (use @) 将特定负载分配到特定的计算集群中，从而实现多导入和查询负载的物理隔离。 + +假设当前有两个计算集群：C1 和 C2。 + +- **读读隔离**：在发起两个大型查询之前，分别使用 `use @c1` 和 `use @c2`，确保两个查询在不同的计算节点上运行，从而避免在访问相同数据集时因 CPU 和内存等资源竞争而相互干扰。 + +- **读写隔离**：Doris 的数据导入会消耗大量资源，尤其是在大数据量和高频导入的场景中。为了避免查询和导入之间的资源竞争，可以通过 `use @c1` 和 `use @c2` 指定查询在 C1 上执行，导入在 C2 上执行。同时，C1 计算集群可以访问 C2 计算集群中新导入的数据。 + +- **写写隔离**：与读写隔离类似，导入之间也可以进行隔离。例如，当系统中存在高频小量导入和大批量导入时，批量导入通常耗时较长且重试成本高，而高频小量导入耗时短且重试成本低。为了避免小量导入对批量导入的干扰，可以通过 `use @c1` 和 `use @c2`，将小量导入指定到 C1 上执行，批量导入指定到 C2 上执行。 + + +## 默认计算组的选择机制 + +当用户未明确设置默认计算组时，系统将自动为用户选择一个具有 Active BE 且用户具有使用权限的计算组。在特定会话中确定默认计算组后，默认计算组将在该会话期间保持不变，除非用户显式更改了默认设置。 + +在不同次的会话中，若发生以下情况，系统可能会自动更改用户的默认计算组： + +- 用户失去了在上次会话中所选择默认计算组的使用权限 +- 有计算组被添加或移除 +- 上次所选择的默认计算组不再具有 Active BE + +其中，情况一和情况二必定会导致系统自动选择的默认计算组更改，情况三可能会导致更改。 + ## 查看所有计算组 -可通过 `SHOW COMPUTE GROUPS` 查看当前仓库拥有的所有计算组。 +可通过 `SHOW COMPUTE GROUPS` 查看当前仓库拥有的所有计算组，返回结果根据当前用户权限不同，可能会有所不同，例如，当前用户不具备 `ADMIN` 权限，则不会返回所有计算组，admin 权限的用户会返回所有计算组。 Review Comment: 普通用户show compute group 又是什么效果? ## i18n/zh-CN/docusaurus-plugin-content-docs/current/compute-storage-decoupled/managing-compute-cluster.md: ## @@ -33,17 +33,43 @@ under the License. *注意* 3.0.2 之前的版本中叫做计算集群（Compute Cluster）。 +## 计算组使用场景 + +在多计算组的架构下，可以通过将一个或多个无状态的 BE 节点组成计算集群，利用计算集群指定语句 (use @) 将特定负载分配到特定的计算集群中，从而实现多导入和查询负载的物理隔离。 + +假设当前有两个计算集群：C1 和 C2。 + +- **读读隔离**：在发起两个大型查询之前，分别使用 `use @c1` 和 `use @c2`，确保两个查询在不同的计算节点上运行，从而避免在访问相同数据集时因 CPU 和内存等资源竞争而相互干扰。 + +- **读写隔离**：Doris 的数据导入会消耗大量资源，尤其是在大数据量和高频导入的场景中。为了避免查询和导入之间的资源竞争，可以通过 `use @c1` 和 `use @c2` 指定查询在 C1 上执行，导入在 C2 上执行。同时，C1 计算集群可以访问 C2 计算集群中新导入的数据。 + +- **写写隔离**：与读写隔离类似，导入之间也可以进行隔离。例如，当系统中存在高频小量导入和大批量导入时，批量导入通常耗时较长且重试成本高，而高频小量导入耗时短且重试成本低。为了避免小量导入对批量导入的干扰，可以通过 `use @c1` 和 `use @c2`，将小量导入指定到 C1 上执行，批量导入指定到 C2 上执行。 + + +## 默认计算组的选择机制 + +当用户未明确设置默认计算组时，系统将自动为用户选择一个具有 Active BE 且用户具有使用权限的计算组。在特定会话中确定默认计算组后，默认计算组将在该会话期间保持不变，除非用户显式更改了默认设置。 Review Comment: 这里加一个 链接 怎么设置默认 和mysql 用户绑定的计算组 后续 允许设置多个默认compute group之后 也要把文档改下(现在先不改) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](function) fix wrong result on group_concat with distinct+order_by+nullable [doris]
github-actions[bot] commented on PR #45313: URL: https://github.com/apache/doris/pull/45313#issuecomment-2535963591 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](regression-test) add a regression test case for s3 vault [doris]
dataroaring commented on PR #45261: URL: https://github.com/apache/doris/pull/45261#issuecomment-2535964968 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](fix) two tests using same table [doris]
shuke987 commented on PR #45312: URL: https://github.com/apache/doris/pull/45312#issuecomment-2535911457 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]
doris-robot commented on PR #44994: URL: https://github.com/apache/doris/pull/44994#issuecomment-2535980229 TeamCity be ut coverage result: Function Coverage: 38.81% (10119/26071) Line Coverage: 29.77% (85005/285535) Region Coverage: 28.79% (43575/151329) Branch Coverage: 25.35% (22135/87332) Coverage Report: http://coverage.selectdb-in.cc/coverage/80270e677fbe0e03547b258c0e4fbb9c36cba70f_80270e677fbe0e03547b258c0e4fbb9c36cba70f/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](function) fix first/last value return error with ignore null [doris]
doris-robot commented on PR #44996: URL: https://github.com/apache/doris/pull/44996#issuecomment-2536020836 TeamCity be ut coverage result: Function Coverage: 38.75% (10104/26074) Line Coverage: 29.69% (84768/285518) Region Coverage: 28.74% (43501/151337) Branch Coverage: 25.30% (22098/87330) Coverage Report: http://coverage.selectdb-in.cc/coverage/32445f19458ccfbc21359c3c5022b09b32f5e196_32445f19458ccfbc21359c3c5022b09b32f5e196/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) range inference convert isnull(k) and null to EmptyValue [doris]
yujun777 commented on PR #45310: URL: https://github.com/apache/doris/pull/45310#issuecomment-2536022040 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) range inference convert isnull(k) and null to EmptyValue [doris]
yujun777 commented on PR #45310: URL: https://github.com/apache/doris/pull/45310#issuecomment-2536031469 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](nereids) add rule count distinct split [doris]
feiniaofeiafei commented on PR #45209: URL: https://github.com/apache/doris/pull/45209#issuecomment-2536032342 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](nereids) add rule count distinct split [doris]
feiniaofeiafei commented on PR #45209: URL: https://github.com/apache/doris/pull/45209#issuecomment-2536032949 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](nereids) add rule count distinct split [doris]
feiniaofeiafei commented on PR #45209: URL: https://github.com/apache/doris/pull/45209#issuecomment-2536031371 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](checkpoint) add enable_checkpoint config [doris]
github-actions[bot] commented on PR #45301: URL: https://github.com/apache/doris/pull/45301#issuecomment-2536045998 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](checkpoint) add enable_checkpoint config [doris]
github-actions[bot] commented on PR #45301: URL: https://github.com/apache/doris/pull/45301#issuecomment-2536046214 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](sql cache) Reorganize the chapter on SQL Cache [doris-website]
KassieZ merged PR #1392: URL: https://github.com/apache/doris-website/pull/1392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-website) branch master updated: [opt](sql cache) Reorganize the chapter on SQL Cache (#1392)
This is an automated email from the ASF dual-hosted git repository.
kassiez pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris-website.git
The following commit(s) were added to refs/heads/master by this push:
new 29834964ed6 [opt](sql cache) Reorganize the chapter on SQL Cache
(#1392)
29834964ed6 is described below
commit 29834964ed6a036d6b07ded38aa790ce660c264b
Author: morrySnow
AuthorDate: Wed Dec 11 21:56:19 2024 +0800
[opt](sql cache) Reorganize the chapter on SQL Cache (#1392)
# Versions
- [x] dev
- [x] 3.0
- [x] 2.1
- [ ] 2.0
# Languages
- [x] Chinese
- [x] English
---
docs/query-acceleration/sql-cache-manual.md| 34 --
.../current/query-acceleration/sql-cache-manual.md | 33 +++--
.../query-acceleration/sql-cache-manual.md | 33 +++--
.../query-acceleration/sql-cache-manual.md | 33 +++--
.../query-acceleration/sql-cache-manual.md | 34 --
.../query-acceleration/sql-cache-manual.md | 34 --
6 files changed, 108 insertions(+), 93 deletions(-)
diff --git a/docs/query-acceleration/sql-cache-manual.md
b/docs/query-acceleration/sql-cache-manual.md
index a9fcbda5aec..916e9f65211 100644
--- a/docs/query-acceleration/sql-cache-manual.md
+++ b/docs/query-acceleration/sql-cache-manual.md
@@ -24,6 +24,8 @@ specific language governing permissions and limitations
under the License.
-->
+## Description
+
SQL Cache is a query optimization mechanism provided by Doris that can
significantly enhance query performance. It reduces redundant computations by
caching query results, making it suitable for scenarios where data update
frequency is low.
SQL Cache stores and retrieves caches based on the following key factors:
@@ -50,6 +52,18 @@ SQL Cache is highly suitable for T+1 update scenarios. Data
is updated early in
Currently, SQL Cache supports both internal OlapTables and external Hive
tables.
+## Usage Limitations
+
+### Non-Deterministic Functions
+
+Non-deterministic functions refer to those whose computation results do not
form a fixed relationship with their input parameters.
+
+Take the common function `select now()` as an example. It returns the current
date and time. Since this function returns different results when executed at
different times, its return value is dynamically changing. The `now` function
returns time at the second level, so SQL Cache from the previous second can be
reused within the same second; however, a new SQL Cache needs to be created for
the next second.
+
+To optimize cache utilization, it is recommended to convert such fine-grained
time into coarse-grained time, such as using `select * from tbl where
dt=date(now())`. In this case, queries within the same day can leverage the SQL
Cache.
+
+In contrast, the `random()` function is difficult to utilize Cache because its
results vary each time it is executed. Therefore, the use of such
non-deterministic functions in queries should be avoided as much as possible.
+
## Principles
### BE Principle
@@ -70,7 +84,7 @@ When the BE returns the computation results to the FE, the FE
is responsible for
Additionally, if the SQL optimization phase determines that the query results
contain only 0 or 1 row of data, the FE will choose to store these results in
its memory to respond more quickly to potential future identical queries.
-## Best Practices
+## Get Started
### Enabling and Disabling SQL Cache
@@ -147,7 +161,7 @@ Execution Summary:
Both methods provide effective means for users to verify whether queries
utilize the SQL Cache, helping users better assess query performance and
optimize query strategies.
-### Statistics on Cache Metrics
+## Metrics and Monitor
**1. The HTTP interface on the FE `http://${FE_IP}:${FE_HTTP_PORT}/metrics`
returns two relevant metrics:**
@@ -181,6 +195,8 @@ Different caches may be stored in different BEs, so metrics
from all BEs need to
:::
+## Memory Control
+
### FE Memory Control
In FE, the metadata information of Cache is set to weak references. When FE
memory is insufficient, the system will automatically release the least
recently used Cache metadata. Additionally, users can further limit FE memory
usage by executing the following SQL statements. This configuration takes
effect in real-time and needs to be set for each FE. For persistent
configuration, it should be saved in the fe.conf file.
@@ -214,7 +230,7 @@ ADMIN SET FRONTEND CONFIG
('cache_result_max_row_count'='3000');
ADMIN SET FRONTEND CONFIG ('cache_result_max_data_size'='31457280');
```
-### Troubleshooting Cache Invalidation
+## Troubleshooting Cache Invalidation
The reasons for cache invalidation typically include the following:
@@ -233,15 +249,3 @@ The reasons for cache invalidation typically include the
following
Re: [PR] [Enhancement](multi-catalog) Add legavy hive compactible catalog property to resolve reading issue of Hive 2.0.0 to 2.2.0 before the ORC-125 fix. [doris]
kaka11chen commented on PR #45311: URL: https://github.com/apache/doris/pull/45311#issuecomment-2536058768 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improment]add be avail cpu num metric [doris]
doris-robot commented on PR #45284: URL: https://github.com/apache/doris/pull/45284#issuecomment-2536060968 TeamCity be ut coverage result: Function Coverage: 38.75% (10105/26076) Line Coverage: 29.69% (84807/285601) Region Coverage: 28.76% (43531/151384) Branch Coverage: 25.31% (22119/87376) Coverage Report: http://coverage.selectdb-in.cc/coverage/8efcf61669132ff83a6c0b400dfdf71f7bf289c1_8efcf61669132ff83a6c0b400dfdf71f7bf289c1/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] [ccr] add support for restore to ccr [doris]
github-actions[bot] commented on PR #45162: URL: https://github.com/apache/doris/pull/45162#issuecomment-2536061360 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](regression) Enable batch_download_file in p0/p1 pipeline [doris]
dataroaring merged PR #45295: URL: https://github.com/apache/doris/pull/45295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (88b36177e81 -> 279c5b7e500)
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 88b36177e81 [regression-test](fix) two tests using same table (#45312) add 279c5b7e500 [chore](regression) Enable batch_download_file in p0/p1 pipeline (#45295) No new revisions were added by this update. Summary of changes: regression-test/pipeline/p0/conf/be.conf | 4 regression-test/pipeline/p1/conf/be.conf | 4 2 files changed, 8 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45295-branch-3.0 created (now 66975825f6d)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-45295-branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git at 66975825f6d branch-3.0: [test](index compaction)Add exception cases for index compaction #45056 (#45192) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](backup) Add config ignore_backup_tmp_partitions [doris]
github-actions[bot] commented on PR #45240: URL: https://github.com/apache/doris/pull/45240#issuecomment-2536070892 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](backup) Add config ignore_backup_tmp_partitions [doris]
github-actions[bot] commented on PR #45240: URL: https://github.com/apache/doris/pull/45240#issuecomment-2536070979 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](backup) Backup and restore cooldown data [doris]
justfortaste commented on PR #44993: URL: https://github.com/apache/doris/pull/44993#issuecomment-2536073226 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) range inference convert isnull(k) and null to EmptyValue [doris]
yujun777 commented on PR #45310: URL: https://github.com/apache/doris/pull/45310#issuecomment-2536077651 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix] Add column with default value string throw exception [doris]
dataroaring merged PR #45000: URL: https://github.com/apache/doris/pull/45000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [Fix] Add column with default value string throw exception #45000 [doris]
doris-robot commented on PR #45315: URL: https://github.com/apache/doris/pull/45315#issuecomment-2536093735 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] add docker quick start [doris-website]
KassieZ commented on code in PR #1506: URL: https://github.com/apache/doris-website/pull/1506#discussion_r1880256101 ## common_docs_zh/gettingStarted/quick-start.md: ## @@ -27,6 +27,90 @@ under the License. 这个简短的指南将告诉你如何下载 Apache Doris 最新稳定版本，在单节点上安装并运行它，包括创建数据库、数据表、导入数据及查询等。 +# Docker 快速体验 + +- 自 Apache Doris 2.1.8 版本起，官方镜像将满足使用 Docker 或 Docker-Compose 快速拉起 1 FE 1 BE 的能力 + +- 但请注意，该方案强烈不建议生产部署使用，仅适用于快速学习、开发以及功能调试所用！ Review Comment: 注意、提示建议通过提示框展示。强烈不建议、适用于...所用略有口语化，建议修改。即 ： :::caution 注意 本方案不建议用于生产部署，仅限于快速学习、开发测试及功能验证阶段使用。 ::: ## common_docs_zh/gettingStarted/quick-start.md: ## @@ -27,6 +27,90 @@ under the License. 这个简短的指南将告诉你如何下载 Apache Doris 最新稳定版本，在单节点上安装并运行它，包括创建数据库、数据表、导入数据及查询等。 +# Docker 快速体验 Review Comment: 正文所有标题从二级开始，且标题建议以动词+主题词、即 `## 使用 Docker 快速体验` ## common_docs_zh/gettingStarted/quick-start.md: ## @@ -27,6 +27,90 @@ under the License. 这个简短的指南将告诉你如何下载 Apache Doris 最新稳定版本，在单节点上安装并运行它，包括创建数据库、数据表、导入数据及查询等。 +# Docker 快速体验 + +- 自 Apache Doris 2.1.8 版本起，官方镜像将满足使用 Docker 或 Docker-Compose 快速拉起 1 FE 1 BE 的能力 + +- 但请注意，该方案强烈不建议生产部署使用，仅适用于快速学习、开发以及功能调试所用！ + +使用 Docker run 命令： + +```dockerfile +docker network create --driver bridge --subnet=172.20.80.0/24 doris-network + +docker run -itd \ +--name=fe \ +--env FE_MASTER_IP="172.20.80.2" \ +--env FE_CURRENT_IP="172.20.80.2" \ +--env FE_MASTER_PORT="9010" \ +--env FE_CURRENT_PORT="9010" \ +-p 8030:8030 \ +-p 9030:9030 \ +--network=doris-network \ +--ip=172.20.80.2 \ +apache/doris:doris-fe-2.1.8 + +docker run -itd \ +--name=be \ +--env FE_MASTER_IP="172.20.80.2" \ +--env BE_IP="172.20.80.3" \ +--env BE_PORT="9050" \ +-p 8040:8040 \ +--network=doris-network \ +--ip=172.20.80.3 \ +apache/doris:doris-fe-2.1.8 Review Comment: 在 be 服务的定义中，使用了 apache/doris:doris-fe-2.1.8，这实际上是FE的镜像，BE应该使用 apache/doris:doris-be-2.1.8？ ## common_docs_zh/gettingStarted/quick-start.md: ## @@ -27,6 +27,90 @@ under the License. 这个简短的指南将告诉你如何下载 Apache Doris 最新稳定版本，在单节点上安装并运行它，包括创建数据库、数据表、导入数据及查询等。 +# Docker 快速体验 + +- 自 Apache Doris 2.1.8 版本起，官方镜像将满足使用 Docker 或 Docker-Compose 快速拉起 1 FE 1 BE 的能力 + +- 但请注意，该方案强烈不建议生产部署使用，仅适用于快速学习、开发以及功能调试所用！ + +使用 Docker run 命令： + +```dockerfile +docker network create --driver bridge --subnet=172.20.80.0/24 doris-network + +docker run -itd \ +--name=fe \ +--env FE_MASTER_IP="172.20.80.2" \ +--env FE_CURRENT_IP="172.20.80.2" \ +--env FE_MASTER_PORT="9010" \ +--env FE_CURRENT_PORT="9010" \ +-p 8030:8030 \ +-p 9030:9030 \ +--network=doris-network \ +--ip=172.20.80.2 \ +apache/doris:doris-fe-2.1.8 + +docker run -itd \ +--name=be \ +--env FE_MASTER_IP="172.20.80.2" \ +--env BE_IP="172.20.80.3" \ +--env BE_PORT="9050" \ +-p 8040:8040 \ +--network=doris-network \ +--ip=172.20.80.3 \ +apache/doris:doris-fe-2.1.8 +``` + +Docker-Compose Yaml 脚本： + +```dockerfile +version: "3" + services: +fe: + image:apache/doris:doris-fe-2.1.8 + hostname:fe + networks: +my-network: Review Comment: 在 Docker 命令中创建的网络名称是 doris-network，在 Yaml 文件中定义的网络名称也是 doris-network，这里其实是一致的。但是在 services 部分引用的网络名称是 my-network，这是不一致的。 ## common_docs_zh/gettingStarted/quick-start.md: ## @@ -27,6 +27,90 @@ under the License. 这个简短的指南将告诉你如何下载 Apache Doris 最新稳定版本，在单节点上安装并运行它，包括创建数据库、数据表、导入数据及查询等。 +# Docker 快速体验 + +- 自 Apache Doris 2.1.8 版本起，官方镜像将满足使用 Docker 或 Docker-Compose 快速拉起 1 FE 1 BE 的能力 + +- 但请注意，该方案强烈不建议生产部署使用，仅适用于快速学习、开发以及功能调试所用！ + +使用 Docker run 命令： + +```dockerfile Review Comment: Docker 命令块应该使用 shell 而不是 dockerfile。 ## common_docs_zh/gettingStarted/quick-start.md: ## @@ -27,6 +27,90 @@ under the License. 这个简短的指南将告诉你如何下载 Apache Doris 最新稳定版本，在单节点上安装并运行它，包括创建数据库、数据表、导入数据及查询等。 +# Docker 快速体验 + +- 自 Apache Doris 2.1.8 版本起，官方镜像将满足使用 Docker 或 Docker-Compose 快速拉起 1 FE 1 BE 的能力 + +- 但请注意，该方案强烈不建议生产部署使用，仅适用于快速学习、开发以及功能调试所用！ + +使用 Docker run 命令： + +```dockerfile +docker network create --driver bridge --subnet=172.20.80.0/24 doris-network + +docker run -itd \ +--name=fe \ +--env FE_MASTER_IP="172.20.80.2" \ +--env FE_CURRENT_IP="172.20.80.2" \ +--env FE_MASTER_PORT="9010" \ +--env FE_CURRENT_PORT="9010" \ +-p 8030:8030 \ +-p 9030:9030 \ +--network=doris-network \ +--ip=172.20.80.2 \ +apache/doris:doris-fe-2.1.8 + +docker run -itd \ +--name=be \ +--env FE_MASTER_IP="172.20.80.2" \ +--env BE_IP="172.20.80.3" \ +--env BE_PORT="9050" \ +-p 8040:8040 \ +--network=doris-network \ +--ip=172.20.80.3 \ +apache/doris:doris-fe-2.1.8 +``` + +Docker-Compose Yaml 脚本： + +```dockerfile Review Comment: Docker-Compose Yaml 脚本块应该使用 yaml 而不是 dockerfile。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --
Re: [PR] [Enhancement] [ccr] add support for restore to ccr [doris]
github-actions[bot] commented on PR #45162: URL: https://github.com/apache/doris/pull/45162#issuecomment-2536089876 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] add docker quick start [doris-website]
KassieZ commented on PR #1506: URL: https://github.com/apache/doris-website/pull/1506#issuecomment-2536096123 Please also fix the conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] branch-2.1: [Fix] Add column with default value string throw exception #45000 [doris]
github-actions[bot] opened a new pull request, #45316: URL: https://github.com/apache/doris/pull/45316 Cherry-picked from #45000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45000-branch-2.1 updated (fb407f2e940 -> 947105e9a5b)
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch auto-pick-45000-branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
from fb407f2e940 [opt](lambda) let lambda expression support refer outer
slot (#45186)
add 947105e9a5b [Fix] Add column with default value string throw exception
(#45000)
No new revisions were added by this update.
Summary of changes:
.../java/org/apache/doris/analysis/ColumnDef.java | 3 ++-
...=> test_alter_add_column_default_value_str.out} | 12 +--
...test_alter_add_column_default_value_str.groovy} | 24 ++
3 files changed, 23 insertions(+), 16 deletions(-)
copy regression-test/data/alter_p0/{test_alter_add_column_default_value.out =>
test_alter_add_column_default_value_str.out} (50%)
copy
regression-test/suites/alter_p0/{test_alter_add_column_default_value.groovy =>
test_alter_add_column_default_value_str.groovy} (64%)
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](framework) try to disable defining global variable in test groovy files [doris]
shuke987 commented on PR #44576: URL: https://github.com/apache/doris/pull/44576#issuecomment-2536094302 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45000-branch-3.0 created (now 66975825f6d)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-45000-branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git at 66975825f6d branch-3.0: [test](index compaction)Add exception cases for index compaction #45056 (#45192) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] branch-3.0: [Fix] Add column with default value string throw exception #45000 [doris]
github-actions[bot] opened a new pull request, #45315: URL: https://github.com/apache/doris/pull/45315 Cherry-picked from #45000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45000-branch-3.0 updated (66975825f6d -> 0cd8a525e55)
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch auto-pick-45000-branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
from 66975825f6d branch-3.0: [test](index compaction)Add exception cases
for index compaction #45056 (#45192)
add 0cd8a525e55 [Fix] Add column with default value string throw exception
(#45000)
No new revisions were added by this update.
Summary of changes:
.../java/org/apache/doris/analysis/ColumnDef.java | 3 ++-
...=> test_alter_add_column_default_value_str.out} | 12 +--
...test_alter_add_column_default_value_str.groovy} | 24 ++
3 files changed, 23 insertions(+), 16 deletions(-)
copy regression-test/data/alter_p0/{test_alter_add_column_default_value.out =>
test_alter_add_column_default_value_str.out} (50%)
copy
regression-test/suites/alter_p0/{test_alter_add_column_default_value.groovy =>
test_alter_add_column_default_value_str.groovy} (64%)
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [Fix] Add column with default value string throw exception (#45000)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 32fa95d2862 [Fix] Add column with default value string throw exception
(#45000)
32fa95d2862 is described below
commit 32fa95d28623547395f5cc65ff16a32a1a24df69
Author: Uniqueyou <134280716+wyxxx...@users.noreply.github.com>
AuthorDate: Wed Dec 11 22:09:06 2024 +0800
[Fix] Add column with default value string throw exception (#45000)
```
ALTER TABLE t ADD COLUMN create_time VARCHAR(20) DEFAULT
"CURRENT_TIMESTAMP";
```
```
errCode = 2, detailMessage = Unexpected exception: Cannot invoke
"org.apache.doris.analysis.DefaultValueExprDef.getExprName()" because
"this.defaultValueExprDef" is null
```
---
.../java/org/apache/doris/analysis/ColumnDef.java | 3 +-
.../test_alter_add_column_default_value_str.out| 14 +
.../test_alter_add_column_default_value_str.groovy | 72 ++
3 files changed, 88 insertions(+), 1 deletion(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java
index 93bcb92f580..c2c55c4ce7c 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java
@@ -134,7 +134,8 @@ public class ColumnDef {
}
public boolean isCurrentTimeStamp() {
-return "CURRENT_TIMESTAMP".equals(value) &&
NOW.equals(defaultValueExprDef.getExprName());
+return "CURRENT_TIMESTAMP".equals(value) && defaultValueExprDef !=
null
+&& NOW.equals(defaultValueExprDef.getExprName());
}
public boolean isCurrentTimeStampWithPrecision() {
diff --git
a/regression-test/data/alter_p0/test_alter_add_column_default_value_str.out
b/regression-test/data/alter_p0/test_alter_add_column_default_value_str.out
new file mode 100644
index 000..b180902fd16
--- /dev/null
+++ b/regression-test/data/alter_p0/test_alter_add_column_default_value_str.out
@@ -0,0 +1,14 @@
+-- This file is automatically generated. You should know what you did if you
want to edit this
+-- !select1 --
+1 1 1
+2 2 2
+3 3 3
+
+-- !select4 --
+1 1 1 CURRENT_TIMESTAMP BITMAP_EMPTY
+2 2 2 CURRENT_TIMESTAMP BITMAP_EMPTY
+3 3 3 CURRENT_TIMESTAMP BITMAP_EMPTY
+4 4 4 4 4
+5 5 5 5 5
+6 6 6 6 6
+
diff --git
a/regression-test/suites/alter_p0/test_alter_add_column_default_value_str.groovy
b/regression-test/suites/alter_p0/test_alter_add_column_default_value_str.groovy
new file mode 100644
index 000..f3d03864981
--- /dev/null
+++
b/regression-test/suites/alter_p0/test_alter_add_column_default_value_str.groovy
@@ -0,0 +1,72 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite('test_alter_add_column_default_value_str') {
+def tbl = 'test_alter_add_column_default_value_str_tbl'
+sql "DROP TABLE IF EXISTS ${tbl} FORCE"
+sql """
+CREATE TABLE ${tbl} (
+`k1` BIGINT NOT NULL,
+`v1` BIGINT NULL,
+`v2` INT NULL,
+) ENGINE=OLAP
+UNIQUE KEY(`k1`)
+DISTRIBUTED BY HASH(`k1`) BUCKETS 1
+PROPERTIES (
+"replication_allocation" = "tag.location.default: 1"
+);
+"""
+
+sql """
+INSERT INTO ${tbl} VALUES (1,1,1),(2,2,2),(3,3,3)
+"""
+
+sql """ SYNC """
+
+// Check data before ALTER TABLE
+qt_select1 """ SELECT * FROM ${tbl} ORDER BY k1 """
+def tb1 = sql """ show create table ${tbl}"""
+logger.info("tb1:{}", tb1[0][1])
+assertFalse(tb1[0][1].contains("varchar(20) NOT NULL DEFAULT
\"CURRENT_TIMESTAMP\""))
+assertFalse(tb1[0][1].contains("varchar(20) NOT NULL DEFAULT
\"BITMAP_EMPTY\""))
+
+sql """
+ALTER TABLE ${tbl} add column timestamp_default varchar(20) NOT NULL
default "CURRENT_TIMESTAMP";
+"""
+
+sql "
Re: [PR] branch-3.0: [Fix] Add column with default value string throw exception #45000 [doris]
doris-robot commented on PR #45315: URL: https://github.com/apache/doris/pull/45315#issuecomment-2536094030 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [Fix] Add column with default value string throw exception #45000 [doris]
dataroaring closed pull request #45315: branch-3.0: [Fix] Add column with default value string throw exception #45000 URL: https://github.com/apache/doris/pull/45315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](opt) add debug log [doris]
github-actions[bot] commented on PR #45307: URL: https://github.com/apache/doris/pull/45307#issuecomment-2536106044 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](opt) add debug log [doris]
github-actions[bot] commented on PR #45307: URL: https://github.com/apache/doris/pull/45307#issuecomment-2536105910 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](opt) add debug log [doris]
github-actions[bot] commented on PR #45307: URL: https://github.com/apache/doris/pull/45307#issuecomment-2536105911 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](opt) add debug log [doris]
liaoxin01 merged PR #45307: URL: https://github.com/apache/doris/pull/45307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](opt) add debug log [doris]
github-actions[bot] commented on PR #45307: URL: https://github.com/apache/doris/pull/45307#issuecomment-2536106045 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [regression-test](opt) add debug log (#45307)
This is an automated email from the ASF dual-hosted git repository.
liaoxin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new a4681f3763d [regression-test](opt) add debug log (#45307)
a4681f3763d is described below
commit a4681f3763d1fcb5ee1dea125f286af5da27be9f
Author: shuke
AuthorDate: Wed Dec 11 22:16:06 2024 +0800
[regression-test](opt) add debug log (#45307)
When running stream load in regression tests and loading same file into
different tables, "org.apache.http.ConnectionClosedException: Premature
end of Content-Length delimited message body (expected: 129,961,387;
received: 125,351,592)" maybe met.
This pr add log to try to debug this problem.
---
.../groovy/org/apache/doris/regression/action/StreamLoadAction.groovy| 1 +
1 file changed, 1 insertion(+)
diff --git
a/regression-test/framework/src/main/groovy/org/apache/doris/regression/action/StreamLoadAction.groovy
b/regression-test/framework/src/main/groovy/org/apache/doris/regression/action/StreamLoadAction.groovy
index 70a7f41e82b..97b6d038fa7 100644
---
a/regression-test/framework/src/main/groovy/org/apache/doris/regression/action/StreamLoadAction.groovy
+++
b/regression-test/framework/src/main/groovy/org/apache/doris/regression/action/StreamLoadAction.groovy
@@ -279,6 +279,7 @@ class StreamLoadAction implements SuiteAction {
fileName = cacheHttpFile(client, fileName)
} else {
entity = new InputStreamEntity(httpGetStream(client,
fileName))
+log.info("http entity length is ${entity.contentLength}")
return entity;
}
}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] [ccr] add support for restore to ccr [doris]
Vallishp commented on PR #45162: URL: https://github.com/apache/doris/pull/45162#issuecomment-2536123646 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] add docker quick start [doris-website]
KassieZ commented on PR #1506: URL: https://github.com/apache/doris-website/pull/1506#issuecomment-2536097037 request review @wangtianyi2004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45000-branch-2.1 created (now fb407f2e940)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-45000-branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git at fb407f2e940 [opt](lambda) let lambda expression support refer outer slot (#45186) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](txn insert) txn insert show error url [doris]
liaoxin01 merged PR #45254: URL: https://github.com/apache/doris/pull/45254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [fix](txn insert) txn insert show error url (#45254)
This is an automated email from the ASF dual-hosted git repository.
liaoxin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 1ee8d40617b [fix](txn insert) txn insert show error url (#45254)
1ee8d40617b is described below
commit 1ee8d40617ba6fff14c7cf71ed2c8851126a1c40
Author: meiyi
AuthorDate: Wed Dec 11 22:23:15 2024 +0800
[fix](txn insert) txn insert show error url (#45254)
```
mysql> begin;
mysql> insert into test values('a', 'a', 1);
mysql> commit;
ERROR 1105 (HY000): errCode = 2, detailMessage = [DATA_QUALITY_ERROR]too
many filtered rows, url:
http://172.21.16.12:9082/api/_load_error_log?file=__shard_110/error_log_insert_stmt_txn_insert_ef05df534f6b4ad7-8782cce460d85b4b_733cffdc9392473f_bd6b2ec40c621119
```
---
be/src/runtime/stream_load/stream_load_executor.cpp | 9 +++--
.../suites/insert_p0/transaction/txn_insert.groovy| 15 ++-
2 files changed, 21 insertions(+), 3 deletions(-)
diff --git a/be/src/runtime/stream_load/stream_load_executor.cpp
b/be/src/runtime/stream_load/stream_load_executor.cpp
index 482fadac44e..ad4d22946f1 100644
--- a/be/src/runtime/stream_load/stream_load_executor.cpp
+++ b/be/src/runtime/stream_load/stream_load_executor.cpp
@@ -85,13 +85,18 @@ Status
StreamLoadExecutor::execute_plan_fragment(std::shared_ptrnumber_unselected_rows = state->num_rows_load_unselected();
ctx->loaded_bytes = state->num_bytes_load_total();
int64_t num_selected_rows = ctx->number_total_rows -
ctx->number_unselected_rows;
+ctx->error_url =
to_load_error_http_path(state->get_error_log_file_path());
if (!ctx->group_commit && num_selected_rows > 0 &&
(double)ctx->number_filtered_rows / num_selected_rows >
ctx->max_filter_ratio) {
// NOTE: Do not modify the error message here, for historical
reasons,
// some users may rely on this error message.
-*status = Status::DataQualityError("too many filtered rows");
+if (ctx->need_commit_self) {
+*status =
+Status::DataQualityError("too many filtered rows, url:
" + ctx->error_url);
+} else {
+*status = Status::DataQualityError("too many filtered rows");
+}
}
-ctx->error_url =
to_load_error_http_path(state->get_error_log_file_path());
if (status->ok()) {
DorisMetrics::instance()->stream_receive_bytes_total->increment(ctx->receive_bytes);
diff --git a/regression-test/suites/insert_p0/transaction/txn_insert.groovy
b/regression-test/suites/insert_p0/transaction/txn_insert.groovy
index 424a03ee173..f4c8caa35ba 100644
--- a/regression-test/suites/insert_p0/transaction/txn_insert.groovy
+++ b/regression-test/suites/insert_p0/transaction/txn_insert.groovy
@@ -107,7 +107,7 @@ suite("txn_insert") {
sql """ DROP TABLE IF EXISTS $tableMV """
sql """
create table $tableMV (
-id int default '10',
+id int not null,
c1 int default '10'
) distributed by hash(id, c1)
properties('replication_num'="1");
@@ -122,6 +122,19 @@ suite("txn_insert") {
order_qt_select5 """select * from $tableMV"""
order_qt_select6 """select c1 from $tableMV"""
} while (0);
+do {
+try {
+sql "begin"
+sql """insert into $tableMV values(9, 2), (10, 4)"""
+sql """insert into $tableMV values('aa', 6)"""
+sql "commit"
+} catch (Exception e) {
+sql "rollback"
+logger.info("insert into $tableMV failed: " + e.getMessage())
+assertTrue(e.getMessage().contains("too many filtered rows"))
+assertTrue(e.getMessage().contains("url"))
+}
+} while (0);
// --- insert into select ---
for (int j = 0; j < 3; j++) {
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45254-branch-3.0 created (now 66975825f6d)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-45254-branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git at 66975825f6d branch-3.0: [test](index compaction)Add exception cases for index compaction #45056 (#45192) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](check) Add code check for some mow code [doris]
dataroaring merged PR #45183: URL: https://github.com/apache/doris/pull/45183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [fix](txn insert) txn insert show error url #45254 [doris]
doris-robot commented on PR #45317: URL: https://github.com/apache/doris/pull/45317#issuecomment-2536145338 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] branch-3.0: [fix](txn insert) txn insert show error url #45254 [doris]
github-actions[bot] opened a new pull request, #45317: URL: https://github.com/apache/doris/pull/45317 Cherry-picked from #45254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [fix](txn insert) txn insert show error url #45254 [doris]
doris-robot commented on PR #45317: URL: https://github.com/apache/doris/pull/45317#issuecomment-2536145533 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
