Re: [PR] [feature](nereids) extend infer predicates (#41731) [doris]
feiniaofeiafei commented on PR #42457: URL: https://github.com/apache/doris/pull/42457#issuecomment-2440232540 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Featrue](default value) Add UUID default value [doris]
github-actions[bot] closed pull request #34211: [Featrue](default value) Add UUID default value URL: https://github.com/apache/doris/pull/34211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Featrue](default value) Add UUID default value #34211 [doris]
github-actions[bot] commented on PR #34319: URL: https://github.com/apache/doris/pull/34319#issuecomment-2440236073 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](Show Transaction) fix show transaction issue [doris]
github-actions[bot] closed pull request #34172: [Enhancement](Show Transaction) fix show transaction issue URL: https://github.com/apache/doris/pull/34172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) extend infer predicates (#41731) [doris]
doris-robot commented on PR #42457: URL: https://github.com/apache/doris/pull/42457#issuecomment-2440269355 TPC-H: Total hot run time: 40555 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit b6eb96382ca7e0cbcac17b843789592108fd9697, data reload: false -- Round 1 -- q1 17564 738472267226 q2 2005282 272 272 q3 12341 106411481064 q4 10563 729 739 729 q5 7732287728012801 q6 234 148 144 144 q7 980 604 598 598 q8 9574193119291929 q9 8121636563256325 q10 7002224922802249 q11 440 245 247 245 q12 405 207 209 207 q13 17782 306131133061 q14 251 209 222 209 q15 564 505 512 505 q16 703 595 601 595 q17 995 562 584 562 q18 7241656365456545 q19 4233107510651065 q20 478 193 193 193 q21 3914333730673067 q22 10471015964 964 Total cold run time: 114169 ms Total hot run time: 40555 ms - Round 2, with runtime_filter_mode=off - q1 7359724973437249 q2 353 229 234 229 q3 3034286629222866 q4 2045175817791758 q5 5618570857605708 q6 223 146 146 146 q7 2148174817591748 q8 3228341534553415 q9 8845886488128812 q10 3507350934903490 q11 573 481 483 481 q12 816 592 608 592 q13 16686 311731613117 q14 305 273 280 273 q15 571 517 515 515 q16 698 661 643 643 q17 1821160816201608 q18 7986770776097609 q19 2311154815491548 q20 2075186918401840 q21 5353524852435243 q22 1081100610561006 Total cold run time: 76636 ms Total hot run time: 59896 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) extend infer predicates (#41731) [doris]
doris-robot commented on PR #42457: URL: https://github.com/apache/doris/pull/42457#issuecomment-2440277858 TPC-DS: Total hot run time: 188649 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit b6eb96382ca7e0cbcac17b843789592108fd9697, data reload: false query1 846 393 402 393 query2 6247213620492049 query3 8698205 216 205 query4 33868 23427 23308 23308 query5 3856439 447 439 query6 262 161 160 160 query7 4191301 308 301 query8 295 234 240 234 query9 9561266126742661 query10 475 251 266 251 query11 17800 15195 14962 14962 query12 146 99 105 99 query13 1535414 404 404 query14 9434654570546545 query15 220 173 170 170 query16 7711481 453 453 query17 1479556 565 556 query18 2017346 311 311 query19 218 159 164 159 query20 122 116 118 116 query21 209 117 106 106 query22 4658452145274521 query23 34803 33972 33664 33664 query24 11198 286527772777 query25 608 399 416 399 query26 731 159 165 159 query27 2102299 308 299 query28 6147252124612461 query29 816 428 433 428 query30 253 152 151 151 query31 1036793 779 779 query32 99 54 53 53 query33 666 275 285 275 query34 899 515 508 508 query35 832 730 716 716 query36 1083970 923 923 query37 114 69 69 69 query38 3998382838333828 query39 1486143514411435 query40 204 98 100 98 query41 51 50 48 48 query42 113 102 100 100 query43 519 483 505 483 query44 1144766 770 766 query45 183 166 167 166 query46 1151711 678 678 query47 1906185217971797 query48 447 370 371 370 query49 903 402 389 389 query50 800 400 401 400 query51 7119691768506850 query52 103 89 94 89 query53 259 183 182 182 query54 1196450 435 435 query55 77 80 77 77 query56 265 259 249 249 query57 1190113010871087 query58 237 224 214 214 query59 3220292830542928 query60 274 244 251 244 query61 101 102 105 102 query62 851 655 669 655 query63 211 186 181 181 query64 3607619 599 599 query65 3212320031853185 query66 846 309 298 298 query67 15793 15424 15271 15271 query68 4388536 551 536 query69 418 246 249 246 query70 1181108311161083 query71 368 262 276 262 query72 6609389336373637 query73 756 340 343 340 query74 10153 891087548754 query75 3355259325932593 query76 2303877 947 877 query77 399 257 271 257 query78 10639 960495699569 query79 8733590 592 590 query80 2500406 423 406 query81 582 243 242 242 query82 1686106 122 106 query83 275 140 137 137 query84 292 81 77 77 query85 2164308 273 273 query86 477 301 299 299 query87 4353417342504173 query88 5577235823932358 query89 558 296 287 287 query90 2003186 180 180 query91 174 140 163 140 query92 66 49 47 47 query93 7624531 530 530 query94 887 264 284 264 query95 348 245 246 245 query96 649 278 285 278 query97 3308314931403140 query98 223 195 205 195 query99 1620130112601260 Total cold run time: 311369 ms Total hot run time: 188649 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
hust-hhb commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2440339379 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](delete) Fix static type dispatch by mistake due to typo [doris]
github-actions[bot] commented on PR #42260: URL: https://github.com/apache/doris/pull/42260#issuecomment-2440317172 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) extend infer predicates (#41731) [doris]
feiniaofeiafei commented on PR #42457: URL: https://github.com/apache/doris/pull/42457#issuecomment-2440340766 run cloud_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) extend infer predicates (#41731) [doris]
feiniaofeiafei commented on PR #42457: URL: https://github.com/apache/doris/pull/42457#issuecomment-2440340514 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Impl](Nereids) add nereids gc cost time and be fold const cost time to profile (#42007) [doris]
LiBinfeng-01 commented on PR #42516: URL: https://github.com/apache/doris/pull/42516#issuecomment-2440355685 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Impl](Nereids) add nereids gc cost time and be fold const cost time to profile (#42007) [doris]
LiBinfeng-01 opened a new pull request, #42516: URL: https://github.com/apache/doris/pull/42516 pick:#42007 add Nereids GarbageCollect Time and Nereids BeFoldConst Time to profile ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[I] [Enhancement] (nereids)implement unset command in nereids [doris]
starocean999 opened a new issue, #42517: URL: https://github.com/apache/doris/issues/42517 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description unset command is supported in legacy planner but not in nereids(new doris fe planner). you need implement the following unset command in nereids: [ ] https://github.com/apache/doris/issues/42514 [ ] https://github.com/apache/doris/issues/42515 ### Solution _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Impl](Nereids) add nereids gc cost time and be fold const cost time to profile (#42007) [doris]
LiBinfeng-01 opened a new pull request, #42518: URL: https://github.com/apache/doris/pull/42518 pick: #42007 add Nereids GarbageCollect Time and Nereids BeFoldConst Time to profile ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Impl](Nereids) add nereids gc cost time and be fold const cost time to profile (#42007) [doris]
LiBinfeng-01 commented on PR #42518: URL: https://github.com/apache/doris/pull/42518#issuecomment-2440359623 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](pipeline) Refactor local exchange planning [doris]
github-actions[bot] commented on PR #42482: URL: https://github.com/apache/doris/pull/42482#issuecomment-2440360622 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Impl](Nereids) add nereids gc cost time and be fold const cost time to profile (#42007) [doris]
doris-robot commented on PR #42518: URL: https://github.com/apache/doris/pull/42518#issuecomment-2440359515 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud)Compatibility with the initial default compute group usage [doris]
deardeng commented on code in PR #42504:
URL: https://github.com/apache/doris/pull/42504#discussion_r1818281702
##
regression-test/suites/cloud_p0/auth/test_set_default_cluster.groovy:
##
@@ -0,0 +1,93 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+import org.apache.doris.regression.suite.ClusterOptions
+import org.junit.Assert
+
+suite("test_default_cluster", "docker") {
+def options = new ClusterOptions()
+options.cloudMode = true
+
+def getProperty = { property ->
+def result = null
+result = sql_return_maparray """SHOW PROPERTY"""
+result.find {
+it.Key == property as String
+}
+}
+
+def setAndCheckDefaultCluster = { validCluster ->
+sql """set property 'DEFAULT_CLOUD_CLUSTER' = '$validCluster'"""
+def ret1 = getProperty("default_cloud_cluster")
+def ret2 = getProperty("default_compute_group")
+assertEquals(ret1.Value as String, validCluster)
+assertEquals(ret1.Value as String, ret2.Value as String)
+}
+
+docker(options) {
+// not admin
+def user1 = "default_user1"
+// admin role
+def user2 = "default_user2"
+
+sql """CREATE USER $user1 IDENTIFIED BY 'Cloud123456' DEFAULT ROLE
'admin'"""
+sql """CREATE USER $user2 IDENTIFIED BY 'Cloud123456'"""
+sql """GRANT SELECT_PRIV on *.*.* to ${user2}"""
+
+def clusters = sql " SHOW CLUSTERS "
+assertTrue(!clusters.isEmpty())
+def validCluster = clusters[0][0]
+
+// admin set himself
+setAndCheckDefaultCluster validCluster
+
+// user1
+connectInDocker(user = user1, password = 'Cloud123456') {
+setAndCheckDefaultCluster validCluster
Review Comment:
no,admin role，
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](pipeline) Refactor local exchange planning [doris]
Gabriel39 commented on PR #42482: URL: https://github.com/apache/doris/pull/42482#issuecomment-2440366530 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](flink) Fix scanner be cancelled early on pipelineX [doris]
github-actions[bot] commented on PR #42421: URL: https://github.com/apache/doris/pull/42421#issuecomment-2440370941 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](flink) Fix scanner be cancelled early on pipelineX [doris]
github-actions[bot] commented on PR #42421: URL: https://github.com/apache/doris/pull/42421#issuecomment-2440370887 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](mtmv) Support rewrite by materialized view when join has other join conjuncts [doris]
seawinde commented on PR #41674: URL: https://github.com/apache/doris/pull/41674#issuecomment-2440369995 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt][file cache] Do not return error if file cache can not be created if ignore_broken_disk is set [doris]
github-actions[bot] commented on PR #42145: URL: https://github.com/apache/doris/pull/42145#issuecomment-2440376531 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Impl](Nereids) add nereids gc cost time and be fold const cost time to profile (#42007) [doris]
doris-robot commented on PR #42516: URL: https://github.com/apache/doris/pull/42516#issuecomment-2440355585 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](cache) More metrics for lru cache #42357 [doris]
zhiqiang- commented on PR #42519: URL: https://github.com/apache/doris/pull/42519#issuecomment-2440385370 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-3.0 updated: [improve](common) Add synchronized to avoid concurrent modification #42384 (#42455)
This is an automated email from the ASF dual-hosted git repository.
w41ter pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new fa438c65612 [improve](common) Add synchronized to avoid concurrent
modification #42384 (#42455)
fa438c65612 is described below
commit fa438c65612f99fad1a5fc542f9384feb876e41e
Author: walter
AuthorDate: Mon Oct 28 10:17:27 2024 +0800
[improve](common) Add synchronized to avoid concurrent modification #42384
(#42455)
cherry pick from #42384
---
.../src/main/java/org/apache/doris/common/MarkedCountDownLatch.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/common/MarkedCountDownLatch.java
b/fe/fe-core/src/main/java/org/apache/doris/common/MarkedCountDownLatch.java
index ba407e7f3e1..14641d501d7 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/common/MarkedCountDownLatch.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/common/MarkedCountDownLatch.java
@@ -35,7 +35,7 @@ public class MarkedCountDownLatch extends
CountDownLatch {
marks = HashMultimap.create();
}
-public void addMark(K key, V value) {
+public synchronized void addMark(K key, V value) {
marks.put(key, value);
}
@@ -51,7 +51,7 @@ public class MarkedCountDownLatch extends
CountDownLatch {
return Lists.newArrayList(marks.entries());
}
-public Status getStatus() {
+public synchronized Status getStatus() {
return st;
}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](expr) fix wrong debug string of cast expr and remove useless variable [doris]
github-actions[bot] commented on PR #42489: URL: https://github.com/apache/doris/pull/42489#issuecomment-2440387160 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-3.0 updated: [fix](docker case) Fix `test_storage_medium_has_disk` due to invalid … #42010 (#42390)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new 07f7fcb4747 [fix](docker case) Fix `test_storage_medium_has_disk` due
to invalid … #42010 (#42390)
07f7fcb4747 is described below
commit 07f7fcb474709118f56c633cf19a6f136f44e9d2
Author: deardeng <565620...@qq.com>
AuthorDate: Mon Oct 28 10:16:49 2024 +0800
[fix](docker case) Fix `test_storage_medium_has_disk` due to invalid …
#42010 (#42390)
cherry pick from #42010
---
.../suites/storage_medium_p0/test_storage_medium_has_disk.groovy| 2 --
1 file changed, 2 deletions(-)
diff --git
a/regression-test/suites/storage_medium_p0/test_storage_medium_has_disk.groovy
b/regression-test/suites/storage_medium_p0/test_storage_medium_has_disk.groovy
index c252e10b130..0ae1b0ce95c 100644
---
a/regression-test/suites/storage_medium_p0/test_storage_medium_has_disk.groovy
+++
b/regression-test/suites/storage_medium_p0/test_storage_medium_has_disk.groovy
@@ -122,7 +122,6 @@ suite('test_storage_medium_has_disk', 'docker') {
"dynamic_partition.buckets" = "3",
"dynamic_partition.replication_num" = "1",
"dynamic_partition.create_history_partition"= "true",
-"dynamic_partition.hot"= "true",
"dynamic_partition.start" = "-4"
)
"""
@@ -147,7 +146,6 @@ suite('test_storage_medium_has_disk', 'docker') {
"dynamic_partition.buckets" = "3",
"dynamic_partition.replication_num" = "1",
"dynamic_partition.create_history_partition"= "true",
-"dynamic_partition.hot"= "true",
"dynamic_partition.start" = "-4"
)
"""
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](expr) fix wrong debug string of cast expr and remove useless variable [doris]
github-actions[bot] commented on PR #42489: URL: https://github.com/apache/doris/pull/42489#issuecomment-2440387266 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](cache) More metrics for lru cache #42357 [doris]
doris-robot commented on PR #42519: URL: https://github.com/apache/doris/pull/42519#issuecomment-2440385477 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](common) Add synchronized to avoid concurrent modification #42384 [doris]
w41ter merged PR #42455: URL: https://github.com/apache/doris/pull/42455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](docker case) Fix `test_storage_medium_has_disk` due to invalid … #42010 [doris]
dataroaring merged PR #42390: URL: https://github.com/apache/doris/pull/42390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt][file cache] Do not return error if file cache can not be created if ignore_broken_disk is set [doris]
github-actions[bot] commented on PR #42145: URL: https://github.com/apache/doris/pull/42145#issuecomment-2440376396 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-3.0][improve](common) Add synchronized to avoid concurrent modification [doris]
w41ter closed pull request #42458: [branch-3.0][improve](common) Add synchronized to avoid concurrent modification URL: https://github.com/apache/doris/pull/42458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-3.0][improve](common) Add synchronized to avoid concurrent modification [doris]
w41ter commented on PR #42458: URL: https://github.com/apache/doris/pull/42458#issuecomment-2440389697 close via #42455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](Nereids) support qualify stmt [doris]
qzsee commented on PR #40048: URL: https://github.com/apache/doris/pull/40048#issuecomment-2440350519 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud)Compatibility with the initial default compute group usage [doris]
deardeng commented on PR #42504: URL: https://github.com/apache/doris/pull/42504#issuecomment-2440391626 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud)Compatibility with the initial default compute group usage [doris]
deardeng commented on code in PR #42504:
URL: https://github.com/apache/doris/pull/42504#discussion_r1818290234
##
regression-test/suites/cloud_p0/auth/test_set_default_cluster.groovy:
##
@@ -0,0 +1,93 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+import org.apache.doris.regression.suite.ClusterOptions
+import org.junit.Assert
+
+suite("test_default_cluster", "docker") {
+def options = new ClusterOptions()
+options.cloudMode = true
+
+def getProperty = { property ->
+def result = null
+result = sql_return_maparray """SHOW PROPERTY"""
+result.find {
+it.Key == property as String
+}
+}
+
+def setAndCheckDefaultCluster = { validCluster ->
+sql """set property 'DEFAULT_CLOUD_CLUSTER' = '$validCluster'"""
+def ret1 = getProperty("default_cloud_cluster")
+def ret2 = getProperty("default_compute_group")
+assertEquals(ret1.Value as String, validCluster)
+assertEquals(ret1.Value as String, ret2.Value as String)
+}
+
+docker(options) {
+// not admin
+def user1 = "default_user1"
+// admin role
+def user2 = "default_user2"
+
+sql """CREATE USER $user1 IDENTIFIED BY 'Cloud123456' DEFAULT ROLE
'admin'"""
+sql """CREATE USER $user2 IDENTIFIED BY 'Cloud123456'"""
+sql """GRANT SELECT_PRIV on *.*.* to ${user2}"""
+
+def clusters = sql " SHOW CLUSTERS "
+assertTrue(!clusters.isEmpty())
+def validCluster = clusters[0][0]
+
+// admin set himself
+setAndCheckDefaultCluster validCluster
+
+// user1
+connectInDocker(user = user1, password = 'Cloud123456') {
+setAndCheckDefaultCluster validCluster
+def ret = sql """show grants"""
+log.info("ret = {}", ret)
+}
+
+connectInDocker(user = user2, password = 'Cloud123456') {
+//java.sql.SQLException: errCode = 2, detailMessage = set default
compute group failed, user default_user2 has no permission to use compute group
'compute_cluster', please
+//grant use privilege first , ComputeGroupException:
CURRENT_USER_NO_AUTH_TO_USE_COMPUTE_GROUP, you canuse SQL `GRANT USAGE_PRIV ON
COMPUTE GROUP {compute_group_name} TO
+//{user}`
+try {
+sql """set property 'DEFAULT_CLOUD_CLUSTER' =
'$validCluster'"""
+} catch (Exception e) {
+log.info(e.getMessage())
+
assertTrue(e.getMessage().contains("CURRENT_USER_NO_AUTH_TO_USE_COMPUTE_GROUP"))
+}
+}
+
+try {
+// admin set user2, failed not give user2 cluster auth
+sql """set property for $user2 'DEFAULT_CLOUD_CLUSTER' =
'$validCluster'"""
+} catch (Exception e) {
+
assertTrue(e.getMessage().contains("CURRENT_USER_NO_AUTH_TO_USE_COMPUTE_GROUP"))
+}
+sql """GRANT USAGE_PRIV ON COMPUTE GROUP $validCluster TO $user2"""
+// succ
+setAndCheckDefaultCluster validCluster
+// admin clean
+sql """set property for $user2 'DEFAULT_CLOUD_CLUSTER' = '' """
Review Comment:
add
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](log) Reduce some BE execution log [doris]
BiteThet merged PR #42383: URL: https://github.com/apache/doris/pull/42383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](cancel) Reduce lock scope in cancel worker [doris]
doris-robot commented on PR #42520: URL: https://github.com/apache/doris/pull/42520#issuecomment-2440392683 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [chore](log) Reduce some BE execution log (#42383)
This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 76958ed9ce0 [chore](log) Reduce some BE execution log (#42383)
76958ed9ce0 is described below
commit 76958ed9ce050e714dd0a406e69b31e8cb4f47a0
Author: zclllhhjj
AuthorDate: Mon Oct 28 10:19:09 2024 +0800
[chore](log) Reduce some BE execution log (#42383)
1. timeout does not print stack
2. when the runtime filter's relative query is finished before, it does
not print the log.
---
be/src/common/status.h | 2 +-
be/src/runtime/fragment_mgr.cpp | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/be/src/common/status.h b/be/src/common/status.h
index e95b9343167..e6c4b687116 100644
--- a/be/src/common/status.h
+++ b/be/src/common/status.h
@@ -478,7 +478,7 @@ public:
ERROR_CTOR_NOSTACK(Cancelled, CANCELLED)
ERROR_CTOR(MemoryLimitExceeded, MEM_LIMIT_EXCEEDED)
ERROR_CTOR(RpcError, THRIFT_RPC_ERROR)
-ERROR_CTOR(TimedOut, TIMEOUT)
+ERROR_CTOR_NOSTACK(TimedOut, TIMEOUT)
ERROR_CTOR_NOSTACK(TooManyTasks, TOO_MANY_TASKS)
ERROR_CTOR(Uninitialized, UNINITIALIZED)
ERROR_CTOR(Aborted, ABORTED)
diff --git a/be/src/runtime/fragment_mgr.cpp b/be/src/runtime/fragment_mgr.cpp
index 26fb098c76d..96d49be4c12 100644
--- a/be/src/runtime/fragment_mgr.cpp
+++ b/be/src/runtime/fragment_mgr.cpp
@@ -602,6 +602,7 @@ void FragmentMgr::remove_pipeline_context(
.count();
g_fragment_executing_count << -1;
g_fragment_last_active_time.set_value(now);
+// this log will show when a query is really finished in BEs
LOG_INFO("Removing query {} fragment {}", print_id(query_id),
f_context->get_fragment_id());
_pipeline_map.erase({query_id, f_context->get_fragment_id()});
}
@@ -1138,8 +1139,6 @@ Status FragmentMgr::apply_filterv2(const
PPublishFilterRequestV2* request,
auto iter = _pipeline_map.find(
{UniqueId(request->query_id()).to_thrift(),
fragment_id});
if (iter == _pipeline_map.end()) {
-LOG(WARNING) << "No pipeline fragment is found: Query-ID =
"
- << request->query_id() << " fragment_id = "
<< fragment_id;
continue;
}
pip_context = iter->second;
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-3.0 updated: [backport][branch-3.0] unpartition table need to keep in recycle bin in insert overwrite case (#42404)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new b1767128699 [backport][branch-3.0] unpartition table need to keep in
recycle bin in insert overwrite case (#42404)
b1767128699 is described below
commit b17671286993d2f13105a569ccc279282dfe6b90
Author: Vallish Pai
AuthorDate: Mon Oct 28 07:52:55 2024 +0530
[backport][branch-3.0] unpartition table need to keep in recycle bin in
insert overwrite case (#42404)
bp #42130
follow up for https://github.com/apache/doris/pull/40512
Issue Number: close #xxx
if a insert overwrite happens to un-partitioned table, partition info
needs to be kept inside the recycle bin. (without this tablets may leak)
once the data kept in recycle bin, it can be recovered using below step.
recover the partition to table as another partition in the table.
create another temp user table , and select the recover partition info
and insert to it.
replace original user table from temp user table.
---
.../java/org/apache/doris/catalog/OlapTable.java | 19 ++
.../test_insert_overwrite_recover_no_partition.out | 14
...st_insert_overwrite_recover_no_partition.groovy | 78 ++
3 files changed, 111 insertions(+)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java
b/fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java
index d77e2744dbd..18d546b04d4 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java
@@ -1062,6 +1062,25 @@ public class OlapTable extends Table implements
MTMVRelatedTableIf, GsonPostProc
partitionInfo.getReplicaAllocation(partition.getId()),
partitionInfo.getIsInMemory(partition.getId()),
partitionInfo.getIsMutable(partition.getId()));
+} else {
+// unpartition
+// construct a dummy range and dummy list.
+List dummyColumns = new ArrayList<>();
+dummyColumns.add(new Column("dummy", PrimitiveType.INT));
+PartitionKey dummyKey = null;
+try {
+dummyKey =
PartitionKey.createInfinityPartitionKey(dummyColumns, false);
+} catch (AnalysisException e) {
+LOG.warn("should not happen", e);
+}
+Range dummyRange = Range.open(new
PartitionKey(), dummyKey);
+Env.getCurrentRecycleBin().recyclePartition(dbId, id,
name, partition,
+dummyRange,
+new ListPartitionItem(Lists.newArrayList(new
PartitionKey())),
+partitionInfo.getDataProperty(partition.getId()),
+
partitionInfo.getReplicaAllocation(partition.getId()),
+partitionInfo.getIsInMemory(partition.getId()),
+partitionInfo.getIsMutable(partition.getId()));
}
} else if (!reserveTablets) {
Env.getCurrentEnv().onErasePartition(partition);
diff --git
a/regression-test/data/catalog_recycle_bin_p0/test_insert_overwrite_recover_no_partition.out
b/regression-test/data/catalog_recycle_bin_p0/test_insert_overwrite_recover_no_partition.out
new file mode 100644
index 000..a3effb99a08
--- /dev/null
+++
b/regression-test/data/catalog_recycle_bin_p0/test_insert_overwrite_recover_no_partition.out
@@ -0,0 +1,14 @@
+-- This file is automatically generated. You should know what you did if you
want to edit this
+-- !select_check_1 --
+1 a 2022-01-02
+2 a 2023-01-02
+3 a 2024-01-02
+
+-- !select_check_2 --
+3 a 2024-01-02
+
+-- !select_check_3 --
+1 a 2022-01-02
+2 a 2023-01-02
+3 a 2024-01-02
+
diff --git
a/regression-test/suites/catalog_recycle_bin_p0/test_insert_overwrite_recover_no_partition.groovy
b/regression-test/suites/catalog_recycle_bin_p0/test_insert_overwrite_recover_no_partition.groovy
new file mode 100644
index 000..f3123d71b8d
--- /dev/null
+++
b/regression-test/suites/catalog_recycle_bin_p0/test_insert_overwrite_recover_no_partition.groovy
@@ -0,0 +1,78 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obta
Re: [PR] [opt](cache) More metrics for lru cache #42357 [doris]
github-actions[bot] commented on code in PR #42519:
URL: https://github.com/apache/doris/pull/42519#discussion_r1818291851
##
be/src/olap/lru_cache.cpp:
##
@@ -177,6 +179,16 @@
prune();
}
+uint64_t LRUCache::get_stampede_count() {
+std::lock_guard l(_mutex);
+return _stampede_count;
+}
+
+uint64_t LRUCache::get_miss_count() {
Review Comment:
warning: method 'get_miss_count' can be made const
[readability-make-member-function-const]
be/src/olap/lru_cache.h:352:
```diff
- uint64_t get_miss_count();
+ uint64_t get_miss_count() const;
```
```suggestion
uint64_t LRUCache::get_miss_count() const {
```
##
be/src/olap/lru_cache.cpp:
##
@@ -177,6 +179,16 @@ LRUCache::~LRUCache() {
prune();
}
+uint64_t LRUCache::get_stampede_count() {
Review Comment:
warning: method 'get_stampede_count' can be made const
[readability-make-member-function-const]
be/src/olap/lru_cache.h:353:
```diff
- uint64_t get_stampede_count();
+ uint64_t get_stampede_count() const;
```
```suggestion
uint64_t LRUCache::get_stampede_count() const {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [backport][branch-3.0] unpartition table need to keep in recycle bin in insert overwrite case [doris]
dataroaring merged PR #42404: URL: https://github.com/apache/doris/pull/42404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](cancel) Reduce lock scope in cancel worker [doris]
github-actions[bot] commented on PR #42520: URL: https://github.com/apache/doris/pull/42520#issuecomment-2440404672 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pick](branch-2.1) pick #41123 [doris]
github-actions[bot] commented on PR #42541: URL: https://github.com/apache/doris/pull/42541#issuecomment-2440648367 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](information_schema) add rowsets table into information_schema in cloud mode [doris]
wyxxxcat commented on PR #42367: URL: https://github.com/apache/doris/pull/42367#issuecomment-2440663825 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (40d0f7704da -> 51446fb0a57)
This is an automated email from the ASF dual-hosted git repository. panxiaolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 40d0f7704da [Feature](schema change) Support add column bitmap with default value bitmap_empty (#42331) add 51446fb0a57 [env](compile) open compile check in runtime file (#42499) No new revisions were added by this update. Summary of changes: be/src/vec/runtime/ip_address_cidr.h| 11 +++ be/src/vec/runtime/ipv4_value.h | 3 +++ be/src/vec/runtime/ipv6_value.h | 3 +++ be/src/vec/runtime/partitioner.cpp | 12 +++- be/src/vec/runtime/partitioner.h| 3 +++ be/src/vec/runtime/shared_hash_table_controller.cpp | 1 + be/src/vec/runtime/shared_hash_table_controller.h | 3 +++ be/src/vec/runtime/time_value.h | 7 ++- be/src/vec/runtime/vcsv_transformer.cpp | 8 +--- be/src/vec/runtime/vcsv_transformer.h | 3 +++ be/src/vec/runtime/vdata_stream_mgr.cpp | 5 +++-- be/src/vec/runtime/vdata_stream_mgr.h | 3 +++ be/src/vec/runtime/vdata_stream_recvr.cpp | 1 + be/src/vec/runtime/vdata_stream_recvr.h | 3 +++ be/src/vec/runtime/vfile_format_transformer.h | 3 +++ be/src/vec/runtime/vorc_transformer.cpp | 4 +++- be/src/vec/runtime/vorc_transformer.h | 3 +++ be/src/vec/runtime/vparquet_transformer.cpp | 1 + be/src/vec/runtime/vparquet_transformer.h | 3 +++ be/src/vec/runtime/vsorted_run_merger.cpp | 1 + be/src/vec/runtime/vsorted_run_merger.h | 3 +++ 21 files changed, 68 insertions(+), 16 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [env](compile) open compile check in runtime file [doris]
github-actions[bot] commented on PR #42499: URL: https://github.com/apache/doris/pull/42499#issuecomment-2440656024 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](auto_partition)add some log to verify load correct [doris]
zfr9527 commented on PR #35816: URL: https://github.com/apache/doris/pull/35816#issuecomment-2440658823 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [chore](fix) fix compile cloud bug [doris]
hello-stephen opened a new pull request, #42555: URL: https://github.com/apache/doris/pull/42555 introduce by: #40381 reproduce: rm -rf thirdparty/installed/include/foundationdb/ thirdparty/src/fdb_lib_7_1_23.tar.xz && sh build.sh --cloud -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](pipeline) Refactor local exchange planning [doris]
github-actions[bot] commented on PR #42482: URL: https://github.com/apache/doris/pull/42482#issuecomment-2440668330 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[I] [Enhancement] (nereids)implement CancelCommand in nereids [doris]
LiBinfeng-01 opened a new issue, #42566: URL: https://github.com/apache/doris/issues/42566 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description cancel command is supported in legacy planner but not in nereids(new doris fe planner). you need implement the following use command in nereids: - [ ] https://github.com/apache/doris/issues/42557 - [ ] https://github.com/apache/doris/issues/42560 - [ ] https://github.com/apache/doris/issues/42561 - [ ] https://github.com/apache/doris/issues/42562 - [ ] https://github.com/apache/doris/issues/42563 ### Solution _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cluster key) add a config to random set cluster keys for mow [doris]
doris-robot commented on PR #42565: URL: https://github.com/apache/doris/pull/42565#issuecomment-2440700862 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](cluster key) add a config to random set cluster keys for mow [doris]
mymeiyi opened a new pull request, #42565: URL: https://github.com/apache/doris/pull/42565 used for test cluster key feature -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](delete) Fix static type dispatch by mistake due to typo [doris]
TangSiyang2001 commented on PR #42260: URL: https://github.com/apache/doris/pull/42260#issuecomment-2440697680 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-42521-branch-3.0 updated: [regression-test](prepared_stmt_p0) use master ip for prepared url (#42521)
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch auto-pick-42521-branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/auto-pick-42521-branch-3.0 by
this push:
new f55c15d5e9c [regression-test](prepared_stmt_p0) use master ip for
prepared url (#42521)
f55c15d5e9c is described below
commit f55c15d5e9ce895daeb74dad5cb82d895afa5218
Author: lihangyu <15605149...@163.com>
AuthorDate: Mon Oct 28 14:52:52 2024 +0800
[regression-test](prepared_stmt_p0) use master ip for prepared url (#42521)
---
.../suites/prepared_stmt_p0/prepared_stmt.groovy | 15 ++-
.../suites/prepared_stmt_p0/prepared_stmt_in_list.groovy | 3 ++-
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/regression-test/suites/prepared_stmt_p0/prepared_stmt.groovy
b/regression-test/suites/prepared_stmt_p0/prepared_stmt.groovy
index 33b9e1b1c6d..e01e574976f 100644
--- a/regression-test/suites/prepared_stmt_p0/prepared_stmt.groovy
+++ b/regression-test/suites/prepared_stmt_p0/prepared_stmt.groovy
@@ -22,7 +22,8 @@ suite("test_prepared_stmt", "nonConcurrent") {
def tableName = "tbl_prepared_stmt"
def user = context.config.jdbcUser
def password = context.config.jdbcPassword
-def url = context.config.jdbcUrl +
"&useServerPrepStmts=true&useCursorFetch=true"
+// def url = context.config.jdbcUrl +
"&useServerPrepStmts=true&useCursorFetch=true"
+String url = getServerPrepareJdbcUrl(context.config.jdbcUrl,
"regression_test_prepared_stmt_p0")
def result1 = connect(user=user, password=password, url=url) {
sql """DROP TABLE IF EXISTS ${tableName} """
sql """
@@ -218,12 +219,14 @@ suite("test_prepared_stmt", "nonConcurrent") {
assertEquals(com.mysql.cj.jdbc.ClientPreparedStatement,
stmt_read.class)
// alter stmt
stmt_read = prepareStatement "alter table mytable1 rename mytable2"
-assertEquals(com.mysql.cj.jdbc.ClientPreparedStatement,
stmt_read.class)
+def result = stmt_read.execute()
+logger.info("result: ${result}")
+// assertEquals(com.mysql.cj.jdbc.ClientPreparedStatement,
stmt_read.class)
// update stmt
stmt_read = prepareStatement "update tbl_prepared_stmt set k5 = ?"
assertEquals(com.mysql.cj.jdbc.ServerPreparedStatement,
stmt_read.class)
stmt_read.setString(1, "2021-01-01")
-def result = stmt_read.execute()
+result = stmt_read.execute()
logger.info("result: ${result}")
stmt_read = prepareStatement "update tbl_prepared_stmt set k4 = 'Will
we ignore LIMIT ?,?'"
assertEquals(com.mysql.cj.jdbc.ServerPreparedStatement,
stmt_read.class)
@@ -231,8 +234,10 @@ suite("test_prepared_stmt", "nonConcurrent") {
logger.info("result: ${result}")
qt_sql "select * from tbl_prepared_stmt where k4 = 'Will we ignore
LIMIT ?,?' order by k1"
// show create table
-stmt_read = prepareStatement "SHOW CREATE TABLE mytable1"
-assertEquals(com.mysql.cj.jdbc.ClientPreparedStatement,
stmt_read.class)
+stmt_read = prepareStatement "SHOW CREATE TABLE tbl_prepared_stmt"
+result = stmt_read.execute()
+logger.info("result: ${result}")
+// assertEquals(com.mysql.cj.jdbc.ClientPreparedStatement,
stmt_read.class)
// not stable
// qe_select16 stmt_read
stmt_read.close()
diff --git
a/regression-test/suites/prepared_stmt_p0/prepared_stmt_in_list.groovy
b/regression-test/suites/prepared_stmt_p0/prepared_stmt_in_list.groovy
index 630fe7fa720..3c972e83fd9 100644
--- a/regression-test/suites/prepared_stmt_p0/prepared_stmt_in_list.groovy
+++ b/regression-test/suites/prepared_stmt_p0/prepared_stmt_in_list.groovy
@@ -21,7 +21,8 @@ suite("test_prepared_stmt_in_list", "nonConcurrent") {
def tableName = "tbl_prepared_stmt_in_list"
def user = context.config.jdbcUser
def password = context.config.jdbcPassword
-def url = context.config.jdbcUrl + "&useServerPrepStmts=true"
+// def url = context.config.jdbcUrl + "&useServerPrepStmts=true"
+String url = getServerPrepareJdbcUrl(context.config.jdbcUrl,
"regression_test_prepared_stmt_p0")
sql """set global max_prepared_stmt_count = 1024"""
def result1 = connect(user=user, password=password, url=url) {
sql """DROP TABLE IF EXISTS ${tableName} """
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] refactor write buffer [doris]
github-actions[bot] commented on PR #42556: URL: https://github.com/apache/doris/pull/42556#issuecomment-2440679334 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](load) fix some typos for load data format [doris-website]
liaoxin01 merged PR #1231: URL: https://github.com/apache/doris-website/pull/1231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Branch-2.1) fix not null variant will lost null bitmap [doris]
doris-robot commented on PR #42559: URL: https://github.com/apache/doris/pull/42559#issuecomment-2440695081 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](scan) Avoid memory allocated by buffered_reader from being traced [doris]
doris-robot commented on PR #42558: URL: https://github.com/apache/doris/pull/42558#issuecomment-2440695032 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-42521-branch-3.0 created (now 5af078bcdd5)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-42521-branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git at 5af078bcdd5 [branch-3.0][Chore](job) Provides configuration of job execution queue size (#42253) (#42531) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch spill_and_reserve updated: refactor write buffer (#42556)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch spill_and_reserve
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/spill_and_reserve by this push:
new 9c3f3fcb9a2 refactor write buffer (#42556)
9c3f3fcb9a2 is described below
commit 9c3f3fcb9a2f38017b72ac9972bba077901b5fcd
Author: yiguolei <676222...@qq.com>
AuthorDate: Mon Oct 28 14:36:37 2024 +0800
refactor write buffer (#42556)
## Proposed changes
Issue Number: close #xxx
Co-authored-by: yiguolei
---
be/src/olap/memtable.cpp | 8 ++--
be/src/olap/memtable_flush_executor.cpp | 2 ++
be/src/runtime/memory/mem_tracker_limiter.cpp | 18 +++---
be/src/runtime/memory/mem_tracker_limiter.h | 19 +--
be/src/runtime/workload_group/workload_group.cpp | 5 ++---
be/src/runtime/workload_group/workload_group.h| 3 +--
.../runtime/workload_group/workload_group_manager.cpp | 5 ++---
7 files changed, 21 insertions(+), 39 deletions(-)
diff --git a/be/src/olap/memtable.cpp b/be/src/olap/memtable.cpp
index facbc90c450..cc16cb481ed 100644
--- a/be/src/olap/memtable.cpp
+++ b/be/src/olap/memtable.cpp
@@ -78,7 +78,6 @@ MemTable::MemTable(int64_t tablet_id,
std::shared_ptr tablet_schem
// TODO: Support ZOrderComparator in the future
_init_columns_offset_by_slot_descs(slot_descs, tuple_desc);
_mem_tracker = std::make_shared();
-_query_thread_context.query_mem_tracker->push_load_buffer(_mem_tracker);
}
void MemTable::_init_columns_offset_by_slot_descs(const
std::vector* slot_descs,
@@ -144,7 +143,8 @@ void MemTable::_init_agg_functions(const vectorized::Block*
block) {
}
MemTable::~MemTable() {
-
SCOPED_SWITCH_THREAD_MEM_TRACKER_LIMITER(_query_thread_context.query_mem_tracker);
+SCOPED_SWITCH_THREAD_MEM_TRACKER_LIMITER(
+_query_thread_context.query_mem_tracker->write_tracker());
if (_is_flush_success) {
// If the memtable is flush success, then its memtracker's consumption
should be 0
if (_mem_tracker->consumption() != 0 &&
config::crash_in_memory_tracker_inaccurate) {
@@ -184,6 +184,8 @@ int RowInBlockComparator::operator()(const RowInBlock*
left, const RowInBlock* r
Status MemTable::insert(const vectorized::Block* input_block,
const std::vector& row_idxs) {
+SCOPED_SWITCH_THREAD_MEM_TRACKER_LIMITER(
+_query_thread_context.query_mem_tracker->write_tracker());
SCOPED_CONSUME_MEM_TRACKER(_mem_tracker);
if (_is_first_insertion) {
@@ -580,6 +582,8 @@ void MemTable::_aggregate() {
}
void MemTable::shrink_memtable_by_agg() {
+SCOPED_SWITCH_THREAD_MEM_TRACKER_LIMITER(
+_query_thread_context.query_mem_tracker->write_tracker());
SCOPED_CONSUME_MEM_TRACKER(_mem_tracker);
if (_keys_type == KeysType::DUP_KEYS) {
return;
diff --git a/be/src/olap/memtable_flush_executor.cpp
b/be/src/olap/memtable_flush_executor.cpp
index dc911647be8..7599a3f6b86 100644
--- a/be/src/olap/memtable_flush_executor.cpp
+++ b/be/src/olap/memtable_flush_executor.cpp
@@ -142,6 +142,8 @@ Status FlushToken::_do_flush_memtable(MemTable* memtable,
int32_t segment_id, in
signal::set_signal_task_id(_rowset_writer->load_id());
signal::tablet_id = memtable->tablet_id();
{
+SCOPED_SWITCH_THREAD_MEM_TRACKER_LIMITER(
+
memtable->query_thread_context().query_mem_tracker->write_tracker());
SCOPED_CONSUME_MEM_TRACKER(memtable->mem_tracker());
std::unique_ptr block;
RETURN_IF_ERROR(memtable->to_block(&block));
diff --git a/be/src/runtime/memory/mem_tracker_limiter.cpp
b/be/src/runtime/memory/mem_tracker_limiter.cpp
index 487b7d48fae..c0555c2fcf3 100644
--- a/be/src/runtime/memory/mem_tracker_limiter.cpp
+++ b/be/src/runtime/memory/mem_tracker_limiter.cpp
@@ -82,6 +82,9 @@ std::shared_ptr
MemTrackerLimiter::create_shared(MemTrackerLi
const
std::string& label,
int64_t
byte_limit) {
auto tracker = std::make_shared(type, label,
byte_limit);
+// Write tracker is only used to tracker the size, so limit == -1
+auto write_tracker = std::make_shared(type, "Memtable"
+ label, -1);
+tracker->_write_tracker.swap(write_tracker);
#ifndef BE_TEST
DCHECK(ExecEnv::tracking_memory());
std::lock_guard l(
@@ -257,21 +260,6 @@ void MemTrackerLimiter::clean_tracker_limiter_group() {
#endif
}
-void MemTrackerLimiter::update_load_buffer_size() {
-std::lock_guard l(_load_buffer_lock);
-int64_t total_buf_size = 0;
-for (auto memtable_tracker = _load_buffers.begin(); memtable_tracker !=
_load_buffers.end();) {
-auto m = memtable_tracker->lock();
-
[PR] refactor write buffer [doris]
yiguolei opened a new pull request, #42556: URL: https://github.com/apache/doris/pull/42556 ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] refactor write buffer [doris]
doris-robot commented on PR #42556: URL: https://github.com/apache/doris/pull/42556#issuecomment-2440672220 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](prepared_stmt_p0) use master ip for prepared url [doris]
github-actions[bot] commented on PR #42521: URL: https://github.com/apache/doris/pull/42521#issuecomment-2440673216 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] refactor write buffer [doris]
yiguolei merged PR #42556: URL: https://github.com/apache/doris/pull/42556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](prepared_stmt_p0) use master ip for prepared url [doris]
eldenmoon merged PR #42521: URL: https://github.com/apache/doris/pull/42521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [regression-test](prepared_stmt_p0) use master ip for prepared url (#42521)
This is an automated email from the ASF dual-hosted git repository.
eldenmoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new c921be820b0 [regression-test](prepared_stmt_p0) use master ip for
prepared url (#42521)
c921be820b0 is described below
commit c921be820b0f3757c418d6b1b0a967b0b447b69c
Author: lihangyu <15605149...@163.com>
AuthorDate: Mon Oct 28 14:52:52 2024 +0800
[regression-test](prepared_stmt_p0) use master ip for prepared url (#42521)
---
.../suites/prepared_stmt_p0/prepared_stmt.groovy | 15 ++-
.../suites/prepared_stmt_p0/prepared_stmt_in_list.groovy | 3 ++-
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/regression-test/suites/prepared_stmt_p0/prepared_stmt.groovy
b/regression-test/suites/prepared_stmt_p0/prepared_stmt.groovy
index 33b9e1b1c6d..e01e574976f 100644
--- a/regression-test/suites/prepared_stmt_p0/prepared_stmt.groovy
+++ b/regression-test/suites/prepared_stmt_p0/prepared_stmt.groovy
@@ -22,7 +22,8 @@ suite("test_prepared_stmt", "nonConcurrent") {
def tableName = "tbl_prepared_stmt"
def user = context.config.jdbcUser
def password = context.config.jdbcPassword
-def url = context.config.jdbcUrl +
"&useServerPrepStmts=true&useCursorFetch=true"
+// def url = context.config.jdbcUrl +
"&useServerPrepStmts=true&useCursorFetch=true"
+String url = getServerPrepareJdbcUrl(context.config.jdbcUrl,
"regression_test_prepared_stmt_p0")
def result1 = connect(user=user, password=password, url=url) {
sql """DROP TABLE IF EXISTS ${tableName} """
sql """
@@ -218,12 +219,14 @@ suite("test_prepared_stmt", "nonConcurrent") {
assertEquals(com.mysql.cj.jdbc.ClientPreparedStatement,
stmt_read.class)
// alter stmt
stmt_read = prepareStatement "alter table mytable1 rename mytable2"
-assertEquals(com.mysql.cj.jdbc.ClientPreparedStatement,
stmt_read.class)
+def result = stmt_read.execute()
+logger.info("result: ${result}")
+// assertEquals(com.mysql.cj.jdbc.ClientPreparedStatement,
stmt_read.class)
// update stmt
stmt_read = prepareStatement "update tbl_prepared_stmt set k5 = ?"
assertEquals(com.mysql.cj.jdbc.ServerPreparedStatement,
stmt_read.class)
stmt_read.setString(1, "2021-01-01")
-def result = stmt_read.execute()
+result = stmt_read.execute()
logger.info("result: ${result}")
stmt_read = prepareStatement "update tbl_prepared_stmt set k4 = 'Will
we ignore LIMIT ?,?'"
assertEquals(com.mysql.cj.jdbc.ServerPreparedStatement,
stmt_read.class)
@@ -231,8 +234,10 @@ suite("test_prepared_stmt", "nonConcurrent") {
logger.info("result: ${result}")
qt_sql "select * from tbl_prepared_stmt where k4 = 'Will we ignore
LIMIT ?,?' order by k1"
// show create table
-stmt_read = prepareStatement "SHOW CREATE TABLE mytable1"
-assertEquals(com.mysql.cj.jdbc.ClientPreparedStatement,
stmt_read.class)
+stmt_read = prepareStatement "SHOW CREATE TABLE tbl_prepared_stmt"
+result = stmt_read.execute()
+logger.info("result: ${result}")
+// assertEquals(com.mysql.cj.jdbc.ClientPreparedStatement,
stmt_read.class)
// not stable
// qe_select16 stmt_read
stmt_read.close()
diff --git
a/regression-test/suites/prepared_stmt_p0/prepared_stmt_in_list.groovy
b/regression-test/suites/prepared_stmt_p0/prepared_stmt_in_list.groovy
index 630fe7fa720..3c972e83fd9 100644
--- a/regression-test/suites/prepared_stmt_p0/prepared_stmt_in_list.groovy
+++ b/regression-test/suites/prepared_stmt_p0/prepared_stmt_in_list.groovy
@@ -21,7 +21,8 @@ suite("test_prepared_stmt_in_list", "nonConcurrent") {
def tableName = "tbl_prepared_stmt_in_list"
def user = context.config.jdbcUser
def password = context.config.jdbcPassword
-def url = context.config.jdbcUrl + "&useServerPrepStmts=true"
+// def url = context.config.jdbcUrl + "&useServerPrepStmts=true"
+String url = getServerPrepareJdbcUrl(context.config.jdbcUrl,
"regression_test_prepared_stmt_p0")
sql """set global max_prepared_stmt_count = 1024"""
def result1 = connect(user=user, password=password, url=url) {
sql """DROP TABLE IF EXISTS ${tableName} """
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Fix](Branch-2.1) fix not null variant will lost null bitmap [doris]
eldenmoon opened a new pull request, #42559: URL: https://github.com/apache/doris/pull/42559 ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pick](branch-2.1) pick #41123 [doris]
doris-robot commented on PR #42541: URL: https://github.com/apache/doris/pull/42541#issuecomment-2440691107 TeamCity be ut coverage result: Function Coverage: 36.02% (9367/26005) Line Coverage: 27.58% (76944/278961) Region Coverage: 26.37% (39532/149900) Branch Coverage: 23.15% (20106/86838) Coverage Report: http://coverage.selectdb-in.cc/coverage/ece582d441a8ae5f294a45daf38e802967c45392_ece582d441a8ae5f294a45daf38e802967c45392/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](fix) fix compile cloud bug [doris]
hello-stephen commented on PR #42555: URL: https://github.com/apache/doris/pull/42555#issuecomment-2440668638 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [regression-test](prepared_stmt_p0) use master ip for prepared url (#42521) [doris]
eldenmoon opened a new pull request, #42567: URL: https://github.com/apache/doris/pull/42567 (#42521) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](prepared_stmt_p0) use master ip for prepared url (#42521) [doris]
doris-robot commented on PR #42567: URL: https://github.com/apache/doris/pull/42567#issuecomment-2440702805 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cases)fix ip case2.1 with sync after streamload [doris]
yiguolei merged PR #42543: URL: https://github.com/apache/doris/pull/42543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: [fix](cases)fix ip case2.1 with sync after streamload (#42543)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new 59b6d7d4727 [fix](cases)fix ip case2.1 with sync after streamload
(#42543)
59b6d7d4727 is described below
commit 59b6d7d4727f599d953b487323f2bef76bdd3483
Author: amory
AuthorDate: Mon Oct 28 14:54:36 2024 +0800
[fix](cases)fix ip case2.1 with sync after streamload (#42543)
## Proposed changes
fix ip case2.1 with sync after streamload
Issue Number: close #xxx
---
regression-test/suites/datatype_p0/ip/test_ip_in_inverted_index.groovy | 1 +
1 file changed, 1 insertion(+)
diff --git
a/regression-test/suites/datatype_p0/ip/test_ip_in_inverted_index.groovy
b/regression-test/suites/datatype_p0/ip/test_ip_in_inverted_index.groovy
index 79aee287a37..b41f6bf9105 100644
--- a/regression-test/suites/datatype_p0/ip/test_ip_in_inverted_index.groovy
+++ b/regression-test/suites/datatype_p0/ip/test_ip_in_inverted_index.groovy
@@ -86,6 +86,7 @@ suite("test_ip_in_inverted_index") {
time 1 // limit inflight 10s
// stream load action will check result, include Success status,
and NumberTotalRows == NumberLoadedRows
}
+sql """ sync; """
qt_sql "select count() from test_ip_with_inverted_index"
// query with inverted index and no inverted index
sql """set enable_inverted_index_query=true; """
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [env](compile) open compile check in runtime file [doris]
github-actions[bot] commented on PR #42499: URL: https://github.com/apache/doris/pull/42499#issuecomment-2440656062 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[I] [Enhancement] (nereids)implement CancelAlterTableCommand in nereids [doris]
LiBinfeng-01 opened a new issue, #42557: URL: https://github.com/apache/doris/issues/42557 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description CancelAlterTableCommand is supported in legacy planner but not in nereids(new doris fe planner). you need implement it in nereids.The DorisParser.g4 has the syntax definition already(see bellow). And you can check CancelAlterTableStmt.java in legacy planner to see what the command does and migrate it to nereids planner ```unsupportedCancelStatement : CANCEL ALTER TABLE (ROLLUP | (MATERIALIZED VIEW) | COLUMN) FROM tableName=multipartIdentifier (LEFT_PAREN jobIds+=INTEGER_VALUE (COMMA jobIds+=INTEGER_VALUE)* RIGHT_PAREN)?``` ### Solution _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](docker)Modify docker build readme [doris]
catpineapple opened a new pull request, #42564: URL: https://github.com/apache/doris/pull/42564 ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-website) branch master updated: [fix](load) fix some typos for load data format (#1231)
This is an automated email from the ASF dual-hosted git repository.
liaoxin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris-website.git
The following commit(s) were added to refs/heads/master by this push:
new a54da0cf1f [fix](load) fix some typos for load data format (#1231)
a54da0cf1f is described below
commit a54da0cf1ff5242763a173c504b0b9627a88907b
Author: Xin Liao
AuthorDate: Mon Oct 28 14:38:06 2024 +0800
[fix](load) fix some typos for load data format (#1231)
# Versions
- [x] dev
- [x] 3.0
- [x] 2.1
- [ ] 2.0
# Languages
- [x] Chinese
- [x] English
---
docs/data-operate/import/load-data-format.md | 64 -
.../data-operate/import/load-data-format.md| 84 +++---
.../data-operate/import/load-data-format.md| 84 +++---
.../data-operate/import/load-data-format.md| 84 +++---
.../data-operate/import/load-data-format.md| 66 -
.../data-operate/import/load-data-format.md| 66 -
6 files changed, 224 insertions(+), 224 deletions(-)
diff --git a/docs/data-operate/import/load-data-format.md
b/docs/data-operate/import/load-data-format.md
index 6ae9c6e76d..a69d92c57d 100644
--- a/docs/data-operate/import/load-data-format.md
+++ b/docs/data-operate/import/load-data-format.md
@@ -56,20 +56,20 @@ The following import methods support data import in CSV
format:
[Stream Load](./import-way/stream-load-manual.md)
-```
-curl --location-trusted -u :
--H "Expect:100-continue"
--H "line_delimiter:\n"
--H "columns_delimiter:|"
--H "enclose:'"
--H "escape:\"
--H "skip_lines:2"
--T streamload_example.csv
+```shell
+curl --location-trusted -u : \
+-H "Expect:100-continue" \
+-H "line_delimiter:\n" \
+-H "columns_delimiter:|" \
+-H "enclose:'" \
+-H "escape:\" \
+-H "skip_lines:2" \
+-T streamload_example.csv \
-XPUT http://:/api/testdb/test_streamload/_stream_load
```
[Broker Load](./import-way/broker-load-manual.md)
-```
+```sql
LOAD LABEL example_db.exmpale_label_1
(
DATA INFILE("s3://your_bucket_name/your_file.txt")
@@ -93,7 +93,7 @@ WITH S3
```
[Routine Load](./import-way/routine-load-manual.md)
-```
+```sql
CREATE ROUTINE LOAD demo.kafka_job01 ON routine_test01
COLUMNS TERMINATED BY "|",
COLUMNS(id, name, age)
@@ -112,7 +112,7 @@ CREATE ROUTINE LOAD demo.kafka_job01 ON routine_test01
```
[MySQL Load](./import-way/mysql-load-manual.md)
-```
+```sql
LOAD DATA LOCAL
INFILE "testData"
INTO TABLE testDb.testTbl
@@ -390,7 +390,7 @@ Import statement 3:
Compared with the import statement 1 and import statement 2, the columns
field `k1_copy` is added here.
Table Structure:
-```
+```text
k2 int, k1 int, k1_copy int
```
@@ -422,13 +422,13 @@ Compared with the import statement 1 and import
statement 2, the columns field
Table Structure:
-```
+```text
k2 int, k1 int, k1_nested1 int, k1_nested2 int
```
If you want to assign multi-level fields with the same name nested in json to
different columns in the table, you can specify the column in jsonPaths and
specify the mapping order in turn. An example are as follows:
```shell
-curl -v --location-trusted -u root: -H "format: json" -H "jsonpaths:
[\"$.k2\", \"$.k1\",\"$.k3.k1\",\"$.k3.k1_nested.k1\" -H "columns:
k2,k1,k1_nested1,k1_nested2" -T example.json
http://127.0.0.1:8030/api/db1/tbl1/_stream_load
+curl -v --location-trusted -u root: -H "format: json" -H "jsonpaths:
[\"$.k2\", \"$.k1\",\"$.k3.k1\",\"$.k3.k1_nested.k1\"]" -H "columns:
k2,k1,k1_nested1,k1_nested2" -T example.json
http://127.0.0.1:8030/api/db1/tbl1/_stream_load
```
The above example will extract the fields in the order of the JSON Path,
specifying that the first column is the value of the `k2` column in the table,
the second column is the value of the `k1` column in the table, and the third
column is the `k1` column in the nested type. The value of the `k1_nested1`
column, from which we know that the `k3.k1_nested.k1` column is the value of
the `k1_nested2` column in the table. The final imported data results are as
follows:
@@ -538,7 +538,7 @@ Suppose the table structure is:
```text
id INT NOT NULL,
-city VARHCAR NULL,
+city VARCHAR NULL,
code INT NULL
```
@@ -681,11 +681,11 @@ we suggest you to use JSON string to import data to
`array` or `arrayhttp://localhost:8035/api/example_db/array_test_decimal/_stream_load
+curl --location-trusted -u root: -H "max_filter_ratio:0.01" -H "format:json"
-H "timeout:300" -T test_decimal.json
http://localhost:8030/api/example_db/array_test_decimal/_stream_load
```
Import result:
-```
+```shell
MySQL > select * from array_test_decimal;
+--+--+
| k1 | k2 |
@@ -701,11 +701,11 @@ MySQL > select * from array_test_deci
Re: [PR] [fix](docker)Modify docker build readme [doris]
catpineapple commented on PR #42564: URL: https://github.com/apache/doris/pull/42564#issuecomment-2440700632 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](fix) fix compile cloud bug [doris]
github-actions[bot] commented on PR #42555: URL: https://github.com/apache/doris/pull/42555#issuecomment-2440674401 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](prepared_stmt_p0) use master ip for prepared url [doris]
github-actions[bot] commented on PR #42521: URL: https://github.com/apache/doris/pull/42521#issuecomment-2440673255 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](docker)Modify docker build readme [doris]
doris-robot commented on PR #42564: URL: https://github.com/apache/doris/pull/42564#issuecomment-2440700192 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] query blocked by exchange reach limit [doris]
doris-robot commented on PR #42371: URL: https://github.com/apache/doris/pull/42371#issuecomment-2440079208 TeamCity be ut coverage result: Function Coverage: 36.02% (9368/26006) Line Coverage: 27.58% (76951/279006) Region Coverage: 26.37% (39527/149916) Branch Coverage: 23.15% (20106/86848) Coverage Report: http://coverage.selectdb-in.cc/coverage/2aafed76cbced5de6a13c8411e353c1f2203d3d4_2aafed76cbced5de6a13c8411e353c1f2203d3d4/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [env](compile) open compile check in some file [doris]
mrhhsg commented on PR #42497: URL: https://github.com/apache/doris/pull/42497#issuecomment-2440079101 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [env](compile)open compile check in function string [doris]
Mryange commented on PR #42474: URL: https://github.com/apache/doris/pull/42474#issuecomment-2439929904 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [I] [Enhancement] Limit the Number of Delete Rowsets in Compaction to Prevent Version Accumulation Errors [doris]
junyizha commented on issue #41756: URL: https://github.com/apache/doris/issues/41756#issuecomment-2440094569 Hi! I'd like to try out this issue. Could you assign it to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] NPE can occur in the Response Path if MetricRepo is not initialized yet [doris]
doris-robot commented on PR #42505: URL: https://github.com/apache/doris/pull/42505#issuecomment-2439882301 TPC-H: Total hot run time: 41312 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit c0295db381a40ef503d3a22ccdd55a4f64bd8007, data reload: false -- Round 1 -- q1 17598 740872927292 q2 2017287 276 276 q3 12192 103712011037 q4 10581 848 827 827 q5 7775307930533053 q6 234 148 142 142 q7 1049606 586 586 q8 9354191519891915 q9 6494646564346434 q10 7091238724032387 q11 429 246 250 246 q12 426 221 209 209 q13 17793 301829732973 q14 241 211 209 209 q15 569 520 523 520 q16 662 592 589 589 q17 970 511 480 480 q18 7241675167866751 q19 13201114970 970 q20 484 179 183 179 q21 3940324632583246 q22 11141028991 991 Total cold run time: 109574 ms Total hot run time: 41312 ms - Round 2, with runtime_filter_mode=off - q1 7309724372497243 q2 331 233 229 229 q3 3021297029522952 q4 2077179017791779 q5 5768576658125766 q6 225 143 143 143 q7 2208180917531753 q8 3378348434723472 q9 8925891488848884 q10 3590351535443515 q11 576 497 477 477 q12 844 644 614 614 q13 10787 317532023175 q14 320 270 273 270 q15 568 523 527 523 q16 685 647 644 644 q17 1839162116151615 q18 8306777674617461 q19 1705147614181418 q20 2135192018261826 q21 5554546653835383 q22 1177104310481043 Total cold run time: 71328 ms Total hot run time: 60185 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [env](compile)open compile check in function string [doris]
github-actions[bot] commented on PR #42474: URL: https://github.com/apache/doris/pull/42474#issuecomment-2439931280 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] NPE can occur in the Response Path if MetricRepo is not initialized yet [doris]
doris-robot commented on PR #42505: URL: https://github.com/apache/doris/pull/42505#issuecomment-2439885541 TPC-DS: Total hot run time: 191223 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit c0295db381a40ef503d3a22ccdd55a4f64bd8007, data reload: false query1 844 407 396 396 query2 7211209820802080 query3 8680187 195 187 query4 34471 23760 23584 23584 query5 4538446 451 446 query6 278 178 186 178 query7 4197295 298 295 query8 300 235 241 235 query9 9507270927052705 query10 481 257 245 245 query11 18258 15207 15406 15207 query12 149 104 97 97 query13 1594443 411 411 query14 9304713364306430 query15 246 174 173 173 query16 7882489 498 489 query17 1402593 584 584 query18 2137304 308 304 query19 235 174 154 154 query20 125 118 115 115 query21 202 107 106 106 query22 4937460746684607 query23 35123 33998 34129 33998 query24 11067 282027492749 query25 635 399 402 399 query26 1270166 169 166 query27 2702292 283 283 query28 7656243424092409 query29 867 421 410 410 query30 270 160 157 157 query31 1021779 786 779 query32 94 53 55 53 query33 778 258 283 258 query34 948 529 518 518 query35 1029880 891 880 query36 1087943 940 940 query37 132 73 76 73 query38 4458421942774219 query39 1470142414201420 query40 251 101 99 99 query41 49 46 46 46 query42 108 100 100 100 query43 541 476 494 476 query44 1282802 804 802 query45 182 164 165 164 query46 1127699 714 699 query47 1952185018391839 query48 440 322 321 321 query49 943 413 403 403 query50 809 400 388 388 query51 7186704168816881 query52 106 94 87 87 query53 254 180 182 180 query54 1161402 398 398 query55 76 73 73 73 query56 257 235 240 235 query57 1292117911771177 query58 216 197 201 197 query59 3199287529692875 query60 268 243 239 239 query61 97 98 95 95 query62 870 680 669 669 query63 218 188 181 181 query64 4112629 616 616 query65 3284320032013200 query66 946 334 302 302 query67 16071 15720 15665 15665 query68 4691566 543 543 query69 435 257 258 257 query70 1188115511501150 query71 405 245 257 245 query72 6231404739443944 query73 762 360 359 359 query74 10249 909789678967 query75 3415266626882666 query76 2860960 914 914 query77 391 265 274 265 query78 10585 969595999599 query79 1126594 591 591 query80 742 409 439 409 query81 519 248 237 237 query82 719 111 113 111 query83 229 142 139 139 query84 243 67 67 67 query85 1052290 279 279 query86 334 289 295 289 query87 5027472247514722 query88 3456221021652165 query89 390 290 284 284 query90 1978188 186 186 query91 137 98 98 98 query92 55 48 49 48 query93 1075525 524 524 query94 730 293 282 282 query95 346 240 242 240 query96 620 283 278 278 query97 2921272026972697 query98 212 195 187 187 query99 1522133513481335 Total cold run time: 299527 ms Total hot run time: 191223 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] NPE can occur in the Response Path if MetricRepo is not initialized yet [doris]
doris-robot commented on PR #42505: URL: https://github.com/apache/doris/pull/42505#issuecomment-2439886770 ClickBench: Total hot run time: 32.6 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit c0295db381a40ef503d3a22ccdd55a4f64bd8007, data reload: false query1 0.040.030.03 query2 0.060.030.03 query3 0.230.060.06 query4 1.640.100.11 query5 0.430.430.40 query6 1.160.650.66 query7 0.020.010.02 query8 0.040.030.03 query9 0.570.530.51 query10 0.540.540.55 query11 0.140.110.10 query12 0.130.120.11 query13 0.600.610.60 query14 2.732.782.74 query15 0.900.830.81 query16 0.380.390.40 query17 0.990.971.00 query18 0.200.200.20 query19 1.891.831.84 query20 0.020.020.01 query21 15.37 0.590.58 query22 2.322.531.78 query23 17.27 0.960.76 query24 3.281.141.21 query25 0.210.140.08 query26 0.500.140.14 query27 0.060.050.04 query28 10.32 1.101.07 query29 12.57 3.323.30 query30 0.250.070.06 query31 2.850.400.38 query32 3.260.450.46 query33 2.993.033.03 query34 16.83 4.424.48 query35 4.494.494.48 query36 0.690.480.48 query37 0.080.060.05 query38 0.040.040.03 query39 0.030.020.03 query40 0.160.130.12 query41 0.080.020.02 query42 0.030.020.02 query43 0.040.030.03 Total cold run time: 106.43 s Total hot run time: 32.6 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) refine block file cache evict policy [doris]
github-actions[bot] commented on PR #42451: URL: https://github.com/apache/doris/pull/42451#issuecomment-2439981551 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) refine block file cache evict policy [doris]
gavinchou commented on code in PR #42451:
URL: https://github.com/apache/doris/pull/42451#discussion_r1818143951
##
be/test/io/cache/block_file_cache_test.cpp:
##
@@ -1136,7 +1136,7 @@ TEST_F(BlockFileCacheTest, max_ttl_size) {
auto holder = cache.get_or_set(key1, offset, 10, context);
auto blocks = fromHolder(holder);
ASSERT_EQ(blocks.size(), 1);
-if (offset < 9000) {
+if (offset < (1 * config::max_ttl_cache_ratio / 100)) {
Review Comment:
better to use `1L`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) refine block file cache evict policy [doris]
gavinchou commented on PR #42451: URL: https://github.com/apache/doris/pull/42451#issuecomment-2440104953 This PR introduce some behavior change, pls describe what it is -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](cloud) Remove patchelf in start.sh for meta-service (#42299) [doris]
doris-robot commented on PR #42513: URL: https://github.com/apache/doris/pull/42513#issuecomment-2440109637 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [opt](cloud) Remove patchelf in start.sh for meta-service (#42299) [doris]
gavinchou opened a new pull request, #42513: URL: https://github.com/apache/doris/pull/42513 `patchelf` is not always available in all runtime environments, remove it from start script for ms. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [env](compile) open compile check in some file [doris]
doris-robot commented on PR #42497: URL: https://github.com/apache/doris/pull/42497#issuecomment-2440113450 TeamCity be ut coverage result: Function Coverage: 37.46% (9714/25935) Line Coverage: 28.72% (80567/280482) Region Coverage: 28.15% (41667/147994) Branch Coverage: 24.71% (21169/85662) Coverage Report: http://coverage.selectdb-in.cc/coverage/c4c39ab602ed45672ad7375fe3936cad972f6b1a_c4c39ab602ed45672ad7375fe3936cad972f6b1a/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [enhancement](log) logout tablename with temp partitions in backup [doris]
dataroaring commented on PR #42549: URL: https://github.com/apache/doris/pull/42549#issuecomment-2440513121 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](schema change) Support add column bitmap with default value bitmap_empty [doris]
dataroaring merged PR #42331: URL: https://github.com/apache/doris/pull/42331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
