Re: [PR] [fix](cancel) Fix cancel reason on master [doris]
github-actions[bot] commented on PR #41867: URL: https://github.com/apache/doris/pull/41867#issuecomment-2413057371 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](doris-future) Support REGR_SXX_SXY_SYY aggregation functions [doris]
zhiqiang- commented on code in PR #39187:
URL: https://github.com/apache/doris/pull/39187#discussion_r1800567192
##
be/src/vec/aggregate_functions/aggregate_function_regr_union.h:
##
@@ -98,6 +98,173 @@ struct AggregateFunctionRegrData {
return slope;
}
};
+template
+struct AggregateFunctionRegrSxxData {
+using Type = T;
+UInt64 count = 0;
+Float64 sum_x {};
+Float64 sum_of_x_squared {};
+
+void write(BufferWritable& buf) const {
+write_binary(sum_x, buf);
+write_binary(sum_of_x_squared, buf);
+write_binary(count, buf);
+}
+
+void read(BufferReadable& buf) {
+read_binary(sum_x, buf);
+read_binary(sum_of_x_squared, buf);
+read_binary(count, buf);
+}
+
+void reset() {
+sum_x = {};
+sum_of_x_squared = {};
+count = 0;
+}
+
+void merge(const AggregateFunctionRegrSxxData& rhs) {
+if (rhs.count == 0) {
+return;
+}
+sum_x += rhs.sum_x;
+sum_of_x_squared += rhs.sum_of_x_squared;
+count += rhs.count;
+}
+
+void add(T value_y, T value_x) {
+sum_x += value_x;
+sum_of_x_squared += value_x * value_x;
+count += 1;
+}
+
+Float64 get_regr_sxx_result() const {
+// count == 0
+// The result of a query for an empty table is a null value
+Float64 result = sum_of_x_squared - (sum_x * sum_x / count);
+return result;
+}
+};
+template
+struct AggregateFunctionRegrSxyData {
+using Type = T;
+UInt64 count = 0;
+Float64 sum_x {};
+Float64 sum_y {};
+Float64 sum_of_x_mul_y {};
+
+void write(BufferWritable& buf) const {
+write_binary(sum_x, buf);
+write_binary(sum_y, buf);
+write_binary(sum_of_x_mul_y, buf);
+write_binary(count, buf);
+}
+
+void read(BufferReadable& buf) {
+read_binary(sum_x, buf);
+read_binary(sum_y, buf);
+read_binary(sum_of_x_mul_y, buf);
+read_binary(count, buf);
+}
+
+void reset() {
+sum_x = {};
+sum_y = {};
+sum_of_x_mul_y = {};
+count = 0;
+}
+
+void merge(const AggregateFunctionRegrSxyData& rhs) {
+if (rhs.count == 0) {
+return;
+}
+sum_x += rhs.sum_x;
+sum_y += rhs.sum_y;
+sum_of_x_mul_y += rhs.sum_of_x_mul_y;
+count += rhs.count;
+}
+
+void add(T value_y, T value_x) {
+sum_x += value_x;
+sum_y += value_y;
+sum_of_x_mul_y += value_x * value_y;
+count += 1;
+}
+
+Float64 get_regr_sxy_result() const {
+// count == 0
+// The result of a query for an empty table is a null value
+Float64 result = sum_of_x_mul_y - (sum_x * sum_y / count);
+return result;
+}
+};
+template
+struct AggregateFunctionRegrSyyData {
+using Type = T;
+UInt64 count = 0;
+Float64 sum_y {};
+Float64 sum_of_y_squared {};
+
+void write(BufferWritable& buf) const {
+write_binary(sum_y, buf);
+write_binary(sum_of_y_squared, buf);
+write_binary(count, buf);
+}
+
+void read(BufferReadable& buf) {
+read_binary(sum_y, buf);
+read_binary(sum_of_y_squared, buf);
+read_binary(count, buf);
+}
+
+void reset() {
+sum_y = {};
+sum_of_y_squared = {};
+count = 0;
+}
+
+void merge(const AggregateFunctionRegrSyyData& rhs) {
+if (rhs.count == 0) {
+return;
+}
+sum_y += rhs.sum_y;
+sum_of_y_squared += rhs.sum_of_y_squared;
+count += rhs.count;
+}
+
+void add(T value_y, T value_x) {
+sum_y += value_y;
+sum_of_y_squared += value_y * value_y;
+count += 1;
+}
+
+Float64 get_regr_syy_result() const {
+// count == 0
+// The result of a query for an empty table is a null value
+Float64 result = sum_of_y_squared - (sum_y * sum_y / count);
Review Comment:
```
if count == 0 {
return Nan;
}
```
##
be/src/vec/aggregate_functions/aggregate_function_regr_union.h:
##
@@ -98,6 +98,173 @@ struct AggregateFunctionRegrData {
return slope;
}
};
+template
+struct AggregateFunctionRegrSxxData {
+using Type = T;
+UInt64 count = 0;
+Float64 sum_x {};
+Float64 sum_of_x_squared {};
+
+void write(BufferWritable& buf) const {
+write_binary(sum_x, buf);
+write_binary(sum_of_x_squared, buf);
+write_binary(count, buf);
+}
+
+void read(BufferReadable& buf) {
+read_binary(sum_x, buf);
+read_binary(sum_of_x_squared, buf);
+read_binary(count, buf);
+}
+
+void reset() {
+sum_x = {};
+sum_of_x_squared = {};
+count = 0;
+}
+
+void merge(const AggregateFunctionRegrSxxData& rhs) {
+if (rhs.count == 0) {
+return;
+
Re: [PR] [branch-2.1] Fix `is_partial_update` parameter is not set in `append_block_with_partial_content()` [doris]
doris-robot commented on PR #41865: URL: https://github.com/apache/doris/pull/41865#issuecomment-2413059990 TeamCity be ut coverage result: Function Coverage: 36.03% (9342/25927) Line Coverage: 27.61% (76731/277960) Region Coverage: 26.42% (39425/149248) Branch Coverage: 23.19% (20052/86456) Coverage Report: http://coverage.selectdb-in.cc/coverage/f20c61aaed2617ad36fe0d3c92683fea39e4bc7b_f20c61aaed2617ad36fe0d3c92683fea39e4bc7b/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cancel) Fix cancel msg on branch-2.1 [doris]
doris-robot commented on PR #41798: URL: https://github.com/apache/doris/pull/41798#issuecomment-2413063835 TeamCity be ut coverage result: Function Coverage: 36.03% (9342/25927) Line Coverage: 27.62% (76767/277960) Region Coverage: 26.41% (39421/149248) Branch Coverage: 23.20% (20057/86456) Coverage Report: http://coverage.selectdb-in.cc/coverage/d898a1b110973c94d19201529343ff4fd7b8fa2b_d898a1b110973c94d19201529343ff4fd7b8fa2b/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](ip/variant) fix information meta [doris]
amorynan opened a new pull request, #41871: URL: https://github.com/apache/doris/pull/41871 fix datatype information meta for ip/variant (#41666) ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](ip/variant) fix information meta [doris]
doris-robot commented on PR #41871: URL: https://github.com/apache/doris/pull/41871#issuecomment-2413064799 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Nereids) ignore match expression logging warning message [doris]
LiBinfeng-01 commented on PR #41546: URL: https://github.com/apache/doris/pull/41546#issuecomment-2413064816 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](ip/variant) fix information meta [doris]
amorynan commented on PR #41871: URL: https://github.com/apache/doris/pull/41871#issuecomment-2413064812 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](job)Implementing Job in Nereids (#41391) [doris]
doris-robot commented on PR #41861: URL: https://github.com/apache/doris/pull/41861#issuecomment-2413071393 TPC-DS: Total hot run time: 193497 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 9e4c3ee3213b77f6a03e65db0af7d16c72ce8a8c, data reload: false query1 1223876 858 858 query2 6278206919871987 query3 10780 374937773749 query4 64069 29147 23466 23466 query5 4998444 457 444 query6 387 158 160 158 query7 5407305 299 299 query8 279 201 204 201 query9 8499267226502650 query10 459 283 261 261 query11 16941 15131 15580 15131 query12 160 100 108 100 query13 1565454 436 436 query14 10822 744872637263 query15 222 192 172 172 query16 7099506 497 497 query17 1164600 598 598 query18 1733312 305 305 query19 211 173 154 154 query20 121 108 110 108 query21 215 104 103 103 query22 4556438744704387 query23 34722 33938 33755 33755 query24 6004289628002800 query25 513 400 393 393 query26 652 167 158 158 query27 1648300 285 285 query28 3908217521572157 query29 675 435 433 433 query30 226 157 151 151 query31 926 771 782 771 query32 70 53 54 53 query33 387 285 299 285 query34 877 499 488 488 query35 878 747 743 743 query36 1067931 949 931 query37 130 80 73 73 query38 3900383239883832 query39 1474141814251418 query40 202 98 99 98 query41 43 42 45 42 query42 113 97 93 93 query43 518 484 472 472 query44 1148765 763 763 query45 193 164 166 164 query46 1116710 711 710 query47 1922181218181812 query48 422 337 324 324 query49 700 364 368 364 query50 811 410 392 392 query51 7519685668266826 query52 101 88 86 86 query53 255 183 179 179 query54 582 456 441 441 query55 74 77 76 76 query56 264 248 248 248 query57 1259113611641136 query58 231 226 235 226 query59 2991285130732851 query60 289 263 259 259 query61 103 98 95 95 query62 751 639 665 639 query63 210 180 178 178 query64 1310631 582 582 query65 3246314732073147 query66 656 301 301 301 query67 15725 15263 15325 15263 query68 4056541 529 529 query69 765 289 287 287 query70 1065111811621118 query71 487 273 278 273 query72 8084397440023974 query73 785 336 339 336 query74 10420 891490488914 query75 4621265626312631 query76 3899916 922 916 query77 784 286 295 286 query78 9976923491309130 query79 4646567 590 567 query80 2461458 463 458 query81 565 223 227 223 query82 1386134 131 131 query83 312 138 136 136 query84 302 77 76 76 query85 1145291 284 284 query86 445 290 302 290 query87 4564423242874232 query88 5419236723902367 query89 406 285 292 285 query90 2264186 181 181 query91 132 104 103 103 query92 57 46 45 45 query93 5436529 524 524 query94 1079283 284 283 query95 343 249 248 248 query96 616 271 277 271 query97 3274316030803080 query98 208 194 200 194 query99 1824131413051305 Total cold run time: 329825 ms Total hot run time: 193497 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] [cherry-pick](branch-21) should check the expr of auto range partition (#41626) [doris]
doris-robot commented on PR #41872: URL: https://github.com/apache/doris/pull/41872#issuecomment-2413072387 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bugfix](paimon)upgrade paimon to 0.9 [doris]
doris-robot commented on PR #41337: URL: https://github.com/apache/doris/pull/41337#issuecomment-2413072716 TPC-DS: Total hot run time: 192068 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 2e3fc0a04e8d0d257edc5c6ffbe7188067807184, data reload: false query1 937 383 403 383 query2 6273203819811981 query3 8682193 214 193 query4 34222 23638 23519 23519 query5 3598503 466 466 query6 269 164 162 162 query7 4209303 284 284 query8 280 221 247 221 query9 9380278627732773 query10 432 280 267 267 query11 17888 15457 15426 15426 query12 165 102 97 97 query13 1588457 427 427 query14 10282 711077867110 query15 252 167 176 167 query16 7531490 449 449 query17 1612597 589 589 query18 2038315 334 315 query19 367 163 158 158 query20 122 117 114 114 query21 221 111 110 110 query22 4787445144894451 query23 38285 34421 34037 34037 query24 11034 276128272761 query25 527 419 410 410 query26 934 158 169 158 query27 2462305 289 289 query28 7497243824222422 query29 681 432 428 428 query30 260 157 156 156 query31 1054772 801 772 query32 102 55 56 55 query33 763 292 288 288 query34 932 524 517 517 query35 882 760 751 751 query36 1098955 954 954 query37 150 95 91 91 query38 4005400240174002 query39 1474143714381437 query40 262 98 100 98 query41 50 50 46 46 query42 126 100 101 100 query43 535 493 489 489 query44 1264826 834 826 query45 196 165 165 165 query46 1133729 724 724 query47 1944187618451845 query48 412 329 318 318 query49 953 419 441 419 query50 804 415 405 405 query51 7177690368716871 query52 104 93 86 86 query53 262 185 188 185 query54 1162453 437 437 query55 84 82 82 82 query56 296 259 259 259 query57 1278115611271127 query58 232 252 229 229 query59 3189286228802862 query60 303 262 265 262 query61 105 100 108 100 query62 825 672 671 671 query63 232 193 189 189 query64 4617632 620 620 query65 3274322732033203 query66 860 299 310 299 query67 15809 15712 15511 15511 query68 4469578 561 561 query69 517 293 294 293 query70 1182111911261119 query71 337 272 281 272 query72 7070403039613961 query73 775 364 363 363 query74 10229 899590508995 query75 3464271526852685 query76 2927913 885 885 query77 687 310 294 294 query78 10516 970296269626 query79 1197604 606 604 query80 2033464 464 464 query81 569 245 242 242 query82 702 141 140 140 query83 306 143 141 141 query84 289 68 72 68 query85 1328303 292 292 query86 362 295 307 295 query87 4538436243344334 query88 3380223221892189 query89 406 290 292 290 query90 2161189 190 189 query91 142 109 108 108 query92 65 46 49 46 query93 1068531 535 531 query94 979 305 297 297 query95 353 253 250 250 query96 616 275 288 275 query97 3310314431483144 query98 225 214 197 197 query99 1507130013141300 Total cold run time: 302472 ms Total hot run time: 192068 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] [cherry-pick](branch-21) should check the expr of auto range partition (#41626) [doris]
zhangstar333 commented on PR #41872: URL: https://github.com/apache/doris/pull/41872#issuecomment-2413072543 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [cherry-pick](branch-21) should check the expr of auto range partition (#41626) [doris]
zhangstar333 opened a new pull request, #41872: URL: https://github.com/apache/doris/pull/41872 ## Proposed changes cherry-pick from master (#41626) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](ip/variant) fix information meta [doris]
github-actions[bot] commented on PR #41871: URL: https://github.com/apache/doris/pull/41871#issuecomment-2413076315 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [cherry-pick](branch-30) should check the expr of auto range partition (#41626) [doris]
zhangstar333 opened a new pull request, #41873: URL: https://github.com/apache/doris/pull/41873 ## Proposed changes cherry-pick from master (#41626) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [cherry-pick](branch-30) should check the expr of auto range partition (#41626) [doris]
doris-robot commented on PR #41873: URL: https://github.com/apache/doris/pull/41873#issuecomment-2413078586 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [cherry-pick](branch-30) should check the expr of auto range partition (#41626) [doris]
zhangstar333 commented on PR #41873: URL: https://github.com/apache/doris/pull/41873#issuecomment-2413078799 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](mtmv) regression test unstable and error [doris]
seawinde commented on PR #41145: URL: https://github.com/apache/doris/pull/41145#issuecomment-2413081498 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor]Delete useless code check_set_nullable() [doris]
Yoruet commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1801488619
##
be/src/vec/functions/array/function_array_range.cpp:
##
@@ -146,14 +144,6 @@ struct RangeImplUtil {
for (int i = 0; i < 3; ++i) {
argument_columns[i] =
block.get_by_position(arguments[i]).column->convert_to_full_column_if_const();
-if (auto* nullable =
check_and_get_column(*argument_columns[i])) {
-// Danger: Here must dispose the null map data first! Because
-// argument_columns[i]=nullable->get_nested_column_ptr(); will
release the mem
-// of column nullable mem of null map
-VectorizedUtils::update_null_map(args_null_map->get_data(),
Review Comment:
I thought that `args_null_map` is working, and it's just dont need to
update_null_map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](block-reader) Fix non-overlap rowsets reading shortcut not work [doris]
TangSiyang2001 commented on PR #40877: URL: https://github.com/apache/doris/pull/40877#issuecomment-2414412323 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor]Delete useless code check_set_nullable() [doris]
Yoruet commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1801491554
##
be/src/vec/functions/array/function_array_range.cpp:
##
@@ -146,14 +144,6 @@ struct RangeImplUtil {
for (int i = 0; i < 3; ++i) {
argument_columns[i] =
block.get_by_position(arguments[i]).column->convert_to_full_column_if_const();
-if (auto* nullable =
check_and_get_column(*argument_columns[i])) {
-// Danger: Here must dispose the null map data first! Because
-// argument_columns[i]=nullable->get_nested_column_ptr(); will
release the mem
-// of column nullable mem of null map
-VectorizedUtils::update_null_map(args_null_map->get_data(),
Review Comment:
because in the following code, `args_null_map` is used as a function
parameter. If it is deleted, unexpected errors may occur.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](block-reader) Fix non-overlap rowsets reading shortcut not work [doris]
github-actions[bot] commented on PR #40877: URL: https://github.com/apache/doris/pull/40877#issuecomment-2414422304 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor]Delete useless code check_set_nullable() [doris]
Yoruet commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1801495314
##
be/src/vec/functions/array/function_array_contains_all.cpp:
##
@@ -37,8 +37,6 @@ class FunctionArrayContainsAll : public IFunction {
String get_name() const override { return name; }
-bool use_default_implementation_for_nulls() const override { return true; }
Review Comment:
actually the other reviewer suggest me to remove this code so i doing it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor]Delete useless code check_set_nullable() [doris]
Yoruet commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1801495314
##
be/src/vec/functions/array/function_array_contains_all.cpp:
##
@@ -37,8 +37,6 @@ class FunctionArrayContainsAll : public IFunction {
String get_name() const override { return name; }
-bool use_default_implementation_for_nulls() const override { return true; }
Review Comment:
actually the other reviewer suggest me to remove this code so i do it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pick](branch-2.1) pick #41676 #41740 #41857 [doris]
Gabriel39 merged PR #41904: URL: https://github.com/apache/doris/pull/41904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](Coordinator) refactor coordinator [doris]
github-actions[bot] commented on PR #41730: URL: https://github.com/apache/doris/pull/41730#issuecomment-2414146912 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](thirdparty) Disable BRPC 1.4 contention profiler to avoid deadlock [doris]
doris-robot commented on PR #41891: URL: https://github.com/apache/doris/pull/41891#issuecomment-2414281195 TeamCity be ut coverage result: Function Coverage: 37.46% (9708/25916) Line Coverage: 28.74% (80630/280504) Region Coverage: 28.18% (41704/147970) Branch Coverage: 24.77% (21213/85638) Coverage Report: http://coverage.selectdb-in.cc/coverage/5a9bb10a5f14111e3ced8c64a1832740fc80efaf_5a9bb10a5f14111e3ced8c64a1832740fc80efaf/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](mtmv) Support partition trace from multi join input when create parition materialized view [doris]
seawinde commented on PR #40942: URL: https://github.com/apache/doris/pull/40942#issuecomment-2414297666 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [imporve][load] support set stream-load data size limit by http header [doris]
github-actions[bot] commented on PR #41914: URL: https://github.com/apache/doris/pull/41914#issuecomment-2414134375 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](index compaction) fix fd leak and mem leak while index compaction [doris]
doris-robot commented on PR #41915: URL: https://github.com/apache/doris/pull/41915#issuecomment-2414185553 TPC-H: Total hot run time: 41362 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit ee28396e4272aaf87cbccf286e42c46a91ca65e8, data reload: false -- Round 1 -- q1 17584 736572887288 q2 2014300 285 285 q3 12045 106512351065 q4 10586 866 745 745 q5 7764308730953087 q6 234 148 148 148 q7 1025609 623 609 q8 9350200819171917 q9 6536647464486448 q10 7055245224852452 q11 454 242 234 234 q12 411 219 229 219 q13 17770 301230313012 q14 244 208 219 208 q15 584 520 509 509 q16 647 586 593 586 q17 984 572 495 495 q18 7279671467086708 q19 1348987 1024987 q20 492 181 187 181 q21 4177318032733180 q22 1128999 1004999 Total cold run time: 109711 ms Total hot run time: 41362 ms - Round 2, with runtime_filter_mode=off - q1 7291721972287219 q2 323 234 228 228 q3 3056298129702970 q4 2090181218861812 q5 5897587759775877 q6 236 152 149 149 q7 2368188618791879 q8 3437347535103475 q9 8947894089278927 q10 3591357435583558 q11 598 483 496 483 q12 904 634 635 634 q13 10664 324032093209 q14 315 289 293 289 q15 597 521 530 521 q16 705 645 633 633 q17 1815163016001600 q18 8342772477577724 q19 1710138514631385 q20 2136188318581858 q21 5760543054045404 q22 1166107910311031 Total cold run time: 71948 ms Total hot run time: 60865 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [env](compile) Replace the shorten-64-to-32 check with a conversion check. [doris]
doris-robot commented on PR #41917: URL: https://github.com/apache/doris/pull/41917#issuecomment-2414181964 ClickBench: Total hot run time: 33.22 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 6f3ba81e5d9750893267957ae46251dfe38e26a0, data reload: false query1 0.030.030.03 query2 0.060.030.03 query3 0.240.060.06 query4 1.640.100.10 query5 0.510.510.50 query6 1.130.720.72 query7 0.020.020.01 query8 0.040.030.03 query9 0.570.510.54 query10 0.550.550.56 query11 0.140.110.11 query12 0.140.110.11 query13 0.610.620.59 query14 2.712.722.71 query15 0.900.820.85 query16 0.380.370.39 query17 1.020.991.01 query18 0.200.200.21 query19 1.981.871.98 query20 0.020.010.01 query21 15.36 0.610.60 query22 2.922.732.29 query23 16.87 0.950.87 query24 3.081.381.06 query25 0.210.100.14 query26 0.510.130.13 query27 0.040.050.03 query28 10.50 1.091.07 query29 12.57 3.203.23 query30 0.260.060.05 query31 2.880.380.36 query32 3.300.450.46 query33 2.953.043.01 query34 16.89 4.474.46 query35 4.554.474.45 query36 0.660.480.50 query37 0.080.060.06 query38 0.040.030.04 query39 0.030.020.02 query40 0.150.130.12 query41 0.070.030.02 query42 0.040.020.02 query43 0.040.030.02 Total cold run time: 106.89 s Total hot run time: 33.22 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](statistics)Support partition row count return -1 when it is not fully reported. (#41348) [doris]
Jibing-Li commented on PR #41916: URL: https://github.com/apache/doris/pull/41916#issuecomment-2414184248 run cloud_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](local shuffle) Improve local shuffle strategy [doris]
doris-robot commented on PR #41789: URL: https://github.com/apache/doris/pull/41789#issuecomment-2414251156 ClickBench: Total hot run time: 33.06 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 43b859290d53585f272bb65e8f32c5d5290272b0, data reload: false query1 0.030.040.03 query2 0.080.040.04 query3 0.220.050.05 query4 1.660.080.07 query5 0.510.500.51 query6 1.130.750.77 query7 0.020.010.02 query8 0.050.040.04 query9 0.550.490.51 query10 0.540.560.57 query11 0.180.130.13 query12 0.150.130.12 query13 0.620.600.59 query14 2.712.692.85 query15 0.890.840.84 query16 0.380.360.39 query17 1.071.001.04 query18 0.180.180.18 query19 1.861.771.94 query20 0.010.010.01 query21 15.36 0.670.67 query22 4.836.851.80 query23 18.26 1.311.24 query24 2.070.250.22 query25 0.150.090.08 query26 0.250.180.17 query27 0.070.080.07 query28 13.21 1.161.12 query29 12.64 3.423.40 query30 0.240.060.06 query31 2.870.400.40 query32 3.230.480.48 query33 3.003.023.02 query34 16.93 4.494.55 query35 4.584.524.60 query36 0.660.470.50 query37 0.210.170.17 query38 0.150.140.14 query39 0.050.040.04 query40 0.160.130.14 query41 0.100.050.05 query42 0.060.060.05 query43 0.050.040.04 Total cold run time: 111.97 s Total hot run time: 33.06 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] Improve Compaction Profiling and Logging [doris]
github-actions[bot] commented on PR #41903: URL: https://github.com/apache/doris/pull/41903#issuecomment-2414249356 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](index compaction) fix fd leak and mem leak while index compaction [doris]
doris-robot commented on PR #41915: URL: https://github.com/apache/doris/pull/41915#issuecomment-2414262051 ClickBench: Total hot run time: 33.22 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit ee28396e4272aaf87cbccf286e42c46a91ca65e8, data reload: false query1 0.040.030.03 query2 0.070.030.02 query3 0.230.060.06 query4 1.640.110.10 query5 0.500.500.49 query6 1.120.720.73 query7 0.020.020.02 query8 0.030.050.03 query9 0.570.490.49 query10 0.550.540.54 query11 0.150.110.11 query12 0.140.100.11 query13 0.620.600.60 query14 2.722.702.72 query15 0.900.840.85 query16 0.380.370.37 query17 1.001.051.01 query18 0.200.200.19 query19 1.931.832.01 query20 0.020.010.00 query21 15.35 0.570.58 query22 2.842.172.02 query23 17.05 0.890.84 query24 2.891.271.67 query25 0.220.110.12 query26 0.460.130.15 query27 0.050.040.04 query28 9.981.101.07 query29 12.54 3.263.25 query30 0.240.060.06 query31 2.860.380.37 query32 3.310.460.45 query33 3.043.013.04 query34 17.13 4.484.49 query35 4.514.534.52 query36 0.670.490.48 query37 0.080.060.06 query38 0.050.040.03 query39 0.040.020.03 query40 0.160.130.12 query41 0.080.020.03 query42 0.030.020.02 query43 0.040.030.03 Total cold run time: 106.45 s Total hot run time: 33.22 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] Improve Compaction Profiling and Logging [doris]
github-actions[bot] commented on PR #41903: URL: https://github.com/apache/doris/pull/41903#issuecomment-2414384760 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](statistics)Support partition row count return -1 when it is not fully reported. (#41348) [doris]
Jibing-Li commented on PR #41916: URL: https://github.com/apache/doris/pull/41916#issuecomment-2414403975 run cloud_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] Improve Compaction Profiling and Logging [doris]
github-actions[bot] commented on PR #41903: URL: https://github.com/apache/doris/pull/41903#issuecomment-2414511907 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](block-reader) Fix non-overlap rowsets reading shortcut not work [doris]
doris-robot commented on PR #40877: URL: https://github.com/apache/doris/pull/40877#issuecomment-2414524766 TPC-DS: Total hot run time: 192509 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 6514a0fcd5381aac00db3d7618eb392c259120ea, data reload: false query1 914 394 402 394 query2 6252213920862086 query3 8685199 203 199 query4 34416 23624 23764 23624 query5 3357481 478 478 query6 264 171 170 170 query7 4195294 285 285 query8 290 224 235 224 query9 9242277627712771 query10 458 268 266 266 query11 17983 15357 15173 15173 query12 160 101 99 99 query13 1576424 435 424 query14 9406754475067506 query15 253 177 183 177 query16 8040470 458 458 query17 1662610 596 596 query18 2146321 309 309 query19 396 152 163 152 query20 125 121 118 118 query21 208 107 105 105 query22 4614440445004404 query23 35163 34260 34360 34260 query24 11014 278828112788 query25 628 417 409 409 query26 1165164 171 164 query27 2260291 280 280 query28 7533244924272427 query29 852 432 430 430 query30 269 157 158 157 query31 1046800 825 800 query32 100 57 55 55 query33 770 298 287 287 query34 929 517 514 514 query35 883 746 761 746 query36 1088961 961 961 query37 161 94 99 94 query38 4042391839143914 query39 1512142014221420 query40 215 101 108 101 query41 49 48 47 47 query42 132 103 99 99 query43 538 500 493 493 query44 1234826 814 814 query45 198 167 166 166 query46 1132718 731 718 query47 1954183818521838 query48 424 322 355 322 query49 939 426 423 423 query50 817 396 410 396 query51 7160699269376937 query52 101 93 88 88 query53 266 183 185 183 query54 1134431 434 431 query55 82 77 77 77 query56 290 277 274 274 query57 1321114811631148 query58 237 238 246 238 query59 3272314929212921 query60 306 269 275 269 query61 109 104 99 99 query62 857 683 675 675 query63 224 188 184 184 query64 3970637 635 635 query65 3284322431883188 query66 815 304 313 304 query67 15989 15540 15583 15540 query68 4423564 563 563 query69 516 288 292 288 query70 1207113511361135 query71 359 280 312 280 query72 7273392139593921 query73 783 349 363 349 query74 10390 903989828982 query75 3417262827052628 query76 2866958 865 865 query77 619 315 330 315 query78 10492 963298689632 query79 1685606 595 595 query80 1072444 448 444 query81 575 242 237 237 query82 644 144 140 140 query83 297 141 133 133 query84 275 69 70 69 query85 1257297 280 280 query86 394 305 305 305 query87 4550433842464246 query88 3288222421832183 query89 406 293 290 290 query90 1937185 189 185 query91 136 98 101 98 query92 63 50 49 49 query93 1597546 548 546 query94 967 280 277 277 query95 354 247 249 247 query96 614 281 284 281 query97 3248312831533128 query98 209 196 192 192 query99 1592130012941294 Total cold run time: 298611 ms Total hot run time: 192509 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [fix](block-reader) Fix non-overlap rowsets reading shortcut not work [doris]
doris-robot commented on PR #40877: URL: https://github.com/apache/doris/pull/40877#issuecomment-2414536822 ClickBench: Total hot run time: 32.23 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 6514a0fcd5381aac00db3d7618eb392c259120ea, data reload: false query1 0.040.040.03 query2 0.060.030.03 query3 0.220.070.07 query4 1.630.100.10 query5 0.530.490.49 query6 1.130.720.73 query7 0.020.010.02 query8 0.040.030.03 query9 0.560.500.51 query10 0.550.550.55 query11 0.140.120.10 query12 0.140.110.12 query13 0.610.590.60 query14 2.822.832.86 query15 0.880.840.83 query16 0.390.390.37 query17 1.031.011.00 query18 0.200.200.19 query19 1.871.861.99 query20 0.010.010.01 query21 15.38 0.590.59 query22 2.502.391.80 query23 16.96 0.810.80 query24 3.031.820.50 query25 0.220.050.05 query26 0.660.130.14 query27 0.050.040.04 query28 10.51 1.091.08 query29 12.60 3.223.21 query30 0.250.060.06 query31 2.870.380.37 query32 3.260.460.45 query33 2.993.043.04 query34 16.86 4.454.49 query35 4.524.484.50 query36 0.680.470.50 query37 0.080.060.05 query38 0.050.030.03 query39 0.030.020.02 query40 0.160.130.12 query41 0.080.020.02 query42 0.030.020.02 query43 0.040.030.03 Total cold run time: 106.68 s Total hot run time: 32.23 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Feat](nereids) support pull up predicate from set operator (#39450) [doris]
feiniaofeiafei opened a new pull request, #41908: URL: https://github.com/apache/doris/pull/41908 cherry-pick #39450 to branch-3.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feat](nereids) support pull up predicate from set operator (#39450) [doris]
doris-robot commented on PR #41908: URL: https://github.com/apache/doris/pull/41908#issuecomment-2413692084 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feat](nereids) support pull up predicate from set operator (#39450) [doris]
feiniaofeiafei commented on PR #41908: URL: https://github.com/apache/doris/pull/41908#issuecomment-2413692250 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-3.0 updated: [opt](cpu-profile) enable cpu profile in BE webui (#40330) (#41849)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new b2d245cacae [opt](cpu-profile) enable cpu profile in BE webui (#40330)
(#41849)
b2d245cacae is described below
commit b2d245cacaea9b6d1ed7622a5ee281d13e63d15b
Author: Rayner Chen
AuthorDate: Tue Oct 15 19:57:36 2024 +0800
[opt](cpu-profile) enable cpu profile in BE webui (#40330) (#41849)
bp #40330
---
.licenserc.yaml|1 +
LICENSE.txt| 10 +-
be/src/http/action/pprof_actions.cpp | 11 +-
be/src/http/default_path_handlers.cpp | 21 +-
be/src/util/pprof_utils.cpp|4 +
be/src/vec/exec/scan/vfile_scanner.cpp |2 +-
be/src/vec/exec/scan/vfile_scanner.h |2 +-
build.sh |4 +-
dist/LICENSE-dist.txt | 65 +-
tools/FlameGraph/README| 13 +
tools/FlameGraph/flamegraph.pl | 1302
tools/FlameGraph/stackcollapse-perf.pl | 435 +++
12 files changed, 1818 insertions(+), 52 deletions(-)
diff --git a/.licenserc.yaml b/.licenserc.yaml
index e458f812bd4..1a35c4a5260 100644
--- a/.licenserc.yaml
+++ b/.licenserc.yaml
@@ -92,4 +92,5 @@ header:
- "pytest/qe"
- "pytest/sys/data"
- "pytest/deploy/*.conf"
+- "tools/FlameGraph/*"
comment: on-failure
diff --git a/LICENSE.txt b/LICENSE.txt
index e28911d07a4..6f9b2963bba 100644
--- a/LICENSE.txt
+++ b/LICENSE.txt
@@ -725,4 +725,12 @@ Apache 2.0, Copyright 2023 SAP SE or an SAP affiliate
company, Johannes Bechberg
This project is maintained by the SapMachine team at SAP SE
---
\ No newline at end of file
+--
+
+be/tools/FlameGraph/*.pl: COMMON DEVELOPMENT AND DISTRIBUTION LICENSE Version
1.0
+
+Unless otherwise noted, all files in this distribution are released
+under the Common Development and Distribution License (CDDL).
+Exceptions are noted within the associated source files.
+
+--
diff --git a/be/src/http/action/pprof_actions.cpp
b/be/src/http/action/pprof_actions.cpp
index 1cc5f9cbef2..453616669b6 100644
--- a/be/src/http/action/pprof_actions.cpp
+++ b/be/src/http/action/pprof_actions.cpp
@@ -23,7 +23,10 @@
!defined(THREAD_SANITIZER) && !defined(USE_JEMALLOC)
#include // IWYU pragma: keep
#include // IWYU pragma: keep
-#include // IWYU pragma: keep
+#endif
+#if !defined(__SANITIZE_ADDRESS__) && !defined(ADDRESS_SANITIZER) &&
!defined(LEAK_SANITIZER) && \
+!defined(THREAD_SANITIZER)
+#include // IWYU pragma: keep
#endif
#include
@@ -141,8 +144,7 @@ public:
};
void ProfileAction::handle(HttpRequest* req) {
-#if defined(ADDRESS_SANITIZER) || defined(LEAK_SANITIZER) ||
defined(THREAD_SANITIZER) || \
-defined(USE_JEMALLOC)
+#if defined(ADDRESS_SANITIZER) || defined(LEAK_SANITIZER) ||
defined(THREAD_SANITIZER)
std::string str = "CPU profiling is not available with address sanitizer
or jemalloc builds.";
HttpChannel::send_reply(req, str);
#else
@@ -178,6 +180,7 @@ void ProfileAction::handle(HttpRequest* req) {
prof_file.close();
std::string str = ss.str();
HttpChannel::send_reply(req, str);
+return;
}
// text type. we will return readable content via http response
@@ -193,7 +196,7 @@ void ProfileAction::handle(HttpRequest* req) {
std::string svg_file_content;
std::string flamegraph_install_dir =
std::string(std::getenv("DORIS_HOME")) + "/tools/FlameGraph/";
-Status st = PprofUtils::generate_flamegraph(30,
flamegraph_install_dir, false,
+Status st = PprofUtils::generate_flamegraph(seconds,
flamegraph_install_dir, false,
&svg_file_content);
if (!st.ok()) {
HttpChannel::send_reply(req, st.to_string());
diff --git a/be/src/http/default_path_handlers.cpp
b/be/src/http/default_path_handlers.cpp
index abc34a2d874..ded72d9f28f 100644
--- a/be/src/http/default_path_handlers.cpp
+++ b/be/src/http/default_path_handlers.cpp
@@ -283,8 +283,7 @@ void heap_handler(const WebPageHandler::ArgumentMap& args,
std::stringstream* ou
void cpu_handler(const WebPageHandler::ArgumentMap& args, std::stringstream*
output) {
(*output) << "CPU Profile" << std::endl;
-#if defined(ADDRESS_SANITIZER) || defined(LEAK_SANITIZER) ||
defined(THREAD_SANITIZER) || \
-defined(USE_JEMALLOC)
+#if defined(ADDRESS_SANITIZER) || defined(LEAK_SANITIZER) ||
defined(THREAD_SANITIZER)
(*output) << ""
Re: [PR] [refactor]Delete useless code check_set_nullable() [doris]
zhiqiang- commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1801019820
##
be/src/vec/functions/array/function_array_range.cpp:
##
@@ -146,14 +144,6 @@ struct RangeImplUtil {
for (int i = 0; i < 3; ++i) {
argument_columns[i] =
block.get_by_position(arguments[i]).column->convert_to_full_column_if_const();
-if (auto* nullable =
check_and_get_column(*argument_columns[i])) {
-// Danger: Here must dispose the null map data first! Because
-// argument_columns[i]=nullable->get_nested_column_ptr(); will
release the mem
-// of column nullable mem of null map
-VectorizedUtils::update_null_map(args_null_map->get_data(),
Review Comment:
`arg_null_map` was updated in this line, and was used be code after this
line, then you removed this logic. Why does this function still work?
##
be/src/vec/functions/array/function_array_enumerate.cpp:
##
@@ -56,7 +56,6 @@ class FunctionArrayEnumerate : public IFunction {
static constexpr auto name = "array_enumerate";
static FunctionPtr create() { return
std::make_shared(); }
String get_name() const override { return name; }
-bool use_default_implementation_for_nulls() const override { return true; }
Review Comment:
do not modify code like this if this pr just wants to do refactor on
`check_set_nullable`
##
be/src/vec/functions/array/function_array_contains_all.cpp:
##
@@ -37,8 +37,6 @@ class FunctionArrayContainsAll : public IFunction {
String get_name() const override { return name; }
-bool use_default_implementation_for_nulls() const override { return true; }
Review Comment:
do not modify code like this if this pr just wants to do refactor on
`check_set_nullable`
##
be/src/vec/functions/function_bitmap.cpp:
##
@@ -349,8 +349,6 @@ class FunctionBitmapAlwaysNull : public IFunction {
size_t get_number_of_arguments() const override { return 1; }
-bool use_default_implementation_for_nulls() const override { return true; }
Review Comment:
keep this, just focus on `check_set_nullable`
##
be/src/vec/functions/function_bitmap.cpp:
##
@@ -1168,10 +1164,6 @@ class FunctionBitmapSubs : public IFunction {
default_preprocess_parameter_columns(argument_columns, col_const, {1,
2}, block, arguments);
-for (int i = 0; i < 3; i++) {
Review Comment:
same problem with `RangeImplUtil`, it seems you remove some update logic to
`res_null_map`, but actually `res_null_map` is still being used in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](cpu-profile) enable cpu profile in BE webui (#40330) [doris]
morningman merged PR #41849: URL: https://github.com/apache/doris/pull/41849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feat](nereids) add max/min filter push down rewrite rule (#39252) [doris]
doris-robot commented on PR #41907: URL: https://github.com/apache/doris/pull/41907#issuecomment-2413685481 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feat](nereids) add max/min filter push down rewrite rule (#39252) [doris]
feiniaofeiafei commented on PR #41907: URL: https://github.com/apache/doris/pull/41907#issuecomment-2413685822 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](compatibility) add percentile_array to restrict_function [doris]
github-actions[bot] commented on PR #41895: URL: https://github.com/apache/doris/pull/41895#issuecomment-2413699171 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-3.0 updated: [bugfix](iceberg)add prefix for endpoint with s3 client for 3.0 (#41336) (#41879)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new c6b7dfc2d14 [bugfix](iceberg)add prefix for endpoint with s3 client
for 3.0 (#41336) (#41879)
c6b7dfc2d14 is described below
commit c6b7dfc2d14ec009eb81241516790f671bd695c5
Author: wuwenchi
AuthorDate: Tue Oct 15 19:59:32 2024 +0800
[bugfix](iceberg)add prefix for endpoint with s3 client for 3.0 (#41336)
(#41879)
bp: #41336
---
.../doris/datasource/iceberg/dlf/DLFCatalog.java | 3 ++
.../iceberg/test_iceberg_dlf_catalog.out | 5 +++
.../iceberg/test_iceberg_dlf_catalog.groovy| 51 ++
3 files changed, 59 insertions(+)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/dlf/DLFCatalog.java
b/fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/dlf/DLFCatalog.java
index e9c406715c1..b9ffc006c61 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/dlf/DLFCatalog.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/dlf/DLFCatalog.java
@@ -67,6 +67,9 @@ public class DLFCatalog extends HiveCompatibleCatalog {
.equalsIgnoreCase("true");
// s3 file io just supports s3-like endpoint
String s3Endpoint = endpoint.replace(region, "s3." + region);
+if (!s3Endpoint.contains("://")) {
+s3Endpoint = "http://"; + s3Endpoint;
+}
URI endpointUri = URI.create(s3Endpoint);
FileIO io = new S3FileIO(() -> S3Util.buildS3Client(endpointUri,
region, credential, isUsePathStyle));
io.initialize(properties);
diff --git
a/regression-test/data/external_table_p2/iceberg/test_iceberg_dlf_catalog.out
b/regression-test/data/external_table_p2/iceberg/test_iceberg_dlf_catalog.out
new file mode 100644
index 000..34f57b2e86e
--- /dev/null
+++
b/regression-test/data/external_table_p2/iceberg/test_iceberg_dlf_catalog.out
@@ -0,0 +1,5 @@
+-- This file is automatically generated. You should know what you did if you
want to edit this
+-- !c1 --
+1 a
+2 b
+
diff --git
a/regression-test/suites/external_table_p2/iceberg/test_iceberg_dlf_catalog.groovy
b/regression-test/suites/external_table_p2/iceberg/test_iceberg_dlf_catalog.groovy
new file mode 100644
index 000..ac04b0e1bb4
--- /dev/null
+++
b/regression-test/suites/external_table_p2/iceberg/test_iceberg_dlf_catalog.groovy
@@ -0,0 +1,51 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_iceberg_dlf_catalog",
"p2,external,iceberg,external_remote,external_remote_iceberg") {
+String enabled = context.config.otherConfigs.get("enableIcebergTest")
+if (enabled == null || !enabled.equalsIgnoreCase("true")) {
+return
+}
+
+String catalog = "test_iceberg_dlf_catalog"
+String uid = context.config.otherConfigs.get("dlf_uid")
+String region = context.config.otherConfigs.get("dlf_region")
+String catalog_id = context.config.otherConfigs.get("dlf_catalog_id")
+String access_key = context.config.otherConfigs.get("dlf_access_key")
+String secret_key = context.config.otherConfigs.get("dlf_secret_key")
+
+
+sql """drop catalog if exists ${catalog};"""
+sql """
+create catalog if not exists ${catalog} properties (
+"type" = "iceberg",
+"iceberg.catalog.type" = "dlf",
+"warehouse" = "oss://selectdb-qa-datalake-test/p2_regression_case",
+"dlf.proxy.mode" = "DLF_ONLY",
+"dlf.uid" = "${uid}",
+"dlf.region" = "${region}",
+"dlf.catalog.id" = "${catalog_id}",
+"dlf.access_key" = "${access_key}",
+"dlf.secret_key" = "${secret_key}"
+);
+"""
+
+sql """ use ${catalog}.regression_iceberg """
+
+qt_c1 """ select * from tb_simple order by id """
+
+}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: [bugfix](iceberg)add prefix for endpoint with s3 client for 2.1 (#41336) (#41877)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new a4b7d93ded8 [bugfix](iceberg)add prefix for endpoint with s3 client
for 2.1 (#41336) (#41877)
a4b7d93ded8 is described below
commit a4b7d93ded843ebf9a24e03416ab643f3ece8304
Author: wuwenchi
AuthorDate: Tue Oct 15 19:59:10 2024 +0800
[bugfix](iceberg)add prefix for endpoint with s3 client for 2.1 (#41336)
(#41877)
bp: #41336
---
.../doris/datasource/iceberg/dlf/DLFCatalog.java | 3 ++
.../iceberg/test_iceberg_dlf_catalog.out | 5 +++
.../iceberg/test_iceberg_dlf_catalog.groovy| 51 ++
3 files changed, 59 insertions(+)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/dlf/DLFCatalog.java
b/fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/dlf/DLFCatalog.java
index e9c406715c1..b9ffc006c61 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/dlf/DLFCatalog.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/dlf/DLFCatalog.java
@@ -67,6 +67,9 @@ public class DLFCatalog extends HiveCompatibleCatalog {
.equalsIgnoreCase("true");
// s3 file io just supports s3-like endpoint
String s3Endpoint = endpoint.replace(region, "s3." + region);
+if (!s3Endpoint.contains("://")) {
+s3Endpoint = "http://"; + s3Endpoint;
+}
URI endpointUri = URI.create(s3Endpoint);
FileIO io = new S3FileIO(() -> S3Util.buildS3Client(endpointUri,
region, credential, isUsePathStyle));
io.initialize(properties);
diff --git
a/regression-test/data/external_table_p2/iceberg/test_iceberg_dlf_catalog.out
b/regression-test/data/external_table_p2/iceberg/test_iceberg_dlf_catalog.out
new file mode 100644
index 000..34f57b2e86e
--- /dev/null
+++
b/regression-test/data/external_table_p2/iceberg/test_iceberg_dlf_catalog.out
@@ -0,0 +1,5 @@
+-- This file is automatically generated. You should know what you did if you
want to edit this
+-- !c1 --
+1 a
+2 b
+
diff --git
a/regression-test/suites/external_table_p2/iceberg/test_iceberg_dlf_catalog.groovy
b/regression-test/suites/external_table_p2/iceberg/test_iceberg_dlf_catalog.groovy
new file mode 100644
index 000..ac04b0e1bb4
--- /dev/null
+++
b/regression-test/suites/external_table_p2/iceberg/test_iceberg_dlf_catalog.groovy
@@ -0,0 +1,51 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_iceberg_dlf_catalog",
"p2,external,iceberg,external_remote,external_remote_iceberg") {
+String enabled = context.config.otherConfigs.get("enableIcebergTest")
+if (enabled == null || !enabled.equalsIgnoreCase("true")) {
+return
+}
+
+String catalog = "test_iceberg_dlf_catalog"
+String uid = context.config.otherConfigs.get("dlf_uid")
+String region = context.config.otherConfigs.get("dlf_region")
+String catalog_id = context.config.otherConfigs.get("dlf_catalog_id")
+String access_key = context.config.otherConfigs.get("dlf_access_key")
+String secret_key = context.config.otherConfigs.get("dlf_secret_key")
+
+
+sql """drop catalog if exists ${catalog};"""
+sql """
+create catalog if not exists ${catalog} properties (
+"type" = "iceberg",
+"iceberg.catalog.type" = "dlf",
+"warehouse" = "oss://selectdb-qa-datalake-test/p2_regression_case",
+"dlf.proxy.mode" = "DLF_ONLY",
+"dlf.uid" = "${uid}",
+"dlf.region" = "${region}",
+"dlf.catalog.id" = "${catalog_id}",
+"dlf.access_key" = "${access_key}",
+"dlf.secret_key" = "${secret_key}"
+);
+"""
+
+sql """ use ${catalog}.regression_iceberg """
+
+qt_c1 """ select * from tb_simple order by id """
+
+}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bugfix](iceberg)add prefix for endpoint with s3 client for 3.0 (#41336) [doris]
morningman merged PR #41879: URL: https://github.com/apache/doris/pull/41879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bugfix](iceberg)add prefix for endpoint with s3 client for 2.1 (#41336) [doris]
morningman merged PR #41877: URL: https://github.com/apache/doris/pull/41877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (827fa1e6018 -> 743151dae3d)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 827fa1e6018 [Chore](compatibility) add percentile_array to restrict_function (#41895) add 743151dae3d [fix](OrcReader) fix the issue that orc_reader can not read DECIMAL(0,0) type of orc file (#41795) No new revisions were added by this update. Summary of changes: be/src/vec/exec/format/orc/vorc_reader.cpp | 9 + be/src/vec/exec/format/orc/vorc_reader.h | 1 - .../tvf/orc_tvf/test_hdfs_orc_group1_orc_files.out | 7 +++ .../tvf/orc_tvf/test_hdfs_orc_group2_orc_files.out | 12 .../tvf/orc_tvf/test_hdfs_orc_group1_orc_files.groovy| 10 +- .../tvf/orc_tvf/test_hdfs_orc_group2_orc_files.groovy| 6 ++ 6 files changed, 39 insertions(+), 6 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](OrcReader) fix the issue that orc_reader can not read DECIMAL(0,0) type of orc file [doris]
morningman merged PR #41795: URL: https://github.com/apache/doris/pull/41795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pick](branch-2.1) pick #41676 #41740 #41857 [doris]
Gabriel39 commented on PR #41904: URL: https://github.com/apache/doris/pull/41904#issuecomment-2413719394 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](flexible partial update) Fix incorrect result when there are insert after delete for same key in one load [doris]
github-actions[bot] commented on code in PR #41701:
URL: https://github.com/apache/doris/pull/41701#discussion_r1801015444
##
be/src/olap/memtable.cpp:
##
@@ -578,6 +546,200 @@ void MemTable::_aggregate() {
}
}
+template
+void MemTable::_aggregate_for_flexible_partial_update_without_seq_col(
+const vectorized::ColumnsWithTypeAndName& block_data,
+vectorized::MutableBlock& mutable_block, std::vector&
temp_row_in_blocks) {
+RowInBlock* prev_row = nullptr;
+int row_pos = -1;
+auto& skip_bitmaps = assert_cast(
+
mutable_block.mutable_columns()[_skip_bitmap_col_idx].get())
+ ->get_data();
+auto& delete_signs = assert_cast(
+
mutable_block.mutable_columns()[_delete_sign_col_idx].get())
+ ->get_data();
+RowInBlock* row_with_delete_sign {nullptr};
+RowInBlock* row_without_delete_sign {nullptr};
+
+auto finalize_rows = [&]() {
+if (row_with_delete_sign != nullptr) {
+temp_row_in_blocks.push_back(row_with_delete_sign);
+_finalize_one_row(row_with_delete_sign,
block_data, ++row_pos);
+row_with_delete_sign = nullptr;
+}
+if (row_without_delete_sign != nullptr) {
+temp_row_in_blocks.push_back(row_without_delete_sign);
+_finalize_one_row(row_without_delete_sign,
block_data, ++row_pos);
+row_without_delete_sign = nullptr;
+}
+_arena->clear();
+};
+
+auto add_row = [&](RowInBlock* row, bool with_delete_sign) {
+if (with_delete_sign) {
+row_with_delete_sign = row;
+} else {
+row_without_delete_sign = row;
+}
+};
+for (RowInBlock* cur_row : _row_in_blocks) {
+const BitmapValue& skip_bitmap = skip_bitmaps[cur_row->_row_pos];
+bool cur_row_has_delete_sign =
(!skip_bitmap.contains(_delete_sign_col_unique_id) &&
+delete_signs[cur_row->_row_pos] != 0);
+prev_row =
+(row_with_delete_sign == nullptr) ? row_without_delete_sign :
row_with_delete_sign;
+// compare keys, the keys of row_with_delete_sign and
row_without_delete_sign is the same,
+// choose any of them if it's valid
+if (prev_row != nullptr && (*_vec_row_comparator)(prev_row, cur_row)
== 0) {
+if (cur_row_has_delete_sign) {
+if (row_without_delete_sign != nullptr) {
+// if there exits row without delete sign, remove it first
+_clear_row_agg(row_without_delete_sign);
+_stat.merged_rows++;
+row_without_delete_sign = nullptr;
+}
+// and then unconditionally replace the previous row
+prev_row = row_with_delete_sign;
+} else {
+prev_row = row_without_delete_sign;
+}
+
+if (prev_row == nullptr) {
+add_row(cur_row, cur_row_has_delete_sign);
+} else {
+if (!prev_row->has_init_agg()) {
+_init_row_for_agg(prev_row, mutable_block);
+}
+_stat.merged_rows++;
+_aggregate_two_row_in_block(mutable_block, cur_row,
prev_row);
+}
+} else {
+finalize_rows();
+add_row(cur_row, cur_row_has_delete_sign);
+}
+}
+// finalize the last lows
+finalize_rows();
+}
+
+template
+void MemTable::_aggregate_for_flexible_partial_update_with_seq_col(
Review Comment:
warning: function '_aggregate_for_flexible_partial_update_with_seq_col'
exceeds recommended size/complexity thresholds [readability-function-size]
```cpp
void MemTable::_aggregate_for_flexible_partial_update_with_seq_col(
^
```
Additional context
**be/src/olap/memtable.cpp:625:** 113 lines including whitespace and
comments (threshold 80)
```cpp
void MemTable::_aggregate_for_flexible_partial_update_with_seq_col(
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](flexible partial update) Fix incorrect result when there are insert after delete for same key in one load [doris]
bobhan1 commented on PR #41701: URL: https://github.com/apache/doris/pull/41701#issuecomment-2413756078 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Metric] add jni metrics for jdbc connection [doris]
github-actions[bot] commented on code in PR #41752:
URL: https://github.com/apache/doris/pull/41752#discussion_r1801089516
##
be/src/util/jni_metrics.cpp:
##
@@ -0,0 +1,136 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "jni_metrics.h"
+
+#include
+
+#include "util/jni-util.h"
+#include "util/metrics.h"
+
+namespace doris {
+
+struct JdbcConnectionMetrics {
+JdbcConnectionMetrics(std::string catalog_id,
std::shared_ptr entity) {
+server_entity = entity;
+metric_jdbc_scan_connection_percent = new
MetricPrototype(MetricType::GAUGE, MetricUnit::PERCENT,
+"jdbc_scan_connection_percent", "", "", {{"catalog", catalog_id}});
+jdbc_scan_connection_percent = static_cast(entity->register_metric(metric_jdbc_scan_connection_percent));
+}
+void update(const int value) const {
jdbc_scan_connection_percent->set_value(value); }
+void deregister_metric() const {
+if (metric_jdbc_scan_connection_percent != nullptr) {
Review Comment:
warning: 'if' statement is unnecessary; deleting null pointer has no effect
[readability-delete-null-pointer]
```suggestion
```
be/src/util/jni_metrics.cpp:38:
```diff
- }
+
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [bugfix](hive)In table properties, add the display of escape characters [doris]
wuwenchi opened a new pull request, #41911: URL: https://github.com/apache/doris/pull/41911 When the hive table attributes contain 'a'='a\1b', 'b'='a\nb', 'c'='a\'b', it will display in `show create table`: before: ``` 'a'='a1b', 'b'='a b', 'c'='a'b', ``` after: ``` 'a'='a\1b', 'b'='a\nb', 'c'='a\'b', ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bugfix](hive)In table properties, add the display of escape characters [doris]
doris-robot commented on PR #41911: URL: https://github.com/apache/doris/pull/41911#issuecomment-2413807017 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](functions) impl scalar functions trim_in、ltrim_in and rtrim_in [doris]
github-actions[bot] commented on PR #41681: URL: https://github.com/apache/doris/pull/41681#issuecomment-2413808986 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](local shuffle) Improve local shuffle strategy [doris]
doris-robot commented on PR #41789: URL: https://github.com/apache/doris/pull/41789#issuecomment-2413813544 TPC-H: Total hot run time: 41306 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 0bda31587f6553d0419f2e4d0006908ea69801ef, data reload: false -- Round 1 -- q1 17578 748973847384 q2 2062164 150 150 q3 10574 114111721141 q4 10217 865 912 865 q5 7725312130703070 q6 241 152 151 151 q7 1003610 614 610 q8 9355194320081943 q9 6638651064216421 q10 7082239624122396 q11 451 246 255 246 q12 417 231 219 219 q13 17788 303530313031 q14 243 211 209 209 q15 586 533 533 533 q16 641 580 570 570 q17 988 525 490 490 q18 7367666968246669 q19 1338925 1026925 q20 481 191 184 184 q21 3959309133343091 q22 1139101410081008 Total cold run time: 107873 ms Total hot run time: 41306 ms - Round 2, with runtime_filter_mode=off - q1 7254725072517250 q2 330 232 230 230 q3 2930280627672767 q4 1969177417491749 q5 5473547855275478 q6 225 142 140 140 q7 2123171316951695 q8 3267341734213417 q9 8613858685998586 q10 3482349734473447 q11 584 481 491 481 q12 797 619 571 571 q13 4785302030303020 q14 301 262 264 262 q15 571 507 506 506 q16 679 640 617 617 q17 1817158515671567 q18 7810747675747476 q19 1676148715201487 q20 2044183118061806 q21 5416518451395139 q22 1120102810071007 Total cold run time: 63266 ms Total hot run time: 58698 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
svn commit: r72338 - /dev/doris/3.0/3.0.2-rc03/ /release/doris/3.0/3.0.2-rc03/
Author: diwu Date: Tue Oct 15 12:47:45 2024 New Revision: 72338 Log: 3.0.2 to release Added: release/doris/3.0/3.0.2-rc03/ - copied from r72337, dev/doris/3.0/3.0.2-rc03/ Removed: dev/doris/3.0/3.0.2-rc03/ - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](functions) impl scalar functions trim_in、ltrim_in and rtrim_in [doris]
github-actions[bot] commented on PR #41681: URL: https://github.com/apache/doris/pull/41681#issuecomment-2413820396 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](dependencies)upgrade some dependencies [doris]
doris-robot commented on PR #41901: URL: https://github.com/apache/doris/pull/41901#issuecomment-2413831325 TPC-H: Total hot run time: 41346 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 5a11c48d6c6cdce37a37ab75a52fcc9bcf8adb16, data reload: false -- Round 1 -- q1 17570 740272787278 q2 2024281 268 268 q3 12161 107612261076 q4 10591 795 868 795 q5 7767308730903087 q6 248 158 157 157 q7 1035625 617 617 q8 9381196819731968 q9 6525643164366431 q10 7121245824632458 q11 445 248 250 248 q12 412 230 225 225 q13 17792 299930202999 q14 241 223 214 214 q15 577 522 520 520 q16 667 597 580 580 q17 986 584 489 489 q18 7298663967776639 q19 13581091952 952 q20 464 185 186 185 q21 3967319931543154 q22 100610061006 Total cold run time: 109741 ms Total hot run time: 41346 ms - Round 2, with runtime_filter_mode=off - q1 7305731272597259 q2 326 230 229 229 q3 3060297329832973 q4 2094178518271785 q5 5755577758095777 q6 239 143 148 143 q7 2279185517851785 q8 3417351734673467 q9 8961885888688858 q10 3579355935743559 q11 600 492 493 492 q12 872 599 629 599 q13 11868 320232133202 q14 307 285 284 284 q15 591 541 521 521 q16 693 640 651 640 q17 1879162416001600 q18 8258784276727672 q19 1742142115971421 q20 2139191219261912 q21 5602554354155415 q22 1113106710681067 Total cold run time: 72679 ms Total hot run time: 60660 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](flexible partial update) Fix incorrect result when there are insert after delete for same key in one load [doris]
doris-robot commented on PR #41701: URL: https://github.com/apache/doris/pull/41701#issuecomment-2413837341 TPC-H: Total hot run time: 41508 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 99e53bd3da17aa9c7e310bf4b8d91beb7a81b396, data reload: false -- Round 1 -- q1 17573 758573387338 q2 2039160 158 158 q3 10565 113712731137 q4 10218 827 856 827 q5 7739310030743074 q6 239 155 154 154 q7 1032632 627 627 q8 9388197219381938 q9 7146642864356428 q10 7107240024092400 q11 457 247 246 246 q12 532 224 236 224 q13 17815 306830323032 q14 240 216 212 212 q15 575 532 522 522 q16 682 586 583 583 q17 990 574 582 574 q18 7459679667056705 q19 1365995 1098995 q20 473 187 194 187 q21 4034314132793141 q22 1121103510061006 Total cold run time: 108789 ms Total hot run time: 41508 ms - Round 2, with runtime_filter_mode=off - q1 7240725672627256 q2 332 225 232 225 q3 2966278228082782 q4 1978170917101709 q5 5506550055075500 q6 225 142 144 142 q7 2137172817321728 q8 3258341134443411 q9 8573855185548551 q10 3480344234513442 q11 571 476 471 471 q12 768 602 588 588 q13 13234 300530383005 q14 295 253 258 253 q15 551 506 498 498 q16 676 646 643 643 q17 1844157615311531 q18 7737739974267399 q19 1670149314511451 q20 2034181318171813 q21 5474534052435243 q22 11311012992 992 Total cold run time: 71680 ms Total hot run time: 58633 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pick](branch-2.1) pick #41676 #41740 #41857 [doris]
doris-robot commented on PR #41904: URL: https://github.com/apache/doris/pull/41904#issuecomment-2413838814 TeamCity be ut coverage result: Function Coverage: 36.03% (9341/25927) Line Coverage: 27.61% (76763/278004) Region Coverage: 26.41% (39427/149264) Branch Coverage: 23.19% (20058/86476) Coverage Report: http://coverage.selectdb-in.cc/coverage/267e4fde60aca529db55b4c22f6d1c7fd56a35f1_267e4fde60aca529db55b4c22f6d1c7fd56a35f1/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Feat](nereids) add max/min filter push down rewrite rule (#39252) [doris]
feiniaofeiafei opened a new pull request, #41907: URL: https://github.com/apache/doris/pull/41907 cherry-pick #39252 to branch-3.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](Nerieds) column prune should retain at least one column for union all (#41613) [doris]
feiniaofeiafei opened a new pull request, #41909: URL: https://github.com/apache/doris/pull/41909 cherry-pick #41613 to branch-3.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nerieds) column prune should retain at least one column for union all (#41613) [doris]
doris-robot commented on PR #41909: URL: https://github.com/apache/doris/pull/41909#issuecomment-2413698301 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nerieds) column prune should retain at least one column for union all (#41613) [doris]
feiniaofeiafei commented on PR #41909: URL: https://github.com/apache/doris/pull/41909#issuecomment-2413698453 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](compatibility) add percentile_array to restrict_function [doris]
BiteThet merged PR #41895: URL: https://github.com/apache/doris/pull/41895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [Chore](compatibility) add percentile_array to restrict_function (#41895)
This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 827fa1e6018 [Chore](compatibility) add percentile_array to
restrict_function (#41895)
827fa1e6018 is described below
commit 827fa1e6018f16da94f6991ca7c97ef1ffb0b979
Author: Pxl
AuthorDate: Tue Oct 15 19:54:54 2024 +0800
[Chore](compatibility) add percentile_array to restrict_function (#41895)
## Proposed changes
1. add percentile_array to restrict_function
2. fix wrong format log like ` Query a91dd45e9f584b70-9ab483bb1bc9d42b
deconstructed, , deregister query/load mem`
---
be/src/runtime/query_context.cpp | 2 +-
be/src/vec/aggregate_functions/aggregate_function_percentile.cpp | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/be/src/runtime/query_context.cpp b/be/src/runtime/query_context.cpp
index c602dc683fe..80f59d7101d 100644
--- a/be/src/runtime/query_context.cpp
+++ b/be/src/runtime/query_context.cpp
@@ -150,7 +150,7 @@ QueryContext::~QueryContext() {
std::string mem_tracker_msg;
if (query_mem_tracker->peak_consumption() != 0) {
mem_tracker_msg = fmt::format(
-", deregister query/load memory tracker, queryId={}, Limit={},
CurrUsed={}, "
+"deregister query/load memory tracker, queryId={}, Limit={},
CurrUsed={}, "
"PeakUsed={}",
print_id(_query_id),
MemCounter::print_bytes(query_mem_tracker->limit()),
MemCounter::print_bytes(query_mem_tracker->consumption()),
diff --git a/be/src/vec/aggregate_functions/aggregate_function_percentile.cpp
b/be/src/vec/aggregate_functions/aggregate_function_percentile.cpp
index 248d808f2cc..8f528e0121d 100644
--- a/be/src/vec/aggregate_functions/aggregate_function_percentile.cpp
+++ b/be/src/vec/aggregate_functions/aggregate_function_percentile.cpp
@@ -75,6 +75,7 @@ void
register_percentile_approx_old_function(AggregateFunctionSimpleFactory& fac
void
register_aggregate_function_percentile_old(AggregateFunctionSimpleFactory&
factory) {
BeExecVersionManager::registe_restrict_function_compatibility("percentile");
+
BeExecVersionManager::registe_restrict_function_compatibility("percentile_array");
}
void
register_aggregate_function_percentile_approx(AggregateFunctionSimpleFactory&
factory) {
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pick](branch-2.1) pick #41676 #41740 #41857 [doris]
Gabriel39 commented on PR #41904: URL: https://github.com/apache/doris/pull/41904#issuecomment-2413752278 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor]Delete useless code check_set_nullable() [doris]
Yoruet commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1801075968
##
be/src/vec/functions/array/function_array_contains_all.cpp:
##
@@ -37,8 +37,6 @@ class FunctionArrayContainsAll : public IFunction {
String get_name() const override { return name; }
-bool use_default_implementation_for_nulls() const override { return true; }
Review Comment:
the default value of this function is true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Metric] add jni metrics for jdbc connection [doris]
github-actions[bot] commented on code in PR #41752:
URL: https://github.com/apache/doris/pull/41752#discussion_r1801077417
##
be/src/util/jni_metrics.cpp:
##
@@ -0,0 +1,136 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "jni_metrics.h"
+
+#include
+
+#include "util/jni-util.h"
+#include "util/metrics.h"
+
+namespace doris {
+
+struct JdbcConnectionMetrics {
+JdbcConnectionMetrics(std::string catalog_id,
std::shared_ptr entity) {
+server_entity = entity;
+metric_jdbc_scan_connection_percent = new
MetricPrototype(MetricType::GAUGE, MetricUnit::PERCENT,
+"jdbc_scan_connection_percent", "", "", {{"catalog", catalog_id}});
+jdbc_scan_connection_percent = static_cast(entity->register_metric(metric_jdbc_scan_connection_percent));
+}
+void update(const int value) const {
jdbc_scan_connection_percent->set_value(value); }
+void deregister_metric() const {
+if (metric_jdbc_scan_connection_percent != nullptr) {
+
server_entity->deregister_metric(metric_jdbc_scan_connection_percent);
+delete metric_jdbc_scan_connection_percent;
+}
+}
+std::shared_ptr server_entity;
+MetricPrototype* metric_jdbc_scan_connection_percent;
+IntGauge* jdbc_scan_connection_percent;
+};
+
+const char* JniMetrics::_s_hook_name = "jni_metrics";
+
+JniMetrics::JniMetrics(MetricRegistry* registry) {
+DCHECK(registry != nullptr);
+_registry = registry;
+_server_entity = _registry->register_entity("server");
+DCHECK(_server_entity != nullptr);
+_server_entity->register_hook(_s_hook_name,
+
std::bind(&JniMetrics::update_jdbc_connection_metrics, this));
+_init();
+}
+
+void JniMetrics::_init() {
+JNIEnv* env = nullptr;
+Status st = JniUtil::GetJNIEnv(&env);
+if (!st.ok()) {
+LOG(WARNING) << "get jni env failed. " << st.to_string();
+return;
+}
+st = JniUtil::get_jni_scanner_class(env,
"org/apache/doris/jdbc/JdbcDataSource",
+&_jdbc_data_source_clz);
+if (!st.ok()) {
+LOG(WARNING) << "class org/apachhe/doris/jdbc/JdbcDataSource not find
in jvm."
+ << st.to_string();
+return;
+}
+_get_connection_percent_id = env->GetStaticMethodID(
+_jdbc_data_source_clz, "getConnectionPercent",
"()Ljava/util/Map;");
+st = JniUtil::GetJniExceptionMsg(env);
+if (!st.ok()) {
+LOG(WARNING) << "get getConnectionPercent method id failed. " <<
st.to_string();
+return;
+}
+_is_init = true;
+LOG(INFO) << "jni metrics inited successfully";
+}
+
Review Comment:
warning: method 'update_jdbc_connection_metrics' can be made const
[readability-make-member-function-const]
```suggestion
void JniMetrics::update_jdbc_connection_metrics() const {
```
be/src/util/jni_metrics.h:32:
```diff
- void update_jdbc_connection_metrics();
+ void update_jdbc_connection_metrics() const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](flexible partial update) Fix incorrect result when there are insert after delete for same key in one load [doris]
doris-robot commented on PR #41701: URL: https://github.com/apache/doris/pull/41701#issuecomment-2413850972 TeamCity be ut coverage result: Function Coverage: 37.44% (9708/25932) Line Coverage: 28.67% (80600/281102) Region Coverage: 28.14% (41703/148204) Branch Coverage: 24.71% (21206/85822) Coverage Report: http://coverage.selectdb-in.cc/coverage/99e53bd3da17aa9c7e310bf4b8d91beb7a81b396_99e53bd3da17aa9c7e310bf4b8d91beb7a81b396/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pick](branch-2.1) pick #40667 #40714 [doris]
doris-robot commented on PR #41905: URL: https://github.com/apache/doris/pull/41905#issuecomment-2413855112 TeamCity be ut coverage result: Function Coverage: 36.03% (9343/25928) Line Coverage: 27.62% (76766/277983) Region Coverage: 26.42% (39430/149258) Branch Coverage: 23.20% (20060/86474) Coverage Report: http://coverage.selectdb-in.cc/coverage/3f1ab0b7ff501df98b2248e6e6e5b00317c83c15_3f1ab0b7ff501df98b2248e6e6e5b00317c83c15/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](dependencies)upgrade some dependencies [doris]
doris-robot commented on PR #41901: URL: https://github.com/apache/doris/pull/41901#issuecomment-2413859987 TPC-DS: Total hot run time: 191972 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 5a11c48d6c6cdce37a37ab75a52fcc9bcf8adb16, data reload: false query1 921 405 405 405 query2 6245214720402040 query3 8681198 209 198 query4 34196 23676 23616 23616 query5 3488487 469 469 query6 275 175 174 174 query7 4200296 292 292 query8 308 256 240 240 query9 9368276727532753 query10 446 274 267 267 query11 17880 15275 15339 15275 query12 150 108 102 102 query13 1564425 424 424 query14 9342747875147478 query15 271 173 179 173 query16 8067475 494 475 query17 1728606 619 606 query18 2159312 318 312 query19 380 158 159 158 query20 127 115 116 115 query21 213 111 113 111 query22 4890463444054405 query23 35099 33994 34244 33994 query24 10892 276627282728 query25 634 414 407 407 query26 1177159 166 159 query27 2273287 291 287 query28 7106245824202420 query29 848 429 425 425 query30 260 155 158 155 query31 1074805 815 805 query32 108 54 56 54 query33 779 297 299 297 query34 942 509 505 505 query35 905 754 764 754 query36 1122934 945 934 query37 158 91 93 91 query38 4043385239193852 query39 1491142614051405 query40 215 100 101 100 query41 49 47 47 47 query42 129 101 104 101 query43 525 499 489 489 query44 1290817 829 817 query45 197 168 167 167 query46 1147715 709 709 query47 1951181918241819 query48 450 324 326 324 query49 928 456 428 428 query50 827 394 393 393 query51 7033689569776895 query52 102 85 88 85 query53 257 176 174 174 query54 1181416 423 416 query55 80 75 77 75 query56 269 256 246 246 query57 1309114711091109 query58 234 232 233 232 query59 3347297529992975 query60 298 266 251 251 query61 103 103 106 103 query62 864 664 685 664 query63 228 187 178 178 query64 3862652 596 596 query65 3280318032183180 query66 837 297 303 297 query67 15959 15684 15477 15477 query68 4371565 557 557 query69 527 281 290 281 query70 1130110211131102 query71 387 269 266 266 query72 7610405839823982 query73 799 356 362 356 query74 10156 898989948989 query75 3464265427332654 query76 3291931 896 896 query77 611 305 299 299 query78 10878 977895929592 query79 1730584 606 584 query80 1300435 442 435 query81 579 248 244 244 query82 700 137 142 137 query83 296 136 137 136 query84 279 72 71 71 query85 1036300 283 283 query86 452 299 287 287 query87 4397437943314331 query88 2877224721872187 query89 410 296 285 285 query90 2082189 189 189 query91 136 102 100 100 query92 65 50 49 49 query93 1658531 535 531 query94 1152294 282 282 query95 353 247 244 244 query96 621 279 279 279 query97 3292314431313131 query98 235 201 198 198 query99 1614130813101308 Total cold run time: 299249 ms Total hot run time: 191972 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Fix](flexible partial update) Fix incorrect result when there are insert after delete for same key in one load [doris]
doris-robot commented on PR #41701: URL: https://github.com/apache/doris/pull/41701#issuecomment-2413865348 TPC-DS: Total hot run time: 192082 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 99e53bd3da17aa9c7e310bf4b8d91beb7a81b396, data reload: false query1 951 386 393 386 query2 5062210820922092 query3 4406214 220 214 query4 32856 23494 23619 23494 query5 3843483 468 468 query6 240 175 169 169 query7 3831299 294 294 query8 286 240 234 234 query9 8374278127432743 query10 441 286 274 274 query11 17693 15260 15298 15260 query12 153 99 102 99 query13 1488445 413 413 query14 10108 767974997499 query15 292 166 172 166 query16 6715447 436 436 query17 1528557 561 557 query18 1838299 299 299 query19 314 151 145 145 query20 122 107 106 106 query21 213 104 102 102 query22 4634439242664266 query23 34799 34155 34033 34033 query24 9899279928352799 query25 667 409 403 403 query26 1388164 159 159 query27 2435285 282 282 query28 6846243224532432 query29 912 435 426 426 query30 327 169 154 154 query31 1056793 834 793 query32 98 64 63 63 query33 721 297 283 283 query34 940 526 511 511 query35 929 766 803 766 query36 1112936 950 936 query37 149 98 87 87 query38 4120387439003874 query39 1457144414281428 query40 286 101 100 100 query41 49 48 44 44 query42 123 103 100 100 query43 541 493 507 493 query44 1210814 821 814 query45 195 166 164 164 query46 1139702 702 702 query47 1933181318511813 query48 433 320 320 320 query49 1205417 424 417 query50 816 384 407 384 query51 7030702869836983 query52 99 94 88 88 query53 255 180 183 180 query54 917 425 433 425 query55 81 80 75 75 query56 279 268 259 259 query57 1304117011451145 query58 237 230 233 230 query59 3290312731083108 query60 282 266 261 261 query61 110 106 106 106 query62 882 689 696 689 query63 224 181 187 181 query64 4629648 599 599 query65 3288319832063198 query66 1335304 301 301 query67 15810 15580 15522 15522 query68 4019569 558 558 query69 565 275 307 275 query70 1176113411701134 query71 362 272 276 272 query72 7090397739363936 query73 776 356 359 356 query74 9832898289728972 query75 3404271027022702 query76 2938894 969 894 query77 417 288 306 288 query78 10418 964496169616 query79 3478609 595 595 query80 1850447 452 447 query81 590 241 241 241 query82 394 139 145 139 query83 267 137 133 133 query84 266 72 70 70 query85 1146302 281 281 query86 393 305 300 300 query87 4461432642374237 query88 3885220021782178 query89 403 321 285 285 query90 1920185 185 185 query91 145 99 100 99 query92 66 48 48 48 query93 1720558 559 558 query94 872 294 292 292 query95 337 243 241 241 query96 620 277 276 276 query97 3291312731373127 query98 220 198 200 198 query99 1507130513031303 Total cold run time: 290053 ms Total hot run time: 192082 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] [download](3.0 release) Update 3.0.2 1015 [doris-website]
gavinchou merged PR #1201: URL: https://github.com/apache/doris-website/pull/1201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bugfix](hive)In table properties, add the display of escape characters [doris]
wuwenchi commented on PR #41911: URL: https://github.com/apache/doris/pull/41911#issuecomment-2413869081 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](dependencies)upgrade some dependencies [doris]
doris-robot commented on PR #41901: URL: https://github.com/apache/doris/pull/41901#issuecomment-2413872747 ClickBench: Total hot run time: 32.37 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 5a11c48d6c6cdce37a37ab75a52fcc9bcf8adb16, data reload: false query1 0.040.030.03 query2 0.060.030.03 query3 0.230.060.06 query4 1.650.100.10 query5 0.510.500.51 query6 1.130.730.72 query7 0.010.010.01 query8 0.030.030.03 query9 0.570.500.50 query10 0.550.560.55 query11 0.140.110.10 query12 0.140.120.11 query13 0.610.600.59 query14 2.802.742.74 query15 0.900.830.82 query16 0.380.390.39 query17 1.001.001.05 query18 0.200.200.20 query19 1.931.781.99 query20 0.010.010.01 query21 15.36 0.600.60 query22 2.732.031.60 query23 17.09 1.230.82 query24 3.231.000.92 query25 0.330.090.21 query26 0.370.130.13 query27 0.040.060.04 query28 10.72 1.101.08 query29 12.54 3.233.24 query30 0.240.060.06 query31 2.880.370.37 query32 3.290.480.45 query33 3.002.973.02 query34 16.85 4.494.51 query35 4.524.464.47 query36 0.680.500.50 query37 0.080.060.06 query38 0.050.030.03 query39 0.030.020.02 query40 0.160.120.11 query41 0.080.020.02 query42 0.030.020.02 query43 0.030.030.03 Total cold run time: 107.22 s Total hot run time: 32.37 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](functions) impl scalar functions trim_in、ltrim_in and rtrim_in [doris]
liujiwen-up commented on code in PR #41681:
URL: https://github.com/apache/doris/pull/41681#discussion_r1801173448
##
be/src/vec/functions/function_string.cpp:
##
@@ -535,6 +545,135 @@ struct TrimUtil {
return Status::OK();
}
};
+template
+struct TrimInUtil {
+static Status vector(const ColumnString::Chars& str_data,
+ const ColumnString::Offsets& str_offsets, const
StringRef& remove_str,
+ ColumnString::Chars& res_data, ColumnString::Offsets&
res_offsets) {
+const size_t offset_size = str_offsets.size();
+res_offsets.resize(offset_size);
+res_data.reserve(str_data.size());
+bool all_ascii = simd::VStringFunctions::is_ascii(remove_str) &&
+ simd::VStringFunctions::is_ascii(StringRef(
+ reinterpret_cast(str_data.data()), str_data.size()));
+
+if (all_ascii) {
+return impl_vectors_ascii(str_data, str_offsets, remove_str,
res_data, res_offsets);
+} else {
+return impl_vectors_utf8(str_data, str_offsets, remove_str,
res_data, res_offsets);
+}
+}
+
+private:
+static Status impl_vectors_ascii(const ColumnString::Chars& str_data,
+ const ColumnString::Offsets& str_offsets,
+ const StringRef& remove_str,
ColumnString::Chars& res_data,
+ ColumnString::Offsets& res_offsets) {
+const size_t offset_size = str_offsets.size();
+std::bitset<128> char_lookup;
+const char* remove_begin = remove_str.data;
+const char* remove_end = remove_str.data + remove_str.size;
+
+while (remove_begin < remove_end) {
+char_lookup.set(static_cast(*remove_begin));
+remove_begin += 1;
+}
+
+for (size_t i = 0; i < offset_size; ++i) {
+const char* str_begin = reinterpret_cast(
+str_data.data() + (i == 0 ? 0 : str_offsets[i - 1]));
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](functions) impl scalar functions trim_in、ltrim_in and rtrim_in [doris]
liujiwen-up commented on code in PR #41681:
URL: https://github.com/apache/doris/pull/41681#discussion_r1801174551
##
be/src/vec/functions/function_string.cpp:
##
@@ -535,6 +545,135 @@ struct TrimUtil {
return Status::OK();
}
};
+template
+struct TrimInUtil {
+static Status vector(const ColumnString::Chars& str_data,
+ const ColumnString::Offsets& str_offsets, const
StringRef& remove_str,
+ ColumnString::Chars& res_data, ColumnString::Offsets&
res_offsets) {
+const size_t offset_size = str_offsets.size();
+res_offsets.resize(offset_size);
+res_data.reserve(str_data.size());
+bool all_ascii = simd::VStringFunctions::is_ascii(remove_str) &&
+ simd::VStringFunctions::is_ascii(StringRef(
+ reinterpret_cast(str_data.data()), str_data.size()));
+
+if (all_ascii) {
+return impl_vectors_ascii(str_data, str_offsets, remove_str,
res_data, res_offsets);
+} else {
+return impl_vectors_utf8(str_data, str_offsets, remove_str,
res_data, res_offsets);
+}
+}
+
+private:
+static Status impl_vectors_ascii(const ColumnString::Chars& str_data,
+ const ColumnString::Offsets& str_offsets,
+ const StringRef& remove_str,
ColumnString::Chars& res_data,
+ ColumnString::Offsets& res_offsets) {
+const size_t offset_size = str_offsets.size();
+std::bitset<128> char_lookup;
+const char* remove_begin = remove_str.data;
+const char* remove_end = remove_str.data + remove_str.size;
+
+while (remove_begin < remove_end) {
+char_lookup.set(static_cast(*remove_begin));
+remove_begin += 1;
+}
+
+for (size_t i = 0; i < offset_size; ++i) {
+const char* str_begin = reinterpret_cast(
+str_data.data() + (i == 0 ? 0 : str_offsets[i - 1]));
+const char* str_end = reinterpret_cast(str_data.data() + str_offsets[i]);
+const char* left_trim_pos = str_begin;
+const char* right_trim_pos = str_end;
+
+if constexpr (is_ltrim_in) {
+while (left_trim_pos < str_end) {
+if (!char_lookup.test(static_cast(*left_trim_pos))) {
+break;
+}
+++left_trim_pos;
+}
+}
+
+if constexpr (is_rtrim_in) {
+while (right_trim_pos > left_trim_pos) {
+--right_trim_pos;
+if (!char_lookup.test(static_cast(*right_trim_pos))) {
+++right_trim_pos;
+break;
+}
+}
+}
+
+res_data.insert_assume_reserved(left_trim_pos, right_trim_pos);
+res_offsets[i] = res_data.size();
+}
+
+return Status::OK();
+}
+
+static Status impl_vectors_utf8(const ColumnString::Chars& str_data,
+const ColumnString::Offsets& str_offsets,
+const StringRef& remove_str,
ColumnString::Chars& res_data,
+ColumnString::Offsets& res_offsets) {
+const size_t offset_size = str_offsets.size();
+res_offsets.resize(offset_size);
+res_data.reserve(str_data.size());
+
+std::unordered_set char_lookup;
Review Comment:
Change to string_view
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bugfix](hive)In table properties, add the display of escape characters [doris]
doris-robot commented on PR #41911: URL: https://github.com/apache/doris/pull/41911#issuecomment-2413930388 TPC-H: Total hot run time: 41108 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit a5a2a4a29012607e2aced877b92c1bacd0489a8e, data reload: false -- Round 1 -- q1 17585 845673377337 q2 2055160 169 160 q3 10565 109111791091 q4 10236 812 868 812 q5 7744302630523026 q6 238 151 149 149 q7 1013616 617 616 q8 9368190919091909 q9 6554640064236400 q10 7069246224432443 q11 447 244 245 244 q12 408 218 226 218 q13 17778 300629802980 q14 255 205 220 205 q15 573 520 506 506 q16 664 582 568 568 q17 963 599 568 568 q18 7437680666786678 q19 1360938 1068938 q20 482 183 184 183 q21 3935307032653070 q22 1122101410071007 Total cold run time: 107851 ms Total hot run time: 41108 ms - Round 2, with runtime_filter_mode=off - q1 7362724772627247 q2 330 235 234 234 q3 2933274028162740 q4 1930168116691669 q5 5408546555645465 q6 221 139 146 139 q7 2115174517451745 q8 3221337933933379 q9 8534855185068506 q10 3462345533853385 q11 598 477 484 477 q12 793 585 567 567 q13 11083 302630153015 q14 285 262 265 262 q15 559 504 509 504 q16 668 618 642 618 q17 1809158815521552 q18 7761739875057398 q19 1669155015371537 q20 2017178418141784 q21 5410516851905168 q22 1120102210031003 Total cold run time: 69288 ms Total hot run time: 58394 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [imporve][load] support set stream-load data size limit by http header [doris]
jqcc opened a new pull request, #41914: URL: https://github.com/apache/doris/pull/41914 ## Proposed changes Doris's stream load limits the amount of data that can be imported at one time. If the amount of data exceeds the limit, it will fail. If you want to increase the limit, you need to manually adjust the BE parameters(`streaming_load_max_mb`). This adjustment adds a check rule for the amount of data during import. If the amount of imported data is set in the HTTP header, the size limit specified in HTTP can be dynamically loaded, avoiding the need to uniformly adjust the limit of the BE layer. just like: ``` bash curl --location-trusted -u : \ -H "data_size_limit:10240" -H "column_separator:," \ -H "columns:user_id,name,age" \ -T streamload_example.csv \ -XPUT http://:/api/testdb/test_streamload/_stream_load ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [imporve][load] support set stream-load data size limit by http header [doris]
doris-robot commented on PR #41914: URL: https://github.com/apache/doris/pull/41914#issuecomment-2413927949 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [imporve][load] support set stream-load data size limit by http header [doris]
github-actions[bot] commented on PR #41914: URL: https://github.com/apache/doris/pull/41914#issuecomment-2413941168 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](parquet) support reading brotli compressed parquet file [doris]
github-actions[bot] commented on PR #41875: URL: https://github.com/apache/doris/pull/41875#issuecomment-2413296471 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](jdbc) fix Unknown command(27) (#41621) [doris]
doris-robot commented on PR #41881: URL: https://github.com/apache/doris/pull/41881#issuecomment-2413298095 TPC-DS: Total hot run time: 188907 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit dc68d68cbb833eb8f92017e2a69c350ae547ef67, data reload: false query1 964 372 356 356 query2 6549204519551955 query3 6696219 228 219 query4 33975 23542 23306 23306 query5 4277461 458 458 query6 278 170 161 161 query7 4620319 310 310 query8 254 209 218 209 query9 9425266026492649 query10 467 284 275 275 query11 17792 15097 15153 15097 query12 158 97 98 97 query13 1666438 444 438 query14 10485 680272906802 query15 234 174 168 168 query16 7450462 494 462 query17 1610575 571 571 query18 1975323 313 313 query19 229 157 151 151 query20 114 104 105 104 query21 204 100 100 100 query22 4454433442604260 query23 34632 33650 33827 33650 query24 12144 279328432793 query25 695 397 415 397 query26 1786162 162 162 query27 2765298 302 298 query28 7782216321242124 query29 993 450 434 434 query30 320 150 149 149 query31 1030765 816 765 query32 98 54 57 54 query33 777 310 292 292 query34 972 503 491 491 query35 890 770 734 734 query36 1102943 925 925 query37 238 77 78 77 query38 3962385438393839 query39 1497140714231407 query40 287 101 100 100 query41 47 43 43 43 query42 118 99 96 96 query43 519 481 481 481 query44 1237775 766 766 query45 199 167 171 167 query46 1141713 741 713 query47 1890186618451845 query48 433 339 335 335 query49 1268393 408 393 query50 829 410 405 405 query51 7121685569866855 query52 102 88 91 88 query53 270 198 189 189 query54 1269478 457 457 query55 76 75 78 75 query56 264 251 256 251 query57 1258121611461146 query58 236 238 228 228 query59 2959308830203020 query60 304 273 259 259 query61 101 101 108 101 query62 842 673 655 655 query63 220 186 183 183 query64 5258606 587 587 query65 3242315731923157 query66 1425305 313 305 query67 15821 15284 15410 15284 query68 4853529 528 528 query69 530 280 286 280 query70 1181114311291129 query71 381 274 283 274 query72 7249385138733851 query73 767 343 345 343 query74 10420 890689508906 query75 3670265826482648 query76 3323963 904 904 query77 478 292 305 292 query78 10076 934293099309 query79 5363575 585 575 query80 1777448 433 433 query81 555 221 233 221 query82 858 135 126 126 query83 278 142 143 142 query84 296 82 83 82 query85 2130301 272 272 query86 438 272 300 272 query87 4413425841614161 query88 4442236623902366 query89 423 290 285 285 query90 1867181 180 180 query91 138 102 102 102 query92 59 45 47 45 query93 5114534 541 534 query94 767 281 269 269 query95 337 248 253 248 query96 630 273 279 273 query97 3300313231453132 query98 224 198 196 196 query99 1677129312981293 Total cold run time: 312309 ms Total hot run time: 188907 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] [enhance](parquet) support reading brotli compressed parquet file [doris]
github-actions[bot] commented on PR #41875: URL: https://github.com/apache/doris/pull/41875#issuecomment-2413302244 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](cases) remove unstable cases [doris]
hello-stephen merged PR #41858: URL: https://github.com/apache/doris/pull/41858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Nereids) ignore match expression logging warning message [doris]
starocean999 merged PR #41546: URL: https://github.com/apache/doris/pull/41546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-3.0 updated: [Fix](cases) remove unstable cases (#41858)
This is an automated email from the ASF dual-hosted git repository.
hellostephen pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new 422f61f8d6e [Fix](cases) remove unstable cases (#41858)
422f61f8d6e is described below
commit 422f61f8d6e250a3bc8320aa3e13ca36395906c3
Author: LiBinfeng <46676950+libinfeng...@users.noreply.github.com>
AuthorDate: Tue Oct 15 17:03:21 2024 +0800
[Fix](cases) remove unstable cases (#41858)
remove unstable cases in multi-leading test
---
.../data/nereids_p0/hint/multi_leading.out | 401 -
.../suites/nereids_p0/hint/multi_leading.groovy| 3 -
2 files changed, 404 deletions(-)
diff --git a/regression-test/data/nereids_p0/hint/multi_leading.out
b/regression-test/data/nereids_p0/hint/multi_leading.out
index be90f0ef094..eac055ef7da 100644
--- a/regression-test/data/nereids_p0/hint/multi_leading.out
+++ b/regression-test/data/nereids_p0/hint/multi_leading.out
@@ -59,404 +59,3 @@
-- !sql4_res_7 --
6224
--- !sql5_2 --
-2
-10
-11
-12
-18
-21
-28
-29
-31
-32
-40
-41
-47
-53
-54
-58
-62
-68
-70
-77
-80
-81
-87
-94
-96
-97
-106
-121
-129
-131
-135
-142
-151
-154
-155
-158
-160
-162
-165
-170
-173
-178
-184
-186
-188
-189
-190
-192
-193
-203
-205
-209
-214
-215
-218
-221
-225
-228
-236
-237
-238
-241
-242
-243
-246
-247
-251
-253
-255
-256
-257
-259
-260
-262
-267
-269
-271
-276
-279
-281
-286
-291
-296
-305
-308
-314
-318
-322
-323
-327
-331
-339
-340
-344
-346
-351
-363
-374
-380
-386
-388
-389
-390
-393
-394
-399
-400
-409
-410
-420
-421
-423
-424
-425
-428
-433
-434
-435
-441
-446
-449
-458
-461
-462
-467
-474
-478
-486
-488
-489
-490
-499
-0
-1
-3
-8
-13
-17
-27
-30
-34
-35
-36
-43
-44
-61
-63
-69
-71
-72
-73
-76
-79
-82
-84
-85
-89
-90
-92
-93
-98
-100
-111
-113
-114
-122
-124
-127
-137
-143
-147
-148
-149
-150
-153
-159
-168
-169
-171
-175
-179
-181
-197
-201
-202
-204
-206
-217
-220
-227
-229
-240
-261
-265
-268
-270
-273
-275
-278
-280
-285
-287
-288
-293
-294
-297
-299
-301
-303
-310
-311
-313
-315
-317
-319
-326
-329
-332
-333
-336
-343
-345
-358
-359
-370
-371
-372
-373
-376
-378
-385
-391
-398
-405
-406
-414
-430
-432
-445
-447
-452
-454
-455
-456
-459
-464
-465
-468
-477
-481
-482
-492
-494
-495
-500
-4
-6
-7
-14
-16
-20
-23
-25
-33
-37
-38
-39
-45
-46
-48
-49
-51
-57
-59
-60
-64
-65
-67
-83
-88
-99
-101
-102
-104
-107
-108
-109
-112
-117
-118
-119
-120
-123
-125
-128
-130
-132
-134
-136
-138
-140
-141
-152
-157
-161
-163
-166
-172
-174
-194
-195
-199
-200
-210
-212
-213
-216
-223
-226
-230
-231
-232
-233
-235
-248
-249
-252
-254
-258
-263
-264
-266
-272
-274
-282
-284
-290
-298
-300
-302
-304
-312
-316
-321
-324
-325
-334
-335
-338
-341
-347
-348
-352
-353
-357
-362
-366
-367
-368
-369
-375
-379
-381
-382
-383
-387
-396
-397
-402
-404
-407
-408
-411
-412
-415
-417
-418
-419
-427
-429
-431
-439
-440
-443
-444
-448
-453
-457
-460
-463
-466
-470
-473
-476
-480
-484
-487
-497
-\N
-
diff --git a/regression-test/suites/nereids_p0/hint/multi_leading.groovy
b/regression-test/suites/nereids_p0/hint/multi_leading.groovy
index fe63db1b636..1f2f41822c7 100644
--- a/regression-test/suites/nereids_p0/hint/multi_leading.groovy
+++ b/regression-test/suites/nereids_p0/hint/multi_leading.groovy
@@ -118,7 +118,4 @@ suite("multi_leading") {
qt_sql4_res_5 """select /*+ leading(t3 alias1) */ count(*) from (select
c1, c11 from t1 join (select /*+ leading(t4 t2) */ c2, c22 from t2 join t4 on
c2 = c4) as alias2 on c1 = alias2.c2) as alias1 join t3 on alias1.c1 = t3.c3;"""
qt_sql4_res_6 """select count(*) from (select /*+ leading(alias2 t1) */
c1, c11 from t1 join (select /*+ leading(t4 t2) */ c2, c22 from t2 join t4 on
c2 = c4) as alias2 on c1 = alias2.c2) as alias1 join t3 on alias1.c1 = t3.c3;"""
qt_sql4_res_7 """select /*+ leading(t3 alias1) */ count(*) from (select
/*+ leading(alias2 t1) */ c1, c11 from t1 join (select /*+ leading(t4 t2) */
c2, c22 from t2 join t4 on c2 = c4) as alias2 on c1 = alias2.c2) as alias1 join
t3 on alias1.c1 = t3.c3;"""
-
-// use cte in scalar query
-qt_sql5_2 """with cte as (select c11, c1 from t1) SELECT c1 FROM cte
group by c1 having sum(cte.c11) > (select /*+ leading(cte t1) */ 0.05 *
avg(t1.c11) from t1 join cte on t1.c1 = cte.c11 )"""
}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [Fix](Nereids) ignore match expression logging warning message (#41546)
This is an automated email from the ASF dual-hosted git repository.
starocean999 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 0153d48d1cc [Fix](Nereids) ignore match expression logging warning
message (#41546)
0153d48d1cc is described below
commit 0153d48d1cc180520e728e1ba39796b620be45f4
Author: LiBinfeng <46676950+libinfeng...@users.noreply.github.com>
AuthorDate: Tue Oct 15 17:04:24 2024 +0800
[Fix](Nereids) ignore match expression logging warning message (#41546)
when match do not contains slot reference it would throw an exception
when translate to original planner expr.
this kind of message is not need to be recorded
---
.../rules/expression/rules/FoldConstantRuleOnBE.java | 7 +--
.../nereids/glue/translator/ExpressionTranslatorTest.java | 14 --
2 files changed, 13 insertions(+), 8 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/FoldConstantRuleOnBE.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/FoldConstantRuleOnBE.java
index 810d281ac57..fc6112834a0 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/FoldConstantRuleOnBE.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/FoldConstantRuleOnBE.java
@@ -192,7 +192,7 @@ public class FoldConstantRuleOnBE implements
ExpressionPatternRuleFactory {
private static void collectConst(Expression expr, Map
constMap,
Map tExprMap, IdGenerator idGenerator) {
-if (expr.isConstant() && !shouldSkipFold(expr)) {
+if (expr.isConstant() && !expr.isLiteral() && !expr.anyMatch(e ->
shouldSkipFold((Expression) e))) {
String id = idGenerator.getNextId().toString();
constMap.put(id, expr);
Expr staleExpr;
@@ -218,11 +218,6 @@ public class FoldConstantRuleOnBE implements
ExpressionPatternRuleFactory {
// Some expressions should not do constant folding
private static boolean shouldSkipFold(Expression expr) {
-// Skip literal expr
-if (expr.isLiteral()) {
-return true;
-}
-
// Frontend can not represent those types
if (expr.getDataType().isAggStateType() ||
expr.getDataType().isObjectType()
|| expr.getDataType().isVariantType() ||
expr.getDataType().isTimeLikeType()
diff --git
a/fe/fe-core/src/test/java/org/apache/doris/nereids/glue/translator/ExpressionTranslatorTest.java
b/fe/fe-core/src/test/java/org/apache/doris/nereids/glue/translator/ExpressionTranslatorTest.java
index cdea9eea5d3..ccfbce80589 100644
---
a/fe/fe-core/src/test/java/org/apache/doris/nereids/glue/translator/ExpressionTranslatorTest.java
+++
b/fe/fe-core/src/test/java/org/apache/doris/nereids/glue/translator/ExpressionTranslatorTest.java
@@ -23,9 +23,12 @@ import org.apache.doris.analysis.Expr;
import org.apache.doris.analysis.IntLiteral;
import org.apache.doris.catalog.Function.NullableMode;
import org.apache.doris.catalog.Type;
-import org.apache.doris.common.AnalysisException;
+import org.apache.doris.nereids.exceptions.AnalysisException;
import org.apache.doris.nereids.trees.expressions.BitNot;
+import org.apache.doris.nereids.trees.expressions.MatchAny;
import org.apache.doris.nereids.trees.expressions.literal.IntegerLiteral;
+import org.apache.doris.nereids.trees.expressions.literal.NullLiteral;
+import org.apache.doris.nereids.trees.expressions.literal.VarcharLiteral;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
@@ -33,7 +36,7 @@ import org.junit.jupiter.api.Test;
public class ExpressionTranslatorTest {
@Test
-public void testUnaryArithmetic() throws AnalysisException {
+public void testUnaryArithmetic() throws Exception {
BitNot bitNot = new BitNot(new IntegerLiteral(1));
ExpressionTranslator translator = ExpressionTranslator.INSTANCE;
Expr actual = translator.visitUnaryArithmetic(bitNot, null);
@@ -41,4 +44,11 @@ public class ExpressionTranslatorTest {
new IntLiteral(1, Type.INT), null, Type.INT,
NullableMode.DEPEND_ON_ARGUMENT);
Assertions.assertEquals(actual, expected);
}
+
+@Test
+public void testMatch() {
+MatchAny matchAny = new MatchAny(new VarcharLiteral("collections"),
new NullLiteral());
+ExpressionTranslator translator = ExpressionTranslator.INSTANCE;
+Assertions.assertThrows(AnalysisException.class, () ->
translator.visitMatch(matchAny, null));
+}
}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bugfix](iceberg)add prefix for endpoint with s3 client for 3.0 (#41336) [doris]
doris-robot commented on PR #41879: URL: https://github.com/apache/doris/pull/41879#issuecomment-2413316946 TPC-DS: Total hot run time: 192243 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 8be31dce1a37951e445fc37196c6a6f34b85cd23, data reload: false query1 1263937 894 894 query2 6274202919111911 query3 10787 396138053805 query4 68200 26631 23413 23413 query5 5626469 457 457 query6 476 171 170 170 query7 6342305 302 302 query8 304 204 214 204 query9 9303264426232623 query10 515 281 272 272 query11 18194 15246 15790 15246 query12 167 98 99 98 query13 1638466 425 425 query14 11531 668375226683 query15 230 179 179 179 query16 7094501 520 501 query17 1069555 543 543 query18 1148300 301 300 query19 204 144 143 143 query20 112 105 107 105 query21 210 97 100 97 query22 4262413241754132 query23 34129 33785 34003 33785 query24 5625274628632746 query25 522 402 397 397 query26 667 162 168 162 query27 1692299 287 287 query28 4042215521422142 query29 646 432 428 428 query30 236 149 146 146 query31 984 790 808 790 query32 73 55 55 55 query33 473 302 295 295 query34 897 502 498 498 query35 852 733 740 733 query36 1082926 941 926 query37 137 78 78 78 query38 3966382338043804 query39 1499144414351435 query40 204 94 101 94 query41 47 42 42 42 query42 113 99 93 93 query43 519 479 483 479 query44 1132757 758 757 query45 198 162 170 162 query46 1118695 706 695 query47 1877183017961796 query48 417 332 334 332 query49 704 415 381 381 query50 832 396 398 396 query51 7008690668346834 query52 93 88 87 87 query53 256 176 179 176 query54 559 476 461 461 query55 75 74 76 74 query56 263 245 247 245 query57 1222113611231123 query58 219 223 234 223 query59 2972292728272827 query60 305 274 262 262 query61 104 101 97 97 query62 767 653 658 653 query63 212 177 178 177 query64 1593638 585 585 query65 3269318631763176 query66 711 300 292 292 query67 15716 15275 15141 15141 query68 3684527 539 527 query69 648 281 286 281 query70 1229111211381112 query71 482 271 282 271 query72 7905385039043850 query73 752 342 344 342 query74 10299 896088258825 query75 4551263526322632 query76 3654905 872 872 query77 783 289 294 289 query78 10051 921991909190 query79 3399587 578 578 query80 1365434 453 434 query81 556 223 215 215 query82 714 129 131 129 query83 398 140 133 133 query84 290 83 78 78 query85 1715285 296 285 query86 447 303 294 294 query87 4445418043324180 query88 4791236323892363 query89 411 284 285 284 query90 2168180 182 180 query91 148 106 103 103 query92 59 45 46 45 query93 5279536 522 522 query94 1124284 287 284 query95 353 247 250 247 query96 629 278 272 272 query97 3287310531173105 query98 228 194 210 194 query99 1541127412571257 Total cold run time: 332361 ms Total hot run time: 192243 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [improve](profile) add timer for record udf execute time [doris]
github-actions[bot] commented on PR #41779: URL: https://github.com/apache/doris/pull/41779#issuecomment-2413314402 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](profile) add timer for record udf execute time [doris]
github-actions[bot] commented on PR #41779: URL: https://github.com/apache/doris/pull/41779#issuecomment-2413314774 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
