Re: [PR] [cherry-pick](branch3.0) impl translate and url encode [doris]
morningman commented on PR #41657: URL: https://github.com/apache/doris/pull/41657#issuecomment-2406525593 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](compile) Fix control reaches end of non-void function [doris]
doris-robot commented on PR #41692: URL: https://github.com/apache/doris/pull/41692#issuecomment-2406524936 TeamCity be ut coverage result: Function Coverage: 37.41% (9661/25827) Line Coverage: 28.67% (80141/279489) Region Coverage: 28.10% (41439/147456) Branch Coverage: 24.71% (2/85420) Coverage Report: http://coverage.selectdb-in.cc/coverage/eaecabafaa2ee8e66fa522a9871ee44aed9c5bd6_eaecabafaa2ee8e66fa522a9871ee44aed9c5bd6/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Revert "[feature](nereids) extend infer predicates (#40878)" [doris]
feiniaofeiafei commented on PR #41696: URL: https://github.com/apache/doris/pull/41696#issuecomment-2406527203 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] Revert "[feature](nereids) extend infer predicates (#40878)" [doris]
feiniaofeiafei opened a new pull request, #41696: URL: https://github.com/apache/doris/pull/41696 This reverts commit a205182850fbded96c93aae71a5ea0a93e6e43f1. ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Revert "[feature](nereids) extend infer predicates (#40878)" [doris]
doris-robot commented on PR #41696: URL: https://github.com/apache/doris/pull/41696#issuecomment-2406527160 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Revert "[feature](nereids) extend infer predicates (#40878)" [doris]
github-actions[bot] commented on PR #41696: URL: https://github.com/apache/doris/pull/41696#issuecomment-2406529727 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Revert "[feature](nereids) extend infer predicates (#40878)" [doris]
github-actions[bot] commented on PR #41696: URL: https://github.com/apache/doris/pull/41696#issuecomment-2406529695 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](followup) Stop tasks if waken by downstream tasks [doris]
Gabriel39 commented on PR #41628: URL: https://github.com/apache/doris/pull/41628#issuecomment-2406561554 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
hust-hhb commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2406381080 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [cherry-pick](branch2.1) support escape.delim and serialization.null.format for hive text [doris]
suxiaogang223 opened a new pull request, #41684: URL: https://github.com/apache/doris/pull/41684 ## Proposed changes pick from master: https://github.com/apache/doris/pull/39700 support escape.delim and serialization.null.format for hive text -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [cherry-pick](branch2.1) support escape.delim and serialization.null.format for hive text [doris]
doris-robot commented on PR #41684: URL: https://github.com/apache/doris/pull/41684#issuecomment-2406379650 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [cherry-pick](branch2.1) support escape.delim and serialization.null.format for hive text [doris]
suxiaogang223 commented on PR #41684: URL: https://github.com/apache/doris/pull/41684#issuecomment-2406379713 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.0 updated: [opt](load) print more detailed log when stream load finished #41398 (#41643)
This is an automated email from the ASF dual-hosted git repository.
liaoxin pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.0 by this push:
new d0cf12f919b [opt](load) print more detailed log when stream load
finished #41398 (#41643)
d0cf12f919b is described below
commit d0cf12f919b1e495fc9e1dfaa570baff52ba8a20
Author: Xin Liao
AuthorDate: Fri Oct 11 09:52:57 2024 +0800
[opt](load) print more detailed log when stream load finished #41398
(#41643)
cherry pick from #41398
---
be/src/http/action/stream_load.cpp | 13 +
be/src/runtime/stream_load/stream_load_executor.cpp | 12 ++--
2 files changed, 15 insertions(+), 10 deletions(-)
diff --git a/be/src/http/action/stream_load.cpp
b/be/src/http/action/stream_load.cpp
index 3557d750ed4..5b113219192 100644
--- a/be/src/http/action/stream_load.cpp
+++ b/be/src/http/action/stream_load.cpp
@@ -133,6 +133,19 @@ void StreamLoadAction::handle(HttpRequest* req) {
_save_stream_load_record(ctx, str);
}
#endif
+
+LOG(INFO) << "finished to execute stream load. label=" << ctx->label
+ << ", txn_id=" << ctx->txn_id << ", query_id=" << ctx->id
+ << ", load_cost_ms=" << ctx->load_cost_millis << ",
receive_data_cost_ms="
+ << (ctx->receive_and_read_data_cost_nanos -
ctx->read_data_cost_nanos) / 100
+ << ", read_data_cost_ms=" << ctx->read_data_cost_nanos / 100
+ << ", write_data_cost_ms=" << ctx->write_data_cost_nanos /
100
+ << ", commit_and_publish_txn_cost_ms="
+ << ctx->commit_and_publish_txn_cost_nanos / 100
+ << ", number_total_rows=" << ctx->number_total_rows
+ << ", number_loaded_rows=" << ctx->number_loaded_rows
+ << ", receive_bytes=" << ctx->receive_bytes << ", loaded_bytes="
<< ctx->loaded_bytes;
+
// update statistics
streaming_load_requests_total->increment(1);
streaming_load_duration_ms->increment(ctx->load_cost_millis);
diff --git a/be/src/runtime/stream_load/stream_load_executor.cpp
b/be/src/runtime/stream_load/stream_load_executor.cpp
index 75386d7aa6b..c21cbc492f6 100644
--- a/be/src/runtime/stream_load/stream_load_executor.cpp
+++ b/be/src/runtime/stream_load/stream_load_executor.cpp
@@ -82,6 +82,7 @@ Status
StreamLoadExecutor::execute_plan_fragment(std::shared_ptrnumber_loaded_rows =
state->num_rows_load_success();
ctx->number_filtered_rows =
state->num_rows_load_filtered();
ctx->number_unselected_rows =
state->num_rows_load_unselected();
+ctx->loaded_bytes = state->num_bytes_load_total();
int64_t num_selected_rows =
ctx->number_total_rows -
ctx->number_unselected_rows;
@@ -165,6 +166,7 @@ Status
StreamLoadExecutor::execute_plan_fragment(std::shared_ptrnumber_loaded_rows =
state->num_rows_load_success();
ctx->number_filtered_rows =
state->num_rows_load_filtered();
ctx->number_unselected_rows =
state->num_rows_load_unselected();
+ctx->loaded_bytes = state->num_bytes_load_total();
int64_t num_selected_rows =
ctx->number_total_rows -
ctx->number_unselected_rows;
@@ -227,16 +229,6 @@ Status
StreamLoadExecutor::execute_plan_fragment(std::shared_ptrcommit_txn(ctx.get());
}
}
-
-LOG(INFO) << "finished to execute stream load. label=" <<
ctx->label
- << ", txn_id=" << ctx->txn_id
- << ", query_id=" <<
print_id(ctx->put_result.params.params.query_id)
- << ", receive_data_cost_ms="
- << (ctx->receive_and_read_data_cost_nanos -
- ctx->read_data_cost_nanos) /
- 100
- << ", read_data_cost_ms=" <<
ctx->read_data_cost_nanos / 100
- << ", write_data_cost_ms=" <<
ctx->write_data_cost_nanos / 100;
});
}
if (!st.ok()) {
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [cherry-pick](branch2.1) support escape.delim and serialization.null.format for hive text [doris]
github-actions[bot] commented on code in PR #41684:
URL: https://github.com/apache/doris/pull/41684#discussion_r1796322480
##
be/src/vec/exec/format/csv/csv_reader.cpp:
##
@@ -174,6 +174,23 @@ void PlainCsvTextFieldSplitter::do_split(const Slice&
line, std::vector*
}
}
+void HiveCsvTextFieldSplitter::do_split(const Slice& line, std::vector*
splitted_values) {
Review Comment:
warning: method 'do_split' can be made const
[readability-make-member-function-const]
be/src/vec/exec/format/csv/csv_reader.cpp:177:
```diff
- values) {
+ values) const {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bugfix](becore) use after free problem when the segment is pop [doris]
yiguolei commented on PR #41685: URL: https://github.com/apache/doris/pull/41685#issuecomment-2406388115 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](json) Support json_search function in 2.1 [doris]
liutang123 commented on PR #41590: URL: https://github.com/apache/doris/pull/41590#issuecomment-2406387698 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](load) print more detailed log when stream load finished #41398 [doris]
liaoxin01 merged PR #41643: URL: https://github.com/apache/doris/pull/41643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](err-msg) Output column info when size invalid in block data convertor [doris]
dataroaring commented on PR #41535: URL: https://github.com/apache/doris/pull/41535#issuecomment-2406382726 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [bugfix](becore) use after free problem when the segment is pop [doris]
yiguolei opened a new pull request, #41685: URL: https://github.com/apache/doris/pull/41685 ## Proposed changes Issue Number: close #xxx introduced by #41608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bugfix](becore) use after free problem when the segment is pop [doris]
doris-robot commented on PR #41685: URL: https://github.com/apache/doris/pull/41685#issuecomment-2406387124 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](err-msg) Output column info when size invalid in block data convertor [doris]
github-actions[bot] commented on PR #41535: URL: https://github.com/apache/doris/pull/41535#issuecomment-2406386885 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](sequence col) add session variable to skip sequence column check while INSERT INTO [doris]
github-actions[bot] commented on PR #41655: URL: https://github.com/apache/doris/pull/41655#issuecomment-2406386088 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](auto-partition) should check the expr of auto range partition [doris]
zhangstar333 commented on PR #41626: URL: https://github.com/apache/doris/pull/41626#issuecomment-2406384794 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [fix](case) fix test_schema_change_ck (#41654)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new fc96ff183e8 [fix](case) fix test_schema_change_ck (#41654)
fc96ff183e8 is described below
commit fc96ff183e82141013715ab32e528134ea23cc53
Author: meiyi
AuthorDate: Fri Oct 11 09:58:11 2024 +0800
[fix](case) fix test_schema_change_ck (#41654)
---
.../unique_with_mow_c_p0/test_schema_change_ck.out | 44 -
regression-test/suites/insert_p0/test_jdbc.groovy | 102 +
.../test_schema_change_ck.groovy | 4 +-
3 files changed, 126 insertions(+), 24 deletions(-)
diff --git
a/regression-test/data/unique_with_mow_c_p0/test_schema_change_ck.out
b/regression-test/data/unique_with_mow_c_p0/test_schema_change_ck.out
index f116cf20b3c..56cba918faa 100644
--- a/regression-test/data/unique_with_mow_c_p0/test_schema_change_ck.out
+++ b/regression-test/data/unique_with_mow_c_p0/test_schema_change_ck.out
@@ -154,28 +154,28 @@
210200 39 20
-- !select_create_mv_mv --
-10 39
-11 38
-11039
-11138
-11237
-11336
-11435
-11534
-11633
-11732
-11831
-11930
-12 37
-13 36
-14 35
-15 34
-16 33
-17 32
-18 31
-19 30
-21039
-21138
+10 \N 29
+11 \N 28
+110200 20
+111200 21
+112200 22
+113200 23
+114200 24
+115200 25
+116200 20
+117200 20
+118200 20
+119200 20
+12 \N 26
+13 \N 27
+14 \N 20
+15 \N 20
+16 \N 20
+17 \N 20
+18 200 20
+19 200 20
+210200 20
+211200 21
-- !select_create_rollup_base --
11 \N 38 28
diff --git a/regression-test/suites/insert_p0/test_jdbc.groovy
b/regression-test/suites/insert_p0/test_jdbc.groovy
new file mode 100644
index 000..acd275983aa
--- /dev/null
+++ b/regression-test/suites/insert_p0/test_jdbc.groovy
@@ -0,0 +1,102 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import java.util.Arrays
+import java.util.stream.Collectors
+
+suite("test_jdbc") {
+def user = context.config.jdbcUser
+def password = context.config.jdbcPassword
+def realDb = "regression_test_insert_p0"
+def tableName = realDb + ".test_jdbc"
+
+sql "CREATE DATABASE IF NOT EXISTS ${realDb}"
+sql """ DROP TABLE IF EXISTS ${tableName} """
+sql """
+CREATE TABLE ${tableName} (
+`id` int(11) NULL,
+`phone` varchar(50) NULL,
+) ENGINE=OLAP
+unique KEY(`id`)
+COMMENT 'OLAP'
+DISTRIBUTED BY HASH(`id`) BUCKETS 1
+PROPERTIES (
+"replication_num" = "1"
+);
+"""
+
+// Parse url
+String jdbcUrl = context.config.jdbcUrl
+String urlWithoutSchema = jdbcUrl.substring(jdbcUrl.indexOf("://") + 3)
+def sql_ip = urlWithoutSchema.substring(0, urlWithoutSchema.indexOf(":"))
+def sql_port
+if (urlWithoutSchema.indexOf("/") >= 0) {
+// e.g: jdbc:mysql://localhost:8080/?a=b
+sql_port = urlWithoutSchema.substring(urlWithoutSchema.indexOf(":") +
1, urlWithoutSchema.indexOf("/"))
+} else {
+// e.g: jdbc:mysql://localhost:8080
+sql_port = urlWithoutSchema.substring(urlWithoutSchema.indexOf(":") +
1)
+}
+String url =
String.format("jdbc:mysql://%s:%s/%s?useLocalSessionState=true", sql_ip,
sql_port, realDb)
+def batchSize = 5
+
+def urls = [
+url,
+url + "&rewriteBatchedStatements=true",
+url + "&rewriteBatchedStatements=true&allowMultiQueries=true",
+url + "&rewriteBatchedStatements=true&allowMultiQueries=false"
+]
+
+def insert = { jdbc_url ->
+connect(user = user, password = password, url = jdbc_url) {
+logger.info("insert url: {}", jdbc_url)
+def ps = prepareStatement "insert into ${tableName} values(?, ?)"
+for (int i = 0; i < batchSize; i++) {
+String phone = UUID.randomUUID().toString()
+
Re: [PR] [fix](case) fix test_schema_change_ck [doris]
dataroaring merged PR #41654: URL: https://github.com/apache/doris/pull/41654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](property) Modify some show properties action [doris]
Yukang-Lian commented on PR #41366: URL: https://github.com/apache/doris/pull/41366#issuecomment-2406391202 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](property) Modify some show properties action [doris]
Yukang-Lian commented on PR #41366: URL: https://github.com/apache/doris/pull/41366#issuecomment-2406391097 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bugfix](becore) use after free problem when the segment is pop [doris]
github-actions[bot] commented on PR #41685: URL: https://github.com/apache/doris/pull/41685#issuecomment-2406391358 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-3.0 updated: [Feature](compatibility) make some agg function restrict (#41459)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new d56371da6be [Feature](compatibility) make some agg function restrict
(#41459)
d56371da6be is described below
commit d56371da6be952e37d8371da8ec683a56b9865fe
Author: Pxl
AuthorDate: Thu Oct 10 14:52:19 2024 +0800
[Feature](compatibility) make some agg function restrict (#41459)
## Proposed changes
make some agg function restrict
---
be/src/agent/be_exec_version_manager.cpp | 26 +-
be/src/agent/be_exec_version_manager.h | 9 +-
.../aggregate_function_covar.cpp | 16 +-
.../aggregate_functions/aggregate_function_covar.h | 34 ---
.../aggregate_function_percentile.cpp | 62 +
.../aggregate_function_percentile.h| 270 -
.../aggregate_function_percentile_approx.cpp | 39 ---
.../aggregate_function_percentile_approx.h | 258
.../aggregate_function_stddev.cpp | 32 +--
.../aggregate_function_stddev.h| 34 ---
.../aggregate_function_window_funnel.cpp | 28 +--
.../aggregate_function_window_funnel.h | 261
.../aggregate_functions/vec_window_funnel_test.cpp | 3 +-
.../main/java/org/apache/doris/common/Config.java | 2 +-
14 files changed, 40 insertions(+), 1034 deletions(-)
diff --git a/be/src/agent/be_exec_version_manager.cpp
b/be/src/agent/be_exec_version_manager.cpp
index 0bdb55f7bc3..bfd0745e316 100644
--- a/be/src/agent/be_exec_version_manager.cpp
+++ b/be/src/agent/be_exec_version_manager.cpp
@@ -34,6 +34,13 @@ Status BeExecVersionManager::check_be_exec_version(int
be_exec_version) {
int BeExecVersionManager::get_function_compatibility(int be_exec_version,
std::string
function_name) {
+if (_function_restrict_map.contains(function_name) && be_exec_version !=
get_newest_version()) {
+throw Exception(Status::InternalError(
+"function {} do not support old be exec version, maybe it's
because doris are "
+"doing a rolling upgrade. newest_version={},
input_be_exec_version={}",
+function_name, get_newest_version(), be_exec_version));
+}
+
auto it = _function_change_map.find(function_name);
if (it == _function_change_map.end()) {
// 0 means no compatibility issues need to be dealt with
@@ -82,7 +89,7 @@ void BeExecVersionManager::check_function_compatibility(int
current_be_exec_vers
* 3: start from doris 2.0.0 (by some mistakes)
*a. aggregation function do not serialize bitmap to string.
*b. support window funnel mode.
- * 4/5: start from doris 2.1.0
+ * 4: start from doris 2.1.0
*a. ignore this line, window funnel mode should be enabled from 2.0.
*b. array contains/position/countequal function return nullable in less
situations.
*c. cleared old version of Version 2.
@@ -92,15 +99,22 @@ void BeExecVersionManager::check_function_compatibility(int
current_be_exec_vers
*g. do local merge of remote runtime filter
*h. "now": ALWAYS_NOT_NULLABLE -> DEPEND_ON_ARGUMENTS
*
- * 7: start from doris 3.0.0
+ * 5: start from doris 3.0.0
+ *a. change some agg function nullable property: PR #37215
+ *
+ * 6: start from doris 3.0.1 and 2.1.6
*a. change the impl of percentile (need fix)
*b. clear old version of version 3->4
*c. change FunctionIsIPAddressInRange from AlwaysNotNullable to
DependOnArguments
- *d. change some agg function nullable property: PR #37215
- *e. change variant serde to fix PR #38413
- *f. support const column in serialize/deserialize function: PR #41175
+ *d. change variant serde to fix PR #38413
+ *
+ * 7: start from doris 3.0.2
+ *a. window funnel logic change
+* b. support const column in serialize/deserialize function: PR #41175
*/
-const int BeExecVersionManager::max_be_exec_version = 7;
+
+const int BeExecVersionManager::max_be_exec_version = 8;
const int BeExecVersionManager::min_be_exec_version = 0;
std::map>
BeExecVersionManager::_function_change_map {};
+std::set BeExecVersionManager::_function_restrict_map;
} // namespace doris
diff --git a/be/src/agent/be_exec_version_manager.h
b/be/src/agent/be_exec_version_manager.h
index a51fb8e36b4..f4158a40152 100644
--- a/be/src/agent/be_exec_version_manager.h
+++ b/be/src/agent/be_exec_version_manager.h
@@ -25,7 +25,6 @@
namespace doris {
-constexpr static int AGG_FUNCTION_NEW_WINDOW_FUNNEL = 6;
constexpr inline int BITMAP_SERDE = 3;
constexpr inline int USE_NEW_SERDE = 4; // release on DORIS version 2.1
constexpr inline int OLD_WAL_SERDE = 3; // use to solve compatibility
issues, see pr #32
Re: [PR] [Fix](delete) Fix some delete p2 case [doris]
Yukang-Lian commented on PR #41678: URL: https://github.com/apache/doris/pull/41678#issuecomment-2406397377 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bugfix](becore) use after free problem when the segment is pop [doris]
github-actions[bot] commented on PR #41685: URL: https://github.com/apache/doris/pull/41685#issuecomment-2406396574 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bugfix](becore) use after free problem when the segment is pop [doris]
github-actions[bot] commented on PR #41685: URL: https://github.com/apache/doris/pull/41685#issuecomment-2406396604 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](property) Modify some show properties action [doris]
Yukang-Lian commented on PR #41366: URL: https://github.com/apache/doris/pull/41366#issuecomment-2406396838 run cloud_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](group commit) set internal group commit timeout [doris]
dataroaring merged PR #41404: URL: https://github.com/apache/doris/pull/41404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (c6bd9cbf9c3 -> 93323fe2b6d)
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from c6bd9cbf9c3 [chore](log) Adjust log level for replaying a batch editlog cost time (#41392) add 93323fe2b6d [fix](cluster key) Cluster key skip non vertical compact (#41413) No new revisions were added by this update. Summary of changes: be/src/olap/compaction.cpp | 4 1 file changed, 4 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](log) Adjust log level for replaying a batch editlog cost time [doris]
dataroaring merged PR #41392: URL: https://github.com/apache/doris/pull/41392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [chore](log) Adjust log level for replaying a batch editlog cost time (#41392)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new c6bd9cbf9c3 [chore](log) Adjust log level for replaying a batch
editlog cost time (#41392)
c6bd9cbf9c3 is described below
commit c6bd9cbf9c38f2ba31eee30e8de6fea3462f84d1
Author: Lei Zhang <27994433+swjtu-zhang...@users.noreply.github.com>
AuthorDate: Fri Oct 11 10:06:40 2024 +0800
[chore](log) Adjust log level for replaying a batch editlog cost time
(#41392)
* `replay journal cost too much time` is a counter for replaying a batch
editlog it is normal that cost too much time, the warning level can make
confused
---
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
b/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
index e4e3c64ec8b..d6ccbbc7c8c 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
@@ -2988,8 +2988,8 @@ public class Env {
}
}
long cost = System.currentTimeMillis() - startTime;
-if (cost >= 1000) {
-LOG.warn("replay journal cost too much time: {} replayedJournalId:
{}", cost, replayedJournalId);
+if (LOG.isDebugEnabled() && cost >= 1000) {
+LOG.debug("replay journal cost too much time: {}
replayedJournalId: {}", cost, replayedJournalId);
}
return hasLog;
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cluster key) Cluster key skip non vertical compact [doris]
dataroaring merged PR #41413: URL: https://github.com/apache/doris/pull/41413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (93323fe2b6d -> 6bb30e43f34)
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 93323fe2b6d [fix](cluster key) Cluster key skip non vertical compact (#41413) add 6bb30e43f34 [improve](group commit) set internal group commit timeout (#41404) No new revisions were added by this update. Summary of changes: fe/fe-common/src/main/java/org/apache/doris/common/Config.java | 5 + .../doris/tablefunction/GroupCommitTableValuedFunction.java | 9 + 2 files changed, 14 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [only test](exchange sink) [doris]
Mryange commented on PR #41560: URL: https://github.com/apache/doris/pull/41560#issuecomment-2406400280 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](Variant) forbid variant type as hash join key [doris]
morrySnow commented on PR #41673: URL: https://github.com/apache/doris/pull/41673#issuecomment-2406400166 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) enable_file_cache for cloud by default [doris]
github-actions[bot] commented on PR #41502: URL: https://github.com/apache/doris/pull/41502#issuecomment-2406400265 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](shuffle) Reduce memory consumption in data stream sender [doris]
github-actions[bot] commented on PR #41676: URL: https://github.com/apache/doris/pull/41676#issuecomment-2406401577 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](shuffle) Reduce memory consumption in data stream sender [doris]
github-actions[bot] commented on PR #41676: URL: https://github.com/apache/doris/pull/41676#issuecomment-2406401605 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [only test](exchange sink) [doris]
github-actions[bot] commented on PR #41560: URL: https://github.com/apache/doris/pull/41560#issuecomment-2406400648 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](regression-test) test alter table partition [doris]
github-actions[bot] commented on PR #41437: URL: https://github.com/apache/doris/pull/41437#issuecomment-2406403077 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](column) implement insert_many_from function for all column [doris]
zhangstar333 commented on PR #41623: URL: https://github.com/apache/doris/pull/41623#issuecomment-2406401329 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](bug) Is null predicate get error query result [doris]
HappenLee commented on PR #41668: URL: https://github.com/apache/doris/pull/41668#issuecomment-2406401354 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [fix](cloud) enable_file_cache for cloud by default (#41502)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 954f98c8a74 [fix](cloud) enable_file_cache for cloud by default
(#41502)
954f98c8a74 is described below
commit 954f98c8a74eb88cdc7beb862d02153d5407a2e5
Author: Yongqiang YANG <98214048+dataroar...@users.noreply.github.com>
AuthorDate: Fri Oct 11 10:13:32 2024 +0800
[fix](cloud) enable_file_cache for cloud by default (#41502)
---
be/src/common/config.cpp | 7 +++
1 file changed, 7 insertions(+)
diff --git a/be/src/common/config.cpp b/be/src/common/config.cpp
index 82dd51224cc..e805da4e62a 100644
--- a/be/src/common/config.cpp
+++ b/be/src/common/config.cpp
@@ -1683,6 +1683,13 @@ bool init(const char* conf_file, bool fill_conf_map,
bool must_exist, bool set_t
SET_FIELD(it.second, std::vector, fill_conf_map,
set_to_default);
}
+if (config::is_cloud_mode()) {
+auto st = config::set_config("enable_file_cache", "true", true, true);
+LOG(INFO) << "set config enable_file_cache "
+ << "true"
+ << " " << st;
+}
+
return true;
}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (6bb30e43f34 -> 199148f82cc)
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 6bb30e43f34 [improve](group commit) set internal group commit timeout (#41404) add 199148f82cc [improve](cloud) set default vaule for file_path (#41507) No new revisions were added by this update. Summary of changes: be/src/common/config.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [only test](exchange sink) [doris]
github-actions[bot] commented on PR #41560: URL: https://github.com/apache/doris/pull/41560#issuecomment-2406403254 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](cloud) set default vaule for file_path [doris]
dataroaring merged PR #41507: URL: https://github.com/apache/doris/pull/41507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) enable_file_cache for cloud by default [doris]
dataroaring merged PR #41502: URL: https://github.com/apache/doris/pull/41502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-3.0 updated: [regression-test](feature) add skip non-concurrent test functions (#41021) (#41494)
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new 9559af3bd20 [regression-test](feature) add skip non-concurrent test functions (#41021) (#41494) 9559af3bd20 is described below commit 9559af3bd2098c967a781bddd8a0bffa07e5bd30 Author: shuke <37901441+shuke...@users.noreply.github.com> AuthorDate: Fri Oct 11 10:15:13 2024 +0800 [regression-test](feature) add skip non-concurrent test functions (#41021) (#41494) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](feature) add skip non-concurrent test functions (#41021) [doris]
dataroaring merged PR #41494: URL: https://github.com/apache/doris/pull/41494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [doc](cloud-deploy) add an example for CREATE-STORAGE-VAULT [doris-website]
KassieZ commented on code in PR #1174: URL: https://github.com/apache/doris-website/pull/1174#discussion_r1796332857 ## docs/compute-storage-decoupled/before-deployment.md: ## Review Comment: EN Docs should not use Examples in Chinese, please fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: [opt](merge-on-write) avoid to check delete bitmap while lookup rowkey in some situation to reduce CPU cost (#41480) (#41439)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new b489cdf8408 [opt](merge-on-write) avoid to check delete bitmap while
lookup rowkey in some situation to reduce CPU cost (#41480) (#41439)
b489cdf8408 is described below
commit b489cdf840856eb553973edde7fcd056d3ef92b1
Author: zhannngchen <48427519+zhannngc...@users.noreply.github.com>
AuthorDate: Fri Oct 11 10:15:39 2024 +0800
[opt](merge-on-write) avoid to check delete bitmap while lookup rowkey in
some situation to reduce CPU cost (#41480) (#41439)
## Proposed changes
Issue Number: close #xxx
cherry-pick #41480
---
be/src/olap/tablet.cpp | 27 +--
be/src/olap/tablet.h | 3 ++-
2 files changed, 19 insertions(+), 11 deletions(-)
diff --git a/be/src/olap/tablet.cpp b/be/src/olap/tablet.cpp
index c1a94223eff..9f07f17ab8a 100644
--- a/be/src/olap/tablet.cpp
+++ b/be/src/olap/tablet.cpp
@@ -2822,7 +2822,7 @@ Status Tablet::lookup_row_key(const Slice& encoded_key,
TabletSchema* latest_sch
const std::vector&
specified_rowsets,
RowLocation* row_location, uint32_t version,
std::vector>& segment_caches,
- RowsetSharedPtr* rowset, bool with_rowid) {
+ RowsetSharedPtr* rowset, bool with_rowid, bool
is_partial_update) {
SCOPED_BVAR_LATENCY(g_tablet_lookup_rowkey_latency);
size_t seq_col_length = 0;
// use the latest tablet schema to decide if the tablet has sequence
column currently
@@ -2839,6 +2839,8 @@ Status Tablet::lookup_row_key(const Slice& encoded_key,
TabletSchema* latest_sch
Slice(encoded_key.get_data(), encoded_key.get_size() -
seq_col_length - rowid_length);
RowLocation loc;
+bool need_to_check_delete_bitmap = is_partial_update || with_seq_col;
+
for (size_t i = 0; i < specified_rowsets.size(); i++) {
auto& rs = specified_rowsets[i];
auto& segments_key_bounds =
rs->rowset_meta()->get_segments_key_bounds();
@@ -2877,15 +2879,19 @@ Status Tablet::lookup_row_key(const Slice& encoded_key,
TabletSchema* latest_sch
if (!s.ok() && !s.is()) {
return s;
}
-if (s.ok() &&
_tablet_meta->delete_bitmap().contains_agg_without_cache(
- {loc.rowset_id, loc.segment_id, version},
loc.row_id)) {
-// if has sequence col, we continue to compare the sequence_id
of
-// all rowsets, util we find an existing key.
-if (schema->has_sequence_col()) {
-continue;
+if (s.ok() && need_to_check_delete_bitmap) {
+// check if the key is already mark deleted
+if (_tablet_meta->delete_bitmap().contains_agg_without_cache(
+{loc.rowset_id, loc.segment_id, version},
loc.row_id)) {
+// if has sequence col, we continue to compare the
sequence_id of
+// all rowsets, util we find an existing key.
+if (with_seq_col) {
+continue;
+}
+// The key is deleted, we need to break the loop and return
+// KEY_NOT_FOUND.
+break;
}
-// The key is deleted, we don't need to search for it any more.
-break;
}
// `st` is either OK or KEY_ALREADY_EXISTS now.
// for partial update, even if the key is already exists, we still
need to
@@ -3052,7 +3058,8 @@ Status Tablet::calc_segment_delete_bitmap(RowsetSharedPtr
rowset,
RowsetSharedPtr rowset_find;
auto st = lookup_row_key(key, rowset_schema.get(), true,
specified_rowsets, &loc,
- dummy_version.first - 1, segment_caches,
&rowset_find);
+ dummy_version.first - 1, segment_caches,
&rowset_find, false,
+ is_partial_update);
bool expected_st = st.ok() || st.is() ||
st.is();
// It's a defensive DCHECK, we need to exclude some common errors
to avoid core-dump
// while stress test
diff --git a/be/src/olap/tablet.h b/be/src/olap/tablet.h
index fb20498355f..fdfad28a0de 100644
--- a/be/src/olap/tablet.h
+++ b/be/src/olap/tablet.h
@@ -438,7 +438,8 @@ public:
const std::vector&
specified_rowsets,
RowLocation* row_location, uint32_t version,
std::vector>&
segment_caches,
- RowsetSharedPtr* rowset = nullptr, bool with_rowid =
true);
+
Re: [PR] [opt](merge-on-write) avoid to check delete bitmap while lookup rowkey in some situation to reduce CPU cost (#41480) [doris]
dataroaring merged PR #41439: URL: https://github.com/apache/doris/pull/41439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance]change SpinLock to mutex for _tablets_channels_lock [doris]
dataroaring merged PR #41384: URL: https://github.com/apache/doris/pull/41384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [enhance]change SpinLock to mutex for _tablets_channels_lock (#41384)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 3b2d61d9d6a [enhance]change SpinLock to mutex for
_tablets_channels_lock (#41384)
3b2d61d9d6a is described below
commit 3b2d61d9d6acb31ae4147e15b6a4e593a5ba67df
Author: kkop <2449402...@qq.com>
AuthorDate: Fri Oct 11 10:17:10 2024 +0800
[enhance]change SpinLock to mutex for _tablets_channels_lock (#41384)
change SpinLock to mutex for _tablets_channels_lock
---
be/src/runtime/load_channel.cpp | 6 +++---
be/src/runtime/load_channel.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/be/src/runtime/load_channel.cpp b/be/src/runtime/load_channel.cpp
index 1ac7753b197..9369c0c833c 100644
--- a/be/src/runtime/load_channel.cpp
+++ b/be/src/runtime/load_channel.cpp
@@ -135,7 +135,7 @@ Status LoadChannel::open(const PTabletWriterOpenRequest&
params) {
_is_high_priority,
_self_profile);
}
{
-std::lock_guard l(_tablets_channels_lock);
+std::lock_guard l(_tablets_channels_lock);
_tablets_channels.insert({index_id, channel});
}
}
@@ -237,7 +237,7 @@ Status LoadChannel::_handle_eos(BaseTabletsChannel* channel,
if (finished) {
std::lock_guard l(_lock);
{
-std::lock_guard l(_tablets_channels_lock);
+std::lock_guard l(_tablets_channels_lock);
_tablets_channels_rows.insert(std::make_pair(
index_id,
std::make_pair(channel->total_received_rows(),
channel->num_rows_filtered(;
@@ -263,7 +263,7 @@ void
LoadChannel::_report_profile(PTabletWriterAddBlockResult* response) {
_self_profile->set_timestamp(_last_updated_time);
{
-std::lock_guard l(_tablets_channels_lock);
+std::lock_guard l(_tablets_channels_lock);
for (auto& it : _tablets_channels) {
it.second->refresh_profile();
}
diff --git a/be/src/runtime/load_channel.h b/be/src/runtime/load_channel.h
index 6c150ed74d9..36a8f363ba9 100644
--- a/be/src/runtime/load_channel.h
+++ b/be/src/runtime/load_channel.h
@@ -104,7 +104,7 @@ private:
std::unordered_map>
_tablets_channels;
// index id -> (received rows, filtered rows)
std::unordered_map>
_tablets_channels_rows;
-SpinLock _tablets_channels_lock;
+std::mutex _tablets_channels_lock;
// This is to save finished channels id, to handle the retry request.
std::unordered_set _finished_channel_ids;
// set to true if at least one tablets channel has been opened
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feat](nereids) add expression transformation rule simplify_conditional_function [doris]
feiniaofeiafei commented on PR #37613: URL: https://github.com/apache/doris/pull/37613#issuecomment-2406413141 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feat](nereids) add expression transformation rule simplify_conditional_function [doris]
feiniaofeiafei commented on PR #37613: URL: https://github.com/apache/doris/pull/37613#issuecomment-2406413198 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](mtmv) Fix written by mv successfully but not get mv lock. If use mv, data maybe wrong [doris]
github-actions[bot] commented on PR #40173: URL: https://github.com/apache/doris/pull/40173#issuecomment-2406414442 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [doc](cloud-deploy) add an example for CREATE-STORAGE-VAULT [doris-website]
yagagagaga commented on code in PR #1174: URL: https://github.com/apache/doris-website/pull/1174#discussion_r1796336486 ## docs/compute-storage-decoupled/before-deployment.md: ## Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](err-msg) Output column info when size invalid in block data convertor [doris]
doris-robot commented on PR #41535: URL: https://github.com/apache/doris/pull/41535#issuecomment-2406417712 TeamCity be ut coverage result: Function Coverage: 37.40% (9660/25827) Line Coverage: 28.67% (80140/279481) Region Coverage: 28.11% (41448/147449) Branch Coverage: 24.71% (21108/85416) Coverage Report: http://coverage.selectdb-in.cc/coverage/295d0212b3b51f27fd7dc3c80c9108e6297851a1_295d0212b3b51f27fd7dc3c80c9108e6297851a1/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](user cancel) Make sure we can see unified cancel msg if query is killed by user. [doris]
zhiqiang- commented on PR #41680: URL: https://github.com/apache/doris/pull/41680#issuecomment-2406419819 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Refactor] (inverted index) Refactor Inverted index file writer [doris]
doris-robot commented on PR #41625: URL: https://github.com/apache/doris/pull/41625#issuecomment-2406419866 TeamCity be ut coverage result: Function Coverage: 37.41% (9663/25832) Line Coverage: 28.67% (80126/279441) Region Coverage: 28.12% (41444/147401) Branch Coverage: 24.72% (21104/85378) Coverage Report: http://coverage.selectdb-in.cc/coverage/a89edd5a7fc9aaf08b8ceba5344b5957160aa864_a89edd5a7fc9aaf08b8ceba5344b5957160aa864/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Upgrade paimon to 0.9.0 [doris-shade]
CalvinKirs merged PR #47: URL: https://github.com/apache/doris-shade/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
doris-robot commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2406419669 TeamCity be ut coverage result: Function Coverage: 37.41% (9662/25829) Line Coverage: 28.68% (80163/279529) Region Coverage: 28.11% (41457/147479) Branch Coverage: 24.71% (2/85440) Coverage Report: http://coverage.selectdb-in.cc/coverage/73d9c5a3fda0ff0d36b8b4a2a8bd20b99e46d142_73d9c5a3fda0ff0d36b8b4a2a8bd20b99e46d142/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-shade) branch master updated: Upgrade paimon to 0.9.0 (#47)
This is an automated email from the ASF dual-hosted git repository. kirs pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris-shade.git The following commit(s) were added to refs/heads/master by this push: new 1168dbd Upgrade paimon to 0.9.0 (#47) 1168dbd is described below commit 1168dbd612ebb7d80f3d72eac53ae31b422d0ad0 Author: Calvin Kirs AuthorDate: Fri Oct 11 10:31:08 2024 +0800 Upgrade paimon to 0.9.0 (#47) --- CHANGE-LOG.md | 2 ++ hive-catalog-shade/pom.xml | 4 ++-- pom.xml| 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/CHANGE-LOG.md b/CHANGE-LOG.md index 57116d0..0766351 100644 --- a/CHANGE-LOG.md +++ b/CHANGE-LOG.md @@ -6,6 +6,8 @@ - Upgrade bcpkix-jdkon15 dependency to bcpkix-jdkon18 2.1.1 - Upgrade paimon to 0.8.1 + 2.1.2 +- Upgrade paimon to 0.9.0 ### 2.0 2.0.0 - upgrade avro to 1.11.3 diff --git a/hive-catalog-shade/pom.xml b/hive-catalog-shade/pom.xml index 6100968..a0db9da 100644 --- a/hive-catalog-shade/pom.xml +++ b/hive-catalog-shade/pom.xml @@ -20,7 +20,7 @@ under the License. org.apache.doris doris-shade -2.1.0-SNAPSHOT +2.1.2-SNAPSHOT hive-catalog-shade @@ -31,7 +31,7 @@ under the License. 3.3.6 2.8.1 1.4.3 -0.8.1 +0.9.0 1.11.3 2.5.2 1.13.1 diff --git a/pom.xml b/pom.xml index a3f629f..5fe021b 100644 --- a/pom.xml +++ b/pom.xml @@ -24,7 +24,7 @@ under the License. org.apache.doris doris-shade -2.1.0-SNAPSHOT +2.1.2-SNAPSHOT pom Archetype - doris-shade https://doris.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](schema change)fix schema change cause load failed due to err -215 [doris]
DarvenDuan commented on PR #23836: URL: https://github.com/apache/doris/pull/23836#issuecomment-2406423677 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Bump org.apache.avro:avro from 1.11.3 to 1.11.4 in /hive-catalog-shade [doris-shade]
CalvinKirs merged PR #49: URL: https://github.com/apache/doris-shade/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-shade) branch master updated: Bump org.apache.avro:avro from 1.11.3 to 1.11.4 in /hive-catalog-shade (#49)
This is an automated email from the ASF dual-hosted git repository. kirs pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris-shade.git The following commit(s) were added to refs/heads/master by this push: new e02ff0d Bump org.apache.avro:avro from 1.11.3 to 1.11.4 in /hive-catalog-shade (#49) e02ff0d is described below commit e02ff0da9d43325dcd8a30b36017ecc72d7823fb Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> AuthorDate: Fri Oct 11 10:33:01 2024 +0800 Bump org.apache.avro:avro from 1.11.3 to 1.11.4 in /hive-catalog-shade (#49) Bumps org.apache.avro:avro from 1.11.3 to 1.11.4. --- updated-dependencies: - dependency-name: org.apache.avro:avro dependency-type: direct:production ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- hive-catalog-shade/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hive-catalog-shade/pom.xml b/hive-catalog-shade/pom.xml index a0db9da..aec6a7c 100644 --- a/hive-catalog-shade/pom.xml +++ b/hive-catalog-shade/pom.xml @@ -32,7 +32,7 @@ under the License. 2.8.1 1.4.3 0.9.0 -1.11.3 +1.11.4 2.5.2 1.13.1 1.78.1 - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-shade) branch dependabot/maven/hive-catalog-shade/org.apache.avro-avro-1.11.4 updated (faeafe7 -> 859d46c)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/hive-catalog-shade/org.apache.avro-avro-1.11.4 in repository https://gitbox.apache.org/repos/asf/doris-shade.git discard faeafe7 Bump org.apache.avro:avro from 1.11.3 to 1.11.4 in /hive-catalog-shade add 1168dbd Upgrade paimon to 0.9.0 (#47) add 859d46c Bump org.apache.avro:avro from 1.11.3 to 1.11.4 in /hive-catalog-shade This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (faeafe7) \ N -- N -- N refs/heads/dependabot/maven/hive-catalog-shade/org.apache.avro-avro-1.11.4 (859d46c) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: CHANGE-LOG.md | 2 ++ hive-catalog-shade/pom.xml | 4 ++-- pom.xml| 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] bump 2.0 to 2.0.16-rc01 [doris]
dataroaring commented on PR #41686: URL: https://github.com/apache/doris/pull/41686#issuecomment-2406431303 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] bump 2.0 to 2.0.16-rc01 [doris]
dataroaring opened a new pull request, #41686: URL: https://github.com/apache/doris/pull/41686 ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-shade) branch dependabot/maven/hive-catalog-shade/org.apache.avro-avro-1.11.4 deleted (was 859d46c)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/hive-catalog-shade/org.apache.avro-avro-1.11.4 in repository https://gitbox.apache.org/repos/asf/doris-shade.git was 859d46c Bump org.apache.avro:avro from 1.11.3 to 1.11.4 in /hive-catalog-shade The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] bump 2.0 to 2.0.16-rc01 [doris]
doris-robot commented on PR #41686: URL: https://github.com/apache/doris/pull/41686#issuecomment-2406430951 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix] (inverted index) fix the error result in the query when using count on index (#41375) [doris]
csun5285 opened a new pull request, #41687: URL: https://github.com/apache/doris/pull/41687 ## Proposed changes pick from master #41375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (inverted index) fix the error result in the query when using count on index (#41375) [doris]
doris-robot commented on PR #41687: URL: https://github.com/apache/doris/pull/41687#issuecomment-2406433662 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (inverted index) fix the error result in the query when using count on index (#41375) [doris]
csun5285 commented on PR #41687: URL: https://github.com/apache/doris/pull/41687#issuecomment-2406433976 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](ExternalTable)Optimize the performance of getCachedRowCount when reading ExternalTable [doris]
hubgeter commented on PR #41659: URL: https://github.com/apache/doris/pull/41659#issuecomment-2406656441 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](information-meta) fix information column_type and data_type for ip/variant [doris]
yiguolei commented on PR #41666: URL: https://github.com/apache/doris/pull/41666#issuecomment-2406652688 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Export) `show export` statement supports specify the catalog name [doris]
BePPPower commented on PR #41662: URL: https://github.com/apache/doris/pull/41662#issuecomment-2406658012 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](compile) Fix control reaches end of non-void function [doris]
bobhan1 commented on PR #41692: URL: https://github.com/apache/doris/pull/41692#issuecomment-2406664184 run cloud_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-website) branch master updated: [pick] pick table overview from dev to 3.0 and 2.1 (#1180)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris-website.git
The following commit(s) were added to refs/heads/master by this push:
new 88d1aed3d0c [pick] pick table overview from dev to 3.0 and 2.1 (#1180)
88d1aed3d0c is described below
commit 88d1aed3d0c3c730f1e5f296dadb6df8c5cabe42
Author: Yongqiang YANG <98214048+dataroar...@users.noreply.github.com>
AuthorDate: Fri Oct 11 14:54:48 2024 +0800
[pick] pick table overview from dev to 3.0 and 2.1 (#1180)
# Versions
- [ ] dev
- [x] 3.0
- [x] 2.1
- [ ] 2.0
# Languages
- [x] Chinese
- [x] English
---
.../version-2.1/table-design/overview.md | 48 ++
.../version-3.0/table-design/overview.md | 48 ++
.../version-2.1/table-design/overview.md | 48 ++
.../version-3.0/table-design/overview.md | 48 ++
versioned_sidebars/version-2.1-sidebars.json | 23 ++-
versioned_sidebars/version-3.0-sidebars.json | 23 ++-
6 files changed, 216 insertions(+), 22 deletions(-)
diff --git
a/i18n/zh-CN/docusaurus-plugin-content-docs/version-2.1/table-design/overview.md
b/i18n/zh-CN/docusaurus-plugin-content-docs/version-2.1/table-design/overview.md
new file mode 100644
index 000..500e72c98ca
--- /dev/null
+++
b/i18n/zh-CN/docusaurus-plugin-content-docs/version-2.1/table-design/overview.md
@@ -0,0 +1,48 @@
+---
+{
+"title": "概览",
+"language": "zh-CN"
+}
+---
+
+
+
+## 创建表
+
+使用 [CREATE
TABLE](../sql-manual/sql-statements/Data-Definition-Statements/Create/CREATE-TABLE.md)
语句在 Doris 中创建一个表，也可以使用
[LIKE](../sql-manual/sql-statements/Data-Definition-Statements/Create/CREATE-TABLE-LIKE.md)
或
[AS](../sql-manual/sql-statements/Data-Definition-Statements/Create/CREATE-TABLE-AS-SELECT.md)
子句从另一个表派生表定义。
+
+## 表名
+
+Doris
中表名默认是大小写敏感的，可以在第一次初始化集群时配置[lower_case_table_names](../admin-manual/config/fe-config.md)为大小写不敏感的。默认的表名最大长度为
64
字节，可以通过配置[table_name_length_limit](../admin-manual/config/fe-config.md)更改，不建议配置过大。创建表的语法请参考[CREATE
TABLE](../sql-manual/sql-statements/Data-Definition-Statements/Create/CREATE-TABLE.md)。
+
+## 表属性
+
+Doris
的建表语句中可以指定[建表属性](../sql-manual/sql-statements/Data-Definition-Statements/Create/CREATE-TABLE.md#properties)，其中分桶数(buckets)、存储介质(storage_medium)、副本数(replication)、冷热分离存储策略(storage_policy)属性作用于分区，即分区创建之后，分区就会有自己的属性，修改表属性只对未来创建的分区生效，对已经创建好的分区不生效，关于属性更多的信息请参考[修改表属性](../sql-manual/sql-statements/Data-Definition-Statements/Alter/ALTER-TABLE-PROPERTY.md)
+
+
+## 注意事项
+
+1. 数据模型不可更改，因此建表时需要选择一个合适的[数据模型](../table-design/data-model/overview.md)。
+
+2. 已经创建的分区不能修改分桶数，可以通过[替换分区](../data-operate/delete/table-temp-partition.md)
来修改分桶数，可以修改动态分区未创建的分区分桶数。
+
+3. 加减 VALUE 列是轻量级实现，秒级别可以完成，加减 KEY 列或者修改数据类型是重量级操作，完成时间取决于数据量，大规模数据下尽量避免加减 KEY
列或者修改数据类型。
+
+4. 可以使用层级存储将冷数据保存到 HDD 或者 S3 / HDFS。
\ No newline at end of file
diff --git
a/i18n/zh-CN/docusaurus-plugin-content-docs/version-3.0/table-design/overview.md
b/i18n/zh-CN/docusaurus-plugin-content-docs/version-3.0/table-design/overview.md
new file mode 100644
index 000..500e72c98ca
--- /dev/null
+++
b/i18n/zh-CN/docusaurus-plugin-content-docs/version-3.0/table-design/overview.md
@@ -0,0 +1,48 @@
+---
+{
+"title": "概览",
+"language": "zh-CN"
+}
+---
+
+
+
+## 创建表
+
+使用 [CREATE
TABLE](../sql-manual/sql-statements/Data-Definition-Statements/Create/CREATE-TABLE.md)
语句在 Doris 中创建一个表，也可以使用
[LIKE](../sql-manual/sql-statements/Data-Definition-Statements/Create/CREATE-TABLE-LIKE.md)
或
[AS](../sql-manual/sql-statements/Data-Definition-Statements/Create/CREATE-TABLE-AS-SELECT.md)
子句从另一个表派生表定义。
+
+## 表名
+
+Doris
中表名默认是大小写敏感的，可以在第一次初始化集群时配置[lower_case_table_names](../admin-manual/config/fe-config.md)为大小写不敏感的。默认的表名最大长度为
64
字节，可以通过配置[table_name_length_limit](../admin-manual/config/fe-config.md)更改，不建议配置过大。创建表的语法请参考[CREATE
TABLE](../sql-manual/sql-statements/Data-Definition-Statements/Create/CREATE-TABLE.md)。
+
+## 表属性
+
+Doris
的建表语句中可以指定[建表属性](../sql-manual/sql-statements/Data-Definition-Statements/Create/CREATE-TABLE.md#properties)，其中分桶数(buckets)、存储介质(storage_medium)、副本数(replication)、冷热分离存储策略(storage_policy)属性作用于分区，即分区创建之后，分区就会有自己的属性，修改表属性只对未来创建的分区生效，对已经创建好的分区不生效，关于属性更多的信息请参考[修改表属性](../sql-manual/sql-statements/Data-Definition-Statements/Alter/ALTER-TABLE-PROPERTY.md)
+
+
+## 注意事项
+
+1. 数据模型不可更改，因此建表时需要选择一个合适的[数据模型](../table-design/data-model/overview.md)。
+
+2. 已经创建的分区不能修改分桶数，可以通过[替换分区](../data-operate/delete/table-temp-partition.md)
来修改分桶数，可以修改动态分区未创建的分区分桶数。
+
+3. 加减 VALUE 列是轻量级实现，秒级别可以完成，加减 KEY 列或者修改数据类型是重量级操作，完成时间取决于数据量，大规模数据下尽量避免加减 KEY
列或者修改数据类型。
+
+4. 可以使用层级存储将冷数据保存到 HDD 或者 S3 / HDFS。
\ No newline at end of file
diff --git a/versioned_docs/version-2.1/table-design/overview.md
b/versioned_docs/version-2.1/table-design/overview.md
new file mode 100644
ind
(doris-website) branch master updated: [fix](cloud) add download link for fdb_ctl.sh (#1185)
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris-website.git The following commit(s) were added to refs/heads/master by this push: new 41854d0c8ae [fix](cloud) add download link for fdb_ctl.sh (#1185) 41854d0c8ae is described below commit 41854d0c8ae88f3529d02631455e9ca5b0763822 Author: Yongqiang YANG <98214048+dataroar...@users.noreply.github.com> AuthorDate: Fri Oct 11 14:54:00 2024 +0800 [fix](cloud) add download link for fdb_ctl.sh (#1185) # Versions - [x] dev - [x] 3.0 - [ ] 2.1 - [ ] 2.0 # Languages - [x] Chinese - [x] English --- docs/compute-storage-decoupled/before-deployment.md | 2 +- .../current/compute-storage-decoupled/before-deployment.md | 2 +- .../version-3.0/compute-storage-decoupled/before-deployment.md | 2 +- .../version-3.0/compute-storage-decoupled/before-deployment.md | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/compute-storage-decoupled/before-deployment.md b/docs/compute-storage-decoupled/before-deployment.md index b61b356ee48..57eee697749 100644 --- a/docs/compute-storage-decoupled/before-deployment.md +++ b/docs/compute-storage-decoupled/before-deployment.md @@ -66,7 +66,7 @@ When machine configurations are high, consider mixing FDB, FE, and Meta Service, ### 5.1. Install FoundationDB -This section provides a step-by-step guide to configure, deploy, and start the FoundationDB (FDB) service using the provided scripts `fdb_vars.sh` and `fdb_ctl.sh`. +This section provides a step-by-step guide to configure, deploy, and start the FoundationDB (FDB) service using the provided scripts `fdb_vars.sh` and `fdb_ctl.sh`. You can download [doris tools](http://apache-doris-releases.oss-accelerate.aliyuncs.com/apache-doris-3.0.2-tools.tar.gz) and get `fdb_vars.sh` and `fdb_ctl.sh` from `fdb` directory. 5.1 Machine Requirements diff --git a/i18n/zh-CN/docusaurus-plugin-content-docs/current/compute-storage-decoupled/before-deployment.md b/i18n/zh-CN/docusaurus-plugin-content-docs/current/compute-storage-decoupled/before-deployment.md index 1307a6e2fd6..b255858ab6f 100644 --- a/i18n/zh-CN/docusaurus-plugin-content-docs/current/compute-storage-decoupled/before-deployment.md +++ b/i18n/zh-CN/docusaurus-plugin-content-docs/current/compute-storage-decoupled/before-deployment.md @@ -68,7 +68,7 @@ Doris 存算分离架构包含三个主要模块： ### 5.1. 安装 FoundationDB -本节提供了脚本 `fdb_vars.sh` 和 `fdb_ctl.sh` 配置、部署和启动 FDB（FoundationDB）服务的分步指南。 +本节提供了脚本 `fdb_vars.sh` 和 `fdb_ctl.sh` 配置、部署和启动 FDB（FoundationDB）服务的分步指南。您可以下载 [doris tools](http://apache-doris-releases.oss-accelerate.aliyuncs.com/apache-doris-3.0.2-tools.tar.gz) 并从 `fdb` 目录获取 `fdb_vars.sh` 和 `fdb_ctl.sh`。 5.1 机器要求 diff --git a/i18n/zh-CN/docusaurus-plugin-content-docs/version-3.0/compute-storage-decoupled/before-deployment.md b/i18n/zh-CN/docusaurus-plugin-content-docs/version-3.0/compute-storage-decoupled/before-deployment.md index 1307a6e2fd6..b255858ab6f 100644 --- a/i18n/zh-CN/docusaurus-plugin-content-docs/version-3.0/compute-storage-decoupled/before-deployment.md +++ b/i18n/zh-CN/docusaurus-plugin-content-docs/version-3.0/compute-storage-decoupled/before-deployment.md @@ -68,7 +68,7 @@ Doris 存算分离架构包含三个主要模块： ### 5.1. 安装 FoundationDB -本节提供了脚本 `fdb_vars.sh` 和 `fdb_ctl.sh` 配置、部署和启动 FDB（FoundationDB）服务的分步指南。 +本节提供了脚本 `fdb_vars.sh` 和 `fdb_ctl.sh` 配置、部署和启动 FDB（FoundationDB）服务的分步指南。您可以下载 [doris tools](http://apache-doris-releases.oss-accelerate.aliyuncs.com/apache-doris-3.0.2-tools.tar.gz) 并从 `fdb` 目录获取 `fdb_vars.sh` 和 `fdb_ctl.sh`。 5.1 机器要求 diff --git a/versioned_docs/version-3.0/compute-storage-decoupled/before-deployment.md b/versioned_docs/version-3.0/compute-storage-decoupled/before-deployment.md index b61b356ee48..57eee697749 100644 --- a/versioned_docs/version-3.0/compute-storage-decoupled/before-deployment.md +++ b/versioned_docs/version-3.0/compute-storage-decoupled/before-deployment.md @@ -66,7 +66,7 @@ When machine configurations are high, consider mixing FDB, FE, and Meta Service, ### 5.1. Install FoundationDB -This section provides a step-by-step guide to configure, deploy, and start the FoundationDB (FDB) service using the provided scripts `fdb_vars.sh` and `fdb_ctl.sh`. +This section provides a step-by-step guide to configure, deploy, and start the FoundationDB (FDB) service using the provided scripts `fdb_vars.sh` and `fdb_ctl.sh`. You can download [doris tools](http://apache-doris-releases.oss-accelerate.aliyuncs.com/apache-doris-3.0.2-tools.tar.gz) and get `fdb_vars.sh` and `fdb_ctl.sh` from `fdb` directory. 5.1 Machine Requirements - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: co
Re: [PR] [fix](cloud) add download link for fdb_ctl.sh [doris-website]
dataroaring merged PR #1185: URL: https://github.com/apache/doris-website/pull/1185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pick] pick table overview from dev to 3.0 and 2.1 [doris-website]
dataroaring merged PR #1180: URL: https://github.com/apache/doris-website/pull/1180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.0 updated: bump 2.0 to 2.0.16-rc01 (#41686)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.0 by this push:
new ca6c4c49dd6 bump 2.0 to 2.0.16-rc01 (#41686)
ca6c4c49dd6 is described below
commit ca6c4c49dd613101a70067cbbd392faa6eca8590
Author: Yongqiang YANG <98214048+dataroar...@users.noreply.github.com>
AuthorDate: Fri Oct 11 14:56:30 2024 +0800
bump 2.0 to 2.0.16-rc01 (#41686)
---
gensrc/script/gen_build_version.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gensrc/script/gen_build_version.sh
b/gensrc/script/gen_build_version.sh
index 25644824cd2..f44b2a00124 100755
--- a/gensrc/script/gen_build_version.sh
+++ b/gensrc/script/gen_build_version.sh
@@ -30,8 +30,8 @@ set -eo pipefail
build_version_prefix="doris"
build_version_major=2
build_version_minor=0
-build_version_patch=15
-build_version_rc_version=""
+build_version_patch=16
+build_version_rc_version="rc01"
if [[ -z "${build_version_rc_version}" ]]; then
build_version="${build_version_prefix}-${build_version_major}.${build_version_minor}.${build_version_patch}"
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] bump 2.0 to 2.0.16-rc01 [doris]
dataroaring merged PR #41686: URL: https://github.com/apache/doris/pull/41686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) tag 2.0.16-rc01 created (now ca6c4c49dd6)
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a change to tag 2.0.16-rc01 in repository https://gitbox.apache.org/repos/asf/doris.git at ca6c4c49dd6 (commit) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nerieds) column prune should retain at least one column for union all [doris]
morrySnow merged PR #41613: URL: https://github.com/apache/doris/pull/41613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Nereids) ignore match expression logging warning message [doris]
morrySnow commented on code in PR #41546:
URL: https://github.com/apache/doris/pull/41546#discussion_r1796374347
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/FoldConstantRuleOnBE.java:
##
@@ -264,7 +261,7 @@ private static boolean shouldSkipFold(Expression expr) {
// This kind of function is often used to change the attributes of
columns.
// Folding will make it impossible to construct columns such as
nullable(1).
-if (expr instanceof Nullable || expr instanceof NonNullable) {
+if (expr.containsType(Nullable.class) ||
expr.containsType(NonNullable.class)) {
Review Comment:
this will traverse expr tree too many times, could we only traverse once by
`expr.anyMatch(e -> shouldSkipFold(e))` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Fix](compile) Fix control reaches end of non-void function [doris]
bobhan1 opened a new pull request, #41692: URL: https://github.com/apache/doris/pull/41692 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](shuffle) Reduce memory consumption in data stream sender [doris]
github-actions[bot] commented on PR #41676: URL: https://github.com/apache/doris/pull/41676#issuecomment-2406486446 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (inverted index) fix the error result in the query when using count on index (#41375) [doris]
doris-robot commented on PR #41687: URL: https://github.com/apache/doris/pull/41687#issuecomment-2406485670 TPC-H: Total hot run time: 48866 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 40d63472d885a9763ad0b87c73bd15af2df1676f, data reload: false -- Round 1 -- q1 17727 438043464346 q2 2084152 142 142 q3 10268 192019151915 q4 10363 122112971221 q5 8826390238973897 q6 238 120 121 120 q7 2002164215911591 q8 9276273827052705 q9 10164 982197499749 q10 8616353834913491 q11 408 254 258 254 q12 464 292 292 292 q13 18383 394740543947 q14 348 325 329 325 q15 511 467 454 454 q16 536 455 452 452 q17 1125971 933 933 q18 7258677968706779 q19 1668157414911491 q20 539 301 311 301 q21 4361418940744074 q22 487 397 387 387 Total cold run time: 115652 ms Total hot run time: 48866 ms - Round 2, with runtime_filter_mode=off - q1 4276428343184283 q2 325 228 224 224 q3 4222419141434143 q4 2746274927542749 q5 7132705471507054 q6 234 118 117 117 q7 3245287528592859 q8 4356447444714471 q9 13693 13474 13598 13474 q10 4227424742364236 q11 768 696 698 696 q12 1020861 858 858 q13 7046378237363736 q14 454 425 431 425 q15 493 460 460 460 q16 625 588 590 588 q17 3821390138433843 q18 8785876487998764 q19 1724166816461646 q20 2357212621152115 q21 8428843184498431 q22 1020943 959 943 Total cold run time: 80997 ms Total hot run time: 76115 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](compile) Fix control reaches end of non-void function [doris]
github-actions[bot] commented on PR #41692: URL: https://github.com/apache/doris/pull/41692#issuecomment-2406484704 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](compile) Fix control reaches end of non-void function [doris]
github-actions[bot] commented on PR #41692: URL: https://github.com/apache/doris/pull/41692#issuecomment-2406484674 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](compile) Fix control reaches end of non-void function [doris]
zhannngchen commented on code in PR #41692:
URL: https://github.com/apache/doris/pull/41692#discussion_r1796378450
##
be/src/olap/partial_update_info.h:
##
@@ -66,6 +66,7 @@ struct PartialUpdateInfo {
case UniqueKeyUpdateModePB::UPDATE_FLEXIBLE_COLUMNS:
return "flexible partial update";
}
+return "";
Review Comment:
```suggestion
switch () {
case xx:
// do sth.
case yy:
// do sth.
default:
return "";
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
