Re: [PR] [opt](nereids) when table.rows > topn.limit+topn.offset, do not generate topn-filter [doris]
englefly commented on PR #40480: URL: https://github.com/apache/doris/pull/40480#issuecomment-2342818474 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cluster key) fix mow cluster key with schema change [doris]
mymeiyi commented on PR #40372: URL: https://github.com/apache/doris/pull/40372#issuecomment-2342797195 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](iot) Fix unexpected error when iot auto detect get no data [doris]
github-actions[bot] commented on PR #40657: URL: https://github.com/apache/doris/pull/40657#issuecomment-2342796295 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) fix the issue that FE's periodic reconnection to MS RPC is ineffective [doris]
doris-robot commented on PR #40661: URL: https://github.com/apache/doris/pull/40661#issuecomment-2342823741 TPC-H: Total hot run time: 38116 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit a97bb8dec4007fb0d56b8eca30b74850e819dea4, data reload: false -- Round 1 -- q1 17613 439542964296 q2 2021188 200 188 q3 10439 122711141114 q4 10156 770 758 758 q5 7726287528292829 q6 226 138 136 136 q7 951 633 597 597 q8 9327208620632063 q9 7004655965486548 q10 7013217422732174 q11 446 242 244 242 q12 419 221 226 221 q13 18841 308431223084 q14 289 233 242 233 q15 552 482 472 472 q16 516 455 435 435 q17 976 658 685 658 q18 7387695268026802 q19 1394108311561083 q20 686 330 340 330 q21 3931295228412841 q22 101510121012 Total cold run time: 109024 ms Total hot run time: 38116 ms - Round 2, with runtime_filter_mode=off - q1 4389455843554355 q2 390 281 278 278 q3 2908266326612661 q4 1975168916851685 q5 5419542154355421 q6 222 131 131 131 q7 2085174917691749 q8 3265337333353335 q9 8447843284628432 q10 3462320732263207 q11 624 506 504 504 q12 810 623 628 623 q13 16205 308931323089 q14 300 279 272 272 q15 527 488 485 485 q16 538 491 472 472 q17 1799150514741474 q18 7723746175947461 q19 1663148914391439 q20 2060184418291829 q21 5503526853855268 q22 1118103910171017 Total cold run time: 71432 ms Total hot run time: 55187 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] add low memory mode in scan operator [doris]
yiguolei merged PR #40662: URL: https://github.com/apache/doris/pull/40662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [enhancement](nereids)support subquery in LogicalGenerator [doris]
starocean999 opened a new pull request, #40663: URL: https://github.com/apache/doris/pull/40663 ## Proposed changes select e1 from (select 1) t lateral view explode(**(select sequence(CURRENT_DATE(), date_add(CURRENT_DATE(), interval 2 day)))**) t2 as e1; The **subquery** in explode is supported by this pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [chore](ci) tmp remove required of Clang Formatter on branch-2.0 [doris]
hello-stephen opened a new pull request, #40664: URL: https://github.com/apache/doris/pull/40664 ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](ci) tmp remove required of Clang Formatter on branch-2.0 [doris]
doris-robot commented on PR #40664: URL: https://github.com/apache/doris/pull/40664#issuecomment-2342828502 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) fix the issue that FE's periodic reconnection to MS RPC is ineffective [doris]
luwei16 commented on PR #40661: URL: https://github.com/apache/doris/pull/40661#issuecomment-2342785483 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids)support correlated scalar subquery without scalar agg [doris]
doris-robot commented on PR #39471: URL: https://github.com/apache/doris/pull/39471#issuecomment-2342828829 ClickBench: Total hot run time: 31.89 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit ccdf83c22740b770151fdc8c81958862b3ef0e8b, data reload: false query1 0.050.040.04 query2 0.080.040.04 query3 0.220.050.06 query4 1.660.080.09 query5 0.490.490.49 query6 1.130.740.74 query7 0.020.010.01 query8 0.050.040.05 query9 0.540.480.47 query10 0.540.550.52 query11 0.150.120.12 query12 0.150.120.12 query13 0.620.590.58 query14 1.391.411.43 query15 0.850.840.83 query16 0.370.360.36 query17 1.071.060.97 query18 0.210.210.22 query19 1.861.751.81 query20 0.010.010.01 query21 15.39 0.660.66 query22 3.607.382.25 query23 18.24 1.371.34 query24 2.160.220.23 query25 0.140.090.08 query26 0.250.180.17 query27 0.080.080.07 query28 13.24 1.041.01 query29 12.61 3.343.32 query30 0.250.060.05 query31 2.870.400.40 query32 3.250.490.48 query33 2.973.033.04 query34 17.07 4.444.40 query35 4.534.504.48 query36 0.650.500.49 query37 0.200.160.15 query38 0.150.150.16 query39 0.050.040.04 query40 0.160.130.13 query41 0.090.050.05 query42 0.060.040.05 query43 0.050.040.04 Total cold run time: 109.52 s Total hot run time: 31.89 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](systable) fix unstable case for partitions table [doris]
doris-robot commented on PR #40553: URL: https://github.com/apache/doris/pull/40553#issuecomment-2342828942 ClickBench: Total hot run time: 31.97 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit f5f7a1193d6c7303b92927ff3c630cb84448cb29, data reload: false query1 0.050.050.04 query2 0.090.040.03 query3 0.220.050.06 query4 1.660.080.08 query5 0.520.520.50 query6 1.130.740.73 query7 0.020.010.01 query8 0.050.040.04 query9 0.540.500.50 query10 0.550.570.56 query11 0.150.110.11 query12 0.150.130.12 query13 0.600.580.59 query14 1.411.411.38 query15 0.830.830.81 query16 0.380.370.38 query17 1.030.961.06 query18 0.210.210.21 query19 1.971.891.86 query20 0.010.010.01 query21 15.38 0.670.65 query22 4.066.762.45 query23 18.24 1.331.29 query24 2.090.240.21 query25 0.160.080.08 query26 0.270.180.17 query27 0.080.080.07 query28 13.27 1.021.00 query29 12.58 3.303.31 query30 0.230.060.05 query31 2.870.400.39 query32 3.260.480.48 query33 3.002.953.01 query34 17.21 4.374.46 query35 4.504.554.52 query36 0.650.460.46 query37 0.180.160.15 query38 0.160.140.15 query39 0.060.040.04 query40 0.160.120.12 query41 0.090.050.05 query42 0.060.050.05 query43 0.040.040.03 Total cold run time: 110.17 s Total hot run time: 31.97 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) fix routine load job stuck if commit transaction failed [doris]
dataroaring merged PR #40539: URL: https://github.com/apache/doris/pull/40539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](cloud) manage node via sql like non cloud mode [doris]
yujun777 commented on code in PR #40264: URL: https://github.com/apache/doris/pull/40264#discussion_r1753318413 ## docker/runtime/doris-compose/cluster.py: ## @@ -390,15 +402,22 @@ def get_add_init_config(self): cfg += self.cluster.fe_config if self.cluster.is_cloud: cfg += [ -"cloud_unique_id = " + self.cloud_unique_id(), "meta_service_endpoint = {}".format( -self.cluster.get_meta_server_addr()), -"", +self.cluster.get_meta_server_addr()), "", "# For regression-test", "ignore_unsupported_properties_in_cloud_mode = true", "merge_on_write_forced_to_false = true", +"deploy_mode = cloud" ] +if self.cluster.sql_mode_node_mgr: Review Comment: 413 ~ 420 行向右缩进, 跟404 行对齐 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](hive) support null_format and escape_char for hive text [doris]
suxiaogang223 commented on PR #40291: URL: https://github.com/apache/doris/pull/40291#issuecomment-2342794916 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] add low memory mode in scan operator [doris]
github-actions[bot] commented on PR #40662: URL: https://github.com/apache/doris/pull/40662#issuecomment-2342831380 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](cloud) manage node via sql like non cloud mode [doris]
yujun777 commented on code in PR #40264: URL: https://github.com/apache/doris/pull/40264#discussion_r1753324123 ## docker/runtime/doris-compose/command.py: ## @@ -297,6 +297,45 @@ def add_parser(self, args_parsers): default="", help="Set code coverage output directory") +parser.add_argument("--sql-mode-node-mgr", +default=False, +action=self._get_parser_bool_action(True), +help="Manager fe be via sql instead of http") + +if self._support_boolean_action(): +parser.add_argument( +"--be-metaservice-endpoint", +default=True, +action=self._get_parser_bool_action(True), +help= +"Do not set BE meta service endpoint in conf. Default is False." +) +else: +parser.add_argument( +"--no-be-metaservice-endpoint", +dest='be-metaservice-endpoint', +default=True, +action=self._get_parser_bool_action(True), Review Comment: True -> False -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](cloud) manage node via sql like non cloud mode [doris]
yujun777 commented on code in PR #40264: URL: https://github.com/apache/doris/pull/40264#discussion_r1753325819 ## docker/runtime/doris-compose/command.py: ## @@ -297,6 +297,45 @@ def add_parser(self, args_parsers): default="", help="Set code coverage output directory") +parser.add_argument("--sql-mode-node-mgr", +default=False, +action=self._get_parser_bool_action(True), +help="Manager fe be via sql instead of http") + +if self._support_boolean_action(): +parser.add_argument( +"--be-metaservice-endpoint", +default=True, +action=self._get_parser_bool_action(True), +help= +"Do not set BE meta service endpoint in conf. Default is False." Review Comment: Do set BE meta service endpoint in conf. Default is True. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](audit) let line comment work well [doris]
yiguolei merged PR #40602: URL: https://github.com/apache/doris/pull/40602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](cloud) manage node via sql like non cloud mode [doris]
yujun777 commented on code in PR #40264: URL: https://github.com/apache/doris/pull/40264#discussion_r1753329387 ## docker/runtime/doris-compose/command.py: ## @@ -297,6 +297,45 @@ def add_parser(self, args_parsers): default="", help="Set code coverage output directory") +parser.add_argument("--sql-mode-node-mgr", +default=False, +action=self._get_parser_bool_action(True), +help="Manager fe be via sql instead of http") + +if self._support_boolean_action(): +parser.add_argument( +"--be-metaservice-endpoint", +default=True, +action=self._get_parser_bool_action(True), +help= +"Do not set BE meta service endpoint in conf. Default is False." +) +else: +parser.add_argument( +"--no-be-metaservice-endpoint", +dest='be-metaservice-endpoint', +default=True, +action=self._get_parser_bool_action(True), +help= +"Do not set BE meta service endpoint in conf. Default is False." +) + +if self._support_boolean_action(): +parser.add_argument( +"--be-cloud-instanceid", +default=True, +action=self._get_parser_bool_action(True), +help= +"Do not set BE cloud instance ID in conf. Default is False.") Review Comment: Do set BE cloud instance ID in conf. Default is True. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](transaction) commit txn check txn status [doris]
doris-robot commented on PR #40064: URL: https://github.com/apache/doris/pull/40064#issuecomment-2342835501 ClickBench: Total hot run time: 31.37 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit c4ecdbb9116e803fa04227dc2d92b5ee9aed2044, data reload: false query1 0.050.040.05 query2 0.070.040.04 query3 0.230.060.06 query4 1.650.080.11 query5 0.540.490.51 query6 1.120.730.72 query7 0.030.010.01 query8 0.040.040.04 query9 0.540.490.48 query10 0.530.570.53 query11 0.150.120.11 query12 0.140.120.12 query13 0.610.600.59 query14 1.361.411.41 query15 0.840.850.86 query16 0.370.370.37 query17 1.070.981.06 query18 0.210.200.20 query19 1.821.811.87 query20 0.010.010.01 query21 15.40 0.670.67 query22 4.038.141.72 query23 18.31 1.371.30 query24 2.150.220.21 query25 0.140.080.08 query26 0.280.180.18 query27 0.080.070.07 query28 13.25 1.041.04 query29 12.64 3.343.32 query30 0.240.060.05 query31 2.860.420.40 query32 3.230.480.49 query33 2.983.023.02 query34 17.01 4.404.39 query35 4.454.434.46 query36 0.660.490.50 query37 0.180.150.15 query38 0.150.140.15 query39 0.040.030.04 query40 0.150.140.13 query41 0.090.040.05 query42 0.060.050.05 query43 0.050.040.04 Total cold run time: 109.81 s Total hot run time: 31.37 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)build agg for random distributed agg table in bindRelation phase [doris]
doris-robot commented on PR #40181: URL: https://github.com/apache/doris/pull/40181#issuecomment-2342798320 TPC-H: Total hot run time: 38111 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 4614578455bb676cbe1f3a36086fa00496622b0a, data reload: false -- Round 1 -- q1 17624 443143104310 q2 2022202 179 179 q3 11727 101112091011 q4 10511 775 792 775 q5 7736284727582758 q6 226 134 134 134 q7 956 640 612 612 q8 9328205620532053 q9 7303653765556537 q10 6998225321942194 q11 490 248 241 241 q12 390 225 218 218 q13 17763 303730613037 q14 289 251 247 247 q15 543 494 482 482 q16 529 432 434 432 q17 973 714 616 616 q18 7343681869846818 q19 1387102610871026 q20 667 335 343 335 q21 3908318030713071 q22 1090102510321025 Total cold run time: 109803 ms Total hot run time: 38111 ms - Round 2, with runtime_filter_mode=off - q1 4445429342774277 q2 382 263 281 263 q3 2879269626772677 q4 1933163116261626 q5 5615568257245682 q6 240 141 138 138 q7 2220184918111811 q8 3313343834413438 q9 8846888687908790 q10 3602341733793379 q11 616 514 516 514 q12 835 656 660 656 q13 13830 338532023202 q14 324 295 297 295 q15 540 490 494 490 q16 524 489 487 487 q17 1850154915011501 q18 8172788680337886 q19 1734153714391439 q20 2149192618971897 q21 5707555954195419 q22 1127102110141014 Total cold run time: 70883 ms Total hot run time: 56881 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (8e37fb46185 -> 36828f2994e)
This is an automated email from the ASF dual-hosted git repository. panxiaolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 8e37fb46185 [fix](cloud) fix routine load job stuck if commit transaction failed (#40539) add 36828f2994e [Fix](load) fix wrong replica number when loading to table with no partition (#40635) No new revisions were added by this update. Summary of changes: .../src/main/java/org/apache/doris/planner/OlapTableSink.java | 6 +- .../src/test/java/org/apache/doris/planner/OlapTableSinkTest.java | 6 -- 2 files changed, 1 insertion(+), 11 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](ci) tmp remove required of Clang Formatter on branch-2.0 [doris]
github-actions[bot] commented on PR #40664: URL: https://github.com/apache/doris/pull/40664#issuecomment-2342837132 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](systable) fix unstable case for partitions table [doris]
doris-robot commented on PR #40553: URL: https://github.com/apache/doris/pull/40553#issuecomment-2342819108 TPC-DS: Total hot run time: 198044 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit f5f7a1193d6c7303b92927ff3c630cb84448cb29, data reload: false query1 1272883 921 883 query2 6337191519421915 query3 10764 398843003988 query4 60090 28679 23360 23360 query5 4998482 505 482 query6 398 186 175 175 query7 5657316 304 304 query8 321 221 226 221 query9 7581250824972497 query10 430 285 267 267 query11 15880 15179 15335 15179 query12 158 112 113 112 query13 1461408 381 381 query14 10693 718573367185 query15 203 172 168 168 query16 6833471 499 471 query17 1094568 569 568 query18 1508292 320 292 query19 191 147 166 147 query20 121 107 106 106 query21 209 106 103 103 query22 4894444146454441 query23 34354 33525 33491 33491 query24 5975283628662836 query25 505 387 380 380 query26 602 157 152 152 query27 1596272 276 272 query28 3754203620162016 query29 641 406 411 406 query30 239 154 152 152 query31 922 737 765 737 query32 69 55 52 52 query33 406 291 280 280 query34 871 484 494 484 query35 845 728 732 728 query36 1079904 932 904 query37 143 84 85 84 query38 4001386939113869 query39 1466142314331423 query40 196 115 114 114 query41 47 47 46 46 query42 115 97 97 97 query43 500 466 469 466 query44 1082753 742 742 query45 194 165 161 161 query46 1088746 725 725 query47 1917183618271827 query48 364 302 304 302 query49 784 440 432 432 query50 819 414 417 414 query51 6953697869196919 query52 98 86 87 86 query53 248 176 175 175 query54 562 456 456 456 query55 74 78 77 77 query56 284 263 262 262 query57 1207108610931086 query58 223 239 231 231 query59 3123288028152815 query60 305 277 281 277 query61 131 130 126 126 query62 746 653 646 646 query63 220 185 187 185 query64 1436790 740 740 query65 3228321232253212 query66 679 357 361 357 query67 16650 15512 15402 15402 query68 1951842 846 842 query69 450 327 325 325 query70 1203120511621162 query71 348 339 341 339 query72 4779361236993612 query73 582 579 579 579 query74 9057885089688850 query75 3078295729972957 query76 956 825 827 825 query77 508 415 415 415 query78 920092639200 query79 888 880 848 848 query80 929 831 776 776 query81 456 263 257 257 query82 263 265 260 260 query83 183 182 186 182 query84 196 108 105 105 query85 629 389 377 377 query86 308 335 300 300 query87 4418427343024273 query88 4316411441014101 query89 363 366 364 364 query90 1512313 304 304 query91 121 123 123 123 query92 78 72 74 72 query93 887 890 888 888 query94 531 350 357 350 query95 418 406 406 406 query96 463 467 469 467 query97 3113308931403089 query98 232 231 237 231 query99 1286127613141276 Total cold run time: 296335 ms Total hot run time: 198044 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
[PR] add low memory mode in scan operator [doris]
yiguolei opened a new pull request, #40662: URL: https://github.com/apache/doris/pull/40662 ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](transaction) commit txn check txn status [doris]
doris-robot commented on PR #40064: URL: https://github.com/apache/doris/pull/40064#issuecomment-2342805491 TPC-H: Total hot run time: 38093 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit c4ecdbb9116e803fa04227dc2d92b5ee9aed2044, data reload: false -- Round 1 -- q1 17600 434843394339 q2 2028190 189 189 q3 11793 966 1180966 q4 10520 657 751 657 q5 7730287628322832 q6 227 143 143 143 q7 969 618 595 595 q8 9332208420712071 q9 7350655865766558 q10 7024218222612182 q11 467 246 246 246 q12 390 223 229 223 q13 19025 308231043082 q14 280 239 242 239 q15 534 491 495 491 q16 533 443 434 434 q17 987 733 780 733 q18 7226685868566856 q19 1383951 951 951 q20 671 332 343 332 q21 3990302329622962 q22 1120102310121012 Total cold run time: 79 ms Total hot run time: 38093 ms - Round 2, with runtime_filter_mode=off - q1 4338430744344307 q2 388 274 270 270 q3 2869266726392639 q4 1950166116751661 q5 5714568958385689 q6 224 131 137 131 q7 2281186318211821 q8 3296349535323495 q9 8936883289158832 q10 3618338333993383 q11 621 522 512 512 q12 837 667 659 659 q13 15662 327932813279 q14 331 284 307 284 q15 542 500 499 499 q16 559 488 517 488 q17 1864155715661557 q18 8140783278907832 q19 1734163615581558 q20 2190191219441912 q21 5832555955585558 q22 1126103910641039 Total cold run time: 73052 ms Total hot run time: 57405 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)build agg for random distributed agg table in bindRelation phase [doris]
doris-robot commented on PR #40181: URL: https://github.com/apache/doris/pull/40181#issuecomment-2342818457 TPC-DS: Total hot run time: 197162 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 4614578455bb676cbe1f3a36086fa00496622b0a, data reload: false query1 1249905 911 905 query2 6339197819391939 query3 10616 402639963996 query4 60045 26800 23209 23209 query5 5140500 494 494 query6 398 176 158 158 query7 5642310 302 302 query8 311 218 218 218 query9 7728250524962496 query10 418 275 260 260 query11 17372 15051 15371 15051 query12 150 107 115 107 query13 1486419 390 390 query14 10745 713767216721 query15 220 187 180 180 query16 6598495 460 460 query17 1087572 564 564 query18 1470291 290 290 query19 196 152 143 143 query20 123 114 114 114 query21 211 108 105 105 query22 4698447546724475 query23 34339 33476 33436 33436 query24 6118287628652865 query25 503 405 416 405 query26 617 160 158 158 query27 1600282 283 282 query28 3821203019941994 query29 661 432 428 428 query30 240 156 157 156 query31 959 780 768 768 query32 73 54 56 54 query33 436 300 298 298 query34 871 471 468 468 query35 845 737 747 737 query36 1092950 949 949 query37 148 85 87 85 query38 4002391239333912 query39 1459141414071407 query40 197 116 115 115 query41 49 51 47 47 query42 119 98 96 96 query43 523 488 479 479 query44 1099753 745 745 query45 197 167 170 167 query46 1081738 750 738 query47 1909179318201793 query48 374 309 297 297 query49 776 443 455 443 query50 835 416 441 416 query51 7057681968646819 query52 103 86 90 86 query53 253 183 188 183 query54 575 462 474 462 query55 76 72 77 72 query56 281 269 274 269 query57 1223108311051083 query58 301 234 230 230 query59 3071279227382738 query60 292 268 270 268 query61 100 101 98 98 query62 737 655 643 643 query63 221 181 186 181 query64 1383681 661 661 query65 3254316031863160 query66 646 357 340 340 query67 15730 15534 15363 15363 query68 2112844 836 836 query69 441 348 315 315 query70 1156120611321132 query71 348 343 345 343 query72 4589351535443515 query73 587 576 575 575 query74 9123888588718871 query75 3065294829442944 query76 934 836 831 831 query77 536 394 401 394 query78 9591921410165 9214 query79 884 864 853 853 query80 770 799 797 797 query81 451 262 270 262 query82 274 260 261 260 query83 186 185 236 185 query84 187 108 103 103 query85 620 388 380 380 query86 314 320 312 312 query87 4269434843324332 query88 4287411541204115 query89 370 362 364 362 query90 1505311 305 305 query91 119 123 122 122 query92 76 72 74 72 query93 899 904 892 892 query94 512 388 337 337 query95 424 416 412 412 query96 467 468 473 468 query97 3157315631323132 query98 237 240 233 233 query99 1300129712871287 Total cold run time: 296278 ms Total hot run time: 197162 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
(doris) branch branch-2.0 updated: [branch-2.0] Fix case `test_delete_on_value` (#40644)
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch branch-2.0 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-2.0 by this push: new 9a54c27c802 [branch-2.0] Fix case `test_delete_on_value` (#40644) 9a54c27c802 is described below commit 9a54c27c802ae1ebe3f5643ed9518ae921a92760 Author: bobhan1 AuthorDate: Wed Sep 11 14:59:01 2024 +0800 [branch-2.0] Fix case `test_delete_on_value` (#40644) --- regression-test/suites/delete_p0/test_delete_on_value.groovy | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/regression-test/suites/delete_p0/test_delete_on_value.groovy b/regression-test/suites/delete_p0/test_delete_on_value.groovy index 353e3d64f76..5b04bff10f0 100644 --- a/regression-test/suites/delete_p0/test_delete_on_value.groovy +++ b/regression-test/suites/delete_p0/test_delete_on_value.groovy @@ -35,7 +35,8 @@ suite("test_delete_on_value") { DISTRIBUTED BY HASH(`x`) BUCKETS 4 PROPERTIES ( "replication_num" = "1", -"enable_unique_key_merge_on_write" = "true" +"enable_unique_key_merge_on_write" = "true", +"enable_mow_light_delete" = "false" );""" sql """ insert into ${tableName} values(1,1,1),(2,2,2),(3,3,3),(4,4,4),(5,5,5),(6,6,6),(7,7,7),(8,8,8),(9,9,9); """ qt_sql "select * from ${tableName} order by x,y,z;" @@ -92,6 +93,7 @@ suite("test_delete_on_value") { PROPERTIES ( "replication_num" = "1", "enable_unique_key_merge_on_write" = "true", +"enable_mow_light_delete" = "false", "function_column.sequence_col" = "z" );""" sql "insert into ${tableName3} values(1,1,10);" @@ -127,7 +129,8 @@ suite("test_delete_on_value") { DISTRIBUTED BY HASH(`x`) BUCKETS 4 PROPERTIES ( "replication_num" = "1", -"function_column.sequence_col" = "z" +"function_column.sequence_col" = "z", +"enable_mow_light_delete" = "false" );""" sql "insert into ${tableName4} values(1,1,10);" sql "insert into ${tableName4} values(1,1,5);" - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch spill_and_reserve updated: add low memory mode in scan operator (#40662)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch spill_and_reserve in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/spill_and_reserve by this push: new f3d4f8d98b3 add low memory mode in scan operator (#40662) f3d4f8d98b3 is described below commit f3d4f8d98b37725ace0d62f9678c92f696ba56f4 Author: yiguolei <676222...@qq.com> AuthorDate: Wed Sep 11 15:04:02 2024 +0800 add low memory mode in scan operator (#40662) ## Proposed changes Issue Number: close #xxx Co-authored-by: yiguolei --- be/src/pipeline/exec/operator.h| 2 + be/src/pipeline/pipeline_task.cpp | 1 + be/src/pipeline/task_scheduler.cpp | 3 +- be/src/runtime/query_context.h | 49 +++ .../workload_group/workload_group_manager.cpp | 10 +++ be/src/vec/exec/scan/scanner_context.cpp | 72 ++ be/src/vec/exec/scan/scanner_context.h | 16 - be/src/vec/exec/scan/scanner_scheduler.cpp | 9 ++- 8 files changed, 134 insertions(+), 28 deletions(-) diff --git a/be/src/pipeline/exec/operator.h b/be/src/pipeline/exec/operator.h index 265cf31f648..c6b49317375 100644 --- a/be/src/pipeline/exec/operator.h +++ b/be/src/pipeline/exec/operator.h @@ -198,6 +198,8 @@ public: void reset_estimate_memory_usage() { _estimate_memory_usage = 0; } +bool low_memory_mode() { return _state->get_query_ctx()->low_memory_mode(); } + protected: friend class OperatorXBase; diff --git a/be/src/pipeline/pipeline_task.cpp b/be/src/pipeline/pipeline_task.cpp index fe44f8a4b3f..8051bb5d4e6 100644 --- a/be/src/pipeline/pipeline_task.cpp +++ b/be/src/pipeline/pipeline_task.cpp @@ -388,6 +388,7 @@ Status PipelineTask::execute(bool* eos) { << ", sink name: " << _sink->get_name() << ", node id: " << _sink->node_id() << " failed: " << st.to_string() << ", debug info: " << GlobalMemoryArbitrator::process_mem_log_str(); +_state->get_query_ctx()->set_low_memory_mode(); bool is_high_wartermark = false; bool is_low_wartermark = false; workload_group->check_mem_used(&is_low_wartermark, &is_high_wartermark); diff --git a/be/src/pipeline/task_scheduler.cpp b/be/src/pipeline/task_scheduler.cpp index 715feceed98..30f3302d429 100644 --- a/be/src/pipeline/task_scheduler.cpp +++ b/be/src/pipeline/task_scheduler.cpp @@ -58,9 +58,8 @@ TaskScheduler::~TaskScheduler() { Status TaskScheduler::start() { int cores = _task_queue->cores(); -// Init the thread pool with cores+1 thread +// Init the thread pool with cores thread // some for pipeline task running -// 1 for spill disk query handler RETURN_IF_ERROR(ThreadPoolBuilder(_name) .set_min_threads(cores) .set_max_threads(cores) diff --git a/be/src/runtime/query_context.h b/be/src/runtime/query_context.h index eb2beb2ba05..fdbfc7c7217 100644 --- a/be/src/runtime/query_context.h +++ b/be/src/runtime/query_context.h @@ -264,6 +264,54 @@ public: } } +// Query will run in low memory mode when +// 1. the query is enable spill and wg's low water mark reached, if not release buffer, it will trigger spill disk, it is very expensive. +// 2. the query is not enable spill, but wg's high water mark reached, if not release buffer, the query will be cancelled. +// 3. the process reached soft mem_limit, if not release these, if not release buffer, the query will be cancelled. +// 4. If the query reserve memory failed. +// Under low memory mode, the query should release some buffers such as scan operator block queue, union operator queue, exchange buffer size, streaming agg +bool low_memory_mode() { +if (_low_memory_mode) { +return true; +} + +// If less than 100MB left, then it is low memory mode +if (doris::GlobalMemoryArbitrator::is_exceed_soft_mem_limit(100 * 1024 * 1024)) { +_low_memory_mode = true; +LOG(INFO) << "Query " << print_id(_query_id) + << " goes to low memory mode due to exceed process soft memory limit"; +return true; +} + +if (_workload_group) { +bool is_low_wartermark = false; +bool is_high_wartermark = false; +_workload_group->check_mem_used(&is_low_wartermark, &is_high_wartermark); +if (is_high_wartermark) { +LOG(INFO) +<< "Query " << print_id(_query_id) +<< " goes to low memory mode due to workload group high water mark reached"; +_low_memory_mode = true; +
Re: [PR] [fix](mtmv) Fix duplicate column name not check when create materialized view [doris]
doris-robot commented on PR #40658: URL: https://github.com/apache/doris/pull/40658#issuecomment-2342826539 TPC-H: Total hot run time: 38377 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit e5f46338be73ee4c229dc9b37e43afd5d49f9e73, data reload: false -- Round 1 -- q1 17610 443143194319 q2 2024186 189 186 q3 11716 995 1057995 q4 10411 709 703 703 q5 7731283927882788 q6 225 138 137 137 q7 964 621 603 603 q8 9325206320392039 q9 7151656066106560 q10 7006228522182218 q11 463 253 246 246 q12 402 228 230 228 q13 19004 316131633161 q14 290 234 254 234 q15 542 506 496 496 q16 517 431 440 431 q17 1020696 721 696 q18 7437689569886895 q19 13851152991 991 q20 691 337 343 337 q21 4155326230923092 q22 1133102810221022 Total cold run time: 111202 ms Total hot run time: 38377 ms - Round 2, with runtime_filter_mode=off - q1 4401442249544422 q2 381 272 274 272 q3 2951275427282728 q4 2029170218111702 q5 5788581960345819 q6 225 138 138 138 q7 2391199419331933 q8 3429362235473547 q9 9127918890489048 q10 3731340834183408 q11 616 521 530 521 q12 835 692 678 678 q13 16219 326433083264 q14 324 293 289 289 q15 532 494 493 493 q16 563 498 506 498 q17 1828155514741474 q18 8186783978347834 q19 1802167616981676 q20 2292190719451907 q21 5913570553495349 q22 1110106010681060 Total cold run time: 74673 ms Total hot run time: 58060 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](regression test) mv test_report_version_missing to p1 #40184 [doris]
yujun777 commented on PR #40647: URL: https://github.com/apache/doris/pull/40647#issuecomment-2342823494 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](load) fix wrong replica number when loading to table with no partition [doris]
github-actions[bot] commented on PR #40635: URL: https://github.com/apache/doris/pull/40635#issuecomment-2342824661 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](transaction) commit txn check txn status [doris]
doris-robot commented on PR #40064: URL: https://github.com/apache/doris/pull/40064#issuecomment-2342825866 TPC-DS: Total hot run time: 197776 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit c4ecdbb9116e803fa04227dc2d92b5ee9aed2044, data reload: false query1 1272908 927 908 query2 6441199319221922 query3 10627 408139203920 query4 59565 24557 23226 23226 query5 5033497 491 491 query6 399 172 159 159 query7 5619311 290 290 query8 300 214 207 207 query9 7656247824782478 query10 412 276 272 272 query11 15610 15240 15159 15159 query12 148 95 96 95 query13 1433400 394 394 query14 10703 773573407340 query15 217 180 176 176 query16 6760451 487 451 query17 1130575 570 570 query18 1443296 299 296 query19 209 154 144 144 query20 118 112 108 108 query21 218 105 104 104 query22 4669441143694369 query23 34503 33832 33544 33544 query24 6038288528742874 query25 514 399 399 399 query26 615 163 159 159 query27 1581274 283 274 query28 3694205820122012 query29 635 407 407 407 query30 247 153 149 149 query31 932 781 762 762 query32 74 56 53 53 query33 438 282 286 282 query34 891 484 471 471 query35 836 721 728 721 query36 1066973 972 972 query37 146 88 83 83 query38 4025390938993899 query39 1404138513811381 query40 196 116 111 111 query41 47 44 44 44 query42 116 97 97 97 query43 512 465 482 465 query44 1097747 743 743 query45 199 170 170 170 query46 1099712 717 712 query47 1874181118111811 query48 374 301 299 299 query49 767 469 471 469 query50 831 419 432 419 query51 7067694768566856 query52 100 87 93 87 query53 252 180 186 180 query54 573 467 464 464 query55 78 76 75 75 query56 282 272 267 267 query57 1192108710691069 query58 241 232 238 232 query59 3074301427992799 query60 315 282 285 282 query61 127 121 122 121 query62 736 662 659 659 query63 222 190 185 185 query64 1414719 744 719 query65 3259315731693157 query66 675 347 354 347 query67 15766 15272 15288 15272 query68 1964852 852 852 query69 443 326 343 326 query70 1145120511961196 query71 346 334 334 334 query72 4758350834843484 query73 585 575 581 575 query74 9044887189478871 query75 3026289629262896 query76 988 838 824 824 query77 516 389 395 389 query78 9312929092439243 query79 890 865 862 862 query80 790 787 812 787 query81 447 261 256 256 query82 267 259 270 259 query83 189 187 186 186 query84 202 105 103 103 query85 603 400 377 377 query86 312 323 323 323 query87 4331430844474308 query88 4360414341254125 query89 364 363 359 359 query90 1382314 303 303 query91 124 119 118 118 query92 77 74 73 73 query93 888 883 897 883 query94 521 364 351 351 query95 415 451 414 414 query96 475 474 469 469 query97 3029309331133093 query98 221 236 230 230 query99 1320131012751275 Total cold run time: 293440 ms Total hot run time: 197776 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
[PR] [docker](fix) Modify docker be default storage path [doris]
catpineapple opened a new pull request, #40665: URL: https://github.com/apache/doris/pull/40665 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [docker](fix) Modify docker be default storage path [doris]
doris-robot commented on PR #40665: URL: https://github.com/apache/doris/pull/40665#issuecomment-2342847814 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)build agg for random distributed agg table in bindRelation phase [doris]
doris-robot commented on PR #40181: URL: https://github.com/apache/doris/pull/40181#issuecomment-2342828208 ClickBench: Total hot run time: 31.77 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 4614578455bb676cbe1f3a36086fa00496622b0a, data reload: false query1 0.040.040.04 query2 0.080.040.04 query3 0.230.050.05 query4 1.660.080.07 query5 0.520.490.51 query6 1.120.730.74 query7 0.020.020.02 query8 0.050.040.05 query9 0.540.500.49 query10 0.550.580.53 query11 0.160.120.12 query12 0.150.120.12 query13 0.610.590.60 query14 1.361.451.41 query15 0.840.820.82 query16 0.390.370.39 query17 1.031.071.07 query18 0.210.200.22 query19 1.911.711.82 query20 0.010.020.01 query21 15.41 0.660.66 query22 4.756.612.26 query23 18.25 1.391.28 query24 2.200.210.22 query25 0.150.080.08 query26 0.270.170.17 query27 0.080.080.08 query28 13.17 1.021.00 query29 12.62 3.313.33 query30 0.250.060.05 query31 2.860.410.39 query32 3.250.480.47 query33 3.012.963.07 query34 17.03 4.464.44 query35 4.484.444.48 query36 0.650.460.48 query37 0.190.170.16 query38 0.160.150.14 query39 0.050.030.03 query40 0.160.130.13 query41 0.100.050.04 query42 0.050.050.05 query43 0.050.040.04 Total cold run time: 110.67 s Total hot run time: 31.77 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](ci) tmp remove required of Clang Formatter on branch-2.0 [doris]
hello-stephen commented on PR #40664: URL: https://github.com/apache/doris/pull/40664#issuecomment-2342828765 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) clean count usage in ColumnStatistic during stats deriving [doris]
xzj7019 commented on PR #40654: URL: https://github.com/apache/doris/pull/40654#issuecomment-2342828971 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](ES Catalog)Support parse single value for array column (#40614) [doris]
doris-robot commented on PR #40660: URL: https://github.com/apache/doris/pull/40660#issuecomment-2342829392 TeamCity be ut coverage result: Function Coverage: 36.15% (9316/25769) Line Coverage: 27.72% (76435/275702) Region Coverage: 26.51% (39238/148000) Branch Coverage: 23.35% (20020/85740) Coverage Report: http://coverage.selectdb-in.cc/coverage/09b70052b7a7bc12c2b57563208adc529df028b2_09b70052b7a7bc12c2b57563208adc529df028b2/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch hello-stephen-patch-3 created (now ae52846f63e)
This is an automated email from the ASF dual-hosted git repository. hellostephen pushed a change to branch hello-stephen-patch-3 in repository https://gitbox.apache.org/repos/asf/doris.git at ae52846f63e [chore](ci) tmp remove required of Clang Formatter on branch-2.0 No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](cloud) manage node via sql like non cloud mode [doris]
yujun777 commented on code in PR #40264: URL: https://github.com/apache/doris/pull/40264#discussion_r1753321226 ## docker/runtime/doris-compose/cluster.py: ## @@ -647,11 +685,17 @@ def __init__(self, name, subnet, image, is_cloud, fe_config, be_config, node_type: Group(node_type) for node_type in Node.TYPE_ALL } +self.sql_mode_node_mgr = sql_mode_node_mgr +self.no_be_metaservice_endpoint = no_be_metaservice_endpoint +self.no_be_cloud_instanceid = no_be_cloud_instanceid + +LOG.info("x cluster") Review Comment: 删除这行 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](cloud) manage node via sql like non cloud mode [doris]
yujun777 commented on code in PR #40264: URL: https://github.com/apache/doris/pull/40264#discussion_r1753323215 ## docker/runtime/doris-compose/command.py: ## @@ -297,6 +297,45 @@ def add_parser(self, args_parsers): default="", help="Set code coverage output directory") +parser.add_argument("--sql-mode-node-mgr", +default=False, +action=self._get_parser_bool_action(True), +help="Manager fe be via sql instead of http") + +if self._support_boolean_action(): +parser.add_argument( +"--be-metaservice-endpoint", +default=True, +action=self._get_parser_bool_action(True), Review Comment: True -> False -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: [chore](audit) let line comment work well (#40602)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-2.1 by this push: new 1c277247664 [chore](audit) let line comment work well (#40602) 1c277247664 is described below commit 1c27724766451b9cb76afe25f3025c3b619b4e13 Author: morrySnow <101034200+morrys...@users.noreply.github.com> AuthorDate: Wed Sep 11 15:09:27 2024 +0800 [chore](audit) let line comment work well (#40602) --- fe/fe-core/src/main/java/org/apache/doris/qe/AuditLogHelper.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/qe/AuditLogHelper.java b/fe/fe-core/src/main/java/org/apache/doris/qe/AuditLogHelper.java index f88133e23a6..508fcc0f33a 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/qe/AuditLogHelper.java +++ b/fe/fe-core/src/main/java/org/apache/doris/qe/AuditLogHelper.java @@ -54,7 +54,7 @@ public class AuditLogHelper { private static void logAuditLogImpl(ConnectContext ctx, String origStmt, StatementBase parsedStmt, org.apache.doris.proto.Data.PQueryStatistics statistics, boolean printFuzzyVariables) { -origStmt = origStmt.replace("\n", " "); +origStmt = origStmt.replace("\n", "\\n"); // slow query long endTime = System.currentTimeMillis(); long elapseMs = endTime - ctx.getStartTime(); - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](cloud) manage node via sql like non cloud mode [doris]
yujun777 commented on code in PR #40264: URL: https://github.com/apache/doris/pull/40264#discussion_r1753329934 ## docker/runtime/doris-compose/command.py: ## @@ -297,6 +297,45 @@ def add_parser(self, args_parsers): default="", help="Set code coverage output directory") +parser.add_argument("--sql-mode-node-mgr", +default=False, +action=self._get_parser_bool_action(True), +help="Manager fe be via sql instead of http") + +if self._support_boolean_action(): +parser.add_argument( +"--be-metaservice-endpoint", +default=True, +action=self._get_parser_bool_action(True), +help= +"Do not set BE meta service endpoint in conf. Default is False." +) +else: +parser.add_argument( +"--no-be-metaservice-endpoint", +dest='be-metaservice-endpoint', +default=True, +action=self._get_parser_bool_action(True), +help= +"Do not set BE meta service endpoint in conf. Default is False." +) + +if self._support_boolean_action(): +parser.add_argument( +"--be-cloud-instanceid", +default=True, +action=self._get_parser_bool_action(True), +help= +"Do not set BE cloud instance ID in conf. Default is False.") +else: +parser.add_argument( +"--no-be-cloud-instanceid", +dest='be-cloud-instanceid', +default=True, +action=self._get_parser_bool_action(True), Review Comment: True -> False -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](cloud) manage node via sql like non cloud mode [doris]
yujun777 commented on code in PR #40264: URL: https://github.com/apache/doris/pull/40264#discussion_r1753328487 ## docker/runtime/doris-compose/command.py: ## @@ -297,6 +297,45 @@ def add_parser(self, args_parsers): default="", help="Set code coverage output directory") +parser.add_argument("--sql-mode-node-mgr", +default=False, +action=self._get_parser_bool_action(True), +help="Manager fe be via sql instead of http") + +if self._support_boolean_action(): +parser.add_argument( +"--be-metaservice-endpoint", +default=True, +action=self._get_parser_bool_action(True), +help= +"Do not set BE meta service endpoint in conf. Default is False." +) +else: +parser.add_argument( +"--no-be-metaservice-endpoint", +dest='be-metaservice-endpoint', +default=True, +action=self._get_parser_bool_action(True), +help= +"Do not set BE meta service endpoint in conf. Default is False." +) + +if self._support_boolean_action(): +parser.add_argument( +"--be-cloud-instanceid", +default=True, +action=self._get_parser_bool_action(True), Review Comment: True -> False -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](cloud) manage node via sql like non cloud mode [doris]
yujun777 commented on code in PR #40264: URL: https://github.com/apache/doris/pull/40264#discussion_r1753330451 ## docker/runtime/doris-compose/command.py: ## @@ -297,6 +297,45 @@ def add_parser(self, args_parsers): default="", help="Set code coverage output directory") +parser.add_argument("--sql-mode-node-mgr", +default=False, +action=self._get_parser_bool_action(True), +help="Manager fe be via sql instead of http") + +if self._support_boolean_action(): +parser.add_argument( +"--be-metaservice-endpoint", +default=True, +action=self._get_parser_bool_action(True), +help= +"Do not set BE meta service endpoint in conf. Default is False." +) +else: +parser.add_argument( +"--no-be-metaservice-endpoint", +dest='be-metaservice-endpoint', +default=True, +action=self._get_parser_bool_action(True), +help= +"Do not set BE meta service endpoint in conf. Default is False." +) + +if self._support_boolean_action(): +parser.add_argument( +"--be-cloud-instanceid", +default=True, +action=self._get_parser_bool_action(True), +help= +"Do not set BE cloud instance ID in conf. Default is False.") +else: +parser.add_argument( +"--no-be-cloud-instanceid", +dest='be-cloud-instanceid', +default=True, +action=self._get_parser_bool_action(True), +help= +"Do not set BE cloud instance ID in conf. Default is False.") Review Comment: Do set BE cloud instance ID in conf. Default is True. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](load) fix wrong replica number when loading to table with no partition [doris]
BiteThet merged PR #40635: URL: https://github.com/apache/doris/pull/40635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](ci) tmp remove required of Clang Formatter on branch-2.0 [doris]
github-actions[bot] commented on PR #40664: URL: https://github.com/apache/doris/pull/40664#issuecomment-2342837069 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](cloud) manage node via sql like non cloud mode [doris]
yujun777 commented on code in PR #40264: URL: https://github.com/apache/doris/pull/40264#discussion_r1753326524 ## docker/runtime/doris-compose/command.py: ## @@ -297,6 +297,45 @@ def add_parser(self, args_parsers): default="", help="Set code coverage output directory") +parser.add_argument("--sql-mode-node-mgr", +default=False, +action=self._get_parser_bool_action(True), +help="Manager fe be via sql instead of http") + +if self._support_boolean_action(): +parser.add_argument( +"--be-metaservice-endpoint", +default=True, +action=self._get_parser_bool_action(True), +help= +"Do not set BE meta service endpoint in conf. Default is False." +) +else: +parser.add_argument( +"--no-be-metaservice-endpoint", +dest='be-metaservice-endpoint', +default=True, +action=self._get_parser_bool_action(True), +help= +"Do not set BE meta service endpoint in conf. Default is False." Review Comment: Do set BE meta service endpoint in conf. Default is True. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](cloud-mow) print the queue length of committing txn on FE [doris]
doris-robot commented on PR #40340: URL: https://github.com/apache/doris/pull/40340#issuecomment-2342851300 TPC-H: Total hot run time: 38198 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 0cbe9fd363773e1611b3356acd2623c31621354e, data reload: false -- Round 1 -- q1 17607 535843134313 q2 2015189 189 189 q3 11789 990 1156990 q4 10518 806 732 732 q5 7723285727832783 q6 230 141 143 141 q7 953 620 622 620 q8 9314209821992098 q9 7261657065666566 q10 70122226 q11 457 241 244 241 q12 404 230 233 230 q13 17768 305730813057 q14 280 236 251 236 q15 543 503 483 483 q16 538 431 436 431 q17 981 696 749 696 q18 7456676969016769 q19 1396102510771025 q20 681 337 345 337 q21 3902306530313031 q22 1079105310081008 Total cold run time: 109907 ms Total hot run time: 38198 ms - Round 2, with runtime_filter_mode=off - q1 4411428243454282 q2 379 282 279 279 q3 2896269226782678 q4 1977167716621662 q5 5695570257985702 q6 241 138 139 138 q7 2235184518441844 q8 3318346635233466 q9 8885889988408840 q10 3662343333563356 q11 615 523 502 502 q12 826 676 674 674 q13 14888 330233403302 q14 314 292 290 290 q15 560 482 501 482 q16 545 476 511 476 q17 1834158815561556 q18 8073787478837874 q19 1808151714861486 q20 2200190519581905 q21 5854574155155515 q22 1133107310301030 Total cold run time: 72349 ms Total hot run time: 57339 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) fix the issue that FE's periodic reconnection to MS RPC is ineffective [doris]
doris-robot commented on PR #40661: URL: https://github.com/apache/doris/pull/40661#issuecomment-2342845406 TPC-DS: Total hot run time: 193164 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit a97bb8dec4007fb0d56b8eca30b74850e819dea4, data reload: false query1 913 374 384 374 query2 6466193618791879 query3 6646215 216 215 query4 34436 23266 23071 23071 query5 4150520 503 503 query6 256 174 163 163 query7 4588303 304 303 query8 276 215 215 215 query9 8495248224982482 query10 444 289 282 282 query11 16253 15120 15306 15120 query12 146 102 102 102 query13 1638396 374 374 query14 9986743773637363 query15 259 167 196 167 query16 7468427 462 427 query17 1661564 553 553 query18 1980291 289 289 query19 329 151 149 149 query20 117 111 109 109 query21 206 104 104 104 query22 4546421742004200 query23 34393 33472 33401 33401 query24 1 293929002900 query25 616 386 389 386 query26 948 158 161 158 query27 2336278 279 278 query28 7054205420492049 query29 771 419 414 414 query30 306 159 148 148 query31 1003773 779 773 query32 99 56 59 56 query33 759 292 284 284 query34 964 490 497 490 query35 872 728 753 728 query36 1116951 956 951 query37 147 89 89 89 query38 4097390538813881 query39 1447139013911390 query40 190 118 137 118 query41 49 45 46 45 query42 115 98 98 98 query43 516 471 475 471 query44 1312774 747 747 query45 200 167 169 167 query46 1112775 774 774 query47 1880180918381809 query48 362 290 296 290 query49 1028450 444 444 query50 823 417 424 417 query51 7067690268386838 query52 100 91 88 88 query53 254 188 188 188 query54 917 460 455 455 query55 80 75 80 75 query56 288 266 284 266 query57 1192107910761076 query58 245 243 240 240 query59 2996272426712671 query60 309 262 271 262 query61 107 111 106 106 query62 837 651 644 644 query63 229 195 196 195 query64 4368686 731 686 query65 3211320031553155 query66 1032341 338 338 query67 15901 15457 15165 15165 query68 3140868 843 843 query69 448 326 325 325 query70 1176115411671154 query71 353 348 353 348 query72 6127354534723472 query73 587 589 586 586 query74 9122897589488948 query75 3176303529702970 query76 1881916 883 883 query77 471 412 408 408 query78 9339923795619237 query79 936 915 875 875 query80 864 837 884 837 query81 458 263 269 263 query82 274 266 268 266 query83 198 192 193 192 query84 233 111 108 108 query85 652 403 391 391 query86 340 324 311 311 query87 4372440342764276 query88 4514409140884088 query89 398 371 372 371 query90 1504329 324 324 query91 128 130 127 127 query92 83 76 77 76 query93 934 942 938 938 query94 575 369 360 360 query95 426 416 417 416 query96 473 472 471 471 query97 3135315131543151 query98 237 288 234 234 query99 1398126712741267 Total cold run time: 283970 ms Total hot run time: 193164 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [fix](mtmv) Fix duplicate column name not check when create materialized view [doris]
doris-robot commented on PR #40658: URL: https://github.com/apache/doris/pull/40658#issuecomment-2342848925 TPC-DS: Total hot run time: 197451 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit e5f46338be73ee4c229dc9b37e43afd5d49f9e73, data reload: false query1 1260903 902 902 query2 6434191719111911 query3 10698 398740453987 query4 60554 28470 23253 23253 query5 4965496 496 496 query6 398 177 166 166 query7 5627299 293 293 query8 315 219 214 214 query9 7722248625022486 query10 412 284 273 273 query11 16292 15085 15524 15085 query12 158 105 104 104 query13 1474422 405 405 query14 10233 700274577002 query15 211 188 180 180 query16 6715486 503 486 query17 1072565 558 558 query18 1390296 295 295 query19 203 148 149 148 query20 127 112 112 112 query21 229 106 106 106 query22 4860473047814730 query23 34394 33589 33515 33515 query24 6009295328172817 query25 487 392 396 392 query26 597 155 155 155 query27 1581282 280 280 query28 3818205820392039 query29 664 429 430 429 query30 250 156 152 152 query31 928 760 752 752 query32 77 57 53 53 query33 436 289 292 289 query34 859 491 478 478 query35 826 738 736 736 query36 1109952 958 952 query37 143 95 91 91 query38 3968396040593960 query39 1453142114031403 query40 200 118 118 118 query41 49 50 48 48 query42 122 97 101 97 query43 508 464 466 464 query44 1086757 740 740 query45 200 164 168 164 query46 1105749 779 749 query47 1878179518071795 query48 381 311 290 290 query49 794 463 466 463 query50 844 431 439 431 query51 7138679870046798 query52 104 91 89 89 query53 254 185 186 185 query54 572 458 475 458 query55 78 80 76 76 query56 277 272 263 263 query57 1225108010681068 query58 240 260 231 231 query59 3008282026972697 query60 300 285 301 285 query61 183 100 102 100 query62 740 654 666 654 query63 213 188 186 186 query64 1399688 699 688 query65 3234313731683137 query66 662 337 333 333 query67 15923 15520 15370 15370 query68 1909568 560 560 query69 395 259 276 259 query70 1208109811441098 query71 326 277 271 271 query72 4684409540234023 query73 739 327 328 327 query74 9317886689268866 query75 3330272127052705 query76 1345100410241004 query77 513 329 312 312 query78 9777920197239201 query79 1079890 863 863 query80 1101808 804 804 query81 520 267 264 264 query82 1382272 264 264 query83 245 197 194 194 query84 265 108 110 108 query85 719 395 387 387 query86 335 319 325 319 query87 4439430444654304 query88 4641409840894089 query89 392 366 364 364 query90 1821320 307 307 query91 122 174 124 124 query92 80 75 75 75 query93 953 927 926 926 query94 755 369 334 334 query95 440 415 422 415 query96 470 471 473 471 query97 3125305931093059 query98 235 228 230 228 query99 1483126412711264 Total cold run time: 299810 ms Total hot run time: 197451 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
(doris) branch spill_and_reserve updated: fix bug
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch spill_and_reserve in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/spill_and_reserve by this push: new 19785489e87 fix bug 19785489e87 is described below commit 19785489e87650cb00ac059ce2ac28e22f8e6090 Author: yiguolei AuthorDate: Wed Sep 11 15:17:53 2024 +0800 fix bug --- be/src/vec/exec/scan/scanner_context.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/be/src/vec/exec/scan/scanner_context.cpp b/be/src/vec/exec/scan/scanner_context.cpp index ed50c195d74..801ed1860f3 100644 --- a/be/src/vec/exec/scan/scanner_context.cpp +++ b/be/src/vec/exec/scan/scanner_context.cpp @@ -322,7 +322,7 @@ Status ScannerContext::get_block_from_queue(RuntimeState* state, vectorized::Blo } } } -if (_local_state->low_memory_mode()) { +if (!_local_state->low_memory_mode()) { // scale up RETURN_IF_ERROR(_try_to_scale_up()); } - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](ES Catalog)Support parse single value for array column (#40614) [doris]
qidaye opened a new pull request, #40666: URL: https://github.com/apache/doris/pull/40666 bp #40614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](ES Catalog)Support parse single value for array column (#40614) [doris]
doris-robot commented on PR #40666: URL: https://github.com/apache/doris/pull/40666#issuecomment-2342853384 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](ES Catalog)Support parse single value for array column (#40614) [doris]
qidaye commented on PR #40666: URL: https://github.com/apache/doris/pull/40666#issuecomment-2342853488 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) fix the issue that FE's periodic reconnection to MS RPC is ineffective [doris]
doris-robot commented on PR #40661: URL: https://github.com/apache/doris/pull/40661#issuecomment-2342855206 ClickBench: Total hot run time: 31.36 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit a97bb8dec4007fb0d56b8eca30b74850e819dea4, data reload: false query1 0.050.040.04 query2 0.080.040.04 query3 0.220.060.05 query4 1.670.080.07 query5 0.510.490.50 query6 1.130.730.73 query7 0.020.010.02 query8 0.060.050.05 query9 0.540.490.49 query10 0.530.570.55 query11 0.160.120.12 query12 0.150.120.12 query13 0.600.590.59 query14 1.351.431.44 query15 0.840.820.83 query16 0.380.370.39 query17 1.081.031.02 query18 0.200.200.19 query19 1.931.721.81 query20 0.010.010.02 query21 15.41 0.670.67 query22 4.177.831.84 query23 18.28 1.421.26 query24 2.040.220.21 query25 0.150.090.07 query26 0.270.180.18 query27 0.080.070.07 query28 13.32 1.010.99 query29 12.61 3.343.32 query30 0.240.060.06 query31 2.870.400.39 query32 3.240.490.48 query33 2.973.083.02 query34 17.14 4.374.44 query35 4.444.464.43 query36 0.640.500.51 query37 0.180.160.15 query38 0.150.140.14 query39 0.050.040.04 query40 0.160.140.12 query41 0.090.050.05 query42 0.060.050.05 query43 0.050.050.04 Total cold run time: 110.12 s Total hot run time: 31.36 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Improment] Log fatal when compaction memtracker not return zero [doris]
wangbo opened a new pull request, #40667: URL: https://github.com/apache/doris/pull/40667 ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improment] Log fatal when compaction memtracker not return zero [doris]
doris-robot commented on PR #40667: URL: https://github.com/apache/doris/pull/40667#issuecomment-2342856361 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids)support correlated scalar subquery without scalar agg [doris]
doris-robot commented on PR #39471: URL: https://github.com/apache/doris/pull/39471#issuecomment-2342819017 TPC-DS: Total hot run time: 197823 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit ccdf83c22740b770151fdc8c81958862b3ef0e8b, data reload: false query1 1231875 913 875 query2 6373197219781972 query3 10634 377240613772 query4 60035 25257 23193 23193 query5 5037513 507 507 query6 404 179 173 173 query7 5632305 297 297 query8 326 227 226 226 query9 7683253425012501 query10 430 286 272 272 query11 16993 15126 15264 15126 query12 151 106 104 104 query13 1465393 402 393 query14 11698 723475647234 query15 200 193 177 177 query16 6673473 472 472 query17 1078572 580 572 query18 905 306 328 306 query19 198 146 154 146 query20 123 112 114 112 query21 212 107 104 104 query22 4623440544114405 query23 34392 33882 33727 33727 query24 5985285328642853 query25 523 387 399 387 query26 607 160 151 151 query27 1595279 278 278 query28 3802204320252025 query29 629 409 407 407 query30 242 150 150 150 query31 951 758 787 758 query32 72 52 56 52 query33 418 279 284 279 query34 879 489 471 471 query35 838 724 717 717 query36 1078916 939 916 query37 150 83 86 83 query38 3943390139123901 query39 1449153113521352 query40 199 112 113 112 query41 49 45 45 45 query42 122 96 97 96 query43 504 477 462 462 query44 1102771 753 753 query45 196 170 169 169 query46 1102750 712 712 query47 1920177918591779 query48 383 302 298 298 query49 763 431 446 431 query50 816 425 422 422 query51 7062683668986836 query52 103 87 89 87 query53 249 177 187 177 query54 572 450 459 450 query55 76 74 78 74 query56 283 259 252 252 query57 1213109210861086 query58 223 235 237 235 query59 3045286928542854 query60 301 277 276 276 query61 104 119 103 103 query62 764 666 648 648 query63 222 191 185 185 query64 1386660 662 660 query65 3220316632063166 query66 621 326 336 326 query67 15940 15207 15240 15207 query68 1577860 856 856 query69 430 336 327 327 query70 1154117110961096 query71 358 351 345 345 query72 4607354035103510 query73 598 582 582 582 query74 9090901889308930 query75 2983297529792975 query76 1005855 850 850 query77 416 422 413 413 query78 9245936593119311 query79 913 868 914 868 query80 790 808 785 785 query81 464 255 261 255 query82 264 265 266 265 query83 185 186 188 186 query84 203 108 107 107 query85 599 394 377 377 query86 323 291 312 291 query87 4367436643484348 query88 4294414741624147 query89 370 361 365 361 query90 822 323 319 319 query91 124 127 125 125 query92 78 78 77 77 query93 908 909 907 907 query94 457 355 398 355 query95 431 422 414 414 query96 475 470 470 470 query97 3129316231223122 query98 224 234 237 234 query99 1307126812841268 Total cold run time: 294387 ms Total hot run time: 197823 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [fix](mtmv) Fix duplicate column name not check when create materialized view [doris]
doris-robot commented on PR #40658: URL: https://github.com/apache/doris/pull/40658#issuecomment-2342859011 ClickBench: Total hot run time: 31.71 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit e5f46338be73ee4c229dc9b37e43afd5d49f9e73, data reload: false query1 0.040.040.04 query2 0.090.040.04 query3 0.230.050.05 query4 1.670.070.07 query5 0.520.510.50 query6 1.130.750.73 query7 0.020.010.01 query8 0.060.050.05 query9 0.540.480.50 query10 0.540.550.56 query11 0.150.120.11 query12 0.150.120.12 query13 0.600.600.59 query14 1.401.401.38 query15 0.850.840.82 query16 0.370.360.38 query17 1.080.990.99 query18 0.220.200.21 query19 1.861.731.78 query20 0.010.010.00 query21 15.39 0.690.66 query22 4.825.762.12 query23 18.23 1.371.24 query24 2.110.240.22 query25 0.160.090.08 query26 0.270.190.18 query27 0.080.070.07 query28 13.22 1.021.00 query29 12.62 3.373.40 query30 0.240.060.06 query31 2.870.400.39 query32 3.260.490.47 query33 3.003.013.02 query34 17.06 4.474.44 query35 4.554.504.52 query36 0.660.480.48 query37 0.190.160.15 query38 0.160.150.15 query39 0.050.030.04 query40 0.150.130.13 query41 0.100.050.06 query42 0.050.050.05 query43 0.050.040.04 Total cold run time: 110.82 s Total hot run time: 31.71 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improment] Log fatal when compaction memtracker not return zero [doris]
wangbo commented on PR #40667: URL: https://github.com/apache/doris/pull/40667#issuecomment-2342859181 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (36828f2994e -> 898d5254ccb)
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 36828f2994e [Fix](load) fix wrong replica number when loading to table with no partition (#40635) add 898d5254ccb [fix](Nereids) sink distribute is wrong when table is unpartitioned (#40541) No new revisions were added by this update. Summary of changes: .../doris/nereids/trees/plans/physical/PhysicalOlapTableSink.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) sink distribute is wrong when table is unpartitioned [doris]
morrySnow merged PR #40541: URL: https://github.com/apache/doris/pull/40541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](cast) remove some typeid_cast usage [doris]
github-actions[bot] commented on PR #40601: URL: https://github.com/apache/doris/pull/40601#issuecomment-2342861613 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](bytebuffer) fix allocate size improper in append_and_flush [doris]
doris-robot commented on PR #40613: URL: https://github.com/apache/doris/pull/40613#issuecomment-2342863735 TPC-H: Total hot run time: 38433 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 84d68885d52e3874a2c11f01ab9d037d408451a9, data reload: false -- Round 1 -- q1 17603 472743534353 q2 2008185 183 183 q3 11627 935 1163935 q4 10522 783 776 776 q5 7787287928632863 q6 231 141 141 141 q7 969 615 627 615 q8 9322207320692069 q9 7090657066136570 q10 7017226322522252 q11 471 239 246 239 q12 402 227 230 227 q13 17759 307030813070 q14 281 239 250 239 q15 549 485 504 485 q16 529 442 437 437 q17 972 692 767 692 q18 7537698569156915 q19 1381110010551055 q20 687 340 340 340 q21 3963308829742974 q22 1122100310211003 Total cold run time: 109829 ms Total hot run time: 38433 ms - Round 2, with runtime_filter_mode=off - q1 4323430243084302 q2 394 270 276 270 q3 2892262726322627 q4 1939161616811616 q5 5717569358165693 q6 236 141 137 137 q7 2250189518551855 q8 3315344935513449 q9 8955890488898889 q10 3623341333683368 q11 618 522 500 500 q12 826 686 653 653 q13 13749 315732873157 q14 318 291 291 291 q15 548 483 499 483 q16 553 501 502 501 q17 1864156215611561 q18 8203788680097886 q19 1807150215511502 q20 2201191319041904 q21 5714566055105510 q22 1120103010341030 Total cold run time: 71165 ms Total hot run time: 57184 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.1](nereids) remove interface Nondeterministic and fix random/random_bytes foldable properties (#39944) [doris]
yiguolei commented on PR #40650: URL: https://github.com/apache/doris/pull/40650#issuecomment-2342864252 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](cast) remove some typeid_cast usage [doris]
github-actions[bot] commented on PR #40601: URL: https://github.com/apache/doris/pull/40601#issuecomment-2342866200 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) when table.rows > topn.limit+topn.offset, do not generate topn-filter [doris]
doris-robot commented on PR #40480: URL: https://github.com/apache/doris/pull/40480#issuecomment-2342867169 TPC-H: Total hot run time: 38343 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit db6fc9ff2cdc1f4b431545b463a8c9649f48f7f6, data reload: false -- Round 1 -- q1 18060 467844084408 q2 2639197 186 186 q3 11076 115110731073 q4 10613 745 665 665 q5 7800287928342834 q6 231 141 136 136 q7 981 619 612 612 q8 9872204320492043 q9 7386655565686555 q10 7007224322122212 q11 467 247 252 247 q12 398 226 223 223 q13 17855 308530713071 q14 290 242 239 239 q15 541 496 478 478 q16 518 430 434 430 q17 970 650 653 650 q18 7319696970116969 q19 1390100310351003 q20 687 330 333 330 q21 4020297230892972 q22 1101100710281007 Total cold run time: 111221 ms Total hot run time: 38343 ms - Round 2, with runtime_filter_mode=off - q1 4375428743064287 q2 372 281 260 260 q3 2885268826772677 q4 1963169716841684 q5 5440542654255425 q6 217 129 130 129 q7 2097174217311731 q8 3198336633553355 q9 8454845684778456 q10 3483320931673167 q11 599 511 506 506 q12 797 620 609 609 q13 9737310531253105 q14 309 276 287 276 q15 529 480 490 480 q16 522 473 464 464 q17 1786150014851485 q18 7830753874307430 q19 1698156715111511 q20 2089181218421812 q21 5477527053535270 q22 1130102510501025 Total cold run time: 64987 ms Total hot run time: 55144 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) clean count usage in ColumnStatistic during stats deriving [doris]
doris-robot commented on PR #40654: URL: https://github.com/apache/doris/pull/40654#issuecomment-2342867779 TPC-H: Total hot run time: 38407 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 1f46762ab2927b314067608dd3befc9f98359a07, data reload: false -- Round 1 -- q1 18315 447844004400 q2 2586190 199 190 q3 11027 117411831174 q4 11035 875 756 756 q5 8089293128392839 q6 233 141 138 138 q7 976 632 608 608 q8 9328207420752074 q9 7329656265486548 q10 7016226522622262 q11 439 238 240 238 q12 394 222 224 222 q13 17756 312231123112 q14 284 233 240 233 q15 544 487 483 483 q16 520 437 436 436 q17 975 647 744 647 q18 7358700668226822 q19 1386100310511003 q20 718 346 322 322 q21 3935307328702870 q22 1152103010471030 Total cold run time: 111395 ms Total hot run time: 38407 ms - Round 2, with runtime_filter_mode=off - q1 4370429742704270 q2 377 266 270 266 q3 2948267226982672 q4 1936168617421686 q5 5416541954525419 q6 225 132 130 130 q7 2149179517501750 q8 3205337733373337 q9 8448847884708470 q10 3494320532343205 q11 610 528 501 501 q12 798 635 587 587 q13 8525307230983072 q14 300 295 279 279 q15 509 484 492 484 q16 528 499 504 499 q17 1794149414731473 q18 7833755974577457 q19 1673146314991463 q20 2092184318481843 q21 5511527654335276 q22 1169109510191019 Total cold run time: 63910 ms Total hot run time: 55158 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](ES Catalog)Support parse single value for array column (#40614) [doris]
github-actions[bot] commented on PR #40666: URL: https://github.com/apache/doris/pull/40666#issuecomment-2342867884 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](api)Improved path handling with normalization, encoding, and error management. [doris]
CalvinKirs commented on PR #40628: URL: https://github.com/apache/doris/pull/40628#issuecomment-2342867810 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore] Split some case logic [doris-flink-connector]
JNSimba merged PR #487: URL: https://github.com/apache/doris-flink-connector/pull/487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-flink-connector) branch master updated: [Chore] Split some case logic (#487)
This is an automated email from the ASF dual-hosted git repository. diwu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris-flink-connector.git The following commit(s) were added to refs/heads/master by this push: new 766b6905 [Chore] Split some case logic (#487) 766b6905 is described below commit 766b69056a8796448352b3364b901086d402d74c Author: wudi <676366...@qq.com> AuthorDate: Wed Sep 11 15:27:28 2024 +0800 [Chore] Split some case logic (#487) --- .../doris/flink/tools/cdc/DatabaseSyncConfig.java | 2 -- .../doris/flink/tools/cdc/DorisTableConfig.java| 12 ++- .../flink/container/e2e/Doris2DorisE2ECase.java| 23 ++ .../flink/tools/cdc/CdcDb2SyncDatabaseCase.java| 4 ++-- .../flink/tools/cdc/CdcMongoSyncDatabaseCase.java | 4 ++-- .../flink/tools/cdc/CdcMysqlSyncDatabaseCase.java | 4 ++-- .../tools/cdc/CdcOraclelSyncDatabaseCase.java | 4 ++-- .../tools/cdc/CdcPostgresSyncDatabaseCase.java | 4 ++-- .../tools/cdc/CdcSqlServerSyncDatabaseCase.java| 4 ++-- 9 files changed, 21 insertions(+), 40 deletions(-) diff --git a/flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DatabaseSyncConfig.java b/flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DatabaseSyncConfig.java index 6c78d5cd..e1a089ff 100644 --- a/flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DatabaseSyncConfig.java +++ b/flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DatabaseSyncConfig.java @@ -69,8 +69,6 @@ public class DatabaseSyncConfig { public static final String SINGLE_SINK = "single-sink"; // doris-table-conf // public static final String TABLE_CONF = "table-conf"; -public static final String REPLICATION_NUM = "replication_num"; -public static final String TABLE_BUCKETS = "table-buckets"; // date-converter-conf // public static final String CONVERTERS = "converters"; diff --git a/flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DorisTableConfig.java b/flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DorisTableConfig.java index 912ed698..6318fc8a 100644 --- a/flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DorisTableConfig.java +++ b/flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DorisTableConfig.java @@ -26,8 +26,11 @@ import java.util.Map; import java.util.Objects; public class DorisTableConfig implements Serializable { -private static final String LIGHT_SCHEMA_CHANGE = "light_schema_change"; +public static final String LIGHT_SCHEMA_CHANGE = "light_schema_change"; // PROPERTIES parameter in doris table creation statement. such as: replication_num=1. +public static final String REPLICATION_NUM = "replication_num"; +public static final String TABLE_BUCKETS = "table-buckets"; + private final Map tableProperties; // The specific parameters extracted from --table-conf need to be parsed and integrated into the // doris table creation statement. such as: table-buckets="tbl1:10,tbl2:20,a.*:30,b.*:40,.*:50". @@ -48,10 +51,9 @@ public class DorisTableConfig implements Serializable { if (!tableConfig.containsKey(LIGHT_SCHEMA_CHANGE)) { tableConfig.put(LIGHT_SCHEMA_CHANGE, Boolean.toString(true)); } -if (tableConfig.containsKey(DatabaseSyncConfig.TABLE_BUCKETS)) { -this.tableBuckets = - buildTableBucketMap(tableConfig.get(DatabaseSyncConfig.TABLE_BUCKETS)); -tableConfig.remove(DatabaseSyncConfig.TABLE_BUCKETS); +if (tableConfig.containsKey(TABLE_BUCKETS)) { +this.tableBuckets = buildTableBucketMap(tableConfig.get(TABLE_BUCKETS)); +tableConfig.remove(TABLE_BUCKETS); } tableProperties = tableConfig; } diff --git a/flink-doris-connector/src/test/java/org/apache/doris/flink/container/e2e/Doris2DorisE2ECase.java b/flink-doris-connector/src/test/java/org/apache/doris/flink/container/e2e/Doris2DorisE2ECase.java index 4b4e3b26..f7b3bee7 100644 --- a/flink-doris-connector/src/test/java/org/apache/doris/flink/container/e2e/Doris2DorisE2ECase.java +++ b/flink-doris-connector/src/test/java/org/apache/doris/flink/container/e2e/Doris2DorisE2ECase.java @@ -24,11 +24,9 @@ import org.apache.flink.table.api.bridge.java.StreamTableEnvironment; import org.apache.flink.types.Row; import org.apache.flink.util.CloseableIterator; -import org.apache.doris.flink.container.AbstractE2EService; +import org.apache.doris.flink.container.AbstractContainerTestBase; import org.apache.doris.flink.container.ContainerUtils; -import org.junit.After; import org.junit.Assert; -import org.junit.Before; import org.junit.Test; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -37,19 +35,12 @@ import java.util.ArrayList; import java.uti
Re: [PR] [Fix](api)Improved path handling with normalization, encoding, and error management. [doris]
github-actions[bot] commented on PR #40628: URL: https://github.com/apache/doris/pull/40628#issuecomment-2342868593 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](api)Improved path handling with normalization, encoding, and error management. [doris]
github-actions[bot] commented on PR #40628: URL: https://github.com/apache/doris/pull/40628#issuecomment-2342868647 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (inverted index) fix error result in complex compound expr [doris]
yiguolei merged PR #40630: URL: https://github.com/apache/doris/pull/40630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated (1c277247664 -> 86647df45b6)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git from 1c277247664 [chore](audit) let line comment work well (#40602) add 86647df45b6 [fix] (inverted index) fix error result in complex compound expr (#40630) No new revisions were added by this update. Summary of changes: be/src/olap/rowset/segment_v2/segment_iterator.cpp | 4 ++ .../test_index_rqg_bug6.out} | 4 +- .../inverted_index_p0/test_index_rqg_bug6.groovy | 63 ++ 3 files changed, 69 insertions(+), 2 deletions(-) copy regression-test/data/{fault_injection_p0/test_no_index_null_fault_injection.out => inverted_index_p0/test_index_rqg_bug6.out} (88%) create mode 100644 regression-test/suites/inverted_index_p0/test_index_rqg_bug6.groovy - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](regression test) mv test_report_version_missing to p1 #40184 [doris]
yiguolei merged PR #40646: URL: https://github.com/apache/doris/pull/40646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: [chore](regression test) mv test_report_version_missing to p1 #40184 (#40646)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-2.1 by this push: new 66421c42705 [chore](regression test) mv test_report_version_missing to p1 #40184 (#40646) 66421c42705 is described below commit 66421c42705293de52f3a89fd2eaef2def7f1fb1 Author: yujun AuthorDate: Wed Sep 11 15:28:23 2024 +0800 [chore](regression test) mv test_report_version_missing to p1 #40184 (#40646) cherry pick from #40184 --- .../control_p0/test_report_version_missing.groovy | 82 - .../control_p1/test_report_version_missing.groovy | 85 ++ 2 files changed, 85 insertions(+), 82 deletions(-) diff --git a/regression-test/suites/control_p0/test_report_version_missing.groovy b/regression-test/suites/control_p0/test_report_version_missing.groovy deleted file mode 100644 index 675ac52362e..000 --- a/regression-test/suites/control_p0/test_report_version_missing.groovy +++ /dev/null @@ -1,82 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one -// or more contributor license agreements. See the NOTICE file -// distributed with this work for additional information -// regarding copyright ownership. The ASF licenses this file -// to you under the Apache License, Version 2.0 (the -// "License"); you may not use this file except in compliance -// with the License. You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, -// software distributed under the License is distributed on an -// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -// KIND, either express or implied. See the License for the -// specific language governing permissions and limitations -// under the License. - -import org.apache.doris.regression.suite.ClusterOptions -import org.apache.doris.regression.util.NodeType - -suite('test_report_version_missing', "nonConcurrent") { -if (isCloudMode()) { -return -} -def tableName = "test_set_replica_status_table_in_docker" -try { -setFeConfig('disable_tablet_scheduler', true) -Thread.sleep(2000) - -sql "DROP TABLE IF EXISTS ${tableName}" -sql """ -CREATE TABLE ${tableName} ( -`id` LARGEINT NOT NULL, -`count` LARGEINT SUM DEFAULT "0") -AGGREGATE KEY(`id`) -DISTRIBUTED BY HASH(`id`) BUCKETS 1 -PROPERTIES -( -"replication_num" = "1" -) -""" -List values = [] -for (int i = 1; i <= 10; ++i) { -values.add("(${i}, ${i})") -} -sql """INSERT INTO ${tableName} VALUES ${values.join(",")}""" - -def result = sql_return_maparray """show tablets from ${tableName}""" -assertNotNull(result) -def tabletId = null -for (def res : result) { -tabletId = res.TabletId -break -} - - GetDebugPoint().enableDebugPointForAllBEs("Tablet.build_tablet_report_info.version_miss", [tablet_id:"${tabletId}",version_miss:true]) -boolean succ = false - -for (int i = 0; i < 3; ++i) { -result = sql_return_maparray """show tablets from ${tableName}""" -logger.info("show tablets from ${result}, has after ${i} * 60 s") -assertNotNull(result) -// LstFailedVersion > 0, version missing -for (def res : result) { -if (res.TabletId.toLong() == tabletId.toLong() && res.LstFailedVersion.toLong() > 0) { -succ = true -break -} -} -if (succ) { -break -} -Thread.sleep(6) -} -assertTrue(succ) - -} finally { -setFeConfig('disable_tablet_scheduler', false) - GetDebugPoint().disableDebugPointForAllBEs("Tablet.build_tablet_report_info.version_miss") -sql "DROP TABLE IF EXISTS ${tableName}" -} -} diff --git a/regression-test/suites/control_p1/test_report_version_missing.groovy b/regression-test/suites/control_p1/test_report_version_missing.groovy new file mode 100644 index 000..63ccd4ed6dd --- /dev/null +++ b/regression-test/suites/control_p1/test_report_version_missing.groovy @@ -0,0 +1,85 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// so
Re: [PR] [Chore](cast) remove some typeid_cast usage [doris]
BiteThet merged PR #40601: URL: https://github.com/apache/doris/pull/40601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (898d5254ccb -> c6c112344fc)
This is an automated email from the ASF dual-hosted git repository. panxiaolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 898d5254ccb [fix](Nereids) sink distribute is wrong when table is unpartitioned (#40541) add c6c112344fc [Chore](cast) remove some typeid_cast usage (#40601) No new revisions were added by this update. Summary of changes: be/src/vec/columns/column_array.cpp | 34 ++ be/src/vec/columns/column_map.cpp| 7 +--- be/src/vec/common/typeid_cast.h | 23 be/src/vec/functions/function_ip.h | 60 +++- be/src/vec/functions/function_map.cpp| 6 +--- be/src/vec/functions/function_struct.cpp | 6 +--- be/src/vec/functions/function_totype.h | 1 - be/src/vec/functions/if.cpp | 11 ++ 8 files changed, 53 insertions(+), 95 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](mem-tracker) Use thread local mem tracker to track s3 file buffer memory usage [doris]
TangSiyang2001 commented on PR #40597: URL: https://github.com/apache/doris/pull/40597#issuecomment-2342871146 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](ES Catalog)Support parse single value for array column (#40614) [doris]
qidaye commented on PR #40666: URL: https://github.com/apache/doris/pull/40666#issuecomment-2342873183 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cluster key) fix mow cluster key with schema change [doris]
doris-robot commented on PR #40372: URL: https://github.com/apache/doris/pull/40372#issuecomment-2342874582 TPC-H: Total hot run time: 37986 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 2537c66eb332e47c8b07f120fc3394e253bdf5a1, data reload: false -- Round 1 -- q1 17605 472943704370 q2 2027190 187 187 q3 11783 985 1105985 q4 10539 730 706 706 q5 7761280428662804 q6 225 135 135 135 q7 961 611 599 599 q8 9318209820972097 q9 7245656165796561 q10 6999215122012151 q11 461 249 244 244 q12 409 222 219 219 q13 17760 306831103068 q14 283 234 241 234 q15 559 492 501 492 q16 527 436 421 421 q17 999 688 695 688 q18 7407682168986821 q19 1400103810741038 q20 689 332 327 327 q21 3918307728172817 q22 1114102210321022 Total cold run time: 109989 ms Total hot run time: 37986 ms - Round 2, with runtime_filter_mode=off - q1 4413431542934293 q2 378 284 275 275 q3 2898268527292685 q4 1926167216851672 q5 5672573657715736 q6 241 143 135 135 q7 2227182418301824 q8 3331346634753466 q9 8916888089128880 q10 3657341433533353 q11 615 534 527 527 q12 835 665 675 665 q13 13532 328133263281 q14 326 291 297 291 q15 536 513 486 486 q16 542 520 494 494 q17 1880156915961569 q18 8177798778907890 q19 1728161215941594 q20 2174188819481888 q21 5849545055835450 q22 1128104010561040 Total cold run time: 70981 ms Total hot run time: 57494 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](cloud-mow) print the queue length of committing txn on FE [doris]
doris-robot commented on PR #40340: URL: https://github.com/apache/doris/pull/40340#issuecomment-2342874465 TPC-DS: Total hot run time: 196898 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 0cbe9fd363773e1611b3356acd2623c31621354e, data reload: false query1 1250895 861 861 query2 6445186118431843 query3 10648 387037863786 query4 59188 25664 23315 23315 query5 5000490 494 490 query6 396 169 168 168 query7 5638294 280 280 query8 301 217 210 210 query9 7653248124602460 query10 401 260 264 260 query11 16929 15065 15229 15065 query12 147 105 105 105 query13 1451384 380 380 query14 11035 737575597375 query15 218 180 179 179 query16 6855493 506 493 query17 1085559 546 546 query18 1535283 293 283 query19 196 149 146 146 query20 121 106 115 106 query21 208 101 102 101 query22 4688455945914559 query23 34420 33319 33638 33319 query24 5977290028492849 query25 517 401 380 380 query26 620 152 151 151 query27 1627271 273 271 query28 3676204520182018 query29 656 399 404 399 query30 234 157 144 144 query31 925 783 785 783 query32 75 50 49 49 query33 420 279 275 275 query34 891 466 459 459 query35 849 734 701 701 query36 1061946 954 946 query37 139 85 84 84 query38 4055381639563816 query39 1451139913971397 query40 193 116 114 114 query41 49 46 48 46 query42 116 97 100 97 query43 520 461 457 457 query44 1069747 740 740 query45 197 167 166 166 query46 1087755 736 736 query47 1937178118311781 query48 379 285 293 285 query49 791 457 454 454 query50 833 407 404 404 query51 7108750169296929 query52 101 87 87 87 query53 261 178 177 177 query54 559 462 458 458 query55 75 77 74 74 query56 285 255 272 255 query57 1223108810801080 query58 227 237 233 233 query59 2952272128102721 query60 314 282 270 270 query61 124 125 121 121 query62 751 673 684 673 query63 225 189 186 186 query64 1473744 731 731 query65 3236319931453145 query66 647 346 359 346 query67 16103 15348 15397 15348 query68 2017670 547 547 query69 410 289 277 277 query70 1189114810941094 query71 336 268 275 268 query72 4728409741674097 query73 741 320 327 320 query74 9269890388478847 query75 3343269227282692 query76 1297978 935 935 query77 562 320 313 313 query78 9844917096279170 query79 1220881 860 860 query80 1089818 798 798 query81 543 260 260 260 query82 1358266 265 265 query83 237 187 182 182 query84 259 104 107 104 query85 703 427 387 387 query86 316 316 324 316 query87 4383454544074407 query88 4659404940324032 query89 391 364 364 364 query90 1969304 305 304 query91 121 119 120 119 query92 81 80 76 76 query93 959 926 918 918 query94 788 363 383 363 query95 437 405 401 401 query96 466 466 468 466 query97 3135313830693069 query98 232 234 226 226 query99 1500131012551255 Total cold run time: 300398 ms Total hot run time: 196898 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [fix](ES Catalog)Support parse single value for array column (#40614) [doris]
qidaye commented on PR #40666: URL: https://github.com/apache/doris/pull/40666#issuecomment-2342875634 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.1](function) Refine crypto functions signature to fix wrong result(#40285) [doris]
yiguolei merged PR #40648: URL: https://github.com/apache/doris/pull/40648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: [branch-2.1](function) Refine crypto functions signature to fix wrong result(#40285) (#40648)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-2.1 by this push: new 3246baa4512 [branch-2.1](function) Refine crypto functions signature to fix wrong result(#40285) (#40648) 3246baa4512 is described below commit 3246baa4512c9a47d0a64a6ff872d13c5daa9948 Author: zclllhhjj AuthorDate: Wed Sep 11 15:32:19 2024 +0800 [branch-2.1](function) Refine crypto functions signature to fix wrong result(#40285) (#40648) pick https://github.com/apache/doris/pull/40285 --- .../apache/doris/analysis/FunctionCallExpr.java| 87 +++--- .../doris/catalog/BuiltinScalarFunctions.java | 8 -- .../expressions/functions/scalar/AesDecrypt.java | 14 +--- .../expressions/functions/scalar/AesDecryptV2.java | 74 -- .../expressions/functions/scalar/AesEncrypt.java | 14 +--- .../expressions/functions/scalar/AesEncryptV2.java | 74 -- .../expressions/functions/scalar/Sm4Decrypt.java | 15 +--- .../expressions/functions/scalar/Sm4DecryptV2.java | 69 - .../expressions/functions/scalar/Sm4Encrypt.java | 15 +--- .../expressions/functions/scalar/Sm4EncryptV2.java | 72 -- .../expressions/visitor/ScalarFunctionVisitor.java | 20 - .../encryption_digest/test_encryption_function.out | 80 +--- .../encryption_digest/test_encryption_function.out | 64 +--- .../nereids_function_p0/scalar_function/S.groovy | 51 + .../test_encryption_function.groovy| 73 +- .../test_encryption_function.groovy| 62 +-- 16 files changed, 29 insertions(+), 763 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java b/fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java index b61c49c0104..88791504b8e 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java +++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java @@ -640,11 +640,7 @@ public class FunctionCallExpr extends Expr { && (fnName.getFunction().equalsIgnoreCase("aes_decrypt") || fnName.getFunction().equalsIgnoreCase("aes_encrypt") || fnName.getFunction().equalsIgnoreCase("sm4_decrypt") -|| fnName.getFunction().equalsIgnoreCase("sm4_encrypt") -|| fnName.getFunction().equalsIgnoreCase("aes_decrypt_v2") -|| fnName.getFunction().equalsIgnoreCase("aes_encrypt_v2") -|| fnName.getFunction().equalsIgnoreCase("sm4_decrypt_v2") -|| fnName.getFunction().equalsIgnoreCase("sm4_encrypt_v2"))) { +|| fnName.getFunction().equalsIgnoreCase("sm4_encrypt"))) { sb.append("\'***\'"); } else if (orderByElements.size() > 0 && i == len - orderByElements.size()) { sb.append("ORDER BY "); @@ -718,22 +714,13 @@ public class FunctionCallExpr extends Expr { if (fnName.getFunction().equalsIgnoreCase("aes_decrypt") || fnName.getFunction().equalsIgnoreCase("aes_encrypt") || fnName.getFunction().equalsIgnoreCase("sm4_decrypt") -|| fnName.getFunction().equalsIgnoreCase("sm4_encrypt") -|| fnName.getFunction().equalsIgnoreCase("aes_decrypt_v2") -|| fnName.getFunction().equalsIgnoreCase("aes_encrypt_v2") -|| fnName.getFunction().equalsIgnoreCase("sm4_decrypt_v2") -|| fnName.getFunction().equalsIgnoreCase("sm4_encrypt_v2")) { +|| fnName.getFunction().equalsIgnoreCase("sm4_encrypt")) { len = len - 1; } for (int i = 0; i < len; ++i) { if (i == 1 && (fnName.getFunction().equalsIgnoreCase("aes_decrypt") || fnName.getFunction().equalsIgnoreCase("aes_encrypt") -|| fnName.getFunction().equalsIgnoreCase("sm4_decrypt") -|| fnName.getFunction().equalsIgnoreCase("sm4_encrypt") -|| fnName.getFunction().equalsIgnoreCase("aes_decrypt_v2") -|| fnName.getFunction().equalsIgnoreCase("aes_encrypt_v2") -|| fnName.getFunction().equalsIgnoreCase("sm4_decrypt_v2") -|| fnName.getFunction().equalsIgnoreCase("sm4_encrypt_v2"))) { +|| fnName.getFunction().equalsIgnoreCase("sm4_decrypt"))) { result.add("\'***\'"); } else { result.add(children.get(i).toDigest()); @@ -1141,13 +1128,8 @@ public class FunctionCallExpr extends Expr { if ((fnName.getFunction().equalsIgno
Re: [PR] [chore](ci) tmp remove required of Clang Formatter on branch-2.0 [doris]
xiaokang merged PR #40664: URL: https://github.com/apache/doris/pull/40664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [chore](ci) tmp remove required of Clang Formatter on branch-2.0 (#40664)
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 73bf91a2480 [chore](ci) tmp remove required of Clang Formatter on branch-2.0 (#40664) 73bf91a2480 is described below commit 73bf91a24808c93787eef9c8fd440e2d6ca8930a Author: Dongyang Li AuthorDate: Wed Sep 11 15:34:09 2024 +0800 [chore](ci) tmp remove required of Clang Formatter on branch-2.0 (#40664) --- .asf.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.asf.yaml b/.asf.yaml index e71e55de23f..1ef19652d39 100644 --- a/.asf.yaml +++ b/.asf.yaml @@ -109,7 +109,6 @@ github: strict: false contexts: - License Check - - Clang Formatter - CheckStyle - P0 Regression (Doris Regression) - External Regression (Doris External Regression) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.1](auto-partition) Re-add deduplication to auto partition rpc (#40580) [doris]
yiguolei merged PR #40652: URL: https://github.com/apache/doris/pull/40652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated (3246baa4512 -> 279c58fbc77)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git from 3246baa4512 [branch-2.1](function) Refine crypto functions signature to fix wrong result(#40285) (#40648) add 279c58fbc77 [branch-2.1](auto-partition) Re-add deduplication to auto partition rpc (#40580) (#40652) No new revisions were added by this update. Summary of changes: be/src/vec/sink/vrow_distribution.cpp | 6 -- be/src/vec/sink/vrow_distribution.h | 28 +++- 2 files changed, 27 insertions(+), 7 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (inverted index) fix wrong result in complex compound expr (#40630) [doris]
xiaokang merged PR #40631: URL: https://github.com/apache/doris/pull/40631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Job)Replace BlockingWaitStrategy with LiteTimeoutBlockingWaitStrategy to avoid deadlock issues. [doris]
github-actions[bot] commented on PR #40625: URL: https://github.com/apache/doris/pull/40625#issuecomment-2342881877 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.0 updated: [fix] (inverted index) fix wrong result in complex compound expr (#40630) (#40631)
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch branch-2.0 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-2.0 by this push: new 9829d44f2c8 [fix] (inverted index) fix wrong result in complex compound expr (#40630) (#40631) 9829d44f2c8 is described below commit 9829d44f2c8624627a4d93a18acd2035b91cd228 Author: Sun Chenyang AuthorDate: Wed Sep 11 15:34:39 2024 +0800 [fix] (inverted index) fix wrong result in complex compound expr (#40630) (#40631) --- be/src/olap/rowset/segment_v2/segment_iterator.cpp | 4 ++ .../data/inverted_index_p0/test_index_rqg_bug6.out | 7 +++ .../inverted_index_p0/test_index_rqg_bug6.groovy | 63 ++ 3 files changed, 74 insertions(+) diff --git a/be/src/olap/rowset/segment_v2/segment_iterator.cpp b/be/src/olap/rowset/segment_v2/segment_iterator.cpp index b337cd8f262..7f9c70be8cc 100644 --- a/be/src/olap/rowset/segment_v2/segment_iterator.cpp +++ b/be/src/olap/rowset/segment_v2/segment_iterator.cpp @@ -757,6 +757,10 @@ Status SegmentIterator::_execute_predicates_except_leafnode_of_andnode( _rowid_result_for_index[pred_result_sign].first) { auto apply_result = _rowid_result_for_index[pred_result_sign].second; _pred_except_leafnode_of_andnode_evaluate_result.push_back(apply_result); +} else { +return Status::InvalidArgument( +"_execute_predicates_except_leafnode_of_andnode has no result for {}", +pred_result_sign); } } else if (node_type == TExprNodeType::COMPOUND_PRED) { auto function_name = expr->fn().name.function_name; diff --git a/regression-test/data/inverted_index_p0/test_index_rqg_bug6.out b/regression-test/data/inverted_index_p0/test_index_rqg_bug6.out new file mode 100644 index 000..edf3444ebe2 --- /dev/null +++ b/regression-test/data/inverted_index_p0/test_index_rqg_bug6.out @@ -0,0 +1,7 @@ +-- This file is automatically generated. You should know what you did if you want to edit this +-- !sql -- +1 + +-- !sql_2 -- +3 + diff --git a/regression-test/suites/inverted_index_p0/test_index_rqg_bug6.groovy b/regression-test/suites/inverted_index_p0/test_index_rqg_bug6.groovy new file mode 100644 index 000..ce8e138dfa3 --- /dev/null +++ b/regression-test/suites/inverted_index_p0/test_index_rqg_bug6.groovy @@ -0,0 +1,63 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +suite("test_index_rqg_bug6", "test_index_rqg_bug"){ +def table = "test_index_rqg_bug6" + +sql "drop table if exists ${table}" + +sql """ + create table ${table} ( +pk int, +col_int_undef_signed_index_inverted int not null , +col_varchar_1024__undef_signed_not_null varchar(1024) not null, +INDEX col_int_undef_signed_index_inverted_idx (`col_int_undef_signed_index_inverted`) USING INVERTED, +INDEX col_varchar_1024__undef_signed_not_null_idx (`col_varchar_1024__undef_signed_not_null`) USING INVERTED +) engine=olap +DUPLICATE KEY(pk) +distributed by hash(pk) buckets 1 +properties("replication_num" = "1"); +""" + +sql """ insert into ${table} values (10, 0, 'ok'), (11, 0, 'oo'), (12, 1, 'ok')""" + + +sql """ sync""" +sql """ set enable_inverted_index_query = true """ +sql """ set inverted_index_skip_threshold = 0 """ +qt_sql """ +SELECT +count() +FROM +test_index_rqg_bug6 +WHERE +IF(col_int_undef_signed_index_inverted = 0, 'true', 'false') = 'false' +AND ( +col_varchar_1024__undef_signed_not_null LIKE 'ok' +OR col_int_undef_signed_index_inverted = 0 +); +""" + +qt_sql_2 """ +SELECT +count() +FROM +test_index_rqg_bug6 +WHERE +col_varchar_1024__undef_signed_not_null LIKE 'ok' +OR col_int_undef_signed_index_inverted = 0; +""" +} ---
Re: [PR] [Fix](Job)Replace BlockingWaitStrategy with LiteTimeoutBlockingWaitStrategy to avoid deadlock issues. [doris]
github-actions[bot] commented on PR #40625: URL: https://github.com/apache/doris/pull/40625#issuecomment-2342881930 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cluster key) fix mow cluster key with schema change [doris]
doris-robot commented on PR #40372: URL: https://github.com/apache/doris/pull/40372#issuecomment-2342881968 TeamCity be ut coverage result: Function Coverage: 36.88% (9451/25624) Line Coverage: 28.25% (77751/275198) Region Coverage: 27.65% (40127/145142) Branch Coverage: 24.26% (20386/84036) Coverage Report: http://coverage.selectdb-in.cc/coverage/2537c66eb332e47c8b07f120fc3394e253bdf5a1_2537c66eb332e47c8b07f120fc3394e253bdf5a1/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.1](partition) Support use Auto and Dynamic partition at the same time (#39580) [doris]
yiguolei merged PR #40649: URL: https://github.com/apache/doris/pull/40649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: [branch-2.1](partition) Support use Auto and Dynamic partition at the same time (#39580) (#40649)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-2.1 by this push: new d554f600bc4 [branch-2.1](partition) Support use Auto and Dynamic partition at the same time (#39580) (#40649) d554f600bc4 is described below commit d554f600bc40aa71aeb7551244bb1f8c69878750 Author: zclllhhjj AuthorDate: Wed Sep 11 15:35:20 2024 +0800 [branch-2.1](partition) Support use Auto and Dynamic partition at the same time (#39580) (#40649) pick https://github.com/apache/doris/pull/39580 --- .../doris/common/util/DynamicPartitionUtil.java| 41 +++- .../apache/doris/datasource/InternalCatalog.java | 6 +- .../test_auto_partition_behavior.out | 10 +- .../test_auto_partition_behavior.groovy| 215 ++--- .../test_dynamic_partition.groovy | 31 ++- 5 files changed, 165 insertions(+), 138 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/common/util/DynamicPartitionUtil.java b/fe/fe-core/src/main/java/org/apache/doris/common/util/DynamicPartitionUtil.java index b6ba99ee250..bcf2c0303ee 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/common/util/DynamicPartitionUtil.java +++ b/fe/fe-core/src/main/java/org/apache/doris/common/util/DynamicPartitionUtil.java @@ -17,6 +17,9 @@ package org.apache.doris.common.util; +import org.apache.doris.analysis.Expr; +import org.apache.doris.analysis.FunctionCallExpr; +import org.apache.doris.analysis.LiteralExpr; import org.apache.doris.analysis.TimestampArithmeticExpr.TimeUnit; import org.apache.doris.catalog.Column; import org.apache.doris.catalog.Database; @@ -127,13 +130,14 @@ public class DynamicPartitionUtil { return DynamicPartitionProperty.MIN_START_OFFSET; } -private static int checkEnd(String end) throws DdlException { +private static int checkEnd(String end, boolean enableAutoPartition) throws DdlException { if (Strings.isNullOrEmpty(end)) { ErrorReport.reportDdlException(ErrorCode.ERROR_DYNAMIC_PARTITION_END_EMPTY); } try { int endInt = Integer.parseInt(end); -if (endInt <= 0) { +// with auto partition sometime we dont like to create future partition by dynamic partition. +if (endInt < 0 || endInt == 0 && !enableAutoPartition) { ErrorReport.reportDdlException(ErrorCode.ERROR_DYNAMIC_PARTITION_END_ZERO, end); } return endInt; @@ -503,6 +507,25 @@ public class DynamicPartitionUtil { } } +public static void partitionIntervalCompatible(String dynamicUnit, ArrayList autoExprs) +throws AnalysisException { +if (autoExprs == null) { +return; +} +for (Expr autoExpr : autoExprs) { +Expr func = (FunctionCallExpr) autoExpr; +for (Expr child : func.getChildren()) { +if (child instanceof LiteralExpr) { +String autoUnit = ((LiteralExpr) child).getStringValue(); +if (!dynamicUnit.equalsIgnoreCase(autoUnit)) { +throw new AnalysisException("If support auto partition and dynamic partition at same time, " ++ "they must have the same interval unit."); +} +} +} +} +} + // Analyze all properties to check their validation public static Map analyzeDynamicPartition(Map properties, OlapTable olapTable, Database db) throws UserException { @@ -511,6 +534,12 @@ public class DynamicPartitionUtil { if (properties.containsKey(DynamicPartitionProperty.TIME_UNIT)) { String timeUnitValue = properties.get(DynamicPartitionProperty.TIME_UNIT); checkTimeUnit(timeUnitValue, olapTable.getPartitionInfo()); + +// if both enabled, must use same interval. +if (olapTable.getPartitionInfo().enableAutomaticPartition()) { +partitionIntervalCompatible(timeUnitValue, olapTable.getPartitionInfo().getPartitionExprs()); +} + properties.remove(DynamicPartitionProperty.TIME_UNIT); analyzedProperties.put(DynamicPartitionProperty.TIME_UNIT, timeUnitValue); } @@ -535,11 +564,7 @@ public class DynamicPartitionUtil { analyzedProperties.put(DynamicPartitionProperty.ENABLE, enableValue); } -if (Boolean.parseBoolean(analyzedProperties.getOrDefault(DynamicPartitionProperty.ENABLE, "true")) -&& olapTable.getPartitionInfo().enableAutomaticPartition()) { -throw new AnalysisException( -"Can't use Dynamic Partition and Auto Partition at the same time"); -} +boolean enableAutoPartition = ola