Re: [PR] [fix](case) adjust ak sk for multi cloud test case [doris]
hello-stephen merged PR #38749: URL: https://github.com/apache/doris/pull/38749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (3eb950119a4 -> 5e12f6789fa)
This is an automated email from the ASF dual-hosted git repository. hellostephen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 3eb950119a4 [fix](Nereids) lock table when generate distribute plan (#38950) add 5e12f6789fa [fix](case) adjust ak sk for multi cloud test case (#38749) No new revisions were added by this update. Summary of changes: regression-test/conf/regression-conf.groovy| 2 ++ .../pipeline/external/conf/regression-conf.groovy | 6 ++ .../paimon/paimon_base_filesystem.groovy | 22 ++ 3 files changed, 18 insertions(+), 12 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](iceberg)]support doris's char/varchar to iceberg's string [doris]
github-actions[bot] commented on PR #38807: URL: https://github.com/apache/doris/pull/38807#issuecomment-2272762186 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Json) fix some cast issue [doris]
github-actions[bot] commented on PR #38683: URL: https://github.com/apache/doris/pull/38683#issuecomment-2272762274 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](iceberg)]support doris's char/varchar to iceberg's string [doris]
github-actions[bot] commented on PR #38807: URL: https://github.com/apache/doris/pull/38807#issuecomment-2272762250 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Revert "[Opt](heartbeat) improve the tolerance of the cluster to occasional heartbeat failures" [doris]
doris-robot commented on PR #39021: URL: https://github.com/apache/doris/pull/39021#issuecomment-2272763503 TPC-DS: Total hot run time: 169323 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 3081fae10cd22472c0f8ee260c13089cec102181, data reload: false query1 915 373 365 365 query2 6455171017111710 query3 6669213 222 213 query4 19076 17419 17322 17322 query5 3655523 505 505 query6 266 168 163 163 query7 4588290 296 290 query8 249 188 187 187 query9 8519232623082308 query10 427 276 263 263 query11 10436 10159 99379937 query12 119 88 90 88 query13 1642372 369 369 query14 8354742175857421 query15 214 159 169 159 query16 6852467 443 443 query17 954 575 559 559 query18 1886287 310 287 query19 192 154 150 150 query20 92 86 87 86 query21 207 106 102 102 query22 4306407039853985 query23 33836 33993 33380 33380 query24 10016 318931373137 query25 689 400 404 400 query26 1749156 154 154 query27 2952271 294 271 query28 7591197719771977 query29 1243441 435 435 query30 246 160 155 155 query31 955 755 784 755 query32 102 55 57 55 query33 693 320 334 320 query34 945 486 508 486 query35 908 766 756 756 query36 1050900 913 900 query37 199 81 84 81 query38 2967294027722772 query39 876 822 822 822 query40 252 112 108 108 query41 49 43 44 43 query42 121 98 103 98 query43 454 431 426 426 query44 1177712 716 712 query45 209 182 177 177 query46 1093809 798 798 query47 1836173417411734 query48 354 288 282 282 query49 919 428 423 423 query50 894 421 429 421 query51 6829663967376639 query52 102 88 87 87 query53 257 184 181 181 query54 646 446 452 446 query55 73 73 71 71 query56 265 274 255 255 query57 1154100510471005 query58 265 256 260 256 query59 2593228023022280 query60 308 274 264 264 query61 95 88 90 88 query62 879 659 666 659 query63 218 180 178 178 query64 5652193618611861 query65 3151308630933086 query66 1273331 342 331 query67 15170 14959 14633 14633 query68 4301556 574 556 query69 429 291 290 290 query70 1062103910641039 query71 444 282 277 277 query72 7162264324682468 query73 772 329 329 329 query74 6002570956565656 query75 3390272527452725 query76 2686119713381197 query77 431 301 297 297 query78 9486900689198919 query79 2742540 532 532 query80 1195507 524 507 query81 563 234 229 229 query82 845 140 132 132 query83 239 174 164 164 query84 269 81 78 78 query85 1466318 299 299 query86 485 285 312 285 query87 3292307630873076 query88 3847239324622393 query89 385 289 283 283 query90 1822190 189 189 query91 123 100 100 100 query92 61 50 48 48 query93 2190611 612 611 query94 814 288 290 288 query95 378 265 263 263 query96 608 280 283 280 query97 3231307030343034 query98 221 196 202 196 query99 1581127312821273 Total cold run time: 261900 ms Total hot run time: 169323 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [Fix](Json) fix some cast issue [doris]
xiaokang merged PR #38683: URL: https://github.com/apache/doris/pull/38683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (5e12f6789fa -> 353c04ee436)
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 5e12f6789fa [fix](case) adjust ak sk for multi cloud test case (#38749) add 353c04ee436 [Fix](Json) fix some cast issue (#38683) No new revisions were added by this update. Summary of changes: be/src/vec/functions/function_cast.h | 27 +++- .../data/datatype_p0/json/json_cast.out| 37 ++- .../data/json_p0/test_json_load_and_function.out | 76 +++--- .../test_json_load_unique_key_and_function.out | 64 +- .../data/jsonb_p0/test_jsonb_load_and_function.out | 76 +++--- .../test_jsonb_load_unique_key_and_function.out| 64 +- .../data/nereids_function_p0/scalar_function/J.out | 76 +++--- .../json_p0/test_json_load_and_function.out| 76 +++--- .../test_json_load_unique_key_and_function.out | 64 +- .../test_jsonb_load_unique_key_and_function.out| 64 +- .../suites/datatype_p0/json/json_cast.groovy | 14 11 files changed, 354 insertions(+), 284 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Fix](Json) fix some cast issue (#38683) [doris]
eldenmoon opened a new pull request, #39025: URL: https://github.com/apache/doris/pull/39025 #38683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Json) fix some cast issue (#38683) [doris]
eldenmoon commented on PR #39025: URL: https://github.com/apache/doris/pull/39025#issuecomment-2272766433 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Json) fix some cast issue (#38683) [doris]
doris-robot commented on PR #39025: URL: https://github.com/apache/doris/pull/39025#issuecomment-2272766430 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Revert "[Opt](heartbeat) improve the tolerance of the cluster to occasional heartbeat failures" [doris]
hello-stephen merged PR #39021: URL: https://github.com/apache/doris/pull/39021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: Revert "[Opt](heartbeat) improve the tolerance of the cluster to occasional heartbeat failures" (#39021)
This is an automated email from the ASF dual-hosted git repository.
hellostephen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new a5df5ee8879 Revert "[Opt](heartbeat) improve the tolerance of the
cluster to occasional heartbeat failures" (#39021)
a5df5ee8879 is described below
commit a5df5ee88797262261ef705b38b5eedc8d09aa47
Author: Xin Liao
AuthorDate: Wed Aug 7 15:06:50 2024 +0800
Revert "[Opt](heartbeat) improve the tolerance of the cluster to occasional
heartbeat failures" (#39021)
Reverts apache/doris#38896
---
fe/fe-common/src/main/java/org/apache/doris/common/Config.java| 4 ++--
fe/fe-core/src/test/java/org/apache/doris/clone/TabletHealthTest.java | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/fe/fe-common/src/main/java/org/apache/doris/common/Config.java
b/fe/fe-common/src/main/java/org/apache/doris/common/Config.java
index ff7078b7e3a..c8db6482428 100644
--- a/fe/fe-common/src/main/java/org/apache/doris/common/Config.java
+++ b/fe/fe-common/src/main/java/org/apache/doris/common/Config.java
@@ -1923,12 +1923,12 @@ public class Config extends ConfigBase {
/**
* Maximum backend heartbeat failure tolerance count.
- * Default is 3, which means if 3 heart failed, the backend will be marked
as dead.
+ * Default is 1, which means if 1 heart failed, the backend will be marked
as dead.
* A larger value can improve the tolerance of the cluster to occasional
heartbeat failures.
* For example, when running regression tests, this value can be increased.
*/
@ConfField(mutable = true, masterOnly = true)
-public static long max_backend_heartbeat_failure_tolerance_count = 3;
+public static long max_backend_heartbeat_failure_tolerance_count = 1;
/**
* Abort transaction time after lost heartbeat.
diff --git
a/fe/fe-core/src/test/java/org/apache/doris/clone/TabletHealthTest.java
b/fe/fe-core/src/test/java/org/apache/doris/clone/TabletHealthTest.java
index 7949352eeb3..b22925e5d89 100644
--- a/fe/fe-core/src/test/java/org/apache/doris/clone/TabletHealthTest.java
+++ b/fe/fe-core/src/test/java/org/apache/doris/clone/TabletHealthTest.java
@@ -61,7 +61,6 @@ public class TabletHealthTest extends TestWithFeService {
Config.colocate_group_relocate_delay_second = -1000; // be dead will
imm relocate
Config.tablet_schedule_interval_ms = 7200_000L; //disable schedule
Config.tablet_checker_interval_ms = 7200_000L; //disable checker
-Config.max_backend_heartbeat_failure_tolerance_count = 1;
}
@Override
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]
sollhui commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2272772939 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Revert "[Opt](heartbeat) improve the tolerance of the cluster to occasional heartbeat failures" [doris]
doris-robot commented on PR #39021: URL: https://github.com/apache/doris/pull/39021#issuecomment-2272772130 ClickBench: Total hot run time: 30.18 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 3081fae10cd22472c0f8ee260c13089cec102181, data reload: false query1 0.040.040.03 query2 0.070.040.04 query3 0.220.050.05 query4 1.690.070.07 query5 0.510.480.49 query6 1.140.720.72 query7 0.020.010.02 query8 0.050.040.05 query9 0.580.530.53 query10 0.560.570.58 query11 0.150.110.12 query12 0.150.130.12 query13 0.610.620.59 query14 0.770.800.81 query15 0.890.850.86 query16 0.350.360.36 query17 1.000.991.01 query18 0.220.200.22 query19 1.891.711.80 query20 0.010.010.01 query21 15.39 0.730.66 query22 4.017.211.46 query23 17.83 1.311.26 query24 2.240.220.22 query25 0.170.080.08 query26 0.310.210.22 query27 0.460.240.22 query28 13.22 1.050.98 query29 12.54 3.313.31 query30 0.260.060.06 query31 2.880.420.40 query32 3.230.480.49 query33 2.922.992.95 query34 15.42 4.264.27 query35 4.284.294.27 query36 0.680.490.47 query37 0.190.170.16 query38 0.160.160.15 query39 0.050.040.04 query40 0.160.130.14 query41 0.090.050.05 query42 0.060.040.05 query43 0.040.040.04 Total cold run time: 107.51 s Total hot run time: 30.18 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Bug](rf) fix rf of in filter cast data as string maybe return wrong result [doris]
zhangstar333 opened a new pull request, #39026:
URL: https://github.com/apache/doris/pull/39026
two point have changed:
1. in batch_assign function:
const std::string& string_value = column.stringval();
if call **insert(&string_value)**, will cast as string_ref:
reinterpret_cast(data), this maybe error;
```
void insert(const void* data) override {
if (data == nullptr) {
_contains_null = true;
return;
}
const auto* value = reinterpret_cast(data);
std::string str_value(value->data, value->size);
_set.insert(str_value);
}
```
2. in batch_copy function, will cast void_value as T*
but the it->get_value() return is StringRef, so need change T as StringRef
```
template
void batch_copy(PInFilter* filter, HybridSetBase::IteratorBase* it,
void (*set_func)(PColumnValue*, const T*)) {
while (it->has_next()) {
const void* void_value = it->get_value();
auto origin_value = reinterpret_cast(void_value);
set_func(filter->add_values(), origin_value);
it->next();
}
}
```
## Proposed changes
Issue Number: close #xxx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](rf) fix rf of in filter cast data as string maybe return wrong result [doris]
zhangstar333 commented on PR #39026: URL: https://github.com/apache/doris/pull/39026#issuecomment-2272773792 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](rf) fix rf of in filter cast data as string maybe return wrong result [doris]
doris-robot commented on PR #39026: URL: https://github.com/apache/doris/pull/39026#issuecomment-2272773644 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [feature](pipeline) check nullable in SET operator [doris]
Mryange opened a new pull request, #39027: URL: https://github.com/apache/doris/pull/39027 ## Proposed changes There are some issues where planning problems lead to discrepancies between the nullable attribute of the computed column and the expected output column. ``` [INTERNAL_ERROR]SET operator expects a nullalbe : true column in column 0, but the computed output is a nullable : false column ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipeline) check nullable in SET operator [doris]
doris-robot commented on PR #39027: URL: https://github.com/apache/doris/pull/39027#issuecomment-2272777112 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipeline) check nullable in SET operator [doris]
Mryange commented on PR #39027: URL: https://github.com/apache/doris/pull/39027#issuecomment-2272777243 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Json) fix some cast issue (#38683) [doris]
github-actions[bot] commented on PR #39025: URL: https://github.com/apache/doris/pull/39025#issuecomment-2272778048 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](statistics)Return -1 when external table row count is unknown. [doris]
Jibing-Li commented on code in PR #38990:
URL: https://github.com/apache/doris/pull/38990#discussion_r1706485695
##
fe/fe-core/src/main/java/org/apache/doris/datasource/paimon/PaimonExternalTable.java:
##
@@ -187,22 +187,17 @@ public BaseAnalysisTask createAnalysisTask(AnalysisInfo
info) {
@Override
public long fetchRowCount() {
makeSureInitialized();
-try {
-long rowCount = 0;
-Optional schemaCacheValue =
getSchemaCacheValue();
-Table paimonTable = schemaCacheValue.map(value ->
((PaimonSchemaCacheValue) value).getPaimonTable())
-.orElse(null);
-if (paimonTable == null) {
-return -1;
-}
-List splits =
paimonTable.newReadBuilder().newScan().plan().splits();
-for (Split split : splits) {
-rowCount += split.rowCount();
-}
-return rowCount;
-} catch (Exception e) {
-LOG.warn("Fail to collect row count for db {} table {}", dbName,
name, e);
+long rowCount = 0;
+Optional schemaCacheValue = getSchemaCacheValue();
+Table paimonTable = schemaCacheValue.map(value ->
((PaimonSchemaCacheValue) value).getPaimonTable())
+.orElse(null);
+if (paimonTable == null) {
+return -1;
+}
+List splits =
paimonTable.newReadBuilder().newScan().plan().splits();
Review Comment:
This could be expensive when the table is large. But it's not related to
this pr, we can try to improve this in a separate pr if needed.
##
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergUtils.java:
##
@@ -592,22 +592,17 @@ public static List getSchema(ExternalCatalog
catalog, String dbName, Str
* @return estimated row count
*/
public static long getIcebergRowCount(ExternalCatalog catalog, String
dbName, String tbName) {
-try {
-Table icebergTable = Env.getCurrentEnv()
-.getExtMetaCacheMgr()
-.getIcebergMetadataCache()
-.getIcebergTable(catalog, dbName, tbName);
-Snapshot snapshot = icebergTable.currentSnapshot();
-if (snapshot == null) {
-// empty table
-return 0;
-}
-Map summary = snapshot.summary();
-return Long.parseLong(summary.get(TOTAL_RECORDS)) -
Long.parseLong(summary.get(TOTAL_POSITION_DELETES));
-} catch (Exception e) {
-LOG.warn("Fail to collect row count for db {} table {}", dbName,
tbName, e);
+Table icebergTable = Env.getCurrentEnv()
+.getExtMetaCacheMgr()
+.getIcebergMetadataCache()
+.getIcebergTable(catalog, dbName, tbName);
+Snapshot snapshot = icebergTable.currentSnapshot();
Review Comment:
I checked the code, the table may be null when the iceberg metadata cache is
not loaded. But I think it's not a problem, because the NPE would be caught in
the caller and return the default value -1. Meanwhile it will trigger iceberg
metadata cache to load the table so we can get it next time. I think we can fix
this in a separate pr if needed. But I feel we don't need to do anything about
it right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](statistics)Return -1 when external table row count is unknown. [doris]
Jibing-Li commented on PR #38990: URL: https://github.com/apache/doris/pull/38990#issuecomment-2272781252 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [Chore](load) return error reason when database/table not founded when stream load (#38967)
This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 3aadf92e559 [Chore](load) return error reason when database/table not
founded when stream load (#38967)
3aadf92e559 is described below
commit 3aadf92e55939da546e7323140bef8d61ca1a983
Author: Pxl
AuthorDate: Wed Aug 7 15:14:31 2024 +0800
[Chore](load) return error reason when database/table not founded when
stream load (#38967)
## Proposed changes
return error reason when database/table not founded when stream load
---
.../main/java/org/apache/doris/httpv2/rest/LoadAction.java | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/LoadAction.java
b/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/LoadAction.java
index 8bdc88a9c22..c2d50460ea4 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/LoadAction.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/LoadAction.java
@@ -62,6 +62,7 @@ import java.net.InetAddress;
import java.net.URI;
import java.util.Enumeration;
import java.util.List;
+import java.util.Optional;
import java.util.Set;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
@@ -293,8 +294,17 @@ public class LoadAction extends RestBaseController {
return new RestBaseResult(e.getMessage());
}
} else {
-long tableId = ((OlapTable) ((Database)
Env.getCurrentEnv().getCurrentCatalog().getDb(dbName)
-.get()).getTable(tableName).get()).getId();
+Optional database =
Env.getCurrentEnv().getCurrentCatalog().getDb(dbName);
+if (!database.isPresent()) {
+return new RestBaseResult("Database not founded.");
+}
+
+Optional olapTable = ((Database)
database.get()).getTable(tableName);
+if (!olapTable.isPresent()) {
+return new RestBaseResult("OlapTable not founded.");
+}
+
+long tableId = ((OlapTable) olapTable.get()).getId();
redirectAddr = selectRedirectBackend(request, groupCommit,
tableId);
}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](load) return error reason when database/table not founded when stream load [doris]
BiteThet merged PR #38967: URL: https://github.com/apache/doris/pull/38967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](load) return error reason when database/table not founded when stream load [doris]
github-actions[bot] commented on PR #38967: URL: https://github.com/apache/doris/pull/38967#issuecomment-2272783632 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](rf) fix rf of in filter cast data as string maybe return wrong result [doris]
github-actions[bot] commented on PR #39026: URL: https://github.com/apache/doris/pull/39026#issuecomment-2272784341 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cluster key) cluster key support vertical_segment_writer [doris]
github-actions[bot] commented on PR #38538: URL: https://github.com/apache/doris/pull/38538#issuecomment-2272785244 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cluster key) cluster key support vertical_segment_writer [doris]
github-actions[bot] commented on PR #38538: URL: https://github.com/apache/doris/pull/38538#issuecomment-2272785323 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](merge-on-write) Skip the alignment process of some rowsets in partial update #38487 [doris]
zhannngchen commented on PR #38686: URL: https://github.com/apache/doris/pull/38686#issuecomment-2272788175 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipeline) check nullable in SET operator [doris]
github-actions[bot] commented on PR #39027: URL: https://github.com/apache/doris/pull/39027#issuecomment-2272788446 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](mtmv) Fix select literal result wrongly in group by when use materialized view [doris]
seawinde commented on PR #38958: URL: https://github.com/apache/doris/pull/38958#issuecomment-2272792603 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](memory) Fix Allocator release memory to correct MemTracker after TLS attach task ends [doris]
xinyiZzz commented on PR #38959: URL: https://github.com/apache/doris/pull/38959#issuecomment-2272796047 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](runtime-filter) send RUNTIME_BLOOM_FILTER_MAX_SIZE to backends [doris]
BiteThet merged PR #38972: URL: https://github.com/apache/doris/pull/38972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (3aadf92e559 -> 44ac169dd48)
This is an automated email from the ASF dual-hosted git repository. panxiaolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 3aadf92e559 [Chore](load) return error reason when database/table not founded when stream load (#38967) add 44ac169dd48 [Improvement](runtime-filter) send RUNTIME_BLOOM_FILTER_MAX_SIZE to backends (#38972) No new revisions were added by this update. Summary of changes: be/src/exprs/bloom_filter_func.h | 31 +- be/src/exprs/runtime_filter.cpp| 3 +++ be/src/exprs/runtime_filter.h | 1 + .../java/org/apache/doris/qe/SessionVariable.java | 1 + gensrc/thrift/PaloInternalService.thrift | 2 ++ 5 files changed, 25 insertions(+), 13 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](inverted index) fix multi match result error [doris]
zzzxl1993 commented on PR #38931: URL: https://github.com/apache/doris/pull/38931#issuecomment-2272797166 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [feature](restore) Support clean_restore property for restore job [doris]
w41ter opened a new pull request, #39028: URL: https://github.com/apache/doris/pull/39028 The restore will keep the existing tables/partitions in which the restore target is not contained, this PR adds a property clean_restore to indicate that the restore job needs to recycle those tables/partitions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](restore) Support clean_restore property for restore job [doris]
doris-robot commented on PR #39028: URL: https://github.com/apache/doris/pull/39028#issuecomment-2272798198 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) lock table when generate distribute plan (#38950) [doris]
doris-robot commented on PR #39029: URL: https://github.com/apache/doris/pull/39029#issuecomment-2272798851 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) lock table when generate distribute plan (#38950) [doris]
924060929 commented on PR #39029: URL: https://github.com/apache/doris/pull/39029#issuecomment-2272798920 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](restore) Support clean_restore property for restore job [doris]
w41ter commented on PR #39028: URL: https://github.com/apache/doris/pull/39028#issuecomment-2272798324 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](Nereids) lock table when generate distribute plan (#38950) [doris]
924060929 opened a new pull request, #39029: URL: https://github.com/apache/doris/pull/39029 cherry pick from #38950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](function) MicroSecondsSub without scale [doris]
Mryange commented on PR #38945: URL: https://github.com/apache/doris/pull/38945#issuecomment-2272799412 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [WIP](assert_cast) Opt assert cast [doris]
zhiqiang- opened a new pull request, #39030: URL: https://github.com/apache/doris/pull/39030 ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [WIP](assert_cast) Opt assert cast [doris]
doris-robot commented on PR #39030: URL: https://github.com/apache/doris/pull/39030#issuecomment-2272800738 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](regression-test) agg schema value add case [doris]
cjj2010 commented on PR #38968: URL: https://github.com/apache/doris/pull/38968#issuecomment-2272801962 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](rf) fix rf of in filter cast data as string maybe return wrong result [doris]
doris-robot commented on PR #39026: URL: https://github.com/apache/doris/pull/39026#issuecomment-2272804415 TPC-H: Total hot run time: 41518 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 5286a06da54f5a2097e5429ab68564c39c94364a, data reload: false -- Round 1 -- q1 18813 426541364136 q2 2489205 199 199 q3 11146 128213451282 q4 10581 795 946 795 q5 7902299130042991 q6 224 144 142 142 q7 1047619 620 619 q8 9433189019601890 q9 8506661165946594 q10 8712383538753835 q11 442 254 256 254 q12 417 226 223 223 q13 17760 292229482922 q14 281 242 245 242 q15 519 482 508 482 q16 487 403 385 385 q17 972 911 888 888 q18 8069725472387238 q19 1380120312071203 q20 567 318 320 318 q21 5321460747944607 q22 353 273 279 273 Total cold run time: 115421 ms Total hot run time: 41518 ms - Round 2, with runtime_filter_mode=off - q1 4034401640494016 q2 324 229 241 229 q3 2993299229762976 q4 1884186518591859 q5 5233519852215198 q6 218 130 131 130 q7 2045169816281628 q8 3176323232373232 q9 8307835382688268 q10 3709381538263815 q11 543 455 448 448 q12 732 582 529 529 q13 13627 294429392939 q14 288 256 255 255 q15 517 474 488 474 q16 448 399 399 399 q17 1734170016951695 q18 7767731271537153 q19 1659166216611661 q20 1968174817471747 q21 5488511750355035 q22 510 451 440 440 Total cold run time: 67204 ms Total hot run time: 54126 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2272805143 TPC-H: Total hot run time: 41324 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit e5c472c4c103fc1d19ec9bf288f7d28bd6d68872, data reload: false -- Round 1 -- q1 17626 404440194019 q2 2020198 201 198 q3 10442 126413441264 q4 10175 784 907 784 q5 7567293629472936 q6 219 136 134 134 q7 1026609 599 599 q8 9425191319361913 q9 8487659666056596 q10 8719382938313829 q11 427 243 247 243 q12 422 230 224 224 q13 17764 291929252919 q14 272 243 249 243 q15 527 488 490 488 q16 526 396 386 386 q17 957 938 927 927 q18 8021728172207220 q19 2983115712141157 q20 555 320 331 320 q21 5273464948304649 q22 347 280 276 276 Total cold run time: 113780 ms Total hot run time: 41324 ms - Round 2, with runtime_filter_mode=off - q1 4101401940074007 q2 327 228 220 220 q3 2985302231533022 q4 1992203719581958 q5 5564547254255425 q6 214 139 127 127 q7 2073178218611782 q8 3252337833183318 q9 8641863087848630 q10 3935407838303830 q11 537 462 443 443 q12 758 623 574 574 q13 16365 310731213107 q14 306 269 276 269 q15 525 512 492 492 q16 455 417 426 417 q17 1753172917441729 q18 8251778676707670 q19 1748173417091709 q20 2060187718231823 q21 5671543252505250 q22 509 472 458 458 Total cold run time: 72022 ms Total hot run time: 56260 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](inverted index) fix multi match result error [doris]
github-actions[bot] commented on PR #38931: URL: https://github.com/apache/doris/pull/38931#issuecomment-2272808129 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](inverted index) fix multi match result error [doris]
github-actions[bot] commented on PR #38931: URL: https://github.com/apache/doris/pull/38931#issuecomment-2272808659 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](statistics)Return -1 when external table row count is unknown. [doris]
doris-robot commented on PR #38990: URL: https://github.com/apache/doris/pull/38990#issuecomment-2272808669 TPC-H: Total hot run time: 41066 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 5ecce2c972dccaffdb84dbb8e00f53bd1654a522, data reload: false -- Round 1 -- q1 17714 407040404040 q2 2022202 192 192 q3 10476 124813411248 q4 10153 813 842 813 q5 7610293529492935 q6 219 135 134 134 q7 1035608 607 607 q8 9429178819541788 q9 8404654665366536 q10 8753382938003800 q11 437 248 246 246 q12 412 233 224 224 q13 17752 295529182918 q14 268 244 243 243 q15 521 476 487 476 q16 517 387 389 387 q17 961 927 917 917 q18 8089733171997199 q19 3058107012101070 q20 550 327 344 327 q21 5239468847004688 q22 347 278 283 278 Total cold run time: 113966 ms Total hot run time: 41066 ms - Round 2, with runtime_filter_mode=off - q1 4091403239933993 q2 324 223 220 220 q3 2991296431282964 q4 2002198019461946 q5 5615544454335433 q6 221 130 129 129 q7 2122180318501803 q8 3287335833363336 q9 8587860186398601 q10 3971404339033903 q11 568 466 466 466 q12 804 561 609 561 q13 16389 310431223104 q14 295 287 283 283 q15 542 494 478 478 q16 463 415 429 415 q17 1775170617451706 q18 8207767876717671 q19 1782170217071702 q20 2129184618461846 q21 5772544352165216 q22 528 466 477 466 Total cold run time: 72465 ms Total hot run time: 56242 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](restore) Support clean_restore property for restore job [doris]
github-actions[bot] commented on PR #39028: URL: https://github.com/apache/doris/pull/39028#issuecomment-2272808818 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improve](columns)replace fatal with exception [doris]
amorynan commented on PR #38996: URL: https://github.com/apache/doris/pull/38996#issuecomment-2272811265 run compile -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improve](columns)replace fatal with exception [doris]
amorynan commented on PR #38996: URL: https://github.com/apache/doris/pull/38996#issuecomment-2272811433 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](local exchange) Fix EOS processing in local exchanger [doris]
Gabriel39 opened a new pull request, #39031: URL: https://github.com/apache/doris/pull/39031 ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](local exchange) Fix EOS processing in local exchanger [doris]
doris-robot commented on PR #39031: URL: https://github.com/apache/doris/pull/39031#issuecomment-2272814374 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](catalog) modify some meta cache logic [doris]
doris-robot commented on PR #38506: URL: https://github.com/apache/doris/pull/38506#issuecomment-2272814264 TPC-H: Total hot run time: 41715 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 0485f5fa13af987ea9a186ca594ef575777a53a2, data reload: false -- Round 1 -- q1 17673 405740634057 q2 2019199 208 199 q3 10444 133913631339 q4 10166 854 919 854 q5 7608300129652965 q6 220 138 138 138 q7 1062628 613 613 q8 9455186319451863 q9 8506658165686568 q10 8785387338673867 q11 434 245 242 242 q12 406 229 236 229 q13 17755 294429462944 q14 280 247 244 244 q15 518 486 475 475 q16 522 390 388 388 q17 968 945 917 917 q18 8080736872887288 q19 1521121912081208 q20 552 331 354 331 q21 5306473847114711 q22 349 275 276 275 Total cold run time: 112629 ms Total hot run time: 41715 ms - Round 2, with runtime_filter_mode=off - q1 4051403140014001 q2 330 231 223 223 q3 2989299631792996 q4 1987203519641964 q5 5591548354775477 q6 222 129 129 129 q7 2120182718291827 q8 3281334433423342 q9 8638871487688714 q10 3939400239083908 q11 545 467 475 467 q12 819 593 588 588 q13 16349 307931163079 q14 316 288 266 266 q15 542 496 476 476 q16 462 424 421 421 q17 1765173317381733 q18 8192781176947694 q19 1763170017021700 q20 2108183618481836 q21 5692540452655265 q22 524 477 466 466 Total cold run time: 72225 ms Total hot run time: 56572 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](mtmv) Fix rewrite by materialized view fail when query hive table [doris]
github-actions[bot] commented on PR #38909: URL: https://github.com/apache/doris/pull/38909#issuecomment-2272818873 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipeline) check nullable in SET operator [doris]
doris-robot commented on PR #39027: URL: https://github.com/apache/doris/pull/39027#issuecomment-2272818599 TPC-H: Total hot run time: 41715 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 043dc916b120a713f3ec33c46ffc6299f6309514, data reload: false -- Round 1 -- q1 17709 443541544154 q2 2034206 191 191 q3 10598 144213711371 q4 10260 815 932 815 q5 7665293829542938 q6 220 139 136 136 q7 1080614 611 611 q8 9432176219481762 q9 8492667266616661 q10 8748381438563814 q11 429 247 250 247 q12 420 225 223 223 q13 17756 294429282928 q14 278 244 243 243 q15 516 487 496 487 q16 530 413 389 389 q17 976 947 920 920 q18 8140739772717271 q19 1440122312081208 q20 576 327 338 327 q21 5334474747794747 q22 355 279 272 272 Total cold run time: 112988 ms Total hot run time: 41715 ms - Round 2, with runtime_filter_mode=off - q1 4074400140264001 q2 327 223 221 221 q3 3004298431532984 q4 1993205919651965 q5 5604545054365436 q6 219 128 127 127 q7 2144178918101789 q8 3307335833773358 q9 8621862287788622 q10 3964403839043904 q11 550 456 468 456 q12 807 581 618 581 q13 16225 313130713071 q14 314 273 277 273 q15 571 486 506 486 q16 480 406 413 406 q17 1781174917461746 q18 8252777877257725 q19 1719171217051705 q20 2038187918061806 q21 5707549152985298 q22 503 462 453 453 Total cold run time: 72204 ms Total hot run time: 56413 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](local exchange) Fix EOS processing in local exchanger [doris]
Gabriel39 commented on PR #39031: URL: https://github.com/apache/doris/pull/39031#issuecomment-2272820115 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [WIP](assert_cast) Opt assert cast [doris]
github-actions[bot] commented on PR #39030: URL: https://github.com/apache/doris/pull/39030#issuecomment-2272820329 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](mtmv) Fix select literal result wrongly in group by when use materialized view [doris]
doris-robot commented on PR #38958: URL: https://github.com/apache/doris/pull/38958#issuecomment-2272820793 TPC-H: Total hot run time: 41748 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 6a74ccb64cf2d437b35b87fcf82a4d8a129e225c, data reload: false -- Round 1 -- q1 17656 412840374037 q2 2030202 197 197 q3 10548 127013651270 q4 10186 853 914 853 q5 7660295929552955 q6 223 140 140 140 q7 1053615 610 610 q8 9434190519541905 q9 8487656665656565 q10 8772385638503850 q11 444 248 248 248 q12 446 235 232 232 q13 17779 294029422940 q14 276 242 250 242 q15 529 495 506 495 q16 522 390 390 390 q17 971 907 893 893 q18 7983751973117311 q19 1629122312091209 q20 558 336 340 336 q21 5319479448004794 q22 353 281 276 276 Total cold run time: 112858 ms Total hot run time: 41748 ms - Round 2, with runtime_filter_mode=off - q1 4068402540484025 q2 327 221 224 221 q3 2994302131383021 q4 1980201719661966 q5 5572549254585458 q6 218 134 136 134 q7 2140186818491849 q8 3306335133563351 q9 8669870487248704 q10 4032393439943934 q11 554 477 469 469 q12 783 606 581 581 q13 16444 312931423129 q14 304 297 270 270 q15 537 487 505 487 q16 468 428 433 428 q17 1750171617431716 q18 8318774676697669 q19 1705173917361736 q20 2064186818551855 q21 5635543652365236 q22 525 445 471 445 Total cold run time: 72393 ms Total hot run time: 56684 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [WIP](assert_cast) Opt assert cast [doris]
github-actions[bot] commented on PR #39030: URL: https://github.com/apache/doris/pull/39030#issuecomment-2272821694 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2272822776 TPC-DS: Total hot run time: 169813 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit e5c472c4c103fc1d19ec9bf288f7d28bd6d68872, data reload: false query1 912 376 361 361 query2 6450171416761676 query3 6668211 226 211 query4 19848 17577 17445 17445 query5 3649528 505 505 query6 275 169 169 169 query7 4609294 290 290 query8 274 219 198 198 query9 8523232923362329 query10 443 278 269 269 query11 10570 10177 10273 10177 query12 123 93 86 86 query13 1650384 372 372 query14 9374675968026759 query15 198 162 168 162 query16 6826446 482 446 query17 938 551 558 551 query18 1923273 279 273 query19 184 140 141 140 query20 90 87 87 87 query21 205 103 100 100 query22 4438424942834249 query23 33852 33584 33647 33584 query24 10295 314831583148 query25 694 399 415 399 query26 1780153 148 148 query27 3078280 289 280 query28 7464197619711971 query29 1327426 412 412 query30 238 157 157 157 query31 967 792 761 761 query32 114 61 54 54 query33 695 333 332 332 query34 915 487 496 487 query35 839 792 761 761 query36 985 892 858 858 query37 250 81 77 77 query38 2903281127512751 query39 870 828 839 828 query40 254 114 114 114 query41 46 43 46 43 query42 120 105 105 105 query43 464 419 416 416 query44 1175720 731 720 query45 217 181 180 180 query46 1087787 770 770 query47 1870173417481734 query48 370 288 284 284 query49 928 422 421 421 query50 902 427 422 422 query51 6749666966696669 query52 100 86 88 86 query53 252 179 180 179 query54 619 443 440 440 query55 76 78 77 77 query56 274 250 250 250 query57 1148106010671060 query58 259 268 280 268 query59 2700247423132313 query60 321 267 277 267 query61 96 92 95 92 query62 882 661 670 661 query63 214 181 178 178 query64 5644188218521852 query65 3154308430823082 query66 1309328 345 328 query67 15223 14998 14901 14901 query68 4338560 581 560 query69 441 295 290 290 query70 1140102710521027 query71 408 277 275 275 query72 7090268025252525 query73 760 324 321 321 query74 6020570856305630 query75 3354273227222722 query76 2324120512861205 query77 415 303 318 303 query78 9505900288938893 query79 1685525 524 524 query80 1153487 493 487 query81 583 223 224 223 query82 1058132 130 130 query83 231 164 168 164 query84 260 82 77 77 query85 1201306 304 304 query86 400 301 310 301 query87 3286310630963096 query88 2875235723652357 query89 384 288 289 288 query90 1724200 191 191 query91 205 98 98 98 query92 57 51 50 50 query93 1534622 622 622 query94 788 302 291 291 query95 378 264 261 261 query96 596 277 273 273 query97 3200309030573057 query98 214 196 189 189 query99 1631131013041304 Total cold run time: 261127 ms Total hot run time: 169813 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th
Re: [PR] [Bug](rf) fix rf of in filter cast data as string maybe return wrong result [doris]
doris-robot commented on PR #39026: URL: https://github.com/apache/doris/pull/39026#issuecomment-2272822021 TPC-DS: Total hot run time: 168621 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 5286a06da54f5a2097e5429ab68564c39c94364a, data reload: false query1 920 371 361 361 query2 6488171416911691 query3 6669223 218 218 query4 20008 17508 17483 17483 query5 4306510 522 510 query6 298 175 181 175 query7 4620301 305 301 query8 275 208 195 195 query9 8500232123122312 query10 430 284 266 266 query11 10789 10128 10123 10123 query12 138 91 86 86 query13 1641383 375 375 query14 10014 690674116906 query15 195 157 167 157 query16 7025465 448 448 query17 946 575 543 543 query18 1855280 269 269 query19 192 149 142 142 query20 92 85 86 85 query21 211 102 97 97 query22 4279408939213921 query23 33479 33260 33191 33191 query24 10374 298330292983 query25 670 387 384 384 query26 1729152 154 152 query27 2717272 277 272 query28 6849194819411941 query29 1226425 414 414 query30 288 153 154 153 query31 943 743 756 743 query32 101 53 55 53 query33 713 308 323 308 query34 902 469 488 469 query35 841 727 732 727 query36 999 837 877 837 query37 277 81 78 78 query38 2890276827952768 query39 868 823 807 807 query40 288 111 111 111 query41 45 45 43 43 query42 111 98 97 97 query43 465 420 419 419 query44 1188720 712 712 query45 210 180 177 177 query46 1080822 776 776 query47 1800172017191719 query48 363 290 288 288 query49 1192431 450 431 query50 894 433 420 420 query51 6707660866596608 query52 105 87 90 87 query53 265 188 182 182 query54 634 447 469 447 query55 75 76 74 74 query56 271 246 264 246 query57 1163105610381038 query58 292 271 273 271 query59 2594244225422442 query60 302 288 262 262 query61 102 98 95 95 query62 920 665 664 664 query63 223 182 175 175 query64 5966192218691869 query65 3209307330783073 query66 1436332 327 327 query67 15365 14629 14837 14629 query68 4363585 589 585 query69 445 293 295 293 query70 1087106010551055 query71 424 287 319 287 query72 7203267625362536 query73 753 323 332 323 query74 6016567455685568 query75 3440269727252697 query76 2536119812871198 query77 436 309 309 309 query78 9458885989148859 query79 1371529 521 521 query80 1028526 504 504 query81 567 229 229 229 query82 1148131 129 129 query83 243 167 169 167 query84 273 78 76 76 query85 1324321 307 307 query86 393 296 309 296 query87 3304309730783078 query88 2975240223782378 query89 371 300 296 296 query90 1798192 193 192 query91 125 102 102 102 query92 58 53 51 51 query93 1384617 616 616 query94 882 290 302 290 query95 387 264 261 261 query96 597 277 281 277 query97 3220305030993050 query98 209 204 198 198 query99 1641127112671267 Total cold run time: 262481 ms Total hot run time: 168621 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
[PR] [Fix](merge-on-write) Fix a typo in #37670 [doris]
bobhan1 opened a new pull request, #39032: URL: https://github.com/apache/doris/pull/39032 ## Proposed changes fix a typo in https://github.com/apache/doris/pull/37670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](merge-on-write) Fix a typo in #37670 [doris]
doris-robot commented on PR #39032: URL: https://github.com/apache/doris/pull/39032#issuecomment-2272823383 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](merge-on-write) Fix a typo in #37670 [doris]
bobhan1 commented on PR #39032: URL: https://github.com/apache/doris/pull/39032#issuecomment-2272823918 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](local exchange) Fix EOS processing in local exchanger [doris]
github-actions[bot] commented on PR #39031: URL: https://github.com/apache/doris/pull/39031#issuecomment-2272825786 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](statistics)Return -1 when external table row count is unknown. [doris]
doris-robot commented on PR #38990: URL: https://github.com/apache/doris/pull/38990#issuecomment-2272826589 TPC-DS: Total hot run time: 169296 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 5ecce2c972dccaffdb84dbb8e00f53bd1654a522, data reload: false query1 926 365 362 362 query2 6455172116511651 query3 6665209 214 209 query4 20373 17421 17426 17421 query5 3676517 513 513 query6 275 161 164 161 query7 4591295 293 293 query8 259 195 201 195 query9 8510234423262326 query10 456 297 272 272 query11 10792 10099 10073 10073 query12 120 91 87 87 query13 1639381 381 381 query14 9998768869476947 query15 206 163 173 163 query16 6931463 460 460 query17 957 585 560 560 query18 1841288 285 285 query19 190 151 150 150 query20 93 86 89 86 query21 207 148 96 96 query22 4365412640504050 query23 33993 33428 33209 33209 query24 9222319230943094 query25 650 401 417 401 query26 1470152 152 152 query27 2823278 296 278 query28 7337200019851985 query29 1081440 440 440 query30 246 161 156 156 query31 943 786 776 776 query32 105 57 56 56 query33 679 306 322 306 query34 915 494 504 494 query35 899 761 774 761 query36 1022895 874 874 query37 178 81 80 80 query38 2903282728512827 query39 884 819 809 809 query40 250 110 110 110 query41 47 48 48 48 query42 115 99 100 99 query43 476 422 430 422 query44 1124722 752 722 query45 206 175 174 174 query46 1069790 806 790 query47 1848175017631750 query48 365 292 286 286 query49 944 418 417 417 query50 892 425 445 425 query51 6711668167466681 query52 100 91 91 91 query53 252 182 175 175 query54 610 449 448 448 query55 75 78 76 76 query56 266 247 254 247 query57 1123106610401040 query58 274 259 287 259 query59 2553240223462346 query60 293 280 277 277 query61 99 95 91 91 query62 913 650 662 650 query63 213 183 180 180 query64 5539188818851885 query65 3145307530993075 query66 1070329 327 327 query67 15213 14791 14770 14770 query68 6002575 588 575 query69 710 367 316 316 query70 1168108010111011 query71 434 272 267 267 query72 7526266225202520 query73 917 326 330 326 query74 6119571956605660 query75 3528274426912691 query76 3350126712231223 query77 653 312 307 307 query78 9509883887938793 query79 1373540 539 539 query80 842 512 509 509 query81 565 228 228 228 query82 835 138 131 131 query83 214 170 166 166 query84 272 76 78 76 query85 1464371 295 295 query86 470 312 305 305 query87 3305312731063106 query88 3693238023842380 query89 381 284 288 284 query90 1774194 194 194 query91 129 97 99 97 query92 59 51 55 51 query93 2027615 625 615 query94 777 302 282 282 query95 377 271 276 271 query96 615 283 280 280 query97 3266308330343034 query98 228 202 204 202 query99 1608129712621262 Total cold run time: 264850 ms Total hot run time: 169296 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [chore](nereids) Added compatibility with mysql alias filter [doris]
Toms1999 commented on PR #38640: URL: https://github.com/apache/doris/pull/38640#issuecomment-2272830226 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](rf) fix rf of in filter cast data as string maybe return wrong result [doris]
doris-robot commented on PR #39026: URL: https://github.com/apache/doris/pull/39026#issuecomment-2272831331 ClickBench: Total hot run time: 29.95 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 5286a06da54f5a2097e5429ab68564c39c94364a, data reload: false query1 0.040.040.03 query2 0.080.040.04 query3 0.220.040.04 query4 1.710.070.06 query5 0.480.510.48 query6 1.140.720.72 query7 0.020.010.01 query8 0.050.040.05 query9 0.580.540.51 query10 0.580.570.56 query11 0.160.110.12 query12 0.150.130.12 query13 0.610.610.60 query14 0.770.810.80 query15 0.930.860.86 query16 0.350.350.36 query17 0.971.001.00 query18 0.220.210.21 query19 1.791.771.74 query20 0.010.010.01 query21 15.42 0.740.64 query22 4.428.411.28 query23 18.07 1.331.36 query24 2.260.220.22 query25 0.190.080.08 query26 0.320.220.22 query27 0.450.230.23 query28 13.20 0.990.97 query29 12.58 3.303.27 query30 0.270.060.05 query31 2.880.400.40 query32 3.250.490.48 query33 2.912.992.93 query34 15.46 4.274.24 query35 4.304.254.31 query36 0.670.480.48 query37 0.180.160.16 query38 0.160.150.15 query39 0.040.040.03 query40 0.160.130.12 query41 0.100.050.05 query42 0.060.040.04 query43 0.050.040.04 Total cold run time: 108.26 s Total hot run time: 29.95 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2272832186 ClickBench: Total hot run time: 30.49 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit e5c472c4c103fc1d19ec9bf288f7d28bd6d68872, data reload: false query1 0.040.040.04 query2 0.080.040.04 query3 0.220.050.05 query4 1.670.080.07 query5 0.490.490.48 query6 1.140.720.71 query7 0.020.010.01 query8 0.050.050.04 query9 0.560.530.53 query10 0.550.580.56 query11 0.160.120.12 query12 0.150.120.12 query13 0.610.600.59 query14 0.770.790.79 query15 0.930.850.86 query16 0.350.350.35 query17 1.050.990.98 query18 0.220.210.20 query19 1.821.721.68 query20 0.010.010.01 query21 15.43 0.740.64 query22 4.337.051.73 query23 18.04 1.441.37 query24 2.280.220.22 query25 0.180.080.07 query26 0.330.210.21 query27 0.470.240.23 query28 13.16 0.990.97 query29 12.65 3.373.38 query30 0.260.050.05 query31 2.880.400.40 query32 3.220.500.48 query33 2.932.932.91 query34 15.45 4.244.26 query35 4.284.304.30 query36 0.670.480.47 query37 0.180.160.17 query38 0.160.150.16 query39 0.040.040.04 query40 0.160.130.13 query41 0.100.050.05 query42 0.060.050.04 query43 0.050.040.04 Total cold run time: 108.2 s Total hot run time: 30.49 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](catalog) modify some meta cache logic [doris]
doris-robot commented on PR #38506: URL: https://github.com/apache/doris/pull/38506#issuecomment-2272832198 TPC-DS: Total hot run time: 169388 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 0485f5fa13af987ea9a186ca594ef575777a53a2, data reload: false query1 912 383 367 367 query2 6460171517131713 query3 6650210 222 210 query4 19640 17584 17322 17322 query5 3647507 518 507 query6 289 188 172 172 query7 4596297 314 297 query8 256 202 198 198 query9 8534232623142314 query10 424 277 270 270 query11 10645 10110 10058 10058 query12 125 90 93 90 query13 1651380 364 364 query14 8506699577766995 query15 196 168 162 162 query16 6834425 465 425 query17 935 585 540 540 query18 1309278 279 278 query19 202 142 143 142 query20 93 92 83 83 query21 203 99 109 99 query22 4204416239733973 query23 33796 33843 33760 33760 query24 9354312430863086 query25 659 406 405 405 query26 1128154 155 154 query27 2401279 292 279 query28 6913199619721972 query29 878 442 455 442 query30 243 152 149 149 query31 940 784 803 784 query32 102 53 54 53 query33 668 332 322 322 query34 919 503 502 502 query35 869 766 770 766 query36 1038877 901 877 query37 154 81 82 81 query38 2912285727822782 query39 873 816 841 816 query40 224 115 115 115 query41 44 49 45 45 query42 122 99 108 99 query43 469 417 440 417 query44 1194723 714 714 query45 213 185 184 184 query46 1104808 789 789 query47 1811173717241724 query48 383 303 290 290 query49 904 417 434 417 query50 895 432 423 423 query51 6741671366436643 query52 110 87 89 87 query53 250 182 188 182 query54 631 442 445 442 query55 77 73 72 72 query56 277 259 255 255 query57 1116104410691044 query58 252 259 266 259 query59 2691234022832283 query60 311 268 274 268 query61 101 94 95 94 query62 856 655 650 650 query63 219 181 175 175 query64 4519190418621862 query65 3150308631293086 query66 831 324 330 324 query67 15110 14763 14921 14763 query68 4320563 572 563 query69 444 302 296 296 query70 1060104710561047 query71 379 275 274 274 query72 7066266124652465 query73 759 332 327 327 query74 6038571856225622 query75 3330271826912691 query76 2186121912901219 query77 430 304 307 304 query78 9316886089568860 query79 2422527 521 521 query80 1200501 500 500 query81 571 220 226 220 query82 1043130 135 130 query83 235 169 166 166 query84 257 79 83 79 query85 1160312 307 307 query86 455 282 289 282 query87 3273310930663066 query88 3018237223922372 query89 382 298 287 287 query90 1682190 188 188 query91 121 100 160 100 query92 60 48 49 48 query93 1952612 621 612 query94 804 306 295 295 query95 379 257 269 257 query96 604 279 280 279 query97 3226303530923035 query98 225 211 192 192 query99 1617126912791269 Total cold run time: 254777 ms Total hot run time: 169388 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [Fix](merge-on-write) Fix a typo in #37670 [doris]
github-actions[bot] commented on PR #39032: URL: https://github.com/apache/doris/pull/39032#issuecomment-2272833884 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](statistics)Return -1 when external table row count is unknown. [doris]
doris-robot commented on PR #38990: URL: https://github.com/apache/doris/pull/38990#issuecomment-2272835992 ClickBench: Total hot run time: 30.49 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 5ecce2c972dccaffdb84dbb8e00f53bd1654a522, data reload: false query1 0.050.050.04 query2 0.070.040.04 query3 0.220.050.05 query4 1.680.070.07 query5 0.480.480.47 query6 1.140.710.71 query7 0.020.010.01 query8 0.050.050.04 query9 0.560.520.52 query10 0.570.570.56 query11 0.150.110.11 query12 0.150.130.12 query13 0.620.600.60 query14 0.760.790.79 query15 0.900.870.85 query16 0.360.370.35 query17 1.000.990.98 query18 0.210.210.20 query19 1.781.721.72 query20 0.000.030.01 query21 15.39 0.750.64 query22 3.737.061.93 query23 18.08 1.261.29 query24 2.270.220.22 query25 0.190.080.08 query26 0.310.220.22 query27 0.450.230.23 query28 13.17 1.010.97 query29 12.56 3.273.28 query30 0.250.060.05 query31 2.870.420.40 query32 3.240.490.48 query33 2.942.982.92 query34 15.43 4.264.27 query35 4.274.274.30 query36 0.660.470.48 query37 0.190.160.16 query38 0.160.150.14 query39 0.040.040.03 query40 0.170.130.13 query41 0.110.040.04 query42 0.060.040.05 query43 0.050.040.05 Total cold run time: 107.36 s Total hot run time: 30.49 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipeline) check nullable in SET operator [doris]
doris-robot commented on PR #39027: URL: https://github.com/apache/doris/pull/39027#issuecomment-2272837174 TPC-DS: Total hot run time: 169387 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 043dc916b120a713f3ec33c46ffc6299f6309514, data reload: false query1 916 382 375 375 query2 6480175216711671 query3 6653212 226 212 query4 19156 17447 17566 17447 query5 3632514 516 514 query6 300 182 169 169 query7 4593311 293 293 query8 258 214 194 194 query9 8482230823062306 query10 421 282 261 261 query11 10565 10110 10053 10053 query12 118 92 85 85 query13 1624376 390 376 query14 10025 610467916104 query15 212 168 167 167 query16 6786453 467 453 query17 928 546 532 532 query18 1812285 278 278 query19 197 145 142 142 query20 92 82 85 82 query21 206 97 99 97 query22 4267394938673867 query23 33523 33671 33680 33671 query24 10113 312130853085 query25 687 411 442 411 query26 1718149 150 149 query27 3008280 280 280 query28 7593200019821982 query29 1243429 428 428 query30 241 152 154 152 query31 925 786 808 786 query32 103 53 60 53 query33 693 322 333 322 query34 937 483 513 483 query35 881 796 758 758 query36 1034911 897 897 query37 264 84 86 84 query38 3020282128142814 query39 926 818 824 818 query40 295 120 121 120 query41 47 48 47 47 query42 122 102 104 102 query43 486 432 431 431 query44 1181735 733 733 query45 220 178 186 178 query46 1086802 796 796 query47 1826172917321729 query48 373 295 294 294 query49 1025448 447 447 query50 892 436 434 434 query51 6682675266826682 query52 100 92 90 90 query53 261 187 183 183 query54 621 453 464 453 query55 79 78 76 76 query56 286 277 280 277 query57 1167108110401040 query58 270 294 285 285 query59 2581246324532453 query60 311 290 298 290 query61 117 112 111 111 query62 909 672 656 656 query63 218 196 186 186 query64 5753199219581958 query65 3194308531063085 query66 1300346 340 340 query67 15334 14908 14804 14804 query68 4371576 584 576 query69 626 345 346 345 query70 1122980 1041980 query71 461 294 290 290 query72 8010282527212721 query73 776 330 332 330 query74 6056563256655632 query75 3557274227332733 query76 2617117513041175 query77 656 315 326 315 query78 9591891588088808 query79 6832529 528 528 query80 2216538 506 506 query81 569 233 229 229 query82 787 130 131 130 query83 285 177 166 166 query84 267 81 78 78 query85 1491305 307 305 query86 449 283 297 283 query87 3322310931143109 query88 4547240323942394 query89 464 297 286 286 query90 1913194 194 194 query91 130 98 101 98 query92 59 51 49 49 query93 5826623 616 616 query94 906 307 290 290 query95 394 310 270 270 query96 629 286 288 286 query97 3238307730723072 query98 223 204 199 199 query99 1596126712631263 Total cold run time: 275354 ms Total hot run time: 169387 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [fix](mtmv) Fix select literal result wrongly in group by when use materialized view [doris]
doris-robot commented on PR #38958: URL: https://github.com/apache/doris/pull/38958#issuecomment-2272839045 TPC-DS: Total hot run time: 169072 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 6a74ccb64cf2d437b35b87fcf82a4d8a129e225c, data reload: false query1 916 390 385 385 query2 6472168916641664 query3 6652213 219 213 query4 19651 17643 17275 17275 query5 3652518 504 504 query6 269 190 157 157 query7 4587291 289 289 query8 260 191 211 191 query9 8523232323112311 query10 447 281 269 269 query11 10410 10053 99989998 query12 125 90 87 87 query13 1634383 384 383 query14 8728629268846292 query15 224 167 172 167 query16 6984448 440 440 query17 951 569 559 559 query18 1927285 284 284 query19 191 149 146 146 query20 92 87 93 87 query21 204 103 99 99 query22 4360404339773977 query23 33810 34036 33723 33723 query24 9334311231173112 query25 672 393 408 393 query26 1551154 156 154 query27 3101280 305 280 query28 7717199219641964 query29 1140434 435 434 query30 239 162 155 155 query31 940 765 782 765 query32 103 57 59 57 query33 679 333 326 326 query34 941 500 495 495 query35 897 768 769 768 query36 1049921 897 897 query37 176 83 79 79 query38 3034288327692769 query39 857 813 807 807 query40 281 110 111 110 query41 46 44 46 44 query42 125 101 98 98 query43 476 411 422 411 query44 1187733 716 716 query45 218 182 183 182 query46 803 768 768 query47 1801172417461724 query48 354 292 284 284 query49 962 420 417 417 query50 910 435 420 420 query51 6987667966976679 query52 102 87 92 87 query53 247 184 186 184 query54 661 450 444 444 query55 76 75 74 74 query56 279 254 246 246 query57 1145104910431043 query58 281 282 271 271 query59 2581241623662366 query60 315 286 268 268 query61 93 90 90 90 query62 884 662 656 656 query63 213 179 179 179 query64 5694190219221902 query65 3175308730843084 query66 1293337 330 330 query67 15238 14871 14903 14871 query68 5464575 580 575 query69 680 368 303 303 query70 1117105710701057 query71 465 279 276 276 query72 7520272524872487 query73 887 326 323 323 query74 6061569356815681 query75 3602273227772732 query76 3238127112601260 query77 547 306 302 302 query78 9409890189468901 query79 2723537 526 526 query80 981 553 502 502 query81 546 225 224 224 query82 1425142 135 135 query83 253 168 174 168 query84 265 87 77 77 query85 1456315 304 304 query86 479 299 294 294 query87 3291312930853085 query88 3697237723692369 query89 394 286 291 286 query90 1756191 189 189 query91 125 101 102 101 query92 57 96 50 50 query93 2136633 620 620 query94 810 291 292 291 query95 375 262 260 260 query96 608 287 286 286 query97 3201305630743056 query98 214 205 195 195 query99 1681126712541254 Total cold run time: 265697 ms Total hot run time: 169072 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [fix](boolean) fix cast as boolean error [doris]
nextdreamblue commented on PR #38786: URL: https://github.com/apache/doris/pull/38786#issuecomment-2272840300 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](boolean) fix cast as boolean error [doris]
github-actions[bot] commented on PR #38786: URL: https://github.com/apache/doris/pull/38786#issuecomment-2272840557 ## Possible file(s) that should be tracked in LFS detected: 🚨 The following file(s) exceeds the file size limit: `1048576` bytes, as set in the .yml configuration files: - regression-test/data/load_p0/stream_load/test_stream_load_properties.out - regression-test/data/load_p2/routine_load/test_routine_load.out Consider using `git-lfs` to manage large files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[I] [Bug] Iceberg sample issue: the doris BE process not successfully started in container. [doris]
wangyjx opened a new issue, #39033: URL: https://github.com/apache/doris/issues/39033 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version master ### What's Wrong? Not able query or insert data in the iceberg table. client reports "No available backends". ### What You Expected? able to query or insert value to iceberg table. ### How to Reproduce? 1. bash start_all.sh 2. bash start_doris_client.sh 3. select * from iceberg.db_iceberg.tb_iceberg; ### Anything Else? - I interactively enter the doris container, observe the /proc/xxx/cmdline, no backend process there, only FE java process. - I run /opt/doris/be/bin/start_be.sh, it shows error : "Please disable swap memory before installation." ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](boolean) fix cast as boolean error [doris]
nextdreamblue commented on PR #38786: URL: https://github.com/apache/doris/pull/38786#issuecomment-2272839639 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](cloud) Add lazy commit mechanism for `commit_txn` [doris]
SWJTU-ZhangLei commented on code in PR #38243:
URL: https://github.com/apache/doris/pull/38243#discussion_r1706546681
##
cloud/src/meta-service/meta_service_txn.cpp:
##
@@ -788,6 +788,164 @@ void update_tablet_stats(const StatsTabletKeyInfo& info,
const TabletStats& stat
txn->put(key, val);
}
}
+
+void convert_tmp_rowsets(
+const std::string& instance_id, int64_t txn_id, std::shared_ptr
txn_kv,
+MetaServiceCode& code, std::string& msg, int64_t db_id,
+std::vector>&
tmp_rowsets_meta,
+std::unordered_map& tablet_ids) {
+std::stringstream ss;
+std::unique_ptr txn;
+TxnErrorCode err = txn_kv->create_txn(&txn);
+if (err != TxnErrorCode::TXN_OK) {
+code = cast_as(err);
+ss << "failed to create txn, txn_id=" << txn_id << " err=" << err;
+msg = ss.str();
+LOG(WARNING) << msg;
+return;
+}
+
+// partition_id -> VersionPB
+std::unordered_map partition_versions;
Review Comment:
> `partition_versions` is not needed here, since all rowsets belong to the
same partition. Read the partition version in here directly.
`convert_tmp_rowsets` is a common api, all roswets not belong to the same
partition also work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](boolean) fix cast as boolean error [doris]
github-actions[bot] commented on PR #38786: URL: https://github.com/apache/doris/pull/38786#issuecomment-2272841040 ## Possible file(s) that should be tracked in LFS detected: 🚨 The following file(s) exceeds the file size limit: `1048576` bytes, as set in the .yml configuration files: - regression-test/data/load_p0/stream_load/test_stream_load_properties.out - regression-test/data/load_p2/routine_load/test_routine_load.out Consider using `git-lfs` to manage large files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](catalog) modify some meta cache logic [doris]
doris-robot commented on PR #38506: URL: https://github.com/apache/doris/pull/38506#issuecomment-2272841347 ClickBench: Total hot run time: 30.26 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 0485f5fa13af987ea9a186ca594ef575777a53a2, data reload: false query1 0.040.040.04 query2 0.080.040.04 query3 0.230.050.05 query4 1.670.070.06 query5 0.470.480.48 query6 1.140.710.71 query7 0.020.020.01 query8 0.050.040.04 query9 0.570.510.50 query10 0.560.570.57 query11 0.160.120.12 query12 0.150.130.12 query13 0.610.620.60 query14 0.770.810.77 query15 0.920.860.87 query16 0.360.360.35 query17 0.971.001.00 query18 0.210.210.21 query19 1.811.761.73 query20 0.020.010.01 query21 15.40 0.750.64 query22 3.595.331.69 query23 17.55 1.361.24 query24 2.250.240.21 query25 0.190.080.08 query26 0.320.230.22 query27 0.470.230.23 query28 13.19 1.010.96 query29 12.52 3.303.29 query30 0.250.060.05 query31 2.880.410.40 query32 3.220.510.48 query33 2.962.912.98 query34 15.45 4.274.25 query35 4.274.284.31 query36 0.670.480.48 query37 0.200.160.17 query38 0.170.150.15 query39 0.040.030.04 query40 0.150.130.12 query41 0.100.050.04 query42 0.060.040.05 query43 0.050.040.04 Total cold run time: 106.76 s Total hot run time: 30.26 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](cloud) Add lazy commit mechanism for `commit_txn` [doris]
SWJTU-ZhangLei commented on code in PR #38243:
URL: https://github.com/apache/doris/pull/38243#discussion_r1706546958
##
cloud/src/meta-service/meta_service_txn.cpp:
##
@@ -788,6 +788,164 @@ void update_tablet_stats(const StatsTabletKeyInfo& info,
const TabletStats& stat
txn->put(key, val);
}
}
+
+void convert_tmp_rowsets(
+const std::string& instance_id, int64_t txn_id, std::shared_ptr
txn_kv,
+MetaServiceCode& code, std::string& msg, int64_t db_id,
+std::vector>&
tmp_rowsets_meta,
+std::unordered_map& tablet_ids) {
+std::stringstream ss;
+std::unique_ptr txn;
+TxnErrorCode err = txn_kv->create_txn(&txn);
+if (err != TxnErrorCode::TXN_OK) {
+code = cast_as(err);
+ss << "failed to create txn, txn_id=" << txn_id << " err=" << err;
+msg = ss.str();
+LOG(WARNING) << msg;
+return;
+}
+
+// partition_id -> VersionPB
+std::unordered_map partition_versions;
+// tablet_id -> stats
+std::unordered_map tablet_stats;
+
+for (auto& [tmp_rowset_key, tmp_rowset_pb] : tmp_rowsets_meta) {
+std::string tmp_rowst_data;
+err = txn->get(tmp_rowset_key, &tmp_rowst_data);
+if (TxnErrorCode::TXN_KEY_NOT_FOUND == err) {
+// the tmp rowset has been converted
Review Comment:
> Add a debug log.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Fix]Fix wg test failed in cloud mode [doris]
wangbo opened a new pull request, #39034: URL: https://github.com/apache/doris/pull/39034 ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix]Fix wg test failed in cloud mode [doris]
doris-robot commented on PR #39034: URL: https://github.com/apache/doris/pull/39034#issuecomment-2272843440 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix]Fix wg test failed in cloud mode [doris]
wangbo commented on PR #39034: URL: https://github.com/apache/doris/pull/39034#issuecomment-2272843517 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](inverted index) warm up inverted index [doris]
gavinchou commented on code in PR #38986:
URL: https://github.com/apache/doris/pull/38986#discussion_r1706550390
##
be/src/io/cache/block_file_cache_downloader.h:
##
@@ -76,7 +76,7 @@ class FileCacheBlockDownloader {
private:
void download_file_cache_block(const DownloadTask::FileCacheBlockMetaVec&);
-void download_segment_file(const DownloadFileMeta&);
+void download_file(const DownloadFileMeta&);
Review Comment:
why rename?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](planner) Empty table source should not begin a transaction to avoid infinite transaction [doris]
TangSiyang2001 commented on PR #38991: URL: https://github.com/apache/doris/pull/38991#issuecomment-2272846308 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipeline) check nullable in SET operator [doris]
doris-robot commented on PR #39027: URL: https://github.com/apache/doris/pull/39027#issuecomment-2272846534 ClickBench: Total hot run time: 30.17 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 043dc916b120a713f3ec33c46ffc6299f6309514, data reload: false query1 0.040.040.04 query2 0.080.040.04 query3 0.220.040.05 query4 1.680.060.06 query5 0.490.480.48 query6 1.140.720.71 query7 0.020.010.02 query8 0.060.050.05 query9 0.580.520.51 query10 0.560.550.55 query11 0.160.120.12 query12 0.150.130.12 query13 0.620.610.60 query14 0.760.810.80 query15 0.890.860.86 query16 0.350.370.35 query17 0.990.981.02 query18 0.220.210.21 query19 1.821.741.75 query20 0.030.010.01 query21 15.44 0.760.65 query22 3.868.011.58 query23 18.06 1.361.26 query24 2.290.220.22 query25 0.180.090.08 query26 0.320.230.22 query27 0.460.230.22 query28 13.17 1.020.96 query29 12.50 3.263.28 query30 0.260.060.06 query31 2.870.430.40 query32 3.230.490.49 query33 2.902.982.92 query34 15.44 4.274.24 query35 4.274.284.27 query36 0.670.470.48 query37 0.190.160.16 query38 0.160.140.16 query39 0.050.030.04 query40 0.160.130.13 query41 0.100.050.05 query42 0.050.040.04 query43 0.050.040.04 Total cold run time: 107.54 s Total hot run time: 30.17 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix]Fix wg test failed in cloud mode [doris]
github-actions[bot] commented on PR #39034: URL: https://github.com/apache/doris/pull/39034#issuecomment-2272847593 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix]Fix wg test failed in cloud mode [doris]
github-actions[bot] commented on PR #39034: URL: https://github.com/apache/doris/pull/39034#issuecomment-2272847537 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](mtmv) Fix select literal result wrongly in group by when use materialized view [doris]
doris-robot commented on PR #38958: URL: https://github.com/apache/doris/pull/38958#issuecomment-2272848338 ClickBench: Total hot run time: 30.15 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 6a74ccb64cf2d437b35b87fcf82a4d8a129e225c, data reload: false query1 0.040.040.04 query2 0.070.040.04 query3 0.220.040.04 query4 1.690.070.06 query5 0.480.480.49 query6 1.130.720.72 query7 0.020.010.01 query8 0.060.050.04 query9 0.560.520.51 query10 0.580.570.56 query11 0.150.120.11 query12 0.150.120.12 query13 0.620.600.60 query14 0.770.800.78 query15 0.930.860.87 query16 0.350.360.35 query17 1.000.981.04 query18 0.220.210.21 query19 1.791.741.73 query20 0.010.010.01 query21 15.42 0.740.64 query22 4.316.031.47 query23 17.93 1.331.34 query24 2.290.220.21 query25 0.180.080.08 query26 0.330.210.22 query27 0.460.240.23 query28 13.18 1.010.97 query29 12.60 3.273.28 query30 0.250.060.05 query31 2.870.410.41 query32 3.220.500.49 query33 2.952.933.00 query34 15.46 4.264.27 query35 4.324.314.31 query36 0.670.490.47 query37 0.180.170.16 query38 0.160.150.14 query39 0.040.030.04 query40 0.160.120.13 query41 0.100.050.05 query42 0.060.040.04 query43 0.050.040.03 Total cold run time: 108.03 s Total hot run time: 30.15 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) Support SELECT * REPLACE clause [doris]
macroguo-ghy commented on PR #38680: URL: https://github.com/apache/doris/pull/38680#issuecomment-2272848466 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](boolean) fix cast as boolean error [doris]
github-actions[bot] commented on PR #38786: URL: https://github.com/apache/doris/pull/38786#issuecomment-2272851164 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](boolean) fix cast as boolean error [doris]
github-actions[bot] commented on PR #38786: URL: https://github.com/apache/doris/pull/38786#issuecomment-2272851281 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: [bugfix](backup)(cooldown) cancel backup properly when be backup failed (#38724) (#38993)
This is an automated email from the ASF dual-hosted git repository.
w41ter pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new 7e95d7cbec7 [bugfix](backup)(cooldown) cancel backup properly when be
backup failed (#38724) (#38993)
7e95d7cbec7 is described below
commit 7e95d7cbec7e709d9f1c29a1a18e1d3570ab606e
Author: walter
AuthorDate: Wed Aug 7 15:58:11 2024 +0800
[bugfix](backup)(cooldown) cancel backup properly when be backup failed
(#38724) (#38993)
Co-authored-by: zhangyuan
---
be/src/common/status.cpp | 7 +
be/src/olap/snapshot_manager.cpp | 3 +
be/src/olap/tablet.cpp | 8 +
.../java/org/apache/doris/backup/BackupJob.java| 69 +++
.../backup_restore/test_backup_cancelled.groovy| 199 +
5 files changed, 286 insertions(+)
diff --git a/be/src/common/status.cpp b/be/src/common/status.cpp
index d17e18951c5..cc6c10c2941 100644
--- a/be/src/common/status.cpp
+++ b/be/src/common/status.cpp
@@ -34,6 +34,13 @@ void Status::to_thrift(TStatus* s) const {
//<< "The error code has to > 0 because TStatusCode need it > 0,
it's actual value is "
//<< _code;
s->status_code = (int16_t)_code > 0 ? (TStatusCode::type)_code :
TStatusCode::INTERNAL_ERROR;
+
+if (_code == ErrorCode::VERSION_ALREADY_MERGED) {
+s->status_code = TStatusCode::OLAP_ERR_VERSION_ALREADY_MERGED;
+} else if (_code == ErrorCode::TABLE_NOT_FOUND) {
+s->status_code = TStatusCode::TABLET_MISSING;
+}
+
s->error_msgs.push_back(fmt::format("({})[{}]{}",
BackendOptions::get_localhost(),
code_as_string(), _err_msg ?
_err_msg->_msg : ""));
s->__isset.error_msgs = true;
diff --git a/be/src/olap/snapshot_manager.cpp b/be/src/olap/snapshot_manager.cpp
index ffa3c5403a8..6e36d0756af 100644
--- a/be/src/olap/snapshot_manager.cpp
+++ b/be/src/olap/snapshot_manager.cpp
@@ -88,6 +88,9 @@ Status SnapshotManager::make_snapshot(const TSnapshotRequest&
request, string* s
TabletSharedPtr ref_tablet =
StorageEngine::instance()->tablet_manager()->get_tablet(request.tablet_id);
+
+DBUG_EXECUTE_IF("SnapshotManager::make_snapshot.inject_failure", {
ref_tablet = nullptr; })
+
if (ref_tablet == nullptr) {
return Status::Error("failed to get tablet.
tablet={}", request.tablet_id);
}
diff --git a/be/src/olap/tablet.cpp b/be/src/olap/tablet.cpp
index 1121e61451a..212b21a8174 100644
--- a/be/src/olap/tablet.cpp
+++ b/be/src/olap/tablet.cpp
@@ -969,6 +969,14 @@ Status Tablet::capture_consistent_versions(const Version&
spec_version,
}
}
}
+
+DBUG_EXECUTE_IF("TTablet::capture_consistent_versions.inject_failure", {
+auto tablet_id = dp->param("tablet_id", -1);
+if (tablet_id != -1 && tablet_id == _tablet_meta->tablet_id()) {
+status = Status::Error("version already
merged");
+}
+});
+
return status;
}
diff --git a/fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java
b/fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java
index 96f5dbdd058..ff92101b59a 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java
@@ -159,6 +159,61 @@ public class BackupJob extends AbstractJob {
return BackupContent.ALL;
}
+private synchronized boolean tryNewTabletSnapshotTask(SnapshotTask task) {
+Table table =
env.getInternalCatalog().getTableByTableId(task.getTableId());
+if (table == null) {
+return false;
+}
+OlapTable tbl = (OlapTable) table;
+tbl.readLock();
+try {
+if (tbl.getId() != task.getTableId()) {
+return false;
+}
+Partition partition = tbl.getPartition(task.getPartitionId());
+if (partition == null) {
+return false;
+}
+MaterializedIndex index = partition.getIndex(task.getIndexId());
+if (index == null) {
+return false;
+}
+Tablet tablet = index.getTablet(task.getTabletId());
+if (tablet == null) {
+return false;
+}
+Replica replica = chooseReplica(tablet, task.getVersion());
+if (replica == null) {
+return false;
+}
+
+//clear old task
+AgentTaskQueue.removeTaskOfType(TTaskType.MAKE_SNAPSHOT,
task.getTabletId());
+unfinishedTaskIds.remove(task.getTabletId());
+taskProgress.remove(task.getTabletId());
+taskErrMsg.remove(task.getTabletId());
+
+SnapshotTask newTask = new SnapshotTask(null,
repli
