Re: [PR] [Improment]Query queued by be memory [doris]
yiguolei commented on code in PR #37559:
URL: https://github.com/apache/doris/pull/37559#discussion_r1675407840
##
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/QueryQueue.java:
##
@@ -126,30 +138,47 @@ public QueueToken getToken() throws UserException {
}
}
-public void releaseAndNotify(QueueToken releaseToken) {
+public void releaseAndNotify(QueueToken releaseToken, AdmissionControl ac)
{
queueLock.lock();
try {
-// NOTE:token's tokenState need to be locked by queueLock
-if (releaseToken.isReadyToRun()) {
-currentRunningQueryNum--;
-} else {
-priorityTokenQueue.remove(releaseToken);
-}
-Preconditions.checkArgument(currentRunningQueryNum >= 0);
-while (currentRunningQueryNum < maxConcurrency) {
-QueueToken queueToken = this.priorityTokenQueue.poll();
+runningQueryQueue.remove(releaseToken);
+waitingQueryQueue.remove(releaseToken);
+releaseToken.release();
+while (runningQueryQueue.size() < maxConcurrency &&
ac.isAllBeMemoryEnough()) {
+QueueToken queueToken = this.waitingQueryQueue.poll();
if (queueToken == null) {
break;
}
queueToken.complete();
-currentRunningQueryNum++;
+runningQueryQueue.offer(queueToken);
+}
+} finally {
+queueLock.unlock();
+if (LOG.isDebugEnabled()) {
+LOG.info(this.debugString());
+}
+}
+}
+
+public boolean notifyQuery(QueueToken queueToken) {
Review Comment:
这个方法还有后面的那个notifySelf 都不用。
直接用releaseAndNotify 这个，把token 传递成null，就是我们想要的逻辑。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improment]Query queued by be memory [doris]
yiguolei commented on code in PR #37559:
URL: https://github.com/apache/doris/pull/37559#discussion_r1675411516
##
fe/fe-core/src/main/java/org/apache/doris/resource/AdmissionControl.java:
##
@@ -0,0 +1,158 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.resource;
+
+import org.apache.doris.common.ClientPool;
+import org.apache.doris.common.Config;
+import org.apache.doris.common.util.MasterDaemon;
+import org.apache.doris.resource.workloadgroup.QueueToken;
+import org.apache.doris.system.Backend;
+import org.apache.doris.system.SystemInfoService;
+import org.apache.doris.thrift.BackendService;
+import org.apache.doris.thrift.TGetBeResourceRequest;
+import org.apache.doris.thrift.TGetBeResourceResult;
+import org.apache.doris.thrift.TGlobalResourceUsage;
+import org.apache.doris.thrift.TNetworkAddress;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.Collection;
+import java.util.Iterator;
+import java.util.concurrent.ConcurrentLinkedQueue;
+
+public class AdmissionControl extends MasterDaemon {
+
+public static final Logger LOG =
LogManager.getLogger(AdmissionControl.class);
+
+private volatile boolean isAllBeMemoryEnough = true;
+
+private SystemInfoService clusterInfoService;
+
+public AdmissionControl(SystemInfoService clusterInfoService) {
+super("get-be-resource-usage-thread",
Config.get_be_resource_usage_interval_ms);
+this.clusterInfoService = clusterInfoService;
+}
+
+private ConcurrentLinkedQueue queryWaitList = new
ConcurrentLinkedQueue<>();
+
+public void addQueueToken(QueueToken queueToken) {
+queryWaitList.offer(queueToken);
+}
+
+@Override
+protected void runAfterCatalogReady() {
+double maxBeMemoryUsagePercent = getBeMemoryUsage();
+notifyWaitMemoryQuery(maxBeMemoryUsagePercent);
+}
+
+public double getBeMemoryUsage() {
+double maxBeMemoryUsagePercent = 0;
+if (Config.query_queue_by_be_used_memory < 0) {
+this.isAllBeMemoryEnough = true;
+return maxBeMemoryUsagePercent;
+}
+Collection backends =
clusterInfoService.getIdToBackend().values();
+boolean tmpIsAllBeMemoryEnough = true;
+for (Backend be : backends) {
+if (!be.isAlive()) {
+continue;
+}
+TNetworkAddress address = null;
+BackendService.Client client = null;
+TGetBeResourceResult result = null;
+boolean rpcOk = true;
+try {
+address = new TNetworkAddress(be.getHost(), be.getBePort());
+client = ClientPool.backendPool.borrowObject(address, 5000);
+result = client.getBeResource(new TGetBeResourceRequest());
+} catch (Throwable t) {
+rpcOk = false;
+LOG.warn("get be {} resource failed, ", be.getHost(), t);
+} finally {
+try {
+if (rpcOk) {
+ClientPool.backendPool.returnObject(address, client);
+} else {
+ClientPool.backendPool.invalidateObject(address,
client);
+}
+} catch (Throwable e) {
+LOG.warn("return rpc client failed. related backend[{}]",
be.getHost(),
+e);
+}
+}
+if (result != null && result.isSetGlobalResourceUsage()) {
+TGlobalResourceUsage globalResourceUsage =
result.getGlobalResourceUsage();
+if (globalResourceUsage != null &&
globalResourceUsage.isSetMemLimit()
+&& globalResourceUsage.isSetMemUsage()) {
+long memUsageL = globalResourceUsage.getMemUsage();
+long memLimitL = globalResourceUsage.getMemLimit();
+double memUsage =
Double.valueOf(String.valueOf(memUsageL));
+double memLimit =
Double.valueOf(String.valueOf(memLimitL));
+double memUsagePercent = memUsage / memLimit;
+maxBeMemoryUsagePerce
Re: [PR] [fix](partial update) fix a mem leak issue [doris]
doris-robot commented on PR #37706: URL: https://github.com/apache/doris/pull/37706#issuecomment-2224957664 TPC-H: Total hot run time: 40369 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 79ebf6b153c95df1976955cafd7accab28fe3914, data reload: false -- Round 1 -- q1 17622 431745364317 q2 2010195 191 191 q3 10439 122511631163 q4 10190 877 774 774 q5 7607268026632663 q6 226 139 139 139 q7 955 608 622 608 q8 9229207820822078 q9 8876658466216584 q10 8802383838143814 q11 459 247 242 242 q12 428 240 236 236 q13 17829 299330362993 q14 280 248 235 235 q15 515 492 493 492 q16 515 381 390 381 q17 972 663 721 663 q18 8146755474787478 q19 7984155314631463 q20 701 321 324 321 q21 5090320332683203 q22 404 338 331 331 Total cold run time: 119279 ms Total hot run time: 40369 ms - Round 2, with runtime_filter_mode=off - q1 4525432043264320 q2 375 285 272 272 q3 3296300530403005 q4 2162189217951795 q5 5767575858265758 q6 239 139 144 139 q7 2351195720001957 q8 3379354835493548 q9 8979909489838983 q10 4122386339003863 q11 594 520 506 506 q12 817 645 642 642 q13 15816 318832513188 q14 313 300 280 280 q15 534 487 497 487 q16 495 433 444 433 q17 1825152915001500 q18 8263802279367936 q19 1817150017301500 q20 2751191918581858 q21 8593469548044695 q22 627 559 549 549 Total cold run time: 77640 ms Total hot run time: 57214 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Nereids) fix fe fold constant evaluate like function [doris]
doris-robot commented on PR #37616: URL: https://github.com/apache/doris/pull/37616#issuecomment-2224964023 TPC-H: Total hot run time: 39953 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit dda6f828a03111d9747352f608ac0ec7437bafc8, data reload: false -- Round 1 -- q1 18784 463743704370 q2 2991200 188 188 q3 11337 116611061106 q4 10835 898 774 774 q5 7615269526362636 q6 227 139 137 137 q7 983 601 587 587 q8 9233204920712049 q9 8664656865456545 q10 8752376637863766 q11 503 247 238 238 q12 394 233 235 233 q13 17756 299229632963 q14 268 232 239 232 q15 553 469 478 469 q16 476 370 375 370 q17 954 699 647 647 q18 8033743473817381 q19 5765149513991399 q20 672 329 333 329 q21 4885324032113211 q22 385 323 337 323 Total cold run time: 120065 ms Total hot run time: 39953 ms - Round 2, with runtime_filter_mode=off - q1 4344425642674256 q2 386 278 270 270 q3 2963278026922692 q4 1885162816591628 q5 5288530653025302 q6 223 131 129 129 q7 2108170917321709 q8 3206334532843284 q9 8401838783888387 q10 3898376737303730 q11 587 491 499 491 q12 773 654 625 625 q13 17479 297829802978 q14 305 279 270 270 q15 512 483 473 473 q16 483 411 420 411 q17 1794149114761476 q18 7680747874127412 q19 2662155215771552 q20 2010177017851770 q21 4894460846424608 q22 638 542 531 531 Total cold run time: 72519 ms Total hot run time: 53984 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Optimize](Row store) allow to set row_store_page_size for tables, change default value to 16KB [doris]
github-actions[bot] commented on PR #37145: URL: https://github.com/apache/doris/pull/37145#issuecomment-2224970555 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](partial update) fix a mem leak issue [doris]
doris-robot commented on PR #37706: URL: https://github.com/apache/doris/pull/37706#issuecomment-2224973187 TPC-DS: Total hot run time: 175420 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 79ebf6b153c95df1976955cafd7accab28fe3914, data reload: false query1 917 382 365 365 query2 6448247524452445 query3 6654208 220 208 query4 23987 17708 17446 17446 query5 3595502 482 482 query6 279 167 176 167 query7 4584307 282 282 query8 331 303 291 291 query9 8766242024062406 query10 424 293 264 264 query11 10586 10114 10219 10114 query12 117 88 81 81 query13 1632380 375 375 query14 10091 759177637591 query15 249 187 191 187 query16 7575320 299 299 query17 1751620 519 519 query18 1873277 290 277 query19 197 147 152 147 query20 102 82 83 82 query21 208 136 124 124 query22 4319403842754038 query23 34327 33720 33797 33720 query24 7000288028762876 query25 594 400 399 399 query26 697 152 150 150 query27 2244284 279 279 query28 4787217721772177 query29 882 661 653 653 query30 272 156 181 156 query31 987 763 751 751 query32 95 55 56 55 query33 551 314 280 280 query34 891 497 522 497 query35 678 587 578 578 query36 1092999 976 976 query37 148 83 88 83 query38 2921287828692869 query39 878 859 828 828 query40 205 127 118 118 query41 58 50 50 50 query42 116 98 99 98 query43 616 566 534 534 query44 1108759 735 735 query45 195 167 164 164 query46 1076733 728 728 query47 1868176317761763 query48 377 299 291 291 query49 848 409 414 409 query50 773 399 385 385 query51 6908678867886788 query52 108 104 94 94 query53 369 291 295 291 query54 559 455 444 444 query55 77 76 74 74 query56 277 265 273 265 query57 1146105610561056 query58 252 261 251 251 query59 3524359932273227 query60 300 270 282 270 query61 140 92 94 92 query62 790 626 636 626 query63 325 286 292 286 query64 9193218316721672 query65 3190313531373135 query66 747 323 332 323 query67 15399 15166 14943 14943 query68 4671542 543 542 query69 769 429 359 359 query70 1199110811131108 query71 406 294 282 282 query72 7019577654765476 query73 781 322 321 321 query74 5921555855175517 query75 3433273627742736 query76 2741957 978 957 query77 665 320 318 318 query78 9589931089568956 query79 2300524 534 524 query80 2015485 493 485 query81 600 224 229 224 query82 771 131 132 131 query83 266 167 170 167 query84 279 89 85 85 query85 1220303 295 295 query86 452 326 327 326 query87 3262311131413111 query88 4127238523872385 query89 491 387 373 373 query90 1834195 190 190 query91 131 104 100 100 query92 64 52 47 47 query93 2848513 507 507 query94 1048210 211 210 query95 403 313 323 313 query96 610 280 276 276 query97 3183309630193019 query98 240 208 196 196 query99 1582125512931255 Total cold run time: 269193 ms Total hot run time: 175420 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
[PR] [docs](readme) Update readme label and pics [doris]
KassieZ opened a new pull request, #37711: URL: https://github.com/apache/doris/pull/37711 ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [docs](readme) Update readme label and pics [doris]
doris-robot commented on PR #37711: URL: https://github.com/apache/doris/pull/37711#issuecomment-2224974173 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Nereids) fix fe fold constant evaluate like function [doris]
doris-robot commented on PR #37616: URL: https://github.com/apache/doris/pull/37616#issuecomment-2224980214 TPC-DS: Total hot run time: 174231 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit dda6f828a03111d9747352f608ac0ec7437bafc8, data reload: false query1 916 369 358 358 query2 6451238023332333 query3 6660210 222 210 query4 27556 17695 17217 17217 query5 4176494 514 494 query6 299 165 161 161 query7 4596289 282 282 query8 298 278 282 278 query9 8589246124562456 query10 440 301 265 265 query11 10820 10061 10227 10061 query12 125 83 87 83 query13 1633370 361 361 query14 9423765174537453 query15 232 184 183 183 query16 7660318 322 318 query17 1440553 536 536 query18 1919277 274 274 query19 198 148 146 146 query20 89 81 82 81 query21 213 127 128 127 query22 4296410639583958 query23 33774 33256 33057 33057 query24 11470 286128612861 query25 622 366 371 366 query26 1539148 147 147 query27 2876274 271 271 query28 7473210720882088 query29 988 617 625 617 query30 280 145 148 145 query31 963 732 748 732 query32 90 52 54 52 query33 771 286 301 286 query34 942 489 498 489 query35 668 577 604 577 query36 1122954 924 924 query37 150 80 87 80 query38 2884280327522752 query39 869 793 790 790 query40 279 125 122 122 query41 56 53 54 53 query42 114 102 108 102 query43 583 559 560 559 query44 1181740 715 715 query45 192 167 171 167 query46 1097745 745 745 query47 1850181317851785 query48 376 313 309 309 query49 1184415 419 415 query50 777 398 399 398 query51 6995687968166816 query52 103 93 92 92 query53 360 293 291 291 query54 1049462 456 456 query55 78 79 75 75 query56 305 286 287 286 query57 1169108210611061 query58 265 255 261 255 query59 3666330832383238 query60 327 298 307 298 query61 118 114 115 114 query62 843 674 668 668 query63 321 288 292 288 query64 10643 227817621762 query65 3178309131003091 query66 1410350 350 350 query67 15450 15023 14917 14917 query68 5612562 548 548 query69 702 456 356 356 query70 1194116111671161 query71 484 283 286 283 query72 8791579054335433 query73 805 335 324 324 query74 6083554356465543 query75 4327267026722670 query76 3694971 952 952 query77 723 331 311 311 query78 9752903090909030 query79 8385523 530 523 query80 2304473 476 473 query81 598 224 217 217 query82 1409141 136 136 query83 312 168 194 168 query84 273 89 86 86 query85 1600324 297 297 query86 474 323 326 323 query87 3303313631483136 query88 5320253924582458 query89 544 376 369 369 query90 1923196 195 195 query91 132 105 103 103 query92 62 48 49 48 query93 6373517 515 515 query94 1328211 254 211 query95 407 323 330 323 query96 616 276 275 275 query97 3204305830273027 query98 227 205 188 188 query99 1595125212921252 Total cold run time: 302035 ms Total hot run time: 174231 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] [fix](partial update) fix a mem leak issue [doris]
doris-robot commented on PR #37706: URL: https://github.com/apache/doris/pull/37706#issuecomment-2224980853 ClickBench: Total hot run time: 31.2 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 79ebf6b153c95df1976955cafd7accab28fe3914, data reload: false query1 0.040.030.03 query2 0.090.040.04 query3 0.220.050.06 query4 1.670.080.08 query5 0.490.480.48 query6 1.190.720.73 query7 0.020.010.01 query8 0.050.040.04 query9 0.550.500.48 query10 0.540.540.54 query11 0.160.110.12 query12 0.150.120.12 query13 0.590.590.59 query14 0.760.770.83 query15 0.860.820.82 query16 0.350.370.37 query17 0.960.991.05 query18 0.240.220.21 query19 1.791.741.73 query20 0.010.010.01 query21 15.39 0.780.66 query22 4.037.102.48 query23 18.33 1.481.30 query24 2.140.220.24 query25 0.160.080.09 query26 0.290.200.21 query27 0.460.230.22 query28 13.22 1.021.02 query29 12.62 3.323.26 query30 0.250.060.05 query31 2.870.380.39 query32 3.270.460.47 query33 2.892.932.86 query34 16.95 4.384.34 query35 4.424.424.41 query36 0.640.480.48 query37 0.180.160.16 query38 0.160.150.15 query39 0.040.030.03 query40 0.160.120.13 query41 0.090.040.05 query42 0.050.050.05 query43 0.040.050.04 Total cold run time: 109.38 s Total hot run time: 31.2 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature-wip](Recycler) Parallelize s3 delete operations and recycle_tablet [doris]
ByteYue commented on PR #37630: URL: https://github.com/apache/doris/pull/37630#issuecomment-2224984733 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Nereids) fix fe fold constant evaluate like function [doris]
doris-robot commented on PR #37616: URL: https://github.com/apache/doris/pull/37616#issuecomment-2224987950 ClickBench: Total hot run time: 31.01 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit dda6f828a03111d9747352f608ac0ec7437bafc8, data reload: false query1 0.040.040.04 query2 0.090.050.04 query3 0.230.060.05 query4 1.680.080.08 query5 0.500.480.47 query6 1.130.730.72 query7 0.020.020.01 query8 0.050.040.04 query9 0.550.490.49 query10 0.540.540.53 query11 0.150.110.12 query12 0.140.120.12 query13 0.590.580.58 query14 0.760.790.79 query15 0.850.800.81 query16 0.370.370.36 query17 1.061.030.98 query18 0.220.220.22 query19 1.881.701.68 query20 0.020.010.01 query21 15.40 0.780.68 query22 4.187.012.25 query23 18.26 1.441.30 query24 2.070.250.22 query25 0.150.090.08 query26 0.310.220.21 query27 0.460.230.22 query28 13.30 1.031.00 query29 12.64 3.333.30 query30 0.250.060.05 query31 2.870.390.39 query32 3.270.470.48 query33 2.892.942.89 query34 16.97 4.384.34 query35 4.484.464.42 query36 0.640.480.49 query37 0.180.160.15 query38 0.160.150.15 query39 0.040.030.03 query40 0.150.120.12 query41 0.100.050.05 query42 0.050.050.05 query43 0.050.040.04 Total cold run time: 109.74 s Total hot run time: 31.01 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](Recycler) Parallelize s3 delete operations and recycle_tablet [doris]
github-actions[bot] commented on code in PR #37630:
URL: https://github.com/apache/doris/pull/37630#discussion_r1675434244
##
cloud/test/util_test.cpp:
##
@@ -0,0 +1,174 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "recycler/util.h"
+
+#include
+#include
+#include
+#include
+
+#include "common/config.h"
+#include "common/logging.h"
+#include "gtest/gtest.h"
+#include "recycler/recycler.h"
+
+using namespace doris::cloud;
+
+int main(int argc, char** argv) {
+const auto* conf_file = "doris_cloud.conf";
Review Comment:
warning: 'auto conf_file' can be declared as 'const auto *conf_file'
[readability-qualified-auto]
```suggestion
const auto *conf_file = "doris_cloud.conf";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids): add order_qt in fuction groovy [doris]
XieJiann commented on PR #37542: URL: https://github.com/apache/doris/pull/37542#issuecomment-2224991201 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](Recycler) Parallelize s3 delete operations and recycle_tablet [doris]
github-actions[bot] commented on code in PR #37630: URL: https://github.com/apache/doris/pull/37630#discussion_r1675437079 ## cloud/test/util_test.cpp: ## @@ -0,0 +1,174 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "recycler/util.h" Review Comment: warning: 'recycler/util.h' file not found [clang-diagnostic-error] ```cpp #include "recycler/util.h" ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix]fix be core when migration tablet to other disk [doris]
z404289981 opened a new pull request, #37712: URL: https://github.com/apache/doris/pull/37712  The asynchronous task reference captures a local variable ## Proposed changes Issue Number: close #36809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]fix be core when migration tablet to other disk [doris]
doris-robot commented on PR #37712: URL: https://github.com/apache/doris/pull/37712#issuecomment-2224998061 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]fix be core when migration tablet to other disk [doris]
github-actions[bot] commented on PR #37712: URL: https://github.com/apache/doris/pull/37712#issuecomment-2225006870 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](stacktrace) Add conf `enable_stacktrace` [doris]
xinyiZzz opened a new pull request, #37713: URL: https://github.com/apache/doris/pull/37713 `enable_stacktrace` if false, turn off all stacktrace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](stacktrace) Add conf `enable_stacktrace` [doris]
doris-robot commented on PR #37713: URL: https://github.com/apache/doris/pull/37713#issuecomment-2225007220 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](stacktrace) Add conf `enable_stacktrace` [doris]
xinyiZzz commented on PR #37713: URL: https://github.com/apache/doris/pull/37713#issuecomment-2225007274 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](inverted index) implementation of match function without index [doris]
zzzxl1993 commented on PR #36918: URL: https://github.com/apache/doris/pull/36918#issuecomment-2225009276 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](Recycler) Parallelize s3 delete operations and recycle_tablet [doris]
ByteYue commented on PR #37630: URL: https://github.com/apache/doris/pull/37630#issuecomment-2225014285 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix)(colocate join) fix wrong use of colocate join [doris]
cambyzju merged PR #37361: URL: https://github.com/apache/doris/pull/37361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [I] [Bug] wrong colocate join used [doris]
cambyzju closed issue #36324: [Bug] wrong colocate join used URL: https://github.com/apache/doris/issues/36324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (5dd27802096 -> 7216734f582)
This is an automated email from the ASF dual-hosted git repository. cambyzju pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 5dd27802096 [change](index) change enable_create_bitmap_index_as_inverted_index default to true (#36692) add 7216734f582 [fix)(colocate join) fix wrong use of colocate join (#37361) No new revisions were added by this update. Summary of changes: .../properties/ChildOutputPropertyDeriver.java | 2 +- .../properties/ChildrenPropertiesRegulator.java| 2 +- .../LogicalOlapScanToPhysicalOlapScan.java | 12 ++-- .../org/apache/doris/nereids/util/JoinUtils.java | 53 -- .../test_colocate_join_of_column_order.groovy | 82 ++ 5 files changed, 137 insertions(+), 14 deletions(-) create mode 100644 regression-test/suites/correctness_p0/test_colocate_join_of_column_order.groovy - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](stacktrace) Add conf `enable_stacktrace` [doris]
github-actions[bot] commented on PR #37713: URL: https://github.com/apache/doris/pull/37713#issuecomment-2225016434 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](colocate join) fix wrong use of colocate join (#37361) [doris]
cambyzju opened a new pull request, #37714: URL: https://github.com/apache/doris/pull/37714 ## Proposed changes cherry-pick #37361 to branch-2.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](colocate join) fix wrong use of colocate join (#37361) [doris]
doris-robot commented on PR #37714: URL: https://github.com/apache/doris/pull/37714#issuecomment-2225020486 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](colocate join) fix wrong use of colocate join (#37361) [doris]
cambyzju commented on PR #37714: URL: https://github.com/apache/doris/pull/37714#issuecomment-2225020658 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](fe) Add check editlog size mechanism for backupJob (#35653) [doris]
dataroaring merged PR #37628: URL: https://github.com/apache/doris/pull/37628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.0 updated: [fix](fe) Add check editlog size mechanism for backupJob (#35653) (#37628)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.0 by this push:
new d085c5ea715 [fix](fe) Add check editlog size mechanism for backupJob
(#35653) (#37628)
d085c5ea715 is described below
commit d085c5ea7155a3911e43113a172663c917072f8b
Author: Lei Zhang <27994433+swjtu-zhang...@users.noreply.github.com>
AuthorDate: Fri Jul 12 15:49:45 2024 +0800
[fix](fe) Add check editlog size mechanism for backupJob (#35653) (#37628)
* When creating a backupJob with huge of tables in a database, it can
cause backupJob editlog size over 2GB and bdbje will throw exception
because of ByteBuffer overflow
## Proposed changes
Issue Number: close #xxx
---
.../java/org/apache/doris/backup/BackupJob.java| 7 +++
.../java/org/apache/doris/journal/Journal.java | 2 ++
.../apache/doris/journal/bdbje/BDBJEJournal.java | 23 ++
.../apache/doris/journal/local/LocalJournal.java | 5 +
.../java/org/apache/doris/persist/EditLog.java | 13
5 files changed, 50 insertions(+)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java
b/fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java
index b6f031ab7d4..ec22d6eafc7 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java
@@ -568,6 +568,13 @@ public class BackupJob extends AbstractJob {
private void waitingAllSnapshotsFinished() {
if (unfinishedTaskIds.isEmpty()) {
+
+if (env.getEditLog().exceedMaxJournalSize(this)) {
+status = new Status(ErrCode.COMMON_ERROR, "backupJob is too
large ");
+return;
+}
+
+
snapshotFinishedTime = System.currentTimeMillis();
state = BackupJobState.UPLOAD_SNAPSHOT;
diff --git a/fe/fe-core/src/main/java/org/apache/doris/journal/Journal.java
b/fe/fe-core/src/main/java/org/apache/doris/journal/Journal.java
index 8fca299df19..b0929818eed 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/journal/Journal.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/journal/Journal.java
@@ -61,4 +61,6 @@ public interface Journal {
// Get all the dbs' name
public List getDatabaseNames();
+public boolean exceedMaxJournalSize(short op, Writable writable) throws
IOException;
+
}
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBJEJournal.java
b/fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBJEJournal.java
index 85e577058be..3c4662e2017 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBJEJournal.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBJEJournal.java
@@ -586,4 +586,27 @@ public class BDBJEJournal implements Journal { //
CHECKSTYLE IGNORE THIS LINE: B
public BDBEnvironment getBDBEnvironment() {
return this.bdbEnvironment;
}
+
+@Override
+public boolean exceedMaxJournalSize(short op, Writable writable) throws
IOException {
+JournalEntity entity = new JournalEntity();
+entity.setOpCode(op);
+entity.setData(writable);
+
+DataOutputBuffer buffer = new
DataOutputBuffer(OUTPUT_BUFFER_INIT_SIZE);
+entity.write(buffer);
+
+DatabaseEntry theData = new DatabaseEntry(buffer.getData());
+
+if (LOG.isDebugEnabled()) {
+LOG.debug("opCode = {}, journal size = {}", op, theData.getSize());
+}
+
+// 1GB
+if (theData.getSize() > (1 << 30)) {
+return true;
+}
+
+return false;
+}
}
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/journal/local/LocalJournal.java
b/fe/fe-core/src/main/java/org/apache/doris/journal/local/LocalJournal.java
index 9ba3274e0f0..4467c53a368 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/journal/local/LocalJournal.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/journal/local/LocalJournal.java
@@ -198,4 +198,9 @@ public class LocalJournal implements Journal {
public List getDatabaseNames() {
throw new RuntimeException("Not Support");
}
+
+@Override
+public boolean exceedMaxJournalSize(short op, Writable writable) throws
IOException {
+return false;
+}
}
diff --git a/fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java
b/fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java
index 79dde3e5874..a1e033d6d1f 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java
@@ -1905,4 +1905,17 @@ public class EditLog {
public void logDeleteTableStats(TableStatsDeletionLog log) {
logEdit(OperationType.OP_DELETE_TABLE_STATS, log);
}
Re: [PR] [fix](query cancel) Fix query is cancelled when it comes from follower FE #37662 [doris]
yiguolei merged PR #37707: URL: https://github.com/apache/doris/pull/37707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: [fix](query cancel) Fix query is cancelled when it comes from follower FE #37662 (#37707)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new 035027f8315 [fix](query cancel) Fix query is cancelled when it comes
from follower FE #37662 (#37707)
035027f8315 is described below
commit 035027f8315ff26a1c5168e71f43fb26f14edc68
Author: zhiqiang
AuthorDate: Fri Jul 12 15:50:45 2024 +0800
[fix](query cancel) Fix query is cancelled when it comes from follower FE
#37662 (#37707)
cherry pick from #37662
---
be/src/runtime/fragment_mgr.cpp | 42 +++--
1 file changed, 36 insertions(+), 6 deletions(-)
diff --git a/be/src/runtime/fragment_mgr.cpp b/be/src/runtime/fragment_mgr.cpp
index fee9d51afba..c2f16e1d05a 100644
--- a/be/src/runtime/fragment_mgr.cpp
+++ b/be/src/runtime/fragment_mgr.cpp
@@ -37,6 +37,7 @@
#include
#include
+#include
#include
#include "common/status.h"
@@ -1173,21 +1174,50 @@ void FragmentMgr::cancel_worker() {
continue;
}
-auto itr = running_fes.find(q.second->coord_addr);
+auto query_context = q.second;
+
+auto itr = running_fes.find(query_context->coord_addr);
if (itr != running_fes.end()) {
-if (q.second->get_fe_process_uuid() ==
itr->second.info.process_uuid ||
+if (query_context->get_fe_process_uuid() ==
itr->second.info.process_uuid ||
itr->second.info.process_uuid == 0) {
continue;
} else {
-LOG_WARNING("Coordinator of query {} restarted,
going to cancel it.",
-print_id(q.second->query_id()));
+// In some rear cases, the rpc port of follower is
not updated in time,
+// then the port of this follower will be zero,
but acutally it is still running,
+// and be has already received the query from
follower.
+// So we need to check if host is in running_fes.
+bool fe_host_is_standing = std::any_of(
+running_fes.begin(), running_fes.end(),
+[query_context](const auto& fe) {
+return fe.first.hostname ==
+
query_context->coord_addr.hostname &&
+ fe.first.port == 0;
+});
+if (fe_host_is_standing) {
+LOG_WARNING(
+"Coordinator {}:{} is not found, but
its host is still "
+"running with an unstable brpc port,
not going to cancel "
+"it.",
+query_context->coord_addr.hostname,
+query_context->coord_addr.port,
+print_id(query_context->query_id()));
+continue;
+} else {
+LOG_WARNING(
+"Could not find target coordinator
{}:{} of query {}, "
+"going to "
+"cancel it.",
+query_context->coord_addr.hostname,
+query_context->coord_addr.port,
+print_id(query_context->query_id()));
+}
}
} else {
LOG_WARNING(
"Could not find target coordinator {}:{} of
query {}, going to "
"cancel it.",
-q.second->coord_addr.hostname,
q.second->coord_addr.port,
-print_id(q.second->query_id()));
+query_context->coord_addr.hostname,
query_context->coord_addr.port,
+print_id(query_context->query_id()));
}
// Coorninator of this query has already dead.
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [docs](readme) Update readme label and pics [doris]
luzhijing commented on PR #37711: URL: https://github.com/apache/doris/pull/37711#issuecomment-2225024275 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [docs](readme) Update readme label and pics [doris]
github-actions[bot] commented on PR #37711: URL: https://github.com/apache/doris/pull/37711#issuecomment-2225025247 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [docs](readme) Update readme label and pics [doris]
github-actions[bot] commented on PR #37711: URL: https://github.com/apache/doris/pull/37711#issuecomment-2225025288 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.1](memory) Add HTTP API to clear data cache [doris]
github-actions[bot] commented on PR #37704: URL: https://github.com/apache/doris/pull/37704#issuecomment-2225026621 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.1](memory) Add HTTP API to clear data cache [doris]
github-actions[bot] commented on PR #37704: URL: https://github.com/apache/doris/pull/37704#issuecomment-2225026662 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](regression) fix multi replica case not executed (#37425) [doris]
dataroaring merged PR #37698: URL: https://github.com/apache/doris/pull/37698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: [fix](regression) fix multi replica case not executed (#37425) (#37698)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new ab8204b33b0 [fix](regression) fix multi replica case not executed
(#37425) (#37698)
ab8204b33b0 is described below
commit ab8204b33b021fba040f06e830b4d8567bd2fbfc
Author: Kaijie Chen
AuthorDate: Fri Jul 12 15:53:20 2024 +0800
[fix](regression) fix multi replica case not executed (#37425) (#37698)
cherry-pick #37425
---
.../suites/fault_injection_p0/test_multi_replica_fault_injection.groovy | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/regression-test/suites/fault_injection_p0/test_multi_replica_fault_injection.groovy
b/regression-test/suites/fault_injection_p0/test_multi_replica_fault_injection.groovy
index 8080b52ff48..d0582099eb8 100644
---
a/regression-test/suites/fault_injection_p0/test_multi_replica_fault_injection.groovy
+++
b/regression-test/suites/fault_injection_p0/test_multi_replica_fault_injection.groovy
@@ -26,7 +26,7 @@ suite("test_multi_replica_fault_injection", "nonConcurrent") {
beNums++;
logger.info(item.toString())
}
-if (beNums == 3){
+if (beNums >= 3){
sql """ set enable_memtable_on_sink_node=true """
sql """
CREATE TABLE IF NOT EXISTS `baseall` (
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](load) limit flush thread num by CPU count (#33325) [doris]
dataroaring closed pull request #37580: [improve](load) limit flush thread num by CPU count (#33325) URL: https://github.com/apache/doris/pull/37580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]fix be core when migration tablet to other disk [doris]
github-actions[bot] commented on PR #37712: URL: https://github.com/apache/doris/pull/37712#issuecomment-2225029697 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) Fix cloud meet e-230 not retry query from observer [doris]
dataroaring merged PR #37625: URL: https://github.com/apache/doris/pull/37625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [fix](cloud) Fix cloud meet e-230 not retry query from observer (#37625)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 570dfb41e65 [fix](cloud) Fix cloud meet e-230 not retry query from
observer (#37625)
570dfb41e65 is described below
commit 570dfb41e65fe22facb64c5f51728919f7dd80ee
Author: deardeng <565620...@qq.com>
AuthorDate: Fri Jul 12 15:55:34 2024 +0800
[fix](cloud) Fix cloud meet e-230 not retry query from observer (#37625)
---
.../java/org/apache/doris/qe/ConnectProcessor.java | 3 +-
.../java/org/apache/doris/qe/StmtExecutor.java | 10 +-
.../cloud_p0/query_retry/test_retry_e-230.groovy | 205 +++--
3 files changed, 116 insertions(+), 102 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java
b/fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java
index fb13633319b..cf1573810c9 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java
@@ -758,8 +758,7 @@ public abstract class ConnectProcessor {
UUID uuid = UUID.randomUUID();
queryId = new TUniqueId(uuid.getMostSignificantBits(),
uuid.getLeastSignificantBits());
}
-
-executor.execute(queryId);
+executor.queryRetry(queryId);
} catch (IOException e) {
// Client failed.
LOG.warn("Process one query failed because IOException: ", e);
diff --git a/fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java
b/fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java
index fcd0d25a130..783b6b95490 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java
@@ -528,10 +528,15 @@ public class StmtExecutor {
public void execute() throws Exception {
UUID uuid = UUID.randomUUID();
TUniqueId queryId = new TUniqueId(uuid.getMostSignificantBits(),
uuid.getLeastSignificantBits());
-TUniqueId firstQueryId = queryId;
if (Config.enable_print_request_before_execution) {
LOG.info("begin to execute query {} {}", queryId, originStmt ==
null ? "null" : originStmt.originStmt);
}
+queryRetry(queryId);
+}
+
+public void queryRetry(TUniqueId queryId) throws Exception {
+TUniqueId firstQueryId = queryId;
+UUID uuid;
int retryTime = Config.max_query_retry_time;
retryTime = retryTime <= 0 ? 1 : retryTime + 1;
for (int i = 1; i <= retryTime; i++) {
@@ -751,6 +756,9 @@ public class StmtExecutor {
if (LOG.isDebugEnabled()) {
LOG.debug("Command({}) process failed.",
originStmt.originStmt, e);
}
+if (Config.isCloudMode() &&
e.getDetailMessage().contains(FeConstants.CLOUD_RETRY_E230)) {
+throw e;
+}
context.getState().setError(e.getMysqlErrorCode(),
e.getMessage());
throw new NereidsException("Command (" + originStmt.originStmt
+ ") process failed",
new AnalysisException(e.getMessage(), e));
diff --git
a/regression-test/suites/cloud_p0/query_retry/test_retry_e-230.groovy
b/regression-test/suites/cloud_p0/query_retry/test_retry_e-230.groovy
index 8f96d1fd9d2..2d8ca3f5296 100644
--- a/regression-test/suites/cloud_p0/query_retry/test_retry_e-230.groovy
+++ b/regression-test/suites/cloud_p0/query_retry/test_retry_e-230.groovy
@@ -24,120 +24,127 @@ suite("test_retry_e-230") {
}
def options = new ClusterOptions()
options.enableDebugPoints()
-options.setFeNum(1)
+// one master, one observer
+options.setFeNum(2)
options.feConfigs.add('max_query_retry_time=100')
options.feConfigs.add('sys_log_verbose_modules=org')
options.setBeNum(1)
options.cloudMode = true
-docker(options) {
-def tbl = 'test_retry_e_230_tbl'
-def tbl1 = 'table_1'
-def tbl2 = 'table_2'
-sql """ DROP TABLE IF EXISTS ${tbl} """
-sql """ DROP TABLE IF EXISTS ${tbl1} """
-sql """ DROP TABLE IF EXISTS ${tbl2} """
-try {
-sql """set global experimental_enable_pipeline_x_engine=false"""
-cluster.injectDebugPoints(NodeType.BE,
['CloudTablet.capture_rs_readers.return.e-230' : null])
+// 1. connect to master
+options.connectToFollower = false
+for (def j = 0; j < 2; j++) {
+docker(options) {
+def tbl = 'test_retry_e_230_tbl'
+def tbl1 = 'table_1'
+def tbl2 = 'table_2'
+sql """ DROP TABLE IF EXISTS ${tbl} """
+sql """ DROP TABLE IF EXISTS ${tbl1} """
+sql """ DROP TABLE IF EXISTS ${tbl2} """
+try {
+sql """set global
experiment
Re: [PR] [fix](stacktrace) Add conf `enable_stacktrace` [doris]
xinyiZzz commented on PR #37713: URL: https://github.com/apache/doris/pull/37713#issuecomment-2225042671 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](partition) Fix be tablet partition id eq 0 By report tablet #32179 [doris]
deardeng commented on PR #37588: URL: https://github.com/apache/doris/pull/37588#issuecomment-2225042683 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](sleep) sleep with character const make be crash [doris]
cambyzju commented on code in PR #37681:
URL: https://github.com/apache/doris/pull/37681#discussion_r1675475352
##
be/src/vec/functions/function_utility.cpp:
##
@@ -74,19 +74,12 @@ class FunctionSleep : public IFunction {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](sleep) sleep with character const make be crash [doris]
cambyzju commented on PR #37681: URL: https://github.com/apache/doris/pull/37681#issuecomment-2225043377 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Update](inverted index) Add column name to debug point for "no need to read data" optimization [doris]
airborne12 merged PR #37649: URL: https://github.com/apache/doris/pull/37649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (570dfb41e65 -> aea3a560cae)
This is an automated email from the ASF dual-hosted git repository. airborne pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 570dfb41e65 [fix](cloud) Fix cloud meet e-230 not retry query from observer (#37625) add aea3a560cae [Update](inverted index) Add column name to debug point for "no need to read data" optimization (#37649) No new revisions were added by this update. Summary of changes: be/src/olap/rowset/segment_v2/segment_iterator.cpp | 10 +- .../test_need_read_data_fault_injection.out| 249 + .../test_need_read_data_fault_injection.groovy | 12 + 3 files changed, 270 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](index) add more inverted index profile metrics [doris]
doris-robot commented on PR #36696: URL: https://github.com/apache/doris/pull/36696#issuecomment-2225049821 TPC-H: Total hot run time: 40088 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 7ed5d91221ee47a65a168a0a82bd07fefc259742, data reload: false -- Round 1 -- q1 17604 441643084308 q2 2010196 189 189 q3 10504 121511391139 q4 10182 710 863 710 q5 7560276227032703 q6 220 142 141 141 q7 989 601 605 601 q8 9211210120942094 q9 8834655865516551 q10 8892382438123812 q11 473 235 243 235 q12 403 235 226 226 q13 18561 298630012986 q14 274 229 236 229 q15 523 484 481 481 q16 508 379 372 372 q17 984 596 695 596 q18 8133747074037403 q19 6403154214891489 q20 704 334 339 334 q21 4975315431683154 q22 383 335 342 335 Total cold run time: 118330 ms Total hot run time: 40088 ms - Round 2, with runtime_filter_mode=off - q1 4446424642594246 q2 390 272 262 262 q3 3050293828972897 q4 1962165617691656 q5 5664558954955495 q6 223 139 139 139 q7 2202191718581858 q8 3277343134893431 q9 8788888689018886 q10 4097381837853785 q11 601 504 509 504 q12 815 649 650 649 q13 16011 316931873169 q14 333 305 290 290 q15 532 497 497 497 q16 492 430 445 430 q17 1832151815051505 q18 8074823880228022 q19 1843167015421542 q20 2206189818791879 q21 5019481948514819 q22 619 558 552 552 Total cold run time: 72476 ms Total hot run time: 56513 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](stacktrace) Add conf `enable_stacktrace` [doris]
github-actions[bot] commented on PR #37713: URL: https://github.com/apache/doris/pull/37713#issuecomment-2225052138 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](sleep) sleep with character const make be crash [doris]
github-actions[bot] commented on PR #37681: URL: https://github.com/apache/doris/pull/37681#issuecomment-2225052713 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](timeout) unify query_timeout, use setting from user property first [doris]
github-actions[bot] commented on PR #37626: URL: https://github.com/apache/doris/pull/37626#issuecomment-2225057013 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](timeout) unify query_timeout, use setting from user property first [doris]
github-actions[bot] commented on PR #37626: URL: https://github.com/apache/doris/pull/37626#issuecomment-2225057047 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](inverted index) implementation of match function without index [doris]
doris-robot commented on PR #36918: URL: https://github.com/apache/doris/pull/36918#issuecomment-2225059886 TeamCity be ut coverage result: Function Coverage: 36.44% (9184/25206) Line Coverage: 27.96% (75098/268566) Region Coverage: 26.84% (38739/144355) Branch Coverage: 23.53% (19636/83468) Coverage Report: http://coverage.selectdb-in.cc/coverage/4c1f6f30c1e6ab98bff59c91d6018de2bec52e4c_4c1f6f30c1e6ab98bff59c91d6018de2bec52e4c/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [improvement](statistics)Async drop stats while truncating table. [doris]
Jibing-Li opened a new pull request, #37715: URL: https://github.com/apache/doris/pull/37715 Drop stats for table with many partitions may slow, because to invalidate partition stats cache is time consuming. Truncate table operation do the drop stats synchronously, so the truncate table may be very slow for partition tables. This pr is to improvement the performance of truncate table. Do the drop stats asynchronously. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](statistics)Async drop stats while truncating table. [doris]
doris-robot commented on PR #37715: URL: https://github.com/apache/doris/pull/37715#issuecomment-2225061223 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](statistics)Async drop stats while truncating table. [doris]
Jibing-Li commented on PR #37715: URL: https://github.com/apache/doris/pull/37715#issuecomment-2225062835 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](index) add more inverted index profile metrics [doris]
doris-robot commented on PR #36696: URL: https://github.com/apache/doris/pull/36696#issuecomment-2225067992 TPC-DS: Total hot run time: 176219 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 7ed5d91221ee47a65a168a0a82bd07fefc259742, data reload: false query1 929 374 362 362 query2 7575241424672414 query3 6636212 218 212 query4 27701 17415 17394 17394 query5 3688525 485 485 query6 261 160 161 160 query7 4603302 307 302 query8 324 297 301 297 query9 8481244324412441 query10 449 291 284 284 query11 11891 10044 10087 10044 query12 118 90 80 80 query13 1640365 360 360 query14 10581 771677387716 query15 243 185 188 185 query16 7581314 312 312 query17 1363534 555 534 query18 1840278 276 276 query19 190 155 152 152 query20 93 81 82 81 query21 204 127 129 127 query22 4437409440354035 query23 34199 33717 33699 33699 query24 11246 291129272911 query25 651 390 392 390 query26 1194158 161 158 query27 2597275 283 275 query28 7535214221322132 query29 918 659 654 654 query30 255 151 153 151 query31 977 777 780 777 query32 100 55 59 55 query33 802 300 311 300 query34 996 512 520 512 query35 709 612 608 608 query36 1092980 978 978 query37 159 91 85 85 query38 2907287628632863 query39 926 864 848 848 query40 207 136 134 134 query41 59 53 50 50 query42 115 104 103 103 query43 606 570 569 569 query44 1217716 734 716 query45 197 170 173 170 query46 1087738 725 725 query47 1874173917481739 query48 375 308 298 298 query49 876 443 442 442 query50 789 405 405 405 query51 6887667966976679 query52 113 95 98 95 query53 372 303 310 303 query54 917 471 460 460 query55 79 78 77 77 query56 315 290 302 290 query57 1162102410751024 query58 266 265 289 265 query59 3488322332543223 query60 337 309 309 309 query61 122 116 120 116 query62 810 648 660 648 query63 324 296 304 296 query64 9587228717531753 query65 3183315631163116 query66 848 346 355 346 query67 15456 14933 15086 14933 query68 4617537 551 537 query69 681 436 383 383 query70 1205113211651132 query71 455 295 294 294 query72 9246576856855685 query73 758 324 331 324 query74 5963555155335533 query75 4130272727052705 query76 3296949 985 949 query77 701 326 308 308 query78 11550 986191449144 query79 11763 583 514 514 query80 949 465 483 465 query81 582 222 221 221 query82 771 133 131 131 query83 312 167 166 166 query84 283 87 87 87 query85 740 307 308 307 query86 376 313 326 313 query87 3307312830763076 query88 5221247625152476 query89 547 380 382 380 query90 2060199 197 197 query91 131 104 102 102 query92 65 48 50 48 query93 6685499 496 496 query94 1149212 214 212 query95 419 323 333 323 query96 612 283 272 272 query97 3189302530273025 query98 228 200 188 188 query99 1531129313061293 Total cold run time: 303281 ms Total hot run time: 176219 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
[PR] [bugfix](paimon)Fixed the reading of timestamp with time zone type data [doris]
wuwenchi opened a new pull request, #37716: URL: https://github.com/apache/doris/pull/37716 ## Proposed changes 1. When using jni to read timestamps with time zones, the time needs to be converted to local time 2. In version 0.8 of paimon, the time zone (isAdjustToUTC) information of parquet files is added, and doris can parse data directly according to the time zone information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bugfix](paimon)Fixed the reading of timestamp with time zone type data [doris]
doris-robot commented on PR #37716: URL: https://github.com/apache/doris/pull/37716#issuecomment-2225070523 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bugfix](paimon)Fixed the reading of timestamp with time zone type data [doris]
wuwenchi commented on PR #37716: URL: https://github.com/apache/doris/pull/37716#issuecomment-2225070687 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.1](memory) Support make all memory snapshots [doris]
HappenLee merged PR #37705: URL: https://github.com/apache/doris/pull/37705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: [branch-2.1](memory) Support make all memory snapshots (#37705)
This is an automated email from the ASF dual-hosted git repository.
lihaopeng pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new a61030215e4 [branch-2.1](memory) Support make all memory snapshots
(#37705)
a61030215e4 is described below
commit a61030215e4b039fd6b5b544227d81ecd23d9bc7
Author: Xinyi Zou
AuthorDate: Fri Jul 12 16:21:37 2024 +0800
[branch-2.1](memory) Support make all memory snapshots (#37705)
pick #36679
---
be/src/common/daemon.cpp | 8 ++--
be/src/http/default_path_handlers.cpp | 2 +
be/src/runtime/memory/mem_tracker.cpp | 16 +++-
be/src/runtime/memory/mem_tracker.h| 35 +
be/src/runtime/memory/mem_tracker_limiter.cpp | 45 +++---
be/src/runtime/memory/mem_tracker_limiter.h| 37 ++
...emory_arbitrator.cpp => memory_reclamation.cpp} | 13 ---
.../{memory_arbitrator.h => memory_reclamation.h} | 2 +-
be/src/vec/sink/writer/vtablet_writer.cpp | 6 +--
9 files changed, 102 insertions(+), 62 deletions(-)
diff --git a/be/src/common/daemon.cpp b/be/src/common/daemon.cpp
index 77d0fdaf0e5..d54189bce23 100644
--- a/be/src/common/daemon.cpp
+++ b/be/src/common/daemon.cpp
@@ -50,7 +50,7 @@
#include "runtime/memory/global_memory_arbitrator.h"
#include "runtime/memory/mem_tracker.h"
#include "runtime/memory/mem_tracker_limiter.h"
-#include "runtime/memory/memory_arbitrator.h"
+#include "runtime/memory/memory_reclamation.h"
#include "runtime/runtime_query_statistics_mgr.h"
#include "runtime/workload_group/workload_group_manager.h"
#include "util/cpu_info.h"
@@ -234,7 +234,7 @@ void Daemon::memory_gc_thread() {
auto process_memory_usage =
doris::GlobalMemoryArbitrator::process_memory_usage();
// GC excess memory for resource groups that not enable overcommit
-auto tg_free_mem =
doris::MemoryArbitrator::tg_disable_overcommit_group_gc();
+auto tg_free_mem =
doris::MemoryReclamation::tg_disable_overcommit_group_gc();
sys_mem_available += tg_free_mem;
process_memory_usage -= tg_free_mem;
@@ -248,7 +248,7 @@ void Daemon::memory_gc_thread() {
memory_minor_gc_sleep_time_ms = memory_gc_sleep_time_ms;
LOG(INFO) << fmt::format("[MemoryGC] start full GC, {}.",
mem_info);
doris::MemTrackerLimiter::print_log_process_usage();
-if (doris::MemoryArbitrator::process_full_gc(std::move(mem_info)))
{
+if
(doris::MemoryReclamation::process_full_gc(std::move(mem_info))) {
// If there is not enough memory to be gc, the process memory
usage will not be printed in the next continuous gc.
doris::MemTrackerLimiter::enable_print_log_process_usage();
}
@@ -261,7 +261,7 @@ void Daemon::memory_gc_thread() {
memory_minor_gc_sleep_time_ms = memory_gc_sleep_time_ms;
LOG(INFO) << fmt::format("[MemoryGC] start minor GC, {}.",
mem_info);
doris::MemTrackerLimiter::print_log_process_usage();
-if
(doris::MemoryArbitrator::process_minor_gc(std::move(mem_info))) {
+if
(doris::MemoryReclamation::process_minor_gc(std::move(mem_info))) {
doris::MemTrackerLimiter::enable_print_log_process_usage();
}
} else {
diff --git a/be/src/http/default_path_handlers.cpp
b/be/src/http/default_path_handlers.cpp
index 5c697539fbc..8d1a14ffda3 100644
--- a/be/src/http/default_path_handlers.cpp
+++ b/be/src/http/default_path_handlers.cpp
@@ -158,6 +158,8 @@ void mem_tracker_handler(const WebPageHandler::ArgumentMap&
args, std::stringstr
MemTrackerLimiter::make_type_snapshots(&snapshots,
MemTrackerLimiter::Type::OTHER);
} else if (iter->second == "reserved_memory") {
GlobalMemoryArbitrator::make_reserved_memory_snapshots(&snapshots);
+} else if (iter->second == "all") {
+MemTrackerLimiter::make_all_memory_state_snapshots(&snapshots);
}
} else {
(*output) << "*Notice:\n";
diff --git a/be/src/runtime/memory/mem_tracker.cpp
b/be/src/runtime/memory/mem_tracker.cpp
index 27b16c76f2c..f5a3853f79f 100644
--- a/be/src/runtime/memory/mem_tracker.cpp
+++ b/be/src/runtime/memory/mem_tracker.cpp
@@ -45,9 +45,11 @@ MemTracker::MemTracker(const std::string& label,
MemTrackerLimiter* parent) : _l
void MemTracker::bind_parent(MemTrackerLimiter* parent) {
if (parent) {
+_type = parent->type();
_parent_label = parent->label();
_parent_group_num = parent->group_num();
} else {
+_type = thread_context()->thread_mem_tracker()->type();
_parent_label = thread_context()->thread_mem_tracker()->label();
_parent_group_num =
thread_context()->thread_mem_tracker()->group_num
Re: [PR] [bugfix](paimon)Fixed the reading of timestamp with time zone type data [doris]
wuwenchi commented on PR #37716: URL: https://github.com/apache/doris/pull/37716#issuecomment-2225074326 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](split) remove retry when fetch split batch failed [doris]
github-actions[bot] commented on PR #37636: URL: https://github.com/apache/doris/pull/37636#issuecomment-2225075937 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](index) add more inverted index profile metrics [doris]
doris-robot commented on PR #36696: URL: https://github.com/apache/doris/pull/36696#issuecomment-2225076904 ClickBench: Total hot run time: 30.91 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 7ed5d91221ee47a65a168a0a82bd07fefc259742, data reload: false query1 0.040.040.03 query2 0.080.030.04 query3 0.220.050.06 query4 1.680.090.08 query5 0.490.490.50 query6 1.130.730.73 query7 0.020.020.01 query8 0.050.040.04 query9 0.540.490.49 query10 0.540.530.54 query11 0.150.110.12 query12 0.150.120.12 query13 0.590.580.59 query14 0.750.780.81 query15 0.850.810.81 query16 0.370.370.35 query17 0.970.971.05 query18 0.220.210.22 query19 1.791.711.70 query20 0.020.010.01 query21 15.39 0.790.68 query22 4.636.562.15 query23 18.16 1.371.33 query24 2.180.220.23 query25 0.160.090.08 query26 0.310.210.21 query27 0.450.220.23 query28 13.26 1.031.00 query29 12.59 3.333.32 query30 0.260.060.06 query31 2.880.380.38 query32 3.280.480.47 query33 2.912.952.94 query34 16.92 4.324.29 query35 4.444.414.39 query36 0.650.470.46 query37 0.190.160.16 query38 0.150.160.15 query39 0.040.030.03 query40 0.160.120.14 query41 0.090.050.05 query42 0.050.040.05 query43 0.050.040.04 Total cold run time: 109.85 s Total hot run time: 30.91 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](partition) Fix be tablet partition id eq 0 By report tablet #32179 [doris]
doris-robot commented on PR #37588: URL: https://github.com/apache/doris/pull/37588#issuecomment-2225077934 TPC-H: Total hot run time: 51356 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit ee53571c74df66462676751bafc1103537d70398, data reload: false -- Round 1 -- q1 17599 462045484548 q2 2068161 154 154 q3 10459 200720472007 q4 10284 132314471323 q5 8501391340193913 q6 280 130 125 125 q7 2104158215961582 q8 9292290929052905 q9 10805 10509 10430 10430 q10 8663359235463546 q11 425 249 244 244 q12 514 311 308 308 q13 18381 407041084070 q14 352 332 327 327 q15 520 461 459 459 q16 688 571 577 571 q17 1193101310421013 q18 7298702970867029 q19 1874175817351735 q20 542 301 317 301 q21 4703432643404326 q22 550 440 450 440 Total cold run time: 117095 ms Total hot run time: 51356 ms - Round 2, with runtime_filter_mode=off - q1 4552449445124494 q2 338 232 224 224 q3 4225421542484215 q4 2857285228602852 q5 7033699769956995 q6 259 120 122 120 q7 3255279528192795 q8 4242441343994399 q9 16988 16922 16918 16918 q10 4306433843004300 q11 726 663 681 663 q12 1054835 869 835 q13 6970388338693869 q14 459 435 437 435 q15 516 455 455 455 q16 738 678 686 678 q17 3790386038143814 q18 8872887188458845 q19 1821185018061806 q20 2386211721112111 q21 8564844084708440 q22 1081993 934 934 Total cold run time: 85032 ms Total hot run time: 80197 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](arrow-flight-sql) Open regression-test/pipeline/p0/arrow_flight_sql [doris]
HappenLee commented on code in PR #36854: URL: https://github.com/apache/doris/pull/36854#discussion_r1675501313 ## fe/fe-core/src/main/java/org/apache/doris/service/arrowflight/DorisFlightSqlProducer.java: ## @@ -90,7 +90,7 @@ /** * Implementation of Arrow Flight SQL service - * + * Review Comment: what the `` means ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](partition) Fix be tablet partition id eq 0 By report tablet #32179 [doris]
doris-robot commented on PR #37588: URL: https://github.com/apache/doris/pull/37588#issuecomment-2225079255 TeamCity be ut coverage result: Function Coverage: 37.89% (8116/21422) Line Coverage: 29.54% (66530/225194) Region Coverage: 29.01% (34285/118186) Branch Coverage: 24.88% (17610/70786) Coverage Report: http://coverage.selectdb-in.cc/coverage/ee53571c74df66462676751bafc1103537d70398_ee53571c74df66462676751bafc1103537d70398/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bugfix](paimon)Fixed the reading of timestamp with time zone type data [doris]
github-actions[bot] commented on PR #37716: URL: https://github.com/apache/doris/pull/37716#issuecomment-2225081340 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](arrow-flight-sql) Open regression-test/pipeline/p0/arrow_flight_sql [doris]
xinyiZzz commented on code in PR #36854: URL: https://github.com/apache/doris/pull/36854#discussion_r1675505233 ## fe/fe-core/src/main/java/org/apache/doris/service/arrowflight/DorisFlightSqlProducer.java: ## @@ -90,7 +90,7 @@ /** * Implementation of Arrow Flight SQL service - * + * Review Comment: IDEA format code automatically added It seems that because the comment is segmented。。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bugfix](paimon)Fixed the reading of timestamp with time zone type data [doris]
github-actions[bot] commented on PR #37716: URL: https://github.com/apache/doris/pull/37716#issuecomment-2225083154 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](partition) Fix be tablet partition id eq 0 By report tablet #32179 [doris]
github-actions[bot] commented on PR #37588: URL: https://github.com/apache/doris/pull/37588#issuecomment-2225086318 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [change](index) change enable_create_bitmap_index_as_inverted_index default to true #36692 [doris]
xiaokang opened a new pull request, #37717: URL: https://github.com/apache/doris/pull/37717 cherry pick from #36692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [change](index) change enable_create_bitmap_index_as_inverted_index default to true #36692 [doris]
xiaokang commented on PR #37717: URL: https://github.com/apache/doris/pull/37717#issuecomment-2225086366 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [change](index) change enable_create_bitmap_index_as_inverted_index default to true #36692 [doris]
doris-robot commented on PR #37717: URL: https://github.com/apache/doris/pull/37717#issuecomment-2225086469 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (index compaction) Fix inverted index file size [doris]
airborne12 commented on code in PR #37564:
URL: https://github.com/apache/doris/pull/37564#discussion_r1675511435
##
be/src/olap/compaction.cpp:
##
@@ -654,16 +658,31 @@ Status Compaction::do_inverted_index_compaction() {
if (st.ok()) {
auto index_not_need_to_compact =
DORIS_TRY(inverted_index_file_reader->get_all_directories());
+// V1: each index is a separate file
+// V2: all indexes are in a single file
+if (_cur_tablet_schema->get_inverted_index_storage_format() ==
Review Comment:
if (_cur_tablet_schema->get_inverted_index_storage_format() != V1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [docs](readme) Update readme label and pics [doris]
luzhijing commented on PR #37711: URL: https://github.com/apache/doris/pull/37711#issuecomment-2225093934 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [docs](readme) Update readme label and pics [doris]
github-actions[bot] commented on PR #37711: URL: https://github.com/apache/doris/pull/37711#issuecomment-2225094936 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (index compaction) Fix inverted index file size [doris]
csun5285 commented on code in PR #37564:
URL: https://github.com/apache/doris/pull/37564#discussion_r1675517065
##
be/src/olap/compaction.cpp:
##
@@ -654,16 +658,31 @@ Status Compaction::do_inverted_index_compaction() {
if (st.ok()) {
auto index_not_need_to_compact =
DORIS_TRY(inverted_index_file_reader->get_all_directories());
+// V1: each index is a separate file
+// V2: all indexes are in a single file
+if (_cur_tablet_schema->get_inverted_index_storage_format() ==
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](partition) Fix be tablet partition id eq 0 By report tablet #32179 [doris]
doris-robot commented on PR #37588: URL: https://github.com/apache/doris/pull/37588#issuecomment-2225098330 TPC-DS: Total hot run time: 203480 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit ee53571c74df66462676751bafc1103537d70398, data reload: false query1 916 415 376 376 query2 6522281326692669 query3 6921202 205 202 query4 20168 18138 17871 17871 query5 19739 652065126512 query6 305 217 230 217 query7 4158298 308 298 query8 434 453 415 415 query9 3078269126112611 query10 419 298 294 294 query11 11285 10812 10636 10636 query12 128 77 74 74 query13 5604694 707 694 query14 17745 13132 13179 13132 query15 358 244 248 244 query16 6472295 262 262 query17 16861459880 880 query18 2310423 399 399 query19 204 149 148 148 query20 83 75 80 75 query21 194 97 95 95 query22 5270481449554814 query23 32505 31828 31918 31828 query24 6973645164856451 query25 519 420 403 403 query26 531 164 167 164 query27 1892289 292 289 query28 6163240223582358 query29 2932278428452784 query30 252 164 167 164 query31 914 725 731 725 query32 65 64 63 63 query33 398 257 248 248 query34 855 469 490 469 query35 1129929 933 929 query36 1437112412281124 query37 94 63 60 60 query38 3073294729052905 query39 1378132613191319 query40 202 99 95 95 query41 47 43 43 43 query42 82 91 90 90 query43 870 628 749 628 query44 1132736 741 736 query45 247 233 232 232 query46 1219956 968 956 query47 2113166816431643 query48 1019719 698 698 query49 625 365 360 360 query50 869 586 580 580 query51 4805470646904690 query52 94 87 96 87 query53 437 321 320 320 query54 2673246824302430 query55 98 72 87 72 query56 218 233 209 209 query57 1193112011601120 query58 205 203 198 198 query59 4143364444123644 query60 207 206 188 188 query61 96 91 95 91 query62 838 536 479 479 query63 491 339 341 339 query64 2485154113781378 query65 3604358435233523 query66 775 390 375 375 query67 15580 15222 15013 15013 query68 11156 669 677 669 query69 614 332 360 332 query70 2058135913431343 query71 439 313 313 313 query72 6478349534933493 query73 751 326 324 324 query74 6352584058175817 query75 5616370236503650 query76 6979111211681112 query77 1189264 260 260 query78 12746 13118 13096 13096 query79 8895644 649 644 query80 667 407 398 398 query81 453 234 227 227 query82 243 97 101 97 query83 186 135 135 135 query84 258 70 68 68 query85 734 325 329 325 query86 349 291 292 291 query87 3268303530373035 query88 4589233023572330 query89 345 309 287 287 query90 2323206 214 206 query91 183 157 138 138 query92 62 52 52 52 query93 1939595 588 588 query94 926 204 212 204 query95 1122104710641047 query96 635 325 330 325 query97 6534623763166237 query98 188 175 173 173 query99 2986920 846 846 Total cold run time: 312739 ms Total hot run time: 203480 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [fix] (index compaction) Fix inverted index file size [doris]
csun5285 commented on PR #37564: URL: https://github.com/apache/doris/pull/37564#issuecomment-2225099145 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](inverted index) opt value extraction from column to string [doris]
airborne12 merged PR #37395: URL: https://github.com/apache/doris/pull/37395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [opt](inverted index) opt value extraction from column to string (#37395)
This is an automated email from the ASF dual-hosted git repository.
airborne pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new f6afbf73b91 [opt](inverted index) opt value extraction from column to
string (#37395)
f6afbf73b91 is described below
commit f6afbf73b913f98315be243730f17a9ad2a498ff
Author: zzzxl <33418555+zzzxl1...@users.noreply.github.com>
AuthorDate: Fri Jul 12 16:40:31 2024 +0800
[opt](inverted index) opt value extraction from column to string (#37395)
## Proposed changes
Issue Number: close #xxx
---
be/src/vec/exprs/vexpr.cpp | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/be/src/vec/exprs/vexpr.cpp b/be/src/vec/exprs/vexpr.cpp
index 3a965c27c92..d788c8dc518 100644
--- a/be/src/vec/exprs/vexpr.cpp
+++ b/be/src/vec/exprs/vexpr.cpp
@@ -631,11 +631,13 @@ std::string VExpr::gen_predicate_result_sign(Block&
block, const ColumnNumbers&
// Generating 'result_sign' from 'inlist' requires sorting the values.
std::set values;
for (size_t i = 1; i < arguments.size(); i++) {
-values.insert(block.get_by_position(arguments[i]).to_string(0));
+const auto& entry = block.get_by_position(arguments[i]);
+values.insert(entry.type->to_string(*entry.column, 0));
}
pred_result_sign += boost::join(values, ",");
} else {
-pred_result_sign += block.get_by_position(arguments[1]).to_string(0);
+const auto& entry = block.get_by_position(arguments[1]);
+pred_result_sign += entry.type->to_string(*entry.column, 0);
}
return pred_result_sign;
}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](partition) Fix be tablet partition id eq 0 By report tablet #32179 [doris]
doris-robot commented on PR #37588: URL: https://github.com/apache/doris/pull/37588#issuecomment-2225107407 ClickBench: Total hot run time: 30.43 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit ee53571c74df66462676751bafc1103537d70398, data reload: false query1 0.030.020.02 query2 0.080.020.02 query3 0.250.040.05 query4 1.790.060.05 query5 0.540.530.53 query6 1.250.660.61 query7 0.010.000.01 query8 0.040.030.02 query9 0.530.480.47 query10 0.540.530.53 query11 0.120.080.08 query12 0.110.090.09 query13 0.620.620.60 query14 0.770.780.78 query15 0.780.760.75 query16 0.380.360.37 query17 1.011.031.04 query18 0.220.270.22 query19 1.921.821.84 query20 0.010.010.02 query21 15.46 0.570.53 query22 2.011.961.47 query23 17.07 0.941.01 query24 4.470.820.98 query25 0.270.060.06 query26 0.630.150.15 query27 0.050.040.03 query28 9.560.710.72 query29 12.64 2.292.35 query30 0.620.530.52 query31 2.850.390.38 query32 3.390.500.49 query33 3.053.113.12 query34 15.26 4.814.80 query35 4.894.844.85 query36 1.061.011.01 query37 0.060.050.05 query38 0.040.020.02 query39 0.020.010.01 query40 0.160.140.13 query41 0.070.010.01 query42 0.020.020.01 query43 0.020.020.02 Total cold run time: 104.67 s Total hot run time: 30.43 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](statistics)Async drop stats while truncating table. [doris]
doris-robot commented on PR #37715: URL: https://github.com/apache/doris/pull/37715#issuecomment-2225109792 TPC-H: Total hot run time: 40428 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 84cae3e8be9d9caf102b47c581e456947ee28fcf, data reload: false -- Round 1 -- q1 17822 443643744374 q2 2499204 204 204 q3 10996 119411351135 q4 10731 822 854 822 q5 7616272627072707 q6 230 141 141 141 q7 962 620 622 620 q8 9675210221072102 q9 8642655565676555 q10 8757381837593759 q11 474 243 239 239 q12 405 235 227 227 q13 18666 301430263014 q14 276 234 249 234 q15 532 475 480 475 q16 487 386 379 379 q17 973 618 653 618 q18 7993751175077507 q19 6026149714321432 q20 694 320 323 320 q21 5020323233253232 q22 402 332 344 332 Total cold run time: 119878 ms Total hot run time: 40428 ms - Round 2, with runtime_filter_mode=off - q1 4378426042284228 q2 371 278 269 269 q3 3049277127772771 q4 1956162316141614 q5 5310532453175317 q6 216 134 133 133 q7 2060175616811681 q8 3164335132883288 q9 8404837083798370 q10 3861378837123712 q11 603 492 527 492 q12 800 611 624 611 q13 16705 302729942994 q14 312 265 268 265 q15 523 478 477 477 q16 467 423 422 422 q17 1778151114981498 q18 7651750173567356 q19 3690152916211529 q20 2004180017741774 q21 4998466647694666 q22 667 526 543 526 Total cold run time: 72967 ms Total hot run time: 53993 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](partition) Fix be tablet partition id eq 0 By report tablet #32179 [doris]
doris-robot commented on PR #37588: URL: https://github.com/apache/doris/pull/37588#issuecomment-2225112614 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit ee53571c74df66462676751bafc1103537d70398 with default session variables Stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s Insert into select: 21.2 seconds inserted 1000 Rows, about 471K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](sleep) sleep with character const make be crash [doris]
doris-robot commented on PR #37681: URL: https://github.com/apache/doris/pull/37681#issuecomment-2225120401 TPC-H: Total hot run time: 40099 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 62dc29da0f0bb17ccaeee8c25ecda2e77b0e6e92, data reload: false -- Round 1 -- q1 17618 434543464345 q2 2023194 184 184 q3 10448 120911601160 q4 10201 871 773 773 q5 7554267626682668 q6 220 139 140 139 q7 959 604 602 602 q8 9232209320602060 q9 8750657165956571 q10 8899375737803757 q11 464 245 248 245 q12 403 227 230 227 q13 17758 299830252998 q14 275 239 225 225 q15 533 491 480 480 q16 484 394 382 382 q17 965 687 609 609 q18 8062740073667366 q19 7312145415151454 q20 662 320 327 320 q21 4880320040473200 q22 383 334 341 334 Total cold run time: 118085 ms Total hot run time: 40099 ms - Round 2, with runtime_filter_mode=off - q1 4411426242814262 q2 389 267 273 267 q3 3073289929232899 q4 1973169617631696 q5 5537559154665466 q6 244 135 136 135 q7 2209185418621854 q8 3256339534473395 q9 8801881189338811 q10 4108386337803780 q11 605 505 496 496 q12 831 652 645 645 q13 16175 317031933170 q14 321 295 288 288 q15 523 490 487 487 q16 504 444 428 428 q17 1830151615261516 q18 8146790777507750 q19 1792164416821644 q20 2122188019111880 q21 5049484047874787 q22 612 522 578 522 Total cold run time: 72511 ms Total hot run time: 56178 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (index compaction) Fix inverted index file size [doris]
csun5285 commented on PR #37564: URL: https://github.com/apache/doris/pull/37564#issuecomment-2225128081 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](statistics)Async drop stats while truncating table. [doris]
doris-robot commented on PR #37715: URL: https://github.com/apache/doris/pull/37715#issuecomment-2225131712 TPC-DS: Total hot run time: 174477 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 84cae3e8be9d9caf102b47c581e456947ee28fcf, data reload: false query1 920 380 370 370 query2 6451245723522352 query3 6648215 224 215 query4 28555 17479 17382 17382 query5 4195504 513 504 query6 287 184 166 166 query7 4589306 307 306 query8 336 293 299 293 query9 8562247024662466 query10 453 297 285 285 query11 10610 10133 10090 10090 query12 150 89 83 83 query13 1639381 375 375 query14 10360 810277017701 query15 252 194 194 194 query16 7686312 316 312 query17 1812561 560 560 query18 1635279 274 274 query19 202 151 153 151 query20 97 85 87 85 query21 213 130 132 130 query22 4322412438483848 query23 33930 33195 33128 33128 query24 12168 294828842884 query25 675 405 382 382 query26 1635158 165 158 query27 2714275 279 275 query28 7239211020892089 query29 1042641 612 612 query30 287 150 154 150 query31 971 748 760 748 query32 102 57 57 57 query33 773 324 333 324 query34 885 499 495 495 query35 728 598 628 598 query36 1130923 947 923 query37 283 81 80 80 query38 2869274627412741 query39 869 823 812 812 query40 276 131 125 125 query41 56 51 55 51 query42 122 98 110 98 query43 592 542 547 542 query44 1216747 726 726 query45 202 164 173 164 query46 1100774 727 727 query47 1861177217641764 query48 384 311 300 300 query49 1206424 422 422 query50 797 410 418 410 query51 6910693168136813 query52 108 99 97 97 query53 363 303 300 300 query54 1041457 457 457 query55 77 77 78 77 query56 294 283 291 283 query57 1197102910791029 query58 321 259 283 259 query59 3374322633593226 query60 315 284 282 282 query61 98 110 94 94 query62 849 637 662 637 query63 342 307 302 302 query64 10506 226417491749 query65 3198314531393139 query66 1359345 333 333 query67 15259 14933 14943 14933 query68 4556566 549 549 query69 479 339 340 339 query70 1166114410831083 query71 378 282 289 282 query72 7177557250515051 query73 758 330 329 329 query74 5862545154325432 query75 3447272027192719 query76 2781955 968 955 query77 512 323 331 323 query78 9694905795459057 query79 2906543 541 541 query80 1966495 493 493 query81 597 230 227 227 query82 1032146 147 146 query83 293 168 167 167 query84 264 94 90 90 query85 1451323 308 308 query86 474 349 332 332 query87 3258311131443111 query88 3957247424822474 query89 485 404 397 397 query90 1805200 196 196 query91 138 107 102 102 query92 71 50 51 50 query93 1968517 520 517 query94 1277223 218 218 query95 413 324 326 324 query96 616 280 270 270 query97 3191299930872999 query98 216 204 199 199 query99 1504126012601260 Total cold run time: 286389 ms Total hot run time: 174477 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [fix](stacktrace) Add conf `enable_stacktrace` [doris]
xinyiZzz commented on PR #37713: URL: https://github.com/apache/doris/pull/37713#issuecomment-2225137995 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bugfix](paimon)Fixed the reading of timestamp with time zone type data [doris]
doris-robot commented on PR #37716: URL: https://github.com/apache/doris/pull/37716#issuecomment-2225138690 TPC-H: Total hot run time: 39665 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 3ed9eefd57f4506786d406b6228fc313e126e7e9, data reload: false -- Round 1 -- q1 17629 439242634263 q2 2011185 187 185 q3 10454 114810161016 q4 10194 832 787 787 q5 7569269428572694 q6 218 135 140 135 q7 979 599 618 599 q8 9203207320662066 q9 8730654165346534 q10 8864379937383738 q11 452 237 239 237 q12 466 225 227 225 q13 18945 297929452945 q14 277 236 237 236 q15 529 481 500 481 q16 501 390 376 376 q17 965 630 737 630 q18 8115754173397339 q19 6255142814751428 q20 682 328 331 328 q21 4867308532313085 q22 401 338 338 338 Total cold run time: 118306 ms Total hot run time: 39665 ms - Round 2, with runtime_filter_mode=off - q1 4360425942324232 q2 366 292 281 281 q3 3005293329012901 q4 2043168616801680 q5 5571558055215521 q6 231 135 132 132 q7 2211191318741874 q8 3263345733983398 q9 8729874687918746 q10 4109381137533753 q11 591 514 491 491 q12 802 632 632 632 q13 16576 315032293150 q14 309 298 285 285 q15 533 496 511 496 q16 497 443 425 425 q17 1817152314821482 q18 8046787679017876 q19 1848165415791579 q20 2983187118841871 q21 9313492745704570 q22 638 562 560 560 Total cold run time: 77841 ms Total hot run time: 55935 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](sleep) sleep with character const make be crash [doris]
doris-robot commented on PR #37681: URL: https://github.com/apache/doris/pull/37681#issuecomment-2225140533 TPC-DS: Total hot run time: 175411 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 62dc29da0f0bb17ccaeee8c25ecda2e77b0e6e92, data reload: false query1 910 376 372 372 query2 6442245223912391 query3 6636210 230 210 query4 28451 17406 17477 17406 query5 3680499 497 497 query6 270 181 154 154 query7 4591289 284 284 query8 310 272 285 272 query9 8586247024432443 query10 435 280 263 263 query11 11304 10089 10095 10089 query12 115 84 80 80 query13 1638363 368 363 query14 9617701879977018 query15 241 180 187 180 query16 7160323 320 320 query17 1659543 537 537 query18 1803273 274 273 query19 190 149 148 148 query20 99 82 84 82 query21 211 127 123 123 query22 4297411239623962 query23 33949 33893 33526 33526 query24 11031 294829052905 query25 581 414 428 414 query26 710 159 152 152 query27 2239278 278 278 query28 6096218721782178 query29 886 671 627 627 query30 262 168 151 151 query31 993 752 742 742 query32 99 54 60 54 query33 706 315 316 315 query34 907 506 506 506 query35 730 609 606 606 query36 1132995 985 985 query37 147 93 90 90 query38 2948291527862786 query39 930 843 848 843 query40 208 126 124 124 query41 54 52 54 52 query42 116 100 99 99 query43 600 534 548 534 query44 1207730 730 730 query45 202 172 168 168 query46 1110721 751 721 query47 1911177617851776 query48 363 313 308 308 query49 850 441 427 427 query50 787 399 400 399 query51 6793690968576857 query52 110 96 102 96 query53 358 286 297 286 query54 921 466 468 466 query55 79 76 74 74 query56 302 290 293 290 query57 1116107810901078 query58 248 279 252 252 query59 3263320431723172 query60 324 301 292 292 query61 123 116 117 116 query62 793 666 644 644 query63 318 307 293 293 query64 9251230975372309 query65 3189311331133113 query66 752 338 351 338 query67 15574 15012 15023 15012 query68 6854557 568 557 query69 721 477 368 368 query70 1162112010761076 query71 500 288 285 285 query72 8319590054425442 query73 767 330 330 330 query74 5924551355365513 query75 4462267726752675 query76 4248993 889 889 query77 786 304 311 304 query78 10044 10095 89798979 query79 8119530 538 530 query80 2705484 485 484 query81 577 225 218 218 query82 670 135 132 132 query83 287 163 204 163 query84 265 86 89 86 query85 1287326 303 303 query86 439 319 302 302 query87 3323316031163116 query88 5109250325532503 query89 509 402 391 391 query90 1940200 195 195 query91 131 107 107 107 query92 66 51 50 50 query93 5850511 512 511 query94 1082215 213 213 query95 421 349 315 315 query96 620 279 271 271 query97 3236299930572999 query98 231 202 194 194 query99 1670125912611259 Total cold run time: 296237 ms Total hot run time: 175411 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th
Re: [PR] [improvement](statistics)Async drop stats while truncating table. [doris]
doris-robot commented on PR #37715: URL: https://github.com/apache/doris/pull/37715#issuecomment-2225141026 ClickBench: Total hot run time: 30.67 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 84cae3e8be9d9caf102b47c581e456947ee28fcf, data reload: false query1 0.040.030.03 query2 0.090.040.04 query3 0.220.040.05 query4 1.690.070.08 query5 0.510.500.49 query6 1.140.720.74 query7 0.020.010.01 query8 0.050.050.04 query9 0.560.510.49 query10 0.560.540.56 query11 0.150.120.12 query12 0.150.120.12 query13 0.590.580.58 query14 0.750.810.77 query15 0.840.810.81 query16 0.360.360.35 query17 0.971.011.02 query18 0.220.220.21 query19 1.791.751.83 query20 0.010.010.01 query21 15.42 0.720.66 query22 4.496.581.75 query23 18.29 1.321.34 query24 2.130.240.23 query25 0.160.080.08 query26 0.290.210.21 query27 0.460.230.23 query28 13.26 1.011.01 query29 12.66 3.373.31 query30 0.260.060.06 query31 2.850.390.40 query32 3.270.460.45 query33 2.892.942.94 query34 16.96 4.354.36 query35 4.434.424.45 query36 0.640.480.47 query37 0.200.150.16 query38 0.170.150.14 query39 0.040.040.04 query40 0.160.120.12 query41 0.090.050.05 query42 0.060.050.05 query43 0.060.040.04 Total cold run time: 109.95 s Total hot run time: 30.67 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](stacktrace) Add conf `enable_stacktrace` [doris]
github-actions[bot] commented on PR #37713: URL: https://github.com/apache/doris/pull/37713#issuecomment-2225148583 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](sleep) sleep with character const make be crash [doris]
doris-robot commented on PR #37681: URL: https://github.com/apache/doris/pull/37681#issuecomment-2225150127 ClickBench: Total hot run time: 31.19 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 62dc29da0f0bb17ccaeee8c25ecda2e77b0e6e92, data reload: false query1 0.040.030.04 query2 0.080.040.04 query3 0.220.050.06 query4 1.660.090.09 query5 0.490.470.50 query6 1.160.720.73 query7 0.020.010.02 query8 0.050.040.04 query9 0.550.500.49 query10 0.560.550.55 query11 0.160.110.11 query12 0.150.120.12 query13 0.580.590.59 query14 0.770.760.78 query15 0.850.810.82 query16 0.360.360.37 query17 0.961.061.04 query18 0.220.210.22 query19 1.811.721.72 query20 0.020.010.01 query21 15.40 0.750.66 query22 4.327.202.37 query23 18.33 1.441.33 query24 2.070.250.22 query25 0.170.080.09 query26 0.300.200.20 query27 0.450.230.23 query28 13.32 1.021.00 query29 12.70 3.313.24 query30 0.250.060.06 query31 2.860.400.39 query32 3.300.490.47 query33 2.912.902.91 query34 17.19 4.384.38 query35 4.444.414.42 query36 0.650.460.49 query37 0.190.160.15 query38 0.150.150.15 query39 0.050.030.04 query40 0.160.120.13 query41 0.100.050.04 query42 0.060.050.05 query43 0.050.030.04 Total cold run time: 110.13 s Total hot run time: 31.19 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bugfix](paimon)Fixed the reading of timestamp with time zone type data [doris]
doris-robot commented on PR #37716: URL: https://github.com/apache/doris/pull/37716#issuecomment-2225158498 TPC-DS: Total hot run time: 174195 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 3ed9eefd57f4506786d406b6228fc313e126e7e9, data reload: false query1 917 374 362 362 query2 6438241423202320 query3 6633208 218 208 query4 28300 17658 17329 17329 query5 3780494 482 482 query6 267 181 155 155 query7 4576297 296 296 query8 305 284 287 284 query9 8446245324362436 query10 451 308 274 274 query11 11433 989010205 9890 query12 116 86 84 84 query13 1635380 380 380 query14 10151 725376097253 query15 242 188 196 188 query16 7734335 333 333 query17 1412566 550 550 query18 1973283 285 283 query19 199 158 158 158 query20 92 80 86 80 query21 213 129 126 126 query22 4348417339743974 query23 33949 33648 34081 33648 query24 10803 302930143014 query25 594 388 382 382 query26 708 155 148 148 query27 2210283 293 283 query28 5716217821742174 query29 875 643 614 614 query30 260 150 154 150 query31 980 793 758 758 query32 101 58 58 58 query33 660 288 295 288 query34 889 498 498 498 query35 701 586 592 586 query36 1132998 964 964 query37 159 90 86 86 query38 2936281428422814 query39 898 815 819 815 query40 197 119 117 117 query41 55 55 55 55 query42 113 98 94 94 query43 568 561 564 561 query44 1089714 712 712 query45 198 164 168 164 query46 1076730 728 728 query47 1874177218101772 query48 363 298 303 298 query49 859 417 412 412 query50 777 401 389 389 query51 7027675066786678 query52 112 91 92 91 query53 346 293 293 293 query54 891 448 473 448 query55 81 78 76 76 query56 296 274 269 269 query57 1115108210631063 query58 240 234 257 234 query59 3233301931463019 query60 305 269 278 269 query61 119 94 123 94 query62 753 649 636 636 query63 310 282 279 279 query64 9127220616431643 query65 3113310930843084 query66 698 328 328 328 query67 15372 14824 14904 14824 query68 4607545 552 545 query69 683 497 361 361 query70 1162112811541128 query71 404 285 279 279 query72 9205546660325466 query73 754 338 330 330 query74 5917555055015501 query75 4139268227102682 query76 2930943 960 943 query77 651 318 327 318 query78 10454 903896219038 query79 3497518 518 518 query80 1668470 469 469 query81 590 220 220 220 query82 768 141 139 139 query83 355 168 171 168 query84 270 91 87 87 query85 1520381 309 309 query86 458 303 308 303 query87 3304316631373137 query88 4593243924102410 query89 488 383 379 379 query90 2014189 189 189 query91 132 102 103 102 query92 57 48 50 48 query93 4979519 511 511 query94 1456217 225 217 query95 409 321 318 318 query96 603 269 275 269 query97 3228306130413041 query98 223 198 201 198 query99 1553125512171217 Total cold run time: 286610 ms Total hot run time: 174195 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
