Re: [PR] [test](case) error format case in test_query_json_object [doris]
github-actions[bot] commented on PR #34722: URL: https://github.com/apache/doris/pull/34722#issuecomment-2106801851 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](case) error format case in test_query_json_object [doris]
github-actions[bot] commented on PR #34722: URL: https://github.com/apache/doris/pull/34722#issuecomment-2106801906 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](prepare) fix datetimev2 return err when binary_row_format [doris]
nextdreamblue commented on PR #34662: URL: https://github.com/apache/doris/pull/34662#issuecomment-2106802368 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature-wip](IO) Replace file writer's finalize function with async close [doris]
doris-robot commented on PR #34679: URL: https://github.com/apache/doris/pull/34679#issuecomment-210680 TeamCity be ut coverage result: Function Coverage: 35.66% (8988/25206) Line Coverage: 27.32% (74294/271930) Region Coverage: 26.55% (38392/144596) Branch Coverage: 23.37% (19583/83788) Coverage Report: http://coverage.selectdb-in.cc/coverage/0178bdb538ded706668b74e75aee8cbe193ae9d5_0178bdb538ded706668b74e75aee8cbe193ae9d5/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](case) insert into select time [doris]
doris-robot commented on PR #34541: URL: https://github.com/apache/doris/pull/34541#issuecomment-2106806625 TPC-H: Total hot run time: 40110 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit b41a5b5cc60fbe20f9b2d9e01e90ececc99442bc, data reload: false -- Round 1 -- q1 17615 441942694269 q2 2012193 187 187 q3 10490 126512831265 q4 10549 801 813 801 q5 7637267927282679 q6 216 133 135 133 q7 1015608 574 574 q8 9322210720902090 q9 9101666066056605 q10 9095369436923692 q11 465 246 240 240 q12 455 209 211 209 q13 17774 296229832962 q14 263 223 228 223 q15 506 475 479 475 q16 510 401 383 383 q17 958 719 698 698 q18 8031757873817381 q19 3312154114641464 q20 641 316 313 313 q21 5036319232103192 q22 349 275 288 275 Total cold run time: 115352 ms Total hot run time: 40110 ms - Round 2, with runtime_filter_mode=off - q1 4385420842204208 q2 385 280 266 266 q3 2972278127132713 q4 1871160216281602 q5 5257533352675267 q6 206 123 123 123 q7 2256190918671867 q8 3185330133543301 q9 8417832983318329 q10 3890366837143668 q11 585 489 506 489 q12 762 584 595 584 q13 16393 294829822948 q14 292 253 278 253 q15 511 483 483 483 q16 468 412 428 412 q17 1766148814771477 q18 7515746974227422 q19 1636156215681562 q20 1929176217801762 q21 4878480047364736 q22 594 481 470 470 Total cold run time: 70153 ms Total hot run time: 53942 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](case) error format case in test_query_json_object [doris]
BiteThet merged PR #34722: URL: https://github.com/apache/doris/pull/34722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [test](case) error format case in test_query_json_object (#34722)
This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 2c3be2f05ee [test](case) error format case in test_query_json_object
(#34722)
2c3be2f05ee is described below
commit 2c3be2f05eef22e18f899376b0d3a1f9c009ae98
Author: Mryange <59914473+mrya...@users.noreply.github.com>
AuthorDate: Mon May 13 15:05:53 2024 +0800
[test](case) error format case in test_query_json_object (#34722)
error format case in test_query_json_object
---
.../query_p0/sql_functions/json_function/test_query_json_object.groovy | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/regression-test/suites/query_p0/sql_functions/json_function/test_query_json_object.groovy
b/regression-test/suites/query_p0/sql_functions/json_function/test_query_json_object.groovy
index e4ebe839276..c3b1e35b5e6 100644
---
a/regression-test/suites/query_p0/sql_functions/json_function/test_query_json_object.groovy
+++
b/regression-test/suites/query_p0/sql_functions/json_function/test_query_json_object.groovy
@@ -43,7 +43,7 @@ suite("test_query_json_object", "query") {
qt_sql1 "select json_object('k0',k0,'k1',k1,'k2',k2,'k3',k3,'k4',k4,'k5',
null,'k6','k6') from ${tableName} order by k0;"
test {
sql """select k0,json_object(k3,123) from ${tableName} order by k0;"""
-exception "[CANCELLED][INTERNAL_ERROR] function json_object can not
input null value , JSON documents may not contain NULL member names."
+exception "function json_object can not input null value , JSON
documents may not contain NULL member names."
}
sql "DROP TABLE ${tableName};"
}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](set) enable admin_set_frontend_config can apply to all fe [doris]
Yulei-Yang commented on PR #34751: URL: https://github.com/apache/doris/pull/34751#issuecomment-2106811809 rerun p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](prepare) fix datetimev2 return err when binary_row_format [doris]
github-actions[bot] commented on PR #34662: URL: https://github.com/apache/doris/pull/34662#issuecomment-2106811190 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](compaction) generate single compaction and cumu(base) compaction tablets simultaneously. [doris]
csun5285 commented on PR #34315: URL: https://github.com/apache/doris/pull/34315#issuecomment-2106814979 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [WIP](test) remove enable_nereids_planner in regression cases (part 4) [doris]
morrySnow merged PR #34642: URL: https://github.com/apache/doris/pull/34642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [WIP](test) remove enable_nereids_planner in regression cases (part 4) (#34642)
This is an automated email from the ASF dual-hosted git repository.
morrysnow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new f2ed0dd8299 [WIP](test) remove enable_nereids_planner in regression
cases (part 4) (#34642)
f2ed0dd8299 is described below
commit f2ed0dd8299c5a9cc48241973d7c0cbca5e1ccfa
Author: morrySnow <101034200+morrys...@users.noreply.github.com>
AuthorDate: Mon May 13 15:12:12 2024 +0800
[WIP](test) remove enable_nereids_planner in regression cases (part 4)
(#34642)
before PR are
#34417
#34490
#34558
---
.../correctness_p0/test_group_having_alias.out | 2 -
.../test_array_functions_array_intersect_sort.out | 110 ++---
.../data/javaudf_p0/test_javaudf_with_decimal.out | 8 +-
.../suites/correctness_p0/test_cast_decimal.groovy | 14 ---
.../correctness_p0/test_group_having_alias.groovy | 20
...est_array_functions_array_intersect_sort.groovy | 97 +++---
...l_tvf_with_complex_type_insertinto_doris.groovy | 1 -
.../tvf/test_tvf_view_count_p2.groovy | 16 +--
.../javaudf_p0/test_javaudf_with_decimal.groovy| 37 +--
...st_array_with_single_row_max_than_uint16.groovy | 1 -
10 files changed, 32 insertions(+), 274 deletions(-)
diff --git a/regression-test/data/correctness_p0/test_group_having_alias.out
b/regression-test/data/correctness_p0/test_group_having_alias.out
index 727040875a7..0b711d92ad6 100644
--- a/regression-test/data/correctness_p0/test_group_having_alias.out
+++ b/regression-test/data/correctness_p0/test_group_having_alias.out
@@ -10,8 +10,6 @@
202245
202245
--- !sql --
-
-- !sql --
202245 3
diff --git
a/regression-test/data/datatype_p0/nested_types/query/array_functions/test_array_functions_array_intersect_sort.out
b/regression-test/data/datatype_p0/nested_types/query/array_functions/test_array_functions_array_intersect_sort.out
index 0127b7b25db..0ede6c3b7a2 100644
---
a/regression-test/data/datatype_p0/nested_types/query/array_functions/test_array_functions_array_intersect_sort.out
+++
b/regression-test/data/datatype_p0/nested_types/query/array_functions/test_array_functions_array_intersect_sort.out
@@ -1,109 +1,43 @@
-- This file is automatically generated. You should know what you did if you
want to edit this
--- !oLd_sql --
+-- !nereid_sql --
array_intersect-array-sort
--- !old_sql --
-[1, 2]
-[1, 2]
-[1]
-[]
-
--- !old_sql --
-[]
-[]
-[]
-[]
-
--- !old_sql --
-[]
-[]
-[]
-[]
-
--- !old_sql --
-[1, 2]
-[1, 2]
-[1]
-[]
-
--- !old_sql --
-[1, 2]
-[1, 2]
-[1, 2]
-[1, 2]
-
--- !old_sql --
-[]
-[]
-[]
-[]
-
--- !old_sql --
+-- !nereid_sql --
[1, 2]
[1, 2]
[1]
[]
--- !old_sql --
+-- !nereid_sql --
[]
[]
[]
[]
--- !old_sql --
+-- !nereid_sql --
[]
[]
[]
[]
--- !old_sql --
+-- !nereid_sql --
[1, 2]
[1, 2]
[1]
[]
--- !old_sql --
+-- !nereid_sql --
[1, 2]
[1, 2]
[1, 2]
[1, 2]
--- !old_sql --
-[]
-[]
-[]
-[]
-
--- !old_sql --
-[]
-
--- !old_sql --
-[]
-
--- !old_sql --
-["a"]
-
--- !old_sql --
+-- !nereid_sql --
[]
-
--- !old_sql --
-[1]
-
--- !old_sql --
[]
-
--- !old_sql --
-[2]
-
--- !old_sql --
[]
-
--- !old_sql --
[]
--- !nereid_sql --
-array_intersect-array-sort
-
-- !nereid_sql --
[1, 2]
[1, 2]
@@ -141,53 +75,29 @@ array_intersect-array-sort
[]
-- !nereid_sql --
-[1, 2]
-[1, 2]
-[1]
[]
-- !nereid_sql --
[]
-[]
-[]
-[]
-- !nereid_sql --
-[]
-[]
-[]
-[]
+["a"]
-- !nereid_sql --
-[1, 2]
-[1, 2]
-[1]
[]
-- !nereid_sql --
-[1, 2]
-[1, 2]
-[1, 2]
-[1, 2]
+[1]
-- !nereid_sql --
[]
-[]
-[]
-[]
-- !nereid_sql --
-[]
+[2]
-- !nereid_sql --
[]
--- !nereid_sql --
-["a"]
-
-- !nereid_sql --
[]
--- !nereid_sql --
-[1]
-
diff --git a/regression-test/data/javaudf_p0/test_javaudf_with_decimal.out
b/regression-test/data/javaudf_p0/test_javaudf_with_decimal.out
index 4a05a63689f..abcbe67e12c 100644
--- a/regression-test/data/javaudf_p0/test_javaudf_with_decimal.out
+++ b/regression-test/data/javaudf_p0/test_javaudf_with_decimal.out
@@ -1,13 +1,9 @@
-- This file is automatically generated. You should know what you did if you
want to edit this
--- !select_1 --
+-- !getarrscale --
[1.123, 1.123] 3
[2.123, 2.123] 3
--- !select_2 --
-{1.123:1.123457} 9
-{2.123:2.123457} 9
-
--- !select_3 --
+-- !retscale --
1 {1.00:1.111000}
2 {2.00:2.222000}
diff --git a/regression-test/suites/correctness_p0/test_cast_decimal.groovy
b/regression-test/suites/correctness_p0/test_cast_decimal.groovy
index 21a1ab6d0c3..ec9a8434c46 100644
--- a/regression-test/suites/correctness_p0/test_cast_decimal.groovy
+++ b/regression-test/suites/correctness_p0/test_cast_decimal.groovy
@@ -16,20 +16,6 @@
// under the License.
suite("test_cast_decimal") {
-sql """
-set enable_nereids_planner=true;
-"""
-
-explain {
-sql """select
Re: [PR] [improvement](spill) fuzzy spill and fix bugs [doris]
doris-robot commented on PR #33291: URL: https://github.com/apache/doris/pull/33291#issuecomment-2106820213 TPC-H: Total hot run time: 41702 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 2af74f643cf1e57c7209fbad3de989f9083cbabb, data reload: false -- Round 1 -- q1 17600 426342134213 q2 2012188 200 188 q3 10448 123412661234 q4 10191 783 785 783 q5 7503271526352635 q6 239 134 129 129 q7 998 610 586 586 q8 9219213420812081 q9 9498670866776677 q10 9209391639063906 q11 434 243 243 243 q12 539 220 228 220 q13 18388 323330653065 q14 261 214 206 206 q15 516 479 464 464 q16 508 405 400 400 q17 974 719 684 684 q18 8401780777277727 q19 4024155915171517 q20 639 318 327 318 q21 5191413041484130 q22 366 296 296 296 Total cold run time: 117158 ms Total hot run time: 41702 ms - Round 2, with runtime_filter_mode=off - q1 4500439343994393 q2 381 284 267 267 q3 3187297027622762 q4 1892159516941595 q5 5499547355155473 q6 208 125 128 125 q7 2304196319631963 q8 3224340434013401 q9 8723872384978497 q10 4006381639083816 q11 609 519 501 501 q12 786 630 627 627 q13 16933 312031133113 q14 284 258 264 258 q15 516 482 460 460 q16 474 428 432 428 q17 1766148514651465 q18 7585769574227422 q19 1649158415801580 q20 1958177717521752 q21 9168473147044704 q22 565 503 495 495 Total cold run time: 76217 ms Total hot run time: 55097 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](multi-table-load) fix be core when partial table load failed [doris]
HHoflittlefish777 commented on PR #34712: URL: https://github.com/apache/doris/pull/34712#issuecomment-2106823112 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](case) insert into select time [doris]
doris-robot commented on PR #34541: URL: https://github.com/apache/doris/pull/34541#issuecomment-2106826224 TPC-DS: Total hot run time: 188045 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit b41a5b5cc60fbe20f9b2d9e01e90ececc99442bc, data reload: false query1 908 373 346 346 query2 6442242523652365 query3 6657215 213 213 query4 24093 21305 21173 21173 query5 4209420 418 418 query6 256 182 172 172 query7 4589289 288 288 query8 245 196 183 183 query9 8609243124352431 query10 453 260 255 255 query11 14756 14173 14294 14173 query12 134 88 87 87 query13 1642366 376 366 query14 9813839084498390 query15 260 167 169 167 query16 8170262 264 262 query17 1865540 536 536 query18 2106277 269 269 query19 273 151 146 146 query20 94 86 83 83 query21 194 130 131 130 query22 5136483148254825 query23 34288 33571 33555 33555 query24 12040 282728832827 query25 641 362 357 357 query26 1731158 158 158 query27 2888319 330 319 query28 7478208520692069 query29 1028652 619 619 query30 292 152 153 152 query31 979 773 784 773 query32 92 53 55 53 query33 760 253 247 247 query34 1015474 478 474 query35 820 690 684 684 query36 1094919 934 919 query37 260 67 69 67 query38 2923278227742774 query39 1637154915531549 query40 278 125 124 124 query41 41 38 39 38 query42 102 95 95 95 query43 592 575 534 534 query44 1211719 734 719 query45 267 240 259 240 query46 1074732 715 715 query47 1967191218691869 query48 382 304 291 291 query49 1194397 395 395 query50 775 401 389 389 query51 6794674866126612 query52 105 86 91 86 query53 348 295 274 274 query54 987 440 440 440 query55 75 71 71 71 query56 239 222 237 222 query57 1256114911841149 query58 221 203 197 197 query59 3388328131693169 query60 254 231 232 231 query61 93 89 90 89 query62 680 485 469 469 query63 310 280 280 280 query64 9768733173487331 query65 3115308330963083 query66 1383344 339 339 query67 15253 15102 15053 15053 query68 4544525 539 525 query69 477 297 302 297 query70 1165112911221122 query71 397 274 269 269 query72 7420257223662366 query73 706 321 326 321 query74 6510615161576151 query75 3327262526342625 query76 2620103510141014 query77 430 258 258 258 query78 10556 10221 10130 10130 query79 1697511 502 502 query80 1071439 426 426 query81 510 216 227 216 query82 117395 92 92 query83 237 161 157 157 query84 236 85 85 85 query85 1260271 312 271 query86 413 291 290 290 query87 3276306231083062 query88 3309243324472433 query89 471 369 382 369 query90 1934189 184 184 query91 123 96 97 96 query92 64 53 47 47 query93 1630505 491 491 query94 1260184 179 179 query95 395 316 293 293 query96 593 273 269 269 query97 3145303230213021 query98 240 215 215 215 query99 1129917 891 891 Total cold run time: 285340 ms Total hot run time: 188045 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
[PR] just test [doris]
hello-stephen opened a new pull request, #34758: URL: https://github.com/apache/doris/pull/34758 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] just test [doris]
doris-robot commented on PR #34758: URL: https://github.com/apache/doris/pull/34758#issuecomment-2106827652 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](pipeline) Refactor blocking dependencies [doris]
Gabriel39 commented on PR #34752: URL: https://github.com/apache/doris/pull/34752#issuecomment-2106828176 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] just test [doris]
hello-stephen commented on PR #34758: URL: https://github.com/apache/doris/pull/34758#issuecomment-2106828319 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](pipeline) Refactor blocking dependencies [doris]
github-actions[bot] commented on code in PR #34752:
URL: https://github.com/apache/doris/pull/34752#discussion_r1597993697
##
be/src/pipeline/pipeline_task.cpp:
##
@@ -197,6 +198,35 @@ void PipelineTask::set_task_queue(TaskQueue* task_queue) {
_task_queue = task_queue;
}
+bool PipelineTask::_is_blocked() {
Review Comment:
warning: method '_is_blocked' can be made const
[readability-make-member-function-const]
```suggestion
bool PipelineTask::_is_blocked() const {
```
be/src/pipeline/pipeline_task.h:245:
```diff
- bool _is_blocked();
+ bool _is_blocked() const;
```
##
be/src/pipeline/pipeline_task.cpp:
##
@@ -197,6 +198,35 @@
_task_queue = task_queue;
}
+bool PipelineTask::_is_blocked() {
+// `_dry_run = true` means we do not need data from source operator.
+if (!_dry_run) {
+for (int i = _read_dependencies.size() - 1; i >= 0; i--) {
+// `_read_dependencies` is organized according to operators. For
each operator, running condition is met iff all dependencies are ready.
+for (auto* dep : _read_dependencies[i]) {
+_blocked_dep = dep->is_blocked_by(this);
+if (_blocked_dep != nullptr) {
+_blocked_dep->start_watcher();
+return true;
+}
+}
+// If all dependencies are ready for this operator, we can execute
this task if no datum is needed from upstream operators.
+if (!_operators[i]->need_more_input_data(_state)) {
+break;
+}
+}
+}
+
+for (auto* op_dep : _write_dependencies) {
+_blocked_dep = op_dep->is_blocked_by(this);
+if (_blocked_dep != nullptr) {
+_blocked_dep->start_watcher();
+return true;
+}
+}
+return false;
+}
+
Status PipelineTask::execute(bool* eos) {
Review Comment:
warning: function 'execute' has cognitive complexity of 58 (threshold 50)
[readability-function-cognitive-complexity]
```cpp
Status PipelineTask::execute(bool* eos) {
^
```
Additional context
**be/src/pipeline/pipeline_task.cpp:234:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (_eos) {
^
```
**be/src/pipeline/pipeline_task.cpp:253:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (has_dependency() || _runtime_filter_blocked_dependency() != nullptr)
{
^
```
**be/src/pipeline/pipeline_task.cpp:253:** +1
```cpp
if (has_dependency() || _runtime_filter_blocked_dependency() != nullptr)
{
^
```
**be/src/pipeline/pipeline_task.cpp:257:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (!_opened) {
^
```
**be/src/pipeline/pipeline_task.cpp:258:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_open());
^
```
**be/src/common/status.h:570:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do {\
^
```
**be/src/pipeline/pipeline_task.cpp:258:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_open());
^
```
**be/src/common/status.h:572:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/pipeline_task.cpp:261:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
while (!_fragment_context->is_canceled()) {
^
```
**be/src/pipeline/pipeline_task.cpp:262:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (_is_blocked()) {
^
```
**be/src/pipeline/pipeline_task.cpp:269:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (_fragment_context->is_canceled()) {
^
```
**be/src/pipeline/pipeline_task.cpp:273:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (time_spent > THREAD_TIME_SLICE) {
^
```
**be/src/pipeline/pipeline_task.cpp:281:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (should_revoke_memory(_state, sink_revocable_mem_size)) {
^
```
**be/src/pipeline/pipeline_task.cpp:282:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_sink->revoke_memory(_state));
^
```
**be/src/common/status.h:570:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do {\
^
```
**be/src/pipeline/pipeline_task.cpp:282:** +4, including nesting penalty of
3, nesting level increased
Re: [PR] [improvement](spill) fuzzy spill and fix bugs [doris]
doris-robot commented on PR #33291: URL: https://github.com/apache/doris/pull/33291#issuecomment-2106840722 TPC-DS: Total hot run time: 187804 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 2af74f643cf1e57c7209fbad3de989f9083cbabb, data reload: false query1 921 361 349 349 query2 6438247724002400 query3 6653215 221 215 query4 24303 21433 21304 21304 query5 4131418 416 416 query6 268 176 175 175 query7 4585292 283 283 query8 246 216 194 194 query9 8659244424402440 query10 443 261 260 260 query11 14950 14250 14285 14250 query12 135 95 87 87 query13 1653384 381 381 query14 10856 815185578151 query15 234 175 181 175 query16 8002271 268 268 query17 1734594 554 554 query18 1952284 281 281 query19 205 153 152 152 query20 97 87 87 87 query21 195 134 133 133 query22 5071479148634791 query23 34020 33528 33553 33528 query24 9876292629512926 query25 555 365 366 365 query26 688 157 151 151 query27 2181323 323 323 query28 5908209320612061 query29 866 625 626 625 query30 228 156 156 156 query31 962 732 738 732 query32 90 52 55 52 query33 638 248 253 248 query34 899 481 491 481 query35 767 665 676 665 query36 1090908 920 908 query37 100 67 64 64 query38 2858279627352735 query39 1628157215531553 query40 199 124 123 123 query41 41 39 37 37 query42 100 96 95 95 query43 585 561 536 536 query44 1065723 731 723 query45 269 248 260 248 query46 1073735 715 715 query47 1961189718971897 query48 380 296 294 294 query49 842 398 398 398 query50 781 388 410 388 query51 6759673366526652 query52 111 90 89 89 query53 348 275 282 275 query54 878 438 423 423 query55 76 74 73 73 query56 248 225 225 225 query57 1218115011421142 query58 212 195 197 195 query59 3383304931073049 query60 258 239 234 234 query61 90 88 90 88 query62 621 472 474 472 query63 312 280 286 280 query64 8435733573627335 query65 3121308330953083 query66 777 341 338 338 query67 15351 14987 14868 14868 query68 5901554 541 541 query69 532 310 315 310 query70 1190112511291125 query71 439 259 268 259 query72 7975253823692369 query73 725 333 330 330 query74 6605607360656065 query75 3498263826102610 query76 32771033993 993 query77 591 266 266 266 query78 10691 10379 10094 10094 query79 2821513 518 513 query80 1233443 436 436 query81 490 216 225 216 query82 735 94 91 91 query83 202 170 165 165 query84 272 92 84 84 query85 1245279 270 270 query86 443 297 300 297 query87 3267312830743074 query88 4470246024502450 query89 481 372 383 372 query90 2058193 189 189 query91 126 95 101 95 query92 59 47 49 47 query93 4169529 505 505 query94 1280184 181 181 query95 395 300 300 300 query96 607 279 277 277 query97 3192298929692969 query98 233 227 212 212 query99 1292912 905 905 Total cold run time: 285073 ms Total hot run time: 187804 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [improvement](inverted index) Disable the use of skipping write index on load [doris]
qidaye merged PR #34719: URL: https://github.com/apache/doris/pull/34719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [improvement](inverted index) Disable the use of skipping write index on load (#34719)
This is an automated email from the ASF dual-hosted git repository.
jianliangqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new ef05e13f888 [improvement](inverted index) Disable the use of skipping
write index on load (#34719)
ef05e13f888 is described below
commit ef05e13f888f68c819e39da8f0f9b4e0a8551701
Author: qiye
AuthorDate: Mon May 13 15:27:51 2024 +0800
[improvement](inverted index) Disable the use of skipping write index on
load (#34719)
When `skip_write_index_on_load` is turned on, users will get an error when
querying for the latest data(not compacted), giving them a bad experience. And
we can use `inverted_index_ram_dir_enable = true` and
`inverted_index_storage_format=V2` to reduce IO and CPU consumption. So we
disable it now.
1. Disable setting `skip_write_index_on_load` to `true` in create table
stmt.
2. Disable setting `skip_write_index_on_load` to `true` in alter table
properties stmt. You can still alter `skip_write_index_on_load` to `false`.
Co-authored-by: Luennng
---
.../java/org/apache/doris/analysis/ModifyTablePropertiesClause.java | 5 +
.../src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java | 3 ++-
.../src/main/java/org/apache/doris/datasource/InternalCatalog.java | 3 +--
regression-test/suites/datatype_p0/scalar_types/load.groovy | 2 +-
4 files changed, 9 insertions(+), 4 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/analysis/ModifyTablePropertiesClause.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/ModifyTablePropertiesClause.java
index e0b0914634b..b6ef97815bc 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/analysis/ModifyTablePropertiesClause.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/analysis/ModifyTablePropertiesClause.java
@@ -240,6 +240,11 @@ public class ModifyTablePropertiesClause extends
AlterTableClause {
this.needTableStable = false;
this.opType = AlterOpType.MODIFY_TABLE_PROPERTY_SYNC;
} else if
(properties.containsKey(PropertyAnalyzer.PROPERTIES_SKIP_WRITE_INDEX_ON_LOAD)) {
+if
(properties.get(PropertyAnalyzer.PROPERTIES_SKIP_WRITE_INDEX_ON_LOAD).equalsIgnoreCase("true"))
{
+throw new AnalysisException(
+"Property "
++ PropertyAnalyzer.PROPERTIES_SKIP_WRITE_INDEX_ON_LOAD + "
is forbidden now");
+}
if
(!properties.get(PropertyAnalyzer.PROPERTIES_SKIP_WRITE_INDEX_ON_LOAD).equalsIgnoreCase("true")
&& !properties.get(PropertyAnalyzer
.PROPERTIES_SKIP_WRITE_INDEX_ON_LOAD).equalsIgnoreCase("false")) {
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java
b/fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java
index 91848292f89..0972018f572 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java
@@ -798,7 +798,8 @@ public class PropertyAnalyzer {
}
properties.remove(PROPERTIES_SKIP_WRITE_INDEX_ON_LOAD);
if (value.equalsIgnoreCase("true")) {
-return true;
+throw new AnalysisException("Property " +
PROPERTIES_SKIP_WRITE_INDEX_ON_LOAD
++ " is forbidden now.");
} else if (value.equalsIgnoreCase("false")) {
return false;
}
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java
b/fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java
index 1f51f1f9c7c..d85d335c45d 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java
@@ -2492,8 +2492,7 @@ public class InternalCatalog implements
CatalogIf {
olapTable.setStoreRowColumn(storeRowColumn);
// set skip inverted index on load
-boolean skipWriteIndexOnLoad =
PropertyAnalyzer.analyzeBooleanProp(properties,
-PropertyAnalyzer.PROPERTIES_SKIP_WRITE_INDEX_ON_LOAD, false);
+boolean skipWriteIndexOnLoad =
PropertyAnalyzer.analyzeSkipWriteIndexOnLoad(properties);
olapTable.setSkipWriteIndexOnLoad(skipWriteIndexOnLoad);
boolean isMutable = PropertyAnalyzer.analyzeBooleanProp(properties,
PropertyAnalyzer.PROPERTIES_MUTABLE, true);
diff --git a/regression-test/suites/datatype_p0/scalar_types/load.groovy
b/regression-test/suites/datatype_p0/scalar_types/load.groovy
index 91cd4eb1f1f..4c7c7ee9366 100644
--- a/regression-test/suites/datatype_p0/scalar_types/load.groovy
+++ b/regression-test/suites/datatype_p0/scalar_types/load.groovy
@@ -448,7 +448,7 @@ suite("test_scalar_types_load
Re: [PR] [ui](profile) Do not do profile format in the FE [doris]
doris-robot commented on PR #34757: URL: https://github.com/apache/doris/pull/34757#issuecomment-2106849311 TPC-H: Total hot run time: 41727 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit d2370a7d63ee30dbb2bdcb89f9661bcc27ab80a0, data reload: false -- Round 1 -- q1 17605 428842564256 q2 2013188 196 188 q3 10454 125512701255 q4 10192 800 724 724 q5 7459274327002700 q6 218 132 130 130 q7 1035610 594 594 q8 9246213120832083 q9 9396668467116684 q10 9145393638663866 q11 453 236 243 236 q12 504 230 222 222 q13 17666 313131663131 q14 272 224 225 224 q15 515 475 485 475 q16 519 406 406 406 q17 991 741 677 677 q18 8264774377017701 q19 7003148314951483 q20 657 319 312 312 q21 5163415141044104 q22 366 276 287 276 Total cold run time: 119136 ms Total hot run time: 41727 ms - Round 2, with runtime_filter_mode=off - q1 4482433944034339 q2 372 278 277 277 q3 3205288328632863 q4 1990169117101691 q5 5372545854915458 q6 218 126 127 126 q7 2403194819131913 q8 3296341934593419 q9 8595872286478647 q10 4055375037673750 q11 577 505 512 505 q12 791 608 624 608 q13 16547 308731933087 q14 313 275 264 264 q15 537 491 475 475 q16 499 447 429 429 q17 1818151814731473 q18 7581762673557355 q19 1685158815611561 q20 1931177317441744 q21 7370472647794726 q22 568 500 489 489 Total cold run time: 74205 ms Total hot run time: 55199 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](user manager) Add rwlock for userManager [doris]
deardeng commented on PR #34699: URL: https://github.com/apache/doris/pull/34699#issuecomment-2106851356 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](join) For left semi/anti join without mark join conjunct and without other conjucnts, stop probing after matching one row [doris]
mrhhsg commented on PR #34703: URL: https://github.com/apache/doris/pull/34703#issuecomment-2106853456 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](prepare) fix datetimev2 return err when binary_row_format [doris]
github-actions[bot] commented on PR #34662: URL: https://github.com/apache/doris/pull/34662#issuecomment-2106858076 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](join) For left semi/anti join without mark join conjunct and without other conjucnts, stop probing after matching one row [doris]
github-actions[bot] commented on PR #34703: URL: https://github.com/apache/doris/pull/34703#issuecomment-2106861328 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](set) enable admin_set_frontend_config can apply to all fe [doris]
Yulei-Yang commented on PR #34751: URL: https://github.com/apache/doris/pull/34751#issuecomment-2106862517 rerun p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](cloud) Add error code to response msg [doris]
w41ter commented on PR #34755: URL: https://github.com/apache/doris/pull/34755#issuecomment-2106863032 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](pipeline) Refactor blocking dependencies [doris]
Gabriel39 commented on PR #34752: URL: https://github.com/apache/doris/pull/34752#issuecomment-2106864857 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[I] [Bug] nereids planner slower than old planner [doris]
kobe6th opened a new issue, #34759: URL: https://github.com/apache/doris/issues/34759 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version 2.1 ### What's Wrong? nereids planner slower than old planner ### What You Expected? fix this issue ### How to Reproduce? ` CREATE TABLE `test_tbl` ( `id` VARCHAR(200) NULL, `create_time` DATETIME NULL, `amount` DECIMAL(21, 10) NULL, `num` VARCHAR(1020) NULL ) ENGINE=OLAP UNIQUE KEY(`id`, `create_time`) COMMENT 'OLAP' DISTRIBUTED BY HASH(`id`) BUCKETS 10 PROPERTIES ( "replication_allocation" = "tag.location.default: 3" ); SELECT count(id) FROM ( SELECT id, sum(amount) AS am, count(DISTINCT num) AS num FROM test_tbl GROUP BY id ) s1 WHERE 1 = 1 AND am >= 10 AND am <= 100 AND num >= 2 AND num <= 1; ` 2000 records in test_tbl with `set enable_nereids_planner=true`, cost 11.40s with `set enable_nereids_planner=false`, cost 4.66s ### Anything Else? _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Fix](Planner) fix date_xxx functions without complete function signature [doris]
LiBinfeng-01 opened a new pull request, #34760: URL: https://github.com/apache/doris/pull/34760 ## Proposed changes Problem: When using current_date as input of functions like date_sub, fold constant would failed cause of missing of function signature in Planner Solved: Add complete function signature of functions like date_sub ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Planner) fix date_xxx functions without complete function signature [doris]
doris-robot commented on PR #34760: URL: https://github.com/apache/doris/pull/34760#issuecomment-2106867321 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](fe) Advance the next id before transfering to master [doris]
w41ter commented on PR #33817: URL: https://github.com/apache/doris/pull/33817#issuecomment-2106867848 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](cloud) Add error code to response msg [doris]
github-actions[bot] commented on PR #34755: URL: https://github.com/apache/doris/pull/34755#issuecomment-2106868903 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [ui](profile) Do not do profile format in the FE [doris]
doris-robot commented on PR #34757: URL: https://github.com/apache/doris/pull/34757#issuecomment-2106869094 TPC-DS: Total hot run time: 187079 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit d2370a7d63ee30dbb2bdcb89f9661bcc27ab80a0, data reload: false query1 924 360 346 346 query2 6433234523372337 query3 6642211 208 208 query4 23208 21304 21243 21243 query5 4167413 424 413 query6 267 170 179 170 query7 4580302 293 293 query8 238 192 181 181 query9 8570243124232423 query10 447 255 252 252 query11 14610 14268 14139 14139 query12 131 92 96 92 query13 1647382 375 375 query14 10605 771576817681 query15 228 174 176 174 query16 7932261 267 261 query17 1713540 534 534 query18 2042268 265 265 query19 201 148 146 146 query20 92 88 84 84 query21 199 123 121 121 query22 5016486948384838 query23 33952 33705 33739 33705 query24 10586 292028622862 query25 578 362 356 356 query26 702 151 154 151 query27 2236318 337 318 query28 5832210220532053 query29 865 609 608 608 query30 249 150 164 150 query31 951 754 763 754 query32 92 52 60 52 query33 635 273 255 255 query34 888 470 482 470 query35 808 667 654 654 query36 1078893 901 893 query37 101 67 64 64 query38 2852278027962780 query39 1612153015951530 query40 214 137 124 124 query41 40 36 37 36 query42 103 96 98 96 query43 573 529 567 529 query44 1048730 735 730 query45 263 253 259 253 query46 1049731 725 725 query47 1951188018481848 query48 385 304 312 304 query49 850 385 388 385 query50 768 391 381 381 query51 6742672867736728 query52 104 86 122 86 query53 345 278 280 278 query54 841 433 437 433 query55 73 73 73 73 query56 246 215 217 215 query57 1196113911511139 query58 223 196 197 196 query59 3374316230783078 query60 253 235 244 235 query61 91 89 85 85 query62 657 453 494 453 query63 312 278 288 278 query64 8475739973407340 query65 3135305131103051 query66 767 352 341 341 query67 15313 14957 14870 14870 query68 4608527 532 527 query69 471 295 300 295 query70 1163112411341124 query71 421 269 307 269 query72 7989257824072407 query73 709 330 337 330 query74 6551601160626011 query75 3460267125822582 query76 2867103010861030 query77 569 264 260 260 query78 10576 10008 10038 10008 query79 2450502 510 502 query80 1004433 424 424 query81 515 216 222 216 query82 129394 91 91 query83 228 164 159 159 query84 251 84 88 84 query85 1502341 314 314 query86 463 325 286 286 query87 3266311830973097 query88 4293244224542442 query89 478 386 390 386 query90 2036191 188 188 query91 133 108 108 108 query92 57 48 52 48 query93 2138505 496 496 query94 1255186 189 186 query95 397 312 310 310 query96 605 273 271 271 query97 3148296829682968 query98 236 224 212 212 query99 1178927 940 927 Total cold run time: 279610 ms Total hot run time: 187079 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th
Re: [PR] [fix](compaction) generate single compaction and cumu(base) compaction tablets simultaneously. [doris]
doris-robot commented on PR #34315: URL: https://github.com/apache/doris/pull/34315#issuecomment-2106870891 TPC-H: Total hot run time: 41946 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit b105c1d1cde4701105fa735aca0e23bb95b68b7b, data reload: false -- Round 1 -- q1 17596 428841924192 q2 2014197 193 193 q3 10469 124811521152 q4 10213 725 824 725 q5 7476272727382727 q6 224 131 141 131 q7 1015607 596 596 q8 9233214621062106 q9 9128676966806680 q10 9347396739433943 q11 454 253 255 253 q12 527 235 236 235 q13 17261 316433433164 q14 257 217 219 217 q15 508 485 472 472 q16 490 411 406 406 q17 1003722 747 722 q18 8342779677237723 q19 3055158414921492 q20 650 332 336 332 q21 5338418441904184 q22 379 304 301 301 Total cold run time: 114979 ms Total hot run time: 41946 ms - Round 2, with runtime_filter_mode=off - q1 4583436344684363 q2 379 265 271 265 q3 3095295127572757 q4 1893165616591656 q5 5534546754785467 q6 217 132 129 129 q7 2337194819731948 q8 3244336233913362 q9 8709874186018601 q10 3917386039273860 q11 595 491 498 491 q12 804 621 615 615 q13 16169 317232073172 q14 302 252 248 248 q15 523 468 471 468 q16 467 420 408 408 q17 1761148214421442 q18 7665775874727472 q19 1659159115421542 q20 1973176617551755 q21 9359486049624860 q22 577 525 502 502 Total cold run time: 75762 ms Total hot run time: 55383 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Planner) fix date_xxx functions without complete function signature [doris]
LiBinfeng-01 commented on PR #34760: URL: https://github.com/apache/doris/pull/34760#issuecomment-2106871618 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](pipeline) Refactor blocking dependencies [doris]
github-actions[bot] commented on code in PR #34752:
URL: https://github.com/apache/doris/pull/34752#discussion_r1598017674
##
be/src/pipeline/pipeline_task.cpp:
##
@@ -197,6 +198,55 @@ void PipelineTask::set_task_queue(TaskQueue* task_queue) {
_task_queue = task_queue;
}
+bool PipelineTask::_wait_to_start() {
+// Before task starting, we should make sure
+// 1. Execution dependency is ready (which is controlled by FE 2-phase
commit)
+// 2. Runtime filter dependencies are ready
+_blocked_dep = _execution_dep->is_blocked_by(this);
+if (_blocked_dep != nullptr) {
+static_cast(_blocked_dep)->start_watcher();
+return true;
+}
+
+for (auto* op_dep : _filter_dependencies) {
+_blocked_dep = op_dep->is_blocked_by(this);
+if (_blocked_dep != nullptr) {
+_blocked_dep->start_watcher();
+return true;
+}
+}
+return false;
+}
+
+bool PipelineTask::_is_blocked() {
Review Comment:
warning: method '_is_blocked' can be made const
[readability-make-member-function-const]
```suggestion
bool PipelineTask::_is_blocked() const {
```
be/src/pipeline/pipeline_task.h:228:
```diff
- bool _is_blocked();
+ bool _is_blocked() const;
```
##
be/src/pipeline/pipeline_task.cpp:
##
@@ -197,6 +198,55 @@
_task_queue = task_queue;
}
+bool PipelineTask::_wait_to_start() {
+// Before task starting, we should make sure
+// 1. Execution dependency is ready (which is controlled by FE 2-phase
commit)
+// 2. Runtime filter dependencies are ready
+_blocked_dep = _execution_dep->is_blocked_by(this);
+if (_blocked_dep != nullptr) {
+static_cast(_blocked_dep)->start_watcher();
+return true;
+}
+
+for (auto* op_dep : _filter_dependencies) {
+_blocked_dep = op_dep->is_blocked_by(this);
+if (_blocked_dep != nullptr) {
+_blocked_dep->start_watcher();
+return true;
+}
+}
+return false;
+}
+
+bool PipelineTask::_is_blocked() {
+// `_dry_run = true` means we do not need data from source operator.
+if (!_dry_run) {
+for (int i = _read_dependencies.size() - 1; i >= 0; i--) {
+// `_read_dependencies` is organized according to operators. For
each operator, running condition is met iff all dependencies are ready.
+for (auto* dep : _read_dependencies[i]) {
+_blocked_dep = dep->is_blocked_by(this);
+if (_blocked_dep != nullptr) {
+_blocked_dep->start_watcher();
+return true;
+}
+}
+// If all dependencies are ready for this operator, we can execute
this task if no datum is needed from upstream operators.
+if (!_operators[i]->need_more_input_data(_state)) {
+break;
+}
+}
+}
+
+for (auto* op_dep : _write_dependencies) {
+_blocked_dep = op_dep->is_blocked_by(this);
+if (_blocked_dep != nullptr) {
+_blocked_dep->start_watcher();
+return true;
+}
+}
+return false;
+}
+
Status PipelineTask::execute(bool* eos) {
Review Comment:
warning: function 'execute' has cognitive complexity of 57 (threshold 50)
[readability-function-cognitive-complexity]
```cpp
Status PipelineTask::execute(bool* eos) {
^
```
Additional context
**be/src/pipeline/pipeline_task.cpp:254:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (_eos) {
^
```
**be/src/pipeline/pipeline_task.cpp:273:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (_wait_to_start()) {
^
```
**be/src/pipeline/pipeline_task.cpp:277:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (!_opened) {
^
```
**be/src/pipeline/pipeline_task.cpp:278:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_open());
^
```
**be/src/common/status.h:570:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do {\
^
```
**be/src/pipeline/pipeline_task.cpp:278:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_open());
^
```
**be/src/common/status.h:572:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/pipeline_task.cpp:281:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
while (!_fragment_context->is_canceled()) {
^
```
**be/src/pipeline/pipeline_task.cpp:282:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (_is_blocked()) {
Re: [PR] [Fix](Planner) fix date_xxx functions without complete function signature [doris]
doris-robot commented on PR #34761: URL: https://github.com/apache/doris/pull/34761#issuecomment-2106874402 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Fix](Planner) fix date_xxx functions without complete function signature [doris]
LiBinfeng-01 opened a new pull request, #34761: URL: https://github.com/apache/doris/pull/34761 ## Proposed changes cherry-pick:#34760 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Planner) fix date_xxx functions without complete function signature [doris]
LiBinfeng-01 commented on PR #34761: URL: https://github.com/apache/doris/pull/34761#issuecomment-2106874481 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](multi-table-load) fix be core when partial table load failed [doris]
doris-robot commented on PR #34712: URL: https://github.com/apache/doris/pull/34712#issuecomment-2106874874 TeamCity be ut coverage result: Function Coverage: 35.65% (8984/25202) Line Coverage: 27.32% (74273/271900) Region Coverage: 26.54% (38375/144599) Branch Coverage: 23.35% (19566/83782) Coverage Report: http://coverage.selectdb-in.cc/coverage/b794fc2b2672734e62e6443b3fd27298e0e99532_b794fc2b2672734e62e6443b3fd27298e0e99532/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](compile) Fix MacOS compile error with conditional variable definition [doris]
zy-kkk opened a new pull request, #34762: URL: https://github.com/apache/doris/pull/34762 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](compile) Fix MacOS compile error with conditional variable definition [doris]
doris-robot commented on PR #34762: URL: https://github.com/apache/doris/pull/34762#issuecomment-2106882796 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](compile) Fix MacOS compile error with conditional variable definition [doris]
zy-kkk commented on PR #34762: URL: https://github.com/apache/doris/pull/34762#issuecomment-2106883955 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](storage-vault) Implement privilege management for storage vault [doris]
platoneko commented on PR #34638: URL: https://github.com/apache/doris/pull/34638#issuecomment-2106884400 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[I] [Bug] web number show wrong with out of max number [doris]
whoamixl opened a new issue, #34763: URL: https://github.com/apache/doris/issues/34763 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version doris-2.0.0-alpha1 ### What's Wrong?  ### What You Expected? show true data ### How to Reproduce? _No response_ ### Anything Else? _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](test) add sync to ensure data synchronization in test_set_operater (#32993) [doris]
LiBinfeng-01 commented on PR #34660: URL: https://github.com/apache/doris/pull/34660#issuecomment-2106885419 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](compile) Fix MacOS compile error with conditional variable definition [doris]
github-actions[bot] commented on PR #34762: URL: https://github.com/apache/doris/pull/34762#issuecomment-210688 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Nereids) ntile function should check argument (#32994) [doris]
LiBinfeng-01 commented on PR #34661: URL: https://github.com/apache/doris/pull/34661#issuecomment-2106885857 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](test) nereids support window function but some cases does not open yet (#33098) [doris]
LiBinfeng-01 commented on PR #34666: URL: https://github.com/apache/doris/pull/34666#issuecomment-2106886304 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Fix](Json type) correct cast result for json type [doris]
eldenmoon opened a new pull request, #34764: URL: https://github.com/apache/doris/pull/34764 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Json type) correct cast result for json type [doris]
doris-robot commented on PR #34764: URL: https://github.com/apache/doris/pull/34764#issuecomment-2106886562 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Json type) correct cast result for json type [doris]
eldenmoon commented on PR #34764: URL: https://github.com/apache/doris/pull/34764#issuecomment-2106886921 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](user manager) Add rwlock for userManager [doris]
deardeng commented on PR #34699: URL: https://github.com/apache/doris/pull/34699#issuecomment-2106888614 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](compile) Fix MacOS compile error with conditional variable definition [doris]
github-actions[bot] commented on PR #34762: URL: https://github.com/apache/doris/pull/34762#issuecomment-2106892778 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](compaction) generate single compaction and cumu(base) compaction tablets simultaneously. [doris]
doris-robot commented on PR #34315: URL: https://github.com/apache/doris/pull/34315#issuecomment-2106890914 TPC-DS: Total hot run time: 187071 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit b105c1d1cde4701105fa735aca0e23bb95b68b7b, data reload: false query1 914 372 349 349 query2 6431226123472261 query3 6640212 209 209 query4 23355 21153 21289 21153 query5 4168412 421 412 query6 278 167 182 167 query7 4593289 291 289 query8 236 182 203 182 query9 8649242724192419 query10 440 251 254 251 query11 14845 14187 14166 14166 query12 133 88 92 88 query13 1645359 371 359 query14 9650846677117711 query15 223 177 169 169 query16 7948277 271 271 query17 1705547 545 545 query18 2054273 274 273 query19 199 148 149 148 query20 89 86 82 82 query21 193 128 126 126 query22 5048482147384738 query23 34062 33431 33454 33431 query24 7663291129062906 query25 572 387 352 352 query26 699 154 154 154 query27 2178319 332 319 query28 5477207520722072 query29 881 609 591 591 query30 226 159 151 151 query31 997 755 737 737 query32 95 50 54 50 query33 536 251 240 240 query34 874 483 483 483 query35 768 685 662 662 query36 1041907 937 907 query37 106 71 66 66 query38 2873279827762776 query39 1604155515481548 query40 197 125 126 125 query41 44 41 41 41 query42 104 94 95 94 query43 563 555 545 545 query44 1068743 734 734 query45 280 252 260 252 query46 1098695 701 695 query47 1977192519121912 query48 383 304 303 303 query49 866 416 405 405 query50 769 385 393 385 query51 6958681968476819 query52 105 89 96 89 query53 358 283 282 282 query54 552 443 450 443 query55 74 73 71 71 query56 248 231 237 231 query57 1238117311491149 query58 221 203 204 203 query59 3492331229652965 query60 260 243 242 242 query61 107 107 109 107 query62 623 478 480 478 query63 305 287 282 282 query64 8505743075077430 query65 3120307731143077 query66 799 349 368 349 query67 15370 14968 14919 14919 query68 4599539 538 538 query69 498 312 315 312 query70 1166116211271127 query71 386 279 267 267 query72 7373267724892489 query73 719 328 329 328 query74 6529610461096104 query75 3308264726112611 query76 2322108910241024 query77 398 264 257 257 query78 10709 10011 10069 10011 query79 3578522 511 511 query80 2072436 434 434 query81 516 215 215 215 query82 774 92 88 88 query83 287 170 162 162 query84 264 115 85 85 query85 1897271 259 259 query86 468 316 310 310 query87 3276315730803080 query88 4778240224302402 query89 492 379 373 373 query90 2062184 186 184 query91 123 96 96 96 query92 57 47 46 46 query93 5347523 509 509 query94 1302179 194 179 query95 393 309 302 302 query96 601 276 266 266 query97 3178299029582958 query98 232 210 209 209 query99 1275914 895 895 Total cold run time: 280751 ms Total hot run time: 187071 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th
Re: [PR] [fix](compaction) generate single compaction and cumu(base) compaction tablets simultaneously. [doris]
github-actions[bot] commented on PR #34315: URL: https://github.com/apache/doris/pull/34315#issuecomment-2106891517 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Json type) correct cast result for json type [doris]
github-actions[bot] commented on PR #34764: URL: https://github.com/apache/doris/pull/34764#issuecomment-2106896512 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](compaction) fix time series compaction merge empty rowsets priority [doris]
doris-robot commented on PR #34765: URL: https://github.com/apache/doris/pull/34765#issuecomment-2106896543 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Improve]delete match_element_xx and add fe config for create inverted index on array [doris]
amorynan opened a new pull request, #34766: URL: https://github.com/apache/doris/pull/34766 ## Proposed changes in this pr: 1. delete match_element_xx grammar for array 2. add a fe config `enable_create_inverted_index_for_array` array type which default is false Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improve]delete match_element_xx and add fe config for create inverted index on array [doris]
doris-robot commented on PR #34766: URL: https://github.com/apache/doris/pull/34766#issuecomment-2106902050 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](block) add check type in block data type and column [doris]
Mryange commented on PR #34314: URL: https://github.com/apache/doris/pull/34314#issuecomment-2106907903 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Cherry-Pick](branch-2.1) Pick "Fix partial update case introduced by #33656 (#34260)" [doris]
doris-robot commented on PR #34767: URL: https://github.com/apache/doris/pull/34767#issuecomment-2106909364 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Cherry-Pick](branch-2.1) Pick "Fix partial update case introduced by #33656 (#34260)" [doris]
Yukang-Lian opened a new pull request, #34767: URL: https://github.com/apache/doris/pull/34767 ## Proposed changes Issue Number: close #xxx Pick #34260 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improve]delete match_element_xx and add fe config for create inverted index on array [doris]
github-actions[bot] commented on PR #34766: URL: https://github.com/apache/doris/pull/34766#issuecomment-2106913676 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](mtmv) Fix table id overturn and optimize get table qualifier method [doris]
seawinde opened a new pull request, #34768: URL: https://github.com/apache/doris/pull/34768 ## Proposed changes Table id may be the same but actually they are different tables. so we optimize the `org.apache.doris.nereids.rules.exploration.mv.mapping.RelationMapping#getTableQualifier` with following code: `Objects.hash(table.getDatabase().getCatalog().getId(), table.getDatabase().getId(), table.getId())` table id is long, we identify the table used in mv rewrite is bitSet. the bitSet can only use int, so we mapping the long id to init id in every query when mv rewrite ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](mtmv) Fix table id overturn and optimize get table qualifier method [doris]
doris-robot commented on PR #34768: URL: https://github.com/apache/doris/pull/34768#issuecomment-2106915966 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improve]delete match_element_xx and add fe config for create inverted index on array [doris]
xiaokang commented on code in PR #34766:
URL: https://github.com/apache/doris/pull/34766#discussion_r1598048402
##
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##
@@ -2694,6 +2694,9 @@ public static boolean isNotCloudMode() {
@ConfField(mutable = true, masterOnly = true)
public static boolean enable_create_bitmap_index_as_inverted_index = false;
+@ConfField(mutable = true)
+public static boolean enable_create_inverted_index_for_array = false;
Review Comment:
If array_contains is OK, keep it true and disable index def with parser
##
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##
@@ -1168,7 +1168,7 @@ nonReserved
| MAP
| MATCH_ALL
| MATCH_ANY
-| MATCH_ELEMENT_EQ
Review Comment:
delete others
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](mtmv) Fix table id overturn and optimize get table qualifier method [doris]
seawinde commented on PR #34768: URL: https://github.com/apache/doris/pull/34768#issuecomment-2106918601 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Planner) fix date_xxx functions without complete function signature [doris]
doris-robot commented on PR #34760: URL: https://github.com/apache/doris/pull/34760#issuecomment-2106920848 TPC-H: Total hot run time: 49695 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 1a6b90c3b7973ed74837d7e533e381dc990db4b3, data reload: false -- Round 1 -- q1 18271 431042934293 q2 2031151 144 144 q3 10449 187219631872 q4 10354 120513371205 q5 8468392239203920 q6 234 123 122 122 q7 2048161015921592 q8 9495272927102710 q9 14251 10506 10674 10506 q10 8644351134953495 q11 405 244 248 244 q12 468 300 305 300 q13 18392 398240253982 q14 347 328 335 328 q15 511 475 464 464 q16 647 578 579 578 q17 1136921 891 891 q18 7346684469006844 q19 1713151415331514 q20 539 305 302 302 q21 4377410439973997 q22 495 396 392 392 Total cold run time: 120621 ms Total hot run time: 49695 ms - Round 2, with runtime_filter_mode=off - q1 4297426743034267 q2 319 219 221 219 q3 4161411140944094 q4 2736272027292720 q5 7140713271407132 q6 237 118 121 118 q7 3209276628032766 q8 432644284428 q9 17418 17082 17178 17082 q10 4225424742374237 q11 761 670 650 650 q12 1045868 864 864 q13 6618378637433743 q14 470 426 431 426 q15 512 465 453 453 q16 733 668 675 668 q17 3757379838173798 q18 8774868488358684 q19 1724169816571657 q20 2372216321342134 q21 8470838083728372 q22 1006937 914 914 Total cold run time: 84310 ms Total hot run time: 79426 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](block) add check type in block data type and column [doris]
github-actions[bot] commented on PR #34314: URL: https://github.com/apache/doris/pull/34314#issuecomment-2106922594 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](compile) Fix MacOS compile error with conditional variable definition [doris]
doris-robot commented on PR #34762: URL: https://github.com/apache/doris/pull/34762#issuecomment-2106922619 TeamCity be ut coverage result: Function Coverage: 35.66% (8986/25202) Line Coverage: 27.32% (74281/271877) Region Coverage: 26.56% (38395/144583) Branch Coverage: 23.37% (19577/83774) Coverage Report: http://coverage.selectdb-in.cc/coverage/f50484b9746cf72b011f21a2cd2589af6f87bae5_f50484b9746cf72b011f21a2cd2589af6f87bae5/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Planner) fix date_xxx functions without complete function signature [doris]
doris-robot commented on PR #34761: URL: https://github.com/apache/doris/pull/34761#issuecomment-2106923640 TPC-H: Total hot run time: 40017 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 6dab5b50e2aad0c07c29930fcedd9b94bdac9d36, data reload: false -- Round 1 -- q1 4785466242404240 q2 417 190 196 190 q3 6061113811831138 q4 1007802 712 712 q5 2639269226632663 q6 219 139 140 139 q7 1021585 708 585 q8 2207216121272127 q9 6571649464936493 q10 3806373137743731 q11 357 241 236 236 q12 377 221 215 215 q13 17785 296329932963 q14 254 224 211 211 q15 523 466 486 466 q16 491 382 376 376 q17 947 636 726 636 q18 7948753374987498 q19 2726155314651465 q20 919 309 307 307 q21 13934 392733443344 q22 354 282 289 282 Total cold run time: 75348 ms Total hot run time: 40017 ms - Round 2, with runtime_filter_mode=off - q1 4227423543434235 q2 374 269 262 262 q3 3006278327592759 q4 1855159516271595 q5 5294527453125274 q6 212 127 126 126 q7 2241190519071905 q8 3221334833593348 q9 8334832983208320 q10 3849368036613661 q11 597 499 488 488 q12 753 610 565 565 q13 3497303629562956 q14 277 259 261 259 q15 517 487 481 481 q16 471 414 413 413 q17 1749150014541454 q18 7559772675387538 q19 1655157615231523 q20 1944178717631763 q21 4939481148364811 q22 586 481 488 481 Total cold run time: 57157 ms Total hot run time: 54217 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](txn insert) Txn load support cloud mode [doris]
github-actions[bot] commented on PR #34721: URL: https://github.com/apache/doris/pull/34721#issuecomment-2106926583 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [feature](iceberg)support iceberg insert for 2.1 [doris]
wuwenchi opened a new pull request, #34769: URL: https://github.com/apache/doris/pull/34769 ## Proposed changes support iceberg insert ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](iceberg)support iceberg insert for 2.1 [doris]
doris-robot commented on PR #34769: URL: https://github.com/apache/doris/pull/34769#issuecomment-2106927560 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improve]delete match_element_xx and add fe config for create inverted index on array [doris]
morrySnow commented on code in PR #34766: URL: https://github.com/apache/doris/pull/34766#discussion_r1598057209 ## fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4: ## @@ -1168,7 +1168,7 @@ nonReserved | MAP | MATCH_ALL | MATCH_ANY -| MATCH_ELEMENT_EQ +| MATCH_columnName Review Comment: what's this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](ui) web profile download use plain text [doris]
Mryange closed pull request #34705: [feature](ui) web profile download use plain text URL: https://github.com/apache/doris/pull/34705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](txn insert) Txn load support cloud mode [doris]
mymeiyi commented on PR #34721: URL: https://github.com/apache/doris/pull/34721#issuecomment-2106931237 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refine](dataque) use lock free queue to impl dataqueue [doris]
Mryange commented on PR #34468: URL: https://github.com/apache/doris/pull/34468#issuecomment-2106932722 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Nereids) ntile function should check argument (#32994) [doris]
doris-robot commented on PR #34661: URL: https://github.com/apache/doris/pull/34661#issuecomment-2106934194 TPC-H: Total hot run time: 49564 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 04d5dceeca8e8f39ee2b944b4e555a83ac074583, data reload: false -- Round 1 -- q1 17871 436243204320 q2 2018150 145 145 q3 10465 190619801906 q4 10341 123513331235 q5 8540388939083889 q6 235 125 122 122 q7 2030159015901590 q8 9258272127052705 q9 10751 10253 10242 10242 q10 8629352335083508 q11 430 237 241 237 q12 480 303 297 297 q13 18342 394340073943 q14 345 328 327 327 q15 511 466 469 466 q16 666 569 570 569 q17 1135975 982 975 q18 7335682868876828 q19 1710153615751536 q20 545 291 304 291 q21 4443412440514051 q22 491 406 382 382 Total cold run time: 116571 ms Total hot run time: 49564 ms - Round 2, with runtime_filter_mode=off - q1 4317430443074304 q2 324 222 226 222 q3 4153414141534141 q4 2777272927552729 q5 7140710471067104 q6 236 116 118 116 q7 3243284128032803 q8 4341446844524452 q9 16824 16681 16718 16681 q10 4259425742954257 q11 765 698 692 692 q12 1044858 859 858 q13 6983372537123712 q14 456 428 419 419 q15 514 466 458 458 q16 739 688 681 681 q17 3915393138123812 q18 8846868988578689 q19 1720169416771677 q20 2381210821222108 q21 8534844883918391 q22 1015911 912 911 Total cold run time: 84526 ms Total hot run time: 79217 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](txn insert) Txn load support cloud mode [doris]
github-actions[bot] commented on PR #34721: URL: https://github.com/apache/doris/pull/34721#issuecomment-2106934352 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](prepare) fix datetimev2 return err when binary_row_format [doris]
nextdreamblue commented on PR #34662: URL: https://github.com/apache/doris/pull/34662#issuecomment-2106935131 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [opt](expr) common expr pushdown supports unique key MoR and agg key table if all slot is key column. [doris]
xinyiZzz opened a new pull request, #26465: URL: https://github.com/apache/doris/pull/26465 ## Proposed changes common expr pushdown in dup key table, unique key MoW table, unique key MoR table and agg key table must satisfy all expr slot is key column. ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](compile) Fix MacOS compile error with conditional variable definition [doris]
doris-robot commented on PR #34762: URL: https://github.com/apache/doris/pull/34762#issuecomment-2106946744 TPC-H: Total hot run time: 41656 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit f50484b9746cf72b011f21a2cd2589af6f87bae5, data reload: false -- Round 1 -- q1 17607 437942724272 q2 2018193 187 187 q3 10457 123513021235 q4 10209 796 856 796 q5 7466274426072607 q6 225 134 132 132 q7 996 609 596 596 q8 9229212221132113 q9 9308672166326632 q10 9353390638663866 q11 452 235 225 225 q12 441 221 227 221 q13 17257 322331833183 q14 272 231 227 227 q15 525 461 476 461 q16 523 398 400 398 q17 990 708 680 680 q18 8283773578317735 q19 6819156314961496 q20 661 317 330 317 q21 5211399541313995 q22 363 289 282 282 Total cold run time: 118665 ms Total hot run time: 41656 ms - Round 2, with runtime_filter_mode=off - q1 4493443643714371 q2 384 277 269 269 q3 3210292228982898 q4 2002167415981598 q5 5390547054925470 q6 216 126 124 124 q7 2317195519321932 q8 3257343834253425 q9 8643865286848652 q10 3915371538563715 q11 602 488 492 488 q12 792 636 620 620 q13 16497 309031173090 q14 309 282 273 273 q15 537 497 475 475 q16 490 443 449 443 q17 1778150114731473 q18 7778755775147514 q19 1640153015591530 q20 1976177217521752 q21 9582491348584858 q22 552 493 491 491 Total cold run time: 76360 ms Total hot run time: 55461 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](prepare) fix datetimev2 return err when binary_row_format [doris]
github-actions[bot] commented on PR #34662: URL: https://github.com/apache/doris/pull/34662#issuecomment-2106947253 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Planner) fix date_xxx functions without complete function signature [doris]
doris-robot commented on PR #34760: URL: https://github.com/apache/doris/pull/34760#issuecomment-2106948185 TPC-DS: Total hot run time: 201865 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 1a6b90c3b7973ed74837d7e533e381dc990db4b3, data reload: false query1 930 388 380 380 query2 6529276724252425 query3 6921211 205 205 query4 21347 17783 17836 17783 query5 19734 653364106410 query6 275 215 226 215 query7 4153303 299 299 query8 250 276 225 225 query9 3124267826212621 query10 413 301 292 292 query11 11322 10564 10705 10564 query12 124 79 71 71 query13 5588672 675 672 query14 17236 13270 13490 13270 query15 358 220 221 220 query16 6452284 257 257 query17 17281438862 862 query18 2337409 402 402 query19 199 155 150 150 query20 76 79 78 78 query21 182 90 95 90 query22 5093500549854985 query23 32467 31931 31694 31694 query24 7018648164916481 query25 519 436 424 424 query26 609 161 160 160 query27 2030293 296 293 query28 6159237123142314 query29 2943271427762714 query30 247 164 167 164 query31 881 729 748 729 query32 68 64 61 61 query33 391 256 236 236 query34 845 484 476 476 query35 1119915 918 915 query36 1241123611861186 query37 88 57 60 57 query38 3045289429252894 query39 1384133713061306 query40 202 97 93 93 query41 38 35 35 35 query42 88 80 83 80 query43 688 692 692 692 query44 1121709 707 707 query45 238 236 229 229 query46 1225983 1000983 query47 1788175216901690 query48 995 712 688 688 query49 639 364 373 364 query50 865 617 634 617 query51 4788470046744674 query52 95 83 91 83 query53 448 315 313 313 query54 2644245424862454 query55 90 78 85 78 query56 224 226 223 223 query57 1083106710411041 query58 192 212 209 209 query59 4105398838633863 query60 216 214 194 194 query61 88 90 111 90 query62 867 446 448 446 query63 474 337 342 337 query64 2495149913891389 query65 3582353135723531 query66 816 361 376 361 query67 15735 15071 15267 15071 query68 9779653 688 653 query69 562 348 350 348 query70 1631166215211521 query71 411 303 302 302 query72 6400340734113407 query73 739 348 326 326 query74 6286588358285828 query75 5317368436653665 query76 6265111911861119 query77 1061255 248 248 query78 12732 11649 13017 11649 query79 11484 654 655 654 query80 1339391 384 384 query81 494 235 229 229 query82 526 99 92 92 query83 189 140 133 133 query84 262 68 71 68 query85 940 299 295 295 query86 344 291 319 291 query87 3260303130023002 query88 5338237123482348 query89 379 270 272 270 query90 2710203 211 203 query91 166 133 134 133 query92 56 51 51 51 query93 3761549 540 540 query94 1300213 214 213 query95 1107106910531053 query96 661 325 341 325 query97 6465638464806384 query98 201 177 172 172 query99 3167844 861 844 Total cold run time: 316586 ms Total hot run time: 201865 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [Fix](Planner) fix date_xxx functions without complete function signature [doris]
doris-robot commented on PR #34761: URL: https://github.com/apache/doris/pull/34761#issuecomment-2106948899 TPC-DS: Total hot run time: 186855 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 6dab5b50e2aad0c07c29930fcedd9b94bdac9d36, data reload: false query1 917 366 347 347 query2 7600229723772297 query3 6645214 211 211 query4 23955 21227 21319 21227 query5 4176417 416 416 query6 279 173 174 173 query7 4583292 285 285 query8 244 188 191 188 query9 8590242824142414 query10 433 241 239 239 query11 14760 14241 14201 14201 query12 134 91 89 89 query13 1659378 373 373 query14 10608 829275347534 query15 251 169 173 169 query16 8175262 250 250 query17 1864564 536 536 query18 2095272 270 270 query19 237 150 151 150 query20 90 85 84 84 query21 189 126 123 123 query22 5071476848824768 query23 34299 33617 33515 33515 query24 10751 301528892889 query25 633 370 359 359 query26 1383155 152 152 query27 2872316 316 316 query28 7612207020652065 query29 878 601 599 599 query30 296 165 151 151 query31 999 758 741 741 query32 94 52 56 52 query33 750 257 246 246 query34 1048481 477 477 query35 798 672 664 664 query36 1068975 938 938 query37 140 70 69 69 query38 2891276127852761 query39 1630156616231566 query40 206 126 130 126 query41 45 41 40 40 query42 105 95 98 95 query43 573 565 567 565 query44 1201722 746 722 query45 267 261 258 258 query46 1124725 718 718 query47 1975187018651865 query48 377 302 301 301 query49 1065398 387 387 query50 763 394 396 394 query51 6810658966076589 query52 103 87 91 87 query53 345 281 276 276 query54 873 430 440 430 query55 74 72 72 72 query56 235 216 221 216 query57 1244113911541139 query58 232 197 203 197 query59 3534317333323173 query60 265 230 236 230 query61 119 91 86 86 query62 692 476 470 470 query63 305 288 281 281 query64 8893736673507350 query65 3110314730653065 query66 945 331 350 331 query67 15357 15000 14891 14891 query68 4737531 528 528 query69 501 311 305 305 query70 1135112211041104 query71 418 265 266 265 query72 7948258523722372 query73 705 328 327 327 query74 6570615560846084 query75 3476263526232623 query76 2874957 972 957 query77 413 274 258 258 query78 10441 10146 10028 10028 query79 2347509 508 508 query80 1178438 440 438 query81 527 217 220 217 query82 955 96 100 96 query83 248 176 176 176 query84 241 94 94 94 query85 1365322 324 322 query86 456 293 309 293 query87 3262310831063106 query88 3526242924372429 query89 476 392 373 373 query90 1960191 186 186 query91 122 96 97 96 query92 63 48 49 48 query93 1962508 490 490 query94 1220180 180 180 query95 390 296 301 296 query96 582 280 273 273 query97 3169304730263026 query98 254 226 218 218 query99 1165881 892 881 Total cold run time: 286220 ms Total hot run time: 186855 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [Fix](Json type) correct cast result for json type [doris]
eldenmoon commented on PR #34764: URL: https://github.com/apache/doris/pull/34764#issuecomment-2106949086 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improve]delete match_element_xx and add fe config for create inverted index on array [doris]
amorynan commented on code in PR #34766: URL: https://github.com/apache/doris/pull/34766#discussion_r1598074818 ## fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4: ## @@ -1168,7 +1168,7 @@ nonReserved | MAP | MATCH_ALL | MATCH_ANY -| MATCH_ELEMENT_EQ +| MATCH_columnName Review Comment: something wrong in last commit for my git action, I will delete -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Planner) fix date_xxx functions without complete function signature [doris]
doris-robot commented on PR #34760: URL: https://github.com/apache/doris/pull/34760#issuecomment-2106959390 ClickBench: Total hot run time: 30.66 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 1a6b90c3b7973ed74837d7e533e381dc990db4b3, data reload: false query1 0.020.020.03 query2 0.080.030.02 query3 0.260.040.05 query4 1.780.060.06 query5 0.530.530.52 query6 1.250.610.62 query7 0.020.010.01 query8 0.020.020.02 query9 0.540.490.49 query10 0.540.520.53 query11 0.120.080.09 query12 0.120.080.08 query13 0.630.620.60 query14 0.780.800.80 query15 0.780.770.76 query16 0.370.370.37 query17 1.030.991.01 query18 0.220.260.25 query19 1.931.841.85 query20 0.020.010.01 query21 15.48 0.560.55 query22 1.992.821.63 query23 17.06 0.991.00 query24 5.860.861.30 query25 0.420.070.07 query26 0.650.160.15 query27 0.040.040.04 query28 7.600.710.71 query29 12.65 2.352.29 query30 0.520.510.52 query31 2.820.380.37 query32 3.400.500.50 query33 3.133.053.03 query34 15.27 4.844.79 query35 4.864.874.85 query36 1.061.001.02 query37 0.060.040.05 query38 0.030.020.02 query39 0.020.010.01 query40 0.150.130.14 query41 0.060.010.02 query42 0.020.010.01 query43 0.020.020.01 Total cold run time: 104.21 s Total hot run time: 30.66 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Json type) correct cast result for json type [doris]
github-actions[bot] commented on PR #34764: URL: https://github.com/apache/doris/pull/34764#issuecomment-2106960259 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Nereids) ntile function should check argument (#32994) [doris]
doris-robot commented on PR #34661: URL: https://github.com/apache/doris/pull/34661#issuecomment-2106960940 TPC-DS: Total hot run time: 203263 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 04d5dceeca8e8f39ee2b944b4e555a83ac074583, data reload: false query1 918 393 383 383 query2 6543293428182818 query3 6913209 206 206 query4 20572 17924 18064 17924 query5 19714 661364516451 query6 285 209 233 209 query7 4161296 306 296 query8 293 263 237 237 query9 3108266526022602 query10 408 318 292 292 query11 11338 10667 10693 10667 query12 119 72 73 72 query13 5586710 673 673 query14 18062 13500 13107 13107 query15 357 233 233 233 query16 6470271 260 260 query17 17141447868 868 query18 2322401 408 401 query19 211 150 152 150 query20 82 77 83 77 query21 191 98 103 98 query22 4997496849494949 query23 32687 31990 32140 31990 query24 6921648065246480 query25 522 410 419 410 query26 526 166 168 166 query27 1835301 295 295 query28 6144235823102310 query29 2894270527592705 query30 241 168 163 163 query31 912 739 754 739 query32 68 64 60 60 query33 401 263 263 263 query34 856 488 479 479 query35 1117935 944 935 query36 1319127110881088 query37 99 58 60 58 query38 3050295429832954 query39 1363132313201320 query40 211 96 94 94 query41 38 36 38 36 query42 88 83 84 83 query43 708 654 714 654 query44 1142710 714 710 query45 243 233 226 226 query46 1225983 976 976 query47 1865169518741695 query48 1017725 707 707 query49 616 370 384 370 query50 849 635 624 624 query51 4843459446874594 query52 94 87 81 81 query53 447 315 327 315 query54 2635246124892461 query55 79 80 84 80 query56 208 185 222 185 query57 1157115511041104 query58 220 213 183 183 query59 4554415738783878 query60 210 222 198 198 query61 91 86 87 86 query62 779 507 471 471 query63 475 344 339 339 query64 2283150214671467 query65 3640353635703536 query66 779 380 381 380 query67 16473 16772 15946 15946 query68 7086631 651 631 query69 573 337 345 337 query70 1437137213071307 query71 403 323 315 315 query72 6461341034213410 query73 748 338 326 326 query74 6283583358615833 query75 4683367637413676 query76 4503113311921133 query77 528 249 242 242 query78 12483 11500 14818 11500 query79 6727645 628 628 query80 1401396 390 390 query81 504 235 227 227 query82 401 100 100 100 query83 162 128 129 128 query84 254 66 71 66 query85 1272296 299 296 query86 354 294 305 294 query87 3231299830282998 query88 4508234723502347 query89 361 290 295 290 query90 1789193 189 189 query91 172 132 147 132 query92 58 55 53 53 query93 954 596 556 556 query94 866 210 207 207 query95 1123106210681062 query96 638 324 328 324 query97 6420642664136413 query98 182 164 168 164 query99 2777984 822 822 Total cold run time: 301630 ms Total hot run time: 203263 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [Fix](Planner) fix date_xxx functions without complete function signature [doris]
doris-robot commented on PR #34760: URL: https://github.com/apache/doris/pull/34760#issuecomment-2106965978 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 1a6b90c3b7973ed74837d7e533e381dc990db4b3 with default session variables Stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s Insert into select: 21.9 seconds inserted 1000 Rows, about 456K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](user manager) Add rwlock for userManager [doris]
doris-robot commented on PR #34699: URL: https://github.com/apache/doris/pull/34699#issuecomment-2106966380 TPC-H: Total hot run time: 41941 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 88fa9ddd061c92d2867570fe5f3f3ab1d9e49dc9, data reload: false -- Round 1 -- q1 17605 429342564256 q2 2009184 186 184 q3 10498 120311761176 q4 10211 783 853 783 q5 7479272727692727 q6 225 133 134 133 q7 1009603 611 603 q8 9237216321112111 q9 9328673467606734 q10 9400389639313896 q11 446 248 230 230 q12 493 232 238 232 q13 17564 325030983098 q14 253 214 224 214 q15 514 483 474 474 q16 499 404 394 394 q17 976 642 713 642 q18 8397778378077783 q19 6337155615601556 q20 657 318 316 316 q21 5337426541184118 q22 361 286 281 281 Total cold run time: 118835 ms Total hot run time: 41941 ms - Round 2, with runtime_filter_mode=off - q1 4530440544634405 q2 392 274 286 274 q3 3154298327692769 q4 1944160417081604 q5 5506552655195519 q6 216 123 126 123 q7 2331201119451945 q8 3246345034073407 q9 8654867283978397 q10 4021390038553855 q11 594 496 478 478 q12 828 648 652 648 q13 16928 316530503050 q14 278 259 259 259 q15 518 472 483 472 q16 472 414 430 414 q17 1768147814901478 q18 7548762275117511 q19 1687153015471530 q20 2008181017981798 q21 5046490249774902 q22 565 502 492 492 Total cold run time: 72234 ms Total hot run time: 55330 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](compile) Fix MacOS compile error with conditional variable definition [doris]
doris-robot commented on PR #34762: URL: https://github.com/apache/doris/pull/34762#issuecomment-2106970126 TPC-DS: Total hot run time: 187314 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit f50484b9746cf72b011f21a2cd2589af6f87bae5, data reload: false query1 917 372 351 351 query2 6443237122372237 query3 6630205 204 204 query4 22747 21308 21102 21102 query5 4206411 413 411 query6 269 176 173 173 query7 4575290 295 290 query8 238 182 201 182 query9 8669244324142414 query10 434 246 258 246 query11 14766 14223 14191 14191 query12 134 91 92 91 query13 1656385 374 374 query14 10644 846383808380 query15 252 170 179 170 query16 8092276 273 273 query17 1720572 562 562 query18 2144275 264 264 query19 191 148 146 146 query20 91 81 88 81 query21 198 124 127 124 query22 5024483948174817 query23 34252 33563 33501 33501 query24 7131283628702836 query25 551 369 364 364 query26 691 161 151 151 query27 2132316 316 316 query28 5359207520652065 query29 847 609 620 609 query30 237 151 154 151 query31 955 764 748 748 query32 93 51 57 51 query33 528 245 244 244 query34 889 486 472 472 query35 753 671 667 667 query36 1056897 895 895 query37 99 68 64 64 query38 2869276227412741 query39 1637157715421542 query40 192 125 120 120 query41 38 37 38 37 query42 101 96 96 96 query43 581 521 547 521 query44 724 744 724 query45 273 253 253 253 query46 1068698 691 691 query47 1982185218911852 query48 370 300 295 295 query49 863 390 419 390 query50 777 390 397 390 query51 6862665366386638 query52 96 89 86 86 query53 350 275 280 275 query54 531 430 441 430 query55 70 73 71 71 query56 238 217 224 217 query57 1204112711491127 query58 213 214 190 190 query59 3424312430433043 query60 252 230 257 230 query61 90 88 86 86 query62 633 480 465 465 query63 314 284 279 279 query64 8537737573417341 query65 3121307930933079 query66 775 337 337 337 query67 15309 14925 14847 14847 query68 4627539 530 530 query69 468 312 301 301 query70 1189114811471147 query71 351 270 279 270 query72 7129252224052405 query73 713 333 320 320 query74 6491615361576153 query75 3290260726262607 query76 2303944 949 944 query77 402 259 260 259 query78 10564 10134 10133 10133 query79 2190508 509 508 query80 985 432 426 426 query81 523 218 220 218 query82 635 92 94 92 query83 234 159 161 159 query84 240 90 82 82 query85 1631268 260 260 query86 521 298 305 298 query87 3295307831533078 query88 4446245124702451 query89 468 387 396 387 query90 2078180 185 180 query91 119 98 101 98 query92 56 48 49 48 query93 2372506 490 490 query94 1210181 193 181 query95 400 336 303 303 query96 595 270 271 270 query97 3137301929912991 query98 250 218 212 212 query99 1193903 910 903 Total cold run time: 273599 ms Total hot run time: 187314 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [Fix](Nereids) ntile function should check argument (#32994) [doris]
doris-robot commented on PR #34661: URL: https://github.com/apache/doris/pull/34661#issuecomment-2106972366 ClickBench: Total hot run time: 30.77 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 04d5dceeca8e8f39ee2b944b4e555a83ac074583, data reload: false query1 0.030.020.02 query2 0.060.030.02 query3 0.240.040.04 query4 1.800.060.06 query5 0.530.520.52 query6 1.230.610.61 query7 0.010.010.02 query8 0.030.020.02 query9 0.520.480.48 query10 0.540.540.54 query11 0.120.080.09 query12 0.120.090.09 query13 0.610.620.61 query14 0.770.790.78 query15 0.770.760.76 query16 0.350.370.35 query17 0.990.981.00 query18 0.230.220.29 query19 1.941.781.84 query20 0.010.000.00 query21 15.51 0.570.54 query22 2.342.411.76 query23 17.23 1.101.12 query24 6.281.320.73 query25 0.420.060.06 query26 0.660.170.15 query27 0.040.040.05 query28 6.850.790.71 query29 12.64 2.382.37 query30 0.540.530.53 query31 2.810.390.38 query32 3.390.490.51 query33 3.073.093.07 query34 15.25 4.804.79 query35 4.824.824.85 query36 1.041.011.03 query37 0.060.050.05 query38 0.040.020.03 query39 0.020.020.01 query40 0.160.140.13 query41 0.060.020.01 query42 0.020.020.01 query43 0.020.020.02 Total cold run time: 104.17 s Total hot run time: 30.77 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
