Re: [PR] [refactor](nereids)unify outputTupleDesc and projection [doris]
github-actions[bot] commented on PR #32093: URL: https://github.com/apache/doris/pull/32093#issuecomment-2005998105 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](parquet) Support hive struct schema change [doris]
suxiaogang223 commented on code in PR #32438:
URL: https://github.com/apache/doris/pull/32438#discussion_r1529826609
##
be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:
##
@@ -728,28 +729,40 @@ Status StructColumnReader::read_column_data(ColumnPtr&
doris_column, DataTypePtr
}
auto& doris_struct = static_cast(*data_column);
-if (_child_readers.size() != doris_struct.tuple_size()) {
-return Status::InternalError("Wrong number of struct fields");
-}
const DataTypeStruct* doris_struct_type =
reinterpret_cast(remove_nullable(type).get());
-for (int i = 0; i < doris_struct.tuple_size(); ++i) {
+
+bool least_one_reader = false;
+size_t least_one_idx = 0;
+std::vector missing_column_idxs {};
+
+for (size_t i = 0; i < doris_struct.tuple_size(); ++i) {
ColumnPtr& doris_field = doris_struct.get_column_ptr(i);
DataTypePtr& doris_type =
const_cast(doris_struct_type->get_element(i));
+String& doris_name =
const_cast(doris_struct_type->get_element_name(i));
Review Comment:
It seems that sql like this is not supported yet:
```sql
select sf.f1 from struct_test;
```
The result is:
```sql
ERROR 1054 (42S22): errCode = 2, detailMessage = Unknown column 'f1' in 'sf'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](fold) fix fold constant core dump with variant type [doris]
zhangstar333 commented on PR #32265: URL: https://github.com/apache/doris/pull/32265#issuecomment-2006000538 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](nereids)unify outputTupleDesc and projection be part [doris]
github-actions[bot] commented on PR #32439: URL: https://github.com/apache/doris/pull/32439#issuecomment-2006004472 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](ParquetReader) Fix Parquet Reader to read `int96` parquet type problem [doris]
doris-robot commented on PR #32394: URL: https://github.com/apache/doris/pull/32394#issuecomment-2006007328 TeamCity be ut coverage result: Function Coverage: 35.24% (8699/24687) Line Coverage: 27.06% (71156/262931) Region Coverage: 26.31% (36910/140274) Branch Coverage: 23.23% (18877/81272) Coverage Report: http://coverage.selectdb-in.cc/coverage/8760b82c0d978534be4485b66c4e94455e068574_8760b82c0d978534be4485b66c4e94455e068574/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] Revert "[fix](merge-cloud) fix no cluster for common user (#32097)" [doris]
hello-stephen opened a new pull request, #32457: URL: https://github.com/apache/doris/pull/32457 This reverts commit 3f4ae002a8cf932dced6166353b7bdbe5b99354f. ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Revert "[fix](merge-cloud) fix no cluster for common user (#32097)" [doris]
doris-robot commented on PR #32457: URL: https://github.com/apache/doris/pull/32457#issuecomment-2006020277 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](random-bucket) random tabletindex when there is no cached value in memory [doris]
dataroaring commented on PR #32336: URL: https://github.com/apache/doris/pull/32336#issuecomment-2006020591 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids) do not transpose semi join agg when mark join [doris]
iwanttobepowerful commented on PR #32296: URL: https://github.com/apache/doris/pull/32296#issuecomment-2006021359 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Revert "[fix](merge-cloud) fix no cluster for common user (#32097)" [doris]
yiguolei merged PR #32457: URL: https://github.com/apache/doris/pull/32457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](runtime-filter) support sync join node build side's size to init bloom runtime filter [doris]
doris-robot commented on PR #32180: URL: https://github.com/apache/doris/pull/32180#issuecomment-2006023815 TeamCity be ut coverage result: Function Coverage: 35.21% (8701/24715) Line Coverage: 27.05% (71176/263154) Region Coverage: 26.30% (36915/140370) Branch Coverage: 23.21% (18880/81344) Coverage Report: http://coverage.selectdb-in.cc/coverage/71927107f90880ff67cae1100edf90c69fc6c992_71927107f90880ff67cae1100edf90c69fc6c992/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: Revert "[fix](merge-cloud) fix no cluster for common user (#32097)" (#32457)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new 115834d1ddd Revert "[fix](merge-cloud) fix no cluster for common user
(#32097)" (#32457)
115834d1ddd is described below
commit 115834d1ddd1abaf4b9f74874d5e4923e1d0aaba
Author: Dongyang Li
AuthorDate: Tue Mar 19 15:06:39 2024 +0800
Revert "[fix](merge-cloud) fix no cluster for common user (#32097)" (#32457)
This reverts commit 3f4ae002a8cf932dced6166353b7bdbe5b99354f.
Co-authored-by: stephen
---
.../tvf/test_insert_from_tvf_with_common_user.groovy | 8
.../suites/load_p0/stream_load/test_stream_load.groovy| 8
2 files changed, 16 deletions(-)
diff --git
a/regression-test/suites/external_table_p0/tvf/test_insert_from_tvf_with_common_user.groovy
b/regression-test/suites/external_table_p0/tvf/test_insert_from_tvf_with_common_user.groovy
index 56cc6aa40c9..1d76ee15f36 100644
---
a/regression-test/suites/external_table_p0/tvf/test_insert_from_tvf_with_common_user.groovy
+++
b/regression-test/suites/external_table_p0/tvf/test_insert_from_tvf_with_common_user.groovy
@@ -88,14 +88,6 @@ suite("test_insert_from_tvf_with_common_user", "p0") {
sql """create user ${common_user} identified by '12345'"""
sql """GRANT SELECT_PRIV,LOAD_PRIV,ALTER_PRIV,CREATE_PRIV,DROP_PRIV ON
*.*.* TO '${common_user}'@'%';"""
- //cloud-mode
-if (isCloudMode()) {
-def clusters = sql " SHOW CLUSTERS; "
-assertTrue(!clusters.isEmpty())
-def validCluster = clusters[0][0]
-sql """GRANT USAGE_PRIV ON CLUSTER ${validCluster} TO
${common_user}""";
-}
-
connect(user = "${common_user}", password = '12345', url =
context.config.jdbcUrl) {
sql """ use regression_test_external_table_p0_tvf """
diff --git a/regression-test/suites/load_p0/stream_load/test_stream_load.groovy
b/regression-test/suites/load_p0/stream_load/test_stream_load.groovy
index 628fe278d52..6c002b2d29b 100644
--- a/regression-test/suites/load_p0/stream_load/test_stream_load.groovy
+++ b/regression-test/suites/load_p0/stream_load/test_stream_load.groovy
@@ -1024,14 +1024,6 @@ suite("test_stream_load", "p0") {
sql """create USER common_user@'%' IDENTIFIED BY '123456test!'"""
sql """GRANT LOAD_PRIV ON *.* TO 'common_user'@'%';"""
- //cloud-mode
-if (isCloudMode()) {
-def clusters = sql " SHOW CLUSTERS; "
-assertTrue(!clusters.isEmpty())
-def validCluster = clusters[0][0]
-sql """GRANT USAGE_PRIV ON CLUSTER ${validCluster} TO common_user""";
-}
-
streamLoad {
table "${tableName13}"
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](Nereids) support make miss slot as null alias when conver anti join (#31854) [doris]
morrySnow merged PR #32417: URL: https://github.com/apache/doris/pull/32417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.0 updated: [feature](Nereids) support make miss slot as null alias when conver anti join (#31854) (#32417)
This is an automated email from the ASF dual-hosted git repository.
morrysnow pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.0 by this push:
new 0cffa4cf5f2 [feature](Nereids) support make miss slot as null alias
when conver anti join (#31854) (#32417)
0cffa4cf5f2 is described below
commit 0cffa4cf5f29ea6c32f348e9a38bd275daeee207
Author: 谢健
AuthorDate: Tue Mar 19 15:06:44 2024 +0800
[feature](Nereids) support make miss slot as null alias when conver anti
join (#31854) (#32417)
pick from master #31854 and #32214
[feature](Nereids) support make miss slot as null alias when converting
anti join (#31854)
transform
project(A.*, B.slot)
- filter(B.slot is null)
- LeftOuterJoin(A, B)
to
project(A.*, null as B.slot)
- LeftAntiJoin(A, B)
[fix](Nereids): don't pushdown project when project contains both side of
join (#32214)
---
.../join/PushdownProjectThroughSemiJoin.java | 19 ++
.../rules/rewrite/ConvertOuterJoinToAntiJoin.java | 76 ++
.../join/PushdownProjectThroughSemiJoinTest.java | 32 +
.../rewrite/ConvertOuterJoinToAntiJoinTest.java| 2 +-
.../transform_outer_join_to_anti.groovy| 20 ++
5 files changed, 105 insertions(+), 44 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/PushdownProjectThroughSemiJoin.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/PushdownProjectThroughSemiJoin.java
index 12199408236..7da6445d698 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/PushdownProjectThroughSemiJoin.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/PushdownProjectThroughSemiJoin.java
@@ -38,6 +38,7 @@ import java.util.stream.Collectors;
/**
* Rule for pushdown project through left-semi/anti join
* Just push down project inside join to avoid to push the top of Join-Cluster.
+ * Note this rule is only used to push down project between join for join
ordering.
*
* Join Join
* ||
@@ -61,6 +62,9 @@ public class PushdownProjectThroughSemiJoin implements
ExplorationRuleFactory {
.whenNot(j -> j.left().child().hasJoinHint())
.then(topJoin -> {
LogicalProject>
project = topJoin.left();
+if (projectBothJoinSide(project)) {
+return null;
+}
Plan newLeft = pushdownProject(project);
return topJoin.withChildren(newLeft, topJoin.right());
}).toRule(RuleType.PUSHDOWN_PROJECT_THROUGH_SEMI_JOIN_LEFT),
@@ -72,12 +76,27 @@ public class PushdownProjectThroughSemiJoin implements
ExplorationRuleFactory {
.whenNot(j -> j.right().child().hasJoinHint())
.then(topJoin -> {
LogicalProject>
project = topJoin.right();
+if (projectBothJoinSide(project)) {
+return null;
+}
Plan newRight = pushdownProject(project);
return topJoin.withChildren(topJoin.left(), newRight);
}).toRule(RuleType.PUSHDOWN_PROJECT_THROUGH_SEMI_JOIN_RIGHT)
);
}
+private boolean projectBothJoinSide(LogicalProject> project) {
+// if project contains both side of join, it can't be pushed.
+// such as:
+// Project(l, null as r)
+// -- L(l) left anti join R(r)
+LogicalJoin join = project.child();
+Set projectOutput = project.getOutputSet();
+boolean containLeft =
join.left().getOutput().stream().anyMatch(projectOutput::contains);
+boolean containRight =
join.right().getOutput().stream().anyMatch(projectOutput::contains);
+return containRight && containLeft;
+}
+
private Plan pushdownProject(LogicalProject> project) {
LogicalJoin join = project.child();
Set conditionLeftSlots = CBOUtils.joinChildConditionSlots(join,
true);
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/ConvertOuterJoinToAntiJoin.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/ConvertOuterJoinToAntiJoin.java
index 74bd7e29142..ff1436252e3 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/ConvertOuterJoinToAntiJoin.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/ConvertOuterJoinToAntiJoin.java
@@ -19,8 +19,10 @@ package org.apache.doris.nereids.rules.rewrite;
import org.apache.doris.nereids.rules.Rule;
import org.apache.doris.nereids.rules.RuleType;
-i
Re: [PR] [refactor](executor)Delete cpu_resource_limit [doris]
github-actions[bot] commented on PR #32388: URL: https://github.com/apache/doris/pull/32388#issuecomment-2006025265 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](like) opt LIKE and REGEXP clause with concat(col, pattern_str) [doris]
BiteThet merged PR #32333: URL: https://github.com/apache/doris/pull/32333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (142ed954098 -> ef03984169c)
This is an automated email from the ASF dual-hosted git repository. panxiaolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 142ed954098 fix routine load regression test fail (#32406) add ef03984169c [opt](like) opt LIKE and REGEXP clause with concat(col, pattern_str) (#32333) No new revisions were added by this update. Summary of changes: be/src/vec/functions/like.cpp | 371 ++--- be/src/vec/functions/like.h| 92 - .../test_like_predicate_with_concat.out| 101 ++ .../test_like_predicate_with_concat.groovy | 112 +++ .../test_string_function_regexp.groovy | 3 +- 5 files changed, 614 insertions(+), 65 deletions(-) create mode 100644 regression-test/data/correctness_p0/test_like_predicate_with_concat.out create mode 100644 regression-test/suites/correctness_p0/test_like_predicate_with_concat.groovy - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Revert "[opt](chinese) chinese tokenizer lowercase interface" [doris-thirdparty]
qidaye merged PR #204: URL: https://github.com/apache/doris-thirdparty/pull/204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-thirdparty) branch clucene updated: Revert "[opt](chinese) chinese tokenizer lowercase interface (#203)" (#204)
This is an automated email from the ASF dual-hosted git repository.
jianliangqi pushed a commit to branch clucene
in repository https://gitbox.apache.org/repos/asf/doris-thirdparty.git
The following commit(s) were added to refs/heads/clucene by this push:
new ff2cd82f9e Revert "[opt](chinese) chinese tokenizer lowercase
interface (#203)" (#204)
ff2cd82f9e is described below
commit ff2cd82f9e545a24318f1256eba312b4d0562a82
Author: qiye
AuthorDate: Tue Mar 19 15:08:03 2024 +0800
Revert "[opt](chinese) chinese tokenizer lowercase interface (#203)" (#204)
This reverts commit cf210eaaadc3ad5d7b27ff2e7b9635ad45cf227b.
---
src/core/CLucene/index/IndexWriter.cpp | 18 +++---
src/core/CLucene/index/IndexWriter.h | 4 ++--
2 files changed, 5 insertions(+), 17 deletions(-)
diff --git a/src/core/CLucene/index/IndexWriter.cpp
b/src/core/CLucene/index/IndexWriter.cpp
index 6b52e047f5..0d770182ba 100644
--- a/src/core/CLucene/index/IndexWriter.cpp
+++ b/src/core/CLucene/index/IndexWriter.cpp
@@ -1255,7 +1255,7 @@ void IndexWriter::resetMergeExceptions() {
void IndexWriter::indexCompaction(std::vector
&src_dirs,
std::vector
dest_dirs,
std::vector>> trans_vec,
- std::vector dest_index_docs, bool
maybe_skip) {
+ std::vector dest_index_docs) {
CND_CONDITION(src_dirs.size() > 0, "Source directory not found.");
CND_CONDITION(dest_dirs.size() > 0, "Destination directory not found.");
this->_trans_vec = std::move(trans_vec);
@@ -1387,7 +1387,7 @@ void
IndexWriter::indexCompaction(std::vector &src_d
}
/// merge terms
-mergeTerms(hasProx, maybe_skip);
+mergeTerms(hasProx);
/// merge null_bitmap
mergeNullBitmap(srcNullBitmapValues, nullBitmapIndexOutputList);
@@ -1613,7 +1613,7 @@ protected:
};
-void IndexWriter::mergeTerms(bool hasProx, bool maybe_skip) {
+void IndexWriter::mergeTerms(bool hasProx) {
auto queue = _CLNEW SegmentMergeQueue(readers.size());
auto numSrcIndexes = readers.size();
//std::vector postingsList(numSrcIndexes);
@@ -1664,18 +1664,6 @@ void IndexWriter::mergeTerms(bool hasProx, bool
maybe_skip) {
top = queue->top();
}
-if (maybe_skip && smallestTerm) {
-auto containsUpperCase = [](const std::wstring_view& ws_term) {
-return std::any_of(ws_term.begin(), ws_term.end(),
- [](wchar_t ch) { return std::iswupper(ch)
!= 0; });
-};
-
-std::wstring_view ws_term(smallestTerm->text(),
smallestTerm->textLength());
-if (containsUpperCase(ws_term)) {
-_CLTHROWA(CL_ERR_InvalidState, "need rewrite, skip index
compaction");
-}
-}
-
std::vector> docDeltaBuffers(numDestIndexes);
std::vector> freqBuffers(numDestIndexes);
auto destPostingQueues = _CLNEW postingQueue(matchSize);
diff --git a/src/core/CLucene/index/IndexWriter.h
b/src/core/CLucene/index/IndexWriter.h
index 0e8d40d8cc..7cfb67d2ca 100644
--- a/src/core/CLucene/index/IndexWriter.h
+++ b/src/core/CLucene/index/IndexWriter.h
@@ -317,14 +317,14 @@ public:
void indexCompaction(std::vector& src_dirs,
std::vector dest_dirs,
std::vector>> trans_vec,
-std::vector dest_index_docs, bool
maybe_skip = false);
+std::vector dest_index_docs);
// create new fields info
void mergeFields(bool hasProx);
// write fields info file
void writeFields(lucene::store::Directory* d, std::string segment);
// merge terms and write files
-void mergeTerms(bool hasProx, bool maybe_skip = false);
+void mergeTerms(bool hasProx);
// merge null_bitmap
void mergeNullBitmap(std::vector> srcBitmapValues,
std::vector nullBitmapIndexOutputList);
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
(doris-thirdparty) branch revert-203-clucene deleted (was b8c1ef4de7)
This is an automated email from the ASF dual-hosted git repository. jianliangqi pushed a change to branch revert-203-clucene in repository https://gitbox.apache.org/repos/asf/doris-thirdparty.git was b8c1ef4de7 Revert "[opt](chinese) chinese tokenizer lowercase interface (#203)" The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](partial-update) Merge transient rowset state to rowset [doris]
platoneko commented on PR #32257: URL: https://github.com/apache/doris/pull/32257#issuecomment-2006030389 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](random-bucket) random tabletindex when there is no cached value in memory [doris]
github-actions[bot] commented on PR #32336: URL: https://github.com/apache/doris/pull/32336#issuecomment-2006035685 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](Nereids): rewrite sum literal to sum and count [doris]
github-actions[bot] commented on PR #32244: URL: https://github.com/apache/doris/pull/32244#issuecomment-2006043532 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](Nereids): rewrite sum literal to sum and count [doris]
github-actions[bot] commented on PR #32244: URL: https://github.com/apache/doris/pull/32244#issuecomment-2006043676 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](smooth-upgrade) Fix right function incompatibility when upgrade from 2.0 to 2.1 [doris]
github-actions[bot] commented on PR #32444: URL: https://github.com/apache/doris/pull/32444#issuecomment-2006046220 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](FS) Improve FS error code [doris]
github-actions[bot] commented on PR #32427: URL: https://github.com/apache/doris/pull/32427#issuecomment-2006052612 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](analysis) sorted partition when do sample analyze [doris]
freemandealer commented on PR #32185: URL: https://github.com/apache/doris/pull/32185#issuecomment-2006057749 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [feature][insert]Adapt the create table statement to the nereids sql [doris]
wsjz opened a new pull request, #32458: URL: https://github.com/apache/doris/pull/32458 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature][insert]Adapt the create table statement to the nereids sql [doris]
doris-robot commented on PR #32458: URL: https://github.com/apache/doris/pull/32458#issuecomment-2006059198 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] Fix unrecognized column name delete handler #32429 [doris]
github-actions[bot] commented on PR #32404: URL: https://github.com/apache/doris/pull/32404#issuecomment-2006061423 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] Fix unrecognized column name delete handler #32429 [doris]
github-actions[bot] commented on PR #32404: URL: https://github.com/apache/doris/pull/32404#issuecomment-2006061499 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](Nereids): rewrite sum literal to sum and count [doris]
XieJiann commented on PR #32244: URL: https://github.com/apache/doris/pull/32244#issuecomment-2006066199 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](analysis) sorted partition when do sample analyze [doris]
freemandealer commented on PR #32185: URL: https://github.com/apache/doris/pull/32185#issuecomment-2006070671 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [pipelineX](api) Add api for long-running tasks [doris]
Gabriel39 opened a new pull request, #32459: URL: https://github.com/apache/doris/pull/32459 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](fold) fix fold constant core dump with variant type [doris]
doris-robot commented on PR #32265: URL: https://github.com/apache/doris/pull/32265#issuecomment-2006071989 TeamCity be ut coverage result: Function Coverage: 35.24% (8700/24687) Line Coverage: 27.07% (71180/262933) Region Coverage: 26.32% (36922/140275) Branch Coverage: 23.23% (18883/81274) Coverage Report: http://coverage.selectdb-in.cc/coverage/f7860b8177d55146f6281e7515b699cae8cc3bae_f7860b8177d55146f6281e7515b699cae8cc3bae/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pipelineX](api) Add api for long-running tasks [doris]
doris-robot commented on PR #32459: URL: https://github.com/apache/doris/pull/32459#issuecomment-2006071561 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pipelineX](api) Add api for long-running tasks [doris]
Gabriel39 commented on PR #32459: URL: https://github.com/apache/doris/pull/32459#issuecomment-2006073566 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] Fix unrecognized column name delete handler #32429 [doris]
dataroaring merged PR #32404: URL: https://github.com/apache/doris/pull/32404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.0 updated: Fix unrecognized column name delete handler (#32404)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.0 by this push:
new d992f08c54a Fix unrecognized column name delete handler (#32404)
d992f08c54a is described below
commit d992f08c54a374ca6027433d52ca416b301f3180
Author: Gavin Chou
AuthorDate: Tue Mar 19 15:26:13 2024 +0800
Fix unrecognized column name delete handler (#32404)
---
be/src/olap/delete_handler.cpp | 77 +++-
be/src/olap/delete_handler.h | 12 +++-
be/test/olap/delete_handler_test.cpp | 40 +++
.../java/org/apache/doris/common/FeNameFormat.java | 4 +-
.../suites/delete_p0/test_delete_handler.groovy| 84 ++
5 files changed, 180 insertions(+), 37 deletions(-)
diff --git a/be/src/olap/delete_handler.cpp b/be/src/olap/delete_handler.cpp
index 4d8385fe9f2..684fdc5c2a5 100644
--- a/be/src/olap/delete_handler.cpp
+++ b/be/src/olap/delete_handler.cpp
@@ -77,6 +77,13 @@ Status DeleteHandler::generate_delete_predicate(const
TabletSchema& schema,
<< "condition size=" << in_pred->values().size();
} else {
string condition_str = construct_sub_predicates(condition);
+if (TCondition tmp;
!DeleteHandler::parse_delete_condition(condition_str, &tmp)) {
+LOG(WARNING) << "failed to parse condition_str, condtion="
+ << ThriftDebugString(condition);
+return Status::Error(
+"failed to parse condition_str, condtion={}",
ThriftDebugString(condition));
+}
+VLOG_NOTICE << __PRETTY_FUNCTION__ << " condition_str: " <<
condition_str;
del_pred->add_sub_predicates(condition_str);
LOG(INFO) << "store one sub-delete condition. condition=" <<
condition_str;
}
@@ -95,8 +102,9 @@ std::string DeleteHandler::construct_sub_predicates(const
TCondition& condition)
}
string condition_str;
if ("IS" == op) {
-condition_str = condition.column_name + " " + op + " " +
condition.condition_values[0];
-} else {
+// ATTN: tricky! Surround IS with spaces to make it "special"
+condition_str = condition.column_name + " IS " +
condition.condition_values[0];
+} else { // multi-elements IN expr has been processed with InPredicatePB
if (op == "*=") {
op = "=";
} else if (op == "!*=") {
@@ -195,43 +203,48 @@ Status DeleteHandler::check_condition_valid(const
TabletSchema& schema, const TC
return Status::OK();
}
-bool DeleteHandler::_parse_condition(const std::string& condition_str,
TCondition* condition) {
-bool matched = true;
+// clang-format off
+// Condition string format, the format is (column_name)(op)(value)
+// eg: condition_str="c1 = 1597751948193618247 and length(source)<1;\n;\n"
+// column_name: matches "c1", must include FeNameFormat.java COLUMN_NAME_REGEX
+// and compactible with any the lagacy
+// operator: matches "="
+// value: matches "1597751948193618247 and length(source)<1;\n;\n"
+//
+// For more info, see DeleteHandler::construct_sub_predicates
+// FIXME(gavin): support unicode. And this is a tricky implementation, it
should
+// not be the final resolution, refactor it.
+const char* const CONDITION_STR_PATTERN =
+// .- column-name .
.--- operator . .
value --.
+
R"(([_a-zA-Z@0-9\s/][.a-zA-Z0-9_+-/?@#$%^&*"\s,:]*)\s*((?:=)|(?:!=)|(?:>>)|(?:<<)|(?:>=)|(?:<=)|(?:\*=)|(?:
IS ))\s*('((?:[\s\S]+)?)'|(?:[\s\S]+)?))";
+// '- group 1 '
'- group 2 ---' | '-- group 4--'
|
+// match any of: =
!= >> << >= <= *= " IS " '--- group 3 -'
+//
match **ANY THING** without(4)
+//
or with(3) single quote
+boost::regex DELETE_HANDLER_REGEX(CONDITION_STR_PATTERN);
+// clang-format on
+
+bool DeleteHandler::parse_delete_condition(const std::string& condition_str,
+ TCondition* condition) {
+bool matched = false;
boost::smatch what;
-
try {
-// Condition string format, the format is (column_name)(op)(value)
-// eg: condition_str="c1 = 1597751948193618247 and
length(source)<1;\n;\n"
-// group1: (\w+) matches "c1"
-// group2: ((?:=)|(?:!=)|(?:>>)|(?:<<)|(?:>
Re: [PR] [enhancement](random-bucket) random tabletindex when there is no cached value in memory [doris]
doris-robot commented on PR #32336: URL: https://github.com/apache/doris/pull/32336#issuecomment-2006085126 TeamCity be ut coverage result: Function Coverage: 35.31% (8728/24716) Line Coverage: 27.13% (71390/263159) Region Coverage: 26.38% (37042/140416) Branch Coverage: 23.28% (18938/81352) Coverage Report: http://coverage.selectdb-in.cc/coverage/8e1328745a2e73684f3ff0ead489d96cf5bc55b3_8e1328745a2e73684f3ff0ead489d96cf5bc55b3/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](function) Support for aggregate function foreach combiner for some error function [doris]
Mryange commented on PR #31913: URL: https://github.com/apache/doris/pull/31913#issuecomment-2006086330 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pipelineX](api) Add api for long-running tasks [doris]
github-actions[bot] commented on PR #32459: URL: https://github.com/apache/doris/pull/32459#issuecomment-2006087863 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids) do not transpose semi join agg when mark join [doris]
iwanttobepowerful commented on PR #32296: URL: https://github.com/apache/doris/pull/32296#issuecomment-2006093838 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](smooth-upgrade) Fix right function incompatibility when upgrade from 2.0 to 2.1 [doris]
zhangstar333 merged PR #32444: URL: https://github.com/apache/doris/pull/32444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [Fix](smooth-upgrade) Fix incompatibility when upgrade from 2.0 to 2.1 (#32444)
This is an automated email from the ASF dual-hosted git repository. zhangstar333 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new a2df10e7867 [Fix](smooth-upgrade) Fix incompatibility when upgrade from 2.0 to 2.1 (#32444) a2df10e7867 is described below commit a2df10e7867a8568fb773065d44c2180dbd65e8f Author: zhangstar333 <87313068+zhangstar...@users.noreply.github.com> AuthorDate: Tue Mar 19 15:31:02 2024 +0800 [Fix](smooth-upgrade) Fix incompatibility when upgrade from 2.0 to 2.1 (#32444) --- be/src/vec/functions/function_string.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/be/src/vec/functions/function_string.h b/be/src/vec/functions/function_string.h index 4dc68eecc83..75d8c8d4997 100644 --- a/be/src/vec/functions/function_string.h +++ b/be/src/vec/functions/function_string.h @@ -948,7 +948,7 @@ public: temp_arguments[0] = arguments[0]; temp_arguments[1] = num_columns_without_result; temp_arguments[2] = num_columns_without_result + 1; -SubstringUtil::substring_execute(block, temp_arguments, result, input_rows_count); +SubstringUtilOld::substring_execute(block, temp_arguments, result, input_rows_count); return Status::OK(); } }; - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [I] [Enhancement] Doc about How to DEBUG using VSCODE? [doris]
AcKing-Sam commented on issue #32423: URL: https://github.com/apache/doris/issues/32423#issuecomment-2006101703 @koarz Thanks again for your help! I used my local machine with LLDB's `attach` mode and it can debug successfully! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](agg) streaming agg should not take too much memory when spilling enabled [doris]
mrhhsg commented on PR #32426: URL: https://github.com/apache/doris/pull/32426#issuecomment-2006102006 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](agg) streaming agg should not take too much memory when spilling enabled [doris]
github-actions[bot] commented on PR #32426: URL: https://github.com/apache/doris/pull/32426#issuecomment-2006102252 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](hdfs) check the connectivity of hdfs resources [doris]
felixwluo commented on PR #32416: URL: https://github.com/apache/doris/pull/32416#issuecomment-2006104365 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [I] [Enhancement] Doc about How to DEBUG using VSCODE? [doris]
AcKing-Sam commented on issue #32423: URL: https://github.com/apache/doris/issues/32423#issuecomment-2006105125 For this issue, it seems that the doc mentioned the machine request is at least ***10c16g*** to run debugger successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](schema-change) fix the bug of handling empty blocks in schema change [doris]
luwei16 opened a new pull request, #32460: URL: https://github.com/apache/doris/pull/32460 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](schema-change) fix the bug of handling empty blocks in schema change [doris]
doris-robot commented on PR #32460: URL: https://github.com/apache/doris/pull/32460#issuecomment-2006106218 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](schema-change) fix the bug of handling empty blocks in schema change [doris]
luwei16 commented on PR #32460: URL: https://github.com/apache/doris/pull/32460#issuecomment-2006106912 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](agg) streaming agg should not take too much memory when spilling enabled [doris]
github-actions[bot] commented on PR #32426: URL: https://github.com/apache/doris/pull/32426#issuecomment-2006111097 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](schema-change) fix the bug of handling empty blocks in schema change [doris]
github-actions[bot] commented on PR #32396: URL: https://github.com/apache/doris/pull/32396#issuecomment-2006111660 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](schema-change) fix the bug of handling empty blocks in schema change [doris]
luwei16 opened a new pull request, #32461: URL: https://github.com/apache/doris/pull/32461 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](schema-change) fix the bug of handling empty blocks in schema change [doris]
doris-robot commented on PR #32461: URL: https://github.com/apache/doris/pull/32461#issuecomment-2006112394 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [regression](framework) add config caseNamePrefix (#32266) [doris]
hello-stephen opened a new pull request, #32462: URL: https://github.com/apache/doris/pull/32462 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](schema-change) fix the bug of handling empty blocks in schema change [doris]
luwei16 commented on PR #32461: URL: https://github.com/apache/doris/pull/32461#issuecomment-2006119689 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression](framework) add config caseNamePrefix (#32266) [doris]
doris-robot commented on PR #32462: URL: https://github.com/apache/doris/pull/32462#issuecomment-2006120078 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression](framework) add config caseNamePrefix (#32266) [doris]
hello-stephen commented on PR #32462: URL: https://github.com/apache/doris/pull/32462#issuecomment-2006120277 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](schema-change) fix the bug of handling empty blocks in schema change [doris]
luwei16 commented on PR #32396: URL: https://github.com/apache/doris/pull/32396#issuecomment-2006121573 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](schema-change) fix the bug of handling empty blocks in schema change [doris]
luwei16 commented on PR #32460: URL: https://github.com/apache/doris/pull/32460#issuecomment-2006120497 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](invert index) use lowercase by default [doris]
zzzxl1993 commented on PR #32405: URL: https://github.com/apache/doris/pull/32405#issuecomment-2006122163 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](schema-change) fix the bug of handling empty blocks in schema change [doris]
github-actions[bot] commented on PR #32460: URL: https://github.com/apache/doris/pull/32460#issuecomment-2006124001 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [feat](Nereids): add is null predicate for the first partition when updating mv by partition [doris]
XieJiann opened a new pull request, #32463: URL: https://github.com/apache/doris/pull/32463 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](Nereids): add is null predicate for the first partition when updating mv by partition [doris]
doris-robot commented on PR #32463: URL: https://github.com/apache/doris/pull/32463#issuecomment-2006132806 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Nereids) fix leading syntax problems and data mismatched problem [doris]
LiBinfeng-01 commented on PR #32382: URL: https://github.com/apache/doris/pull/32382#issuecomment-2006133882 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](schema-change) fix the bug of handling empty blocks in schema change [doris]
github-actions[bot] commented on PR #32461: URL: https://github.com/apache/doris/pull/32461#issuecomment-2006136443 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pipelineX](api) Add api for long-running tasks [doris]
doris-robot commented on PR #32459: URL: https://github.com/apache/doris/pull/32459#issuecomment-2006140626 TeamCity be ut coverage result: Function Coverage: 35.30% (8726/24719) Line Coverage: 27.12% (71379/263184) Region Coverage: 26.38% (37044/140425) Branch Coverage: 23.27% (18935/81354) Coverage Report: http://coverage.selectdb-in.cc/coverage/bba0d2e8701c303d2983a8bc4a821d58d8422edd_bba0d2e8701c303d2983a8bc4a821d58d8422edd/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](schema-change) fix the bug of handling empty blocks in schema change [doris]
github-actions[bot] commented on PR #32460: URL: https://github.com/apache/doris/pull/32460#issuecomment-2006156974 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](group commit) Fix compatibility issues on serializing and deserializing wal file [doris]
hust-hhb commented on PR #32299: URL: https://github.com/apache/doris/pull/32299#issuecomment-2006162342 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](spill) optimize the spilling logic of hash join operator [doris]
yiguolei commented on PR #32202: URL: https://github.com/apache/doris/pull/32202#issuecomment-2006165587 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Job)When jobname is the do keyword, parsing errors will occur when executing SQL. [doris]
CalvinKirs commented on PR #32379: URL: https://github.com/apache/doris/pull/32379#issuecomment-2006167100 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](function) Support for aggregate function foreach combiner for some error function [doris]
doris-robot commented on PR #31913: URL: https://github.com/apache/doris/pull/31913#issuecomment-2006170204 TeamCity be ut coverage result: Function Coverage: 35.30% (8728/24726) Line Coverage: 27.12% (71390/263278) Region Coverage: 26.37% (37047/140472) Branch Coverage: 23.27% (18936/81388) Coverage Report: http://coverage.selectdb-in.cc/coverage/c48d721aa70dfcbd6550d1fd06617e3ddac5f3ef_c48d721aa70dfcbd6550d1fd06617e3ddac5f3ef/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](group commit) Fix compatibility issues on serializing and deserializing wal file [doris]
github-actions[bot] commented on code in PR #32299:
URL: https://github.com/apache/doris/pull/32299#discussion_r1529886785
##
be/src/olap/wal/wal_writer.cpp:
##
@@ -90,7 +90,7 @@ Status WalWriter::append_blocks(const PBlockArray& blocks) {
return Status::OK();
}
-Status WalWriter::append_header(uint32_t version, std::string col_ids) {
+Status WalWriter::append_header(std::string col_ids) {
Review Comment:
warning: method 'append_header' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status WalWriter::append_header(std::string col_ids) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [improve](doriswriter)doris writer compatible with copy into [doris]
caoliang-web opened a new pull request, #32464: URL: https://github.com/apache/doris/pull/32464 1. doris writer compatible with copy into ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](doriswriter)doris writer compatible with copy into [doris]
doris-robot commented on PR #32464: URL: https://github.com/apache/doris/pull/32464#issuecomment-2006188413 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](partial-update) Fix wrong rowset state in partial update [doris]
platoneko commented on PR #32257: URL: https://github.com/apache/doris/pull/32257#issuecomment-2006191850 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](insert)fix sink user name [doris]
wsjz opened a new pull request, #32465: URL: https://github.com/apache/doris/pull/32465 ## Proposed changes fix sink user name ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](insert)fix sink user name [doris]
doris-robot commented on PR #32465: URL: https://github.com/apache/doris/pull/32465#issuecomment-2006198868 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](partial-update) Fix wrong rowset state in partial update [doris]
github-actions[bot] commented on PR #32257: URL: https://github.com/apache/doris/pull/32257#issuecomment-2006201199 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [case](mtmv)MTMV external catalog case [doris]
zddr commented on PR #32390: URL: https://github.com/apache/doris/pull/32390#issuecomment-2006203414 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](partial-update) Fix wrong rowset state in partial update [doris]
platoneko commented on PR #32257: URL: https://github.com/apache/doris/pull/32257#issuecomment-2006203813 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](schema-change) fix the bug of handling empty blocks in schema change [doris]
doris-robot commented on PR #32460: URL: https://github.com/apache/doris/pull/32460#issuecomment-2006204100 TeamCity be ut coverage result: Function Coverage: 35.31% (8727/24716) Line Coverage: 27.12% (71371/263167) Region Coverage: 26.39% (37055/140422) Branch Coverage: 23.28% (18941/81356) Coverage Report: http://coverage.selectdb-in.cc/coverage/866c2d6ec986b69d189fd993e4e38e1acacb7569_866c2d6ec986b69d189fd993e4e38e1acacb7569/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: [fix](insert)fix sink user name (#32465)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new fc2588c7866 [fix](insert)fix sink user name (#32465)
fc2588c7866 is described below
commit fc2588c7866fdcae2414546d1b76f6b3f03ac070
Author: slothever <18522955+w...@users.noreply.github.com>
AuthorDate: Tue Mar 19 16:04:09 2024 +0800
[fix](insert)fix sink user name (#32465)
---
fe/fe-core/src/main/java/org/apache/doris/planner/HiveTableSink.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/planner/HiveTableSink.java
b/fe/fe-core/src/main/java/org/apache/doris/planner/HiveTableSink.java
index 5dce86b3330..4652c132a9e 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/planner/HiveTableSink.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/planner/HiveTableSink.java
@@ -152,7 +152,7 @@ public class HiveTableSink extends DataSink {
}
private String createTempPath(String location) {
-String user = ConnectContext.get().getUserIdentity().getUser();
+String user =
ConnectContext.get().getUserIdentity().getQualifiedUser();
return location + "/.doris_staging/" + user + "/" +
UUID.randomUUID().toString().replace("-", "");
}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](insert)fix sink user name [doris]
yiguolei merged PR #32465: URL: https://github.com/apache/doris/pull/32465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [improvement] update clone hint [doris]
yujun777 opened a new pull request, #32466: URL: https://github.com/apache/doris/pull/32466 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement] update clone hint [doris]
doris-robot commented on PR #32466: URL: https://github.com/apache/doris/pull/32466#issuecomment-2006210258 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [disable feature](show profile) Disable show query/load profile stmt [doris]
zhiqiang- opened a new pull request, #32467: URL: https://github.com/apache/doris/pull/32467 show query/load profile from terminal is actually not a well maintained feature, and our execution model changed a lot in 2.1 which introduced new execution engine, it will cost much to keep show profile stmt work with new execution engine. So, we disable it, and user will get a prompt to guide them get profile from web browser like bellow ```sql show load profile "/512b998305c3455d-9e8ea49e520486a6" -- ERROR 1105 (HY000): errCode = 2, detailMessage = try visit http://127.0.0.1:5937/QueryProfile//512b998305c3455d-9e8ea49e520486a6, show query/load profile syntax is a deprecated feature ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [disable feature](show profile) Disable show query/load profile stmt [doris]
doris-robot commented on PR #32467: URL: https://github.com/apache/doris/pull/32467#issuecomment-200627 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement] update clone hint [doris]
yujun777 commented on PR #32466: URL: https://github.com/apache/doris/pull/32466#issuecomment-2006212159 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix][regression]update ccr test project [doris]
XuJianxu commented on PR #32445: URL: https://github.com/apache/doris/pull/32445#issuecomment-2006212858 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](analysis) sorted partition when do sample analyze [doris]
freemandealer commented on PR #32185: URL: https://github.com/apache/doris/pull/32185#issuecomment-2006213459 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](hive)Get updated information from coordinate and commit [doris]
wuwenchi commented on PR #32441: URL: https://github.com/apache/doris/pull/32441#issuecomment-2006215058 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](schema-change) fix the bug of handling empty blocks in schema change [doris]
doris-robot commented on PR #32461: URL: https://github.com/apache/doris/pull/32461#issuecomment-2006216814 TeamCity be ut coverage result: Function Coverage: 37.80% (8038/21265) Line Coverage: 29.46% (65580/222619) Region Coverage: 28.93% (33746/116643) Branch Coverage: 24.78% (17321/69904) Coverage Report: http://coverage.selectdb-in.cc/coverage/6a8f73cd5e5f82e247fa33aed13c988a33b9dc47_6a8f73cd5e5f82e247fa33aed13c988a33b9dc47/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](partial-update) Fix wrong rowset state in partial update [doris]
github-actions[bot] commented on PR #32257: URL: https://github.com/apache/doris/pull/32257#issuecomment-2006221192 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement] update clone hint [doris]
github-actions[bot] commented on PR #32466: URL: https://github.com/apache/doris/pull/32466#issuecomment-2006222067 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix][regression]update ccr test project [doris]
XuJianxu commented on PR #32445: URL: https://github.com/apache/doris/pull/32445#issuecomment-2006227059 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix][regression]update ccr test project [doris]
github-actions[bot] commented on PR #32445: URL: https://github.com/apache/doris/pull/32445#issuecomment-2006230075 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
