Re: [PR] [feature](pipelineX) avoid using blocked queue in sink [doris]
Mryange commented on PR #26247: URL: https://github.com/apache/doris/pull/26247#issuecomment-1793657047 run pipelinex_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](profile) remove unused code in profile [doris]
Mryange commented on PR #26404: URL: https://github.com/apache/doris/pull/26404#issuecomment-1793657562 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [feature](pipelineX) add last blocked dep in source can read [doris]
Mryange opened a new pull request, #26431: URL: https://github.com/apache/doris/pull/26431 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) add last blocked dep in source can read [doris]
Mryange commented on PR #26431: URL: https://github.com/apache/doris/pull/26431#issuecomment-1793659025 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) add last blocked dep in source can read [doris]
github-actions[bot] commented on PR #26431: URL: https://github.com/apache/doris/pull/26431#issuecomment-1793660227 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](workflow) Fix failure test cases in BE UT (macOS) [doris]
adonis0147 commented on PR #26425: URL: https://github.com/apache/doris/pull/26425#issuecomment-1793661068 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) add last blocked dep in source can read [doris]
doris-robot commented on PR #26431: URL: https://github.com/apache/doris/pull/26431#issuecomment-1793662752 TeamCity be ut coverage result: Function Coverage: 37.30% (8454/22667) Line Coverage: 29.68% (68460/230637) Region Coverage: 28.35% (35429/124979) Branch Coverage: 25.09% (18083/72084) Coverage Report: http://coverage.selectdb-in.cc/coverage/5dd34de57961c7a1228aaccd24a707d583e5b1ef_5dd34de57961c7a1228aaccd24a707d583e5b1ef/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) avoid using blocked queue in sink/filter/finish [doris]
Mryange commented on PR #26393: URL: https://github.com/apache/doris/pull/26393#issuecomment-1793665010 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore] Print FE version even if it has been started [doris]
github-actions[bot] commented on PR #26427: URL: https://github.com/apache/doris/pull/26427#issuecomment-1793665474 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](workflow) Fix failure test cases in BE UT (macOS) [doris]
doris-robot commented on PR #26425: URL: https://github.com/apache/doris/pull/26425#issuecomment-1793666106 TeamCity be ut coverage result: Function Coverage: 36.99% (8384/22666) Line Coverage: 29.43% (67864/230628) Region Coverage: 28.11% (35133/124975) Branch Coverage: 24.90% (17950/72080) Coverage Report: http://coverage.selectdb-in.cc/coverage/4e810a9da4fc522b3969cd1b73fbf4630172502c_4e810a9da4fc522b3969cd1b73fbf4630172502c/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) avoid using blocked queue in sink/filter/finish [doris]
github-actions[bot] commented on code in PR #26393:
URL: https://github.com/apache/doris/pull/26393#discussion_r1382526172
##
be/src/pipeline/pipeline_x/dependency.cpp:
##
@@ -294,6 +315,18 @@ std::vector
HashJoinDependency::convert_block_to_null(vectorized::Bloc
return results;
}
+void SetSharedState::set_probe_finished_children(int child_id) {
Review Comment:
warning: method 'set_probe_finished_children' can be made static
[readability-convert-member-functions-to-static]
be/src/pipeline/pipeline_x/dependency.h:782:
```diff
- void set_probe_finished_children(int child_id);
+ static void set_probe_finished_children(int child_id);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) add last blocked dep in source can read [doris]
doris-robot commented on PR #26431: URL: https://github.com/apache/doris/pull/26431#issuecomment-1793666918 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.43 seconds stream load tsv: 552 seconds loaded 74807831229 Bytes, about 129 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 29.0 seconds inserted 1000 Rows, about 344K ops/s storage size: 17162262819 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](flush) enlarge memtable flush thread num and lower the loading soft mem limit [doris]
TangSiyang2001 commented on PR #26429: URL: https://github.com/apache/doris/pull/26429#issuecomment-1793666963 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](flush) enlarge memtable flush thread num and lower the loading soft mem limit [doris]
github-actions[bot] commented on PR #26429: URL: https://github.com/apache/doris/pull/26429#issuecomment-1793668645 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](workflow) Fix failure test cases in BE UT (macOS) [doris]
doris-robot commented on PR #26425: URL: https://github.com/apache/doris/pull/26425#issuecomment-1793669347 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.34 seconds stream load tsv: 551 seconds loaded 74807831229 Bytes, about 129 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 29.0 seconds inserted 1000 Rows, about 344K ops/s storage size: 1716218 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](flush) enlarge memtable flush thread num and lower the loading soft mem limit [doris]
doris-robot commented on PR #26429: URL: https://github.com/apache/doris/pull/26429#issuecomment-1793670666 TeamCity be ut coverage result: Function Coverage: 37.30% (8454/22666) Line Coverage: 29.69% (68468/230628) Region Coverage: 28.35% (35433/124975) Branch Coverage: 25.09% (18084/72080) Coverage Report: http://coverage.selectdb-in.cc/coverage/c310182cc4fa8c0d2994643769c1e421a5b2238f_c310182cc4fa8c0d2994643769c1e421a5b2238f/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) avoid using blocked queue in sink/filter/finish [doris]
doris-robot commented on PR #26393: URL: https://github.com/apache/doris/pull/26393#issuecomment-1793670908 TeamCity be ut coverage result: Function Coverage: 37.28% (8452/22673) Line Coverage: 29.66% (68440/230715) Region Coverage: 28.33% (35413/125016) Branch Coverage: 25.06% (18073/72108) Coverage Report: http://coverage.selectdb-in.cc/coverage/b3555bedbfc5b94e5c906e05a576d92109509b87_b3555bedbfc5b94e5c906e05a576d92109509b87/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](workflow) Fix failure test cases in BE UT (macOS) [doris]
adonis0147 commented on PR #26425: URL: https://github.com/apache/doris/pull/26425#issuecomment-1793672169 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) add last blocked dep in source can read [doris]
Mryange commented on PR #26431: URL: https://github.com/apache/doris/pull/26431#issuecomment-1793672929 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](flush) enlarge memtable flush thread num and lower the loading soft mem limit [doris]
doris-robot commented on PR #26429: URL: https://github.com/apache/doris/pull/26429#issuecomment-1793673520 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.73 seconds stream load tsv: 573 seconds loaded 74807831229 Bytes, about 124 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s insert into select: 29.9 seconds inserted 1000 Rows, about 334K ops/s storage size: 17163851963 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) add last blocked dep in source can read [doris]
github-actions[bot] commented on PR #26431: URL: https://github.com/apache/doris/pull/26431#issuecomment-1793674494 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) avoid using blocked queue in sink/filter/finish [doris]
doris-robot commented on PR #26393: URL: https://github.com/apache/doris/pull/26393#issuecomment-1793677268 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.4 seconds stream load tsv: 575 seconds loaded 74807831229 Bytes, about 124 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s insert into select: 28.7 seconds inserted 1000 Rows, about 348K ops/s storage size: 17162187726 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) add last blocked dep in source can read [doris]
doris-robot commented on PR #26431: URL: https://github.com/apache/doris/pull/26431#issuecomment-1793678271 TeamCity be ut coverage result: Function Coverage: 37.30% (8454/22667) Line Coverage: 29.68% (68463/230637) Region Coverage: 28.35% (35430/124981) Branch Coverage: 25.08% (18080/72086) Coverage Report: http://coverage.selectdb-in.cc/coverage/8d010e4792c02777e8c322fc9abbc96dbb031722_8d010e4792c02777e8c322fc9abbc96dbb031722/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) add last blocked dep in source can read [doris]
doris-robot commented on PR #26431: URL: https://github.com/apache/doris/pull/26431#issuecomment-1793679599 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.04 seconds stream load tsv: 559 seconds loaded 74807831229 Bytes, about 127 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s insert into select: 28.8 seconds inserted 1000 Rows, about 347K ops/s storage size: 17162348532 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] Row distribution [doris]
dataroaring opened a new pull request, #26432: URL: https://github.com/apache/doris/pull/26432 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Row distribution [doris]
dataroaring commented on PR #26432: URL: https://github.com/apache/doris/pull/26432#issuecomment-1793679737 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Row distribution [doris]
github-actions[bot] commented on code in PR #26432:
URL: https://github.com/apache/doris/pull/26432#discussion_r1382537027
##
be/src/exec/tablet_info.h:
##
@@ -17,6 +17,7 @@
#pragma once
+#include
Review Comment:
warning: 'butil/fast_rand.h' file not found [clang-diagnostic-error]
```cpp
#include
^
```
##
be/src/exec/tablet_info.h:
##
@@ -162,9 +165,78 @@
int64_t version() const { return _t_param.version; }
// return true if we found this block_row in partition
-bool find_partition(BlockRow* block_row, const VOlapTablePartition**
partition) const;
+//TODO: use virtual function to refactor it
+ALWAYS_INLINE bool find_partition(vectorized::Block* block, int row,
+ VOlapTablePartition*& partition) const {
+auto it = _is_in_partition ? _partitions_map->find(std::tuple {block,
row, true})
+ : _partitions_map->upper_bound(std::tuple
{block, row, true});
+// for list partition it might result in default partition
+if (_is_in_partition) {
+partition = (it != _partitions_map->end()) ? it->second :
_default_partition;
+it = _partitions_map->end();
+}
+if (it != _partitions_map->end() &&
+_part_contains(it->second, std::tuple {block, row, true})) {
+partition = it->second;
+}
+return (partition != nullptr);
+}
+
+ALWAYS_INLINE void find_tablets(
Review Comment:
warning: method 'find_tablets' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static ALWAYS_INLINE void find_tablets(
```
be/src/exec/tablet_info.h:189:
```diff
- std::map* partition_tablets_buffer =
nullptr) const {
+ std::map* partition_tablets_buffer =
nullptr) {
```
##
be/src/vec/sink/vtablet_sink_v2.cpp:
##
@@ -221,20 +221,32 @@ void VOlapTableSinkV2::_build_tablet_node_mapping() {
}
}
-void VOlapTableSinkV2::_generate_rows_for_tablet(RowsForTablet&
rows_for_tablet,
- const VOlapTablePartition*
partition,
- uint32_t tablet_index, int
row_idx) {
-// Generate channel payload for sinking data to each tablet
-for (const auto& index : partition->indexes) {
-auto tablet_id = index.tablets[tablet_index];
-if (rows_for_tablet.count(tablet_id) == 0) {
-Rows rows;
-rows.partition_id = partition->id;
-rows.index_id = index.index_id;
-rows_for_tablet.insert({tablet_id, rows});
+void VOlapTableSinkV2::_generate_rows_for_tablet(
Review Comment:
warning: method '_generate_rows_for_tablet' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void VOlapTableSinkV2::_generate_rows_for_tablet(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) avoid using blocked queue in sink/filter/finish [doris]
Mryange commented on PR #26393: URL: https://github.com/apache/doris/pull/26393#issuecomment-1793682779 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](workflow) Fix failure test cases in BE UT (macOS) [doris]
adonis0147 commented on PR #26425: URL: https://github.com/apache/doris/pull/26425#issuecomment-1793683487 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) avoid using blocked queue in sink/filter/finish [doris]
github-actions[bot] commented on code in PR #26393:
URL: https://github.com/apache/doris/pull/26393#discussion_r1382539515
##
be/src/pipeline/pipeline_x/dependency.cpp:
##
@@ -294,6 +317,18 @@ std::vector
HashJoinDependency::convert_block_to_null(vectorized::Bloc
return results;
}
+void SetSharedState::set_probe_finished_children(int child_id) {
Review Comment:
warning: method 'set_probe_finished_children' can be made static
[readability-convert-member-functions-to-static]
be/src/pipeline/pipeline_x/dependency.h:781:
```diff
- void set_probe_finished_children(int child_id);
+ static void set_probe_finished_children(int child_id);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) avoid using blocked queue in sink/filter/finish [doris]
doris-robot commented on PR #26393: URL: https://github.com/apache/doris/pull/26393#issuecomment-1793686645 TeamCity be ut coverage result: Function Coverage: 37.28% (8452/22672) Line Coverage: 29.66% (68433/230718) Region Coverage: 28.32% (35411/125026) Branch Coverage: 25.06% (18073/72118) Coverage Report: http://coverage.selectdb-in.cc/coverage/8fe1dddc52dab8ee6fdc50f4d1d226707cd3b9b2_8fe1dddc52dab8ee6fdc50f4d1d226707cd3b9b2/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Row distribution [doris]
doris-robot commented on PR #26432: URL: https://github.com/apache/doris/pull/26432#issuecomment-1793687119 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.89 seconds stream load tsv: 590 seconds loaded 74807831229 Bytes, about 120 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 34 seconds loaded 861443392 Bytes, about 24 MB/s insert into select: 58.0 seconds inserted 1000 Rows, about 172K ops/s storage size: 17162338866 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) avoid using blocked queue in sink/filter/finish [doris]
doris-robot commented on PR #26393: URL: https://github.com/apache/doris/pull/26393#issuecomment-1793692147 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.67 seconds stream load tsv: 573 seconds loaded 74807831229 Bytes, about 124 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s insert into select: 28.7 seconds inserted 1000 Rows, about 348K ops/s storage size: 17162259808 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](stats) merge insert action to reduce trasaction volume [doris]
Kikyou1997 commented on PR #26163: URL: https://github.com/apache/doris/pull/26163#issuecomment-1793696773 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) avoid using blocked queue in sink/filter/finish [doris]
Mryange commented on PR #26393: URL: https://github.com/apache/doris/pull/26393#issuecomment-1793699364 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](stats) merge insert action to reduce trasaction volume [doris]
Kikyou1997 commented on PR #26163: URL: https://github.com/apache/doris/pull/26163#issuecomment-1793701865 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) avoid using blocked queue in sink/filter/finish [doris]
doris-robot commented on PR #26393: URL: https://github.com/apache/doris/pull/26393#issuecomment-1793703439 TeamCity be ut coverage result: Function Coverage: 37.29% (8454/22672) Line Coverage: 29.67% (68456/230718) Region Coverage: 28.33% (35426/125026) Branch Coverage: 25.07% (18080/72118) Coverage Report: http://coverage.selectdb-in.cc/coverage/8fe1dddc52dab8ee6fdc50f4d1d226707cd3b9b2_8fe1dddc52dab8ee6fdc50f4d1d226707cd3b9b2/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](auditlog) add column catalog for audit log and audit log table [doris]
Yulei-Yang commented on PR #26403: URL: https://github.com/apache/doris/pull/26403#issuecomment-1793704321 run pipelinex_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](auditlog) add column catalog for audit log and audit log table [doris]
Yulei-Yang commented on PR #26403: URL: https://github.com/apache/doris/pull/26403#issuecomment-1793704517 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](auditlog) add column catalog for audit log and audit log table [doris]
Yulei-Yang commented on PR #26403: URL: https://github.com/apache/doris/pull/26403#issuecomment-1793704908 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](stats) merge insert action to reduce trasaction volume [doris]
doris-robot commented on PR #26163: URL: https://github.com/apache/doris/pull/26163#issuecomment-1793706654 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.68 seconds stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 29.0 seconds inserted 1000 Rows, about 344K ops/s storage size: 17162312552 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) avoid using blocked queue in sink/filter/finish [doris]
doris-robot commented on PR #26393: URL: https://github.com/apache/doris/pull/26393#issuecomment-1793708882 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.11 seconds stream load tsv: 571 seconds loaded 74807831229 Bytes, about 124 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 28.6 seconds inserted 1000 Rows, about 349K ops/s storage size: 17162628344 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](stats) merge insert action to reduce trasaction volume [doris]
doris-robot commented on PR #26163: URL: https://github.com/apache/doris/pull/26163#issuecomment-1793711271 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.47 seconds stream load tsv: 553 seconds loaded 74807831229 Bytes, about 129 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 28.9 seconds inserted 1000 Rows, about 346K ops/s storage size: 17162340515 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.0][enhancement](regression) fault injection for segcompaction test (#25709) [doris]
HHoflittlefish777 commented on PR #26305: URL: https://github.com/apache/doris/pull/26305#issuecomment-1793711976 run build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.0][enhancement](regression) fault injection for segcompaction test (#25709) [doris]
HHoflittlefish777 commented on PR #26305: URL: https://github.com/apache/doris/pull/26305#issuecomment-1793712023 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) avoid using blocked queue in sink/filter/finish [doris]
Mryange commented on PR #26393: URL: https://github.com/apache/doris/pull/26393#issuecomment-1793712357 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.0][enhancement](regression) fault injection for segcompaction test (#25709) [doris]
github-actions[bot] commented on PR #26305: URL: https://github.com/apache/doris/pull/26305#issuecomment-1793713047 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [cases](regression-test) Add backup & restore test case of dup table [doris]
Bears0haunt opened a new pull request, #26433: URL: https://github.com/apache/doris/pull/26433 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [cases](regression-test) Add backup & restore test case of dup table [doris]
Bears0haunt commented on PR #26433: URL: https://github.com/apache/doris/pull/26433#issuecomment-1793716003 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.0][enhancement](regression) fault injection for segcompaction test (#25709) [doris]
doris-robot commented on PR #26305: URL: https://github.com/apache/doris/pull/26305#issuecomment-1793716187 TeamCity be ut coverage result: Function Coverage: 38.26% (7941/20754) Line Coverage: 30.16% (64462/213707) Region Coverage: 29.25% (33272/113734) Branch Coverage: 25.09% (17113/68206) Coverage Report: http://coverage.selectdb-in.cc/coverage/3ad4e3e0f1fee2002c404842079a8a08c919d137_3ad4e3e0f1fee2002c404842079a8a08c919d137/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) avoid using blocked queue in sink/filter/finish [doris]
doris-robot commented on PR #26393: URL: https://github.com/apache/doris/pull/26393#issuecomment-1793718454 TeamCity be ut coverage result: Function Coverage: 37.28% (8453/22672) Line Coverage: 29.67% (68456/230718) Region Coverage: 28.33% (35426/125026) Branch Coverage: 25.07% (18077/72118) Coverage Report: http://coverage.selectdb-in.cc/coverage/8fe1dddc52dab8ee6fdc50f4d1d226707cd3b9b2_8fe1dddc52dab8ee6fdc50f4d1d226707cd3b9b2/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.0][enhancement](regression) fault injection for segcompaction test (#25709) [doris]
doris-robot commented on PR #26305: URL: https://github.com/apache/doris/pull/26305#issuecomment-1793718967 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.17 seconds stream load tsv: 553 seconds loaded 74807831229 Bytes, about 129 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s insert into select: 29.2 seconds inserted 1000 Rows, about 342K ops/s storage size: 17162714152 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) avoid using blocked queue in sink/filter/finish [doris]
doris-robot commented on PR #26393: URL: https://github.com/apache/doris/pull/26393#issuecomment-1793722293 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.49 seconds stream load tsv: 574 seconds loaded 74807831229 Bytes, about 124 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 28.7 seconds inserted 1000 Rows, about 348K ops/s storage size: 17162266287 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pipelineX) add last blocked dep in source can read [doris]
Mryange closed pull request #26431: [feature](pipelineX) add last blocked dep in source can read URL: https://github.com/apache/doris/pull/26431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](stats) merge insert action to reduce trasaction volume [doris]
Kikyou1997 commented on PR #26163: URL: https://github.com/apache/doris/pull/26163#issuecomment-1793729034 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [cases](regression-test) Add backup & restore test case of dup table [doris]
Bears0haunt commented on PR #26433: URL: https://github.com/apache/doris/pull/26433#issuecomment-1793729960 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Row distribution [doris]
dataroaring commented on PR #26432: URL: https://github.com/apache/doris/pull/26432#issuecomment-1793732470 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Opt](orc-reader) Optimize orc string dict filter in not_single_conjunct case. [doris]
kaka11chen commented on PR #26386: URL: https://github.com/apache/doris/pull/26386#issuecomment-1793733196 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Row distribution [doris]
github-actions[bot] commented on code in PR #26432:
URL: https://github.com/apache/doris/pull/26432#discussion_r1382573855
##
be/src/vec/sink/vrow_distribution.cpp:
##
@@ -0,0 +1,300 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+#include
Review Comment:
warning: 'gen_cpp/FrontendService.h' file not found [clang-diagnostic-error]
```cpp
#include
^
```
##
be/src/vec/sink/vrow_distribution.h:
##
@@ -0,0 +1,125 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+// IWYU pragma: no_include
+#include
+#include
+#include
+
+#include "common/status.h"
+#include "exec/tablet_info.h"
+#include "runtime/types.h"
+#include "util/runtime_profile.h"
+#include "util/stopwatch.hpp"
+#include "vec/core/block.h"
+#include "vec/data_types/data_type.h"
+#include "vec/exprs/vexpr_fwd.h"
+#include "vec/sink/vtablet_block_convertor.h"
+#include "vec/sink/vtablet_finder.h"
+
+namespace doris::vectorized {
+
+class IndexChannel;
+class VNodeChannel;
+
+using Payload = std::pair,
std::vector>;
+
+typedef Status (*OnPartitionsCreated)(void*, TCreatePartitionResult*);
+
+class VRowDistributionContext {
+public:
+RuntimeState* state = nullptr; // not owned, set when open
+std::vector>* channels;
+OlapTableBlockConvertor* block_convertor = nullptr;
+OlapTabletFinder* tablet_finder = nullptr;
+VOlapTablePartitionParam* vpartition = nullptr;
+RuntimeProfile::Counter* add_partition_request_timer = nullptr;
+int64_t txn_id = -1;
+ObjectPool* pool;
+OlapTableLocationParam* location;
+const VExprContextSPtrs* vec_output_expr_ctxs;
+OnPartitionsCreated on_partitions_created;
+};
+
+class VRowDistribution {
+public:
+VRowDistribution() {
+}
Review Comment:
warning: use '= default' to define a trivial default constructor
[modernize-use-equals-default]
```suggestion
VRowDistribution() = default;
```
##
be/src/vec/sink/vrow_distribution.cpp:
##
@@ -0,0 +1,300 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+#include
+#include
+#include "runtime/client_cache.h"
+#include "runtime/exec_env.h"
+#include "runtime/runtime_state.h"
+#include "util/thrift_rpc_helper.h"
+#include "vec/sink/vrow_distribution.h"
+#include "vec/sink/writer/vtablet_writer.h"
+
+namespace doris::vectorized {
+
+std::pair
+VRowDistribution::_get_partition_function() {
+return {_vpartition->get_part_func_ctx(),
_vpartition->get_partition_function()};
+}
+
+void VRowDistribution::_save_missing_values(vectorized::ColumnPtr col,
+vectorized::DataTypePtr value_ty
Re: [PR] [Opt](multi-catalog) Optimize string dict filter in not_single_conjunct case. [doris]
github-actions[bot] commented on PR #26386: URL: https://github.com/apache/doris/pull/26386#issuecomment-1793734575 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Row distribution [doris]
dataroaring commented on PR #26432: URL: https://github.com/apache/doris/pull/26432#issuecomment-1793735889 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Row distribution [doris]
github-actions[bot] commented on code in PR #26432:
URL: https://github.com/apache/doris/pull/26432#discussion_r1382576658
##
be/src/vec/sink/vrow_distribution.h:
##
@@ -0,0 +1,128 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+// IWYU pragma: no_include
+#include
+#include
+#include
+
+#include "common/status.h"
+#include "exec/tablet_info.h"
+#include "runtime/types.h"
+#include "util/runtime_profile.h"
+#include "util/stopwatch.hpp"
+#include "vec/core/block.h"
+#include "vec/data_types/data_type.h"
+#include "vec/exprs/vexpr_fwd.h"
+#include "vec/sink/vtablet_block_convertor.h"
+#include "vec/sink/vtablet_finder.h"
+
+namespace doris::vectorized {
+
+class IndexChannel;
+class VNodeChannel;
+
+using Payload = std::pair,
std::vector>;
+
+typedef Status (*OnPartitionsCreated)(void*, TCreatePartitionResult*);
+
+class VRowDistributionContext {
+public:
+RuntimeState* state = nullptr; // not owned, set when open
+std::vector>* channels;
+OlapTableBlockConvertor* block_convertor = nullptr;
+OlapTabletFinder* tablet_finder = nullptr;
+VOlapTablePartitionParam* vpartition = nullptr;
+RuntimeProfile::Counter* add_partition_request_timer = nullptr;
+int64_t txn_id = -1;
+ObjectPool* pool;
+OlapTableLocationParam* location;
+const VExprContextSPtrs* vec_output_expr_ctxs;
+OnPartitionsCreated on_partitions_created;
+void* caller;
+};
+
+class VRowDistribution {
+public:
+VRowDistribution() {
+}
+
+void init(VRowDistributionContext *ctx) {
+_state = ctx->state;
+_channels = ctx->channels;
+_block_convertor = ctx->block_convertor;
+_tablet_finder = ctx->tablet_finder;
+_vpartition = ctx->vpartition;
+_add_partition_request_timer = ctx->add_partition_request_timer;
+_txn_id = ctx->txn_id;
+_pool = ctx->pool;
+_location = ctx->location;
+_vec_output_expr_ctxs = ctx->vec_output_expr_ctxs;
+_on_partitions_created = ctx->on_partitions_created;
+_caller = ctx->caller;
+}
+
+using ChannelDistributionPayload =
std::vector>;
+
+Status generate_rows_distribution(vectorized::Block& input_block,
+ std::shared_ptr&
block,
+ int64_t& filtered_rows, bool&
has_filtered_rows,
+ ChannelDistributionPayload&
channel_to_payload);
+
+private:
+std::pair
_get_partition_function();
+void _save_missing_values(vectorized::ColumnPtr col,
vectorized::DataTypePtr value_type,
+ std::vector filter);
+
+// create partitions when need for auto-partition table using
#_partitions_need_create.
+Status _automatic_create_partition();
+
+Status _single_partition_generate(vectorized::Block* block,
+ ChannelDistributionPayload&
channel_to_payload,
+ size_t num_rows, bool has_filtered_rows);
+
+void _generate_row_distribution_payload(
+ChannelDistributionPayload& channel_to_payload,
+const std::vector& partitions,
+const std::vector& tablet_indexes, const std::vector&
skip,
+size_t row_cnt);
+
+private:
Review Comment:
warning: redundant access specifier has the same accessibility as the
previous access specifier [readability-redundant-access-specifiers]
```suggestion
```
Additional context
**be/src/vec/sink/vrow_distribution.h:87:** previously declared here
```cpp
private:
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](stats) merge insert action to reduce trasaction volume [doris]
doris-robot commented on PR #26163: URL: https://github.com/apache/doris/pull/26163#issuecomment-1793740176 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.38 seconds stream load tsv: 551 seconds loaded 74807831229 Bytes, about 129 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 28.7 seconds inserted 1000 Rows, about 348K ops/s storage size: 17162394815 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) make AGG_SCALAR_SUBQUERY_TO_WINDOW_FUNCTION rewrite rule [doris]
github-actions[bot] commented on PR #25969: URL: https://github.com/apache/doris/pull/25969#issuecomment-1793741718 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) make AGG_SCALAR_SUBQUERY_TO_WINDOW_FUNCTION rewrite rule [doris]
github-actions[bot] commented on PR #25969: URL: https://github.com/apache/doris/pull/25969#issuecomment-1793741722 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Row distribution [doris]
doris-robot commented on PR #26432: URL: https://github.com/apache/doris/pull/26432#issuecomment-1793742965 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.42 seconds stream load tsv: 586 seconds loaded 74807831229 Bytes, about 121 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 56.0 seconds inserted 1000 Rows, about 178K ops/s storage size: 17162203014 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Row distribution [doris]
doris-robot commented on PR #26432: URL: https://github.com/apache/doris/pull/26432#issuecomment-1793746600 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.28 seconds stream load tsv: 586 seconds loaded 74807831229 Bytes, about 121 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 55.8 seconds inserted 1000 Rows, about 179K ops/s storage size: 17162303039 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Opt](multi-catalog) Optimize string dict filter in not_single_conjunct case. [doris]
github-actions[bot] commented on PR #26386: URL: https://github.com/apache/doris/pull/26386#issuecomment-1793748323 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [cases](regression-test) Add backup & restore test case of dup table [doris]
Bears0haunt commented on PR #26433: URL: https://github.com/apache/doris/pull/26433#issuecomment-1793752142 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Opt](multi-catalog) Optimize string dict filter in not_single_conjunct case. [doris]
kaka11chen commented on PR #26386: URL: https://github.com/apache/doris/pull/26386#issuecomment-1793753719 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Opt](multi-catalog) Optimize string dict filter in not_single_conjunct case. [doris]
doris-robot commented on PR #26386: URL: https://github.com/apache/doris/pull/26386#issuecomment-1793759362 TeamCity be ut coverage result: Function Coverage: 37.30% (8454/22666) Line Coverage: 29.69% (68463/230620) Region Coverage: 28.34% (35421/124974) Branch Coverage: 25.09% (18082/72078) Coverage Report: http://coverage.selectdb-in.cc/coverage/5530e7a7cef19c55d046cdf3f619d995c7421fa8_5530e7a7cef19c55d046cdf3f619d995c7421fa8/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Opt](multi-catalog) Optimize string dict filter in not_single_conjunct case. [doris]
doris-robot commented on PR #26386: URL: https://github.com/apache/doris/pull/26386#issuecomment-1793763352 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.45 seconds stream load tsv: 548 seconds loaded 74807831229 Bytes, about 130 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s insert into select: 28.7 seconds inserted 1000 Rows, about 348K ops/s storage size: 17162212758 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) infer result column name in ctas and query stmt [doris]
seawinde commented on code in PR #26055:
URL: https://github.com/apache/doris/pull/26055#discussion_r1382599382
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindExpression.java:
##
@@ -564,10 +567,16 @@ protected boolean condition(Rule rule, Plan plan) {
),
RuleType.BINDING_RESULT_SINK.build(
unboundResultSink().then(sink -> {
-List outputExprs =
sink.child().getOutput().stream()
-.map(NamedExpression.class::cast)
-.collect(ImmutableList.toImmutableList());
-return new LogicalResultSink<>(outputExprs, sink.child());
+
+final ImmutableListMultimap.Builder
exprIdToIndexMapBuilder =
Review Comment:
Ctas stmt is only supported by legacy, It's already supported in another pr
[Infer the column name when create view if the column is
expression](https://github.com/apache/doris/pull/24990), and when cats is
supported in nereids future, this is also useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) infer result column name in ctas and query stmt [doris]
seawinde commented on PR #26055: URL: https://github.com/apache/doris/pull/26055#issuecomment-1793773815 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature-wip](arrow-flight)(step4) Support other DML and DDL statements, besides `Select` [doris]
xinyiZzz commented on code in PR #25919:
URL: https://github.com/apache/doris/pull/25919#discussion_r1382599813
##
fe/fe-core/src/main/java/org/apache/doris/mysql/MysqlProto.java:
##
@@ -339,7 +339,7 @@ public static boolean negotiate(ConnectContext context)
throws IOException {
}
Env.getCurrentEnv().changeDb(context, dbFullName);
} catch (DdlException e) {
-context.getState().setError(e.getMysqlErrorCode(),
e.getMessage());
+context.getState().setError(e.getUserErrorCode(),
e.getMessage());
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature-wip](arrow-flight)(step4) Support other DML and DDL statements, besides `Select` [doris]
xinyiZzz commented on code in PR #25919:
URL: https://github.com/apache/doris/pull/25919#discussion_r1382599833
##
fe/fe-core/src/main/java/org/apache/doris/qe/QueryState.java:
##
@@ -47,7 +48,7 @@ public enum ErrType {
private long affectedRows = 0;
private int warningRows = 0;
// make it public for easy to use
-public int serverStatus = 0;
+public int mysqlServerStatus = 0;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) infer result column name in ctas and query stmt [doris]
seawinde commented on code in PR #26055:
URL: https://github.com/apache/doris/pull/26055#discussion_r1382600380
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/visitor/PlanVisitors.java:
##
@@ -0,0 +1,84 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.visitor;
+
+import org.apache.doris.nereids.trees.expressions.Alias;
+import org.apache.doris.nereids.trees.expressions.ExprId;
+import org.apache.doris.nereids.trees.expressions.NamedExpression;
+import org.apache.doris.nereids.trees.expressions.Slot;
+import org.apache.doris.nereids.trees.plans.Plan;
+
+import com.google.common.collect.ImmutableCollection;
+import com.google.common.collect.ImmutableMultimap;
+import com.google.common.collect.ImmutableSet;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.stream.Collectors;
+
+/**
+ * This is the facade and factory for plan visitor
+ */
+public class PlanVisitors {
+
+/**
+ * Infer output column name when it refers an expression and not has an
alias manually.
+ */
+public static class InferPlanOutputAlias extends DefaultPlanVisitor> {
+
+private final List currentOutputs;
+private final List finalOutputs;
+
+public InferPlanOutputAlias(List currentOutputs) {
+this.currentOutputs = currentOutputs;
+this.finalOutputs = new ArrayList<>(currentOutputs);
+}
+
+@Override
+public Void visit(Plan plan, ImmutableMultimap
context) {
+
+List projects = plan.getExpressions().stream()
+.filter(expression -> expression instanceof
NamedExpression)
+.map(NamedExpression.class::cast)
+.collect(Collectors.toList());
+
+ImmutableSet currentOutputExprIdSet = context.keySet();
+for (NamedExpression projectItem : projects) {
+ExprId exprId = projectItem.getExprId();
+// Infer name when alias child is expression and alias's name
is from child
+if (currentOutputExprIdSet.contains(projectItem.getExprId())
+&& projectItem instanceof Alias
+&& ((Alias) projectItem).isNameFromChild()) {
Review Comment:
Alias construct logical as following:
`public Expression visitUnboundAlias(UnboundAlias unboundAlias,
CascadesContext context) {
Expression child = unboundAlias.child().accept(this, context);
if (unboundAlias.getAlias().isPresent()) {
return new Alias(child, unboundAlias.getAlias().get());
} else if (child instanceof NamedExpression) {
return new Alias(child, ((NamedExpression) child).getName());
} else {
return new Alias(child);
}
}`
if the alias name is set by child.toSql() we should infer the alias name.
`isNameFromChild ` field identify the name is from child. Maybe we should add
anther field to record the info. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) infer result column name in ctas and query stmt [doris]
seawinde commented on code in PR #26055:
URL: https://github.com/apache/doris/pull/26055#discussion_r1382600380
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/visitor/PlanVisitors.java:
##
@@ -0,0 +1,84 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.visitor;
+
+import org.apache.doris.nereids.trees.expressions.Alias;
+import org.apache.doris.nereids.trees.expressions.ExprId;
+import org.apache.doris.nereids.trees.expressions.NamedExpression;
+import org.apache.doris.nereids.trees.expressions.Slot;
+import org.apache.doris.nereids.trees.plans.Plan;
+
+import com.google.common.collect.ImmutableCollection;
+import com.google.common.collect.ImmutableMultimap;
+import com.google.common.collect.ImmutableSet;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.stream.Collectors;
+
+/**
+ * This is the facade and factory for plan visitor
+ */
+public class PlanVisitors {
+
+/**
+ * Infer output column name when it refers an expression and not has an
alias manually.
+ */
+public static class InferPlanOutputAlias extends DefaultPlanVisitor> {
+
+private final List currentOutputs;
+private final List finalOutputs;
+
+public InferPlanOutputAlias(List currentOutputs) {
+this.currentOutputs = currentOutputs;
+this.finalOutputs = new ArrayList<>(currentOutputs);
+}
+
+@Override
+public Void visit(Plan plan, ImmutableMultimap
context) {
+
+List projects = plan.getExpressions().stream()
+.filter(expression -> expression instanceof
NamedExpression)
+.map(NamedExpression.class::cast)
+.collect(Collectors.toList());
+
+ImmutableSet currentOutputExprIdSet = context.keySet();
+for (NamedExpression projectItem : projects) {
+ExprId exprId = projectItem.getExprId();
+// Infer name when alias child is expression and alias's name
is from child
+if (currentOutputExprIdSet.contains(projectItem.getExprId())
+&& projectItem instanceof Alias
+&& ((Alias) projectItem).isNameFromChild()) {
Review Comment:
Alias construct logical as following:
> public Expression visitUnboundAlias(UnboundAlias unboundAlias,
CascadesContext context) {
> Expression child = unboundAlias.child().accept(this, context);
> if (unboundAlias.getAlias().isPresent()) {
> return new Alias(child, unboundAlias.getAlias().get());
> } else if (child instanceof NamedExpression) {
> return new Alias(child, ((NamedExpression) child).getName());
> } else {
> return new Alias(child);
> }
> }
if the alias name is set by child.toSql() we should infer the alias name.
`isNameFromChild ` field identify the name is from child. Maybe we should add
anther field to record the info. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature-wip](arrow-flight)(step4) Support other DML and DDL statements, besides `Select` [doris]
xinyiZzz commented on code in PR #25919:
URL: https://github.com/apache/doris/pull/25919#discussion_r1382602689
##
fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java:
##
@@ -716,10 +773,9 @@ public void kill(boolean killConnection) {
if (killConnection) {
isKilled = true;
-if (connectType.equals(ConnectType.MYSQL)) {
-// Close channel to break connection with client
-getMysqlChannel().close();
-} else if (connectType.equals(ConnectType.ARROW_FLIGHT)) {
+// Close channel to break connection with client
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature-wip](arrow-flight)(step4) Support other DML and DDL statements, besides `Select` [doris]
xinyiZzz commented on PR #25919: URL: https://github.com/apache/doris/pull/25919#issuecomment-1793781177 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) infer result column name in ctas and query stmt [doris]
doris-robot commented on PR #26055: URL: https://github.com/apache/doris/pull/26055#issuecomment-1793784918 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.08 seconds stream load tsv: 553 seconds loaded 74807831229 Bytes, about 129 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 29.0 seconds inserted 1000 Rows, about 344K ops/s storage size: 17161949271 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature-wip](arrow-flight)(step4) Support other DML and DDL statements, besides `Select` [doris]
doris-robot commented on PR #25919: URL: https://github.com/apache/doris/pull/25919#issuecomment-1793788129 TeamCity be ut coverage result: Function Coverage: 37.29% (8452/22667) Line Coverage: 29.68% (68442/230636) Region Coverage: 28.33% (35408/124980) Branch Coverage: 25.07% (18075/72084) Coverage Report: http://coverage.selectdb-in.cc/coverage/f178572d22f6371c78562d92d7f66c0115e9ae02_f178572d22f6371c78562d92d7f66c0115e9ae02/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature-wip](arrow-flight)(step4) Support other DML and DDL statements, besides `Select` [doris]
xinyiZzz commented on PR #25919: URL: https://github.com/apache/doris/pull/25919#issuecomment-1793791813 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature-wip](arrow-flight)(step4) Support other DML and DDL statements, besides `Select` [doris]
doris-robot commented on PR #25919: URL: https://github.com/apache/doris/pull/25919#issuecomment-1793792312 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.16 seconds stream load tsv: 574 seconds loaded 74807831229 Bytes, about 124 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 34 seconds loaded 861443392 Bytes, about 24 MB/s insert into select: 28.8 seconds inserted 1000 Rows, about 347K ops/s storage size: 17162362181 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature-wip](arrow-flight)(step4) Support other DML and DDL statements, besides `Select` [doris]
doris-robot commented on PR #25919: URL: https://github.com/apache/doris/pull/25919#issuecomment-1793798422 TeamCity be ut coverage result: Function Coverage: 37.30% (8454/22667) Line Coverage: 29.68% (68455/230636) Region Coverage: 28.34% (35417/124980) Branch Coverage: 25.08% (18079/72084) Coverage Report: http://coverage.selectdb-in.cc/coverage/5328810b31d85ade7ca10939e31f6a3c4beaf4ff_5328810b31d85ade7ca10939e31f6a3c4beaf4ff/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature-wip](arrow-flight)(step4) Support other DML and DDL statements, besides `Select` [doris]
doris-robot commented on PR #25919: URL: https://github.com/apache/doris/pull/25919#issuecomment-1793799790 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.58 seconds stream load tsv: 576 seconds loaded 74807831229 Bytes, about 123 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s insert into select: 28.7 seconds inserted 1000 Rows, about 348K ops/s storage size: 17162621155 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](load) optimize the performance of row distribution [doris]
zclllyybb commented on PR #25546: URL: https://github.com/apache/doris/pull/25546#issuecomment-1793800986 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](load) optimize the performance of row distribution [doris]
doris-robot commented on PR #25546: URL: https://github.com/apache/doris/pull/25546#issuecomment-1793804962 TeamCity be ut coverage result: Function Coverage: 37.29% (8452/22666) Line Coverage: 29.68% (68467/230659) Region Coverage: 28.35% (35428/124978) Branch Coverage: 25.09% (18092/72102) Coverage Report: http://coverage.selectdb-in.cc/coverage/82fd4ba41845d12db80d8772c8477a887550da4e_82fd4ba41845d12db80d8772c8477a887550da4e/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](load) optimize the performance of row distribution [doris]
doris-robot commented on PR #25546: URL: https://github.com/apache/doris/pull/25546#issuecomment-1793810598 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.97 seconds stream load tsv: 584 seconds loaded 74807831229 Bytes, about 122 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 56.0 seconds inserted 1000 Rows, about 178K ops/s storage size: 17162345108 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [don't merge] run move-memtable regression tests [doris]
kaijchen commented on PR #25796: URL: https://github.com/apache/doris/pull/25796#issuecomment-1793863070 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [don't merge] run move-memtable regression tests [doris]
github-actions[bot] commented on code in PR #25796:
URL: https://github.com/apache/doris/pull/25796#discussion_r1382661621
##
be/src/runtime/load_stream_writer.cpp:
##
@@ -121,7 +121,15 @@ Status LoadStreamWriter::close_segment(uint32_t segid) {
return Status::OK();
}
-Status LoadStreamWriter::add_segment(uint32_t segid, SegmentStatistics& stat) {
+Status LoadStreamWriter::add_segment(uint32_t segid, const SegmentStatistics&
stat) {
Review Comment:
warning: method 'add_segment' can be made static
[readability-convert-member-functions-to-static]
be/src/runtime/load_stream_writer.h:73:
```diff
- Status add_segment(uint32_t segid, const SegmentStatistics& stat);
+ static Status add_segment(uint32_t segid, const SegmentStatistics&
stat);
```
##
be/src/vec/sink/load_stream_stub.cpp:
##
@@ -83,31 +83,33 @@ void
LoadStreamStub::LoadStreamReplyHandler::on_closed(brpc::StreamId id) {
_close_cv.notify_all();
}
-LoadStreamStub::LoadStreamStub(PUniqueId load_id, int64_t src_id)
-: _load_id(load_id),
+LoadStreamStub::LoadStreamStub(PUniqueId load_id, int64_t src_id, int num_use)
+: _use_cnt(num_use),
+ _load_id(load_id),
_src_id(src_id),
_tablet_schema_for_index(std::make_shared()),
- _enable_unique_mow_for_index(std::make_shared())
{};
+ _enable_unique_mow_for_index(std::make_shared()) {}
LoadStreamStub::LoadStreamStub(LoadStreamStub& stub)
-: _load_id(stub._load_id),
+: _use_cnt(stub._use_cnt.load()),
+ _load_id(stub._load_id),
_src_id(stub._src_id),
_tablet_schema_for_index(stub._tablet_schema_for_index),
- _enable_unique_mow_for_index(stub._enable_unique_mow_for_index) {};
+ _enable_unique_mow_for_index(stub._enable_unique_mow_for_index) {}
LoadStreamStub::~LoadStreamStub() {
if (_is_init.load() && !_handler.is_closed()) {
brpc::StreamClose(_stream_id);
+static_cast(close_wait(6)); // 60s
Review Comment:
warning: 6 is a magic number; consider replacing it with a named
constant [readability-magic-numbers]
```cpp
static_cast(close_wait(6)); // 60s
^
```
##
be/src/vec/sink/vtablet_sink_v2.cpp:
##
@@ -165,35 +175,37 @@
SCOPED_CONSUME_MEM_TRACKER(_mem_tracker.get());
signal::set_signal_task_id(_load_id);
-_build_tablet_node_mapping();
-RETURN_IF_ERROR(_open_streams(state->backend_id()));
-
+RETURN_IF_ERROR(_open_streams());
return Status::OK();
}
-Status VOlapTableSinkV2::_open_streams(int64_t src_id) {
+Status VOlapTableSinkV2::_init_streams(int64_t src_id) {
for (auto& [dst_id, _] : _tablets_for_node) {
+_streams_for_node[dst_id] =
ExecEnv::GetInstance()->load_stream_stub_pool()->get_or_create(
+_load_id, src_id, dst_id, _stream_per_node, _num_local_sink);
+}
+return Status::OK();
+}
+
+Status VOlapTableSinkV2::_open_streams() {
Review Comment:
warning: method '_open_streams' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/sink/vtablet_sink_v2.h:125:
```diff
- Status _open_streams();
+ static Status _open_streams();
```
##
be/src/vec/sink/vtablet_sink_v2.cpp:
##
@@ -165,35 +175,37 @@ Status VOlapTableSinkV2::open(RuntimeState* state) {
SCOPED_CONSUME_MEM_TRACKER(_mem_tracker.get());
signal::set_signal_task_id(_load_id);
-_build_tablet_node_mapping();
-RETURN_IF_ERROR(_open_streams(state->backend_id()));
-
+RETURN_IF_ERROR(_open_streams());
return Status::OK();
}
-Status VOlapTableSinkV2::_open_streams(int64_t src_id) {
+Status VOlapTableSinkV2::_init_streams(int64_t src_id) {
Review Comment:
warning: method '_init_streams' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/sink/vtablet_sink_v2.h:123:
```diff
- Status _init_streams(int64_t src_id);
+ static Status _init_streams(int64_t src_id);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [don't merge] run move-memtable regression tests [doris]
doris-robot commented on PR #25796: URL: https://github.com/apache/doris/pull/25796#issuecomment-1793886459 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.56 seconds stream load tsv: 553 seconds loaded 74807831229 Bytes, about 129 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s insert into select: 28.9 seconds inserted 1000 Rows, about 346K ops/s storage size: 17162216933 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids) support subquery combine [doris]
github-actions[bot] commented on PR #19288: URL: https://github.com/apache/doris/pull/19288#issuecomment-1793893129 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Opt](multi-catalog) Optimize string dict filter in not_single_conjunct case. [doris]
kaka11chen commented on PR #26386: URL: https://github.com/apache/doris/pull/26386#issuecomment-1793941906 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Pick-2.0](regression) add failure injection in inverted index writer [doris]
airborne12 commented on PR #26376: URL: https://github.com/apache/doris/pull/26376#issuecomment-1793944416 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Opt](multi-catalog) Optimize string dict filter in not_single_conjunct case. [doris]
github-actions[bot] commented on code in PR #26386:
URL: https://github.com/apache/doris/pull/26386#discussion_r1382705928
##
be/src/vec/exec/format/orc/vorc_reader.cpp:
##
@@ -164,7 +165,7 @@
_is_hive(params.__isset.slot_name_to_schema_pos),
_file_system(nullptr),
_io_ctx(io_ctx),
- _enable_lazy_mat(enable_lazy_mat) {
+ _enable_lazy_mat(enable_lazy_mat) _is_on_string_dicts_loaded(false) {
Review Comment:
warning: member initializer for '_is_on_string_dicts_loaded' is redundant
[modernize-use-default-member-init]
```suggestion
_enable_lazy_mat(enable_lazy_mat) {
```
##
be/src/vec/exec/format/orc/vorc_reader.cpp:
##
@@ -145,7 +145,8 @@ OrcReader::OrcReader(RuntimeProfile* profile, RuntimeState*
state,
_ctz(ctz),
_is_hive(params.__isset.slot_name_to_schema_pos),
_io_ctx(io_ctx),
- _enable_lazy_mat(enable_lazy_mat) {
+ _enable_lazy_mat(enable_lazy_mat),
+ _is_on_string_dicts_loaded(false) {
Review Comment:
warning: member initializer for '_is_on_string_dicts_loaded' is redundant
[modernize-use-default-member-init]
```suggestion
{
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Pick-2.0](regression) add failure injection in inverted index writer [doris]
github-actions[bot] commented on PR #26376: URL: https://github.com/apache/doris/pull/26376#issuecomment-1793948160 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [branch-2.0-var](sample) Fix computeSampleTabletIds NullPointerException [doris]
xinyiZzz opened a new pull request, #26434: URL: https://github.com/apache/doris/pull/26434 ## Proposed changes ``` 2023-11-05 22:52:01,914 WARN (mysql-nio-pool-167|1655) [StmtExecutor.analyze():992] Analyze failed. stmt[222101, ec1adf0f9f7b405d-8cb71a522bc50b82] java.lang.NullPointerException: null at org.apache.doris.planner.OlapScanNode.computeSampleTabletIds(OlapScanNode.java:952) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.planner.OlapScanNode.init(OlapScanNode.java:548) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.planner.SingleNodePlanner.createScanNode(SingleNodePlanner.java:2064) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.planner.SingleNodePlanner.createTableRefNode(SingleNodePlanner.java:2213) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.planner.SingleNodePlanner.createSelectPlan(SingleNodePlanner.java:1244) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.planner.SingleNodePlanner.createQueryPlan(SingleNodePlanner.java:266) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.planner.SingleNodePlanner.createSingleNodePlan(SingleNodePlanner.java:189) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.planner.OriginalPlanner.createPlanFragments(OriginalPlanner.java:160) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.planner.OriginalPlanner.plan(OriginalPlanner.java:101) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.StmtExecutor.analyzeAndGenerateQueryPlan(StmtExecutor.java:1141) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.StmtExecutor.analyze(StmtExecutor.java:975) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.StmtExecutor.executeByLegacy(StmtExecutor.java:673) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.StmtExecutor.execute(StmtExecutor.java:451) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.StmtExecutor.execute(StmtExecutor.java:422) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.ConnectProcessor.handleQuery(ConnectProcessor.java:435) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.ConnectProcessor.dispatch(ConnectProcessor.java:583) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.ConnectProcessor.processOnce(ConnectProcessor.java:834) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.mysql.ReadListener.lambda$handleEvent$0(ReadListener.java:52) ~[doris-fe.jar:1.2-SNAPSHOT] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_333] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_333] at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_333] 2023-11-05 22:52:01,914 WARN (mysql-nio-pool-167|1655) [StmtExecutor.executeByLegacy():776] execute Exception. stmt[222101, ec1adf0f9f7b405d-8cb71a522bc50b82] org.apache.doris.common.AnalysisException: errCode = 2, detailMessage = Unexpected exception: null at org.apache.doris.qe.StmtExecutor.analyze(StmtExecutor.java:993) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.StmtExecutor.executeByLegacy(StmtExecutor.java:673) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.StmtExecutor.execute(StmtExecutor.java:451) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.StmtExecutor.execute(StmtExecutor.java:422) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.ConnectProcessor.handleQuery(ConnectProcessor.java:435) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.ConnectProcessor.dispatch(ConnectProcessor.java:583) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.ConnectProcessor.processOnce(ConnectProcessor.java:834) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.mysql.ReadListener.lambda$handleEvent$0(ReadListener.java:52) ~[doris-fe.jar:1.2-SNAPSHOT] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_333] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_333] at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_333] ``` ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: co
Re: [PR] [Opt](multi-catalog) Optimize string dict filter in not_single_conjunct case. [doris]
kaka11chen commented on PR #26386: URL: https://github.com/apache/doris/pull/26386#issuecomment-1793953908 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Improvement](statistics)Improve stats sample strategy. [doris]
Jibing-Li opened a new pull request, #26435: URL: https://github.com/apache/doris/pull/26435 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
