[GitHub] [doris] yiguolei merged pull request #19795: [fix](memory) Remind log if `vm/overcommit_memory`=2 when be start
yiguolei merged PR #19795: URL: https://github.com/apache/doris/pull/19795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (9d54545bac -> 65807f888b)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 9d54545bac [Fix](inverted index) add datev2/datetimev2 for inverted index column type (#19845) add 65807f888b [fix](memory) Remind log if `vm/overcommit_memory`=2 when be start (#19795) No new revisions were added by this update. Summary of changes: be/src/util/mem_info.cpp | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Error while running github feature from .asf.yaml in doris!
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators, please contact vp-in...@apache.org to request an exception. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei commented on issue #19812: [Feature] Add support for arrow flight sql
yiguolei commented on issue #19812: URL: https://github.com/apache/doris/issues/19812#issuecomment-1554117402 @liangjiawei1110 great -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] liuanxin commented on issue #7592: [Bug] Error creating materialized view
liuanxin commented on issue #7592: URL: https://github.com/apache/doris/issues/7592#issuecomment-1554122992 > Doris currently do not support create `count(distinct)` materialized view column on `varchar` column @morningman 请问, 是否有添加「支持 `count(distinct varchar列)` 来创建物化视图」的计划? varchar 做为列来 count distinct 还是挺常见的 Excuse me, Is there a plan to support `count(distinct varchar_column)` with materialized view? varchar as a column to do `count(distinct)` is quite common -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19764: [fix-test](client-cache) Replace ThriftClientImpl* with smart pointer
github-actions[bot] commented on PR #19764: URL: https://github.com/apache/doris/pull/19764#issuecomment-1554132670 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] deadlinefen commented on pull request #19764: [fix-test](client-cache) Replace ThriftClientImpl* with smart pointer
deadlinefen commented on PR #19764: URL: https://github.com/apache/doris/pull/19764#issuecomment-1554137814 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #19859: [chore](build) Fix the compilation errors on macOS (arm64)
adonis0147 commented on PR #19859: URL: https://github.com/apache/doris/pull/19859#issuecomment-1554141016 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19859: [chore](build) Fix the compilation errors on macOS (arm64)
github-actions[bot] commented on PR #19859: URL: https://github.com/apache/doris/pull/19859#issuecomment-1554147937 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19857: [fix](Nereids) drop table before create table in window function test
github-actions[bot] commented on PR #19857: URL: https://github.com/apache/doris/pull/19857#issuecomment-1554157179 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19857: [fix](Nereids) drop table before create table in window function test
github-actions[bot] commented on PR #19857: URL: https://github.com/apache/doris/pull/19857#issuecomment-1554157234 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #19859: [chore](build) Fix the compilation errors on macOS (arm64)
adonis0147 commented on PR #19859: URL: https://github.com/apache/doris/pull/19859#issuecomment-1554160211 run be_ut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #19859: [chore](build) Fix the compilation errors on macOS (arm64)
adonis0147 commented on PR #19859: URL: https://github.com/apache/doris/pull/19859#issuecomment-1554164191 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19859: [chore](build) Fix the compilation errors on macOS (arm64)
github-actions[bot] commented on PR #19859: URL: https://github.com/apache/doris/pull/19859#issuecomment-1554167082 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #19847: [improvement](exchange) data stream sender stop sending data to receiver if it returns eos early
HappenLee commented on code in PR #19847:
URL: https://github.com/apache/doris/pull/19847#discussion_r1198642667
##
be/src/vec/sink/vdata_stream_sender.cpp:
##
@@ -135,8 +135,10 @@ Status Channel::send_local_block(bool eos) {
if (eos) {
_local_recvr->remove_sender(_parent->_sender_id, _be_number);
}
+return Status::OK();
+} else {
+return receiver_status_;
Review Comment:
here need clear _mutable_block mem ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yixiutt opened a new pull request, #19864: [enhancement](page cache) use separate pk index cache
yixiutt opened a new pull request, #19864: URL: https://github.com/apache/doris/pull/19864 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yixiutt commented on pull request #19864: [enhancement](page cache) use separate pk index cache
yixiutt commented on PR #19864: URL: https://github.com/apache/doris/pull/19864#issuecomment-1554168335 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19854: [feature-wip](MTMV) support multi catalog
github-actions[bot] commented on PR #19854: URL: https://github.com/apache/doris/pull/19854#issuecomment-1554168516 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19854: [feature-wip](MTMV) support multi catalog
github-actions[bot] commented on PR #19854: URL: https://github.com/apache/doris/pull/19854#issuecomment-1554168559 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] nextdreamblue commented on pull request #19326: [feature-wip](duplicate-no-keys) schame change support for duplicate no keys
nextdreamblue commented on PR #19326: URL: https://github.com/apache/doris/pull/19326#issuecomment-1554170301 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19860: [improvement](conf)Add an example of directly specifying an IP address
github-actions[bot] commented on PR #19860: URL: https://github.com/apache/doris/pull/19860#issuecomment-1554170399 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19860: [improvement](conf)Add an example of directly specifying an IP address
github-actions[bot] commented on PR #19860: URL: https://github.com/apache/doris/pull/19860#issuecomment-1554170441 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19099: [performance](stream-load) use vector instead of skiplist when insert agg keys
github-actions[bot] commented on PR #19099: URL: https://github.com/apache/doris/pull/19099#issuecomment-1554172274 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19864: [enhancement](page cache) use separate pk index cache
github-actions[bot] commented on PR #19864: URL: https://github.com/apache/doris/pull/19864#issuecomment-1554172492 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #19847: [improvement](exchange) data stream sender stop sending data to receiver if it returns eos early
HappenLee commented on code in PR #19847:
URL: https://github.com/apache/doris/pull/19847#discussion_r1198649009
##
be/src/vec/sink/vdata_stream_sender.cpp:
##
@@ -513,42 +553,72 @@ Status VDataStreamSender::send(RuntimeState* state,
Block* block, bool eos) {
serialize_block(block, block_holder->get_block(),
_channels.size()));
}
-for (auto channel : _channels) {
-if (channel->is_local()) {
-RETURN_IF_ERROR(channel->send_local_block(block));
+Status status;
+for (auto it = _channels.begin(); it != _channels.end();) {
+if ((*it)->is_local()) {
+status = (*it)->send_local_block(block);
} else {
SCOPED_CONSUME_MEM_TRACKER(_mem_tracker.get());
-RETURN_IF_ERROR(channel->send_block(block_holder, eos));
+status = (*it)->send_block(block_holder, eos);
}
+if (status.is()) {
Review Comment:
```
if (status.is()) {
it = _handle_oef_channel(state, it, status);
continue;
}
```
the code repeat many time, better a function or #DEFINE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xiaokang commented on pull request #19843: [test](inverted index) add testcases for inverted index on different datatypes
xiaokang commented on PR #19843: URL: https://github.com/apache/doris/pull/19843#issuecomment-1554182599 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] anthony-yau opened a new issue, #19865: [Bug] Doris 1.2.4.1版本使用k8s部署，不能发现计算节点
anthony-yau opened a new issue, #19865: URL: https://github.com/apache/doris/issues/19865 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version 1.2.4.1 ### What's Wrong? fe yaml配置： ``` # Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The ASF licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, # software distributed under the License is distributed on an # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. apiVersion: v1 kind: Service metadata: name: doris-follower-cluster1 labels: app: doris-follower-cluster1 spec: ports: - port: 8030 name: http-port - port: 9020 name: rpc-port - port: 9030 name: query-port - port: 9010 name: edit-log-port #This name should be fixed. Doris will get the port information through this name clusterIP: None selector: app: doris-follower-cluster1 --- apiVersion: apps/v1 kind: StatefulSet metadata: name: doris-follower-cluster1 labels: app: doris-follower-cluster1 spec: selector: matchLabels: app: doris-follower-cluster1 serviceName: doris-follower-cluster1 replicas: 3 template: metadata: name: doris-follower-cluster1 labels: app: doris-follower-cluster1 spec: containers: - name: doris-follower-cluster1 #Need to change to real mirror information image: mirrors.aliyun.com/doris-fe:1.2.3 imagePullPolicy: IfNotPresent env: #Specify the startup type as k8s to bypass some restrictions of the official image initialization script - name: BUILD_TYPE value: "k8s" #Initialize the fe of three nodes - name: FE_INIT_NUMBER value: "3" #ServiceName of bakend_cn node,（if do not have bakend_cn node,do not configure this environment variable） - name: CN_SERVICE value: "doris-cn-cluster1" #StatefulSetName of bakend_cn node,（if do not have bakend_cn node,do not configure this environment variable) - name: CN_STATEFULSET value: "doris-cn-cluster1" #ServiceName of bakend node,（if do not have bakend node,do not configure this environment variable） - name: BE_SERVICE value: "doris-be-cluster1" #StatefulSetName of bakend node,（if do not have bakend node,do not configure this environment variable) - name: BE_STATEFULSET value: "doris-be-cluster1" #ServiceName of follower node,（if do not have follower node,do not configure this environment variable） - name: FE_SERVICE value: "doris-follower-cluster1" ##StatefulSetName of follower node,（if do not have follower node,do not configure this environment variable) - name: FE_STATEFULSET value: "doris-follower-cluster1" - name: APP_NAMESPACE valueFrom: fieldRef: fieldPath: metadata.namespace ports: - containerPort: 8030 name: http-port - containerPort: 9020 name: rpc-port - containerPort: 9030 name: query-port - containerPort: 9010 name: edit-log-port volumeMounts: #Mount the configuration file in the way of configmap - name: conf mountPath: /opt/apache-doris/fe/conf #In order to call the api of k8s - name: kube mountPath: /root/.kube/config readOnly: true volumes: - name: conf configMap: name: follower-conf - name: kube hostPath: path: /root/.kube/config --- apiVersion: v1 kind: ConfigMap metadata: name: follower-conf data: fe.conf: | # priority_networks = 172.16.0.0/24 #It can automatica
[GitHub] [doris] freemandealer opened a new issue, #19866: [Enhancement] show segcompaction info in load profile
freemandealer opened a new issue, #19866: URL: https://github.com/apache/doris/issues/19866 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description we need show segcompaction[^1][^2] related segment num & time cost information in load profile. 1) BetaRowsetWriter::_num_segcompacted、_num_segment 2) wait_flying_segcompaction wait time [1] https://github.com/apache/doris/pull/12866 [2] https://doris.apache.org/zh-CN/docs/dev/advanced/best-practice/compaction?#segment-compaction ### Solution _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19825: [Fix](planner)fix type incompatible after fold constant by be on 1.2
github-actions[bot] commented on PR #19825: URL: https://github.com/apache/doris/pull/19825#issuecomment-1554188684 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19825: [Fix](planner)fix type incompatible after fold constant by be on 1.2
github-actions[bot] commented on PR #19825: URL: https://github.com/apache/doris/pull/19825#issuecomment-1554188715 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] nextdreamblue commented on pull request #19326: [feature-wip](duplicate-no-keys) schame change support for duplicate no keys
nextdreamblue commented on PR #19326: URL: https://github.com/apache/doris/pull/19326#issuecomment-1554189074 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zclllyybb opened a new pull request, #19867: [fix](regression-test) Move big testcase of string length limit from p1 to p2
zclllyybb opened a new pull request, #19867: URL: https://github.com/apache/doris/pull/19867 # Proposed changes Issue Number: partly close DORIS-4566 ## Problem summary case of "test_string_concat_extremely_long_string" will exceed our test limit. Move it to p2 so that it will be tested only in SelectDB test environment. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [x] Has document been added or modified * [ ] Does it need to update dependencies * [x] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zclllyybb commented on pull request #19867: [fix](regression-test) Move big testcase of string length limit from p1 to p2
zclllyybb commented on PR #19867: URL: https://github.com/apache/doris/pull/19867#issuecomment-1554189824 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wangbo commented on pull request #19659: [test](executor)add crud regression test for resource group
wangbo commented on PR #19659: URL: https://github.com/apache/doris/pull/19659#issuecomment-1554201915 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] qidaye opened a new pull request, #19868: [opt](compaction) add pick rowset to compact interval config
qidaye opened a new pull request, #19868: URL: https://github.com/apache/doris/pull/19868 # Proposed changes Make pick rowset to compact interval configurable. ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Jibing-Li commented on pull request #19816: [Fix](multi catalog)Change all partition names to lower case.
Jibing-Li commented on PR #19816: URL: https://github.com/apache/doris/pull/19816#issuecomment-1554204755 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] CalvinKirs commented on pull request #19834: [refactor](routineload)Refactored routineload to improve scalability
CalvinKirs commented on PR #19834: URL: https://github.com/apache/doris/pull/19834#issuecomment-1554205801 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19868: [opt](compaction) add pick rowset to compact interval config
github-actions[bot] commented on PR #19868: URL: https://github.com/apache/doris/pull/19868#issuecomment-1554208213 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19868: [opt](compaction) add pick rowset to compact interval config
github-actions[bot] commented on PR #19868: URL: https://github.com/apache/doris/pull/19868#issuecomment-1554212281 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19758: [refactor](exec) replace the single pointer with an array of 'conjuncts' in ExecNode
github-actions[bot] commented on PR #19758: URL: https://github.com/apache/doris/pull/19758#issuecomment-1554212254 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] qidaye opened a new pull request, #19869: [opt](balance) add config balance_slot_num_per_path
qidaye opened a new pull request, #19869: URL: https://github.com/apache/doris/pull/19869 # Proposed changes Make balance_slot_num_per_path configurable. ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #19870: [Bug](function) make VcompoundPred optimization work well
BiteThet opened a new pull request, #19870: URL: https://github.com/apache/doris/pull/19870 # Proposed changes make VcompoundPred optimization work well https://github.com/apache/doris/pull/19818 this pr try to enable VcompoundPred optimization but get wrong result on tpcds q28. The reason is some nullable logic on mysql need special handling. ```sql mysql [regression_test_tpcds_sf1_p1]>select null and false; ++ | NULL AND FALSE | ++ | 0 | ++ 1 row in set (0.00 sec) mysql [regression_test_tpcds_sf1_p1]>select null and true; +---+ | NULL AND TRUE | +---+ | NULL | +---+ 1 row in set (0.00 sec) mysql [regression_test_tpcds_sf1_p1]>select null or false; +---+ | NULL OR FALSE | +---+ | NULL | +---+ 1 row in set (0.00 sec) mysql [regression_test_tpcds_sf1_p1]>select null or true; +--+ | NULL OR TRUE | +--+ |1 | +--+ 1 row in set (0.00 sec) ``` ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #19870: [Bug](function) make VcompoundPred optimization work well
BiteThet commented on PR #19870: URL: https://github.com/apache/doris/pull/19870#issuecomment-1554221815 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] catpineapple opened a new pull request, #19871: [doc](fix) update format create table doc and add multi partition by number
catpineapple opened a new pull request, #19871: URL: https://github.com/apache/doris/pull/19871 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19870: [Bug](function) make VcompoundPred optimization work well
github-actions[bot] commented on PR #19870: URL: https://github.com/apache/doris/pull/19870#issuecomment-1554226275 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wangbo commented on a diff in pull request #19802: [feature-wip](resouce-group) Supports memory soft isolation of resource group
wangbo commented on code in PR #19802: URL: https://github.com/apache/doris/pull/19802#discussion_r1198691779 ## be/src/runtime/memory/mem_tracker_limiter.cpp: ## @@ -487,21 +487,14 @@ int64_t MemTrackerLimiter::free_top_overcommit_query( } int64_t MemTrackerLimiter::tg_memory_limit_gc( Review Comment: tg_hard_memory_limit_gc -> memory_limit_gc -> tg_memory_limit_gc But free_top_memory_query is also called in this method. It seems that we just need to free_top_overcommit_query here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] niebayes commented on issue #19866: [Enhancement] show segcompaction info in load profile
niebayes commented on issue #19866: URL: https://github.com/apache/doris/issues/19866#issuecomment-1554229446 Please assign this me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #19758: [refactor](exec) replace the single pointer with an array of 'conjuncts' in ExecNode
mrhhsg commented on PR #19758: URL: https://github.com/apache/doris/pull/19758#issuecomment-1554229813 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #18803: [opt](nereids)runtime filter resize
morrySnow commented on PR #18803: URL: https://github.com/apache/doris/pull/18803#issuecomment-1554234954 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Gabriel39 commented on pull request #19806: [decimalv3](function) support function width_bucket
Gabriel39 commented on PR #19806: URL: https://github.com/apache/doris/pull/19806#issuecomment-1554237718 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19806: [decimalv3](function) support function width_bucket
github-actions[bot] commented on PR #19806: URL: https://github.com/apache/doris/pull/19806#issuecomment-1554239542 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19861: [Bug](decimal) fix variance_samp and avg_weighted
github-actions[bot] commented on PR #19861: URL: https://github.com/apache/doris/pull/19861#issuecomment-1554241482 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19861: [Bug](decimal) fix variance_samp and avg_weighted
github-actions[bot] commented on PR #19861: URL: https://github.com/apache/doris/pull/19861#issuecomment-1554241520 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #19860: [improvement](conf)Add an example of directly specifying an IP address
yiguolei merged PR #19860: URL: https://github.com/apache/doris/pull/19860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (65807f888b -> 514be8def1)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 65807f888b [fix](memory) Remind log if `vm/overcommit_memory`=2 when be start (#19795) add 514be8def1 [improvement](conf)Add an example of directly specifying an IP address #19860 No new revisions were added by this update. Summary of changes: conf/be.conf | 2 +- conf/fe.conf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] amorynan commented on pull request #19830: [Improve](complex-type)improve array/map/struct creating and function with decimalv3
amorynan commented on PR #19830: URL: https://github.com/apache/doris/pull/19830#issuecomment-1554243846 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Error while running github feature from .asf.yaml in doris!
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators, please contact vp-in...@apache.org to request an exception. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #19857: [fix](Nereids) drop table before create table in window function test
yiguolei merged PR #19857: URL: https://github.com/apache/doris/pull/19857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Yulei-Yang commented on pull request #19540: [Improvement](planner) expand sql-block-rule to make it can be used on all kinds of sql stmt
Yulei-Yang commented on PR #19540: URL: https://github.com/apache/doris/pull/19540#issuecomment-1554244168 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (514be8def1 -> 24de75757d)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 514be8def1 [improvement](conf)Add an example of directly specifying an IP address #19860 add 24de75757d [fix](Nereids) drop table before create table in window function test (#19857) No new revisions were added by this update. Summary of changes: regression-test/suites/nereids_syntax_p0/window_function.groovy | 4 1 file changed, 4 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Error while running github feature from .asf.yaml in doris!
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators, please contact vp-in...@apache.org to request an exception. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #19861: [Bug](decimal) fix variance_samp and avg_weighted
yiguolei merged PR #19861: URL: https://github.com/apache/doris/pull/19861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (24de75757d -> 0fc8d2e029)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 24de75757d [fix](Nereids) drop table before create table in window function test (#19857) add 0fc8d2e029 [Bug](decimal) fix variance_samp and avg_weighted #19861 No new revisions were added by this update. Summary of changes: .../java/org/apache/doris/analysis/FunctionCallExpr.java| 13 - 1 file changed, 8 insertions(+), 5 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Error while running github feature from .asf.yaml in doris!
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators, please contact vp-in...@apache.org to request an exception. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #19854: [feature-wip](MTMV) support multi catalog
yiguolei merged PR #19854: URL: https://github.com/apache/doris/pull/19854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (0fc8d2e029 -> 2ab844550f)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 0fc8d2e029 [Bug](decimal) fix variance_samp and avg_weighted #19861 add 2ab844550f [feature-wip](MTMV) support multi catalog (#19854) No new revisions were added by this update. Summary of changes: .../doris/alter/MaterializedViewHandler.java | 7 ++-- .../apache/doris/analysis/ColumnPartitionDesc.java | 7 ++-- .../CreateMultiTableMaterializedViewStmt.java | 48 ++ 3 files changed, 38 insertions(+), 24 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Error while running github feature from .asf.yaml in doris!
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators, please contact vp-in...@apache.org to request an exception. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19594: [refactor](dynamic table) Make segment_writer unaware of dynamic schema, and ensure parsing is exception-safe.
github-actions[bot] commented on PR #19594: URL: https://github.com/apache/doris/pull/19594#issuecomment-1554250395 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener opened a new pull request, #19873: [enhance](Nereids): Pushdown Filter Through Project in Post Processor.
jackwener opened a new pull request, #19873: URL: https://github.com/apache/doris/pull/19873 # Proposed changes Issue Number: close #xxx ## Problem summary Originally, `Pushdown Filter Through Project` is in CBO phase, but it will increase Memo size. So, we handle it in PostProcessor ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19871: [doc](fix) update format create table doc and add multi partition by number
github-actions[bot] commented on PR #19871: URL: https://github.com/apache/doris/pull/19871#issuecomment-1554255090 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener commented on pull request #19873: [enhance](Nereids): Pushdown Filter Through Project in Post Processor.
jackwener commented on PR #19873: URL: https://github.com/apache/doris/pull/19873#issuecomment-1554255546 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #19847: [improvement](exchange) data stream sender stop sending data to receiver if it returns eos early
HappenLee commented on code in PR #19847:
URL: https://github.com/apache/doris/pull/19847#discussion_r1198716937
##
be/src/vec/sink/vdata_stream_sender.h:
##
@@ -403,9 +423,23 @@ Status VDataStreamSender::channel_add_rows(Channels&
channels, int num_channels,
channel2rows[channel_ids[i]].emplace_back(i);
}
+Status status;
for (int i = 0; i < num_channels; ++i) {
if (!channel2rows[i].empty()) {
-RETURN_IF_ERROR(channels[i]->add_rows(block, channel2rows[i]));
+status = channels[i]->add_rows(block, channel2rows[i]);
+if (status.is()) {
+channels[i]->set_receiver_eof(status);
+continue;
+}
+RETURN_IF_ERROR(status);
+}
+}
+for (auto it = channels.begin(); it != channels.end();) {
+if ((*it)->receiver_status().template is()) {
+(*it)->close(_state);
+it = channels.erase(it);
Review Comment:
erase the channel may cause the parttion get error result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yuanyuan8983 opened a new pull request, #19874: [typo](docs) Modify the jdk version requirements in the documentation
yuanyuan8983 opened a new pull request, #19874: URL: https://github.com/apache/doris/pull/19874 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19852: [Doc](point query) Modify the document to add constraints and limitat…
github-actions[bot] commented on PR #19852: URL: https://github.com/apache/doris/pull/19852#issuecomment-1554260897 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wangbo commented on a diff in pull request #19802: [feature-wip](resouce-group) Supports memory soft isolation of resource group
wangbo commented on code in PR #19802:
URL: https://github.com/apache/doris/pull/19802#discussion_r1198723250
##
be/src/util/mem_info.cpp:
##
@@ -215,6 +221,52 @@ bool MemInfo::process_full_gc() {
return false;
}
+int64_t MemInfo::tg_hard_memory_limit_gc() {
+std::vector task_groups;
+taskgroup::TaskGroupManager::instance()->get_resource_groups(
+[](const taskgroup::TaskGroupPtr& task_group) {
+return !task_group->enable_overcommit();
+},
+&task_groups);
+
+int64_t total_free_memory = 0;
+for (const auto& task_group : task_groups) {
+total_free_memory += task_group->memory_limit_gc();
+}
+return total_free_memory;
Review Comment:
```suggestion
[memory_limit, name, used] list;
for (const auto& task_group : task_groups) {
list->add(task_group->get_info());
}
MemTrackerLimiter::tg_memory_limit_gc(list);
return total_free_memory;
```
1 get needed info from TaskGroup;
2 call tg_memory_limit_gc in mem_info;
Maybe it's more clear;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wangbo commented on a diff in pull request #19802: [feature-wip](resouce-group) Supports memory soft isolation of resource group
wangbo commented on code in PR #19802:
URL: https://github.com/apache/doris/pull/19802#discussion_r1198723250
##
be/src/util/mem_info.cpp:
##
@@ -215,6 +221,52 @@ bool MemInfo::process_full_gc() {
return false;
}
+int64_t MemInfo::tg_hard_memory_limit_gc() {
+std::vector task_groups;
+taskgroup::TaskGroupManager::instance()->get_resource_groups(
+[](const taskgroup::TaskGroupPtr& task_group) {
+return !task_group->enable_overcommit();
+},
+&task_groups);
+
+int64_t total_free_memory = 0;
+for (const auto& task_group : task_groups) {
+total_free_memory += task_group->memory_limit_gc();
+}
+return total_free_memory;
Review Comment:
```
[memory_limit, name, used] list;
for (const auto& task_group : task_groups) {
list->add(task_group->get_info());
}
MemTrackerLimiter::tg_memory_limit_gc(list);
```
1 get needed info from TaskGroup;
2 call tg_memory_limit_gc in mem_info;
Maybe it's more clear;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19874: [typo](docs) Modify the jdk version requirements in the documentation
github-actions[bot] commented on PR #19874: URL: https://github.com/apache/doris/pull/19874#issuecomment-1554264345 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19874: [typo](docs) Modify the jdk version requirements in the documentation
github-actions[bot] commented on PR #19874: URL: https://github.com/apache/doris/pull/19874#issuecomment-1554264407 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname commented on pull request #18869: [Feature](Nereids)support insert into select.
sohardforaname commented on PR #18869: URL: https://github.com/apache/doris/pull/18869#issuecomment-1554265033 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zy-kkk closed issue #19739: [Enhancement] statement error in data-model.md
zy-kkk closed issue #19739: [Enhancement] statement error in data-model.md URL: https://github.com/apache/doris/issues/19739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19852: [Doc](point query) Modify the document to add constraints and limitat…
github-actions[bot] commented on PR #19852: URL: https://github.com/apache/doris/pull/19852#issuecomment-1554273338 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #19859: [chore](build) Fix the compilation errors on macOS (arm64)
adonis0147 commented on PR #19859: URL: https://github.com/apache/doris/pull/19859#issuecomment-1554275391 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19594: [refactor](dynamic table) Make segment_writer unaware of dynamic schema, and ensure parsing is exception-safe.
github-actions[bot] commented on PR #19594: URL: https://github.com/apache/doris/pull/19594#issuecomment-1554276900 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19871: [doc](fix) update format create table doc and add multi partition by number
github-actions[bot] commented on PR #19871: URL: https://github.com/apache/doris/pull/19871#issuecomment-1554277925 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] caoliang-web opened a new pull request, #19875: [typo](doc)Modify the usage of Doriswriter parameters
caoliang-web opened a new pull request, #19875: URL: https://github.com/apache/doris/pull/19875 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19858: [Improvement](Cache) lru support evict expired entries
github-actions[bot] commented on PR #19858: URL: https://github.com/apache/doris/pull/19858#issuecomment-1554285637 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hqx871 commented on pull request #19858: [Improvement](Cache) lru support evict expired entries
hqx871 commented on PR #19858: URL: https://github.com/apache/doris/pull/19858#issuecomment-1554288004 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hf200012 merged pull request #19852: [Doc](point query) Modify the document to add constraints and limitat…
hf200012 merged PR #19852: URL: https://github.com/apache/doris/pull/19852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (2ab844550f -> d8d6880ef1)
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 2ab844550f [feature-wip](MTMV) support multi catalog (#19854) add d8d6880ef1 [Doc](point query) Modify the document to add constraints and limitations for optimizing high-concurrency point queries. (#19852) No new revisions were added by this update. Summary of changes: docs/en/docs/query-acceleration/hight-concurrent-point-query.md| 2 ++ docs/zh-CN/docs/query-acceleration/hight-concurrent-point-query.md | 1 + 2 files changed, 3 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Error while running github feature from .asf.yaml in doris!
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators, please contact vp-in...@apache.org to request an exception. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19681: [Enhancement](catalog) paimon catalog
github-actions[bot] commented on PR #19681: URL: https://github.com/apache/doris/pull/19681#issuecomment-1554298534 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Gabriel39 commented on pull request #19641: [DRAFT](decimalv3) test auto conversion
Gabriel39 commented on PR #19641: URL: https://github.com/apache/doris/pull/19641#issuecomment-1554299652 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19802: [feature-wip](resouce-group) Supports memory soft isolation of resource group
github-actions[bot] commented on PR #19802: URL: https://github.com/apache/doris/pull/19802#issuecomment-1554299484 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname commented on pull request #19863: [Fix](Nereids)fix nereids fold constant bug on functions relative to timezone
sohardforaname commented on PR #19863: URL: https://github.com/apache/doris/pull/19863#issuecomment-1554301238 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19641: [DRAFT](decimalv3) test auto conversion
github-actions[bot] commented on PR #19641: URL: https://github.com/apache/doris/pull/19641#issuecomment-1554301677 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19830: [Improve](complex-type)improve array/map/struct creating and function with decimalv3
github-actions[bot] commented on PR #19830: URL: https://github.com/apache/doris/pull/19830#issuecomment-1554303270 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19830: [Improve](complex-type)improve array/map/struct creating and function with decimalv3
github-actions[bot] commented on PR #19830: URL: https://github.com/apache/doris/pull/19830#issuecomment-1554303311 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19099: [performance](stream-load) use vector instead of skiplist when insert agg keys
github-actions[bot] commented on PR #19099: URL: https://github.com/apache/doris/pull/19099#issuecomment-1554304747 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wsjz commented on a diff in pull request #19681: [Enhancement](catalog) paimon catalog
wsjz commented on code in PR #19681:
URL: https://github.com/apache/doris/pull/19681#discussion_r1198757265
##
be/src/vec/exec/scan/vfile_scanner.cpp:
##
@@ -641,6 +642,14 @@ Status VFileScanner::_get_next_reader() {
init_status = ((NewJsonReader*)(_cur_reader.get()))->init_reader();
break;
}
+case TFileFormatType::FORMAT_JNI: {
+// test
+LOG(INFO) << "FORMAT_JNI ";
+_cur_reader = PaimonJniReader::create_unique(_file_slot_descs,
_state, _profile, range);
Review Comment:
JNI type is not only paimon, can you judge this in any other way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yuxuan-luo commented on a diff in pull request #19681: [Enhancement](catalog) paimon catalog
yuxuan-luo commented on code in PR #19681:
URL: https://github.com/apache/doris/pull/19681#discussion_r1198757150
##
fe/fe-core/src/main/java/org/apache/doris/datasource/paimon/PaimonHMSExternalCatalog.java:
##
@@ -0,0 +1,165 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.datasource.paimon;
+
+import org.apache.doris.datasource.CatalogProperty;
+import org.apache.doris.datasource.property.PropertyConverter;
+import org.apache.doris.datasource.property.constants.HMSProperties;
+import org.apache.doris.datasource.property.constants.PaimonProperties;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.paimon.catalog.Catalog;
+import org.apache.paimon.catalog.CatalogContext;
+import org.apache.paimon.fs.FileIO;
+import org.apache.paimon.fs.Path;
+import org.apache.paimon.hive.HiveCatalog;
+import org.apache.paimon.hive.HiveCatalogOptions;
+import org.apache.paimon.options.CatalogOptions;
+import org.apache.paimon.options.ConfigOption;
+import org.apache.paimon.options.ConfigOptions;
+import org.apache.paimon.options.Options;
+import org.apache.paimon.utils.StringUtils;
+
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.URL;
+import java.util.Map;
+import javax.annotation.Nullable;
+
+
+
+
+public class PaimonHMSExternalCatalog extends PaimonExternalCatalog {
+
+private static final ConfigOption METASTORE_CLIENT_CLASS =
+ConfigOptions.key("metastore.client.class")
+.stringType()
+
.defaultValue("org.apache.hadoop.hive.metastore.HiveMetaStoreClient")
+.withDescription(
+"Class name of Hive metastore client.\n"
++ "NOTE: This class must directly implements "
++ "org.apache.hadoop.hive.metastore.IMetaStoreClient.");
+
+public PaimonHMSExternalCatalog(long catalogId, String name, String
resource, Map props) {
+super(catalogId, name);
+props = PropertyConverter.convertToMetaProperties(props);
+catalogProperty = new CatalogProperty(resource, props);
+}
+
+@Override
+protected void initLocalObjectsImpl() {
+paimonCatalogType = PAIMON_HMS;
+String metastoreUris =
catalogProperty.getOrDefault(HMSProperties.HIVE_METASTORE_URIS, "");
+String warehouse =
catalogProperty.getOrDefault(PaimonProperties.PAIMON_WAREHOUSE, "");
+Options options = new Options();
+options.set(PaimonProperties.WAREHOUSE, warehouse);
+// Currently, only supports hive
+options.set(PaimonProperties.METASTORE,
PaimonProperties.METASTORE_HIVE);
+options.set(PaimonProperties.URI, metastoreUris);
+CatalogContext context = CatalogContext.create(options,
getConfiguration());
+try {
+catalog = create(context);
+} catch (IOException e) {
+e.printStackTrace();
+}
+}
+
+public Catalog create(CatalogContext context) throws IOException {
+Path warehousePath = new
Path(context.options().get(CatalogOptions.WAREHOUSE));
+FileIO fileIO;
+fileIO = FileIO.get(warehousePath, context);
+String uri = context.options().get(CatalogOptions.URI);
+String hiveConfDir =
context.options().get(HiveCatalogOptions.HIVE_CONF_DIR);
+String hadoopConfDir =
context.options().get(HiveCatalogOptions.HADOOP_CONF_DIR);
+HiveConf hiveConf = createHiveConf(hiveConfDir, hadoopConfDir);
+
+// always using user-set parameters overwrite hive-site.xml parameters
+context.options().toMap().forEach(hiveConf::set);
+hiveConf.set(HiveConf.ConfVars.METASTOREURIS.varname, uri);
+// set the warehouse location to the hiveConf
+hiveConf.set(HiveConf.ConfVars.METASTOREWAREHOUSE.varname,
context.options().get(CatalogOptions.WAREHOUSE));
+
+String clientClassName = context.options().get(METASTORE_CLIENT_CLASS);
+
+return new HiveCatalog(fileIO, hiveConf, clientClassName,
context.options().toMap());
+}
+
+public static HiveConf createHiveConf(@Nullable String h
