[GitHub] [doris] XieJiann opened a new pull request, #15479: fix colocate join
XieJiann opened a new pull request, #15479: URL: https://github.com/apache/doris/pull/15479 Signed-off-by: xiejiann # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #15458: [chore](thirdparty) Support cleaning extracted data before building them
morningman merged PR #15458: URL: https://github.com/apache/doris/pull/15458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15458: [chore](thirdparty) Support cleaning extracted data before building them
github-actions[bot] commented on PR #15458: URL: https://github.com/apache/doris/pull/15458#issuecomment-1367137798 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Error while running github feature from .asf.yaml in doris!
An error occurred while running github feature in .asf.yaml!:
422 {"message": "Validation Failed", "errors": ["A repository cannot have more
than 20 topics."], "documentation_url":
"https://docs.github.com/rest/reference/repos#replace-all-repository-topics"}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (c22ba8e160 -> 43c8e7b465)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from c22ba8e160 [Bug](Decimalv3) coredump of decimalv3 multiply (#15452) add 43c8e7b465 [chore](thirdparty) Support cleaning extracted data before building them (#15458) No new revisions were added by this update. Summary of changes: thirdparty/build-thirdparty.sh | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15458: [chore](thirdparty) Support cleaning extracted data before building them
github-actions[bot] commented on PR #15458: URL: https://github.com/apache/doris/pull/15458#issuecomment-1367137828 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15303: [vectorized](jdbc) support array type in jdbc external table
github-actions[bot] commented on PR #15303: URL: https://github.com/apache/doris/pull/15303#issuecomment-1367138093 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15303: [vectorized](jdbc) support array type in jdbc external table
github-actions[bot] commented on PR #15303: URL: https://github.com/apache/doris/pull/15303#issuecomment-1367138121 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] pengxiangyu commented on a diff in pull request #15418: [feature-wip](multi-catalog) support Iceberg time travel in external table
pengxiangyu commented on code in PR #15418:
URL: https://github.com/apache/doris/pull/15418#discussion_r1058792961
##
fe/fe-core/src/main/cup/sql_parser.cup:
##
@@ -5095,9 +5098,31 @@ base_table_ref_list ::=
;
base_table_ref ::=
-table_name:name opt_partition_names:partitionNames
opt_tablet_list:tabletIds opt_table_alias:alias opt_table_sample:tableSample
opt_common_hints:commonHints
+table_name:name opt_snapshot_version:snapshotVersion
opt_partition_names:partitionNames opt_tablet_list:tabletIds
opt_table_alias:alias opt_table_sample:tableSample opt_common_hints:commonHints
{:
-RESULT = new TableRef(name, alias, partitionNames, tabletIds,
tableSample, commonHints);
+RESULT = new TableRef(name, alias, partitionNames, tabletIds,
tableSample, commonHints, snapshotVersion);
+:}
+;
+
+opt_snapshot_version ::=
+/* empty */
+{:
+RESULT = null;
+:}
+| snapshot_version:snapshotVersion
+{:
+RESULT = snapshotVersion;
+:}
+;
+
+snapshot_version ::=
Review Comment:
external_table_snapshot is better, it contains not only version, but also
time,
##
fe/fe-core/src/main/java/org/apache/doris/analysis/BaseTableRef.java:
##
@@ -70,6 +70,7 @@ public void analyze(Analyzer analyzer) throws UserException {
name.analyze(analyzer);
desc = analyzer.registerTableRef(this);
isAnalyzed = true; // true that we have assigned desc
+analyzeSnapshotVersion(analyzer);
Review Comment:
It is better to be analyzeExternalTable(analyzer),
analyzeSnapshotVersion(analyzer) is better in this function.
So that you can deal with all external table options in this function in the
furture.
##
fe/fe-core/src/main/java/org/apache/doris/analysis/SnapshotVersion.java:
##
@@ -0,0 +1,66 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
+
+public class SnapshotVersion {
Review Comment:
May be ExternalTableSnapshot is better, it doesn't only contain version, but
also time.
##
fe/fe-core/src/main/java/org/apache/doris/analysis/SnapshotVersion.java:
##
@@ -0,0 +1,66 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
Review Comment:
package org.apache.doris.analysis.external;
external table has more syntax, it will be too many in package:
org.apache.doris.analysis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] spaces-X opened a new pull request, #15480: [Fix](SparkLoad): fix the timeout aborted loadtasks are not cleaned up.
spaces-X opened a new pull request, #15480: URL: https://github.com/apache/doris/pull/15480 # Proposed changes close #15446 ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15442: [fix](icebergv2)update icebergv2 regression case
github-actions[bot] commented on PR #15442: URL: https://github.com/apache/doris/pull/15442#issuecomment-1367139643 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15442: [fix](icebergv2)update icebergv2 regression case
github-actions[bot] commented on PR #15442: URL: https://github.com/apache/doris/pull/15442#issuecomment-1367139671 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15467: [fix](nereids)the project node is lost when creating PhysicalStorageLayerAggregate node
hello-stephen commented on PR #15467: URL: https://github.com/apache/doris/pull/15467#issuecomment-1367139810 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 36.67 seconds load time: 687 seconds storage size: 17123255172 Bytes https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221229080453_clickbench_pr_70768.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15448: [Broker](bos) support baidu bos object storage file system for broker
github-actions[bot] commented on PR #15448: URL: https://github.com/apache/doris/pull/15448#issuecomment-1367140875 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15448: [Broker](bos) support baidu bos object storage file system for broker
github-actions[bot] commented on PR #15448: URL: https://github.com/apache/doris/pull/15448#issuecomment-1367140896 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15444: [Fix](storage) Fix bug that cooldown time for partition in SSD is wrong
github-actions[bot] commented on PR #15444: URL: https://github.com/apache/doris/pull/15444#issuecomment-1367142965 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15444: [Fix](storage) Fix bug that cooldown time for partition in SSD is wrong
github-actions[bot] commented on PR #15444: URL: https://github.com/apache/doris/pull/15444#issuecomment-1367142991 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #15463: [Improvement](decimalv3) Add a config to check overflow for DECIMALV3
HappenLee commented on code in PR #15463:
URL: https://github.com/apache/doris/pull/15463#discussion_r1058800717
##
fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java:
##
@@ -2036,6 +2038,27 @@ private boolean customNullableAlgorithm() {
if (fn.functionName().equalsIgnoreCase("concat_ws")) {
return children.get(0).isNullable();
}
+if (fn.functionName().equalsIgnoreCase(Operator.MULTIPLY.getName())
+&& fn.getReturnType().isDecimalV3()) {
+if ((children.get(0).getType().getPrecision() +
children.get(1).getType().getPrecision()
+> ScalarType.MAX_PRECISION ||
!children.get(0).getType().isDecimalV3()
+|| !children.get(1).getType().isDecimalV3()) &&
ConnectContext.get() != null
+&&
ConnectContext.get().getSessionVariable().checkOverflowForDecimal()) {
+return true;
Review Comment:
make sure the nullable type return same as BE，maybe coredump here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] liaoxin01 opened a new pull request, #15481: [fix](index) fix that the last element of each batch will be read repeatedly for binary prefix page
liaoxin01 opened a new pull request, #15481: URL: https://github.com/apache/doris/pull/15481 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] nextdreamblue commented on pull request #14722: [fix](vec) VMergeIterator add key same label for agg table
nextdreamblue commented on PR #14722: URL: https://github.com/apache/doris/pull/14722#issuecomment-1367155194 > What if we let MergeIterator calculate Agg and provide CollectIterator with aggragated result? feel it more complicated than this pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15481: [fix](index) fix that the last element of each batch will be read repeatedly for binary prefix page
github-actions[bot] commented on PR #15481: URL: https://github.com/apache/doris/pull/15481#issuecomment-1367156124 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wsjz commented on a diff in pull request #15418: [feature-wip](multi-catalog) support Iceberg time travel in external table
wsjz commented on code in PR #15418:
URL: https://github.com/apache/doris/pull/15418#discussion_r1058814877
##
fe/fe-core/src/main/cup/sql_parser.cup:
##
@@ -5095,9 +5098,31 @@ base_table_ref_list ::=
;
base_table_ref ::=
-table_name:name opt_partition_names:partitionNames
opt_tablet_list:tabletIds opt_table_alias:alias opt_table_sample:tableSample
opt_common_hints:commonHints
+table_name:name opt_snapshot_version:snapshotVersion
opt_partition_names:partitionNames opt_tablet_list:tabletIds
opt_table_alias:alias opt_table_sample:tableSample opt_common_hints:commonHints
{:
-RESULT = new TableRef(name, alias, partitionNames, tabletIds,
tableSample, commonHints);
+RESULT = new TableRef(name, alias, partitionNames, tabletIds,
tableSample, commonHints, snapshotVersion);
+:}
+;
+
+opt_snapshot_version ::=
+/* empty */
+{:
+RESULT = null;
+:}
+| snapshot_version:snapshotVersion
+{:
+RESULT = snapshotVersion;
+:}
+;
+
+snapshot_version ::=
Review Comment:
it maybe not only external table support time travel in the future
but indeed need change the name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wsjz commented on a diff in pull request #15418: [feature-wip](multi-catalog) support Iceberg time travel in external table
wsjz commented on code in PR #15418:
URL: https://github.com/apache/doris/pull/15418#discussion_r1058814877
##
fe/fe-core/src/main/cup/sql_parser.cup:
##
@@ -5095,9 +5098,31 @@ base_table_ref_list ::=
;
base_table_ref ::=
-table_name:name opt_partition_names:partitionNames
opt_tablet_list:tabletIds opt_table_alias:alias opt_table_sample:tableSample
opt_common_hints:commonHints
+table_name:name opt_snapshot_version:snapshotVersion
opt_partition_names:partitionNames opt_tablet_list:tabletIds
opt_table_alias:alias opt_table_sample:tableSample opt_common_hints:commonHints
{:
-RESULT = new TableRef(name, alias, partitionNames, tabletIds,
tableSample, commonHints);
+RESULT = new TableRef(name, alias, partitionNames, tabletIds,
tableSample, commonHints, snapshotVersion);
+:}
+;
+
+opt_snapshot_version ::=
+/* empty */
+{:
+RESULT = null;
+:}
+| snapshot_version:snapshotVersion
+{:
+RESULT = snapshotVersion;
+:}
+;
+
+snapshot_version ::=
Review Comment:
it maybe not only external table support time travel in the future
but indeed need change the name, I will use table_snapshot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wsjz commented on a diff in pull request #15418: [feature-wip](multi-catalog) support Iceberg time travel in external table
wsjz commented on code in PR #15418:
URL: https://github.com/apache/doris/pull/15418#discussion_r1058816085
##
fe/fe-core/src/main/java/org/apache/doris/analysis/BaseTableRef.java:
##
@@ -70,6 +70,7 @@ public void analyze(Analyzer analyzer) throws UserException {
name.analyze(analyzer);
desc = analyzer.registerTableRef(this);
isAnalyzed = true; // true that we have assigned desc
+analyzeSnapshotVersion(analyzer);
Review Comment:
olap table maybe support snapshot read for time travel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wsjz commented on a diff in pull request #15418: [feature-wip](multi-catalog) support Iceberg time travel in external table
wsjz commented on code in PR #15418: URL: https://github.com/apache/doris/pull/15418#discussion_r1058816217 ## fe/fe-core/src/main/java/org/apache/doris/analysis/SnapshotVersion.java: ## @@ -0,0 +1,66 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.analysis; Review Comment: olap table maybe support snapshot read for time travel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wsjz commented on a diff in pull request #15418: [feature-wip](multi-catalog) support Iceberg time travel in external table
wsjz commented on code in PR #15418:
URL: https://github.com/apache/doris/pull/15418#discussion_r1058816289
##
fe/fe-core/src/main/java/org/apache/doris/analysis/SnapshotVersion.java:
##
@@ -0,0 +1,66 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
+
+public class SnapshotVersion {
Review Comment:
I will use TableSnapshot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15433: [chore](pipeline) optimize profile information
github-actions[bot] commented on PR #15433: URL: https://github.com/apache/doris/pull/15433#issuecomment-1367158954 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhangstar333 commented on a diff in pull request #14396: [Feature](function) Support width_bucket function
zhangstar333 commented on code in PR #14396:
URL: https://github.com/apache/doris/pull/14396#discussion_r1058818860
##
be/src/vec/functions/function_width_bucket.cpp:
##
@@ -0,0 +1,154 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "vec/columns/columns_number.h"
+#include "vec/data_types/data_type_nullable.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/functions/function.h"
+#include "vec/functions/function_helpers.h"
+#include "vec/functions/simple_function_factory.h"
+
+namespace doris::vectorized {
+class FunctionWidthBucket : public IFunction {
+public:
+static constexpr auto name = "width_bucket";
+static FunctionPtr create() { return
std::make_shared(); }
+
+/// Get function name.
+String get_name() const override { return name; }
+
+bool is_variadic() const override { return false; }
+
+size_t get_number_of_arguments() const override { return 4; }
+
+DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+if (arguments[0]->is_nullable()) {
+return make_nullable(std::make_shared());
+} else {
+return std::make_shared();
+}
+}
+
+Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+size_t result, size_t input_rows_count) override {
+ColumnPtr expr_ptr =
+
block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ColumnPtr min_value_ptr =
+
block.get_by_position(arguments[1]).column->convert_to_full_column_if_const();
+ColumnPtr max_value_ptr =
+
block.get_by_position(arguments[2]).column->convert_to_full_column_if_const();
+ColumnPtr num_buckets_ptr =
+
block.get_by_position(arguments[3]).column->convert_to_full_column_if_const();
+int64_t num_buckets = num_buckets_ptr->get_int(0);
+
+auto nested_column_ptr = ColumnInt64::create(input_rows_count, 0);
+DataTypePtr expr_type = block.get_by_position(arguments[0]).type;
+
+_execute_by_type(*expr_ptr, *min_value_ptr, *max_value_ptr,
num_buckets, *nested_column_ptr,
+ expr_type);
+
+WhichDataType which(remove_nullable(expr_type));
+if (which.is_nullable()) {
Review Comment:
see have remove nullable in 64 line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15469: [enhancement](fuzzy test) support fuzzy test of RewriteOrToInPredicateThreshold
hello-stephen commented on PR #15469: URL: https://github.com/apache/doris/pull/15469#issuecomment-1367161409 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 36.06 seconds load time: 646 seconds storage size: 17123626058 Bytes https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221229084816_clickbench_pr_70846.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wsjz commented on a diff in pull request #15418: [feature-wip](multi-catalog) support Iceberg time travel in external table
wsjz commented on code in PR #15418:
URL: https://github.com/apache/doris/pull/15418#discussion_r1058816085
##
fe/fe-core/src/main/java/org/apache/doris/analysis/BaseTableRef.java:
##
@@ -70,6 +70,7 @@ public void analyze(Analyzer analyzer) throws UserException {
name.analyze(analyzer);
desc = analyzer.registerTableRef(this);
isAnalyzed = true; // true that we have assigned desc
+analyzeSnapshotVersion(analyzer);
Review Comment:
olap table maybe support snapshot read for time travel
I change it to analyzeTableSnapshot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15212: [Feature](Materialized-View) support advanced Materialized-View
github-actions[bot] commented on PR #15212: URL: https://github.com/apache/doris/pull/15212#issuecomment-1367163863 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15433: [chore](pipeline) optimize profile information
github-actions[bot] commented on PR #15433: URL: https://github.com/apache/doris/pull/15433#issuecomment-1367164056 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15471: [fix](nereids)hll and bitmap type can't be used as order by and group by exprs
hello-stephen commented on PR #15471: URL: https://github.com/apache/doris/pull/15471#issuecomment-1367175654 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 36.16 seconds load time: 656 seconds storage size: 17123666954 Bytes https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221229091151_clickbench_pr_70840.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] smallhibiscus commented on pull request #15476: [fix] fix be coredump caused by nullable const in logical expr
smallhibiscus commented on PR #15476: URL: https://github.com/apache/doris/pull/15476#issuecomment-1367176306 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] MRYOG commented on issue #15472: [Bug] when where clause column type is bigint , value equal faild
MRYOG commented on issue #15472: URL: https://github.com/apache/doris/issues/15472#issuecomment-1367178015 sorry , the bug is doris web only show 28462147635660600 , realy value is 2846214763566060097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] MRYOG commented on issue #15472: [Bug] when where clause column type is bigint , value equal faild
MRYOG commented on issue #15472: URL: https://github.com/apache/doris/issues/15472#issuecomment-1367179127  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] MRYOG commented on issue #15472: [Bug] when where clause column type is bigint , value equal faild
MRYOG commented on issue #15472: URL: https://github.com/apache/doris/issues/15472#issuecomment-1367181789 same problem : https://github.com/apache/doris/issues/10313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] MRYOG closed issue #15472: [Bug] when where clause column type is bigint , value equal faild
MRYOG closed issue #15472: [Bug] when where clause column type is bigint , value equal faild URL: https://github.com/apache/doris/issues/15472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zddr closed pull request #15401: [WIP]support automatic sync hive metastore events
zddr closed pull request #15401: [WIP]support automatic sync hive metastore events URL: https://github.com/apache/doris/pull/15401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15441: [optimize](multi-catalog) use dictionary encode&filter to process delete files
github-actions[bot] commented on PR #15441: URL: https://github.com/apache/doris/pull/15441#issuecomment-1367191577 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14964: [Fix](Nereids)fix aggregation result error when child is empty relation
github-actions[bot] commented on PR #14964: URL: https://github.com/apache/doris/pull/14964#issuecomment-1367191735 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14964: [Fix](Nereids)fix aggregation result error when child is empty relation
github-actions[bot] commented on PR #14964: URL: https://github.com/apache/doris/pull/14964#issuecomment-1367191764 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wangbo commented on a diff in pull request #15480: [Fix](SparkLoad): fix the timeout aborted loadtasks are not cleaned up.
wangbo commented on code in PR #15480:
URL: https://github.com/apache/doris/pull/15480#discussion_r1058848092
##
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/SparkLoadJob.java:
##
@@ -695,6 +695,8 @@ private void clearJob() {
// clear job infos that not persist
sparkLoadAppHandle = null;
resourceDesc = null;
+etlOutputPath = "";
+appId = "";
Review Comment:
Why set empty string here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 opened a new pull request, #15482: [chore](badges) Remove daily test badges for origin engine
xy720 opened a new pull request, #15482: URL: https://github.com/apache/doris/pull/15482 # Proposed changes The code of origin engine will be remove later, we already stop the daily test for origin engine, so we should remove this badges from home page. ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [x] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [x] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [x] No Need 4. Does it need to update dependencies: - [ ] Yes - [x] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [x] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15473: [fix](nereids) translate agg-sort
github-actions[bot] commented on PR #15473: URL: https://github.com/apache/doris/pull/15473#issuecomment-1367198627 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15473: [fix](nereids) translate agg-sort
github-actions[bot] commented on PR #15473: URL: https://github.com/apache/doris/pull/15473#issuecomment-1367198607 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] 03/03: [chore](thirdparty) Support cleaning extracted data before building them (#15458)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
commit 5ce523852ab797b977fab3b40a2a6da184ba4991
Author: Adonis Ling
AuthorDate: Thu Dec 29 16:01:23 2022 +0800
[chore](thirdparty) Support cleaning extracted data before building them
(#15458)
Currently, we may fail to build the third-party libraries if we keep the
outdated extracted data.
Considering the following scenario, Bob added patches to some libraries and
Alice updates the codebase and builds
the third-party libraries. If Alice kept the outdated extracted data, she
should fail to build the third-party libraries
because the patches are not applied due to the outdated `patched_marks`.
This PR introduces a way to clean the outdated data before building the
third-party libraries.
---
thirdparty/build-thirdparty.sh | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/thirdparty/build-thirdparty.sh b/thirdparty/build-thirdparty.sh
index 45200bf7ce..6e64b89f5c 100755
--- a/thirdparty/build-thirdparty.sh
+++ b/thirdparty/build-thirdparty.sh
@@ -49,6 +49,7 @@ usage() {
Usage: $0
Optional options:
-j build thirdparty parallel
+ --cleanclean the extracted data
"
exit 1
}
@@ -58,6 +59,7 @@ if ! OPTS="$(getopt \
-o '' \
-o 'h' \
-l 'help' \
+-l 'clean' \
-o 'j:' \
-- "$@")"; then
usage
@@ -88,6 +90,10 @@ if [[ "$#" -ne 1 ]]; then
HELP=1
shift
;;
+--clean)
+CLEAN=1
+shift
+;;
--)
shift
break
@@ -102,11 +108,11 @@ fi
if [[ "${HELP}" -eq 1 ]]; then
usage
-exit
fi
echo "Get params:
PARALLEL-- ${PARALLEL}
+CLEAN -- ${CLEAN}
"
if [[ ! -f "${TP_DIR}/download-thirdparty.sh" ]]; then
@@ -123,6 +129,12 @@ fi
cd "${TP_DIR}"
+if [[ "${CLEAN}" -eq 1 ]] && [[ -d "${TP_SOURCE_DIR}" ]]; then
+echo 'Clean the extracted data ...'
+find "${TP_SOURCE_DIR}" -mindepth 1 -maxdepth 1 -type d -exec rm -rf {} \;
+echo 'Success!'
+fi
+
# Download thirdparties.
"${TP_DIR}/download-thirdparty.sh"
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch branch-1.2-lts updated (be513e1062 -> 5ce523852a)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git from be513e1062 [fix](multi catalog)Set column defualt value for query. (#15415) new e2a54f6408 [enhancement](session var) varariable to control whether to rewrite OR to IN or not (#15437) new e599532588 [Bug](Decimalv3) coredump of decimalv3 multiply (#15452) new 5ce523852a [chore](thirdparty) Support cleaning extracted data before building them (#15458) The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: be/src/vec/core/decimal_comparison.h | 8 +-- be/src/vec/data_types/data_type_decimal.h | 60 ++ be/src/vec/functions/function_binary_arithmetic.h | 7 ++- .../java/org/apache/doris/qe/SessionVariable.java | 14 + .../doris/rewrite/ExtractCommonFactorsRule.java| 51 ++ .../org/apache/doris/planner/QueryPlanTest.java| 17 ++ regression-test/data/decimalv3/test_decimalv3.out | 3 ++ .../data/performance_p0/redundant_conjuncts.out| 2 +- .../suites/decimalv3/test_decimalv3.groovy | 1 + .../performance_p0/redundant_conjuncts.groovy | 1 + thirdparty/build-thirdparty.sh | 14 - 11 files changed, 116 insertions(+), 62 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] 01/03: [enhancement](session var) varariable to control whether to rewrite OR to IN or not (#15437)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
commit e2a54f6408ae07a6b85da3206479a8602c00e7a2
Author: Henry2SS <45096548+henry...@users.noreply.github.com>
AuthorDate: Thu Dec 29 14:50:32 2022 +0800
[enhancement](session var) varariable to control whether to rewrite OR to
IN or not (#15437)
---
.../java/org/apache/doris/qe/SessionVariable.java | 14 ++
.../doris/rewrite/ExtractCommonFactorsRule.java| 51 +-
.../org/apache/doris/planner/QueryPlanTest.java| 17
.../data/performance_p0/redundant_conjuncts.out| 2 +-
.../performance_p0/redundant_conjuncts.groovy | 1 +
5 files changed, 74 insertions(+), 11 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
b/fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
index f0a556067f..8d8f412aee 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
@@ -196,6 +196,9 @@ public class SessionVariable implements Serializable,
Writable {
//percentage of EXEC_MEM_LIMIT
public static final String BROADCAST_HASHTABLE_MEM_LIMIT_PERCENTAGE =
"broadcast_hashtable_mem_limit_percentage";
+
+public static final String REWRITE_OR_TO_IN_PREDICATE_THRESHOLD =
"rewrite_or_to_in_predicate_threshold";
+
public static final String NEREIDS_STAR_SCHEMA_SUPPORT =
"nereids_star_schema_support";
public static final String NEREIDS_CBO_PENALTY_FACTOR =
"nereids_cbo_penalty_factor";
@@ -544,6 +547,9 @@ public class SessionVariable implements Serializable,
Writable {
@VariableMgr.VarAttr(name = NEREIDS_STAR_SCHEMA_SUPPORT)
private boolean nereidsStarSchemaSupport = true;
+@VariableMgr.VarAttr(name = REWRITE_OR_TO_IN_PREDICATE_THRESHOLD)
+private int rewriteOrToInPredicateThreshold = 2;
+
@VariableMgr.VarAttr(name = NEREIDS_CBO_PENALTY_FACTOR)
private double nereidsCboPenaltyFactor = 0.7;
@VariableMgr.VarAttr(name = ENABLE_NEREIDS_TRACE)
@@ -661,6 +667,14 @@ public class SessionVariable implements Serializable,
Writable {
this.blockEncryptionMode = blockEncryptionMode;
}
+public void setRewriteOrToInPredicateThreshold(int threshold) {
+this.rewriteOrToInPredicateThreshold = threshold;
+}
+
+public int getRewriteOrToInPredicateThreshold() {
+return rewriteOrToInPredicateThreshold;
+}
+
public long getMaxExecMemByte() {
return maxExecMemByte;
}
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/rewrite/ExtractCommonFactorsRule.java
b/fe/fe-core/src/main/java/org/apache/doris/rewrite/ExtractCommonFactorsRule.java
index 5a3bc34c8c..3c808c6100 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/rewrite/ExtractCommonFactorsRule.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/rewrite/ExtractCommonFactorsRule.java
@@ -28,6 +28,7 @@ import org.apache.doris.analysis.SlotRef;
import org.apache.doris.analysis.TableName;
import org.apache.doris.common.AnalysisException;
import org.apache.doris.planner.PlanNode;
+import org.apache.doris.qe.ConnectContext;
import org.apache.doris.rewrite.ExprRewriter.ClauseType;
import com.google.common.base.Preconditions;
@@ -43,6 +44,7 @@ import org.apache.logging.log4j.Logger;
import java.util.ArrayList;
import java.util.Arrays;
+import java.util.HashSet;
import java.util.LinkedHashSet;
import java.util.List;
import java.util.Map;
@@ -462,6 +464,13 @@ public class ExtractCommonFactorsRule implements
ExprRewriteRule {
boolean isOrToInAllowed = true;
Set slotSet = new LinkedHashSet<>();
+int rewriteThreshold;
+if (ConnectContext.get() == null) {
+rewriteThreshold = 2;
+} else {
+rewriteThreshold =
ConnectContext.get().getSessionVariable().getRewriteOrToInPredicateThreshold();
+}
+
for (int i = 0; i < exprs.size(); i++) {
Expr predicate = exprs.get(i);
if (!(predicate instanceof BinaryPredicate) && !(predicate
instanceof InPredicate)) {
@@ -492,22 +501,44 @@ public class ExtractCommonFactorsRule implements
ExprRewriteRule {
// isOrToInAllowed : true, means can rewrite
// slotSet.size : nums of columnName in exprs, should be 1
if (isOrToInAllowed && slotSet.size() == 1) {
-// slotRef to get ColumnName
-
-// SlotRef firstSlot = (SlotRef) exprs.get(0).getChild(0);
-List childrenList = exprs.get(0).getChildren();
-inPredicate = new InPredicate(exprs.get(0).getChild(0),
-childrenList.subList(1, childrenList.size()), false);
-
-for (int i = 1; i < exprs.size(); i++) {
-childrenList = exprs.get(i).getChildren();
-inPredicate.addCh
[doris] 02/03: [Bug](Decimalv3) coredump of decimalv3 multiply (#15452)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
commit e599532588b5ac8d20cfc22efe89c311a0b2af24
Author: HappenLee
AuthorDate: Thu Dec 29 15:35:17 2022 +0800
[Bug](Decimalv3) coredump of decimalv3 multiply (#15452)
---
be/src/vec/core/decimal_comparison.h | 8 +--
be/src/vec/data_types/data_type_decimal.h | 60 ++
be/src/vec/functions/function_binary_arithmetic.h | 7 ++-
regression-test/data/decimalv3/test_decimalv3.out | 3 ++
.../suites/decimalv3/test_decimalv3.groovy | 1 +
5 files changed, 29 insertions(+), 50 deletions(-)
diff --git a/be/src/vec/core/decimal_comparison.h
b/be/src/vec/core/decimal_comparison.h
index 1f2bce4200..4c7cfcf765 100644
--- a/be/src/vec/core/decimal_comparison.h
+++ b/be/src/vec/core/decimal_comparison.h
@@ -142,9 +142,11 @@ private:
Shift shift;
if (decimal0 && decimal1) {
-auto result_type = decimal_result_type(*decimal0, *decimal1,
false, false);
-shift.a = result_type.scale_factor_for(*decimal0, false);
-shift.b = result_type.scale_factor_for(*decimal1, false);
+using Type = std::conditional_t= sizeof(U), T, U>;
+auto type_ptr = decimal_result_type(*decimal0, *decimal1, false,
false, false);
+const DataTypeDecimal* result_type =
check_decimal(*type_ptr);
+shift.a = result_type->scale_factor_for(*decimal0, false);
+shift.b = result_type->scale_factor_for(*decimal1, false);
} else if (decimal0) {
shift.b = decimal0->get_scale_multiplier();
} else if (decimal1) {
diff --git a/be/src/vec/data_types/data_type_decimal.h
b/be/src/vec/data_types/data_type_decimal.h
index ea29954293..c8e08303a1 100644
--- a/be/src/vec/data_types/data_type_decimal.h
+++ b/be/src/vec/data_types/data_type_decimal.h
@@ -219,56 +219,30 @@ private:
};
template
-typename std::enable_if_t<(sizeof(T) >= sizeof(U)), const DataTypeDecimal>
decimal_result_type(
-const DataTypeDecimal& tx, const DataTypeDecimal& ty, bool
is_multiply,
-bool is_divide) {
+DataTypePtr decimal_result_type(const DataTypeDecimal& tx, const
DataTypeDecimal& ty,
+bool is_multiply, bool is_divide, bool
is_plus_minus) {
+using Type = std::conditional_t= sizeof(U), T, U>;
if constexpr (IsDecimalV2 && IsDecimalV2) {
-return DataTypeDecimal(max_decimal_precision(), 9);
+return
std::make_shared>((max_decimal_precision(), 9));
} else {
-UInt32 scale = (tx.get_scale() > ty.get_scale() ? tx.get_scale() :
ty.get_scale());
+UInt32 scale = std::max(tx.get_scale(), ty.get_scale());
+auto precision = max_decimal_precision();
+
+size_t multiply_precision = tx.get_precision() + ty.get_precision();
+size_t divide_precision = tx.get_precision() + ty.get_scale();
+size_t plus_minus_precision =
+std::max(tx.get_precision() - tx.get_scale(),
ty.get_precision() - ty.get_scale()) +
+scale;
if (is_multiply) {
scale = tx.get_scale() + ty.get_scale();
+precision = std::min(multiply_precision,
max_decimal_precision());
} else if (is_divide) {
scale = tx.get_scale();
+precision = std::min(divide_precision,
max_decimal_precision());
+} else if (is_plus_minus) {
+precision = std::min(plus_minus_precision,
max_decimal_precision());
}
-return DataTypeDecimal(max_decimal_precision(), scale);
-}
-}
-
-template
-typename std::enable_if_t<(sizeof(T) < sizeof(U)), const DataTypeDecimal>
decimal_result_type(
-const DataTypeDecimal& tx, const DataTypeDecimal& ty, bool
is_multiply,
-bool is_divide) {
-if constexpr (IsDecimalV2 && IsDecimalV2) {
-return DataTypeDecimal(max_decimal_precision(), 9);
-} else {
-UInt32 scale = (tx.get_scale() > ty.get_scale() ? tx.get_scale() :
ty.get_scale());
-if (is_multiply) {
-scale = tx.get_scale() + ty.get_scale();
-} else if (is_divide) {
-scale = tx.get_scale();
-}
-return DataTypeDecimal(max_decimal_precision(), scale);
-}
-}
-
-template
-const DataTypeDecimal decimal_result_type(const DataTypeDecimal& tx,
const DataTypeNumber&,
- bool, bool) {
-if constexpr (IsDecimalV2 && IsDecimalV2) {
-return DataTypeDecimal(max_decimal_precision(), 9);
-} else {
-return DataTypeDecimal(max_decimal_precision(), tx.get_scale());
-}
-}
-
-template
-const DataTypeDecimal decimal_result_type(const DataTypeNumber&, const
DataTypeDecimal& ty,
- bool, bool) {
-if constexpr (IsDecimalV2 && IsDecimalV2) {
-
[GitHub] [doris] morningman opened a new pull request, #15483: [fix](branch-1.2) add TIME as KEYWORD
morningman opened a new pull request, #15483: URL: https://github.com/apache/doris/pull/15483 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] 01/04: test
This is an automated email from the ASF dual-hosted git repository. xuyang pushed a commit to branch struct-type in repository https://gitbox.apache.org/repos/asf/doris.git commit 51ba9362f9b12b65cd44963115a0a4ead0a26099 Author: xy720 AuthorDate: Thu Nov 17 19:01:17 2022 +0800 test --- test_file | 1 + 1 file changed, 1 insertion(+) diff --git a/test_file b/test_file new file mode 100644 index 00..63d3c2d75e --- /dev/null +++ b/test_file @@ -0,0 +1 @@ +just for test - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] 03/04: [test] (test) test modify branch (#14375)
This is an automated email from the ASF dual-hosted git repository. xuyang pushed a commit to branch struct-type in repository https://gitbox.apache.org/repos/asf/doris.git commit 14ec06a8d25406b75d824a51a5091a3840b210f7 Author: xy720 <22125576+xy...@users.noreply.github.com> AuthorDate: Thu Nov 17 19:27:40 2022 +0800 [test] (test) test modify branch (#14375) --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index b7a33dc9fc..2b449530a5 100644 --- a/README.md +++ b/README.md @@ -237,3 +237,4 @@ some Doris features to be complied with Apache 2.0 License. For details, refer t + - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] 02/04: save
This is an automated email from the ASF dual-hosted git repository. xuyang pushed a commit to branch struct-type in repository https://gitbox.apache.org/repos/asf/doris.git commit 2c7694e13be6cf0f0c4514150c33efb1b55c4467 Author: xy720 AuthorDate: Thu Nov 17 19:15:50 2022 +0800 save --- test_file | 1 - 1 file changed, 1 deletion(-) diff --git a/test_file b/test_file deleted file mode 100644 index 63d3c2d75e..00 --- a/test_file +++ /dev/null @@ -1 +0,0 @@ -just for test - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] 04/04: [feature](struct-type) add the class ColumnStruct and class DataTypeStruct implement (#14545)
This is an automated email from the ASF dual-hosted git repository.
xuyang pushed a commit to branch struct-type
in repository https://gitbox.apache.org/repos/asf/doris.git
commit bebab27bc9c1a1a93193359fd929309c81c2a69b
Author: carlvinhust2012
AuthorDate: Thu Dec 8 09:26:12 2022 +0800
[feature](struct-type) add the class ColumnStruct and class DataTypeStruct
implement (#14545)
Co-authored-by: hucheng01
---
be/src/vec/CMakeLists.txt | 2 +
be/src/vec/columns/column_struct.cpp | 618 +
be/src/vec/columns/column_struct.h | 232 +++
be/src/vec/core/types.h| 3 +
be/src/vec/data_types/data_type_struct.cpp | 361 +
be/src/vec/data_types/data_type_struct.h | 115 ++
6 files changed, 1331 insertions(+)
diff --git a/be/src/vec/CMakeLists.txt b/be/src/vec/CMakeLists.txt
index 4426ba63a7..27d163e8ca 100644
--- a/be/src/vec/CMakeLists.txt
+++ b/be/src/vec/CMakeLists.txt
@@ -49,6 +49,7 @@ set(VEC_FILES
aggregate_functions/aggregate_function_histogram.cpp
columns/column.cpp
columns/column_array.cpp
+ columns/column_struct.cpp
columns/column_const.cpp
columns/column_decimal.cpp
columns/column_nullable.cpp
@@ -72,6 +73,7 @@ set(VEC_FILES
core/materialize_block.cpp
data_types/data_type.cpp
data_types/data_type_array.cpp
+ data_types/data_type_struct.cpp
data_types/data_type_bitmap.cpp
data_types/data_type_factory.cpp
data_types/data_type_fixed_length_object.cpp
diff --git a/be/src/vec/columns/column_struct.cpp
b/be/src/vec/columns/column_struct.cpp
new file mode 100644
index 00..05d5df0fd4
--- /dev/null
+++ b/be/src/vec/columns/column_struct.cpp
@@ -0,0 +1,618 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+// This file is copied from
+//
https://github.com/ClickHouse/ClickHouse/blob/master/src/Columns/ColumnStruct.cpp
+// and modified by Doris
+
+#include "vec/columns/column_struct.h"
+
+namespace doris::vectorized {
+
+namespace ErrorCodes {
+extern const int ILLEGAL_COLUMN;
+extern const int NOT_IMPLEMENTED;
+extern const int CANNOT_INSERT_VALUE_OF_DIFFERENT_SIZE_INTO_TUPLE;
+extern const int LOGICAL_ERROR;
+} // namespace ErrorCodes
+
+std::string ColumnStruct::get_name() const {
+std::stringstream res;
+res << "Struct(";
+bool is_first = true;
+for (const auto& column : columns) {
+if (!is_first) {
+res << ", ";
+}
+is_first = false;
+res << column->get_name();
+}
+res << ")";
+return res.str();
+}
+
+ColumnStruct::ColumnStruct(MutableColumns&& mutable_columns) {
+columns.reserve(mutable_columns.size());
+for (auto& column : mutable_columns) {
+if (is_column_const(*column)) {
+throw Exception {"ColumnStruct cannot have ColumnConst as its
element",
+ ErrorCodes::ILLEGAL_COLUMN};
+}
+columns.push_back(std::move(column));
+}
+}
+
+ColumnStruct::ColumnStruct(Columns&& columns) {
+columns.reserve(columns.size());
+for (auto& column : columns) {
+if (is_column_const(*column)) {
+throw Exception {"ColumnStruct cannot have ColumnConst as its
element",
+ ErrorCodes::ILLEGAL_COLUMN};
+}
+columns.push_back(std::move(column));
+}
+}
+
+ColumnStruct::ColumnStruct(TupleColumns&& tuple_columns) {
+columns.reserve(tuple_columns.size());
+for (auto& column : tuple_columns) {
+if (is_column_const(*column)) {
+throw Exception {"ColumnStruct cannot have ColumnConst as its
element",
+ ErrorCodes::ILLEGAL_COLUMN};
+}
+columns.push_back(std::move(column));
+}
+}
+
+ColumnStruct::Ptr ColumnStruct::create(Columns& columns) {
+for (const auto& column : columns) {
+if (is_column_const(*column))
+throw Exception {"ColumnStruct cannot have ColumnConst as its
element",
+ ErrorCodes::ILLEGAL_COLUMN};
+}
+auto column_struct = ColumnStruct::create(columns);
+return column_struct;
+}
+
+ColumnStruct::Ptr ColumnStruct::create(TupleColumns& tuple_columns)
[GitHub] [doris] morningman merged pull request #15483: [fix](branch-1.2) add TIME as KEYWORD
morningman merged PR #15483: URL: https://github.com/apache/doris/pull/15483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch branch-1.2-lts updated: [fix](branch-1.2) add TIME as KEYWORD (#15483)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-1.2-lts by this push:
new d65e1fbeeb [fix](branch-1.2) add TIME as KEYWORD (#15483)
d65e1fbeeb is described below
commit d65e1fbeeb9c75627e2fca0388b11e0e4d5d4b45
Author: Mingyu Chen
AuthorDate: Thu Dec 29 17:59:03 2022 +0800
[fix](branch-1.2) add TIME as KEYWORD (#15483)
---
fe/fe-core/src/main/cup/sql_parser.cup | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fe/fe-core/src/main/cup/sql_parser.cup
b/fe/fe-core/src/main/cup/sql_parser.cup
index 20cc80a81d..97c3fdd5c3 100644
--- a/fe/fe-core/src/main/cup/sql_parser.cup
+++ b/fe/fe-core/src/main/cup/sql_parser.cup
@@ -6762,6 +6762,8 @@ keyword ::=
{: RESULT = id; :}
| KW_THAN:id
{: RESULT = id; :}
+| KW_TIME:id
+{: RESULT = id; :}
| KW_TIMESTAMP:id
{: RESULT = id; :}
| KW_TRANSACTION:id
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15413: [refactor]remove seek block in segmentIterator
github-actions[bot] commented on PR #15413: URL: https://github.com/apache/doris/pull/15413#issuecomment-1367206466 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15473: [fix](nereids) translate agg-sort
hello-stephen commented on PR #15473: URL: https://github.com/apache/doris/pull/15473#issuecomment-1367208366 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.94 seconds load time: 658 seconds storage size: 17123568553 Bytes https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221229100827_clickbench_pr_70875.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15474: [WIP](struct-type) support struct-type in vectorize storage engine
github-actions[bot] commented on code in PR #15474:
URL: https://github.com/apache/doris/pull/15474#discussion_r1058864184
##
be/src/olap/types.h:
##
@@ -188,6 +189,232 @@ class ScalarTypeInfo : public TypeInfo {
friend class ScalarTypeInfoResolver;
};
+class StructTypeInfo: public TypeInfo {
+public:
+explicit StructTypeInfo(std::vector& type_infos) {
+for (TypeInfoPtr& type_info : type_infos) {
+_type_infos.push_back(std::move(type_info));
+}
+}
+~StructTypeInfo() override = default;
+
+bool equal(const void* left, const void* right) const override {
+auto l_value = reinterpret_cast(left);
+auto r_value = reinterpret_cast(right);
+if (l_value->size() != r_value->size()) {
+return false;
+}
+uint32_t size = l_value->size();
+
+if (!l_value->has_null() && !r_value->has_null()) {
Review Comment:
warning: no member named 'has_null' in 'doris::StructValue'
[clang-diagnostic-error]
```cpp
if (!l_value->has_null() && !r_value->has_null()) {
^
```
##
be/src/olap/types.h:
##
@@ -188,6 +189,232 @@
friend class ScalarTypeInfoResolver;
};
+class StructTypeInfo: public TypeInfo {
+public:
+explicit StructTypeInfo(std::vector& type_infos) {
+for (TypeInfoPtr& type_info : type_infos) {
+_type_infos.push_back(std::move(type_info));
+}
+}
+~StructTypeInfo() override = default;
+
+bool equal(const void* left, const void* right) const override {
+auto l_value = reinterpret_cast(left);
+auto r_value = reinterpret_cast(right);
+if (l_value->size() != r_value->size()) {
+return false;
+}
+uint32_t size = l_value->size();
+
+if (!l_value->has_null() && !r_value->has_null()) {
Review Comment:
warning: no member named 'has_null' in 'doris::StructValue'
[clang-diagnostic-error]
```cpp
if (!l_value->has_null() && !r_value->has_null()) {
^
```
##
be/src/olap/types.h:
##
@@ -188,6 +189,232 @@
friend class ScalarTypeInfoResolver;
};
+class StructTypeInfo: public TypeInfo {
+public:
+explicit StructTypeInfo(std::vector& type_infos) {
+for (TypeInfoPtr& type_info : type_infos) {
+_type_infos.push_back(std::move(type_info));
+}
+}
+~StructTypeInfo() override = default;
+
+bool equal(const void* left, const void* right) const override {
+auto l_value = reinterpret_cast(left);
+auto r_value = reinterpret_cast(right);
+if (l_value->size() != r_value->size()) {
+return false;
+}
+uint32_t size = l_value->size();
+
+if (!l_value->has_null() && !r_value->has_null()) {
+for (size_t i = 0; i < size; ++i) {
+if (!_type_infos[i]->equal(l_value->child_value(i),
r_value->child_value(i)) {
+return false;
+}
+}
+} else {
+for (size_t i = 0; i < size; ++i) {
+if (l_value->is_null_at(i)) {
+if (r_value->is_null_at(i)) { // both are null
+continue;
+} else { // left is null & right is not null
+return false;
+}
+} else if (r_value->is_null_at(i)) { // left is not null &
right is null
+return false;
+}
+if (!_type_infos[i]->equal(l_value->child_value(i),
r_value->child_value(i)) {
Review Comment:
warning: expected ')' [clang-diagnostic-error]
```cpp
if (!_type_infos[i]->equal(l_value->child_value(i),
r_value->child_value(i)) {
^
```
**be/src/olap/types.h:225:** to match this '('
```cpp
if (!_type_infos[i]->equal(l_value->child_value(i),
r_value->child_value(i)) {
^
```
##
be/src/olap/types.h:
##
@@ -188,6 +189,232 @@
friend class ScalarTypeInfoResolver;
};
+class StructTypeInfo: public TypeInfo {
+public:
+explicit StructTypeInfo(std::vector& type_infos) {
+for (TypeInfoPtr& type_info : type_infos) {
+_type_infos.push_back(std::move(type_info));
+}
+}
+~StructTypeInfo() override = default;
+
+bool equal(const void* left, const void* right) const override {
+auto l_value = reinterpret_cast(left);
+auto r_value = reinterpret_cast(right);
+if (l_value->size() != r_value->size()) {
+return false;
+}
+uint32_t size = l_value->size();
+
+if (!l_value->has_null() && !r_value->has_null()) {
+for (size_t i = 0; i < size; ++i) {
+if (
[GitHub] [doris] morrySnow merged pull request #15370: [feature](nereids)add variance function for nereids
morrySnow merged PR #15370: URL: https://github.com/apache/doris/pull/15370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Error while running github feature from .asf.yaml in doris!
An error occurred while running github feature in .asf.yaml!:
422 {"message": "Validation Failed", "errors": ["A repository cannot have more
than 20 topics."], "documentation_url":
"https://docs.github.com/rest/reference/repos#replace-all-repository-topics"}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (43c8e7b465 -> e651a9bb11)
This is an automated email from the ASF dual-hosted git repository.
morrysnow pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
from 43c8e7b465 [chore](thirdparty) Support cleaning extracted data before
building them (#15458)
add e651a9bb11 [feature](nereids) add variance function for nereids
(#15370)
No new revisions were added by this update.
Summary of changes:
.../doris/catalog/BuiltinAggregateFunctions.java | 13 +++---
.../{scalar/Abs.java => agg/Variance.java} | 51 --
.../visitor/AggregateFunctionVisitor.java | 5 +++
.../test_variance_nereids.out} | 5 +--
.../nereids_syntax_p0/test_variance_nereids.groovy | 19 +++-
5 files changed, 47 insertions(+), 46 deletions(-)
copy
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/{scalar/Abs.java
=> agg/Variance.java} (64%)
copy regression-test/data/{correctness/test_forbidden_infer_filter_rule.out =>
nereids_syntax_p0/test_variance_nereids.out} (80%)
copy be/src/io/fs/path.h =>
regression-test/suites/nereids_syntax_p0/test_variance_nereids.groovy (77%)
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhengshiJ opened a new pull request, #15484: [Fix](Nereids) Group by binding should be consistent with the behavio…
zhengshiJ opened a new pull request, #15484: URL: https://github.com/apache/doris/pull/15484 …r of the old optimizer # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #15326: [fix](nereids) fix some arrgregate bugs in Nereids
morrySnow commented on PR #15326: URL: https://github.com/apache/doris/pull/15326#issuecomment-1367228876 > 2. why shouldn't eliminate project in the translator? i can answer the 2nd question. currently, we use two map to maintain ExprId and SlotId's relationship. However, in some cases, this cannot work fine when we eliminate project in translator. Instead, we need to maintain a 1 to n relationship. And in some other cases, we find more than one bugs in this feature's code. So, we just remove this feature temporarily and add it back later~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] spaces-X commented on a diff in pull request #15480: [Fix](SparkLoad): fix the timeout aborted loadtasks are not cleaned up.
spaces-X commented on code in PR #15480:
URL: https://github.com/apache/doris/pull/15480#discussion_r1058890386
##
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/SparkLoadJob.java:
##
@@ -695,6 +695,8 @@ private void clearJob() {
// clear job infos that not persist
sparkLoadAppHandle = null;
resourceDesc = null;
+etlOutputPath = "";
+appId = "";
Review Comment:
If the job is cancelled by user, the `clearJob()` will be called twice.
Set thess shtring empty,to ensure the idempotency of the `clearJob` function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] spaces-X commented on a diff in pull request #15480: [Fix](SparkLoad): fix the timeout aborted loadtasks are not cleaned up.
spaces-X commented on code in PR #15480:
URL: https://github.com/apache/doris/pull/15480#discussion_r1058890386
##
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/SparkLoadJob.java:
##
@@ -695,6 +695,8 @@ private void clearJob() {
// clear job infos that not persist
sparkLoadAppHandle = null;
resourceDesc = null;
+etlOutputPath = "";
+appId = "";
Review Comment:
If the job is cancelled by user, the `clearJob()` will be called twice.
Set thess strings to empty,to ensure the idempotency of the `clearJob`
function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15479: [fix](Nereids): generate colocate join when property is different with require property
hello-stephen commented on PR #15479: URL: https://github.com/apache/doris/pull/15479#issuecomment-1367246796 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.67 seconds load time: 634 seconds storage size: 17123673499 Bytes https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221229111314_clickbench_pr_70987.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #15440: [fix](hashjoin) Fix right join pull output block memory overflow
HappenLee commented on code in PR #15440:
URL: https://github.com/apache/doris/pull/15440#discussion_r1058893537
##
be/src/vec/exec/join/join_op.h:
##
@@ -202,6 +206,7 @@ struct RowRefListWithFlag : RowRef {
friend class ForwardIterator;
Batch* next = nullptr;
+ForwardIterator _visited_iter;
Review Comment:
the way will cause unnecessary mem and performance problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15480: [Fix](SparkLoad): fix the timeout aborted loadtasks are not cleaned up.
hello-stephen commented on PR #15480: URL: https://github.com/apache/doris/pull/15480#issuecomment-1367256119 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.7 seconds load time: 652 seconds storage size: 17123647190 Bytes https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221229113123_clickbench_pr_70925.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15481: [fix](index) fix that the last element of each batch will be read repeatedly for binary prefix page
github-actions[bot] commented on PR #15481: URL: https://github.com/apache/doris/pull/15481#issuecomment-1367259490 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15481: [fix](index) fix that the last element of each batch will be read repeatedly for binary prefix page
hello-stephen commented on PR #15481: URL: https://github.com/apache/doris/pull/15481#issuecomment-1367267660 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.95 seconds load time: 659 seconds storage size: 17122365479 Bytes https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221229115502_clickbench_pr_70944.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhangstar333 commented on issue #15327: [Bug] mysql external table, select be crash
zhangstar333 commented on issue #15327: URL: https://github.com/apache/doris/issues/15327#issuecomment-1367278448 mysql tinyint(1) mapping to doris is boolean, use this type will be good https://user-images.githubusercontent.com/87313068/209949639-7f6b4c16-c180-462b-9b55-f374e8e4a243.png";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] df007df opened a new issue, #15485: [Bug] mapping not found for the ES Cluster
df007df opened a new issue, #15485: URL: https://github.com/apache/doris/issues/15485 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version doris-1.2.0-rc04 ### What's Wrong? 配置ES链接后，查询失败。错误内容 创建语句 ``` CREATE EXTERNAL TABLE `es_index_products_v4` ( `_id` varchar COMMENT "_id", `id` bigint(20) COMMENT "id", `code` varchar(20) COMMENT "code", `source` varchar(20) COMMENT "source", `platform` varchar(20) COMMENT "platform", `status` varchar(20) COMMENT "status", `gmtCreate` datetime COMMENT "gmtCreate", `gmtModified` datetime COMMENT "gmtModified" ) ENGINE=ELASTICSEARCH PROPERTIES ( "hosts" = "https://47.97.182.118:9200";, "index" = "products_v4_1", "user" = "elastic", "password" = "nmOvwUr1W=QNHgq*FKyl", "enable_docvalue_scan" = "true", "http_ssl_enabled" = "true", "nodes_discovery" = "false" ); ``` be 的日志内容  ### What You Expected? 调研中，希望尽快好。 doris 1.1.0 版本是可以的 ### How to Reproduce? _No response_ ### Anything Else? _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #15418: [feature-wip](multi-catalog) support Iceberg time travel in external table
morningman commented on code in PR #15418:
URL: https://github.com/apache/doris/pull/15418#discussion_r1058934476
##
fe/fe-core/src/main/java/org/apache/doris/analysis/TableRef.java:
##
@@ -499,6 +515,27 @@ protected void analyzeHints() throws AnalysisException {
}
}
+public void analyzeTableSnapshot(Analyzer analyzer) throws
AnalysisException {
Review Comment:
```suggestion
protected void analyzeTableSnapshot(Analyzer analyzer) throws
AnalysisException {
```
##
regression-test/suites/external_table_emr_p2/iceberg/test_external_catalog_icebergv2.groovy:
##
@@ -24,9 +24,9 @@ suite("test_external_catalog_icebergv2", "p2") {
sql """drop catalog if exists ${catalog_name};"""
sql """
-create catalog if not exists ${catalog_name} properties (
+create catalog if not exists test_external_catalog_iceberg
properties (
'type'='hms',
-'hive.metastore.uris' =
'thrift://${extHiveHmsHost}:${extHiveHmsPort}'
+'hive.metastore.uris' = 'thrift://172.21.16.47:7004'
Review Comment:
Change this
##
fe/fe-core/src/main/java/org/apache/doris/planner/external/IcebergScanProvider.java:
##
@@ -168,6 +176,18 @@ public List getSplits(List exprs) throws
UserException {
org.apache.iceberg.Table table = getIcebergTable();
TableScan scan = table.newScan();
+TableSnapshot tableSnapshot = desc.getRef().getTableSnapshot();
+if (tableSnapshot != null) {
+TableSnapshot.VersionType type = tableSnapshot.getType();
+if (type == TableSnapshot.VersionType.VERSION) {
+scan = scan.useSnapshot(tableSnapshot.getVersion());
+} else {
+LocalDateTime asOfTime =
LocalDateTime.parse(tableSnapshot.getTime(), DATE_TIME_FORMATTER);
Review Comment:
You can use `TimeUtil.timeStringToLong()`
##
fe/fe-core/src/main/java/org/apache/doris/planner/external/IcebergScanProvider.java:
##
@@ -168,6 +176,18 @@ public List getSplits(List exprs) throws
UserException {
org.apache.iceberg.Table table = getIcebergTable();
TableScan scan = table.newScan();
+TableSnapshot tableSnapshot = desc.getRef().getTableSnapshot();
+if (tableSnapshot != null) {
+TableSnapshot.VersionType type = tableSnapshot.getType();
+if (type == TableSnapshot.VersionType.VERSION) {
+scan = scan.useSnapshot(tableSnapshot.getVersion());
Review Comment:
What if user give a non-exist snapshot version?
##
fe/fe-core/src/main/java/org/apache/doris/planner/external/IcebergScanProvider.java:
##
@@ -168,6 +176,18 @@ public List getSplits(List exprs) throws
UserException {
org.apache.iceberg.Table table = getIcebergTable();
TableScan scan = table.newScan();
+TableSnapshot tableSnapshot = desc.getRef().getTableSnapshot();
+if (tableSnapshot != null) {
+TableSnapshot.VersionType type = tableSnapshot.getType();
+if (type == TableSnapshot.VersionType.VERSION) {
+scan = scan.useSnapshot(tableSnapshot.getVersion());
Review Comment:
Catch the `NotFoundException` and throw `UserException`
##
fe/fe-core/src/main/cup/sql_parser.cup:
##
@@ -5095,12 +5098,33 @@ base_table_ref_list ::=
;
base_table_ref ::=
-table_name:name opt_partition_names:partitionNames
opt_tablet_list:tabletIds opt_table_alias:alias opt_table_sample:tableSample
opt_common_hints:commonHints
+table_name:name opt_partition_names:partitionNames
opt_tablet_list:tabletIds opt_table_alias:alias opt_table_sample:tableSample
opt_common_hints:commonHints opt_snapshot_version:snapshotVersion
{:
-RESULT = new TableRef(name, alias, partitionNames, tabletIds,
tableSample, commonHints);
+RESULT = new TableRef(name, alias, partitionNames, tabletIds,
tableSample, commonHints, snapshotVersion);
:}
;
+opt_snapshot_version ::=
+/* empty */
+{:
+RESULT = null;
+:}
+| snapshot_version:snapshotVersion
+{:
+RESULT = snapshotVersion;
+:}
+;
+
+snapshot_version ::=
+KW_FOR KW_VERSION KW_AS KW_OF STRING_LITERAL:version
Review Comment:
`time` should be string and `version` should be integer.
##
fe/fe-core/src/main/java/org/apache/doris/analysis/TableRef.java:
##
@@ -499,6 +515,27 @@ protected void analyzeHints() throws AnalysisException {
}
}
+public void analyzeTableSnapshot(Analyzer analyzer) throws
AnalysisException {
+if (tableSnapshot == null) {
+return;
+}
+TableIf.TableType tableType = this.getTable().getType();
+if (tableType != TableIf.TableType.HMS_EXTERNAL_TABLE) {
+
ErrorReport.reportAnalysisException(ErrorCode.ERR_NONSUPPORT_TIME_TRAVEL_TABLE);
+}
+
[GitHub] [doris] github-actions[bot] commented on pull request #15463: [Improvement](decimalv3) Add a config to check overflow for DECIMALV3
github-actions[bot] commented on PR #15463: URL: https://github.com/apache/doris/pull/15463#issuecomment-1367301203 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15463: [Improvement](decimalv3) Add a config to check overflow for DECIMALV3
github-actions[bot] commented on PR #15463: URL: https://github.com/apache/doris/pull/15463#issuecomment-1367301227 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] englefly opened a new pull request, #15486: [fix](nereids) fix ut
englefly opened a new pull request, #15486: URL: https://github.com/apache/doris/pull/15486 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman closed issue #15430: [Bug] Cooldown time is wrong for data in SSD
morningman closed issue #15430: [Bug] Cooldown time is wrong for data in SSD URL: https://github.com/apache/doris/issues/15430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #15444: [Fix](storage) Fix bug that cooldown time for partition in SSD is wrong
morningman merged PR #15444: URL: https://github.com/apache/doris/pull/15444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (e651a9bb11 -> 79113b0cd1)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from e651a9bb11 [feature](nereids) add variance function for nereids (#15370) add 79113b0cd1 [Fix](storage) Fix bug that cooldown time is error (#15444) No new revisions were added by this update. Summary of changes: .../src/main/java/org/apache/doris/analysis/SinglePartitionDesc.java | 4 ++-- fe/fe-core/src/main/java/org/apache/doris/catalog/DataProperty.java | 5 ++--- .../src/main/java/org/apache/doris/datasource/InternalCatalog.java | 5 +++-- .../src/test/java/org/apache/doris/catalog/CatalogTestUtil.java | 4 ++-- .../src/test/java/org/apache/doris/catalog/DataPropertyTest.java | 2 +- .../src/test/java/org/apache/doris/common/util/UnitTestUtil.java | 2 +- .../src/test/java/org/apache/doris/http/DorisHttpTestCase.java | 5 +++-- .../java/org/apache/doris/persist/BatchModifyPartitionsInfoTest.java | 5 +++-- 8 files changed, 17 insertions(+), 15 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Error while running github feature from .asf.yaml in doris!
An error occurred while running github feature in .asf.yaml!:
422 {"message": "Validation Failed", "errors": ["A repository cannot have more
than 20 topics."], "documentation_url":
"https://docs.github.com/rest/reference/repos#replace-all-repository-topics"}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhangstar333 opened a new pull request, #15487: [vectorized](jdbc) fix external table of oracle have keyworld column …
zhangstar333 opened a new pull request, #15487: URL: https://github.com/apache/doris/pull/15487 if column name is keyword of oracle, the query will report error # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch branch-1.2-lts updated: [Fix](storage) Fix bug that cooldown time is error (#15444)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-1.2-lts by this push:
new 524607d003 [Fix](storage) Fix bug that cooldown time is error (#15444)
524607d003 is described below
commit 524607d003bb1d88e05c77c9678f43ab1560fd24
Author: weizuo93
AuthorDate: Thu Dec 29 21:01:36 2022 +0800
[Fix](storage) Fix bug that cooldown time is error (#15444)
Cooldown time is wrong for data in SSD, because cooldown time for all
`table/partitionis`
is only calculated once when class `DataProperty` loaded and that cannot be
updated later.
This patch is to ensure that cooldown time for each table/partition can be
calculated in real time
when table/partition is created.
Co-authored-by: weizuo
---
.../src/main/java/org/apache/doris/analysis/SinglePartitionDesc.java | 4 ++--
fe/fe-core/src/main/java/org/apache/doris/catalog/DataProperty.java | 5 ++---
.../src/main/java/org/apache/doris/datasource/InternalCatalog.java | 5 +++--
.../src/test/java/org/apache/doris/catalog/CatalogTestUtil.java | 4 ++--
.../src/test/java/org/apache/doris/catalog/DataPropertyTest.java | 2 +-
.../src/test/java/org/apache/doris/common/util/UnitTestUtil.java | 2 +-
.../src/test/java/org/apache/doris/http/DorisHttpTestCase.java | 5 +++--
.../java/org/apache/doris/persist/BatchModifyPartitionsInfoTest.java | 5 +++--
8 files changed, 17 insertions(+), 15 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/analysis/SinglePartitionDesc.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/SinglePartitionDesc.java
index 06b4bcfa71..7ffec7c1d2 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/analysis/SinglePartitionDesc.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/analysis/SinglePartitionDesc.java
@@ -58,7 +58,7 @@ public class SinglePartitionDesc implements AllPartitionDesc {
this.partitionKeyDesc = partitionKeyDesc;
this.properties = properties;
-this.partitionDataProperty = DataProperty.DEFAULT_DATA_PROPERTY;
+this.partitionDataProperty = new
DataProperty(DataProperty.DEFAULT_STORAGE_MEDIUM);
this.replicaAlloc = ReplicaAllocation.DEFAULT_ALLOCATION;
this.storagePolicy = "";
}
@@ -127,7 +127,7 @@ public class SinglePartitionDesc implements
AllPartitionDesc {
// analyze data property
partitionDataProperty =
PropertyAnalyzer.analyzeDataProperty(properties,
-DataProperty.DEFAULT_DATA_PROPERTY);
+new DataProperty(DataProperty.DEFAULT_STORAGE_MEDIUM));
Preconditions.checkNotNull(partitionDataProperty);
// analyze replication num
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/catalog/DataProperty.java
b/fe/fe-core/src/main/java/org/apache/doris/catalog/DataProperty.java
index 50fcbf7e72..13b1fd6123 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/catalog/DataProperty.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/DataProperty.java
@@ -35,9 +35,8 @@ import java.io.IOException;
import java.util.Objects;
public class DataProperty implements Writable, GsonPostProcessable {
-public static final DataProperty DEFAULT_DATA_PROPERTY = new DataProperty(
-"SSD".equalsIgnoreCase(Config.default_storage_medium) ?
TStorageMedium.SSD : TStorageMedium.HDD
-);
+public static final TStorageMedium DEFAULT_STORAGE_MEDIUM =
+"SSD".equalsIgnoreCase(Config.default_storage_medium) ?
TStorageMedium.SSD : TStorageMedium.HDD;
public static final long MAX_COOLDOWN_TIME_MS = 253402271999000L; //
-12-31 23:59:59
@SerializedName(value = "storageMedium")
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java
b/fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java
index 6466a29e12..0a264598d8 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java
@@ -1947,7 +1947,7 @@ public class InternalCatalog implements
CatalogIf {
DataProperty dataProperty = null;
try {
dataProperty =
PropertyAnalyzer.analyzeDataProperty(stmt.getProperties(),
-DataProperty.DEFAULT_DATA_PROPERTY);
+new DataProperty(DataProperty.DEFAULT_STORAGE_MEDIUM));
} catch (AnalysisException e) {
throw new DdlException(e.getMessage());
}
@@ -2104,7 +2104,8 @@ public class InternalCatalog implements
CatalogIf {
try {
// just for remove entries in stmt.getProperties(),
// and then check if there still has unknown properties
-PropertyAnalyzer.analyzeDataP
[GitHub] [doris] wsjz commented on a diff in pull request #15418: [feature-wip](multi-catalog) support Iceberg time travel in external table
wsjz commented on code in PR #15418:
URL: https://github.com/apache/doris/pull/15418#discussion_r1058943350
##
fe/fe-core/src/main/java/org/apache/doris/planner/external/IcebergScanProvider.java:
##
@@ -168,6 +176,18 @@ public List getSplits(List exprs) throws
UserException {
org.apache.iceberg.Table table = getIcebergTable();
TableScan scan = table.newScan();
+TableSnapshot tableSnapshot = desc.getRef().getTableSnapshot();
+if (tableSnapshot != null) {
+TableSnapshot.VersionType type = tableSnapshot.getType();
+if (type == TableSnapshot.VersionType.VERSION) {
+scan = scan.useSnapshot(tableSnapshot.getVersion());
Review Comment:
catch illegalArgument
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #14887: [fix](web ui)fix fe web ui
morningman merged PR #14887: URL: https://github.com/apache/doris/pull/14887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [fix](web ui) fix fe web ui (#14887)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 9b371f6b0b [fix](web ui) fix fe web ui (#14887)
9b371f6b0b is described below
commit 9b371f6b0b10ea971cbeb3f67d9899136f96b877
Author: jiafeng.zhang
AuthorDate: Thu Dec 29 21:19:44 2022 +0800
[fix](web ui) fix fe web ui (#14887)
---
ui/src/components/table/index.less | 11 +++
ui/src/components/table/index.tsx | 2 +-
ui/src/pages/system/index.tsx | 1 +
3 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/ui/src/components/table/index.less
b/ui/src/components/table/index.less
index a417c7d0a2..49db6dbb64 100644
--- a/ui/src/components/table/index.less
+++ b/ui/src/components/table/index.less
@@ -33,3 +33,14 @@ under the License. */
position: absolute;
}
}
+:table {
+:global {
+ .ant-table-thead > tr > th {
+background: #fff !important;
+white-space: nowrap;
+ }
+ .ant-table-tbody >tr> td {
+white-space: nowrap;
+ }
+}
+ }
diff --git a/ui/src/components/table/index.tsx
b/ui/src/components/table/index.tsx
index 5030b104be..94afff63c3 100644
--- a/ui/src/components/table/index.tsx
+++ b/ui/src/components/table/index.tsx
@@ -52,7 +52,7 @@ export default function SortFilterTable(props: any) {
Error while running github feature from .asf.yaml in doris!
An error occurred while running github feature in .asf.yaml!:
422 {"message": "Validation Failed", "errors": ["A repository cannot have more
than 20 topics."], "documentation_url":
"https://docs.github.com/rest/reference/repos#replace-all-repository-topics"}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch branch-1.2-lts updated: [fix](web ui) fix fe web ui (#14887)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-1.2-lts by this push:
new 9cecfe038f [fix](web ui) fix fe web ui (#14887)
9cecfe038f is described below
commit 9cecfe038f563c2803a8b7137d6b7e074d3f3cf9
Author: jiafeng.zhang
AuthorDate: Thu Dec 29 21:19:44 2022 +0800
[fix](web ui) fix fe web ui (#14887)
---
ui/src/components/table/index.less | 11 +++
ui/src/components/table/index.tsx | 2 +-
ui/src/pages/system/index.tsx | 1 +
3 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/ui/src/components/table/index.less
b/ui/src/components/table/index.less
index a417c7d0a2..49db6dbb64 100644
--- a/ui/src/components/table/index.less
+++ b/ui/src/components/table/index.less
@@ -33,3 +33,14 @@ under the License. */
position: absolute;
}
}
+:table {
+:global {
+ .ant-table-thead > tr > th {
+background: #fff !important;
+white-space: nowrap;
+ }
+ .ant-table-tbody >tr> td {
+white-space: nowrap;
+ }
+}
+ }
diff --git a/ui/src/components/table/index.tsx
b/ui/src/components/table/index.tsx
index 5030b104be..94afff63c3 100644
--- a/ui/src/components/table/index.tsx
+++ b/ui/src/components/table/index.tsx
@@ -52,7 +52,7 @@ export default function SortFilterTable(props: any) {
[GitHub] [doris] morningman merged pull request #15464: [fix](statistics) fix npe when __internal_schema not created
morningman merged PR #15464: URL: https://github.com/apache/doris/pull/15464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (9b371f6b0b -> c54c2f8035)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 9b371f6b0b [fix](web ui) fix fe web ui (#14887) add c54c2f8035 [fix](statistics) fix npe when __internal_schema not created (#15464) No new revisions were added by this update. Summary of changes: .../main/java/org/apache/doris/statistics/util/StatisticsUtil.java | 5 + 1 file changed, 5 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Error while running github feature from .asf.yaml in doris!
An error occurred while running github feature in .asf.yaml!:
422 {"message": "Validation Failed", "errors": ["A repository cannot have more
than 20 topics."], "documentation_url":
"https://docs.github.com/rest/reference/repos#replace-all-repository-topics"}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #15482: [chore](badges) Remove daily test badges for origin engine
morningman merged PR #15482: URL: https://github.com/apache/doris/pull/15482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [chore](badges) Remove daily test badges for origin engine (#15482)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new bb305aa572 [chore](badges) Remove daily test badges for origin engine (#15482) bb305aa572 is described below commit bb305aa572e60d28757c4978f56f3ae52e4670d7 Author: xy720 <22125576+xy...@users.noreply.github.com> AuthorDate: Thu Dec 29 21:25:15 2022 +0800 [chore](badges) Remove daily test badges for origin engine (#15482) The code of origin engine will be remove later, we already stop the daily test for origin engine, so we should remove this badges from home page. --- README.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/README.md b/README.md index b7a33dc9fc..57b1b16580 100644 --- a/README.md +++ b/README.md @@ -24,8 +24,7 @@ under the License. # Apache Doris [](https://www.apache.org/licenses/LICENSE-2.0.html) [](https://github.com/apache/doris/releases) -[](https://ci-builds.apache.org/job/Doris/job/doris_daily_disable_vectorized) -[](https://ci-builds.apache.org/job/Doris/job/doris_daily_enable_vectorized) +[](https://ci-builds.apache.org/job/Doris/job/doris_daily_enable_vectorized) [](https://github.com/apache/doris) [](https://join.slack.com/t/apachedoriscommunity/shared_invite/zt-1h153f1ar-sTJB_QahY1SHvZdtPFoIOQ) [](https://gitter.im/apache-doris/Lobby?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Error while running github feature from .asf.yaml in doris!
An error occurred while running github feature in .asf.yaml!:
422 {"message": "Validation Failed", "errors": ["A repository cannot have more
than 20 topics."], "documentation_url":
"https://docs.github.com/rest/reference/repos#replace-all-repository-topics"}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman opened a new pull request, #15489: [fix](regression-test) fix duplicate columns in yandex_metrica_p2 case
morningman opened a new pull request, #15489: URL: https://github.com/apache/doris/pull/15489 # Proposed changes Issue Number: close #xxx ## Problem summary Column in duplicated ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] weizhengte opened a new pull request, #15490: add histogram syntax and perstist histogram statistics
weizhengte opened a new pull request, #15490: URL: https://github.com/apache/doris/pull/15490 # Proposed changes Histogram statistics are more expensive to collect and we collect and persist them separately. This PR does the following work: 1. Add histogram syntax and normalize statistics syntax 2. Add the task of collecting histogram statistics 3. Persistent histogram statistics 4. Add unit tests Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15489: [fix](regression-test) fix duplicate columns in yandex_metrica_p2 case
github-actions[bot] commented on PR #15489: URL: https://github.com/apache/doris/pull/15489#issuecomment-1367325910 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15489: [fix](regression-test) fix duplicate columns in yandex_metrica_p2 case
github-actions[bot] commented on PR #15489: URL: https://github.com/apache/doris/pull/15489#issuecomment-1367325922 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] eldenmoon opened a new pull request, #15491: Pq opt
eldenmoon opened a new pull request, #15491: URL: https://github.com/apache/doris/pull/15491 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
