[GitHub] [doris] stalary commented on issue #11765: 请问in查询是不是不支持多个字段?
stalary commented on issue #11765: URL: https://github.com/apache/doris/issues/11765#issuecomment-1214306036 Yes, doris not support it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris-website] timelxy closed pull request #42: [fix] complete a subsetion that exists in English doc but missing in Chinese doc
timelxy closed pull request #42: [fix] complete a subsetion that exists in English doc but missing in Chinese doc URL: https://github.com/apache/doris-website/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11736: [bug](backup) fix backup restore raise `Storage backend not initialized.` error
github-actions[bot] commented on PR #11736: URL: https://github.com/apache/doris/pull/11736#issuecomment-1214306476 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] stalary commented on pull request #11737: "Spark load" supports string data type
stalary commented on PR #11737: URL: https://github.com/apache/doris/pull/11737#issuecomment-1214307592 Please modify your pr title. [Enhancement](spark load) Supports string data type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] stalary closed issue #9744: [Enhancement] group_concat support order by
stalary closed issue #9744: [Enhancement] group_concat support order by URL: https://github.com/apache/doris/issues/9744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] stalary closed issue #9577: [Feature] Improve Doris observability
stalary closed issue #9577: [Feature] Improve Doris observability URL: https://github.com/apache/doris/issues/9577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #11757: [fix](query) fix orderby keys limit return less or no result
BiteThet commented on code in PR #11757:
URL: https://github.com/apache/doris/pull/11757#discussion_r945248679
##
be/src/vec/exec/volap_scanner.h:
##
@@ -134,6 +134,7 @@ class VOlapScanner {
// time costed and row returned statistics
int64_t _num_rows_read = 0;
Review Comment:
Are `_num_rows_read` and `_raw_rows_read` always equal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yaoyi commented on issue #11765: 请问in查询是不是不支持多个字段?
yaoyi commented on issue #11765: URL: https://github.com/apache/doris/issues/11765#issuecomment-1214322386 > Yes, doris not support it. 请问有计划支持嘛? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman opened a new pull request, #11766: [doc](community) modify verify release doc
morningman opened a new pull request, #11766: URL: https://github.com/apache/doris/pull/11766 # Proposed changes Issue Number: close #xxx ## Problem summary Remove DISCLAIMER check ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11766: [doc](community) modify verify release doc
github-actions[bot] commented on PR #11766: URL: https://github.com/apache/doris/pull/11766#issuecomment-1214324136 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11766: [doc](community) modify verify release doc
github-actions[bot] commented on PR #11766: URL: https://github.com/apache/doris/pull/11766#issuecomment-1214324141 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] stalary commented on issue #11765: 请问in查询是不是不支持多个字段?
stalary commented on issue #11765: URL: https://github.com/apache/doris/issues/11765#issuecomment-1214331001 > > Yes, doris not support it. > > 请问有计划支持嘛? @stalary Is it generated in BI or used in code? I understand this syntax can be changed. No support is currently planned -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] luozenglin commented on a diff in pull request #11754: [fix](delete) fix query result error after delete
luozenglin commented on code in PR #11754:
URL: https://github.com/apache/doris/pull/11754#discussion_r945272616
##
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##
@@ -1199,6 +1199,34 @@ Status SegmentIterator::next_batch(vectorized::Block*
block) {
return Status::OK();
}
+void SegmentIterator::_convert_dict_code_for_predicate_if_necessary() {
+for (auto predicate : _short_cir_eval_predicate) {
+_convert_dict_code_for_predicate_if_necessary_impl(predicate);
+}
+
+for (auto predicate : _pre_eval_block_predicate) {
+_convert_dict_code_for_predicate_if_necessary_impl(predicate);
+}
+
+std::set predicate_set {};
+_opts.delete_condition_predicates->get_all_column_predicate(predicate_set);
Review Comment:
That sounds like a good idea. I have modified the code as you suggested.
thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] luozenglin commented on pull request #11754: [fix](delete) fix query result error after delete
luozenglin commented on PR #11754: URL: https://github.com/apache/doris/pull/11754#issuecomment-1214342915 > Please add regression test from the issue. done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] luozenglin commented on a diff in pull request #11754: [fix](delete) fix query result error after delete
luozenglin commented on code in PR #11754:
URL: https://github.com/apache/doris/pull/11754#discussion_r945274864
##
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##
@@ -1199,6 +1199,34 @@ Status SegmentIterator::next_batch(vectorized::Block*
block) {
return Status::OK();
}
+void SegmentIterator::_convert_dict_code_for_predicate_if_necessary() {
+for (auto predicate : _short_cir_eval_predicate) {
+_convert_dict_code_for_predicate_if_necessary_impl(predicate);
+}
+
+for (auto predicate : _pre_eval_block_predicate) {
+_convert_dict_code_for_predicate_if_necessary_impl(predicate);
+}
+
+std::set predicate_set {};
+_opts.delete_condition_predicates->get_all_column_predicate(predicate_set);
+for (const auto column_predicate : predicate_set) {
Review Comment:
Yes, dev-1.1.2 has the same problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] mrhhsg opened a new pull request, #11767: [fix](storage) Convert dict columns in delete_condition_predicates
mrhhsg opened a new pull request, #11767: URL: https://github.com/apache/doris/pull/11767 # Proposed changes Issue Number: #11425 ## Problem Summary For a quick fix for the branch dev-1.1.2, code from #11754 Thank @luozenglin . ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener closed pull request #9976: Remove the redundant "this."
jackwener closed pull request #9976: Remove the redundant "this." URL: https://github.com/apache/doris/pull/9976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener opened a new issue, #11768: [Enhancement] Use `NIO` to replace the legacy IO.
jackwener opened a new issue, #11768:
URL: https://github.com/apache/doris/issues/11768
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and
found no similar issues.
### Description
The legacy IO is hard to use.
After Java 7, the NIO is imported, it's easy to use and elegant.
```java
Old:
File file = new File("...");
file.createNewFile()
mkdir()
New:
Path path = Paths.get("");
..
```
like this
https://github.com/apache/doris/pull/11645/files#diff-470c2ed9f28730c3d42f0a11fed56f0a4dae030a9eb9c7521c9793ed6499ec8d
### Solution
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener closed issue #11496: [Bug] The result of left join operator is empty
jackwener closed issue #11496: [Bug] The result of left join operator is empty URL: https://github.com/apache/doris/issues/11496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener commented on issue #11496: [Bug] The result of left join operator is empty
jackwener commented on issue #11496: URL: https://github.com/apache/doris/issues/11496#issuecomment-1214399162 Solved, close it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener closed issue #11249: https://doris.incubator.apache.org/docs/get-starting/ Help docs describes the error
jackwener closed issue #11249: https://doris.incubator.apache.org/docs/get-starting/Help docs describes the error URL: https://github.com/apache/doris/issues/11249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener commented on issue #11249: https://doris.incubator.apache.org/docs/get-starting/ Help docs describes the error
jackwener commented on issue #11249: URL: https://github.com/apache/doris/issues/11249#issuecomment-1214399460 Solved, close it. Thanks for your feedback -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] AshinGau opened a new pull request, #11769: [feature-wip](parquet-reader) parquet physical type to doris logical type
AshinGau opened a new pull request, #11769: URL: https://github.com/apache/doris/pull/11769 # Proposed changes Two improvements have been added: 1. Translate parquet physical type into doris logical type. 2. Decode parquet column chunk to doris ColumnPtr, and add unit tests to show how to use related API. ## Doris Logical Typs ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [x] No - [ ] I don't know 3. Has unit tests been added: - [x] Yes - [ ] No - [ ] No Need 4. Has document been added or modified: - [ ] Yes - [x] No - [ ] No Need 5. Does it need to update dependencies: - [ ] Yes - [x] No 6. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [x] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xinyiZzz opened a new issue, #11770: [Bug] Flush memtable to reduce load channel mem not executed
xinyiZzz opened a new issue, #11770: URL: https://github.com/apache/doris/issues/11770 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version 32e451e6adf2ac52cfafa2eea300614f955576fa ### What's Wrong? When the load channel memory reaches `load_process_max_memory_limit_percent`, flush memtable to reduce mem consumption is not triggered. Causes the load memory to be uncontrolled. ### What You Expected? win ### How to Reproduce? _No response_ ### Anything Else? _No response_ ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #11745: [FIX](function)fix max_by function bug
morningman merged PR #11745: URL: https://github.com/apache/doris/pull/11745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch dev-1.1.2 updated: [fix](function)fix max_by function bug (#11745)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch dev-1.1.2
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/dev-1.1.2 by this push:
new ccf2f82be4 [fix](function)fix max_by function bug (#11745)
ccf2f82be4 is described below
commit ccf2f82be43d9170cb0c3373bd27338573e6d7c9
Author: starocean999 <40539150+starocean...@users.noreply.github.com>
AuthorDate: Mon Aug 15 09:06:54 2022 +0800
[fix](function)fix max_by function bug (#11745)
This pr does the same thing as #10650. Because the code base is so
different that it's easier to make the changes based on dev-1.1.2 than
cherry-pick
---
be/src/vec/CMakeLists.txt | 1 +
be/src/vec/data_types/data_type_factory.cpp| 100 +
be/src/vec/data_types/data_type_factory.hpp| 8 +-
be/src/vec/exprs/vectorized_agg_fn.cpp | 28 +++---
be/src/vec/exprs/vectorized_agg_fn.h | 2 +-
.../org/apache/doris/analysis/AggregateInfo.java | 18 ++--
.../apache/doris/analysis/FunctionCallExpr.java| 20 -
.../org/apache/doris/analysis/FunctionParams.java | 17
gensrc/thrift/Exprs.thrift | 1 +
gensrc/thrift/Types.thrift | 1 +
10 files changed, 166 insertions(+), 30 deletions(-)
diff --git a/be/src/vec/CMakeLists.txt b/be/src/vec/CMakeLists.txt
index d8adfe6d40..56cfdfcc14 100644
--- a/be/src/vec/CMakeLists.txt
+++ b/be/src/vec/CMakeLists.txt
@@ -73,6 +73,7 @@ set(VEC_FILES
data_types/nested_utils.cpp
data_types/data_type_date.cpp
data_types/data_type_date_time.cpp
+ data_types/data_type_factory.cpp
exec/vaggregation_node.cpp
exec/ves_http_scan_node.cpp
exec/ves_http_scanner.cpp
diff --git a/be/src/vec/data_types/data_type_factory.cpp
b/be/src/vec/data_types/data_type_factory.cpp
new file mode 100644
index 00..d78679d377
--- /dev/null
+++ b/be/src/vec/data_types/data_type_factory.cpp
@@ -0,0 +1,100 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+// This file is copied from
+//
https://github.com/ClickHouse/ClickHouse/blob/master/src/DataTypes/DataTypeFactory.cpp
+// and modified by Doris
+
+#include "vec/data_types/data_type_factory.hpp"
+#include "runtime/types.h"
+#include "vec/data_types/data_type.h"
+#include "vec/data_types/data_type_bitmap.h"
+#include "vec/data_types/data_type_date.h"
+#include "vec/data_types/data_type_date_time.h"
+#include "vec/data_types/data_type_decimal.h"
+#include "vec/data_types/data_type_nothing.h"
+#include "vec/data_types/data_type_nullable.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/data_types/data_type_string.h"
+
+namespace doris::vectorized {
+
+DataTypePtr DataTypeFactory::create_data_type(const TypeDescriptor& col_desc,
bool is_nullable) {
+DataTypePtr nested = nullptr;
+switch (col_desc.type) {
+case TYPE_BOOLEAN:
+nested = std::make_shared();
+break;
+case TYPE_TINYINT:
+nested = std::make_shared();
+break;
+case TYPE_SMALLINT:
+nested = std::make_shared();
+break;
+case TYPE_INT:
+nested = std::make_shared();
+break;
+case TYPE_FLOAT:
+nested = std::make_shared();
+break;
+case TYPE_BIGINT:
+nested = std::make_shared();
+break;
+case TYPE_LARGEINT:
+nested = std::make_shared();
+break;
+case TYPE_DATE:
+nested = std::make_shared();
+break;
+case TYPE_DATETIME:
+nested = std::make_shared();
+break;
+case TYPE_TIME:
+case TYPE_DOUBLE:
+nested = std::make_shared();
+break;
+case TYPE_STRING:
+case TYPE_CHAR:
+case TYPE_VARCHAR:
+nested = std::make_shared();
+break;
+case TYPE_HLL:
+nested = std::make_shared();
+break;
+case TYPE_OBJECT:
+nested = std::make_shared();
+break;
+case TYPE_DECIMALV2:
+nested =
std::make_shared>(27, 9);
+break;
+// Just Mock A NULL Type in Vec Exec Engine
+case TYPE_NULL:
+nested = std::make_shared(
[GitHub] [doris] xinyiZzz opened a new pull request, #11771: [fix](memtracker) Fix flush memtable to reduce load channel mem not executed
xinyiZzz opened a new pull request, #11771: URL: https://github.com/apache/doris/pull/11771 # Proposed changes Issue Number: close #11770 ## Problem summary 1. Reason: The memory value automatically tracked by the tcmalloc hook in the DeltaWriter is smaller than the value recorded manually in the memtable, because the first 4096-byte Chunk requested by each MemPool when the memtable is initialized is not recorded in the DeltaWriter by the hook. The values of the two are not equal, causing the `mem_consumption() == _mem_table->memory_usage ` branch judgment to fail. 2. Solution: In order to completely avoid the modification of mem tracker and affect the judgment of `mem_consumption() == _mem_table->memory_usage ` branch, change it to ` if (_flush_token->get_stats().flush_running_count == 0) `, flush_running_count is counted in FlushToken and divided Open two kinds of flush memory statistics logic. Memory value automatically tracked by tcmalloc hook in DeltaWriter for load channel Flush memtable is triggered when the mem limit is exceeded. The manually recorded value of the memtable is used to flush the memtable when it is larger than write_buffer_size. 3. Can use independent variables to control flush: At present, when the flush is larger than write_buffer_size, it is already manually controlled independently; When the flush is larger than the mem limit, the tcmallloc hook is still used for automatic statistics, and the selection of the flush DeltaWriter is realized based on the hierarchical relationship of the mem tracker. Currently, the memory value automatically tracked by the tcmalloc hook is 20% less than the manually recorded value in the memtable, because some of the freed memory is not allocated by the DeltaWriter. ` ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris-website] branch master updated: remove dup
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris-website.git The following commit(s) were added to refs/heads/master by this push: new 2b533bbb4db remove dup 2b533bbb4db is described below commit 2b533bbb4dbe19020d1cd044b890c5de75de626e Author: jiafeng.zhang AuthorDate: Mon Aug 15 09:28:31 2022 +0800 remove dup --- sidebars.json | 1 - 1 file changed, 1 deletion(-) diff --git a/sidebars.json b/sidebars.json index a6ad696f2f8..1999efd7e4c 100644 --- a/sidebars.json +++ b/sidebars.json @@ -378,7 +378,6 @@ "sql-manual/sql-functions/bitmap-functions/bitmap_or", "sql-manual/sql-functions/bitmap-functions/bitmap_and_count", "sql-manual/sql-functions/bitmap-functions/bitmap_or_count", - "sql-manual/sql-functions/bitmap-functions/bitmap_xor", "sql-manual/sql-functions/bitmap-functions/bitmap_xor_count", "sql-manual/sql-functions/bitmap-functions/bitmap_not", "sql-manual/sql-functions/bitmap-functions/bitmap_and_not", - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris-website] branch asf-site updated: Create remove-non-reserved-dir.sh
This is an automated email from the ASF dual-hosted git repository.
jiafengzheng pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/doris-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 08d5f20e908 Create remove-non-reserved-dir.sh
08d5f20e908 is described below
commit 08d5f20e90890dc70dd41d3c2c45d4cebc46d17b
Author: jiafeng.zhang
AuthorDate: Mon Aug 15 09:31:20 2022 +0800
Create remove-non-reserved-dir.sh
---
remove-non-reserved-dir.sh | 38 ++
1 file changed, 38 insertions(+)
diff --git a/remove-non-reserved-dir.sh b/remove-non-reserved-dir.sh
new file mode 100644
index 000..42a3d65be95
--- /dev/null
+++ b/remove-non-reserved-dir.sh
@@ -0,0 +1,38 @@
+#!/bin/bash
+
+set -eo pipefail
+
+ROOT=`dirname "$0"`
+ROOT=`cd "$ROOT"; pwd`
+
+reserved=(
+build
+remove-non-reserved-dir.sh
+versions.json
+.asf.yaml
+.nojekyll
+.git
+.
+..
+)
+
+function contains() {
+local n=$#
+local value=${!n}
+for ((i=1;i < $#;i++)) {
+if [ "${!i}" == "${value}" ]; then
+echo "y"
+return 0
+fi
+}
+echo "n"
+return 1
+}
+
+for file in `ls -a $ROOT`
+do
+if [ $(contains "${reserved[@]}" "$file") == "n" ]; then
+echo "delete $ROOT/$file"
+rm -rf $ROOT/$file
+fi
+done
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[doris-website] branch master updated: complete Chinese missing doc section that exist in English (#43)
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris-website.git The following commit(s) were added to refs/heads/master by this push: new 5dd2eb94314 complete Chinese missing doc section that exist in English (#43) 5dd2eb94314 is described below commit 5dd2eb943148a2616b6224510068ce1e5dc05338 Author: timey AuthorDate: Mon Aug 15 09:38:59 2022 +0800 complete Chinese missing doc section that exist in English (#43) --- .../current/design/grouping_sets_design.md | 6 +- .../version-0.15/internal/grouping_sets_design.md | 6 +- .../version-1.0/internal/grouping_sets_design.md| 6 +- 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/i18n/zh-CN/docusaurus-plugin-content-docs-community/current/design/grouping_sets_design.md b/i18n/zh-CN/docusaurus-plugin-content-docs-community/current/design/grouping_sets_design.md index 0c19094cffc..6ca788064c5 100644 --- a/i18n/zh-CN/docusaurus-plugin-content-docs-community/current/design/grouping_sets_design.md +++ b/i18n/zh-CN/docusaurus-plugin-content-docs-community/current/design/grouping_sets_design.md @@ -502,7 +502,11 @@ select NULL, NULL, sum(k3) from t; 在 GroupByClause 类中为了将 GROUPING_ID 加到 groupingExprs 表达式列表中，需要创建 virtual SlotRef, 相应的，需要对这个 slot 创建一个 tuple, 叫 GROUPING_ID Tuple。 -对于 RepeatNode 这个执行计划，其输入是子节点的所有 tuple， 输出的 tuple 除了 repeat 子节点的数据外，还需要填写 GROUPING_ID 和其他grouping，grouping_id 对应的虚拟列，因此。 +对于 RepeatNode 这个执行计划，其输入是子节点的所有 tuple， 输出的 tuple 除了 repeat 子节点的数据外，还需要填写 GROUPING_ID 和其他grouping，grouping_id 对应的虚拟列。 + + 3.3.3 表达式和函数替换 +group子句表达式拓展：`expr -> if(bitand(pos, grouping_id)=0, expr, null)` +grouping_id函数：`grouping_id() -> grouping_id(grouping_id)` ### 3.4 BE 查询执行阶段 diff --git a/i18n/zh-CN/docusaurus-plugin-content-docs/version-0.15/internal/grouping_sets_design.md b/i18n/zh-CN/docusaurus-plugin-content-docs/version-0.15/internal/grouping_sets_design.md index 0c19094cffc..6ca788064c5 100644 --- a/i18n/zh-CN/docusaurus-plugin-content-docs/version-0.15/internal/grouping_sets_design.md +++ b/i18n/zh-CN/docusaurus-plugin-content-docs/version-0.15/internal/grouping_sets_design.md @@ -502,7 +502,11 @@ select NULL, NULL, sum(k3) from t; 在 GroupByClause 类中为了将 GROUPING_ID 加到 groupingExprs 表达式列表中，需要创建 virtual SlotRef, 相应的，需要对这个 slot 创建一个 tuple, 叫 GROUPING_ID Tuple。 -对于 RepeatNode 这个执行计划，其输入是子节点的所有 tuple， 输出的 tuple 除了 repeat 子节点的数据外，还需要填写 GROUPING_ID 和其他grouping，grouping_id 对应的虚拟列，因此。 +对于 RepeatNode 这个执行计划，其输入是子节点的所有 tuple， 输出的 tuple 除了 repeat 子节点的数据外，还需要填写 GROUPING_ID 和其他grouping，grouping_id 对应的虚拟列。 + + 3.3.3 表达式和函数替换 +group子句表达式拓展：`expr -> if(bitand(pos, grouping_id)=0, expr, null)` +grouping_id函数：`grouping_id() -> grouping_id(grouping_id)` ### 3.4 BE 查询执行阶段 diff --git a/i18n/zh-CN/docusaurus-plugin-content-docs/version-1.0/internal/grouping_sets_design.md b/i18n/zh-CN/docusaurus-plugin-content-docs/version-1.0/internal/grouping_sets_design.md index 0c19094cffc..6ca788064c5 100644 --- a/i18n/zh-CN/docusaurus-plugin-content-docs/version-1.0/internal/grouping_sets_design.md +++ b/i18n/zh-CN/docusaurus-plugin-content-docs/version-1.0/internal/grouping_sets_design.md @@ -502,7 +502,11 @@ select NULL, NULL, sum(k3) from t; 在 GroupByClause 类中为了将 GROUPING_ID 加到 groupingExprs 表达式列表中，需要创建 virtual SlotRef, 相应的，需要对这个 slot 创建一个 tuple, 叫 GROUPING_ID Tuple。 -对于 RepeatNode 这个执行计划，其输入是子节点的所有 tuple， 输出的 tuple 除了 repeat 子节点的数据外，还需要填写 GROUPING_ID 和其他grouping，grouping_id 对应的虚拟列，因此。 +对于 RepeatNode 这个执行计划，其输入是子节点的所有 tuple， 输出的 tuple 除了 repeat 子节点的数据外，还需要填写 GROUPING_ID 和其他grouping，grouping_id 对应的虚拟列。 + + 3.3.3 表达式和函数替换 +group子句表达式拓展：`expr -> if(bitand(pos, grouping_id)=0, expr, null)` +grouping_id函数：`grouping_id() -> grouping_id(grouping_id)` ### 3.4 BE 查询执行阶段 - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris-website] hf200012 merged pull request #43: complete Chinese missing doc section that exist in English
hf200012 merged PR #43: URL: https://github.com/apache/doris-website/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hf200012 merged pull request #11766: [doc](community) modify verify release doc
hf200012 merged PR #11766: URL: https://github.com/apache/doris/pull/11766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [doc](community) modify verify release doc (#11766)
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 073e46097f [doc](community) modify verify release doc (#11766) 073e46097f is described below commit 073e46097f7630993c36531d16ea6ee4114a6f41 Author: Mingyu Chen AuthorDate: Mon Aug 15 09:59:17 2022 +0800 [doc](community) modify verify release doc (#11766) modify verify release doc --- docs/en/community/release-and-verify/release-verify.md| 15 +++ docs/zh-CN/community/release-and-verify/release-verify.md | 15 +++ 2 files changed, 14 insertions(+), 16 deletions(-) diff --git a/docs/en/community/release-and-verify/release-verify.md b/docs/en/community/release-and-verify/release-verify.md index 93654bcf06..f95c73d85d 100644 --- a/docs/en/community/release-and-verify/release-verify.md +++ b/docs/en/community/release-and-verify/release-verify.md @@ -30,14 +30,13 @@ This validation step can be used for validation during release polling and also The following steps can be followed to verify. -1. [ ] Whether the download link is legitimate. -2. [ ] Whether the checksum and PGP signature are legitimate. 3. -3. [ ] Whether the DISCLAIMER or DISCLAIMER-WIP is included. -4. [ ] Whether the code matches the current release. -5. [ ] Whether the LICENSE and NOTICE files are correct. -6. [ ] All files carry the necessary protocol descriptions. -7. [ ] No compiled content is included in the source package. -8. [ ] Whether the compilation can be executed without problems. +1. [ ] The download link is legal. +2. [ ] The PGP signature are valid. +3. [ ] The source code matches the current release version. +4. [ ] The LICENSE and NOTICE files are correct. +5. [ ] All files carry the necessary protocol header. +6. [ ] The compiled content is not included in the source package. +7. [ ] The compilation can be executed smoothly. Here we use the verification of the Doris Core version as an example. Note that other components have their corresponding names changed. diff --git a/docs/zh-CN/community/release-and-verify/release-verify.md b/docs/zh-CN/community/release-and-verify/release-verify.md index 4030152baa..3dd1cd6243 100644 --- a/docs/zh-CN/community/release-and-verify/release-verify.md +++ b/docs/zh-CN/community/release-and-verify/release-verify.md @@ -30,14 +30,13 @@ under the License. 可以按照以下步骤进行验证： -1. [ ] 下载链接是否合法。 -2. [ ] 校验值和 PGP 签名是否合法。 -3. [ ] 是否包含 DISCLAIMER 或 DISCLAIMER-WIP 文件。 -4. [ ] 代码是否和当前发布版本相匹配。 -5. [ ] LICENSE 和 NOTICE 文件是否正确。 -6. [ ] 所有文件都携带必要的协议说明。 -7. [ ] 在源码包中不包含已经编译好的内容。 -8. [ ] 编译是否能够顺利执行。 +1. [ ] 下载链接合法。 +2. [ ] 校验值和 PGP 签名合法。 +3. [ ] 代码和当前发布版本相匹配。 +4. [ ] LICENSE 和 NOTICE 文件正确。 +5. [ ] 所有文件都携带必要的协议说明。 +6. [ ] 在源码包中不包含已经编译好的内容。 +7. [ ] 编译能够顺利执行。 这里我们以 Doris Core 版本的验证为例。其他组件注意修改对应名称。 - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11760: [remote-udaf](sample) add some python demo
github-actions[bot] commented on PR #11760: URL: https://github.com/apache/doris/pull/11760#issuecomment-1214531709 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11760: [remote-udaf](sample) add some python demo
github-actions[bot] commented on PR #11760: URL: https://github.com/apache/doris/pull/11760#issuecomment-1214531740 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11756: [doc](fix)fix-doc
github-actions[bot] commented on PR #11756: URL: https://github.com/apache/doris/pull/11756#issuecomment-1214532303 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11741: [docs](fix)[fix some error path]
github-actions[bot] commented on PR #11741: URL: https://github.com/apache/doris/pull/11741#issuecomment-1214532673 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] englefly opened a new pull request, #11772: [fix](Nereids) fix a bug in multJoin: if there is no condition, create cross join
englefly opened a new pull request, #11772: URL: https://github.com/apache/doris/pull/11772 # Proposed changes In MultiJoin transform, if there is no condition, we should generate cross join instead of inner join Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11771: [fix](memtracker) Fix flush memtable to reduce load channel mem not executed
github-actions[bot] commented on PR #11771: URL: https://github.com/apache/doris/pull/11771#issuecomment-1214535999 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11771: [fix](memtracker) Fix flush memtable to reduce load channel mem not executed
github-actions[bot] commented on PR #11771: URL: https://github.com/apache/doris/pull/11771#issuecomment-1214536012 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11748: [Bugfix](schema change) fix memory exceeded when schema change
github-actions[bot] commented on PR #11748: URL: https://github.com/apache/doris/pull/11748#issuecomment-1214540593 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11748: [Bugfix](schema change) fix memory exceeded when schema change
github-actions[bot] commented on PR #11748: URL: https://github.com/apache/doris/pull/11748#issuecomment-1214540630 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] englefly commented on pull request #11772: [fix](Nereids) fix a bug in multJoin: if there is no condition, create cross join
englefly commented on PR #11772: URL: https://github.com/apache/doris/pull/11772#issuecomment-1214540977 @wangshuo128 @jackwener could you review, please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
svn commit: r56283 - /dev/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.13_2.11-1.0.3-src.tar.gz.asc /release/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.13_2.11-1.0.3-src.
Author: jiafengzheng Date: Mon Aug 15 02:20:11 2022 New Revision: 56283 Log: move doris flink connector 1.13_2.11-1.0.3 to release Added: release/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.13_2.11-1.0.3-src.tar.gz.asc - copied unchanged from r56282, dev/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.13_2.11-1.0.3-src.tar.gz.asc Removed: dev/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.13_2.11-1.0.3-src.tar.gz.asc - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
svn commit: r56279 - /dev/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.12_2.11-1.0.3-src.tar.gz /release/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.12_2.11-1.0.3-src.tar.
Author: jiafengzheng Date: Mon Aug 15 02:19:45 2022 New Revision: 56279 Log: move doris flink connector 1.12_2.11-1.0.3 to release Added: release/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.12_2.11-1.0.3-src.tar.gz - copied unchanged from r56278, dev/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.12_2.11-1.0.3-src.tar.gz Removed: dev/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.12_2.11-1.0.3-src.tar.gz - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
svn commit: r56278 - /dev/doris/flink-connector/1.2.0/ /release/doris/flink-connector/1.2.0/
Author: jiafengzheng Date: Mon Aug 15 02:19:38 2022 New Revision: 56278 Log: move doris flink connector 1.2.0 to release Added: release/doris/flink-connector/1.2.0/ - copied from r56277, dev/doris/flink-connector/1.2.0/ Removed: dev/doris/flink-connector/1.2.0/ - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
svn commit: r56282 - /dev/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.13_2.11-1.0.3-src.tar.gz /release/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.13_2.11-1.0.3-src.tar.
Author: jiafengzheng Date: Mon Aug 15 02:20:04 2022 New Revision: 56282 Log: move doris flink connector 1.13_2.11-1.0.3 to release Added: release/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.13_2.11-1.0.3-src.tar.gz - copied unchanged from r56281, dev/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.13_2.11-1.0.3-src.tar.gz Removed: dev/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.13_2.11-1.0.3-src.tar.gz - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
svn commit: r56281 - /dev/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.12_2.11-1.0.3-src.tar.gz.sha512 /release/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.12_2.11-1.0.3-s
Author: jiafengzheng Date: Mon Aug 15 02:19:58 2022 New Revision: 56281 Log: move doris flink connector 1.12_2.11-1.0.3 to release Added: release/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.12_2.11-1.0.3-src.tar.gz.sha512 - copied unchanged from r56280, dev/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.12_2.11-1.0.3-src.tar.gz.sha512 Removed: dev/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.12_2.11-1.0.3-src.tar.gz.sha512 - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
svn commit: r56284 - /dev/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.13_2.11-1.0.3-src.tar.gz.sha512 /release/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.13_2.11-1.0.3-s
Author: jiafengzheng Date: Mon Aug 15 02:20:17 2022 New Revision: 56284 Log: move doris flink connector 1.13_2.11-1.0.3 to release Added: release/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.13_2.11-1.0.3-src.tar.gz.sha512 - copied unchanged from r56283, dev/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.13_2.11-1.0.3-src.tar.gz.sha512 Removed: dev/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.13_2.11-1.0.3-src.tar.gz.sha512 - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
svn commit: r56280 - /dev/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.12_2.11-1.0.3-src.tar.gz.asc /release/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.12_2.11-1.0.3-src.
Author: jiafengzheng Date: Mon Aug 15 02:19:51 2022 New Revision: 56280 Log: move doris flink connector 1.12_2.11-1.0.3 to release Added: release/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.12_2.11-1.0.3-src.tar.gz.asc - copied unchanged from r56279, dev/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.12_2.11-1.0.3-src.tar.gz.asc Removed: dev/doris/flink-connector/1.0.3/apache-doris-flink-connector-1.12_2.11-1.0.3-src.tar.gz.asc - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #11761: [remote-udaf](sample) add some c++ demo
morningman commented on code in PR #11761:
URL: https://github.com/apache/doris/pull/11761#discussion_r945388011
##
samples/doris-demo/remote-udaf-cpp-demo/README.md:
##
@@ -25,4 +25,132 @@ under the License.
# Run
`./function_server 9000`
-`9000` is the port that the server will listen on
\ No newline at end of file
+`9000` is the port that the server will listen on
+
+
+# Demo
+
+```
+//create one table such as table2
+CREATE TABLE `table2` (
+ `event_day` date NULL,
+ `siteid` int(11) NULL DEFAULT "10",
+ `citycode` smallint(6) NULL,
+ `visitinfo` varchar(1024) NULL DEFAULT "",
+ `pv` varchar(1024) REPLACE NULL DEFAULT "0"
+) ENGINE=OLAP
+AGGREGATE KEY(`event_day`, `siteid`, `citycode`, `visitinfo`)
+COMMENT 'OLAP'
+DISTRIBUTED BY HASH(`siteid`) BUCKETS 10
+PROPERTIES (
+"replication_allocation" = "tag.location.default: 1",
+"in_memory" = "false",
+"storage_format" = "V2"
+)
+//import some data
+MySQL [test_db]> select * from table2;
++++--++--+
+| event_day | siteid | citycode | visitinfo | pv |
++++--++--+
+| 2017-07-03 | 8 | 12 | {"ip":"192.168.0.5","source":"pc"} | 81 |
+| 2017-07-03 | 37 | 12 | {"ip":"192.168.0.3","source":"pc"} | 81 |
+| 2017-07-03 | 67 | 16 | {"ip":"192.168.0.2","source":"pc"} | 79 |
+| 2017-07-03 |101 | 11 | {"ip":"192.168.0.5","source":"pc"} | 65 |
+| 2017-07-03 | 32 | 15 | {"ip":"192.168.0.1","source":"pc"} | 188 |
+| 2017-07-03 |103 | 12 | {"ip":"192.168.0.5","source":"pc"} | 123 |
+| 2017-07-03 |104 | 16 | {"ip":"192.168.0.5","source":"pc"} | 79 |
+| 2017-07-03 | 3 | 12 | {"ip":"192.168.0.3","source":"pc"} | 123 |
+| 2017-07-03 | 3 | 15 | {"ip":"192.168.0.2","source":"pc"} | 188 |
+| 2017-07-03 | 13 | 11 | {"ip":"192.168.0.1","source":"pc"} | 65 |
+| 2017-07-03 | 53 | 12 | {"ip":"192.168.0.2","source":"pc"} | 123 |
+| 2017-07-03 | 1 | 11 | {"ip":"192.168.0.1","source":"pc"} | 65 |
+| 2017-07-03 | 7 | 16 | {"ip":"192.168.0.4","source":"pc"} | 79 |
+| 2017-07-03 |102 | 15 | {"ip":"192.168.0.5","source":"pc"} | 188 |
+| 2017-07-03 |105 | 12 | {"ip":"192.168.0.5","source":"pc"} | 81 |
++++--++--+
+```
+
+### 1. find most visit top 3 ip
+c++ demo not implement,If you are interested you can reference java/python
demo
Review Comment:
remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11753: [enhancement](status) Fix Status related macros to enable RVO or move ctor
github-actions[bot] commented on PR #11753: URL: https://github.com/apache/doris/pull/11753#issuecomment-1214548819 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11753: [enhancement](status) Fix Status related macros to enable RVO or move ctor
github-actions[bot] commented on PR #11753: URL: https://github.com/apache/doris/pull/11753#issuecomment-1214548843 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yixiutt commented on a diff in pull request #11625: [Enhancement](load) add hidden_columns in stream load param
yixiutt commented on code in PR #11625:
URL: https://github.com/apache/doris/pull/11625#discussion_r945390100
##
fe/fe-core/src/main/java/org/apache/doris/task/StreamLoadTask.java:
##
@@ -320,6 +328,9 @@ private void
setOptionalFromTSLPutRequest(TStreamLoadPutRequest request) throws
if (request.isSetLoadToSingleTablet()) {
loadToSingleTablet = request.isLoadToSingleTablet();
}
+if (request.isSetHiddenColumns()) {
+hiddenColumns =
Arrays.asList(request.getHiddenColumns().split(","));
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yixiutt commented on a diff in pull request #11625: [Enhancement](load) add hidden_columns in stream load param
yixiutt commented on code in PR #11625: URL: https://github.com/apache/doris/pull/11625#discussion_r945390345 ## docs/en/docs/sql-manual/sql-reference/Data-Manipulation-Statements/Load/STREAM-LOAD.md: ## @@ -136,6 +136,14 @@ Parameter introduction: 21. send_batch_parallelism: Integer, used to set the parallelism of sending batch data. If the value of parallelism exceeds `max_send_batch_parallelism_per_job` in the BE configuration, the BE as a coordination point will use the value of `max_send_batch_parallelism_per_job`. +22. hidden_columns: Specify hidden column when no `columns` in Headers，multi hidden column shoud be +separated by commas。 + + ``` + hidden_columns: __DORIS_DELETE_SIGN__ Review Comment: use the order specified by user is easy to understand -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #11708: [refactor](date) Use uint32 as predicate type for date type
BiteThet merged PR #11708: URL: https://github.com/apache/doris/pull/11708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [refactor](date) Use uint32 as predicate type for date type (#11708)
This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 77e241cbb0 [refactor](date) Use uint32 as predicate type for date type
(#11708)
77e241cbb0 is described below
commit 77e241cbb0b907a99fb61dbf82925908ef093e96
Author: Gabriel
AuthorDate: Mon Aug 15 11:12:33 2022 +0800
[refactor](date) Use uint32 as predicate type for date type (#11708)
Use uint32 as predicate type for date type
---
be/src/olap/comparison_predicate.h | 111 +++--
be/src/olap/in_list_predicate.h| 75 +--
be/src/olap/predicate_creator.h| 44 ++--
be/src/util/date_func.cpp | 9 +--
be/src/util/date_func.h| 2 +-
be/test/olap/comparison_predicate_test.cpp | 28 +---
be/test/olap/in_list_predicate_test.cpp| 10 +--
7 files changed, 159 insertions(+), 120 deletions(-)
diff --git a/be/src/olap/comparison_predicate.h
b/be/src/olap/comparison_predicate.h
index ad36d59503..f953f196f2 100644
--- a/be/src/olap/comparison_predicate.h
+++ b/be/src/olap/comparison_predicate.h
@@ -27,17 +27,9 @@ namespace doris {
template
class ComparisonPredicateBase : public ColumnPredicate {
public:
-using T = std::conditional_t::PredicateFieldType>;
+using T = typename PredicatePrimitiveTypeTraits::PredicateFieldType;
ComparisonPredicateBase(uint32_t column_id, const T& value, bool opposite
= false)
-: ColumnPredicate(column_id, opposite), _value(value) {
-if constexpr (std::is_same_v) {
-_value_real = 0;
-memory_copy(&_value_real, _value.get_data(), sizeof(T));
-} else {
-_value_real = _value;
-}
-}
+: ColumnPredicate(column_id, opposite), _value(value) {}
PredicateType type() const override { return PT; }
@@ -47,17 +39,34 @@ public:
for (uint16_t i = 0; i < *size; ++i) {
uint16_t idx = sel[i];
sel[new_size] = idx;
-const T* cell_value = reinterpret_cast(block->cell(idx).cell_ptr());
-auto result = (!block->cell(idx).is_null() &&
_operator(*cell_value, _value));
-new_size += _opposite ? !result : result;
+if constexpr (Type == TYPE_DATE) {
+T tmp_uint32_value = 0;
+memcpy((char*)(&tmp_uint32_value),
block->cell(idx).cell_ptr(),
+ sizeof(uint24_t));
+auto result =
+(!block->cell(idx).is_null() &&
_operator(tmp_uint32_value, _value));
+new_size += _opposite ? !result : result;
+} else {
+const T* cell_value = reinterpret_cast(block->cell(idx).cell_ptr());
+auto result = (!block->cell(idx).is_null() &&
_operator(*cell_value, _value));
+new_size += _opposite ? !result : result;
+}
}
} else {
for (uint16_t i = 0; i < *size; ++i) {
uint16_t idx = sel[i];
sel[new_size] = idx;
-const T* cell_value = reinterpret_cast(block->cell(idx).cell_ptr());
-auto result = _operator(*cell_value, _value);
-new_size += _opposite ? !result : result;
+if constexpr (Type == TYPE_DATE) {
+T tmp_uint32_value = 0;
+memcpy((char*)(&tmp_uint32_value),
block->cell(idx).cell_ptr(),
+ sizeof(uint24_t));
+auto result = _operator(tmp_uint32_value, _value);
+new_size += _opposite ? !result : result;
+} else {
+const T* cell_value = reinterpret_cast(block->cell(idx).cell_ptr());
+auto result = _operator(*cell_value, _value);
+new_size += _opposite ? !result : result;
+}
}
}
*size = new_size;
@@ -70,9 +79,18 @@ public:
continue;
}
uint16_t idx = sel[i];
-const T* cell_value = reinterpret_cast(block->cell(idx).cell_ptr());
-auto result = (!block->cell(idx).is_null() &&
_operator(*cell_value, _value));
-flags[i] = flags[i] | (_opposite ? !result : result);
+if constexpr (Type == TYPE_DATE) {
+T tmp_uint32_value = 0;
+memcpy((char*)(&tmp_uint32_value),
block->cell(idx).cell_ptr(),
+ sizeof(uint24_t));
+auto result =
+(!block->cell(idx).is_null() &&
_operator(tmp_uint32_value, _value));
+flags[i] = flags[i]
[GitHub] [doris] HappenLee opened a new pull request, #11773: [opt](join) speed up large data outer join
HappenLee opened a new pull request, #11773: URL: https://github.com/apache/doris/pull/11773 # Proposed changes Issue Number: close #xxx ## Problem summary speed up the bottom patch of outer join ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] caiconghui opened a new pull request, #11774: [Fix](image)(upgrade) Clear all DECOMMISSION_BACKEND job to be compatible with newer version
caiconghui opened a new pull request, #11774: URL: https://github.com/apache/doris/pull/11774 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Kikyou1997 opened a new pull request, #11775: Nereids projection
Kikyou1997 opened a new pull request, #11775: URL: https://github.com/apache/doris/pull/11775 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11772: [fix](Nereids) fix a bug in multJoin: if there is no condition, create cross join
github-actions[bot] commented on PR #11772: URL: https://github.com/apache/doris/pull/11772#issuecomment-1214576593 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #11714: [fix](thirdparty) Fix the errors while building brpc
adonis0147 commented on code in PR #11714:
URL: https://github.com/apache/doris/pull/11714#discussion_r945404428
##
thirdparty/patches/brpc-1.2.0.patch:
##
@@ -0,0 +1,13 @@
+diff --git a/tools/rpc_press/rpc_press_impl.cpp
b/tools/rpc_press/rpc_press_impl.cpp
+index 8a873eff..d1ff2a1e 100644
+--- a/tools/rpc_press/rpc_press_impl.cpp
b/tools/rpc_press/rpc_press_impl.cpp
+@@ -222,7 +222,7 @@ void RpcPress::sync_client() {
+ int64_t last_expected_time = butil::monotonic_time_ns();
+ const int64_t interval = (int64_t) (10L / req_rate);
+ // the max tolerant delay between end_time and expected_time. 10ms or 10
intervals
+-int64_t max_tolerant_delay = std::max(1000L, 10 * interval);
++int64_t max_tolerant_delay = std::max(1000L, 10 * interval);
Review Comment:
BRPC have fixed it in https://github.com/apache/incubator-brpc/pull/1846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] chenlinzhong commented on a diff in pull request #11761: [remote-udaf](sample) add some c++ demo
chenlinzhong commented on code in PR #11761:
URL: https://github.com/apache/doris/pull/11761#discussion_r945406344
##
samples/doris-demo/remote-udaf-cpp-demo/README.md:
##
@@ -25,4 +25,132 @@ under the License.
# Run
`./function_server 9000`
-`9000` is the port that the server will listen on
\ No newline at end of file
+`9000` is the port that the server will listen on
+
+
+# Demo
+
+```
+//create one table such as table2
+CREATE TABLE `table2` (
+ `event_day` date NULL,
+ `siteid` int(11) NULL DEFAULT "10",
+ `citycode` smallint(6) NULL,
+ `visitinfo` varchar(1024) NULL DEFAULT "",
+ `pv` varchar(1024) REPLACE NULL DEFAULT "0"
+) ENGINE=OLAP
+AGGREGATE KEY(`event_day`, `siteid`, `citycode`, `visitinfo`)
+COMMENT 'OLAP'
+DISTRIBUTED BY HASH(`siteid`) BUCKETS 10
+PROPERTIES (
+"replication_allocation" = "tag.location.default: 1",
+"in_memory" = "false",
+"storage_format" = "V2"
+)
+//import some data
+MySQL [test_db]> select * from table2;
++++--++--+
+| event_day | siteid | citycode | visitinfo | pv |
++++--++--+
+| 2017-07-03 | 8 | 12 | {"ip":"192.168.0.5","source":"pc"} | 81 |
+| 2017-07-03 | 37 | 12 | {"ip":"192.168.0.3","source":"pc"} | 81 |
+| 2017-07-03 | 67 | 16 | {"ip":"192.168.0.2","source":"pc"} | 79 |
+| 2017-07-03 |101 | 11 | {"ip":"192.168.0.5","source":"pc"} | 65 |
+| 2017-07-03 | 32 | 15 | {"ip":"192.168.0.1","source":"pc"} | 188 |
+| 2017-07-03 |103 | 12 | {"ip":"192.168.0.5","source":"pc"} | 123 |
+| 2017-07-03 |104 | 16 | {"ip":"192.168.0.5","source":"pc"} | 79 |
+| 2017-07-03 | 3 | 12 | {"ip":"192.168.0.3","source":"pc"} | 123 |
+| 2017-07-03 | 3 | 15 | {"ip":"192.168.0.2","source":"pc"} | 188 |
+| 2017-07-03 | 13 | 11 | {"ip":"192.168.0.1","source":"pc"} | 65 |
+| 2017-07-03 | 53 | 12 | {"ip":"192.168.0.2","source":"pc"} | 123 |
+| 2017-07-03 | 1 | 11 | {"ip":"192.168.0.1","source":"pc"} | 65 |
+| 2017-07-03 | 7 | 16 | {"ip":"192.168.0.4","source":"pc"} | 79 |
+| 2017-07-03 |102 | 15 | {"ip":"192.168.0.5","source":"pc"} | 188 |
+| 2017-07-03 |105 | 12 | {"ip":"192.168.0.5","source":"pc"} | 81 |
++++--++--+
+```
+
+### 1. find most visit top 3 ip
+c++ demo not implement,If you are interested you can reference java/python
demo
Review Comment:
why ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 merged pull request #11406: [feature-wip](array-type) add the array_join function
xy720 merged PR #11406: URL: https://github.com/apache/doris/pull/11406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (77e241cbb0 -> 8c8f48c4c2)
This is an automated email from the ASF dual-hosted git repository. xuyang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 77e241cbb0 [refactor](date) Use uint32 as predicate type for date type (#11708) add 8c8f48c4c2 [feature-wip](array-type) add the array_join function (#11406) No new revisions were added by this update. Summary of changes: .../functions/array/function_array_aggregation.cpp | 16 +- be/src/vec/functions/array/function_array_join.h | 243 + be/src/vec/functions/array/function_array_mapped.h | 12 +- .../sql-functions/array-functions/array_join.md| 104 + .../sql-functions/array-functions/array_join.md| 104 + gensrc/script/doris_builtins_functions.py | 31 +++ .../array_functions/test_array_functions.out | 9 + .../array_functions/test_array_functions.groovy| 1 + 8 files changed, 512 insertions(+), 8 deletions(-) create mode 100644 be/src/vec/functions/array/function_array_join.h create mode 100644 docs/en/docs/sql-manual/sql-functions/array-functions/array_join.md create mode 100644 docs/zh-CN/docs/sql-manual/sql-functions/array-functions/array_join.md - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] chenlinzhong commented on a diff in pull request #11761: [remote-udaf](sample) add some c++ demo
chenlinzhong commented on code in PR #11761:
URL: https://github.com/apache/doris/pull/11761#discussion_r945408087
##
samples/doris-demo/remote-udaf-cpp-demo/README.md:
##
@@ -25,4 +25,132 @@ under the License.
# Run
`./function_server 9000`
-`9000` is the port that the server will listen on
\ No newline at end of file
+`9000` is the port that the server will listen on
+
+
+# Demo
+
+```
+//create one table such as table2
+CREATE TABLE `table2` (
+ `event_day` date NULL,
+ `siteid` int(11) NULL DEFAULT "10",
+ `citycode` smallint(6) NULL,
+ `visitinfo` varchar(1024) NULL DEFAULT "",
+ `pv` varchar(1024) REPLACE NULL DEFAULT "0"
+) ENGINE=OLAP
+AGGREGATE KEY(`event_day`, `siteid`, `citycode`, `visitinfo`)
+COMMENT 'OLAP'
+DISTRIBUTED BY HASH(`siteid`) BUCKETS 10
+PROPERTIES (
+"replication_allocation" = "tag.location.default: 1",
+"in_memory" = "false",
+"storage_format" = "V2"
+)
+//import some data
+MySQL [test_db]> select * from table2;
++++--++--+
+| event_day | siteid | citycode | visitinfo | pv |
++++--++--+
+| 2017-07-03 | 8 | 12 | {"ip":"192.168.0.5","source":"pc"} | 81 |
+| 2017-07-03 | 37 | 12 | {"ip":"192.168.0.3","source":"pc"} | 81 |
+| 2017-07-03 | 67 | 16 | {"ip":"192.168.0.2","source":"pc"} | 79 |
+| 2017-07-03 |101 | 11 | {"ip":"192.168.0.5","source":"pc"} | 65 |
+| 2017-07-03 | 32 | 15 | {"ip":"192.168.0.1","source":"pc"} | 188 |
+| 2017-07-03 |103 | 12 | {"ip":"192.168.0.5","source":"pc"} | 123 |
+| 2017-07-03 |104 | 16 | {"ip":"192.168.0.5","source":"pc"} | 79 |
+| 2017-07-03 | 3 | 12 | {"ip":"192.168.0.3","source":"pc"} | 123 |
+| 2017-07-03 | 3 | 15 | {"ip":"192.168.0.2","source":"pc"} | 188 |
+| 2017-07-03 | 13 | 11 | {"ip":"192.168.0.1","source":"pc"} | 65 |
+| 2017-07-03 | 53 | 12 | {"ip":"192.168.0.2","source":"pc"} | 123 |
+| 2017-07-03 | 1 | 11 | {"ip":"192.168.0.1","source":"pc"} | 65 |
+| 2017-07-03 | 7 | 16 | {"ip":"192.168.0.4","source":"pc"} | 79 |
+| 2017-07-03 |102 | 15 | {"ip":"192.168.0.5","source":"pc"} | 188 |
+| 2017-07-03 |105 | 12 | {"ip":"192.168.0.5","source":"pc"} | 81 |
++++--++--+
+```
+
+### 1. find most visit top 3 ip
+c++ demo not implement,If you are interested you can reference java/python
demo
Review Comment:
> remove this?
ok ,done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhannngchen opened a new pull request, #11776: [typo](doc) fix typos in readme.md
zhannngchen opened a new pull request, #11776: URL: https://github.com/apache/doris/pull/11776 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11774: [Fix](image)(upgrade) Clear all DECOMMISSION_BACKEND job to be compatible with newer version
github-actions[bot] commented on PR #11774: URL: https://github.com/apache/doris/pull/11774#issuecomment-1214584435 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11774: [Fix](image)(upgrade) Clear all DECOMMISSION_BACKEND job to be compatible with newer version
github-actions[bot] commented on PR #11774: URL: https://github.com/apache/doris/pull/11774#issuecomment-1214584442 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] freemandealer commented on pull request #11771: [fix](memtracker) Fix flush memtable to reduce load channel mem not executed
freemandealer commented on PR #11771: URL: https://github.com/apache/doris/pull/11771#issuecomment-1214584987 The patch has been tested and verified functional as expected: flush memtable execute due to exceeding memory limit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11776: [typo](doc) fix typos in readme.md
github-actions[bot] commented on PR #11776: URL: https://github.com/apache/doris/pull/11776#issuecomment-1214586615 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11776: [typo](doc) fix typos in readme.md
github-actions[bot] commented on PR #11776: URL: https://github.com/apache/doris/pull/11776#issuecomment-1214586633 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] 924060929 merged pull request #11772: [fix](Nereids) fix a bug in multJoin: if there is no condition, create cross join
924060929 merged PR #11772: URL: https://github.com/apache/doris/pull/11772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (8c8f48c4c2 -> 66116b78d1)
This is an automated email from the ASF dual-hosted git repository. huajianlan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 8c8f48c4c2 [feature-wip](array-type) add the array_join function (#11406) add 66116b78d1 fix multJoin bug (#11772) No new revisions were added by this update. Summary of changes: .../apache/doris/nereids/rules/rewrite/logical/MultiJoin.java| 9 + 1 file changed, 5 insertions(+), 4 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xiaokang commented on a diff in pull request #11757: [fix](query) fix orderby keys limit return less or no result
xiaokang commented on code in PR #11757:
URL: https://github.com/apache/doris/pull/11757#discussion_r945418160
##
be/src/vec/exec/volap_scanner.h:
##
@@ -134,6 +134,7 @@ class VOlapScanner {
// time costed and row returned statistics
int64_t _num_rows_read = 0;
Review Comment:
I'm not sure about this. But the code for update _num_rows_read and
_raw_rows_read seems to be very different.
BTW, if you mean _num_rows_read and _num_rows_return, they are not the same.
_num_rows_return is smaller than _num_rows_read, since _num_rows_return is
counted after filter_block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11703: [enhancement](array-type) support export files in 'select into outfile'
github-actions[bot] commented on PR #11703: URL: https://github.com/apache/doris/pull/11703#issuecomment-1214605669 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11703: [enhancement](array-type) support export files in 'select into outfile'
github-actions[bot] commented on PR #11703: URL: https://github.com/apache/doris/pull/11703#issuecomment-1214605690 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11630: [feature](nereids): SimplifyCastRule
github-actions[bot] commented on PR #11630: URL: https://github.com/apache/doris/pull/11630#issuecomment-1214608397 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11630: [feature](nereids): SimplifyCastRule
github-actions[bot] commented on PR #11630: URL: https://github.com/apache/doris/pull/11630#issuecomment-1214608415 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 merged pull request #11703: [enhancement](array-type) support export files in 'select into outfile'
xy720 merged PR #11703: URL: https://github.com/apache/doris/pull/11703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [enhancement](array-type) support export files in 'select into outfile' (#11703)
This is an automated email from the ASF dual-hosted git repository.
xuyang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new ab9529f6b5 [enhancement](array-type) support export files in 'select
into outfile' (#11703)
ab9529f6b5 is described below
commit ab9529f6b5ef4731e206b4db2a89823dbf3f6891
Author: carlvinhust2012
AuthorDate: Mon Aug 15 12:34:31 2022 +0800
[enhancement](array-type) support export files in 'select into outfile'
(#11703)
this pr is used to support export array type in 'select into outfile'.
Co-authored-by: hucheng01
---
be/src/runtime/file_result_writer.cpp | 6 ++
be/src/vec/runtime/vfile_result_writer.cpp | 4
2 files changed, 10 insertions(+)
diff --git a/be/src/runtime/file_result_writer.cpp
b/be/src/runtime/file_result_writer.cpp
index 8e7ee645b7..3c115b6cac 100644
--- a/be/src/runtime/file_result_writer.cpp
+++ b/be/src/runtime/file_result_writer.cpp
@@ -337,6 +337,12 @@ Status FileResultWriter::_write_one_row_as_csv(TupleRow*
row) {
}
break;
}
+case TYPE_ARRAY: {
+auto col_type = _output_expr_ctxs[i]->root()->type();
+int output_scale =
_output_expr_ctxs[i]->root()->output_scale();
+RawValue::print_value(item, col_type, output_scale,
&_plain_text_outstream);
+break;
+}
default: {
// not supported type, like BITMAP, HLL, just export null
_plain_text_outstream << NULL_IN_CSV;
diff --git a/be/src/vec/runtime/vfile_result_writer.cpp
b/be/src/vec/runtime/vfile_result_writer.cpp
index a132eb696d..1a250a8010 100644
--- a/be/src/vec/runtime/vfile_result_writer.cpp
+++ b/be/src/vec/runtime/vfile_result_writer.cpp
@@ -312,6 +312,10 @@ Status VFileResultWriter::_write_csv_file(const Block&
block) {
_plain_text_outstream << col.type->to_string(*col.column,
i);
break;
}
+case TYPE_ARRAY: {
+_plain_text_outstream << col.type->to_string(*col.column,
i);
+break;
+}
default: {
// not supported type, like BITMAP, HLL, just export null
_plain_text_outstream << NULL_IN_CSV;
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 merged pull request #11727: [chore](regression) Add badges for jenkins on home page
xy720 merged PR #11727: URL: https://github.com/apache/doris/pull/11727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (ab9529f6b5 -> 74b0d0da88)
This is an automated email from the ASF dual-hosted git repository. xuyang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from ab9529f6b5 [enhancement](array-type) support export files in 'select into outfile' (#11703) add 74b0d0da88 [chore](regression) Add badges for jenkins on home page (#11727) No new revisions were added by this update. Summary of changes: README.md | 2 ++ 1 file changed, 2 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] 924060929 merged pull request #11630: [feature](nereids): SimplifyCastRule
924060929 merged PR #11630: URL: https://github.com/apache/doris/pull/11630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [feature](nereids): SimplifyCastRule (#11630)
This is an automated email from the ASF dual-hosted git repository.
huajianlan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 1e6b8cd1a9 [feature](nereids): SimplifyCastRule (#11630)
1e6b8cd1a9 is described below
commit 1e6b8cd1a916dba546a9f0268a8b45ec280b5916
Author: jakevin
AuthorDate: Mon Aug 15 12:41:36 2022 +0800
[feature](nereids): SimplifyCastRule (#11630)
Remove redundant cast like
```
cast(1 as int) -> 1
```
---
.../rewrite/ExpressionNormalization.java | 4 +-
.../expression/rewrite/rules/SimplifyCastRule.java | 60 ++
.../doris/nereids/trees/expressions/Cast.java | 13 -
.../expression/rewrite/ExpressionRewriteTest.java | 21 +++-
4 files changed, 93 insertions(+), 5 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rewrite/ExpressionNormalization.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rewrite/ExpressionNormalization.java
index 3cd9357325..465e120085 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rewrite/ExpressionNormalization.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rewrite/ExpressionNormalization.java
@@ -19,6 +19,7 @@ package org.apache.doris.nereids.rules.expression.rewrite;
import
org.apache.doris.nereids.rules.expression.rewrite.rules.BetweenToCompoundRule;
import
org.apache.doris.nereids.rules.expression.rewrite.rules.NormalizeBinaryPredicatesRule;
+import
org.apache.doris.nereids.rules.expression.rewrite.rules.SimplifyCastRule;
import
org.apache.doris.nereids.rules.expression.rewrite.rules.SimplifyNotExprRule;
import com.google.common.collect.ImmutableList;
@@ -33,7 +34,8 @@ public class ExpressionNormalization extends
ExpressionRewrite {
public static final List NORMALIZE_REWRITE_RULES =
ImmutableList.of(
NormalizeBinaryPredicatesRule.INSTANCE,
BetweenToCompoundRule.INSTANCE,
-SimplifyNotExprRule.INSTANCE
+SimplifyNotExprRule.INSTANCE,
+SimplifyCastRule.INSTANCE
);
private static final ExpressionRuleExecutor EXECUTOR = new
ExpressionRuleExecutor(NORMALIZE_REWRITE_RULES);
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rewrite/rules/SimplifyCastRule.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rewrite/rules/SimplifyCastRule.java
new file mode 100644
index 00..81d6e685ca
--- /dev/null
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rewrite/rules/SimplifyCastRule.java
@@ -0,0 +1,60 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.expression.rewrite.rules;
+
+import
org.apache.doris.nereids.rules.expression.rewrite.AbstractExpressionRewriteRule;
+import
org.apache.doris.nereids.rules.expression.rewrite.ExpressionRewriteContext;
+import org.apache.doris.nereids.trees.expressions.Cast;
+import org.apache.doris.nereids.trees.expressions.Expression;
+
+
+/**
+ * Rewrite rule of simplify CAST expression.
+ * Remove redundant cast like
+ * - cast(1 as int) -> 1.
+ * Merge cast like
+ * - cast(cast(1 as bigint) as string) -> cast(1 as string).
+ */
+public class SimplifyCastRule extends AbstractExpressionRewriteRule {
+
+public static SimplifyCastRule INSTANCE = new SimplifyCastRule();
+
+@Override
+public Expression visitCast(Cast origin, ExpressionRewriteContext context)
{
+return simplify(origin);
+}
+
+private Expression simplify(Cast cast) {
+Expression source = cast.left();
+// simplify inside
+if (source instanceof Cast) {
+source = simplify((Cast) source);
+}
+
+// remove redundant cast
+// CAST(value as type), value is type
+if (cast.getDataType().equals(source.getDataType())) {
+return source;
+}
+
+if (source != cast.left()) {
+return new Cast(source, cast.right());
+}
+return cast;
+}
+}
diff --
[doris-website] branch asf-site updated: add
This is an automated email from the ASF dual-hosted git repository.
jiafengzheng pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/doris-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 0c6d36ee9be add
0c6d36ee9be is described below
commit 0c6d36ee9beeab7a76974d94e141d37b7cebe52d
Author: jiafeng.zhang
AuthorDate: Mon Aug 15 12:42:13 2022 +0800
add
---
remove-non-reserved-dir.sh | 38 ++
1 file changed, 38 insertions(+)
diff --git a/remove-non-reserved-dir.sh b/remove-non-reserved-dir.sh
new file mode 100644
index 000..42a3d65be95
--- /dev/null
+++ b/remove-non-reserved-dir.sh
@@ -0,0 +1,38 @@
+#!/bin/bash
+
+set -eo pipefail
+
+ROOT=`dirname "$0"`
+ROOT=`cd "$ROOT"; pwd`
+
+reserved=(
+build
+remove-non-reserved-dir.sh
+versions.json
+.asf.yaml
+.nojekyll
+.git
+.
+..
+)
+
+function contains() {
+local n=$#
+local value=${!n}
+for ((i=1;i < $#;i++)) {
+if [ "${!i}" == "${value}" ]; then
+echo "y"
+return 0
+fi
+}
+echo "n"
+return 1
+}
+
+for file in `ls -a $ROOT`
+do
+if [ $(contains "${reserved[@]}" "$file") == "n" ]; then
+echo "delete $ROOT/$file"
+rm -rf $ROOT/$file
+fi
+done
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 closed issue #11725: [Proposal] Open Baidu's regression test to Doris Community
xy720 closed issue #11725: [Proposal] Open Baidu's regression test to Doris Community URL: https://github.com/apache/doris/issues/11725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch dev-1.1.2 updated: [bug](scanner) Improve limit query performance on olapScannode and avoid infinite loop (#11301)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch dev-1.1.2
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/dev-1.1.2 by this push:
new 6e40592ca1 [bug](scanner) Improve limit query performance on
olapScannode and avoid infinite loop (#11301)
6e40592ca1 is described below
commit 6e40592ca1d1eb8c53d0ad0a3a0e2be15a4dfcdf
Author: Zhengguo Yang
AuthorDate: Mon Aug 1 13:50:12 2022 +0800
[bug](scanner) Improve limit query performance on olapScannode and avoid
infinite loop (#11301)
1. Fix a bug that query large column table may cause infinite loop
2. Optimize the query logic with limit, for the case where the limit value
is relatively small, reduce the parallelism of the scanner, reduce unnecessary
resource consumption, and increase the number of similar queries that the
system can carry at the same time, and increase the query speed by more than 60%
---
be/src/exec/olap_scan_node.cpp | 19 +++---
be/src/exec/olap_scan_node.h | 2 ++
be/src/exec/olap_scanner.cpp | 18 +
be/src/exec/olap_scanner.h | 4 +++
be/src/runtime/fragment_mgr.cpp | 9 +++
be/src/runtime/query_fragments_ctx.h | 11
be/src/runtime/row_batch.cpp | 2 +-
be/src/vec/exec/volap_scan_node.cpp | 50 ++--
8 files changed, 92 insertions(+), 23 deletions(-)
diff --git a/be/src/exec/olap_scan_node.cpp b/be/src/exec/olap_scan_node.cpp
index b3e63ee8cd..9728922a0a 100644
--- a/be/src/exec/olap_scan_node.cpp
+++ b/be/src/exec/olap_scan_node.cpp
@@ -92,7 +92,8 @@ Status OlapScanNode::init(const TPlanNode& tnode,
RuntimeState* state) {
_runtime_filter_ctxs[i].runtimefilter = runtime_filter;
}
-
+_batch_size = _limit == -1 ? state->batch_size()
+ :
std::min(static_cast(state->batch_size()), _limit);
return Status::OK();
}
@@ -260,7 +261,6 @@ Status OlapScanNode::open(RuntimeState* state) {
Status OlapScanNode::get_next(RuntimeState* state, RowBatch* row_batch, bool*
eos) {
RETURN_IF_ERROR(exec_debug_action(TExecNodePhase::GETNEXT));
SCOPED_TIMER(_runtime_profile->total_time_counter());
-
// check if Canceled.
if (state->is_cancelled()) {
std::unique_lock l(_row_batches_lock);
@@ -813,6 +813,7 @@ Status OlapScanNode::start_scan_thread(RuntimeState* state)
{
}
OlapScanner* scanner = new OlapScanner(state, this,
_olap_scan_node.is_preaggregation,
_need_agg_finalize,
*scan_range);
+scanner->set_batch_size(_batch_size);
// add scanner to pool before doing prepare.
// so that scanner can be automatically deconstructed if prepare
failed.
_scanner_pool.add(scanner);
@@ -1359,7 +1360,12 @@ void OlapScanNode::transfer_thread(RuntimeState* state) {
}
}
-ThreadPoolToken* thread_token =
state->get_query_fragments_ctx()->get_token();
+ThreadPoolToken* thread_token = nullptr;
+if (limit() != -1 && limit() < 1024) {
+thread_token = state->get_query_fragments_ctx()->get_serial_token();
+} else {
+thread_token = state->get_query_fragments_ctx()->get_token();
+}
/*
* The basic strategy of priority scheduling:
@@ -1605,7 +1611,7 @@ void OlapScanNode::scanner_thread(OlapScanner* scanner) {
<< ", fragment id=" <<
print_id(_runtime_state->fragment_instance_id());
break;
}
-RowBatch* row_batch = new RowBatch(this->row_desc(),
state->batch_size(),
+RowBatch* row_batch = new RowBatch(this->row_desc(), _batch_size,
_runtime_state->fragment_mem_tracker().get());
row_batch->set_scanner_id(scanner->id());
status = scanner->get_batch(_runtime_state, row_batch, &eos);
@@ -1625,6 +1631,10 @@ void OlapScanNode::scanner_thread(OlapScanner* scanner) {
raw_bytes_read +=
row_batch->tuple_data_pool()->total_reserved_bytes();
}
raw_rows_read = scanner->raw_rows_read();
+if (limit() != -1 && raw_rows_read >= limit()) {
+eos = true;
+break;
+}
}
{
@@ -1643,6 +1653,7 @@ void OlapScanNode::scanner_thread(OlapScanner* scanner) {
std::lock_guard guard(_status_mutex);
global_status_ok = _status.ok();
}
+
if (UNLIKELY(!global_status_ok)) {
eos = true;
for (auto rb : row_batchs) {
diff --git a/be/src/exec/olap_scan_node.h b/be/src/exec/olap_scan_node.h
index 4cd2902b93..12cdb36f85 100644
--- a/be/src/exec/olap_scan_node.h
+++ b/be/src/exec/olap_scan_node.h
@@ -199,6 +199,8 @@ protected:
// object is.
ObjectPool _scanner_pool;
+size_t _b
[doris-website] branch asf-site updated: update remove-non-reserved-dir.sh
This is an automated email from the ASF dual-hosted git repository.
jiafengzheng pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/doris-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new d344536ebc2 update remove-non-reserved-dir.sh
d344536ebc2 is described below
commit d344536ebc2d8bdab12b0edf662e8d59753d6b7d
Author: jiafeng.zhang
AuthorDate: Mon Aug 15 13:02:58 2022 +0800
update remove-non-reserved-dir.sh
---
remove-non-reserved-dir.sh | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/remove-non-reserved-dir.sh b/remove-non-reserved-dir.sh
index 42a3d65be95..fb4046e8a4f 100644
--- a/remove-non-reserved-dir.sh
+++ b/remove-non-reserved-dir.sh
@@ -33,6 +33,8 @@ for file in `ls -a $ROOT`
do
if [ $(contains "${reserved[@]}" "$file") == "n" ]; then
echo "delete $ROOT/$file"
-rm -rf $ROOT/$file
+if [ $file != "remove-non-reserved-dir.sh"]; then
+ rm -rf $ROOT/$file
+fi
fi
done
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Gabriel39 opened a new pull request, #11777: [Bug](date function) Fix bug for date format %T
Gabriel39 opened a new pull request, #11777: URL: https://github.com/apache/doris/pull/11777 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11723: [bug](update) Fix where clause is not reanalyzed after rewrite
github-actions[bot] commented on PR #11723: URL: https://github.com/apache/doris/pull/11723#issuecomment-1214628621 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11723: [bug](update) Fix where clause is not reanalyzed after rewrite
github-actions[bot] commented on PR #11723: URL: https://github.com/apache/doris/pull/11723#issuecomment-1214628609 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11736: [bug](backup) fix backup restore raise `Storage backend not initialized.` error
github-actions[bot] commented on PR #11736: URL: https://github.com/apache/doris/pull/11736#issuecomment-1214629523 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [fix](backup) fix backup restore raise `Storage backend not initialized.` error (#11736)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 805c13aaa1 [fix](backup) fix backup restore raise `Storage backend not
initialized.` error (#11736)
805c13aaa1 is described below
commit 805c13aaa1204a24aa31f5a63f73a678d5e7d3f1
Author: Zhengguo Yang
AuthorDate: Mon Aug 15 13:24:38 2022 +0800
[fix](backup) fix backup restore raise `Storage backend not initialized.`
error (#11736)
fix backup restore raise Storage backend not initialized. error
---
be/src/agent/task_worker_pool.cpp | 30 ++
be/src/runtime/snapshot_loader.cpp | 20
be/src/runtime/snapshot_loader.h | 2 --
3 files changed, 14 insertions(+), 38 deletions(-)
diff --git a/be/src/agent/task_worker_pool.cpp
b/be/src/agent/task_worker_pool.cpp
index deb39a3a51..f63e9abb25 100644
--- a/be/src/agent/task_worker_pool.cpp
+++ b/be/src/agent/task_worker_pool.cpp
@@ -1296,16 +1296,11 @@ void TaskWorkerPool::_upload_worker_thread_callback() {
<< ", job id:" << upload_request.job_id;
std::map> tablet_files;
-std::unique_ptr loader = nullptr;
-if (upload_request.__isset.storage_backend) {
-loader.reset(new SnapshotLoader(_env, upload_request.job_id,
agent_task_req.signature,
-upload_request.broker_prop,
-upload_request.storage_backend));
-} else {
-loader.reset(new SnapshotLoader(_env, upload_request.job_id,
agent_task_req.signature,
-upload_request.broker_addr,
-upload_request.broker_prop));
-}
+std::unique_ptr loader =
std::make_unique(
+_env, upload_request.job_id, agent_task_req.signature,
upload_request.broker_addr,
+upload_request.broker_prop,
+upload_request.__isset.storage_backend ?
upload_request.storage_backend
+ :
TStorageBackendType::type::BROKER);
Status status = loader->upload(upload_request.src_dest_map,
&tablet_files);
TStatusCode::type status_code = TStatusCode::OK;
@@ -1363,16 +1358,11 @@ void TaskWorkerPool::_download_worker_thread_callback()
{
// TODO: download
std::vector downloaded_tablet_ids;
-std::unique_ptr loader = nullptr;
-if (download_request.__isset.storage_backend) {
-loader.reset(new SnapshotLoader(_env, download_request.job_id,
agent_task_req.signature,
-download_request.broker_prop,
-download_request.storage_backend));
-} else {
-loader.reset(new SnapshotLoader(_env, download_request.job_id,
agent_task_req.signature,
-download_request.broker_addr,
-download_request.broker_prop));
-}
+std::unique_ptr loader =
std::make_unique(
+_env, download_request.job_id, agent_task_req.signature,
+download_request.broker_addr, download_request.broker_prop,
+download_request.__isset.storage_backend ?
download_request.storage_backend
+ :
TStorageBackendType::type::BROKER);
Status status = loader->download(download_request.src_dest_map,
&downloaded_tablet_ids);
if (!status.ok()) {
diff --git a/be/src/runtime/snapshot_loader.cpp
b/be/src/runtime/snapshot_loader.cpp
index 598092d3d8..11c8930d11 100644
--- a/be/src/runtime/snapshot_loader.cpp
+++ b/be/src/runtime/snapshot_loader.cpp
@@ -40,17 +40,6 @@
namespace doris {
-SnapshotLoader::SnapshotLoader(ExecEnv* env, int64_t job_id, int64_t task_id,
- const TNetworkAddress& broker_addr,
- const std::map&
broker_prop)
-: _env(env),
- _job_id(job_id),
- _task_id(task_id),
- _broker_addr(broker_addr),
- _prop(broker_prop) {
-_storage_backend.reset(new BrokerStorageBackend(_env, _broker_addr,
_prop));
-}
-
SnapshotLoader::SnapshotLoader(ExecEnv* env, int64_t job_id, int64_t task_id)
: _env(env),
_job_id(job_id),
@@ -60,17 +49,16 @@ SnapshotLoader::SnapshotLoader(ExecEnv* env, int64_t
job_id, int64_t task_id)
_storage_backend(nullptr) {}
SnapshotLoader::SnapshotLoader(ExecEnv* env, int64_t job_id, int64_t task_id,
+ const TNetworkAddress& broker_addr,
const std::map& prop,
TStorageBackendType::type type)
-:
[GitHub] [doris] morningman closed issue #11734: [Bug] backup restore raise `Storage backend not initialized.` error
morningman closed issue #11734: [Bug] backup restore raise `Storage backend not initialized.` error URL: https://github.com/apache/doris/issues/11734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [fix](update) Fix where clause is not reanalyzed after rewrite (#11723)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 910d51c76f [fix](update) Fix where clause is not reanalyzed after
rewrite (#11723)
910d51c76f is described below
commit 910d51c76fb856ca504de65020395806292cfb11
Author: Zhengguo Yang
AuthorDate: Mon Aug 15 13:24:57 2022 +0800
[fix](update) Fix where clause is not reanalyzed after rewrite (#11723)
---
fe/fe-core/src/main/java/org/apache/doris/analysis/UpdateStmt.java | 2 ++
regression-test/data/update/test_update_unique.out | 4
regression-test/suites/update/test_update_unique.groovy| 2 ++
3 files changed, 8 insertions(+)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/UpdateStmt.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/UpdateStmt.java
index 23b182f9df..26577b5379 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/UpdateStmt.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/UpdateStmt.java
@@ -200,6 +200,8 @@ public class UpdateStmt extends DdlStmt {
}
whereExpr.analyze(analyzer);
whereExpr = analyzer.getExprRewriter().rewrite(whereExpr, analyzer,
ExprRewriter.ClauseType.WHERE_CLAUSE);
+whereExpr.reset();
+whereExpr.analyze(analyzer);
if (!whereExpr.getType().equals(Type.BOOLEAN)) {
throw new AnalysisException("Where clause is not a valid statement
return bool");
}
diff --git a/regression-test/data/update/test_update_unique.out
b/regression-test/data/update/test_update_unique.out
index 6df338a346..98f001495e 100644
--- a/regression-test/data/update/test_update_unique.out
+++ b/regression-test/data/update/test_update_unique.out
@@ -3,6 +3,10 @@
1 2 1 1999-01-01
2 2 1 1999-01-01
+-- !select_uniq_table --
+1 2 1 1998-01-01
+2 2 1 1998-01-01
+
-- !desc_uniq_table --
k INT Yes true\N
value1 INT Yes false \N REPLACE
diff --git a/regression-test/suites/update/test_update_unique.groovy
b/regression-test/suites/update/test_update_unique.groovy
index 667fb3d4df..21d2d26b13 100644
--- a/regression-test/suites/update/test_update_unique.groovy
+++ b/regression-test/suites/update/test_update_unique.groovy
@@ -34,6 +34,8 @@ suite("test_update_unique", "p0") {
sql "UPDATE ${tbName} SET value1 = value1+1 WHERE k=2;"
sql "UPDATE ${tbName} SET date_value = '1999-01-01' WHERE k in (1,2);"
qt_select_uniq_table "select * from ${tbName} order by k"
+sql "UPDATE ${tbName} SET date_value = '1998-01-01' WHERE k is null or k
is not null;"
+qt_select_uniq_table "select * from ${tbName} order by k"
qt_desc_uniq_table "desc ${tbName}"
sql "DROP TABLE ${tbName}"
}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #11723: [bug](update) Fix where clause is not reanalyzed after rewrite
morningman merged PR #11723: URL: https://github.com/apache/doris/pull/11723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #11736: [bug](backup) fix backup restore raise `Storage backend not initialized.` error
morningman merged PR #11736: URL: https://github.com/apache/doris/pull/11736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman closed issue #11722: [Bug] Where clause is not reanalyzed after rewrite
morningman closed issue #11722: [Bug] Where clause is not reanalyzed after rewrite URL: https://github.com/apache/doris/issues/11722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris-website] branch asf-site updated: fix
This is an automated email from the ASF dual-hosted git repository.
jiafengzheng pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/doris-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 29e0e754a01 fix
29e0e754a01 is described below
commit 29e0e754a012cce3d4764f1b373dbf354ea947b5
Author: jiafeng.zhang
AuthorDate: Mon Aug 15 13:24:25 2022 +0800
fix
---
remove-non-reserved-dir.sh | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/remove-non-reserved-dir.sh b/remove-non-reserved-dir.sh
index fb4046e8a4f..fe769dec6fc 100644
--- a/remove-non-reserved-dir.sh
+++ b/remove-non-reserved-dir.sh
@@ -34,7 +34,11 @@ do
if [ $(contains "${reserved[@]}" "$file") == "n" ]; then
echo "delete $ROOT/$file"
if [ $file != "remove-non-reserved-dir.sh"]; then
- rm -rf $ROOT/$file
+ if [ [ $FILE =~ "remove-non-reserved-dir.sh" ] ]; then
+ echo "cannot delete $ROOT/$file"
+ else
+ rm -rf $ROOT/$file
+ fi
fi
fi
done
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
