[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

[joanahalili via Phabricator via cfe-commits]

joanahalili added a comment.

Heads up: This commit causes clang crashes on our end. We are currently working 
on a reproducer and will post it as soon as its ready.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129973/new/

https://reviews.llvm.org/D129973

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

[joanahalili via Phabricator via cfe-commits]

joanahalili added a comment.

In D129973#3696189 , @joanahalili 
wrote:

> Heads up: This commit causes clang crashes on our end. We are currently 
> working on a reproducer and will post it as soon as its ready.

Here is the reduced code:

  template  struct b {
template  void ab(c);
template  void ad(c p1) { ab(d()(p1)); }
a d();
  };
  template  struct f {
using aa = e;
template  struct j {
  g ag;
  template  auto operator()(h... p1) -> decltype(ag(p1...));
};
using ai = b>;
template  void ad(c p1) { i.ad(p1); }
ai i;
  };
  template  struct l {
int k(const c &);
struct n {
  int operator()(const c &) const;
};
using m = f;
m aj;
  };
  template  int l::k(const c &p1) { aj.ad(p1); }
  template 
  int l::n::operator()(const c &) const {}
  template class l;

This commit causes a compiler crash for this code. It however successfully 
builds with the previous commit compiler. 
Here is also a link comparing released clang with clang trunk where trunk is 
crashing and the released version is not: https://godbolt.org/z/fdbo74c54


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129973/new/

https://reviews.llvm.org/D129973

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

[joanahalili via Phabricator via cfe-commits]

joanahalili added a comment.

We have a translation unit, on which we see an increase of compilation time and 
clang memory allocation from 11GB to 14GB. We are working on an isolated case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128113/new/

https://reviews.llvm.org/D128113

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

[joanahalili via Phabricator via cfe-commits]

joanahalili added a comment.

F24241982: reproduction.cpp 

  clang -fsyntax-only -std=c++17  -fproc-stat-report 
-Wno-deprecated-declarations  -fsized-deallocation -Werror 
-Wno-deprecated-declarations  -Wno-inconsistent-missing-override 
-Wno-null-conversion -Wno-ignored-attributes  -Wno-defaulted-function-deleted 
-xc++ reproduction.cpp

This is the reproducer we managed to create for the memory increase.  As 
mentioned above we notice both a difference in memory and execution time. 
Clang version before this patch

- Memory: 8Gb
- Time: 32507 ms

Clang version with this patch:

- Memory: 10.5 Gb (1.5Gb increase)
- Time 63812 (almost double the previous compilation time).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128113/new/

https://reviews.llvm.org/D128113

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

[joanahalili via Phabricator via cfe-commits]

joanahalili added a comment.

We have some compilation failures on our end because of function template 
parameter deduction when passing the function template to a function pointer.

  typedef void (*f)(const int&);
  
  template 
  void F(T value) {}
  
  template 
  void F(const T& value){}
  
  void q(f);
  
  void w() {
  q(&F);
  }

Is this an intended outcome for this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128745/new/

https://reviews.llvm.org/D128745

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

[joanahalili via Phabricator via cfe-commits]

joanahalili added a comment.

Heads up: We are experiencing a series of clang crashes because of this commit.

What we already have so far:

  Unhandled DeclRefExpr
  UNREACHABLE executed at clang/lib/CodeGen/CGExpr.cpp:2958!

We are now working on a reproducer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143840/new/

https://reviews.llvm.org/D143840

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

[joanahalili via Phabricator via cfe-commits]

joanahalili added a comment.

In D143840#4147234 , @joanahalili 
wrote:

> Heads up: We are experiencing a series of clang crashes because of this 
> commit.
>
> What we already have so far:
>
>   Unhandled DeclRefExpr
>   UNREACHABLE executed at clang/lib/CodeGen/CGExpr.cpp:2958!
>
> We are now working on a reproducer.

Here is our reproducer:

  struct a {
enum { b };
  };
  struct c {
void *d;
  };
  struct e {
void f(void *);
  };
  template  struct h : g {
h(short, int);
virtual void i();
  };
  template  void h::i() { e().f(c::d); }
  struct j : h {
j();
  };
  int k;
  j::j() : h(a::b, k) {}




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143840/new/

https://reviews.llvm.org/D143840

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits