[PATCH][www] Mention that libcxx is necessary on OS X
Hi all, According to https://llvm.org/bugs/show_bug.cgi?id=17821 , when Clang gets built on OS X we need to build it with libcxx and libcxxabi (otherwise tests will fail to link with "can't find iostream". This patch adds a note to getting started page. Ok to apply? Best regards, Yury Gribov libcxx-osx-1.patch Description: Binary data ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH][www] Mention that libcxx is necessary on OS X
On Fri, Sep 4, 2015 at 11:49 PM, Jonathan Roelofs wrote: > On 9/4/15 2:45 PM, Yuri Gribov via cfe-commits wrote: > >> Hi all, >> >> According to https://llvm.org/bugs/show_bug.cgi?id=17821 , when Clang >> gets built on OS X we need to build it with libcxx and libcxxabi >> (otherwise tests will fail to link with "can't find iostream". This >> patch adds a note to getting started page. Ok to apply? >> > > Which tests fail to link for you? > Sorry, I'm not at my desk right now. Basically make check-all failed in 5 seconds and after some googling I found the above bug with Bob Wilson's advice to link libcxx which fixed the issue. Do you mean that libcxx shouldn't be needed on Mac? -Y ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH][www] Mention that libcxx is necessary on OS X
Oh, nice so this was actually done by Kuba to fix sanitizer unittests: "echo '#include ' | ${COMPILER_RT_TEST_COMPILER} -E -x c++ - > /dev/null" "if [ $? != 0 ] " " then echo" " echo 'Your just-built clang cannot find C++ headers, which are needed to build and run compiler-rt tests.'" " echo 'You should copy or symlink your system C++ headers into ${LLVM_BINARY_DIR}/include/c++'" " if [ -d $(dirname $(dirname $(xcrun -f clang)))/include/c++ ]" "then echo 'e.g. with:'" "echo ' cp -r' $(dirname $(dirname $(xcrun -f clang)))/include/c++ '${LLVM_BINARY_DIR}/include/'" " elif [ -d $(dirname $(dirname $(xcrun -f clang)))/lib/c++ ]" "then echo 'e.g. with:'" "echo ' cp -r' $(dirname $(dirname $(xcrun -f clang)))/lib/c++ '${LLVM_BINARY_DIR}/include/'" " fi" " echo 'This can also be fixed by checking out the libcxx project from llvm.org and installing the headers'" " echo 'into your build directory:'" " echo ' cd ${LLVM_SOURCE_DIR}/projects && svn co http://llvm.org/svn/llvm-project/libcxx/trunk libcxx'" " echo ' cd ${LLVM_BINARY_DIR} && make -C ${LLVM_SOURCE_DIR}/projects/libcxx installheaders HEADER_DIR=${LLVM_BINARY_DIR}/include'" " echo" " false" "fi" What I mean is that we should either fix the tests, or describe precisely > the scenario in which libcxx+libcxxabi is needed because it's not > always needed. I suspect it's just needed when testing the sanitizers (but > I might be wrong). > What if I s/mandatory on OS X, optional otherwise/required to run tests on OS X/ ? -Y ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits