[PATCH] D143123: [NFC] Add split-file as runtime test dependency

2023-02-01 Thread YongKang Zhu via Phabricator via cfe-commits 
yozhu updated this revision to Diff 494156.
yozhu added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Add `split-file` as compiler-rt test dependency under clang/runtime


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143123/new/

https://reviews.llvm.org/D143123

Files:
  clang/runtime/CMakeLists.txt
  llvm/runtimes/CMakeLists.txt


Index: llvm/runtimes/CMakeLists.txt
===
--- llvm/runtimes/CMakeLists.txt
+++ llvm/runtimes/CMakeLists.txt
@@ -503,6 +503,7 @@
 sanstats
 llvm_gtest_main
 llvm_gtest
+split-file
   )
 foreach(target ${test_targets} ${SUB_CHECK_TARGETS})
   add_dependencies(${target} ${RUNTIMES_TEST_DEPENDS})
Index: clang/runtime/CMakeLists.txt
===
--- clang/runtime/CMakeLists.txt
+++ clang/runtime/CMakeLists.txt
@@ -132,7 +132,7 @@
   if(LLVM_INCLUDE_TESTS)
 # Add binaries that compiler-rt tests depend on.
 set(COMPILER_RT_TEST_DEPENDENCIES
-  FileCheck count not llvm-nm llvm-objdump llvm-symbolizer llvm-jitlink 
lli)
+  FileCheck count not llvm-nm llvm-objdump llvm-symbolizer llvm-jitlink 
lli split-file)
 
 # Add top-level targets for various compiler-rt test suites.
 set(COMPILER_RT_TEST_SUITES check-fuzzer check-asan check-hwasan 
check-asan-dynamic check-dfsan


Index: llvm/runtimes/CMakeLists.txt
===
--- llvm/runtimes/CMakeLists.txt
+++ llvm/runtimes/CMakeLists.txt
@@ -503,6 +503,7 @@
 sanstats
 llvm_gtest_main
 llvm_gtest
+split-file
   )
 foreach(target ${test_targets} ${SUB_CHECK_TARGETS})
   add_dependencies(${target} ${RUNTIMES_TEST_DEPENDS})
Index: clang/runtime/CMakeLists.txt
===
--- clang/runtime/CMakeLists.txt
+++ clang/runtime/CMakeLists.txt
@@ -132,7 +132,7 @@
   if(LLVM_INCLUDE_TESTS)
 # Add binaries that compiler-rt tests depend on.
 set(COMPILER_RT_TEST_DEPENDENCIES
-  FileCheck count not llvm-nm llvm-objdump llvm-symbolizer llvm-jitlink lli)
+  FileCheck count not llvm-nm llvm-objdump llvm-symbolizer llvm-jitlink lli split-file)
 
 # Add top-level targets for various compiler-rt test suites.
 set(COMPILER_RT_TEST_SUITES check-fuzzer check-asan check-hwasan check-asan-dynamic check-dfsan
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143123: [NFC] Add split-file as runtime test dependency

2023-02-02 Thread YongKang Zhu via Phabricator via cfe-commits 
yozhu updated this revision to Diff 494354.
yozhu added a comment.

rebase


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143123/new/

https://reviews.llvm.org/D143123

Files:
  clang/runtime/CMakeLists.txt
  llvm/runtimes/CMakeLists.txt


Index: llvm/runtimes/CMakeLists.txt
===
--- llvm/runtimes/CMakeLists.txt
+++ llvm/runtimes/CMakeLists.txt
@@ -503,6 +503,7 @@
 sanstats
 llvm_gtest_main
 llvm_gtest
+split-file
   )
 foreach(target ${test_targets} ${SUB_CHECK_TARGETS})
   add_dependencies(${target} ${RUNTIMES_TEST_DEPENDS})
Index: clang/runtime/CMakeLists.txt
===
--- clang/runtime/CMakeLists.txt
+++ clang/runtime/CMakeLists.txt
@@ -132,7 +132,7 @@
   if(LLVM_INCLUDE_TESTS)
 # Add binaries that compiler-rt tests depend on.
 set(COMPILER_RT_TEST_DEPENDENCIES
-  FileCheck count not llvm-nm llvm-objdump llvm-symbolizer llvm-jitlink 
lli)
+  FileCheck count not llvm-nm llvm-objdump llvm-symbolizer llvm-jitlink 
lli split-file)
 
 # Add top-level targets for various compiler-rt test suites.
 set(COMPILER_RT_TEST_SUITES check-fuzzer check-asan check-hwasan 
check-asan-dynamic check-dfsan


Index: llvm/runtimes/CMakeLists.txt
===
--- llvm/runtimes/CMakeLists.txt
+++ llvm/runtimes/CMakeLists.txt
@@ -503,6 +503,7 @@
 sanstats
 llvm_gtest_main
 llvm_gtest
+split-file
   )
 foreach(target ${test_targets} ${SUB_CHECK_TARGETS})
   add_dependencies(${target} ${RUNTIMES_TEST_DEPENDS})
Index: clang/runtime/CMakeLists.txt
===
--- clang/runtime/CMakeLists.txt
+++ clang/runtime/CMakeLists.txt
@@ -132,7 +132,7 @@
   if(LLVM_INCLUDE_TESTS)
 # Add binaries that compiler-rt tests depend on.
 set(COMPILER_RT_TEST_DEPENDENCIES
-  FileCheck count not llvm-nm llvm-objdump llvm-symbolizer llvm-jitlink lli)
+  FileCheck count not llvm-nm llvm-objdump llvm-symbolizer llvm-jitlink lli split-file)
 
 # Add top-level targets for various compiler-rt test suites.
 set(COMPILER_RT_TEST_SUITES check-fuzzer check-asan check-hwasan check-asan-dynamic check-dfsan
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

2023-04-06 Thread YongKang Zhu via Phabricator via cfe-commits 
yozhu created this revision.
Herald added a project: All.
yozhu requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Add missing "REQUIRES: asserts" for the two tests added in commit
711a64412749ae73709562b591ab1609a3ee7751 
.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147764

Files:
  clang/test/Modules/gmodules-preferred-name-alias.cpp
  clang/test/Modules/gmodules-preferred-name-typedef.cpp


Index: clang/test/Modules/gmodules-preferred-name-typedef.cpp
===
--- clang/test/Modules/gmodules-preferred-name-typedef.cpp
+++ clang/test/Modules/gmodules-preferred-name-typedef.cpp
@@ -1,3 +1,4 @@
+// REQUIRES: asserts
 // RUN: rm -rf %t
 // RUN: %clang_cc1 -std=c++11 -dwarf-ext-refs -fmodule-format=obj \
 // RUN: 
-fmodule-map-file=%S/Inputs/gmodules-preferred-name-typedef.modulemap \
Index: clang/test/Modules/gmodules-preferred-name-alias.cpp
===
--- clang/test/Modules/gmodules-preferred-name-alias.cpp
+++ clang/test/Modules/gmodules-preferred-name-alias.cpp
@@ -1,3 +1,4 @@
+// REQUIRES: asserts
 // RUN: rm -rf %t
 // RUN: %clang_cc1 -std=c++11 -dwarf-ext-refs -fmodule-format=obj \
 // RUN: 
-fmodule-map-file=%S/Inputs/gmodules-preferred-name-alias.modulemap \


Index: clang/test/Modules/gmodules-preferred-name-typedef.cpp
===
--- clang/test/Modules/gmodules-preferred-name-typedef.cpp
+++ clang/test/Modules/gmodules-preferred-name-typedef.cpp
@@ -1,3 +1,4 @@
+// REQUIRES: asserts
 // RUN: rm -rf %t
 // RUN: %clang_cc1 -std=c++11 -dwarf-ext-refs -fmodule-format=obj \
 // RUN: -fmodule-map-file=%S/Inputs/gmodules-preferred-name-typedef.modulemap \
Index: clang/test/Modules/gmodules-preferred-name-alias.cpp
===
--- clang/test/Modules/gmodules-preferred-name-alias.cpp
+++ clang/test/Modules/gmodules-preferred-name-alias.cpp
@@ -1,3 +1,4 @@
+// REQUIRES: asserts
 // RUN: rm -rf %t
 // RUN: %clang_cc1 -std=c++11 -dwarf-ext-refs -fmodule-format=obj \
 // RUN: -fmodule-map-file=%S/Inputs/gmodules-preferred-name-alias.modulemap \
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

2023-04-06 Thread YongKang Zhu via Phabricator via cfe-commits 
yozhu added a comment.

In D147764#4250636 , @chapuni wrote:

> FYI it's netter to mention diff id like D145803 
>  rather than commit hash, as far as is is 
> based on the diff.

Yes, will include diff ID in commit message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147764/new/

https://reviews.llvm.org/D147764

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

2023-04-07 Thread YongKang Zhu via Phabricator via cfe-commits 
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG53d8b59307d4: Fix the two gmoules-prefered-name-* tests 
(authored by yozhu).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147764/new/

https://reviews.llvm.org/D147764

Files:
  clang/test/Modules/gmodules-preferred-name-alias.cpp
  clang/test/Modules/gmodules-preferred-name-typedef.cpp


Index: clang/test/Modules/gmodules-preferred-name-typedef.cpp
===
--- clang/test/Modules/gmodules-preferred-name-typedef.cpp
+++ clang/test/Modules/gmodules-preferred-name-typedef.cpp
@@ -1,3 +1,4 @@
+// REQUIRES: asserts
 // RUN: rm -rf %t
 // RUN: %clang_cc1 -std=c++11 -dwarf-ext-refs -fmodule-format=obj \
 // RUN: 
-fmodule-map-file=%S/Inputs/gmodules-preferred-name-typedef.modulemap \
Index: clang/test/Modules/gmodules-preferred-name-alias.cpp
===
--- clang/test/Modules/gmodules-preferred-name-alias.cpp
+++ clang/test/Modules/gmodules-preferred-name-alias.cpp
@@ -1,3 +1,4 @@
+// REQUIRES: asserts
 // RUN: rm -rf %t
 // RUN: %clang_cc1 -std=c++11 -dwarf-ext-refs -fmodule-format=obj \
 // RUN: 
-fmodule-map-file=%S/Inputs/gmodules-preferred-name-alias.modulemap \


Index: clang/test/Modules/gmodules-preferred-name-typedef.cpp
===
--- clang/test/Modules/gmodules-preferred-name-typedef.cpp
+++ clang/test/Modules/gmodules-preferred-name-typedef.cpp
@@ -1,3 +1,4 @@
+// REQUIRES: asserts
 // RUN: rm -rf %t
 // RUN: %clang_cc1 -std=c++11 -dwarf-ext-refs -fmodule-format=obj \
 // RUN: -fmodule-map-file=%S/Inputs/gmodules-preferred-name-typedef.modulemap \
Index: clang/test/Modules/gmodules-preferred-name-alias.cpp
===
--- clang/test/Modules/gmodules-preferred-name-alias.cpp
+++ clang/test/Modules/gmodules-preferred-name-alias.cpp
@@ -1,3 +1,4 @@
+// REQUIRES: asserts
 // RUN: rm -rf %t
 // RUN: %clang_cc1 -std=c++11 -dwarf-ext-refs -fmodule-format=obj \
 // RUN: -fmodule-map-file=%S/Inputs/gmodules-preferred-name-alias.modulemap \
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits