[PATCH] D71428: [clang] Move CLANG_BOOTSTRAP_CMAKE_ARGS above PASSTHROUGH_VARIABLES

[Xin-Xin Wang via Phabricator via cfe-commits]

xinxinw1 created this revision.
Herald added subscribers: cfe-commits, mgorny.
Herald added a project: clang.

I want to pass some CMake cache files in CLANG_BOOTSTRAP_CMAKE_ARGS as `-C 
.cmake` arguments. I want to be able to use the values of the 
bootstrap passthrough variables in the cache files, so the cache file arguments 
need to be after passthrough variables. This should be safe because the values 
of passthrough variables are all constants and can't refer to values in 
CLANG_BOOTSTRAP_CMAKE_ARGS.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D71428

Files:
  clang/CMakeLists.txt


Index: clang/CMakeLists.txt
===
--- clang/CMakeLists.txt
+++ clang/CMakeLists.txt
@@ -801,8 +801,8 @@
 # We shouldn't need to set this here, but INSTALL_DIR doesn't
 # seem to work, so instead I'm passing this through
 -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
-${CLANG_BOOTSTRAP_CMAKE_ARGS}
 ${PASSTHROUGH_VARIABLES}
+${CLANG_BOOTSTRAP_CMAKE_ARGS}
  -DCLANG_STAGE=${NEXT_CLANG_STAGE}
 ${COMPILER_OPTIONS}
 ${${CLANG_STAGE}_CONFIG}


Index: clang/CMakeLists.txt
===
--- clang/CMakeLists.txt
+++ clang/CMakeLists.txt
@@ -801,8 +801,8 @@
 # We shouldn't need to set this here, but INSTALL_DIR doesn't
 # seem to work, so instead I'm passing this through
 -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
-${CLANG_BOOTSTRAP_CMAKE_ARGS}
 ${PASSTHROUGH_VARIABLES}
+${CLANG_BOOTSTRAP_CMAKE_ARGS}
  -DCLANG_STAGE=${NEXT_CLANG_STAGE}
 ${COMPILER_OPTIONS}
 ${${CLANG_STAGE}_CONFIG}
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71585: [perf-training] Change profile file pattern string to use %4m instead of %p

[Xin-Xin Wang via Phabricator via cfe-commits]

xinxinw1 created this revision.
xinxinw1 added reviewers: beanz, phosek, xiaobai, smeenai.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

With %p, each test file that we're using to generate profile data will make its 
own profraw file which is around 60 MB in size. If we have a lot of test files, 
that quickly uses a lot of space. Use %4m instead to share the profraw files 
used to store the profile data. We use 4 here based on the default value in 
https://reviews.llvm.org/source/llvm-github/browse/master/llvm/CMakeLists.txt$604


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D71585

Files:
  clang/utils/perf-training/lit.cfg


Index: clang/utils/perf-training/lit.cfg
===
--- clang/utils/perf-training/lit.cfg
+++ clang/utils/perf-training/lit.cfg
@@ -37,5 +37,5 @@
 config.substitutions.append( ('%clang', ' %s %s ' % (config.clang, 
sysroot_flags) ) )
 config.substitutions.append( ('%test_root', config.test_exec_root ) )
 
-config.environment['LLVM_PROFILE_FILE'] = 'perf-training-%p.profraw'
+config.environment['LLVM_PROFILE_FILE'] = 'perf-training-%4m.profraw'
 


Index: clang/utils/perf-training/lit.cfg
===
--- clang/utils/perf-training/lit.cfg
+++ clang/utils/perf-training/lit.cfg
@@ -37,5 +37,5 @@
 config.substitutions.append( ('%clang', ' %s %s ' % (config.clang, sysroot_flags) ) )
 config.substitutions.append( ('%test_root', config.test_exec_root ) )
 
-config.environment['LLVM_PROFILE_FILE'] = 'perf-training-%p.profraw'
+config.environment['LLVM_PROFILE_FILE'] = 'perf-training-%4m.profraw'
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71585: [perf-training] Change profile file pattern string to use %4m instead of %p

[Xin-Xin Wang via Phabricator via cfe-commits]

xinxinw1 added a comment.

@vsk Thanks! The %c mode looks pretty cool but yeah, I don't really have the 
bandwidth to test it right now


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71585/new/

https://reviews.llvm.org/D71585



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits