[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level
thevinster added inline comments. Comment at: lld/Common/Args.cpp:29 +OptimizationLevel args::getOptLevel(llvm::opt::InputArgList &args, +unsigned int key, nit: `getOptLevel` seems a bit too generic for something that's LTO specific. The MachO port has the concept of passing an opt level that generates more efficient opcodes. Suggestions are welcome here - perhaps `getLTOOptLevel` would be better here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113738/new/ https://reviews.llvm.org/D113738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D114842: [lld-macho] Remove old macho darwin lld
thevinster added inline comments. Comment at: lld/lib/CMakeLists.txt:1 add_subdirectory(Core) Just wondering, can't we delete this too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://reviews.llvm.org/D114842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D133633: [CMake] Add ClangBootstrap configuration
thevinster added inline comments. Comment at: clang/cmake/modules/ClangBootstrap.cmake:11 +macro(clang_bootstrap_add name) + cmake_parse_arguments(ARG "" "LINKER;AR;RANLIB;OBJCOPY;STRIP" +"DEPENDS;TABLEGEN;CMAKE_ARGS;BUILD_TOOL_ARGS" Were you planning to also use the single arguments list such as `ARG_LINKER` in the `CMAKE_ARGS`? Without it, I have to supply an override to `CLANG_BOLT_INSTRUMENT_EXTRA_CMAKE_FLAGS` so I can avoid using the gnu linker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133633/new/ https://reviews.llvm.org/D133633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
