[PATCH] D82574: Merge TableGen files used for clang options

2020-07-10 Thread Valeriy Dmitriev via Phabricator via cfe-commits 
vdmitrie added inline comments.



Comment at: clang/include/clang/Driver/Options.td:3668
+  HelpText<"Do not emit code that uses the red zone.">;
+def dwarf_column_info : Flag<["-"], "dwarf-column-info">,
+  HelpText<"Turn on column location information.">;

This option was deleted.



Comment at: clang/include/clang/Driver/Options.td:3738
+  HelpText<"Try to use a split stack if possible.">;
+def mno_zero_initialized_in_bss : Flag<["-"], "mno-zero-initialized-in-bss">,
+  HelpText<"Do not put zero initialized data in the BSS">;

This option was deleted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82574/new/

https://reviews.llvm.org/D82574



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-24 Thread Valeriy Dmitriev via Phabricator via cfe-commits 
vdmitrie added inline comments.



Comment at: clang/lib/Parse/ParseOpenMP.cpp:197
   }
   return DKind < OMPD_unknown ? static_cast(DKind)
   : OMPD_unknown;

Should this be a comparison against llvm::omp::Directive_enumSize rather than 
OMPD_unknown?


And there is an assertion in file clang/lib/Basic/OpenMPKinds.cpp
that I guess needs to be updated the same way:
void clang::getOpenMPCaptureRegions(
SmallVectorImpl &CaptureRegions,
OpenMPDirectiveKind DKind) {
  assert(DKind <= OMPD_unknown);



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81736/new/

https://reviews.llvm.org/D81736



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits