[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

2017-08-22 Thread Teodor MICU via Phabricator via cfe-commits
mteodor added a comment.

In https://reviews.llvm.org/D33932#793994, @djasper wrote:

> Just make clang-format always do this. I don't think anyone is relying on the 
> current behavior.


Well, someone did rely on **case sensitive** match. I thought //case 
insensitive// by default was just a Windows thing. Not anymore.

  - Regex:   '^"I[A-Z]+[a-z].*\.h"'
Priority:1

This rule became too greedy on latest revision. Now not only interfaces are 
prioritized but also all headers that start with [Ii].


Repository:
  rL LLVM

https://reviews.llvm.org/D33932



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D12407: [clang-format-vs] Add an option to reformat source code when file is saved to disk

2017-07-07 Thread Teodor MICU via Phabricator via cfe-commits
mteodor added a comment.

In https://reviews.llvm.org/D12407#314671, @klimek wrote:

> I think we'll want somebody to find out whether there are simpler ways to
>  implement this.


**Format on save** was implemented by https://reviews.llvm.org/D29221.

What's the new functionality in the **reformat** implementation?
Always trigger a (re)format even if there are no changes? Probably not a good 
idea.


https://reviews.llvm.org/D12407



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits