[PATCH] D110280: [modules] Fix IRGen assertion on accessing ObjC ivar inside a method.
SharonXu added a comment. Hi @vsapsai, I checked out the apple `stable/20211026` llvm-project branch at https://github.com/apple/llvm-project/tree/stable/20211026, and ran check-clang locally, but the tested added in the patch `clang/test/Modules/merge-objc-interface.m` failed with the error clang: /home/sharonxu/local/apple_llvm_main/llvm-project/clang/lib/AST/RecordLayoutBuilder.cpp:3457: uint64_t clang::ASTContext::lookupFieldBitOffset(const clang::ObjCInterfaceDecl*, const clang::ObjCImplementationDecl*, const clang::ObjCIvarDecl*) const: Assertion `Index < RL->getFieldCount() && "Ivar is not inside record layout!"' failed. Do you know what's going on? Any fix missing on the `stable/20211026` branch? Thanks! Sharon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110280/new/ https://reviews.llvm.org/D110280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D81624: [CodeGen] Simplify the way lifetime of block captures is extended
SharonXu added a comment. Hi @ahatanak , @rjmccall, we found that this diff causes an issue: When -fobjc-arc is enabled, if a block is passed as an argument to a function whose corresponding parameter type is && rvalue and attributed as noescape, the object captured by the block can get destructed before the block invocation. More details and code example is in https://bugs.llvm.org/show_bug.cgi?id=50043 we filed. We've tried locally reverted this patch, and the test cases mentioned in that bug report passed successfully. I am wondering could you please take a look at the bug report and see if you have a quick fix or something? Thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81624/new/ https://reviews.llvm.org/D81624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
