[PATCH] D92269: [TableGen] Eliminate the 'code' type

2020-12-04 Thread Sean Silva via Phabricator via cfe-commits 
silvas added a comment.

Wow, awesome work!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92269/new/

https://reviews.llvm.org/D92269

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

2021-11-11 Thread Sean Silva via Phabricator via cfe-commits 
silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.

Nice :) This looks pretty straightforward, but given how core this is, wait for 
another approver or two.




Comment at: llvm/include/llvm/ADT/DenseMapInfo.h:42
 
-template
-struct DenseMapInfo {
+template  struct DenseMapInfo {
   //static inline T getEmptyKey();

bondhugula wrote:
> A code comment here?
+1. Is there a doc that needs to be updated too? We should update the source of 
truth is for "here's how to use DenseMapInfo", if such documentation even 
exists :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113641/new/

https://reviews.llvm.org/D113641

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26960: [docs] Use x86_64 and i386 instead of x86 as arch for triples.

2016-12-01 Thread Sean Silva via Phabricator via cfe-commits 
silvas added a comment.

LGTM. Do you need me to commit this for you?


https://reviews.llvm.org/D26960



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits