[PATCH] D98594: [clang/docs/LibASTMatchersTutorial.rst,clang/docs/HowToSetupToolingForLLVM.rst] ninja now uses `configure.py` rather than `bootstrap.py`

[Samuel Marks via Phabricator via cfe-commits]

SamuelMarks created this revision.
SamuelMarks added a project: LLVM.
SamuelMarks requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D98594

Files:
  clang/docs/HowToSetupToolingForLLVM.rst
  clang/docs/LibASTMatchersTutorial.rst


Index: clang/docs/LibASTMatchersTutorial.rst
===
--- clang/docs/LibASTMatchersTutorial.rst
+++ clang/docs/LibASTMatchersTutorial.rst
@@ -33,7 +33,7 @@
   git clone https://github.com/martine/ninja.git
   cd ninja
   git checkout release
-  ./bootstrap.py
+  ./configure.py
   sudo cp ninja /usr/bin/
 
   cd ~/clang-llvm
Index: clang/docs/HowToSetupToolingForLLVM.rst
===
--- clang/docs/HowToSetupToolingForLLVM.rst
+++ clang/docs/HowToSetupToolingForLLVM.rst
@@ -156,7 +156,7 @@
 
   $ git clone git://github.com/martine/ninja.git
   $ cd ninja/
-  $ ./bootstrap.py
+  $ ./configure.py
 
 This will result in a single binary ``ninja`` in the current directory.
 It doesn't require installation and can just be copied to any location


Index: clang/docs/LibASTMatchersTutorial.rst
===
--- clang/docs/LibASTMatchersTutorial.rst
+++ clang/docs/LibASTMatchersTutorial.rst
@@ -33,7 +33,7 @@
   git clone https://github.com/martine/ninja.git
   cd ninja
   git checkout release
-  ./bootstrap.py
+  ./configure.py
   sudo cp ninja /usr/bin/
 
   cd ~/clang-llvm
Index: clang/docs/HowToSetupToolingForLLVM.rst
===
--- clang/docs/HowToSetupToolingForLLVM.rst
+++ clang/docs/HowToSetupToolingForLLVM.rst
@@ -156,7 +156,7 @@
 
   $ git clone git://github.com/martine/ninja.git
   $ cd ninja/
-  $ ./bootstrap.py
+  $ ./configure.py
 
 This will result in a single binary ``ninja`` in the current directory.
 It doesn't require installation and can just be copied to any location
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D98594: [clang/docs/LibASTMatchersTutorial.rst,clang/docs/HowToSetupToolingForLLVM.rst] ninja now uses `configure.py` rather than `bootstrap.py`

[Samuel Marks via Phabricator via cfe-commits]

SamuelMarks updated this revision to Diff 330487.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98594/new/

https://reviews.llvm.org/D98594

Files:
  clang/docs/HowToSetupToolingForLLVM.rst
  clang/docs/LibASTMatchersTutorial.rst


Index: clang/docs/LibASTMatchersTutorial.rst
===
--- clang/docs/LibASTMatchersTutorial.rst
+++ clang/docs/LibASTMatchersTutorial.rst
@@ -33,7 +33,7 @@
   git clone https://github.com/martine/ninja.git
   cd ninja
   git checkout release
-  ./bootstrap.py
+  ./configure.py --bootstrap
   sudo cp ninja /usr/bin/
 
   cd ~/clang-llvm
Index: clang/docs/HowToSetupToolingForLLVM.rst
===
--- clang/docs/HowToSetupToolingForLLVM.rst
+++ clang/docs/HowToSetupToolingForLLVM.rst
@@ -156,7 +156,7 @@
 
   $ git clone git://github.com/martine/ninja.git
   $ cd ninja/
-  $ ./bootstrap.py
+  $ ./configure.py --bootstrap
 
 This will result in a single binary ``ninja`` in the current directory.
 It doesn't require installation and can just be copied to any location


Index: clang/docs/LibASTMatchersTutorial.rst
===
--- clang/docs/LibASTMatchersTutorial.rst
+++ clang/docs/LibASTMatchersTutorial.rst
@@ -33,7 +33,7 @@
   git clone https://github.com/martine/ninja.git
   cd ninja
   git checkout release
-  ./bootstrap.py
+  ./configure.py --bootstrap
   sudo cp ninja /usr/bin/
 
   cd ~/clang-llvm
Index: clang/docs/HowToSetupToolingForLLVM.rst
===
--- clang/docs/HowToSetupToolingForLLVM.rst
+++ clang/docs/HowToSetupToolingForLLVM.rst
@@ -156,7 +156,7 @@
 
   $ git clone git://github.com/martine/ninja.git
   $ cd ninja/
-  $ ./bootstrap.py
+  $ ./configure.py --bootstrap
 
 This will result in a single binary ``ninja`` in the current directory.
 It doesn't require installation and can just be copied to any location
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

[Samuel Marks via Phabricator via cfe-commits]

SamuelMarks created this revision.
SamuelMarks added a project: LLVM.
SamuelMarks requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111490

Files:
  clang/docs/HowToSetupToolingForLLVM.rst
  clang/docs/LibASTMatchersTutorial.rst


Index: clang/docs/LibASTMatchersTutorial.rst
===
--- clang/docs/LibASTMatchersTutorial.rst
+++ clang/docs/LibASTMatchersTutorial.rst
@@ -30,11 +30,9 @@
 .. code-block:: console
 
   cd ~/clang-llvm
-  git clone https://github.com/martine/ninja.git
-  cd ninja
-  git checkout release
-  ./bootstrap.py
-  sudo cp ninja /usr/bin/
+  git clone git://github.com/ninja-build/ninja.git
+  ./configure.py --bootstrap
+  sudo cp ninja /usr/local/bin/
 
   cd ~/clang-llvm
   git clone git://cmake.org/stage/cmake.git
Index: clang/docs/HowToSetupToolingForLLVM.rst
===
--- clang/docs/HowToSetupToolingForLLVM.rst
+++ clang/docs/HowToSetupToolingForLLVM.rst
@@ -143,7 +143,7 @@
 Using Ninja Build System
 ===
 
-Optionally you can use the `Ninja `_
+Optionally you can use the `Ninja `_
 build system instead of make. It is aimed at making your builds faster.
 Currently this step will require building Ninja from sources.
 
@@ -154,9 +154,9 @@
 
 .. code-block:: console
 
-  $ git clone git://github.com/martine/ninja.git
+  $ git clone git://github.com/ninja-build/ninja.git
   $ cd ninja/
-  $ ./bootstrap.py
+  $ ./configure.py --bootstrap
 
 This will result in a single binary ``ninja`` in the current directory.
 It doesn't require installation and can just be copied to any location
@@ -165,7 +165,6 @@
 .. code-block:: console
 
   $ sudo cp ninja /usr/local/bin/
-  $ sudo chmod a+rx /usr/local/bin/ninja
 
 After doing all of this, you'll need to generate Ninja build files for
 LLVM with CMake. You need to make a build directory and run CMake from


Index: clang/docs/LibASTMatchersTutorial.rst
===
--- clang/docs/LibASTMatchersTutorial.rst
+++ clang/docs/LibASTMatchersTutorial.rst
@@ -30,11 +30,9 @@
 .. code-block:: console
 
   cd ~/clang-llvm
-  git clone https://github.com/martine/ninja.git
-  cd ninja
-  git checkout release
-  ./bootstrap.py
-  sudo cp ninja /usr/bin/
+  git clone git://github.com/ninja-build/ninja.git
+  ./configure.py --bootstrap
+  sudo cp ninja /usr/local/bin/
 
   cd ~/clang-llvm
   git clone git://cmake.org/stage/cmake.git
Index: clang/docs/HowToSetupToolingForLLVM.rst
===
--- clang/docs/HowToSetupToolingForLLVM.rst
+++ clang/docs/HowToSetupToolingForLLVM.rst
@@ -143,7 +143,7 @@
 Using Ninja Build System
 ===
 
-Optionally you can use the `Ninja `_
+Optionally you can use the `Ninja `_
 build system instead of make. It is aimed at making your builds faster.
 Currently this step will require building Ninja from sources.
 
@@ -154,9 +154,9 @@
 
 .. code-block:: console
 
-  $ git clone git://github.com/martine/ninja.git
+  $ git clone git://github.com/ninja-build/ninja.git
   $ cd ninja/
-  $ ./bootstrap.py
+  $ ./configure.py --bootstrap
 
 This will result in a single binary ``ninja`` in the current directory.
 It doesn't require installation and can just be copied to any location
@@ -165,7 +165,6 @@
 .. code-block:: console
 
   $ sudo cp ninja /usr/local/bin/
-  $ sudo chmod a+rx /usr/local/bin/ninja
 
 After doing all of this, you'll need to generate Ninja build files for
 LLVM with CMake. You need to make a build directory and run CMake from
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

[Samuel Marks via Phabricator via cfe-commits]

SamuelMarks added inline comments.



Comment at: clang/docs/LibASTMatchersTutorial.rst:34
-  git clone https://github.com/martine/ninja.git
-  cd ninja
-  git checkout release

xgupta wrote:
> why removed `cd ninja` & `git checkout release`?
@xgupta To match how ninja is installed everywhere else in LLVM guides. Also 
ninja's release branch is almost a year old, whereas its master is 5 days old.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111490/new/

https://reviews.llvm.org/D111490

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

[Samuel Marks via Phabricator via cfe-commits]

SamuelMarks updated this revision to Diff 378463.
SamuelMarks added a comment.

Also updates appveyor to latest release version of ninja


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111490/new/

https://reviews.llvm.org/D111490

Files:
  clang/docs/HowToSetupToolingForLLVM.rst
  clang/docs/LibASTMatchersTutorial.rst
  libcxx/appveyor-reqs-install.cmd


Index: libcxx/appveyor-reqs-install.cmd
===
--- libcxx/appveyor-reqs-install.cmd
+++ libcxx/appveyor-reqs-install.cmd
@@ -38,7 +38,7 @@
 :: Install Ninja
 ::###
 if NOT EXIST ninja (
-  appveyor DownloadFile 
https://github.com/ninja-build/ninja/releases/download/v1.6.0/ninja-win.zip 
-FileName ninja.zip
+  appveyor DownloadFile 
https://github.com/ninja-build/ninja/releases/download/v1.10.2/ninja-win.zip 
-FileName ninja.zip
   7z x ninja.zip -oC:\projects\deps\ninja > nul
   rm ninja.zip
 )
Index: clang/docs/LibASTMatchersTutorial.rst
===
--- clang/docs/LibASTMatchersTutorial.rst
+++ clang/docs/LibASTMatchersTutorial.rst
@@ -30,7 +30,7 @@
 .. code-block:: console
 
   cd ~/clang-llvm
-  git clone git://github.com/ninja-build/ninja.git
+  git clone https://github.com/ninja-build/ninja
   ./configure.py --bootstrap
   sudo cp ninja /usr/local/bin/
 
Index: clang/docs/HowToSetupToolingForLLVM.rst
===
--- clang/docs/HowToSetupToolingForLLVM.rst
+++ clang/docs/HowToSetupToolingForLLVM.rst
@@ -154,7 +154,7 @@
 
 .. code-block:: console
 
-  $ git clone git://github.com/ninja-build/ninja.git
+  $ git clone https://github.com/ninja-build/ninja
   $ cd ninja/
   $ ./configure.py --bootstrap
 


Index: libcxx/appveyor-reqs-install.cmd
===
--- libcxx/appveyor-reqs-install.cmd
+++ libcxx/appveyor-reqs-install.cmd
@@ -38,7 +38,7 @@
 :: Install Ninja
 ::###
 if NOT EXIST ninja (
-  appveyor DownloadFile https://github.com/ninja-build/ninja/releases/download/v1.6.0/ninja-win.zip -FileName ninja.zip
+  appveyor DownloadFile https://github.com/ninja-build/ninja/releases/download/v1.10.2/ninja-win.zip -FileName ninja.zip
   7z x ninja.zip -oC:\projects\deps\ninja > nul
   rm ninja.zip
 )
Index: clang/docs/LibASTMatchersTutorial.rst
===
--- clang/docs/LibASTMatchersTutorial.rst
+++ clang/docs/LibASTMatchersTutorial.rst
@@ -30,7 +30,7 @@
 .. code-block:: console
 
   cd ~/clang-llvm
-  git clone git://github.com/ninja-build/ninja.git
+  git clone https://github.com/ninja-build/ninja
   ./configure.py --bootstrap
   sudo cp ninja /usr/local/bin/
 
Index: clang/docs/HowToSetupToolingForLLVM.rst
===
--- clang/docs/HowToSetupToolingForLLVM.rst
+++ clang/docs/HowToSetupToolingForLLVM.rst
@@ -154,7 +154,7 @@
 
 .. code-block:: console
 
-  $ git clone git://github.com/ninja-build/ninja.git
+  $ git clone https://github.com/ninja-build/ninja
   $ cd ninja/
   $ ./configure.py --bootstrap
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

[Samuel Marks via Phabricator via cfe-commits]

SamuelMarks updated this revision to Diff 378466.
SamuelMarks marked an inline comment as done.
SamuelMarks added a comment.

pushd/popd to the various build dirs


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111490/new/

https://reviews.llvm.org/D111490

Files:
  clang/docs/HowToSetupToolingForLLVM.rst
  clang/docs/LibASTMatchersTutorial.rst
  libcxx/appveyor-reqs-install.cmd


Index: libcxx/appveyor-reqs-install.cmd
===
--- libcxx/appveyor-reqs-install.cmd
+++ libcxx/appveyor-reqs-install.cmd
@@ -38,7 +38,7 @@
 :: Install Ninja
 ::###
 if NOT EXIST ninja (
-  appveyor DownloadFile 
https://github.com/ninja-build/ninja/releases/download/v1.6.0/ninja-win.zip 
-FileName ninja.zip
+  appveyor DownloadFile 
https://github.com/ninja-build/ninja/releases/download/v1.10.2/ninja-win.zip 
-FileName ninja.zip
   7z x ninja.zip -oC:\projects\deps\ninja > nul
   rm ninja.zip
 )
Index: clang/docs/LibASTMatchersTutorial.rst
===
--- clang/docs/LibASTMatchersTutorial.rst
+++ clang/docs/LibASTMatchersTutorial.rst
@@ -30,29 +30,31 @@
 .. code-block:: console
 
   cd ~/clang-llvm
-  git clone git://github.com/ninja-build/ninja.git
+  git clone https://github.com/ninja-build/ninja
+  pushd ninja
   ./configure.py --bootstrap
   sudo cp ninja /usr/local/bin/
+  popd
 
-  cd ~/clang-llvm
   git clone git://cmake.org/stage/cmake.git
   cd cmake
   git checkout next
   ./bootstrap
   make
   sudo make install
+  popd
 
 Okay. Now we'll build Clang!
 
 .. code-block:: console
 
-  cd ~/clang-llvm
-  mkdir build && cd build
+  mkdir build && pushd build
   cmake -G Ninja ../llvm -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra" 
-DLLVM_BUILD_TESTS=ON  # Enable tests; default is off.
   ninja
   ninja check   # Test LLVM only.
   ninja clang-test  # Test Clang only.
   ninja install
+  popd
 
 And we're live.
 
Index: clang/docs/HowToSetupToolingForLLVM.rst
===
--- clang/docs/HowToSetupToolingForLLVM.rst
+++ clang/docs/HowToSetupToolingForLLVM.rst
@@ -154,7 +154,7 @@
 
 .. code-block:: console
 
-  $ git clone git://github.com/ninja-build/ninja.git
+  $ git clone https://github.com/ninja-build/ninja
   $ cd ninja/
   $ ./configure.py --bootstrap
 


Index: libcxx/appveyor-reqs-install.cmd
===
--- libcxx/appveyor-reqs-install.cmd
+++ libcxx/appveyor-reqs-install.cmd
@@ -38,7 +38,7 @@
 :: Install Ninja
 ::###
 if NOT EXIST ninja (
-  appveyor DownloadFile https://github.com/ninja-build/ninja/releases/download/v1.6.0/ninja-win.zip -FileName ninja.zip
+  appveyor DownloadFile https://github.com/ninja-build/ninja/releases/download/v1.10.2/ninja-win.zip -FileName ninja.zip
   7z x ninja.zip -oC:\projects\deps\ninja > nul
   rm ninja.zip
 )
Index: clang/docs/LibASTMatchersTutorial.rst
===
--- clang/docs/LibASTMatchersTutorial.rst
+++ clang/docs/LibASTMatchersTutorial.rst
@@ -30,29 +30,31 @@
 .. code-block:: console
 
   cd ~/clang-llvm
-  git clone git://github.com/ninja-build/ninja.git
+  git clone https://github.com/ninja-build/ninja
+  pushd ninja
   ./configure.py --bootstrap
   sudo cp ninja /usr/local/bin/
+  popd
 
-  cd ~/clang-llvm
   git clone git://cmake.org/stage/cmake.git
   cd cmake
   git checkout next
   ./bootstrap
   make
   sudo make install
+  popd
 
 Okay. Now we'll build Clang!
 
 .. code-block:: console
 
-  cd ~/clang-llvm
-  mkdir build && cd build
+  mkdir build && pushd build
   cmake -G Ninja ../llvm -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra" -DLLVM_BUILD_TESTS=ON  # Enable tests; default is off.
   ninja
   ninja check   # Test LLVM only.
   ninja clang-test  # Test Clang only.
   ninja install
+  popd
 
 And we're live.
 
Index: clang/docs/HowToSetupToolingForLLVM.rst
===
--- clang/docs/HowToSetupToolingForLLVM.rst
+++ clang/docs/HowToSetupToolingForLLVM.rst
@@ -154,7 +154,7 @@
 
 .. code-block:: console
 
-  $ git clone git://github.com/ninja-build/ninja.git
+  $ git clone https://github.com/ninja-build/ninja
   $ cd ninja/
   $ ./configure.py --bootstrap
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

[Samuel Marks via Phabricator via cfe-commits]

SamuelMarks added inline comments.



Comment at: clang/docs/LibASTMatchersTutorial.rst:34
-  git clone https://github.com/martine/ninja.git
-  cd ninja
-  git checkout release

xgupta wrote:
> SamuelMarks wrote:
> > xgupta wrote:
> > > why removed `cd ninja` & `git checkout release`?
> > @xgupta To match how ninja is installed everywhere else in LLVM guides. 
> > Also ninja's release branch is almost a year old, whereas its master is 5 
> > days old.
> fine, but we need to cd into ninja directory to run configure step, right?
Good point, I'll fix all of them with pushd and popd


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111490/new/

https://reviews.llvm.org/D111490

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

[Samuel Marks via Phabricator via cfe-commits]

SamuelMarks updated this revision to Diff 378467.
SamuelMarks added a comment.

push/popd for build dirs


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111490/new/

https://reviews.llvm.org/D111490

Files:
  clang/docs/HowToSetupToolingForLLVM.rst
  clang/docs/LibASTMatchersTutorial.rst
  libcxx/appveyor-reqs-install.cmd


Index: libcxx/appveyor-reqs-install.cmd
===
--- libcxx/appveyor-reqs-install.cmd
+++ libcxx/appveyor-reqs-install.cmd
@@ -38,7 +38,7 @@
 :: Install Ninja
 ::###
 if NOT EXIST ninja (
-  appveyor DownloadFile 
https://github.com/ninja-build/ninja/releases/download/v1.6.0/ninja-win.zip 
-FileName ninja.zip
+  appveyor DownloadFile 
https://github.com/ninja-build/ninja/releases/download/v1.10.2/ninja-win.zip 
-FileName ninja.zip
   7z x ninja.zip -oC:\projects\deps\ninja > nul
   rm ninja.zip
 )
Index: clang/docs/LibASTMatchersTutorial.rst
===
--- clang/docs/LibASTMatchersTutorial.rst
+++ clang/docs/LibASTMatchersTutorial.rst
@@ -30,29 +30,31 @@
 .. code-block:: console
 
   cd ~/clang-llvm
-  git clone git://github.com/ninja-build/ninja.git
+  git clone https://github.com/ninja-build/ninja
+  pushd ninja
   ./configure.py --bootstrap
   sudo cp ninja /usr/local/bin/
+  popd
 
-  cd ~/clang-llvm
   git clone git://cmake.org/stage/cmake.git
   cd cmake
   git checkout next
   ./bootstrap
   make
   sudo make install
+  popd
 
 Okay. Now we'll build Clang!
 
 .. code-block:: console
 
-  cd ~/clang-llvm
-  mkdir build && cd build
+  mkdir build && pushd build
   cmake -G Ninja ../llvm -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra" 
-DLLVM_BUILD_TESTS=ON  # Enable tests; default is off.
   ninja
   ninja check   # Test LLVM only.
   ninja clang-test  # Test Clang only.
   ninja install
+  popd
 
 And we're live.
 
Index: clang/docs/HowToSetupToolingForLLVM.rst
===
--- clang/docs/HowToSetupToolingForLLVM.rst
+++ clang/docs/HowToSetupToolingForLLVM.rst
@@ -154,7 +154,7 @@
 
 .. code-block:: console
 
-  $ git clone git://github.com/ninja-build/ninja.git
+  $ git clone https://github.com/ninja-build/ninja
   $ cd ninja/
   $ ./configure.py --bootstrap
 


Index: libcxx/appveyor-reqs-install.cmd
===
--- libcxx/appveyor-reqs-install.cmd
+++ libcxx/appveyor-reqs-install.cmd
@@ -38,7 +38,7 @@
 :: Install Ninja
 ::###
 if NOT EXIST ninja (
-  appveyor DownloadFile https://github.com/ninja-build/ninja/releases/download/v1.6.0/ninja-win.zip -FileName ninja.zip
+  appveyor DownloadFile https://github.com/ninja-build/ninja/releases/download/v1.10.2/ninja-win.zip -FileName ninja.zip
   7z x ninja.zip -oC:\projects\deps\ninja > nul
   rm ninja.zip
 )
Index: clang/docs/LibASTMatchersTutorial.rst
===
--- clang/docs/LibASTMatchersTutorial.rst
+++ clang/docs/LibASTMatchersTutorial.rst
@@ -30,29 +30,31 @@
 .. code-block:: console
 
   cd ~/clang-llvm
-  git clone git://github.com/ninja-build/ninja.git
+  git clone https://github.com/ninja-build/ninja
+  pushd ninja
   ./configure.py --bootstrap
   sudo cp ninja /usr/local/bin/
+  popd
 
-  cd ~/clang-llvm
   git clone git://cmake.org/stage/cmake.git
   cd cmake
   git checkout next
   ./bootstrap
   make
   sudo make install
+  popd
 
 Okay. Now we'll build Clang!
 
 .. code-block:: console
 
-  cd ~/clang-llvm
-  mkdir build && cd build
+  mkdir build && pushd build
   cmake -G Ninja ../llvm -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra" -DLLVM_BUILD_TESTS=ON  # Enable tests; default is off.
   ninja
   ninja check   # Test LLVM only.
   ninja clang-test  # Test Clang only.
   ninja install
+  popd
 
 And we're live.
 
Index: clang/docs/HowToSetupToolingForLLVM.rst
===
--- clang/docs/HowToSetupToolingForLLVM.rst
+++ clang/docs/HowToSetupToolingForLLVM.rst
@@ -154,7 +154,7 @@
 
 .. code-block:: console
 
-  $ git clone git://github.com/ninja-build/ninja.git
+  $ git clone https://github.com/ninja-build/ninja
   $ cd ninja/
   $ ./configure.py --bootstrap
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

[Samuel Marks via Phabricator via cfe-commits]

SamuelMarks added a comment.

In D111490#3053564 , @xgupta wrote:

> The patch is not applying cleanly so can't be committed. please follow the 
> above phabricator docs I suggested before to upload it.

Oh there was an error in the web interface which told me to retry. Will check 
the docs on how to delete|supersede diffs


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111490/new/

https://reviews.llvm.org/D111490

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits