[clang] [clang][coverage] fixing "if constexpr" and "if consteval" coverage report (PR #77214)

2024-01-07 Thread Paweł Bylica via cfe-commits 

chfast wrote:

> But in future it would be useful to mark whole gap there as skipped instead. 
> If there is interest I would do it in another PR.

This would be very useful not to treat compile-time unreachable code as 
uncovered. Can the skipped code be marked separately in the reports?

https://github.com/llvm/llvm-project/pull/77214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0c82fa6 - [python][tests] Fix string comparison with "is"

2020-09-28 Thread Paweł Bylica via cfe-commits 

Author: Paweł Bylica
Date: 2020-09-28T21:11:50+02:00
New Revision: 0c82fa677f24d8a9656af41ac9cc64ea4f818bc0

URL: 
https://github.com/llvm/llvm-project/commit/0c82fa677f24d8a9656af41ac9cc64ea4f818bc0
DIFF: 
https://github.com/llvm/llvm-project/commit/0c82fa677f24d8a9656af41ac9cc64ea4f818bc0.diff

LOG: [python][tests] Fix string comparison with "is"

Added: 


Modified: 
clang/bindings/python/tests/cindex/test_cursor_kind.py

Removed: 




diff  --git a/clang/bindings/python/tests/cindex/test_cursor_kind.py 
b/clang/bindings/python/tests/cindex/test_cursor_kind.py
index e6b9558b3cc1..ed245d593d55 100644
--- a/clang/bindings/python/tests/cindex/test_cursor_kind.py
+++ b/clang/bindings/python/tests/cindex/test_cursor_kind.py
@@ -10,7 +10,7 @@
 
 class TestCursorKind(unittest.TestCase):
 def test_name(self):
-self.assertTrue(CursorKind.UNEXPOSED_DECL.name is 'UNEXPOSED_DECL')
+self.assertEqual(CursorKind.UNEXPOSED_DECL.name, 'UNEXPOSED_DECL')
 
 def test_get_all_kinds(self):
 kinds = CursorKind.get_all_kinds()



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7324535 - [clang][NFC] Fix typos in sema builtins test

2023-07-18 Thread Paweł Bylica via cfe-commits 

Author: Paweł Bylica
Date: 2023-07-18T15:40:28+02:00
New Revision: 73245359847da385182dd3b3b2168e246a69a276

URL: 
https://github.com/llvm/llvm-project/commit/73245359847da385182dd3b3b2168e246a69a276
DIFF: 
https://github.com/llvm/llvm-project/commit/73245359847da385182dd3b3b2168e246a69a276.diff

LOG: [clang][NFC] Fix typos in sema builtins test

Added: 


Modified: 
clang/test/Sema/constant-builtins-2.c

Removed: 




diff  --git a/clang/test/Sema/constant-builtins-2.c 
b/clang/test/Sema/constant-builtins-2.c
index 1f4d1d3c23ade5..93948201c451b4 100644
--- a/clang/test/Sema/constant-builtins-2.c
+++ b/clang/test/Sema/constant-builtins-2.c
@@ -217,13 +217,13 @@ char 
bitreverse4[__builtin_bitreverse64(0x0123456789ABCDEFULL) == 0xF7B3D591E6A2
 
 char rotateleft1[__builtin_rotateleft8(0x01, 5) == 0x20 ? 1 : -1];
 char rotateleft2[__builtin_rotateleft16(0x3210, 11) == 0x8190 ? 1 : -1];
-char rotateleft2[__builtin_rotateleft32(0x76543210, 22) == 0x841D950C ? 1 : 
-1];
-char rotateleft2[__builtin_rotateleft64(0xFEDCBA9876543210ULL, 55) == 
0x87F6E5D4C3B2A19ULL ? 1 : -1];
+char rotateleft3[__builtin_rotateleft32(0x76543210, 22) == 0x841D950C ? 1 : 
-1];
+char rotateleft4[__builtin_rotateleft64(0xFEDCBA9876543210ULL, 55) == 
0x87F6E5D4C3B2A19ULL ? 1 : -1];
 
 char rotateright1[__builtin_rotateright8(0x01, 5) == 0x08 ? 1 : -1];
 char rotateright2[__builtin_rotateright16(0x3210, 11) == 0x4206 ? 1 : -1];
-char rotateright2[__builtin_rotateright32(0x76543210, 22) == 0x50C841D9 ? 1 : 
-1];
-char rotateright2[__builtin_rotateright64(0xFEDCBA9876543210ULL, 55) == 
0xB97530ECA86421FDULL ? 1 : -1];
+char rotateright3[__builtin_rotateright32(0x76543210, 22) == 0x50C841D9 ? 1 : 
-1];
+char rotateright4[__builtin_rotateright64(0xFEDCBA9876543210ULL, 55) == 
0xB97530ECA86421FDULL ? 1 : -1];
 
 char ffs1[__builtin_ffs(0) == 0 ? 1 : -1];
 char ffs2[__builtin_ffs(1) == 1 ? 1 : -1];



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][use-internal-linkage] fix false positive for consteval function (PR #122141)

2025-01-08 Thread Paweł Bylica via cfe-commits 


@@ -0,0 +1,3 @@
+// RUN: %check_clang_tidy -std=c++20 %s misc-use-internal-linkage %t -- -- 
-I%S/Inputs/use-internal-linkage
+
+consteval void gh122096() {}

chfast wrote:

Can you also check `constexpr void func_constexpr()`?

https://github.com/llvm/llvm-project/pull/122141
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][use-internal-linkage] fix false positive for consteval function (PR #122141)

2025-01-09 Thread Paweł Bylica via cfe-commits 

https://github.com/chfast approved this pull request.


https://github.com/llvm/llvm-project/pull/122141
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits