[clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

[Paul Zander via cfe-commits]

@@ -284,7 +284,7 @@ def sync_csv(rows: List[Tuple], from_github: 
List[PaperInfo]) -> List[Tuple]:
 results.append(gh.for_printing())
 continue
 elif paper.status != gh.status:
-print(f"We found a CSV row and a Github issue with different 
statuses:\nrow: {row}\Github issue: {gh}")
+print(rf"We found a CSV row and a Github issue with different 
statuses:\nrow: {row}\Github issue: {gh}")

negril wrote:

That can be fix if you want me to?

https://github.com/llvm/llvm-project/pull/105990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

[Paul Zander via cfe-commits]

https://github.com/negril edited 
https://github.com/llvm/llvm-project/pull/105990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

[Paul Zander via cfe-commits]

@@ -284,7 +284,7 @@ def sync_csv(rows: List[Tuple], from_github: 
List[PaperInfo]) -> List[Tuple]:
 results.append(gh.for_printing())
 continue
 elif paper.status != gh.status:
-print(f"We found a CSV row and a Github issue with different 
statuses:\nrow: {row}\Github issue: {gh}")
+print(rf"We found a CSV row and a Github issue with different 
statuses:\nrow: {row}\Github issue: {gh}")

negril wrote:

See https://docs.python.org/3/reference/lexical_analysis.html#escape-sequences. 
The `\n` and `\G` are interpreted as an escape sequence. Hence necessitates the 
change.  

https://github.com/llvm/llvm-project/pull/105990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

[Paul Zander via cfe-commits]

negril wrote:

> This was suggested in #91856 and the suggestion there was that we need to 
> split it up per sub-project which is something @e-kwsm has been doing: 
> https://github.com/llvm/llvm-project/pulls/e-kwsm so I don't think this one 
> is needed.

That PR is 3 months old? What are the odds or the timeline of it getting merged?

https://github.com/llvm/llvm-project/pull/105990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

[Paul Zander via cfe-commits]

negril wrote:

> > That PR is 3 months old? What are the odds or the timeline of it getting 
> > merged?
> 
> Probably whenever the author gets back to reviewers. There might be a couple 
> rounds of review before things get pushed through, but patches for two 
> subprojects have landed already.
> 
> The author doesn't seem particularly responsive though. If you want to pick 
> it up, creating per-project PRs like done in the original PR linked, that 
> would probably be best.

Sounds good.

https://github.com/llvm/llvm-project/pull/105990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits