[PATCH] D49403: More aggressively complete RecordTypes with Function Pointers

2018-07-23 Thread Olga Chupina via Phabricator via cfe-commits
olga.chupina added a comment.

Hello,

Since the structure field which is a function pointer appears in the assignment 
statement, it messes up the type analysis.
If it would really be a pointer to a structure then the corresponding 
assignment could be treated as bad type casting and potentially lead to 
unauthorized structure field access.


https://reviews.llvm.org/D49403



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D49403: More aggressively complete RecordTypes with Function Pointers

2018-07-23 Thread Olga Chupina via Phabricator via cfe-commits
olga.chupina added a comment.

Yes, correct.


https://reviews.llvm.org/D49403



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D49403: More aggressively complete RecordTypes with Function Pointers

2018-07-25 Thread Olga Chupina via Phabricator via cfe-commits
olga.chupina added a comment.

I should probably add one more example to explain my point of view.
Suppose we have an indirect call in the program and we need to know all 
possible goals for this indirect call. Then we would like to know that one of 
the structure fields is a function pointer and it can be a candidate for 
indirect call resolution.


https://reviews.llvm.org/D49403



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits