[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

[Nikola Smiljanić via Phabricator via cfe-commits]

nikola added a comment.

Commit r298574, thanks for woking on this folks!


https://reviews.llvm.org/D21279



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32519: [Sema] Avoid using a null type pointer (fixes PR32750)

[Nikola Smiljanić via Phabricator via cfe-commits]

nikola accepted this revision.
nikola added a comment.
This revision is now accepted and ready to land.

LGTM




Comment at: test/SemaCXX/MicrosoftExtensions.cpp:516
+template struct A {};
+template struct B : A > { A::C::D d; }; // expected-error 
{{missing 'typename' prior to dependent type name 'A::C::D'}}
+}

nitpick: you don't need the space between angle brackets since you set the 
standard to C++14, I'm not sure what the convention here is but you don't need 
more than C++11...


https://reviews.llvm.org/D32519



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits