[PATCH] D157767: [Driver] move Haiku header search path management to the driver

[Niels Sascha Reedijk via Phabricator via cfe-commits]

nielx added a comment.

I will test the patch and see if it works as expected. Note that we currently 
have the following preset header paths in our GCC port 
.




Comment at: clang/lib/Driver/ToolChains/Haiku.cpp:58
+  addSystemInclude(DriverArgs, CC1Args, D.SysRoot + 
"/boot/system/develop/headers/os/app");
+  addSystemInclude(DriverArgs, CC1Args, D.SysRoot + 
"/boot/system/develop/headers/os/arch");
+  addSystemInclude(DriverArgs, CC1Args, D.SysRoot + 
"/boot/system/develop/headers/os/device");

Not (or no longer) in GCC default sys path, so can be removed.



Comment at: clang/lib/Driver/ToolChains/Haiku.cpp:86
+  addSystemInclude(DriverArgs, CC1Args, D.SysRoot + 
"/boot/system/develop/headers/glibc");
+  addSystemInclude(DriverArgs, CC1Args, D.SysRoot + 
"/boot/system/develop/headers/posix");
+  addSystemInclude(DriverArgs, CC1Args, D.SysRoot + 
"/boot/system/develop/headers");

Missing: /boot/system/develop/headers/gnu


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157767/new/

https://reviews.llvm.org/D157767

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157767: [Driver] move Haiku header search path management to the driver

[Niels Sascha Reedijk via Phabricator via cfe-commits]

nielx accepted this revision.
nielx added a comment.
This revision is now accepted and ready to land.

I have applied the patch to a recent checkout of the llvm repository, and I 
then built clang. With this clang build I have built various source files that 
depend on headers that are in the system search paths. I can confirm that the 
compiler was able to find all the referenced headers.

This change looks good to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157767/new/

https://reviews.llvm.org/D157767

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159390: Haiku: Enable thread-local storag, disable PIE / enable PIC by default

[Niels Sascha Reedijk via Phabricator via cfe-commits]

nielx added a comment.

Can confirm this is correct for Haiku.
For PIC by default, see our GCC haiku.h 
.
These changes have also been part of our patches for clang 
.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159390/new/

https://reviews.llvm.org/D159390

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159390: Haiku: Enable thread-local storag, disable PIE / enable PIC by default

[Niels Sascha Reedijk via Phabricator via cfe-commits]

nielx accepted this revision.
nielx added a comment.
This revision is now accepted and ready to land.

Looks good to me!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159390/new/

https://reviews.llvm.org/D159390

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

[Niels Sascha Reedijk via Phabricator via cfe-commits]

nielx added a comment.

Have you been able to test the changes?




Comment at: clang/lib/Driver/ToolChains/Haiku.h:39
+
+  unsigned GetDefaultDwarfVersion() const override { return 2; }
+

I propose pushing this to version 4. Haiku's GCC also defaults to version 4 now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159409/new/

https://reviews.llvm.org/D159409

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

[Niels Sascha Reedijk via Phabricator via cfe-commits]

nielx accepted this revision.
nielx added a comment.
This revision is now accepted and ready to land.

Patch looks good to me and in line with previous work that was done on LLVM to 
run it on Haiku.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159409/new/

https://reviews.llvm.org/D159409

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits