[PATCH] D70765: LTOVisibility.rst: fix up syntax in example
dankamongmen added a comment. I hate to bother anyone, but can this go ahead and get merged? :) thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70765/new/ https://reviews.llvm.org/D70765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D70765: LTOVisibility.rst: fix up syntax in example
dankamongmen added a comment. > Typically the author commits the patch, unless they don't have commit access > and request the reviewer to commit for them, but I don't see a request for > that here. Thanks, Teresa. I indeed do not have commit access (so far as I know or can tell, anyway), so please consider this comment to be such a request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70765/new/ https://reviews.llvm.org/D70765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D70765: LTOVisibility.rst: fix up syntax in example
dankamongmen created this revision.
dankamongmen added a project: LLVM.
Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya,
inglorion, mehdi_amini.
Herald added a project: clang.
dankamongmen added a reviewer: pcc.
Pretty self-evident. This example was missing an lparen. Added it, and fixed up
the ASCII art.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D70765
Files:
clang/docs/LTOVisibility.rst
Index: clang/docs/LTOVisibility.rst
===
--- clang/docs/LTOVisibility.rst
+++ clang/docs/LTOVisibility.rst
@@ -83,7 +83,7 @@
| | }; | | | struct E
: D {|
| | struct [[clang::lto_visibility_public]] D {| | |
virtual void g() { ... }|
| |virtual void g() = 0;| | | };
|
-| | }; | | |
__attribute__(visibility("default"))) D *mkE() { |
+| | }; | | |
__attribute__((visibility("default"))) D *mkE() { |
| | | | |return
new E; |
| +-+ | | }
|
| | |
|
Index: clang/docs/LTOVisibility.rst
===
--- clang/docs/LTOVisibility.rst
+++ clang/docs/LTOVisibility.rst
@@ -83,7 +83,7 @@
| | }; | | | struct E : D {|
| | struct [[clang::lto_visibility_public]] D {| | |virtual void g() { ... }|
| |virtual void g() = 0;| | | };|
-| | }; | | | __attribute__(visibility("default"))) D *mkE() { |
+| | }; | | | __attribute__((visibility("default"))) D *mkE() { |
| | | | |return new E; |
| +-+ | | } |
| | ||
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D70765: LTOVisibility.rst: fix up syntax in example
dankamongmen added a comment. Thanks, @pcc! Is there anything I need to do, or am I just waiting on someone to merge this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70765/new/ https://reviews.llvm.org/D70765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
