Re: [PATCH] D129014: rewording static_assert to more generic static assertion

[Muhammad Usman Shahid via cfe-commits]

Ok ... I am working on the tests I will update it

On Sat, Jul 2, 2022, 7:35 AM Shivam Gupta via Phabricator <
revi...@reviews.llvm.org> wrote:

> xgupta added a comment.
>
> Running check-clang after applying the patch, results into 36 failed test
> cases. Please update them all.
> Also add a description of patch motivation(via the Edit Revision option on
> the top) for why you are making the changes (like any wrong behavior you
> are seeing etc).
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D129014/new/
>
> https://reviews.llvm.org/D129014
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D129048: Rewording the "static_assert" to static assertion

[Muhammad Usman Shahid via cfe-commits]

Done.

On Wed, Jul 13, 2022 at 10:30 PM Aaron Ballman via Phabricator <
revi...@reviews.llvm.org> wrote:

> aaron.ballman added inline comments.
>
>
> 
> Comment at:
> clang/test/CXX/expr/expr.prim/expr.prim.req/nested-requirement.cpp:48
>  }
> \ No newline at end of file
>
> 
> Codesbyusman wrote:
> > aaron.ballman wrote:
> > > xgupta wrote:
> > > > a 'newline' is missing here.
> > > Still missing the newline at the end of the file here.
> > what here is mean by the missing line I am adding the newline but no
> changes to the comment
> >
> > > No newline at end of file
> >
> >
> C++ used to have a requirement that every file end with a newline (C still
> has that requirement), so Phabricator is reminding you that the file should
> still end in a newline. The fix is to put a newline after the closing curly
> brace on line 47 (so the newline is line 48).
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D129048/new/
>
> https://reviews.llvm.org/D129048
>
>

-- 
Regards,
Cyber Security Student
Muhammad Usman Shahid
BS Cyber Security & Digital Forensics
National University Of Computer & Emerging Sciences, Islamabad Pakistan
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits