[PATCH] D125679: [Clang] Added options for integrated backend only used for SPIR-V for now

[Michal Paszkowski via Phabricator via cfe-commits]

mpaszkowski accepted this revision.
mpaszkowski added a comment.
This revision is now accepted and ready to land.

The typos noticed by Ilia need to be fixed, but apart from this the patch LGTM! 
Thank you Anastasia!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125679/new/

https://reviews.llvm.org/D125679

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

[Michal Paszkowski via Phabricator via cfe-commits]

mpaszkowski accepted this revision.
mpaszkowski added a comment.
This revision is now accepted and ready to land.

@Keenuts Hi Nathan, thanks for the patch! I agree with your approach and I 
think that this solution despite being a "hack" seems to be the most 
straightforward. Eventual differences could be handled in the backend. I would 
be open for other solutions in the future (for example in case other targets 
would also stumble upon a similar dilemma), but this looks like a completely 
valid approach to me.

@Anastasia Thanks for your input on this thread! I tried reaching out to you, 
but I realized you may no longer have access to the email address.

LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155978/new/

https://reviews.llvm.org/D155978

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

[Michal Paszkowski via Phabricator via cfe-commits]

mpaszkowski added a comment.

In D155978#4639499 , @Keenuts wrote:

> In D155978#4639094 , @mpaszkowski 
> wrote:
>
>> @Keenuts Hi Nathan, thanks for the patch! I agree with your approach and I 
>> think that this solution despite being a "hack" seems to be the most 
>> straightforward. Eventual differences could be handled in the backend. I 
>> would be open for other solutions in the future (for example in case other 
>> targets would also stumble upon a similar dilemma), but this looks like a 
>> completely valid approach to me.
>
> Thanks!
> Do you know how we can get this merged? (we have no commit access on our end).

Either I could push the patch for you (adding you as an author) or preferably 
you could gain commit access yourself for this and future patches. Please see 
this guide  
and send an email to Chris (include your GitHub user name and a link to this 
Phabricator review). Please let me know which option you would prefer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155978/new/

https://reviews.llvm.org/D155978

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits