[PATCH] D152625: run-clang-tidy: forward warnings-as-errors argument

[Maxim Kolesnikov via Phabricator via cfe-commits]

indev29 created this revision.
indev29 added reviewers: cfe-commits, njames93.
Herald added subscribers: PiotrZSL, carlosgalvezp.
Herald added a project: All.
indev29 requested review of this revision.
Herald added a project: clang-tools-extra.

Forward `warnings-as-errors` argument to clang-tidy.


https://reviews.llvm.org/D152625

Files:
  clang-tools-extra/clang-tidy/tool/run-clang-tidy.py


Index: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
===
--- clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
+++ clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
@@ -105,6 +105,7 @@
 line_filter,
 use_color,
 plugins,
+warnings_as_errors,
 ):
 """Gets a command line for clang-tidy."""
 start = [clang_tidy_binary]
@@ -141,6 +142,8 @@
 start.append("-config=" + config)
 for plugin in plugins:
 start.append("-load=" + plugin)
+if warnings_as_errors:
+start.append("--warnings-as-errors=" + warnings_as_errors)
 start.append(f)
 return start
 
@@ -224,6 +227,7 @@
 args.line_filter,
 args.use_color,
 args.plugins,
+args.warnings_as_errors,
 )
 
 proc = subprocess.Popen(
@@ -363,6 +367,11 @@
 default=[],
 help="Load the specified plugin in clang-tidy.",
 )
+parser.add_argument(
+"-warnings-as-errors",
+default=None,
+help="Upgrades warnings to errors. Same format as " "'-checks'",
+)
 args = parser.parse_args()
 
 db_path = "compile_commands.json"
@@ -399,6 +408,7 @@
 args.line_filter,
 args.use_color,
 args.plugins,
+args.warnings_as_errors,
 )
 invocation.append("-list-checks")
 invocation.append("-")


Index: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
===
--- clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
+++ clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
@@ -105,6 +105,7 @@
 line_filter,
 use_color,
 plugins,
+warnings_as_errors,
 ):
 """Gets a command line for clang-tidy."""
 start = [clang_tidy_binary]
@@ -141,6 +142,8 @@
 start.append("-config=" + config)
 for plugin in plugins:
 start.append("-load=" + plugin)
+if warnings_as_errors:
+start.append("--warnings-as-errors=" + warnings_as_errors)
 start.append(f)
 return start
 
@@ -224,6 +227,7 @@
 args.line_filter,
 args.use_color,
 args.plugins,
+args.warnings_as_errors,
 )
 
 proc = subprocess.Popen(
@@ -363,6 +367,11 @@
 default=[],
 help="Load the specified plugin in clang-tidy.",
 )
+parser.add_argument(
+"-warnings-as-errors",
+default=None,
+help="Upgrades warnings to errors. Same format as " "'-checks'",
+)
 args = parser.parse_args()
 
 db_path = "compile_commands.json"
@@ -399,6 +408,7 @@
 args.line_filter,
 args.use_color,
 args.plugins,
+args.warnings_as_errors,
 )
 invocation.append("-list-checks")
 invocation.append("-")
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152625: [clang-tidy] run-clang-tidy: forward warnings-as-errors argument

[Maxim Kolesnikov via Phabricator via cfe-commits]

indev29 added a comment.

@PiotrZSL could you please commit? I don't think I have access yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152625/new/

https://reviews.llvm.org/D152625

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152625: [clang-tidy] run-clang-tidy: forward warnings-as-errors argument

[Maxim Kolesnikov via Phabricator via cfe-commits]

indev29 added a comment.

In D152625#4413366 , @PiotrZSL wrote:

> In D152625#4413242 , @indev29 wrote:
>
>> @PiotrZSL could you please commit? I don't think I have access yet.
>
> Author & Email please for git, under which should it be delivered.

`indev `


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152625/new/

https://reviews.llvm.org/D152625

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits