Re: [PATCH] D18408: readability check for const params in declarations
My attempts to do this end with: $ arc diff Linting... No lint engine configured for this project. Running unit tests... No unit test engine is configured for this project. SKIP STAGING Unable to determine repository for this change. Exception ERR_CLOSED: This revision has already been closed. (Run with `--trace` for a full exception trace.) On Wed, Mar 30, 2016 at 7:39 AM, Alexander Kornienko wrote: > alexfh added a comment. > > Actually, we missed one thing: may I ask you to update > docs/ReleaseNotes.rst with a short description of the new check? > > > Repository: > rL LLVM > > http://reviews.llvm.org/D18408 > > > > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D18408: readability check for const params in declarations
Helped by sbenza@ http://reviews.llvm.org/D18608 On Wed, Mar 30, 2016 at 12:54 PM, Richard wrote: > LegalizeAdulthood added a comment. > > Maybe you need to rebase first? I haven't used arc. > > > Repository: > rL LLVM > > http://reviews.llvm.org/D18408 > > > > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D18408: readability check for const params in declarations
I tried manually specifying --create. The problem was that my commit message had stuff from an early arc diff still in it which arc was picking up and getting confused by. Matt On Thu, Mar 31, 2016 at 8:29 AM, Alexander Kornienko wrote: > On Wed, Mar 30, 2016 at 4:01 PM, Matthew Fowles Kulukundis < > matt.fow...@gmail.com> wrote: > >> My attempts to do this end with: >> >> $ arc diff >> > > I normally use `arc diff --create` or `arc diff --update D`, and this > works. > > >> Linting... >> No lint engine configured for this project. >> Running unit tests... >> No unit test engine is configured for this project. >> SKIP STAGING Unable to determine repository for this change. >> Exception >> ERR_CLOSED: This revision has already been closed. >> (Run with `--trace` for a full exception trace.) >> >> >> On Wed, Mar 30, 2016 at 7:39 AM, Alexander Kornienko >> wrote: >> >>> alexfh added a comment. >>> >>> Actually, we missed one thing: may I ask you to update >>> docs/ReleaseNotes.rst with a short description of the new check? >>> >>> >>> Repository: >>> rL LLVM >>> >>> http://reviews.llvm.org/D18408 >>> >>> >>> >>> >> > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
