[PATCH] D156718: [ASanStableABI][Driver] Stop linking to asan dylib when stable abi is enabled

2023-08-01 Thread Mariusz Borsa via Phabricator via cfe-commits 
wrotki accepted this revision.
wrotki added a comment.

Yes, it looks good. I downloaded the patch and ran the test - had some doubts 
about 'otool -L %t |grep -q "dynamic.dylib"' - but verified with other ASAN 
tests binaries  and convinced myself that it's the right thing to do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156718/new/

https://reviews.llvm.org/D156718

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145715: Remove -lower-global-dtors-via-cxa-atexit flag

2023-03-10 Thread Mariusz Borsa via Phabricator via cfe-commits 
wrotki added a comment.

LGTM, perhaps with addressing @RKSimon remark about release notes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145715/new/

https://reviews.llvm.org/D145715

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits