[PATCH] D109653: Fix some definitions on AVR target

2021-09-11 Thread Mara Sophie Grosch via Phabricator via cfe-commits 
LittleFox94 created this revision.
LittleFox94 added a reviewer: cfe-commits.
Herald added subscribers: Jim, dylanmckay.
LittleFox94 requested review of this revision.
Herald added a project: clang.

Fix definitions in AVR target for MCUs xmega16a4u and xmega128a4u to match 
avr-libc.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D109653

Files:
  clang/lib/Basic/Targets/AVR.cpp


Index: clang/lib/Basic/Targets/AVR.cpp
===
--- clang/lib/Basic/Targets/AVR.cpp
+++ clang/lib/Basic/Targets/AVR.cpp
@@ -223,7 +223,7 @@
 {"atmega256rfr2", "__AVR_ATmega256RFR2__"},
 {"atmega2564rfr2", "__AVR_ATmega2564RFR2__"},
 {"atxmega16a4", "__AVR_ATxmega16A4__"},
-{"atxmega16a4u", "__AVR_ATxmega16a4U__"},
+{"atxmega16a4u", "__AVR_ATxmega16A4U__"},
 {"atxmega16c4", "__AVR_ATxmega16C4__"},
 {"atxmega16d4", "__AVR_ATxmega16D4__"},
 {"atxmega32a4", "__AVR_ATxmega32A4__"},
@@ -265,7 +265,7 @@
 {"atxmega384d3", "__AVR_ATxmega384D3__"},
 {"atxmega128a1", "__AVR_ATxmega128A1__"},
 {"atxmega128a1u", "__AVR_ATxmega128A1U__"},
-{"atxmega128a4u", "__AVR_ATxmega128a4U__"},
+{"atxmega128a4u", "__AVR_ATxmega128A4U__"},
 {"attiny4", "__AVR_ATtiny4__"},
 {"attiny5", "__AVR_ATtiny5__"},
 {"attiny9", "__AVR_ATtiny9__"},


Index: clang/lib/Basic/Targets/AVR.cpp
===
--- clang/lib/Basic/Targets/AVR.cpp
+++ clang/lib/Basic/Targets/AVR.cpp
@@ -223,7 +223,7 @@
 {"atmega256rfr2", "__AVR_ATmega256RFR2__"},
 {"atmega2564rfr2", "__AVR_ATmega2564RFR2__"},
 {"atxmega16a4", "__AVR_ATxmega16A4__"},
-{"atxmega16a4u", "__AVR_ATxmega16a4U__"},
+{"atxmega16a4u", "__AVR_ATxmega16A4U__"},
 {"atxmega16c4", "__AVR_ATxmega16C4__"},
 {"atxmega16d4", "__AVR_ATxmega16D4__"},
 {"atxmega32a4", "__AVR_ATxmega32A4__"},
@@ -265,7 +265,7 @@
 {"atxmega384d3", "__AVR_ATxmega384D3__"},
 {"atxmega128a1", "__AVR_ATxmega128A1__"},
 {"atxmega128a1u", "__AVR_ATxmega128A1U__"},
-{"atxmega128a4u", "__AVR_ATxmega128a4U__"},
+{"atxmega128a4u", "__AVR_ATxmega128A4U__"},
 {"attiny4", "__AVR_ATtiny4__"},
 {"attiny5", "__AVR_ATtiny5__"},
 {"attiny9", "__AVR_ATtiny9__"},
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D109653: Fix some definitions on AVR target

2021-09-11 Thread Mara Sophie Grosch via Phabricator via cfe-commits 
LittleFox94 added a comment.

I guess this would have qualified for post-commit review, but since this would 
have been my first commit I made myself, I want to be careful ^^
Comments on this would be nice, if this would have been ok to just commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109653/new/

https://reviews.llvm.org/D109653

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D109653: Fix some definitions on AVR target

2021-09-12 Thread Mara Sophie Grosch via Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rG339c73404224: [Clang][AVR] Fix definitions on AVR target 
(authored by LittleFox94).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109653/new/

https://reviews.llvm.org/D109653

Files:
  clang/lib/Basic/Targets/AVR.cpp


Index: clang/lib/Basic/Targets/AVR.cpp
===
--- clang/lib/Basic/Targets/AVR.cpp
+++ clang/lib/Basic/Targets/AVR.cpp
@@ -223,7 +223,7 @@
 {"atmega256rfr2", "__AVR_ATmega256RFR2__"},
 {"atmega2564rfr2", "__AVR_ATmega2564RFR2__"},
 {"atxmega16a4", "__AVR_ATxmega16A4__"},
-{"atxmega16a4u", "__AVR_ATxmega16a4U__"},
+{"atxmega16a4u", "__AVR_ATxmega16A4U__"},
 {"atxmega16c4", "__AVR_ATxmega16C4__"},
 {"atxmega16d4", "__AVR_ATxmega16D4__"},
 {"atxmega32a4", "__AVR_ATxmega32A4__"},
@@ -265,7 +265,7 @@
 {"atxmega384d3", "__AVR_ATxmega384D3__"},
 {"atxmega128a1", "__AVR_ATxmega128A1__"},
 {"atxmega128a1u", "__AVR_ATxmega128A1U__"},
-{"atxmega128a4u", "__AVR_ATxmega128a4U__"},
+{"atxmega128a4u", "__AVR_ATxmega128A4U__"},
 {"attiny4", "__AVR_ATtiny4__"},
 {"attiny5", "__AVR_ATtiny5__"},
 {"attiny9", "__AVR_ATtiny9__"},


Index: clang/lib/Basic/Targets/AVR.cpp
===
--- clang/lib/Basic/Targets/AVR.cpp
+++ clang/lib/Basic/Targets/AVR.cpp
@@ -223,7 +223,7 @@
 {"atmega256rfr2", "__AVR_ATmega256RFR2__"},
 {"atmega2564rfr2", "__AVR_ATmega2564RFR2__"},
 {"atxmega16a4", "__AVR_ATxmega16A4__"},
-{"atxmega16a4u", "__AVR_ATxmega16a4U__"},
+{"atxmega16a4u", "__AVR_ATxmega16A4U__"},
 {"atxmega16c4", "__AVR_ATxmega16C4__"},
 {"atxmega16d4", "__AVR_ATxmega16D4__"},
 {"atxmega32a4", "__AVR_ATxmega32A4__"},
@@ -265,7 +265,7 @@
 {"atxmega384d3", "__AVR_ATxmega384D3__"},
 {"atxmega128a1", "__AVR_ATxmega128A1__"},
 {"atxmega128a1u", "__AVR_ATxmega128A1U__"},
-{"atxmega128a4u", "__AVR_ATxmega128a4U__"},
+{"atxmega128a4u", "__AVR_ATxmega128A4U__"},
 {"attiny4", "__AVR_ATtiny4__"},
 {"attiny5", "__AVR_ATtiny5__"},
 {"attiny9", "__AVR_ATtiny9__"},
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D109653: Fix some definitions on AVR target

2021-09-12 Thread Mara Sophie Grosch via Phabricator via cfe-commits 
LittleFox94 added a comment.

This is committed by now, but I would still love to know if this would have 
been ok to just commit (and have post-commit review) :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109653/new/

https://reviews.llvm.org/D109653

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits