[PATCH] D110525: [docs] fix docs for bugprone-virtual-near-miss & performance-type-promotion-in-math-fn

[M B via Phabricator via cfe-commits]

bakinovsky-m created this revision.
bakinovsky-m added a reviewer: aaron.ballman.
bakinovsky-m created this object with edit policy "Administrators".
bakinovsky-m added a project: clang-tools-extra.
bakinovsky-m requested review of this revision.
Herald added a subscriber: cfe-commits.

bugprone-virtual-near-miss & performance-type-promotion-in-math-fn


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D110525

Files:
  clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst
  
clang-tools-extra/docs/clang-tidy/checks/performance-type-promotion-in-math-fn.rst


Index: 
clang-tools-extra/docs/clang-tidy/checks/performance-type-promotion-in-math-fn.rst
===
--- 
clang-tools-extra/docs/clang-tidy/checks/performance-type-promotion-in-math-fn.rst
+++ 
clang-tools-extra/docs/clang-tidy/checks/performance-type-promotion-in-math-fn.rst
@@ -6,7 +6,7 @@
 Finds calls to C math library functions (from ``math.h`` or, in C++, ``cmath``)
 with implicit ``float`` to ``double`` promotions.
 
-For example, warns on ``::sin(0.f)``, because this funciton's parameter is a
+For example, warns on ``::sin(0.f)``, because this function's parameter is a
 double. You probably meant to call ``std::sin(0.f)`` (in C++), or ``sinf(0.f)``
 (in C).
 
Index: clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst
===
--- clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst
+++ clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst
@@ -15,6 +15,6 @@
   };
 
   struct Derived : Base {
-virtual funk();
+virtual void funk();
 // warning: 'Derived::funk' has a similar name and the same signature as 
virtual method 'Base::func'; did you mean to override it?
   };


Index: clang-tools-extra/docs/clang-tidy/checks/performance-type-promotion-in-math-fn.rst
===
--- clang-tools-extra/docs/clang-tidy/checks/performance-type-promotion-in-math-fn.rst
+++ clang-tools-extra/docs/clang-tidy/checks/performance-type-promotion-in-math-fn.rst
@@ -6,7 +6,7 @@
 Finds calls to C math library functions (from ``math.h`` or, in C++, ``cmath``)
 with implicit ``float`` to ``double`` promotions.
 
-For example, warns on ``::sin(0.f)``, because this funciton's parameter is a
+For example, warns on ``::sin(0.f)``, because this function's parameter is a
 double. You probably meant to call ``std::sin(0.f)`` (in C++), or ``sinf(0.f)``
 (in C).
 
Index: clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst
===
--- clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst
+++ clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst
@@ -15,6 +15,6 @@
   };
 
   struct Derived : Base {
-virtual funk();
+virtual void funk();
 // warning: 'Derived::funk' has a similar name and the same signature as virtual method 'Base::func'; did you mean to override it?
   };
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D110525: [docs] fix docs for bugprone-virtual-near-miss & performance-type-promotion-in-math-fn

[M B via Phabricator via cfe-commits]

bakinovsky-m added a comment.

In D110525#3025314 , @aaron.ballman 
wrote:

> I'm not certain how, but somehow this review is set to be uneditable, so I 
> cannot mark it as accepted (or close it later once it lands).
>
>> bakinovsky-m created this object with edit policy "Administrators".
>
> I think you may need to edit the review's policy so it goes back to whatever 
> the default is.

My bad, should be editable now

In D110525#3025300 , @aaron.ballman 
wrote:

> Thanks for the fixes, LGTM! Do you need me to commit on your behalf? If so, 
> please let me know what name and email address you would like me to use for 
> patch attribution in git.

Yes, please. Name: "M Bakinovsky", email: "mbtr...@yandex.ru"

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110525/new/

https://reviews.llvm.org/D110525

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits