[clang] [Clang] add emit -Wignored-base-class-qualifiers diagnostic for cv-qualified base classes (PR #132116)

[Lyle Dean via cfe-commits]

https://github.com/lyledean1 edited 
https://github.com/llvm/llvm-project/pull/132116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add emit -Wignored-base-class-qualifiers diagnostic for cv-qualified base classes (PR #132116)

[Lyle Dean via cfe-commits]

https://github.com/lyledean1 edited 
https://github.com/llvm/llvm-project/pull/132116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add emit -Wignored-base-class-qualifiers diagnostic for cv-qualified base classes (PR #132116)

[Lyle Dean via cfe-commits]

https://github.com/lyledean1 edited 
https://github.com/llvm/llvm-project/pull/132116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add emit -Wignored-cv-qualifiers diagnostic for cv-qualified base classes (PR #132116)

[Lyle Dean via cfe-commits]

@@ -284,6 +284,8 @@ Improvements to Clang's diagnostics
 
 - Improve the ``-Wundefined-func-template`` warning when a function template 
is not instantiated due to being unreachable in modules.
 
+- Clang now emits a ``-Wignored-cv-qualifiers`` diagnostic when a base class 
includes cv-qualifiers ([toadd]).

lyledean1 wrote:

on the original PR release note i saw a reference to the feature number i.e 
(#GH55474) and wasn't sure if i needed to add it here - removed it 

https://github.com/llvm/llvm-project/pull/132116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add emit -Wignored-cv-qualifiers diagnostic for cv-qualified base classes (PR #132116)

[Lyle Dean via cfe-commits]

@@ -497,6 +497,7 @@ def GNUImaginaryConstant : 
DiagGroup<"gnu-imaginary-constant">;
 def IgnoredGCH : DiagGroup<"ignored-gch">;
 def IgnoredReferenceQualifiers : DiagGroup<"ignored-reference-qualifiers">;
 def IgnoredQualifiers : DiagGroup<"ignored-qualifiers", 
[IgnoredReferenceQualifiers]>;
+def IgnoredCVQualifiers : DiagGroup<"ignored-cv-qualifiers", 
[IgnoredReferenceQualifiers]>;

lyledean1 wrote:

I've updated this, so all references will be to `ignored-base-class-qualifiers` 
now 

https://github.com/llvm/llvm-project/pull/132116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add emit -Wignored-base-class-qualifiers diagnostic for cv-qualified base classes (PR #132116)

[Lyle Dean via cfe-commits]

https://github.com/lyledean1 edited 
https://github.com/llvm/llvm-project/pull/132116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add emit -Wignored-base-class-qualifiers diagnostic for cv-qualified base classes (PR #132116)

[Lyle Dean via cfe-commits]

lyledean1 wrote:

Thanks for the review @AaronBallman , I've updated the PR from your comments 
and the CI has passed - is this good to merge now? 

https://github.com/llvm/llvm-project/pull/132116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add emit -Wignored-base-class-qualifiers diagnostic for cv-qualified base classes (PR #132116)

[Lyle Dean via cfe-commits]

@@ -497,6 +497,7 @@ def GNUImaginaryConstant : 
DiagGroup<"gnu-imaginary-constant">;
 def IgnoredGCH : DiagGroup<"ignored-gch">;
 def IgnoredReferenceQualifiers : DiagGroup<"ignored-reference-qualifiers">;
 def IgnoredQualifiers : DiagGroup<"ignored-qualifiers", 
[IgnoredReferenceQualifiers]>;
+def IgnoredBaseClassQualifiers : DiagGroup<"ignored-base-class-qualifiers", 
[IgnoredReferenceQualifiers]>;

lyledean1 wrote:

Ah yeah, makes sense, thanks 

https://github.com/llvm/llvm-project/pull/132116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add emit -Wignored-base-class-qualifiers diagnostic for cv-qualified base classes (PR #132116)

[Lyle Dean via cfe-commits]

@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 %s -std=c++11 -Wignored-qualifiers -verify
+// RUN: %clang_cc1 %s -std=c++11 -Wignored-base-class-qualifiers -verify

lyledean1 wrote:

I've updated those tests - so will let the CI run now and confirm everything 
passes 

https://github.com/llvm/llvm-project/pull/132116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add emit -Wignored-base-class-qualifiers diagnostic for cv-qualified base classes (PR #132116)

[Lyle Dean via cfe-commits]

lyledean1 wrote:

CI seems to be failing with the message `no such option: 
--break-system-packages` from `pip` for 
`[buildkite/github-pull-requests/linux-linux-x64](https://buildkite.com/llvm-project/github-pull-requests/builds/164119#0195f387-c1b7-4bc5-8fb8-cc8049f19033)`
 and 
[buildkite/github-pull-requests](https://buildkite.com/llvm-project/github-pull-requests/builds/164119)

But haven't changed anything around this? 

https://github.com/llvm/llvm-project/pull/132116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add emit -Wignored-base-class-qualifiers diagnostic for cv-qualified base classes (PR #132116)

[Lyle Dean via cfe-commits]

lyledean1 wrote:

> It isn't clear what the merge conflicts are (github won't tell me for some 
> reason?) but those need fixing before we can merge this.

It was on the release notes, that's fixed now 

https://github.com/llvm/llvm-project/pull/132116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add emit -Wignored-base-class-qualifiers diagnostic for cv-qualified base classes (PR #132116)

[Lyle Dean via cfe-commits]

@@ -298,6 +298,8 @@ Improvements to Clang's diagnostics
 
 - Improve the ``-Wundefined-func-template`` warning when a function template 
is not instantiated due to being unreachable in modules.
 
+- Clang now emits a ``-Wignored-base-class-qualifiers`` diagnostic when a base 
class includes cv-qualifiers.

lyledean1 wrote:

Thanks, will add that in 

https://github.com/llvm/llvm-project/pull/132116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add emit -Wignored-base-class-qualifiers diagnostic for cv-qualified base classes (PR #132116)

[Lyle Dean via cfe-commits]

https://github.com/lyledean1 edited 
https://github.com/llvm/llvm-project/pull/132116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add emit -Wignored-base-class-qualifiers diagnostic for cv-qualified base classes (PR #132116)

[Lyle Dean via cfe-commits]

lyledean1 wrote:

Happy to adjust this @MagentaTreehouse for LLVM 20 - what would that require?

@erichkeane is this ok to merge (assuming I make the changes for the above - 
the CI has passed)

https://github.com/llvm/llvm-project/pull/132116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits