[PATCH] D77342: Sema: check for null TInfo in ActOnBaseSpecifier

[Luke Zarko via Phabricator via cfe-commits]

zarko abandoned this revision.
zarko added a comment.

I can confirm that this has been fixed by the revision that rsmith has linked. 
Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77342/new/

https://reviews.llvm.org/D77342



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D77342: Sema: check for null TInfo in ActOnBaseSpecifier

[Luke Zarko via Phabricator via cfe-commits]

zarko created this revision.
zarko added a project: clang.
Herald added a subscriber: cfe-commits.
zarko added a reviewer: rsmith.

In certain cases (particularly when some input files are missing), 
GetTypeFromParser will set TInfo to nullptr in ActOnBaseSpecifier.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77342

Files:
  clang/lib/Sema/SemaDeclCXX.cpp


Index: clang/lib/Sema/SemaDeclCXX.cpp
===
--- clang/lib/Sema/SemaDeclCXX.cpp
+++ clang/lib/Sema/SemaDeclCXX.cpp
@@ -2581,6 +2581,8 @@
 
   TypeSourceInfo *TInfo = nullptr;
   GetTypeFromParser(basetype, &TInfo);
+  if (TInfo == nullptr)
+return true;
 
   if (EllipsisLoc.isInvalid() &&
   DiagnoseUnexpandedParameterPack(SpecifierRange.getBegin(), TInfo,


Index: clang/lib/Sema/SemaDeclCXX.cpp
===
--- clang/lib/Sema/SemaDeclCXX.cpp
+++ clang/lib/Sema/SemaDeclCXX.cpp
@@ -2581,6 +2581,8 @@
 
   TypeSourceInfo *TInfo = nullptr;
   GetTypeFromParser(basetype, &TInfo);
+  if (TInfo == nullptr)
+return true;
 
   if (EllipsisLoc.isInvalid() &&
   DiagnoseUnexpandedParameterPack(SpecifierRange.getBegin(), TInfo,
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits