[PATCH] D24084: [CMake] Cleanup libunwind lookup code.

2016-12-15 Thread Logan Chien via Phabricator via cfe-commits
logan added a comment.

Hi @rengolin:

Yeah.  It is a kind of similar.  Another route is to move the code from 
`/include/unwind.h` to `/lib/Headers` and then ship a shim 
layer with `libc++abi` and/or `libunwind` for old clang.


https://reviews.llvm.org/D24084



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D24083: [CMake] Fix libc++abi __aeabi_idiv() link error.

2016-12-15 Thread Logan Chien via Phabricator via cfe-commits
logan added a comment.

Sorry, I don't have time to work on this recently.  Here's the plan:

1. Add another flag to specify the path to `libclang_rt-builtin.a`.

2. If that flag was not specified and the compiler is `clang`, then run `clang 
-###` to extract for `-L` option and `-l` option for `libclang_rt-builtin.a`.

3. If neither (1) nor (2) are available, then report an error.

I hope I can get back to this next week.


https://reviews.llvm.org/D24083



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits