[PATCH] D123648: Restrict lvalue-to-rvalue conversions in CGExprConstant.

2022-04-12 Thread LiqinWeng via Phabricator via cfe-commits 
Miss_Grape added inline comments.



Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1096
+case CK_LValueToRValue: {
+  // We don't really support doing lvalue-to-rvalue conversions here; any
+  // interesting conversions should be done in Evaluate().  But as a

Could you add a test case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123648/new/

https://reviews.llvm.org/D123648

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D139908: [clang] Do not extend i8 return values to i16 on AVR.

2022-12-20 Thread LiqinWeng via Phabricator via cfe-commits 
Miss_Grape added a comment.

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139908/new/

https://reviews.llvm.org/D139908

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits