[PATCH] D126302: [PowerPC] Diagnose invalid combination with Altivec, VSX and soft-float
Laurentiu added a comment. Hi Nemanja, I just realized I only had a personal account on llvm.org. Would you be able to remove me from that review and add laurentiu.ter...@windriver.com instead? Thanks, Laurentiu Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126302/new/ https://reviews.llvm.org/D126302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D126302: [PowerPC] Diagnose invalid combination with Altivec, VSX and soft-float
ltertan added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:455 + << "-maltivec"; + + // Cannot allow soft-float with Altivec. Do we also need to return from here? Comment at: clang/lib/Basic/Targets/PPC.cpp:461 + << "-mno-altivec"; + // vsx was not explicitly turned off. Do we also need to return from here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126302/new/ https://reviews.llvm.org/D126302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
