[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

2021-10-06 Thread Kevin Greene via Phabricator via cfe-commits
kgk added a comment.

Will the new macros in this patch also be useful for supporting the 
surface-related methods that also use __nv_tex_surf_handler (from 
surface_indirect_functions.h)?

I gave this new code a try with surf2Dread and surf2Dwrite, and based on the 
errors, it look like it may just be a matter of creating the right mappings 
from Tag to the correct asm using these new macros (e.g. __isurf2Dwrite_v2 and 
isurf2Dread).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110089/new/

https://reviews.llvm.org/D110089

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

2021-10-07 Thread Kevin Greene via Phabricator via cfe-commits
kgk added a comment.

In D110089#3048460 , @tra wrote:

> In D110089#3047161 , @kgk wrote:
>
>> Will the new macros in this patch also be useful for supporting the 
>> surface-related methods that also use __nv_tex_surf_handler (from 
>> surface_indirect_functions.h)?
>>
>> I gave this new code a try with surf2Dread and surf2Dwrite, and based on the 
>> errors, it look like it may just be a matter of creating the right mappings 
>> from Tag to the correct asm using these new macros (e.g. __isurf2Dwrite_v2 
>> and isurf2Dread).
>
> Only textures are supported at the moment, but adding support for surface 
> operations would indeed be very similar.
>
> Basically we just need to add specializations for the surface operations. 
> It's fairly tedious, but straightforward in principle.

Very cool! I am selfishly curious if support for surface operations is 
something you plan to add. I had a go at implementing it myself today based on 
this patch, and found it a bit harder than I was expecting 😅

I appreciate your work on this; it's great to see cuda texture support being 
added to clang!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110089/new/

https://reviews.llvm.org/D110089

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits