[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
kiszk created this revision. Herald added subscribers: cfe-commits, phosek, usaxena95, kadircet, jfb, arphaman, jkorous, kbarton, nemanjai. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77458 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-change-namespace/ChangeNamespace.h clang-tools-extra/clang-doc/Generators.cpp clang-tools-extra/clang-doc/Serialize.cpp clang-tools-extra/clang-include-fixer/IncludeFixer.h clang-tools-extra/clang-include-fixer/IncludeFixerContext.h clang-tools-extra/clang-include-fixer/SymbolIndexManager.cpp clang-tools-extra/clang-include-fixer/find-all-symbols/FindAllSymbols.cpp clang-tools-extra/clang-include-fixer/find-all-symbols/tool/run-find-all-symbols.py clang-tools-extra/clang-include-fixer/tool/clang-include-fixer.py clang-tools-extra/clang-move/Move.cpp clang-tools-extra/clang-reorder-fields/ReorderFieldsAction.cpp clang-tools-extra/clang-tidy/abseil/DurationFactoryScaleCheck.cpp clang-tools-extra/clang-tidy/abseil/DurationRewriter.cpp clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/clang-tidy/bugprone/FoldInitTypeCheck.cpp clang-tools-extra/clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousMissingCommaCheck.cpp clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.h clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp clang-tools-extra/clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tools-extra/clang-tidy/modernize/UseAutoCheck.cpp clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp clang-tools-extra/clang-tidy/readability/ConstReturnTypeCheck.cpp clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp clang-tools-extra/clang-tidy/readability/IsolateDeclarationCheck.cpp clang-tools-extra/clang-tidy/readability/MakeMemberFunctionConstCheck.cpp clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/ClangdLSPServer.h clang-tools-extra/clangd/Diagnostics.cpp clang-tools-extra/clangd/FindSymbols.h clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/FindTarget.h clang-tools-extra/clangd/FormattedString.cpp clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover.h clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/clangd/PathMapping.cpp clang-tools-extra/clangd/Preamble.cpp clang-tools-extra/clangd/Quality.cpp clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tools-extra/clangd/index/Background.cpp clang-tools-extra/clangd/index/Serialization.cpp clang-tools-extra/clangd/index/SymbolOrigin.h clang-tools-extra/clangd/index/dex/Trigram.cpp clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extra/clangd/refactor/Rename.h clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp clang-tools-extra/clangd/tool/ClangdMain.cpp clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp clang-tools-extra/clangd/unittests/CollectMacrosTests.cpp clang-tools-extra/clangd/unittests/FindTargetTests.cpp clang-tools-extra/clangd/unittests/HeaderSourceSwitchTests.cpp clang-tools-extra/clangd/unittests/PathMappingTests.cpp clang-tools-extra/clangd/unittests/RenameTests.cpp clang-tools-extra/clangd/unittests/SymbolInfoTests.cpp clang-tools-extra/clangd/unittests/TweakTests.cpp clang-tools-extra/docs/clang-tidy/checks/abseil-no-internal-dependencies.rst clang-tools-extra/docs/clang-tidy/checks/bugprone-misplaced-pointer-arithmetic-in-alloc.rst clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst clang-tools-extra/docs/clang-tidy/checks/performance-inefficient-vector-operation.r
[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
kiszk added a comment. I used aspell for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77458/new/ https://reviews.llvm.org/D77458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D77470: [clang] NFC: Fix trivial typo in comments and document
kiszk created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `the the` -> `the` Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77470 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/AST/ASTStructuralEquivalence.h clang/include/clang/AST/ComparisonCategories.h clang/include/clang/AST/OpenMPClause.h clang/include/clang/ASTMatchers/ASTMatchers.h clang/include/clang/DirectoryWatcher/DirectoryWatcher.h clang/include/clang/Tooling/Transformer/RangeSelector.h clang/lib/CodeGen/CGExprScalar.cpp clang/lib/Lex/PPDirectives.cpp clang/lib/Sema/SemaAvailability.cpp Index: clang/lib/Sema/SemaAvailability.cpp === --- clang/lib/Sema/SemaAvailability.cpp +++ clang/lib/Sema/SemaAvailability.cpp @@ -57,7 +57,7 @@ /// \param D The declaration to check. /// \param Message If non-null, this will be populated with the message from /// the availability attribute that is selected. -/// \param ClassReceiver If we're checking the the method of a class message +/// \param ClassReceiver If we're checking the method of a class message /// send, the class. Otherwise nullptr. static std::pair ShouldDiagnoseAvailabilityOfDecl(Sema &S, const NamedDecl *D, Index: clang/lib/Lex/PPDirectives.cpp === --- clang/lib/Lex/PPDirectives.cpp +++ clang/lib/Lex/PPDirectives.cpp @@ -124,7 +124,7 @@ // the specified module, meaning clang won't build the specified module. This is // useful in a number of situations, for instance, when building a library that // vends a module map, one might want to avoid hitting intermediate build -// products containimg the the module map or avoid finding the system installed +// products containimg the module map or avoid finding the system installed // modulemap for that library. static bool isForModuleBuilding(Module *M, StringRef CurrentModule, StringRef ModuleName) { Index: clang/lib/CodeGen/CGExprScalar.cpp === --- clang/lib/CodeGen/CGExprScalar.cpp +++ clang/lib/CodeGen/CGExprScalar.cpp @@ -4708,7 +4708,7 @@ auto *GEP = cast(GEPVal); assert(GEP->getPointerOperand() == BasePtr && - "BasePtr must be the the base of the GEP."); + "BasePtr must be the base of the GEP."); assert(GEP->isInBounds() && "Expected inbounds GEP"); auto *IntPtrTy = DL.getIntPtrType(GEP->getPointerOperandType()); Index: clang/include/clang/Tooling/Transformer/RangeSelector.h === --- clang/include/clang/Tooling/Transformer/RangeSelector.h +++ clang/include/clang/Tooling/Transformer/RangeSelector.h @@ -40,7 +40,7 @@ /// Selects the (empty) range [B,B) when \p Selector selects the range [B,E). RangeSelector before(RangeSelector Selector); -/// Selects the the point immediately following \p Selector. That is, the +/// Selects the point immediately following \p Selector. That is, the /// (empty) range [E,E), when \p Selector selects either /// * the CharRange [B,E) or /// * the TokenRange [B,E'] where the token at E' spans the range [E,E'). Index: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h === --- clang/include/clang/DirectoryWatcher/DirectoryWatcher.h +++ clang/include/clang/DirectoryWatcher/DirectoryWatcher.h @@ -20,7 +20,7 @@ /// Provides notifications for file changes in a directory. /// /// Invokes client-provided function on every filesystem event in the watched -/// directory. Initially the the watched directory is scanned and for every file +/// directory. Initially the watched directory is scanned and for every file /// found, an event is synthesized as if the file was added. /// /// This is not a general purpose directory monitoring tool - list of Index: clang/include/clang/ASTMatchers/ASTMatchers.h === --- clang/include/clang/ASTMatchers/ASTMatchers.h +++ clang/include/clang/ASTMatchers/ASTMatchers.h @@ -303,7 +303,7 @@ /// Matches statements that are (transitively) expanded from the named macro. /// Does not match if only part of the statement is expanded from that macro or -/// if different parts of the the statement are expanded from different +/// if different parts of the statement are expanded from different /// appearances of the macro. /// /// FIXME: Change to be a polymorphic matcher that works on any syntactic Index: clang/include/clang/AST/OpenMPClause.h === --- clang/include/clang/AST/OpenMPClause.h +++ clang/include/clang/AST/OpenMPClause.h @@ -1788,13 +1788,13 @@ return IsExtended ? 2 : 0; } - /// Sets the the location of '(' in clause for 'depobj' directive. + /// Se
[PATCH] D77471: address review comment
kiszk added a comment. Sorry, I made a mistake. This should not be reviewed. This should be deleted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77471/new/ https://reviews.llvm.org/D77471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D77471: address review comment
kiszk created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. kiszk added a comment. kiszk removed a project: clang. kiszk removed a subscriber: cfe-commits. Herald added a project: clang. Sorry, I made a mistake. This should not be reviewed. This should be deleted. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77471 Files: clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp Index: clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp === --- clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp +++ clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp @@ -116,7 +116,7 @@ } if (NumConcrete > 1) { - diag(D->getBeginLoc(), "inheriting mulitple classes that aren't " + diag(D->getBeginLoc(), "inheriting multiple classes that aren't " "pure virtual is discouraged"); } } Index: clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp === --- clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp +++ clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp @@ -116,7 +116,7 @@ } if (NumConcrete > 1) { - diag(D->getBeginLoc(), "inheriting mulitple classes that aren't " + diag(D->getBeginLoc(), "inheriting multiple classes that aren't " "pure virtual is discouraged"); } } ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
kiszk updated this revision to Diff 255071. kiszk added a comment. address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77458/new/ https://reviews.llvm.org/D77458 Files: clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp Index: clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp === --- clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp +++ clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp @@ -116,7 +116,7 @@ } if (NumConcrete > 1) { - diag(D->getBeginLoc(), "inheriting mulitple classes that aren't " + diag(D->getBeginLoc(), "inheriting multiple classes that aren't " "pure virtual is discouraged"); } } Index: clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp === --- clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp +++ clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp @@ -116,7 +116,7 @@ } if (NumConcrete > 1) { - diag(D->getBeginLoc(), "inheriting mulitple classes that aren't " + diag(D->getBeginLoc(), "inheriting multiple classes that aren't " "pure virtual is discouraged"); } } ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
kiszk added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/fuchsia-multiple-inheritance.cpp:48 // Inherits from multiple concrete classes. -// CHECK-MESSAGES: [[@LINE+2]]:1: warning: inheriting mulitple classes that aren't pure virtual is discouraged [fuchsia-multiple-inheritance] +// CHECK-MESSAGES: [[@LINE+2]]:1: warning: inheriting multiple classes that aren't pure virtual is discouraged [fuchsia-multiple-inheritance] // CHECK-NEXT: class Bad_Child1 : public Base_A, Base_B {}; sammccall wrote: > Did you update the actual generated diagnostic in > clang-tidy/fuchsia/MultipleInheritanceCheck.cpp? I don't see it in this patch. Good catch. I also updated clang-tidy/fuchsia/MultipleInheritanceCheck.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77458/new/ https://reviews.llvm.org/D77458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
This revision was automatically updated to reflect the committed changes. Closed by commit rGabdd042bb7a5: [clang-tools-extra] NFC: Fix trivial typo in documents and comments (authored by kiszk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77458/new/ https://reviews.llvm.org/D77458 Files: clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp Index: clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp === --- clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp +++ clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp @@ -116,7 +116,7 @@ } if (NumConcrete > 1) { - diag(D->getBeginLoc(), "inheriting mulitple classes that aren't " + diag(D->getBeginLoc(), "inheriting multiple classes that aren't " "pure virtual is discouraged"); } } Index: clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp === --- clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp +++ clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp @@ -116,7 +116,7 @@ } if (NumConcrete > 1) { - diag(D->getBeginLoc(), "inheriting mulitple classes that aren't " + diag(D->getBeginLoc(), "inheriting multiple classes that aren't " "pure virtual is discouraged"); } } ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D77482: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
kiszk created this revision. Herald added subscribers: cfe-commits, phosek, usaxena95, kadircet, jfb, arphaman, jkorous, kbarton, nemanjai. Herald added a project: clang. This also includes the build failure due to https://reviews.llvm.org/D77458 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77482 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-change-namespace/ChangeNamespace.h clang-tools-extra/clang-doc/Generators.cpp clang-tools-extra/clang-doc/Serialize.cpp clang-tools-extra/clang-include-fixer/IncludeFixer.h clang-tools-extra/clang-include-fixer/IncludeFixerContext.h clang-tools-extra/clang-include-fixer/SymbolIndexManager.cpp clang-tools-extra/clang-include-fixer/find-all-symbols/FindAllSymbols.cpp clang-tools-extra/clang-include-fixer/find-all-symbols/tool/run-find-all-symbols.py clang-tools-extra/clang-include-fixer/tool/clang-include-fixer.py clang-tools-extra/clang-move/Move.cpp clang-tools-extra/clang-reorder-fields/ReorderFieldsAction.cpp clang-tools-extra/clang-tidy/abseil/DurationFactoryScaleCheck.cpp clang-tools-extra/clang-tidy/abseil/DurationRewriter.cpp clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/clang-tidy/bugprone/FoldInitTypeCheck.cpp clang-tools-extra/clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousMissingCommaCheck.cpp clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.h clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp clang-tools-extra/clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tools-extra/clang-tidy/modernize/UseAutoCheck.cpp clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp clang-tools-extra/clang-tidy/readability/ConstReturnTypeCheck.cpp clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp clang-tools-extra/clang-tidy/readability/IsolateDeclarationCheck.cpp clang-tools-extra/clang-tidy/readability/MakeMemberFunctionConstCheck.cpp clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/ClangdLSPServer.h clang-tools-extra/clangd/Diagnostics.cpp clang-tools-extra/clangd/FindSymbols.h clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/FindTarget.h clang-tools-extra/clangd/FormattedString.cpp clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover.h clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/clangd/PathMapping.cpp clang-tools-extra/clangd/Preamble.cpp clang-tools-extra/clangd/Quality.cpp clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tools-extra/clangd/index/Background.cpp clang-tools-extra/clangd/index/Serialization.cpp clang-tools-extra/clangd/index/SymbolOrigin.h clang-tools-extra/clangd/index/dex/Trigram.cpp clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extra/clangd/refactor/Rename.h clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp clang-tools-extra/clangd/tool/ClangdMain.cpp clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp clang-tools-extra/clangd/unittests/CollectMacrosTests.cpp clang-tools-extra/clangd/unittests/FindTargetTests.cpp clang-tools-extra/clangd/unittests/HeaderSourceSwitchTests.cpp clang-tools-extra/clangd/unittests/PathMappingTests.cpp clang-tools-extra/clangd/unittests/RenameTests.cpp clang-tools-extra/clangd/unittests/SymbolInfoTests.cpp clang-tools-extra/clangd/unittests/TweakTests.cpp clang-tools-extra/docs/clang-tidy/checks/abseil-no-internal-dependencies.rst clang-tools-extra/docs/clang-tidy/checks/bugprone-misplaced-pointer-arithmetic-in-alloc.rst clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst clang
[PATCH] D77482: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
kiszk added a subscriber: sammccall. kiszk added a comment. Herald added a subscriber: wuzish. @sammccall, I am very sorry that I led to the build break due to my misoperation in https://reviews.llvm.org/D77458 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77482/new/ https://reviews.llvm.org/D77482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D77482: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
kiszk added a comment. Thank you for letting me know. I will do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77482/new/ https://reviews.llvm.org/D77482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
kiszk updated this revision to Diff 255119. kiszk added a comment. This includes a fix to break the llvm build CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77458/new/ https://reviews.llvm.org/D77458 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-change-namespace/ChangeNamespace.h clang-tools-extra/clang-doc/Generators.cpp clang-tools-extra/clang-doc/Serialize.cpp clang-tools-extra/clang-include-fixer/IncludeFixer.h clang-tools-extra/clang-include-fixer/IncludeFixerContext.h clang-tools-extra/clang-include-fixer/SymbolIndexManager.cpp clang-tools-extra/clang-include-fixer/find-all-symbols/FindAllSymbols.cpp clang-tools-extra/clang-include-fixer/find-all-symbols/tool/run-find-all-symbols.py clang-tools-extra/clang-include-fixer/tool/clang-include-fixer.py clang-tools-extra/clang-move/Move.cpp clang-tools-extra/clang-reorder-fields/ReorderFieldsAction.cpp clang-tools-extra/clang-tidy/abseil/DurationFactoryScaleCheck.cpp clang-tools-extra/clang-tidy/abseil/DurationRewriter.cpp clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/clang-tidy/bugprone/FoldInitTypeCheck.cpp clang-tools-extra/clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousMissingCommaCheck.cpp clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.h clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp clang-tools-extra/clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tools-extra/clang-tidy/modernize/UseAutoCheck.cpp clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp clang-tools-extra/clang-tidy/readability/ConstReturnTypeCheck.cpp clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp clang-tools-extra/clang-tidy/readability/IsolateDeclarationCheck.cpp clang-tools-extra/clang-tidy/readability/MakeMemberFunctionConstCheck.cpp clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/ClangdLSPServer.h clang-tools-extra/clangd/Diagnostics.cpp clang-tools-extra/clangd/FindSymbols.h clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/FindTarget.h clang-tools-extra/clangd/FormattedString.cpp clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover.h clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/clangd/PathMapping.cpp clang-tools-extra/clangd/Preamble.cpp clang-tools-extra/clangd/Quality.cpp clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tools-extra/clangd/index/Background.cpp clang-tools-extra/clangd/index/Serialization.cpp clang-tools-extra/clangd/index/SymbolOrigin.h clang-tools-extra/clangd/index/dex/Trigram.cpp clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extra/clangd/refactor/Rename.h clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp clang-tools-extra/clangd/tool/ClangdMain.cpp clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp clang-tools-extra/clangd/unittests/CollectMacrosTests.cpp clang-tools-extra/clangd/unittests/FindTargetTests.cpp clang-tools-extra/clangd/unittests/HeaderSourceSwitchTests.cpp clang-tools-extra/clangd/unittests/PathMappingTests.cpp clang-tools-extra/clangd/unittests/RenameTests.cpp clang-tools-extra/clangd/unittests/SymbolInfoTests.cpp clang-tools-extra/clangd/unittests/TweakTests.cpp clang-tools-extra/docs/clang-tidy/checks/abseil-no-internal-dependencies.rst clang-tools-extra/docs/clang-tidy/checks/bugprone-misplaced-pointer-arithmetic-in-alloc.rst clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst clang-tools-extra/docs/clang-tidy/checks/performance-inefficient-vector-operation.rst clang-tools-extra/docs/cla
[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
kiszk updated this revision to Diff 255120. kiszk added a comment. This include the fix of the build failure at http://lab.llvm.org:8011/builders/clang-cmake-armv7-global-isel/builds/7450/steps/ninja%20check%201/logs/FAIL%3A%20Clang%20Tools%3A%3Afuchsia-multiple-inheritance.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77458/new/ https://reviews.llvm.org/D77458 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-change-namespace/ChangeNamespace.h clang-tools-extra/clang-doc/Generators.cpp clang-tools-extra/clang-doc/Serialize.cpp clang-tools-extra/clang-include-fixer/IncludeFixer.h clang-tools-extra/clang-include-fixer/IncludeFixerContext.h clang-tools-extra/clang-include-fixer/SymbolIndexManager.cpp clang-tools-extra/clang-include-fixer/find-all-symbols/FindAllSymbols.cpp clang-tools-extra/clang-include-fixer/find-all-symbols/tool/run-find-all-symbols.py clang-tools-extra/clang-include-fixer/tool/clang-include-fixer.py clang-tools-extra/clang-move/Move.cpp clang-tools-extra/clang-reorder-fields/ReorderFieldsAction.cpp clang-tools-extra/clang-tidy/abseil/DurationFactoryScaleCheck.cpp clang-tools-extra/clang-tidy/abseil/DurationRewriter.cpp clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/clang-tidy/bugprone/FoldInitTypeCheck.cpp clang-tools-extra/clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousMissingCommaCheck.cpp clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.h clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp clang-tools-extra/clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tools-extra/clang-tidy/modernize/UseAutoCheck.cpp clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp clang-tools-extra/clang-tidy/readability/ConstReturnTypeCheck.cpp clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp clang-tools-extra/clang-tidy/readability/IsolateDeclarationCheck.cpp clang-tools-extra/clang-tidy/readability/MakeMemberFunctionConstCheck.cpp clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/ClangdLSPServer.h clang-tools-extra/clangd/Diagnostics.cpp clang-tools-extra/clangd/FindSymbols.h clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/FindTarget.h clang-tools-extra/clangd/FormattedString.cpp clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover.h clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/clangd/PathMapping.cpp clang-tools-extra/clangd/Preamble.cpp clang-tools-extra/clangd/Quality.cpp clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tools-extra/clangd/index/Background.cpp clang-tools-extra/clangd/index/Serialization.cpp clang-tools-extra/clangd/index/SymbolOrigin.h clang-tools-extra/clangd/index/dex/Trigram.cpp clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extra/clangd/refactor/Rename.h clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp clang-tools-extra/clangd/tool/ClangdMain.cpp clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp clang-tools-extra/clangd/unittests/CollectMacrosTests.cpp clang-tools-extra/clangd/unittests/FindTargetTests.cpp clang-tools-extra/clangd/unittests/HeaderSourceSwitchTests.cpp clang-tools-extra/clangd/unittests/PathMappingTests.cpp clang-tools-extra/clangd/unittests/RenameTests.cpp clang-tools-extra/clangd/unittests/SymbolInfoTests.cpp clang-tools-extra/clangd/unittests/TweakTests.cpp clang-tools-extra/docs/clang-tidy/checks/bugprone-misplaced-pointer-arithmetic-in-alloc.rst clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst clang-tools-extra/docs/cl
[PATCH] D77482: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
kiszk added a comment. I have done in https://reviews.llvm.org/D77458 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77482/new/ https://reviews.llvm.org/D77482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D72087: NFC: Fix trivial typos in comments
kiszk created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. "the the" -> "the" "an" -> "a" Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72087 Files: clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.h clang-tools-extra/clang-tidy/modernize/ReplaceAutoPtrCheck.cpp clang-tools-extra/clangd/CodeComplete.h clang-tools-extra/clangd/unittests/TweakTests.cpp clang-tools-extra/docs/doxygen.cfg.in Index: clang-tools-extra/docs/doxygen.cfg.in === --- clang-tools-extra/docs/doxygen.cfg.in +++ clang-tools-extra/docs/doxygen.cfg.in @@ -46,7 +46,7 @@ PROJECT_BRIEF = -# With the PROJECT_LOGO tag one can specify an logo or icon that is included in +# With the PROJECT_LOGO tag one can specify a logo or icon that is included in # the documentation. The maximum height of the logo should not exceed 55 pixels # and the maximum width should not exceed 200 pixels. Doxygen will copy the logo # to the output directory. Index: clang-tools-extra/clangd/unittests/TweakTests.cpp === --- clang-tools-extra/clangd/unittests/TweakTests.cpp +++ clang-tools-extra/clangd/unittests/TweakTests.cpp @@ -127,7 +127,7 @@ ExtraArgs.push_back("-x"); ExtraArgs.push_back("objective-c"); - // Ensure the the action can be initiated in the string literal. + // Ensure the action can be initiated in the string literal. EXPECT_AVAILABLE(R"(id x = ^[[@[[^"^t^est^";)"); // Ensure that the action can't be initiated in other places. Index: clang-tools-extra/clangd/CodeComplete.h === --- clang-tools-extra/clangd/CodeComplete.h +++ clang-tools-extra/clangd/CodeComplete.h @@ -61,7 +61,7 @@ bool IncludeIneligibleResults = false; /// Combine overloads into a single completion item where possible. - /// If none, the the implementation may choose an appropriate behavior. + /// If none, the implementation may choose an appropriate behavior. /// (In practice, ClangdLSPServer enables bundling if the client claims /// to supports signature help). llvm::Optional BundleOverloads; Index: clang-tools-extra/clang-tidy/modernize/ReplaceAutoPtrCheck.cpp === --- clang-tools-extra/clang-tidy/modernize/ReplaceAutoPtrCheck.cpp +++ clang-tools-extra/clang-tidy/modernize/ReplaceAutoPtrCheck.cpp @@ -114,7 +114,7 @@ this); // Find ownership transfers via copy construction and assignment. - // AutoPtrOwnershipTransferId is bound to the the part that has to be wrapped + // AutoPtrOwnershipTransferId is bound to the part that has to be wrapped // into std::move(). // std::auto_ptr i, j; // i = j; Index: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.h === --- clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.h +++ clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.h @@ -145,7 +145,7 @@ /// /// In order to avoid this, this class looks at the container expression /// `arr[k]` and decides whether or not it contains a sub-expression declared - /// within the the loop body. + /// within the loop body. bool dependsOnInsideVariable(const clang::Stmt *Body) { DependsOnInsideVariable = false; TraverseStmt(const_cast(Body)); Index: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp === --- clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp +++ clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp @@ -867,7 +867,7 @@ return OldIndex->getName(); } -/// Determines whether or not the the name \a Symbol conflicts with +/// Determines whether or not the name \a Symbol conflicts with /// language keywords or defined macros. Also checks if the name exists in /// LoopContext, any of its parent contexts, or any of its child statements. /// Index: clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp === --- clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp +++ clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp @@ -393,7 +393,7 @@ } // If the destination array is the same length as the given length we have to -// increase the capacity by one to create space for the the null terminator. +// increase the capacity by one to create space for the null terminator. static bool isDestCapacityFix(const MatchFinder::MatchResult &Result, DiagnosticBuilder &Diag) {
[PATCH] D72087: [clang-tools-extra] NFC: Fix trivial typos in comments
kiszk added a comment. I do not have commit rights to the repository. Could someone commit this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72087/new/ https://reviews.llvm.org/D72087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D72140: [clang-tools-extra] NFC: Fix trivial typos in comments
kiszk created this revision. Herald added subscribers: cfe-commits, usaxena95, jsji, kadircet, arphaman, jkorous, javed.absar, kbarton, nemanjai. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72140 Files: clang-tools-extra/clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp clang-tools-extra/clang-doc/BitcodeReader.h clang-tools-extra/clang-doc/Representation.h clang-tools-extra/clang-doc/Serialize.cpp clang-tools-extra/clang-doc/tool/ClangDocMain.cpp clang-tools-extra/clang-include-fixer/IncludeFixerContext.cpp clang-tools-extra/clang-include-fixer/tool/clang-include-fixer.el clang-tools-extra/clang-move/tool/ClangMove.cpp clang-tools-extra/clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp clang-tools-extra/clang-tidy/bugprone/ForwardDeclarationNamespaceCheck.cpp clang-tools-extra/clang-tidy/bugprone/StringLiteralWithEmbeddedNulCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/SlicingCheck.cpp clang-tools-extra/clang-tidy/google/GlobalNamesInHeadersCheck.cpp clang-tools-extra/clang-tidy/google/IntegerTypesCheck.h clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tools-extra/clang-tidy/modernize/UseAutoCheck.cpp clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp clang-tools-extra/clang-tidy/performance/InefficientAlgorithmCheck.h clang-tools-extra/clang-tidy/performance/InefficientVectorOperationCheck.cpp clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.h clang-tools-extra/clang-tidy/utils/NamespaceAliaser.cpp clang-tools-extra/clangd/AST.h clang-tools-extra/clangd/ClangdLSPServer.h clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clangd/Context.h clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/IncludeFixer.cpp clang-tools-extra/clangd/ParsedAST.h clang-tools-extra/clangd/Protocol.h clang-tools-extra/clangd/SemanticHighlighting.h clang-tools-extra/clangd/TUScheduler.h clang-tools-extra/clangd/Trace.h clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts clang-tools-extra/clangd/index/CanonicalIncludes.cpp clang-tools-extra/clangd/index/Symbol.h clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp clang-tools-extra/clangd/unittests/RenameTests.cpp clang-tools-extra/clangd/unittests/SymbolInfoTests.cpp clang-tools-extra/clangd/unittests/SyncAPI.cpp clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp clang-tools-extra/clangd/unittests/TweakTests.cpp clang-tools-extra/clangd/unittests/TypeHierarchyTests.cpp clang-tools-extra/clangd/unittests/XRefsTests.cpp clang-tools-extra/docs/clang-tidy/checks/bugprone-branch-clone.rst clang-tools-extra/docs/clang-tidy/checks/cert-mem57-cpp.rst clang-tools-extra/docs/clang-tidy/checks/hicpp-undelegated-constructor.rst clang-tools-extra/docs/clang-tidy/checks/readability-identifier-naming.rst clang-tools-extra/modularize/Modularize.cpp clang-tools-extra/modularize/PreprocessorTracker.cpp clang-tools-extra/pp-trace/PPCallbacksTracker.cpp clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-no-malloc-custom.cpp clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-no-malloc.cpp clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-owning-memory-containers.cpp clang-tools-extra/test/clang-tidy/checkers/modernize-make-unique.cpp clang-tools-extra/test/clang-tidy/checkers/modernize-use-nullptr-basic.cpp clang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-value-param-arc.m clang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-value-param-arc.mm clang-tools-extra/test/clang-tidy/checkers/readability-redundant-declaration.cpp clang-tools-extra/unittests/clang-include-fixer/find-all-symbols/FindAllSymbolsTests.cpp Index: clang-tools-extra/unittests/clang-include-fixer/find-all-symbols/FindAllSymbolsTests.cpp === --- clang-tools-extra/unittests/clang-include-fixer/find-all-symbols/FindAllSymbolsTests.cpp +++ clang-tools-extra/unittests/clang-include-fixer/find-all-symbols/FindAllSymbolsTests.cpp @@ -198,8 +198,8 @@ TEST_F(FindAllSymbolsTest, CXXRecordSymbols) { static const char Header[] = R"( struct Glob {}; - struct A; // Not a defintion, ignored. - class NOP; // Not a defintion, ignored + struct A; // Not a definition, ignored. + cl
[PATCH] D72140: [clang-tools-extra] NFC: Fix trivial typos in comments
kiszk updated this revision to Diff 236069. kiszk added a comment. Rebase with master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72140/new/ https://reviews.llvm.org/D72140 Files: clang-tools-extra/clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp clang-tools-extra/clang-doc/BitcodeReader.h clang-tools-extra/clang-doc/Representation.h clang-tools-extra/clang-doc/Serialize.cpp clang-tools-extra/clang-doc/tool/ClangDocMain.cpp clang-tools-extra/clang-include-fixer/IncludeFixerContext.cpp clang-tools-extra/clang-include-fixer/tool/clang-include-fixer.el clang-tools-extra/clang-move/tool/ClangMove.cpp clang-tools-extra/clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp clang-tools-extra/clang-tidy/bugprone/ForwardDeclarationNamespaceCheck.cpp clang-tools-extra/clang-tidy/bugprone/StringLiteralWithEmbeddedNulCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/SlicingCheck.cpp clang-tools-extra/clang-tidy/google/GlobalNamesInHeadersCheck.cpp clang-tools-extra/clang-tidy/google/IntegerTypesCheck.h clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tools-extra/clang-tidy/modernize/UseAutoCheck.cpp clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp clang-tools-extra/clang-tidy/performance/InefficientAlgorithmCheck.h clang-tools-extra/clang-tidy/performance/InefficientVectorOperationCheck.cpp clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.h clang-tools-extra/clang-tidy/utils/NamespaceAliaser.cpp clang-tools-extra/clangd/AST.h clang-tools-extra/clangd/ClangdLSPServer.h clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clangd/Context.h clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/IncludeFixer.cpp clang-tools-extra/clangd/ParsedAST.h clang-tools-extra/clangd/Protocol.h clang-tools-extra/clangd/SemanticHighlighting.h clang-tools-extra/clangd/TUScheduler.h clang-tools-extra/clangd/Trace.h clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts clang-tools-extra/clangd/index/CanonicalIncludes.cpp clang-tools-extra/clangd/index/Symbol.h clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp clang-tools-extra/clangd/unittests/RenameTests.cpp clang-tools-extra/clangd/unittests/SymbolInfoTests.cpp clang-tools-extra/clangd/unittests/SyncAPI.cpp clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp clang-tools-extra/clangd/unittests/TweakTests.cpp clang-tools-extra/clangd/unittests/TypeHierarchyTests.cpp clang-tools-extra/clangd/unittests/XRefsTests.cpp clang-tools-extra/docs/clang-tidy/checks/bugprone-branch-clone.rst clang-tools-extra/docs/clang-tidy/checks/cert-mem57-cpp.rst clang-tools-extra/docs/clang-tidy/checks/hicpp-undelegated-constructor.rst clang-tools-extra/docs/clang-tidy/checks/readability-identifier-naming.rst clang-tools-extra/modularize/Modularize.cpp clang-tools-extra/modularize/PreprocessorTracker.cpp clang-tools-extra/pp-trace/PPCallbacksTracker.cpp clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-no-malloc-custom.cpp clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-no-malloc.cpp clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-owning-memory-containers.cpp clang-tools-extra/test/clang-tidy/checkers/modernize-make-unique.cpp clang-tools-extra/test/clang-tidy/checkers/modernize-use-nullptr-basic.cpp clang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-value-param-arc.m clang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-value-param-arc.mm clang-tools-extra/test/clang-tidy/checkers/readability-redundant-declaration.cpp clang-tools-extra/unittests/clang-include-fixer/find-all-symbols/FindAllSymbolsTests.cpp Index: clang-tools-extra/unittests/clang-include-fixer/find-all-symbols/FindAllSymbolsTests.cpp === --- clang-tools-extra/unittests/clang-include-fixer/find-all-symbols/FindAllSymbolsTests.cpp +++ clang-tools-extra/unittests/clang-include-fixer/find-all-symbols/FindAllSymbolsTests.cpp @@ -198,8 +198,8 @@ TEST_F(FindAllSymbolsTest, CXXRecordSymbols) { static const char Header[] = R"( struct Glob {}; - struct A; // Not a defintion, ignored. - class NOP; // Not a defintion, ignored + struct A; // Not a definition, ignored. + class NOP; // Not a defini
[PATCH] D72140: [clang-tools-extra] NFC: Fix trivial typos in comments
kiszk added a comment. I do not have commit rights to the repository. Could someone commit this change if it is OK? Kazuaki Ishizaki Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72140/new/ https://reviews.llvm.org/D72140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D77470: [clang] NFC: Fix trivial typo in comments and document
kiszk added a comment. Thank you very much at https://github.com/llvm/llvm-project/commit/8f77dc459e31aad6daab89a124fa92067916274c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77470/new/ https://reviews.llvm.org/D77470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits