Re: [llvm-dev] Phabricator Creator Pulling the Plug
On 9/30/21 4:15 PM, Mehdi AMINI via llvm-dev wrote: > On Thu, Sep 30, 2021 at 4:09 PM Brian Cain wrote: >> >> >> >> On Thu, Sep 30, 2021, 6:04 PM Brian Cain wrote: >>> >>> Does something like Rust's "bors" bot satisfy the herald rules need? >> >> >> >> sorry, maybe I was thinking of the high-five bot. And it looks like that's >> not quite a match for herald. > > Actually high-five may be a good starting point! > In practice it may still be a bit limited by the GitHub integration: > for example I suspect you may not be able to "subscribe" someone to a > pull-request? > Also what the user will receive as an email may be quite unhelpful > (you have been subscribed to "" instead of the > current more comprehensive emails). You can configure path-based "mentions" like these: https://github.com/rust-lang/highfive/blob/6e2c21639aaeafaeae423b244d353247c507d46a/highfive/configs/rust-lang/rust.json#L129 It will mention those users in a comment, which subscribes them, like: https://github.com/rust-lang/rust/pull/89266#issuecomment-927275025 That one demonstrates both an individual and an org team, and note that people can choose whether their team membership is publicly visible. ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [llvm-dev] Phabricator Creator Pulling the Plug
On 10/1/21 2:59 PM, Josh Stone wrote: > On 9/30/21 4:15 PM, Mehdi AMINI via llvm-dev wrote: >> On Thu, Sep 30, 2021 at 4:09 PM Brian Cain wrote: >>> >>> >>> >>> On Thu, Sep 30, 2021, 6:04 PM Brian Cain wrote: Does something like Rust's "bors" bot satisfy the herald rules need? >>> >>> >>> >>> sorry, maybe I was thinking of the high-five bot. And it looks like that's >>> not quite a match for herald. >> >> Actually high-five may be a good starting point! >> In practice it may still be a bit limited by the GitHub integration: >> for example I suspect you may not be able to "subscribe" someone to a >> pull-request? >> Also what the user will receive as an email may be quite unhelpful >> (you have been subscribed to "" instead of the >> current more comprehensive emails). > > You can configure path-based "mentions" like these: > https://github.com/rust-lang/highfive/blob/6e2c21639aaeafaeae423b244d353247c507d46a/highfive/configs/rust-lang/rust.json#L129 > > It will mention those users in a comment, which subscribes them, like: > https://github.com/rust-lang/rust/pull/89266#issuecomment-927275025 > > That one demonstrates both an individual and an org team, and note that > people can choose whether their team membership is publicly visible. Hmm, maybe you can only choose your org visibility, not each team. ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 700ca0e - [NFC] Red Hat is two words
Author: Josh Stone
Date: 2023-08-14T10:10:10-07:00
New Revision: 700ca0e7432d4ef485900f16d9f051e2bbc8523c
URL:
https://github.com/llvm/llvm-project/commit/700ca0e7432d4ef485900f16d9f051e2bbc8523c
DIFF:
https://github.com/llvm/llvm-project/commit/700ca0e7432d4ef485900f16d9f051e2bbc8523c.diff
LOG: [NFC] Red Hat is two words
Added:
Modified:
clang/lib/Driver/Distro.cpp
llvm/docs/Security.rst
Removed:
diff --git a/clang/lib/Driver/Distro.cpp b/clang/lib/Driver/Distro.cpp
index 6e0087565941ea..005c31bd38893c 100644
--- a/clang/lib/Driver/Distro.cpp
+++ b/clang/lib/Driver/Distro.cpp
@@ -112,7 +112,7 @@ static Distro::DistroType
DetectDistro(llvm::vfs::FileSystem &VFS) {
if (Version != Distro::UnknownDistro)
return Version;
- // Otherwise try some distro-specific quirks for RedHat...
+ // Otherwise try some distro-specific quirks for Red Hat...
llvm::ErrorOr> File =
VFS.getBufferForFile("/etc/redhat-release");
diff --git a/llvm/docs/Security.rst b/llvm/docs/Security.rst
index 11acac33f0a19f..2729541facbfe6 100644
--- a/llvm/docs/Security.rst
+++ b/llvm/docs/Security.rst
@@ -40,7 +40,7 @@ The members of the group represent a wide cross-section of
the community, and me
* Dimitry Andric (individual; FreeBSD) [dim]
* Ed Maste (individual; FreeBSD) [emaste]
* George Burgess IV (Google) [george.burgess.iv]
-* Josh Stone (RedHat; Rust) [cuviper]
+* Josh Stone (Red Hat; Rust) [cuviper]
* Kate McInnes (Apple) []
* Kristof Beyls (ARM) [kristof.beyls]
* Matthew Riley (Google) [mattdr]
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
