joaotavora added a comment.
In https://reviews.llvm.org/D50571#1206020, @arphaman wrote:
> In https://reviews.llvm.org/D50571#1205650, @joaotavora wrote:
>
> > > LGTM. Let's watch out for possible breakages in any of the clients,
> > > though. I've checked VSCode and it seems to be fine with the added fields.
> >
> > This isn't in the spec and broke the LSP client eglot
> > (https://github.com/joaotavora/eglot/pull/81). Why don't you put this in
> > the "source" field, or concat it to the "message" field. Who can even use
> > this information if it's not in the spec? Are clients supposed to code
> > against every LSP server's whim?
>
>
> Thanks for the feedback. I'll make a patch that turns this off by default so
> that clients can opt-in into it.
Thank you very much, and sorry if I came across a bit hostile. What is this
category field good for?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits