[clang-tools-extra] [clangd] Support outgoing calls in call hierarchy (PR #77556)

[Igor V. Kovalenko via cfe-commits]

@@ -1700,6 +1700,7 @@ declToHierarchyItem(const NamedDecl &ND, llvm::StringRef 
TUPath) {
 
   HierarchyItem HI;
   HI.name = printName(Ctx, ND);
+  // FIXME: Populate HI.detail the way we do in symbolToHierarchyItem?

i-garrison wrote:

I see. Ideally there should be some recommended use model for `c++` which call 
hierarchy clients/visualisers (e.g. lsp4e) could implement to show expected 
function signatures. Like "obtain details field from call hierarchy item and 
use it as function signature" and then lsp4e could append details to name. We 
probably can later tune xrefs.cpp implementation to provide required details 
where needed. Note that function return value is still not available, and as 
far as I can see there is no place in protocol to put it in.

https://github.com/llvm/llvm-project/pull/77556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Support outgoing calls in call hierarchy (PR #77556)

[Igor V. Kovalenko via cfe-commits]

https://github.com/i-garrison edited 
https://github.com/llvm/llvm-project/pull/77556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Support outgoing calls in call hierarchy (PR #77556)

[Igor V. Kovalenko via cfe-commits]

@@ -1751,6 +1752,7 @@ static std::optional 
symbolToHierarchyItem(const Symbol &S,
   }
   HierarchyItem HI;
   HI.name = std::string(S.Name);
+  HI.detail = (S.Scope + S.Name).str();

i-garrison wrote:

adding signature looks a bit more helpful, maybe one day add return type info 
too
```suggestion
  HI.detail = (S.Scope + S.Name + S.Signature).str();
```

https://github.com/llvm/llvm-project/pull/77556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Support outgoing calls in call hierarchy (PR #77556)

[Igor V. Kovalenko via cfe-commits]

@@ -1700,6 +1700,7 @@ declToHierarchyItem(const NamedDecl &ND, llvm::StringRef 
TUPath) {
 
   HierarchyItem HI;
   HI.name = printName(Ctx, ND);
+  // FIXME: Populate HI.detail the way we do in symbolToHierarchyItem?

i-garrison wrote:

is this the place which covers c++ constructors?

https://github.com/llvm/llvm-project/pull/77556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits